From b9f6f140035e775f7f12690ef3fca930529067bf Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Mon, 16 Feb 2026 17:30:37 +0100 Subject: [PATCH] don't explicitly specify defaults in argument parsing --- internal/command/arguments/state_mv.go | 4 +-- internal/command/arguments/state_mv_test.go | 31 ++++++++------------- 2 files changed, 12 insertions(+), 23 deletions(-) diff --git a/internal/command/arguments/state_mv.go b/internal/command/arguments/state_mv.go index 146f3d8a26..a7b4446cef 100644 --- a/internal/command/arguments/state_mv.go +++ b/internal/command/arguments/state_mv.go @@ -51,9 +51,7 @@ type StateMv struct { // representing the best effort interpretation of the arguments. func ParseStateMv(args []string) (*StateMv, tfdiags.Diagnostics) { var diags tfdiags.Diagnostics - mv := &StateMv{ - StateLock: true, - } + mv := &StateMv{} cmdFlags := defaultFlagSet("state mv") cmdFlags.BoolVar(&mv.DryRun, "dry-run", false, "dry run") diff --git a/internal/command/arguments/state_mv_test.go b/internal/command/arguments/state_mv_test.go index acaad320df..49af874f28 100644 --- a/internal/command/arguments/state_mv_test.go +++ b/internal/command/arguments/state_mv_test.go @@ -18,31 +18,22 @@ func TestParseStateMv_valid(t *testing.T) { "addresses only": { []string{"test_instance.foo", "test_instance.bar"}, &StateMv{ - DryRun: false, - BackupPath: "-", - BackupOutPath: "-", - StateLock: true, - StateLockTimeout: 0, - StatePath: "", - StateOutPath: "", - IgnoreRemoteVersion: false, - SourceAddr: "test_instance.foo", - DestAddr: "test_instance.bar", + BackupPath: "-", + BackupOutPath: "-", + StateLock: true, + SourceAddr: "test_instance.foo", + DestAddr: "test_instance.bar", }, }, "dry run": { []string{"-dry-run", "test_instance.foo", "test_instance.bar"}, &StateMv{ - DryRun: true, - BackupPath: "-", - BackupOutPath: "-", - StateLock: true, - StateLockTimeout: 0, - StatePath: "", - StateOutPath: "", - IgnoreRemoteVersion: false, - SourceAddr: "test_instance.foo", - DestAddr: "test_instance.bar", + DryRun: true, + BackupPath: "-", + BackupOutPath: "-", + StateLock: true, + SourceAddr: "test_instance.foo", + DestAddr: "test_instance.bar", }, }, "all options": {