proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	efe0d4fe61	Add extensive doxygen documentation for vacuum_stats and stats_pgsql_stat_activity This commit documents: 1. The vacuum_stats() function's purpose, behavior, and the reason why stats_pgsql_stat_activity is excluded from bulk deletion operations 2. The fact that stats_pgsql_stat_activity is a SQL VIEW (not a table) and attempting DELETE on it would cause SQLite error: "cannot modify stats_pgsql_stat_activity because it is a view" The documentation explains: - Why TRUNCATE stats_mysql_query_digest triggers vacuum_stats(true) - Why both MySQL and PostgreSQL tables are cleared regardless of protocol - How the view is automatically cleared via its underlying table stats_pgsql_processlist - The importance of keeping the view excluded from deletion lists	4 months ago
Rene Cannao	de214cb558	Add comprehensive documentation for "Closing killed client connection" warnings	4 months ago
Rene Cannao	6966b79db9	Add documentation for query rules capture groups and backreferences	4 months ago
René Cannaò	6ee087c73c	Merge pull request #5250 from sysown/v3.0-issue5248 Fix cache_empty_result=0 not caching non-empty resultsets (issue #5248)	4 months ago
René Cannaò	fd6cd76b7f	Merge pull request #5251 from sysown/v3.0-set_testing_version Add comments to select @@version queries to bypass ProxySQL interception	4 months ago
Rene Cannao	66119b74fb	Add comments to select @@version queries to bypass ProxySQL interception ProxySQL now responds directly to `select @@version` queries, which prevents these queries from reaching the backend MySQL server. This commit adds `/* set_testing */` comments to these queries in test files to prevent perfect match interception and allow them to run on the backend. Modified files: - test/tap/tap/utils.cpp - test/tap/tests/set_testing-240.h - test/tap/tests/set_testing.h - test/tap/tests/test_firewall-t.cpp	4 months ago
Rene Cannao	2987242d4f	Fix cache_empty_result=0 not caching non-empty resultsets (issue #5248 ) The `cache_empty_result` field in query rules has three possible values: • -1: Use global setting (`query_cache_stores_empty_result`) • 0: Do NOT cache empty resultsets, but cache non-empty resultsets • 1: Always cache resultsets (both empty and non-empty) Previously, when `cache_empty_result` was set to 0, nothing was cached at all, even for non-empty resultsets. This prevented users from disabling caching for empty resultsets while still allowing caching of non-empty resultsets on a per-rule basis. Changes: 1. Modified caching logic in MySQL_Session.cpp and PgSQL_Session.cpp to add the condition `(qpo->cache_empty_result == 0 && MyRS->num_rows)` (MySQL) and `(qpo->cache_empty_result == 0 && num_rows)` (PgSQL) to allow caching when cache_empty_result=0 AND result has rows. 2. Added comprehensive Doxygen documentation in query_processor.h explaining the semantics of cache_empty_result values. 3. Updated Query_Processor.cpp with inline comments explaining the three possible values. Now when cache_empty_result is set to 0: - Empty resultsets (0 rows) are NOT cached - Non-empty resultsets (>0 rows) ARE cached - This matches the intended per-rule behavior described in issue #5248. Fixes: https://github.com/sysown/proxysql/issues/5248	4 months ago
René Cannaò	5a314d2364	Merge pull request #4889 from sysown/v3.0_get_server_version Added handling of SELECT @@version and SELECT VERSION() without backend	4 months ago
René Cannaò	8cf3e59ead	Merge pull request #5247 from sysown/v3.0-issue5246 Fix: Automatic prefix stripping for mysql_variables, pgsql_variables, and admin_variables config parsing	4 months ago
Rene Cannao	0b2bc1bf22	Fix SQL injection vulnerability in Read_Global_Variables_from_configfile Replace sprintf-based SQL query construction with prepared statements using bound parameters to prevent SQL injection attacks. This addresses the security issue identified in PR #5247 review. Changes: - Use SQLite prepared statement with placeholders ?1, ?2 - Bind variable names and values securely using proxy_sqlite3_bind_text - Use ASSERT_SQLITE_OK for error handling as per ProxySQL conventions - Remove malloc/sprintf vulnerable code pattern - Add necessary includes for SQLite functions and ASSERT_SQLITE_OK macro Security: SQL injection could have occurred if configuration variable names or values contained malicious quotes. Prepared statements eliminate this risk.	4 months ago
Rene Cannao	a206828609	Add test_load_from_config_prefix_stripping-t to test groups Adds the new prefix stripping validation test to the default-g4 test group along with mysql-auto_increment_delay_multiplex=0-g4, mysql-multiplexing=false-g4, mysql-query_digests=0-g4, and mysql-query_digests_keep_comment=1-g4 groups. This ensures the test is run as part of the regular test suite.	4 months ago
René Cannaò	87026c049d	Merge pull request #5245 from sysown/v3.0-issue5244 Permanent FF sessions + check_data_flow docs	4 months ago
Rene Cannao	6c97d3d244	Add extensive Doxygen documentation for ProxySQL_Config and Read_Global_Variables_from_configfile This commit adds detailed Doxygen documentation for: 1. The ProxySQL_Config class - describes its role in configuration management 2. The Read_Global_Variables_from_configfile() method - documents its behavior, parameters, return value, and the automatic prefix stripping feature The documentation explains the automatic prefix stripping behavior that handles cases where users mistakenly include module prefix (e.g., "mysql-") in variable names within configuration files.	4 months ago
Rene Cannao	7ebdf561ca	Fix automatic prefix stripping to work with libconfig lookup The previous implementation stripped the prefix before calling group.lookupValue(), which would fail because the config file contains the prefixed name (e.g., "mysql-log_unhealthy_connections"). The lookup must use the original name from the config file. This commit moves the prefix stripping logic to after the value lookup but before constructing the SQL query, ensuring both: 1. The correct value is retrieved from the config using the original prefixed name 2. The variable is stored in the database with a single prefix Also includes a test to verify the fix works for mysql_variables, pgsql_variables, and admin_variables sections.	4 months ago
Rene Cannao	b4683569d6	Add automatic prefix stripping for mysql_variables, pgsql_variables, and admin_variables config parsing When users mistakenly include the module prefix (e.g., mysql-log_unhealthy_connections) in the mysql_variables section, the variable gets stored with a double prefix (e.g., mysql-mysql-log_unhealthy_connections). This fix automatically strips the prefix if present, ensuring variables are stored correctly. The same logic applies to pgsql_variables (pgsql-) and admin_variables (admin-). Fixes #5246	4 months ago
Rene Cannao	ec1247f2a9	Add Doxygen docs for MySQL_Data_Stream::check_data_flow()	4 months ago
Rene Cannao	4044a40794	Skip bidirectional data check for permanent fast-forward sessions Allow permanent fast-forward sessions (SESSION_FORWARD_TYPE_PERMANENT) to continue processing when bidirectional data flow is detected, instead of treating it as a fatal error. This prevents unnecessary session termination in these specific cases while maintaining the original strict validation for all other session types.	4 months ago
Rene Cannao	689bece9ab	Add CONTRIBUTING.md guide for community contributors - Comprehensive contribution guidelines for ProxySQL - Includes development setup, coding standards, and PR guidelines - Provides clear instructions for bug reports and feature requests	4 months ago
René Cannaò	b73160ef5f	Merge pull request #4901 from sysown/v3.0_wait_timeout [WIP] Setting client side wait_timeout	5 months ago
René Cannaò	0d55ab5ea2	Merge branch 'v3.0' into v3.0_get_server_version Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
Rene Cannao	2b900b3465	Update test groups configuration	5 months ago
Rene Cannao	5a7b22181f	Fix metrics collection for wait_timeout counters The get_status_variable() function was only scanning worker threads but ignoring auxiliary threads (idle threads) where timeout terminations are detected. This caused the timeout termination counter to show incorrect/zero values. - Added idle thread scanning to both overloaded versions of get_status_variable() function - Now properly collects metrics from both worker and idle threads - Fixes the issue where proxysql_mysql_timeout_terminated_connections_total showed zero despite actual timeout terminations Resolves the metrics reading issue identified in the previous commits.	5 months ago
René Cannaò	65dbe904f0	Merge pull request #5199 from sysown/v3.0_refactor_monitoring_ping Fix artificially high ping latency in MySQL backend monitoring	5 months ago
Rene Cannao	fbf5f2d762	Improve wait_timeout warning messages with detailed connection information Enhance logging clarity: - Replace generic IP address with detailed connection info including IP and port - Use client_myds->addr.addr and client_myds->addr.port for precise identification - Improve debuggability of timeout clamping and enforcement warnings The warning messages now provide complete connection details, making it easier to identify and troubleshoot timeout-related issues in ProxySQL logs.	5 months ago
Rene Cannao	dc4694d656	Refactor idle session scanning and improve test precision Code improvements: - Extract SESS_TO_SCAN_idle_thread constant to header file for better maintainability - Replace magic number 128 with named constant in idle_thread_to_kill_idle_sessions() - Improve code readability and consistency in session scanning logic Test enhancements: - Add mysql-poll_timeout configuration for more precise timeout testing - Reduce test sleep times to 13 seconds for faster test execution - Add diagnostic messages to clearly show timeout configurations in test output - Ensure tests properly validate timeout enforcement with precise timing The changes improve code maintainability and make tests more reliable and faster while maintaining accurate timeout validation.	5 months ago
Rene Cannao	0c5e75a064	Fix wait_timeout timeout calculations and add proper newline characters Key improvements: - Fix timeout comparison in MySQL_Thread::idle_thread_to_kill_idle_sessions() to prevent underflow - Use effective wait_timeout (minimum of global and session values) for idle timeout calculations - Add proper newline characters to proxy_warning messages for consistent log formatting - Increase test sleep times to account for global timeout enforcement - Fix session timeout test durations to properly test timeout behavior Technical changes: - Replace broken min_idle calculation with proper effective wait_timeout logic - Add std::min() usage to determine effective timeout from global and session values - Ensure warning messages end with newline characters for proper log formatting - Update test sleep durations to ensure proper timeout testing Resolves potential timeout calculation bugs and ensures consistent timeout enforcement behavior.	5 months ago
René Cannaò	6534a152b2	Merge pull request #5241 from sysown/v3.0-5062_2 Add fast forward replication deprecate EOF test and update test infrastructure (closes #5062)	5 months ago
Rene Cannao	0c9c938d66	Fix mysql-set_wait_timeout-t.cpp compilation and JSON testing - Replace <json/json.h> include with <json.hpp> and proper nlohmann namespace - Replace manual JSON parsing with fetch_internal_session() utility function - Replace fail() calls with ok(false, ...) to follow TAP framework standards - Add comprehensive JSON validation test for various wait_timeout values - Include edge case testing: zero values, maximum values, and clamping behavior Resolves compilation issues and enables proper testing of wait_timeout JSON output.	5 months ago
Rene Cannao	6539587c9a	test: Add comprehensive wait_timeout JSON validation tests - Add JSON parsing helper for PROXYSQL INTERNAL SESSION responses - Add test_wait_timeout_json_values() function with 8 test cases: * Zero value (should clamp to 1 second) * Valid values (1s, 10s, 5min, 1hr, 24hr, 20 days) * Value exceeding 20 days (should clamp to maximum) - Validate that wait_timeout appears in session JSON output - Test plan increased from 4 to 12 tests total - Provides comprehensive validation of wait_timeout clamping behavior	5 months ago
Rene Cannao	df515f91fa	session: Add wait_timeout to proxysql internal session JSON - Include wait_timeout value in session JSON output for monitoring/debugging - Provides visibility into client-configured timeout values	5 months ago
Rene Cannao	0a9dc9dd29	session: Add input validation for client wait_timeout with silent clamping - Add range validation for client SET wait_timeout commands - Implement clamping between 1 second (1000ms) and 20 days (1,728,000,000ms) - Add warning messages when values are clamped due to ProxySQL limits - Maintain MySQL compatibility by accepting larger values than global config - Fix signed/unsigned comparison warning in wait_timeout assignment - Ensures client applications don't break while enforcing safety limits	5 months ago
Rene Cannao	86cc7cd3da	session: Fix wait_timeout member variable declaration and usage - Add wait_timeout member variable declaration to Base_Session class - Fix constructor initialization to use this->wait_timeout - Fix assignment in handler to properly scope member variable - Resolves compilation error for wait_timeout functionality	5 months ago
Rene Cannao	9df7407ff2	Add fast forward replication deprecate EOF test and update test infrastructure - Add comprehensive test `fast_forward_switch_replication_deprecate_eof.cpp` that validates all combinations of mysql-enable_client_deprecate_eof and mysql-enable_server_deprecate_eof settings during replication - Update test Makefile to include the new test in the test suite - Update test groups configuration to include the new test The test validates fast forward replication behavior across all 4 deprecate EOF combinations: - true/true, true/false, false/true, false/false - Ensures proper binary log fetching at full speed without throttling - Provides comprehensive coverage for CLIENT_DEPRECATE_EOF validation improvements Complements the existing fast_forward_grace_close test by focusing on EOF variable combinations rather than timing scenarios. Closes #5062	5 months ago
René Cannaò	b641c0d627	Merge pull request #5232 from sysown/fix/issue-4855 Fix issue 4855: Incorrect affected rows reporting for DDL queries	5 months ago
René Cannaò	0f719d3e7b	Merge pull request #5240 from sysown/v3.0-5062 Improve fast forward replication CLIENT_DEPRECATE_EOF validation (closes #5062)	5 months ago
Rene Cannao	5485bb02f4	Improve fast forward replication CLIENT_DEPRECATE_EOF validation Enhance the match_ff_req_options function to better handle CLIENT_DEPRECATE_EOF flag validation in fast forward replication scenarios. The function now performs a more robust check by examining the actual MySQL command type when the initial CLIENT_DEPRECATE_EOF flags don't match between frontend and backend connections. Key improvements: - Special handling for binlog-related commands (_MYSQL_COM_BINLOG_DUMP, _MYSQL_COM_BINLOG_DUMP_GTID, _MYSQL_COM_REGISTER_SLAVE) that should be allowed even when CLIENT_DEPRECATE_EOF flags don't match - Proper packet parsing to extract and validate MySQL command types - Enhanced compatibility for fast forward replication connections with mixed deprecate EOF configurations This change ensures that ProxySQL can handle more complex replication scenarios while maintaining proper protocol validation.	5 months ago
René Cannaò	3c4e09fec0	Merge pull request #5225 from sysown/v3.0_refactor_prepared_statement_cache_design_5211 Refactored Prepared-Statement Cache Design (Lock-Free Hot Path) - Part 2	5 months ago
Miro Stauder	5d2d26d74e	Merge pull request #5230 from sysown/v3.0.4-add_opensuse16 add opensuse16 packaging	5 months ago
Rahim Kanji	9c0e14a5d1	Replace rand() with lock-free Xoshiro128++ PRNG	5 months ago
Rahim Kanji	1251e4d539	Add Xoshiro128++ pseudo-random number generator to replace rand()	5 months ago
René Cannaò	4915234663	Merge pull request #5115 from sysown/v3.0.agentics [skip-ci] V3.0.agentics - Add Claude Code Agent Definitions and Architecture Documentation	5 months ago
Rene Cannao	291e5f02a9	Add AI disclaimer to ENHANCEMENT-OPPORTUNITIES.md	5 months ago
Rene Cannao	54091905c1	Restructure AI-generated documentation with verification framework - Move AI-generated docs to doc/ai-generated/ folder for clear separation - Add AI disclaimers to all documentation files (Status: NON-VERIFIED) - Create AI-DOCUMENTATION-FRAMEWORK.md explaining the tiered approach - Add doc/README.md as main navigation guide - Maintain transparency about AI documentation limitations - Reduce verification burden while preserving exploration value All AI-generated docs now clearly state they are starting points for exploration and should be verified against actual source code.	5 months ago
René Cannaò	9713f87be7	Merge branch 'v3.0' into v3.0.agentics Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
René Cannaò	d188715a7d	Merge branch 'v3.0' into fix/issue-4855 Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
noizu	652acb5d83	cont	5 months ago
noizu	39f94b0f6f	simplify for pr	5 months ago
Rene Cannao	644174a348	Add reg_test_4855_affected_rows_ddl to TAP test groups Include the regression test for issue 4855 in the g1 test group configuration to ensure it runs as part of the standard test suite.	5 months ago
René Cannaò	ae30eea64e	Merge branch 'v3.0' into v3.0_get_server_version Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
René Cannaò	3810922340	Merge pull request #5198 from sysown/v3.0_add_delay_tap_test Add delay to let ProxySQL process mysql_stmt_close()	5 months ago

1 2 3 4 5 ...

7866 Commits (efe0d4fe612e919e0207c15e605a112a8c4913a8) All Branches Search

7866 Commits (efe0d4fe612e919e0207c15e605a112a8c4913a8)

All Branches