proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	dd60d2665b	Add fast_forward_grace_close test to groups.json	5 months ago
Rene Cannao	ae93966603	Add TAP test for fast forward grace close feature - Rename and modify test to use MySQL C API mysql_binlog_* functions - Implement throttled binlog reading with 5 iterations (no limit, 2s, 5s, 20s, 60s targets) - Add diagnostics for debugging binlog fetch issues - Set RPL options for file, position, server_id, and non-blocking flag - Update Makefile to compile with MySQL client library	5 months ago
Rene Cannao	44aa606caa	Implement fast forward grace close feature to prevent data loss Problem: In fast forward mode, ProxySQL forwards packets directly from client to backend without buffering them. If the backend connection closes unexpectedly (e.g., due to server crash, network failure, or other issues), ProxySQL immediately closes the client session. This can result in data loss because the client may have sent additional data that hasn't been fully transmitted yet, as ProxySQL does not wait for the output buffers to drain. Solution: Implement a configurable grace period for session closure in fast forward mode. When the backend closes unexpectedly, instead of closing the session immediately, ProxySQL waits for a configurable timeout (fast_forward_grace_close_ms, default 5000ms) to allow any pending client output data to be sent. During this grace period: - If the client output buffers become empty, the session closes gracefully. - If the timeout expires, the session closes anyway to prevent indefinite hanging. Changes: - Added global variable mysql_thread___fast_forward_grace_close_ms (0-3600000ms) - Added session flags: backend_closed_in_fast_forward, fast_forward_grace_start_time - Added data stream flag: defer_close_due_to_fast_forward - Modified MySQL_Data_Stream::read_from_net() to detect backend EOF and initiate grace close if client buffers are not empty - Modified MySQL_Session::handler() FAST_FORWARD case to implement grace close logic with timeout and buffer checks - Added extensive inline documentation explaining the feature and its mechanics This prevents data loss in fast forward scenarios while maintaining bounded session lifetime.	5 months ago
René Cannaò	3db9c0df5d	Merge pull request #5200 from sysown/v3.0.4-bump_version bump version to 3.0.4 at the beginning of the development cycle	5 months ago
Miro Stauder	ba664785fa	bump version to 3.0.4 at the beginning of the development cycle	5 months ago
René Cannaò	cce161bc74	Merge pull request #5188 from sysown/v3.0-stmt_exec_bounds_check Improve handling of malformed `COM_STMT_EXECUTE` packets	6 months ago
Javier Jaramago Fernández	1a874de9ef	Ensure existence of testing database for 'reg_test_proclist_use_after_free-t.cpp'	6 months ago
Javier Jaramago Fernández	0903682756	Improve verbosity for 'reg_test_stmt_inv_param_offset-t.cpp' Replace 'MYSQL_QUERY' macro with verbose alternative 'MYSQL_QUERY_T'.	6 months ago
Javier Jaramago Fernández	69cf5576f3	Fix conn selection for 'reg_test_stmt_inv_param_offset-t' Since the test requires to modify 'max_allowed_packet' to work, it cannot reuse previous connections from the conn_pool. New connections must be created, to ensure that the new defaults are used.	6 months ago
Javier Jaramago Fernández	b89ea4db66	Fix credentials in one conn for 'reg_test_stmt_inv_param_offset-t' Connection requires root credentials for modifying 'max_allowed_packet'.	6 months ago
Miro Stauder	e1679a21a7	add tap test to groups.json Signed-off-by: Miro Stauder <miro@proxysql.com>	6 months ago
Javier Jaramago Fernández	bea0d14f4d	Add regression test for malformed 'COM_STMT_EXECUTE' packets The test exercises the boundary checks for 'COM_STMT_EXECUTE' params decoding and ensures the correct processing of malformed packets which only mangle the upper '4-bytes' of the param length-encoded integer.	6 months ago
Javier Jaramago Fernández	64b16172c7	Change 'COM_STMT_EXECUTE' params length decoding According to MySQL protocol, variable length strings are encoded using length encoded integers. For reference, see: - https://dev.mysql.com/doc/dev/mysql-server/9.4.0/page_protocol_com_stmt_execute.html - https://dev.mysql.com/doc/dev/mysql-server/9.4.0/page_protocol_basic_dt_integers.html#a_protocol_type_int2 The protocol specifies that values greater than 2^24 (16777216) should be encoded using '0xFE + 8-byte integer'. Yet, in reality MySQL ignores the upper section of these 8-byte integers, treating them effectively like '4-bytes'. For the sake of compatibility this commit changes the decoding behavior for 'COM_STMT_EXECUTE' to match MySQL one. This different is subtle but important, since in practice MySQL itself doesn't use the '8 bytes' from the field. This means that connectors that are compatible with MySQL could find issues when sending these packets through ProxySQL (like NodeJS 'mysql2' connector which writes the 8-bytes as a 4-bytes duplication, motivating these changes), situation that could result in rejection due to malformed packet detection (or crashes/invalid handling in the worse case scenario). The previous decoding function is now renamed into 'mysql_decode_length_ll' to honor MySQL naming 'net_field_length_ll'. For now, this protocol change is limited to 'COM_STMT_EXECUTE'.	6 months ago
Javier Jaramago Fernández	e35973b226	Add boundary checks in 'MySQL_Protocol::get_binds_from_pkt' These checks should prevent crashes when packets are received holding invalid lengths in the processed params.	6 months ago
René Cannaò	4fa3bf6a91	Merge pull request #5191 from sysown/v3.0-fix_proclist_use_after_free Fix heap-after-use between `PROXYSQL INTERNAL SESSION` and `SHOW PROCESSLIST`	6 months ago
Miro Stauder	7051857d9b	add tap test to groups.json Signed-off-by: Miro Stauder <miro@proxysql.com>	6 months ago
René Cannaò	dfd46fee4b	Merge pull request #5150 from proton-lisandro-pin/ignore_min_gtid Implement a `ignore_min_gtid_annotation` global variable, fix memory leak/overflow in `min_gtid` annotation handler.	6 months ago
René Cannaò	8be91071ef	Merge pull request #5190 from sysown/v3.0_default_interface_global_var_5189 Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set	6 months ago
René Cannaò	c06e15fd74	Merge pull request #5192 from sysown/v3.0_add_delay_watchdog Improved PgSQL/MySQL Thread Watchdog Unit Test	6 months ago
René Cannaò	d2cb0183b3	Merge pull request #5193 from sysown/v3.0-fullauth_sid Increase sid on caching_sha2 full authentication	6 months ago
Rene Cannao	f803a1d419	Increase sid on caching_sha2 full authentication caching_sha2_password full authentication is a complex task that requires a lot of packets being sent and forth between client and server (ProxySQL in this case). Every packet needs to have an increased sequence ID (sid) according to protocol. ProxySQL was incorrectly forgetting to increase the sid when requesting a full authentication. For some clients this is not a problem, while other clients will consider the incorrect sid a serious issue and abort the connection. This commit ensures that sid is correctly increased when requesting caching_sha2_password full authentication.	6 months ago
Javier Jaramago Fernández	6ff850170b	Add regression test triggering 'heap-after-use' for ASAN runs	6 months ago
Lisandro Pin	c23930b2ee	Add TAP test for `mysql-ignore_min_gtid_annotations` Co-authored-by: Wazir Ahmed <wazir@proxysql.com>	6 months ago
Lisandro Pin	6cb522283d	Implement a ignore_min_gtid_annotation global variable for ProxySQL When true, all `min_gtid` query annotations are ignored; see https://proxysql.com/documentation/query-annotations/ for details. This is useful on ProxySQL setups with multiple layers, where some layers mandate GTID-based routing while others don't.	6 months ago
Rahim Kanji	48928ce04e	Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set	6 months ago
Rahim Kanji	86c17f04d7	Replace single sleep with looped delay for simulated watchdog test	6 months ago
Rahim Kanji	3c79800a45	Add delay - WatchDog test	6 months ago
Javier Jaramago Fernández	4b28bb6ced	Fix heap-after-use between 'PROXYSQL INTERNAL SESSION' and 'SHOW PROCESSLIST' Missing query cleanup in 'PROXYSQL INTERNAL SESSION' could lead to invalid memory accesses during 'SHOW PROCESSLIST' sessions scan.	6 months ago
René Cannaò	f1426ff99e	Merge pull request #5185 from sysown/v3.0_bind_fmt_patch Reinstate bind_fmt_text.patch accidentally removed in a previous commit	6 months ago
Rahim Kanji	be6126ffc8	Added missing TAP tests in groups.json	6 months ago
Rahim Kanji	b21982d5ac	Restore bind_fmt_text.patch mistakenly removed in commit `d020f577b`	6 months ago
René Cannaò	4a6ba68357	Merge pull request #5173 from sysown/v3.0_admin_cmd_5170 Resolved issues with PROXYSQL PAUSE/RESUME/STOP/START	6 months ago
René Cannaò	a308d26cd0	Merge pull request #5184 from sysown/v3.0.3-revert-opensuse16 remove opensuse16 builds due to rpm packaging issue	6 months ago
Rahim Kanji	9d131058ae	Added TAP test	6 months ago
Miro Stauder	aba0b6ea2d	remove opensuse16 builds due to rpm packaging issue	6 months ago
René Cannaò	08014501e1	Merge pull request #5171 from sysown/v3.0.3-upgrade_coredumper V3.0.3 upgrade coredumper to percona fork hash 8f2623b	6 months ago
René Cannaò	a44dee127d	Merge pull request #5174 from sysown/v3.0_optimise_extended_query_response Removed unnecessary writeout()	6 months ago
René Cannaò	9dd4d54e79	Merge pull request #5182 from sysown/v3.0-fix_use_after_free_in_pgsql_proclist Fix potential 'use-after-free' by Admin 'SHOW PROCESSLIST' (PgSQL)	6 months ago
Javier Jaramago Fernández	2668de77c2	Fix compilation warning for 'strncpy' due string truncation As per the GCC manual, calls to 'strn*' function family shall be replaced by 'memcpy' when truncation (no null termination) is expected.	6 months ago
Javier Jaramago Fernández	c0978f9371	Fix potential 'use-after-free' by 'SHOW PROCESSLIST' (PgSQL) Accesses by 'stats___pgsql_processlist' to 'myconn->query.ptr' could lead to invalid memory accesses, as the pointed query could already have been free by the session after being issued.	6 months ago
René Cannaò	27ac446b72	Merge pull request #5181 from sysown/v3.0-fix_test_server_sess_status Fix user dependence in 'test_server_sess_status-t'	6 months ago
René Cannaò	4f8c5992ca	Merge pull request #5180 from sysown/v3.0-fix_use_after_free_in_proclist Fix potential 'use-after-free' by Admin 'SHOW PROCESSLIST'	6 months ago
René Cannaò	bc8163e206	Merge pull request #5178 from sysown/v3.0.3-tap_groups_fix V3.0.3 tap groups - fix mangled entry	6 months ago
Javier Jaramago Fernández	10258d5b52	Fix user dependence in 'test_server_sess_status-t' This test had dependencies with other tests regarding the used users. When requiring extra users, tests should by idempotent, and handle user/resources creation on their own.	6 months ago
Javier Jaramago Fernández	67624b8569	Fix compilation warning for 'strncpy' due string truncation As per the GCC manual, calls to 'strn*' function family shall be replaced by 'memcpy' when truncation (no null termination) is expected.	6 months ago
Javier Jaramago Fernández	639f9d0c74	Fix potential 'use-after-free' by 'SHOW PROCESSLIST' Accesses by 'stats___mysql_processlist' to 'myconn->query.ptr' could lead to invalid memory accesses, as the pointed query could already have been free by the session after being issued.	6 months ago
Miro Stauder	4d43313a27	fix mangled entry	6 months ago
René Cannaò	eb10eff1e1	Merge pull request #5175 from sysown/revert-gtid-refactoring Revert "gtid: Refactor reconnect logic & prevent events_count reset"	6 months ago
Wazir Ahmed	8d1b5b597c	Revert "gtid: Refactor reconnect logic & prevent events_count reset" This reverts commit `0a70fd515f`.	6 months ago
Rahim Kanji	8291361bc1	Removed unnecessary writeout()	6 months ago

1 2 3 4 5 ...

7739 Commits (dd60d2665b91f83182fa12b02f3e2d8e69bd2c85) All Branches Search

7739 Commits (dd60d2665b91f83182fa12b02f3e2d8e69bd2c85)

All Branches