12 Commits (dbb40a30baec7d23568ebe2d2b228737d31dfcba)

Author	SHA1	Message	Date
Rene Cannao	6322d58376	sqlite3: CACHING_SHA2_PASSWORD() accepts optional rounds arg (closes #5640) ... The ProxySQL admin SQLite3 extension CACHING_SHA2_PASSWORD() previously always emitted hashes with 5000 rounds (hardcoded "\$A\$005\$" prefix and "\$5\$rounds=5000\$" crypt salt). MySQL's caching_sha2_password_digest_rounds is configurable from 5000 to 4095000 in steps of 1000, so a backend that uses any non-default value produces hashes the extension cannot reproduce — breaking the byte-for-byte hash equivalence test in test_sqlite3_pass_exts-t on e.g. the mysql95 backend where rounds=10000. Extend the SQLite function to accept an optional third integer argument carrying the desired rounds value: CACHING_SHA2_PASSWORD(pass) -> random salt, 5000 rounds CACHING_SHA2_PASSWORD(pass, salt) -> given salt, 5000 rounds CACHING_SHA2_PASSWORD(pass, salt, rounds) -> given salt, given rounds rounds is validated: integer, multiple of 1000, in [5000, 4095000] — matching MySQL's caching_sha2_password_digest_rounds bounds. The "\$5\$rounds=<N>\$" salt prefix and "\$A\$<RRR>\$" hash prefix are now built at runtime from the resolved value, with <RRR> emitted as 3-char zero-padded uppercase hex of (rounds/1000) per MySQL's sql/auth/sha2_password.cc::digest_round_separator(). Update test_sqlite3_pass_exts-t to parse the rounds field from the MySQL-generated hash (chars 3..5 of \$A\$<RRR>\$..., base-16, ×1000) and pass it to CACHING_SHA2_PASSWORD() — so the hash-equivalence assertion matches any backend rounds. Update the INV_INPUTS fixture: 3-arg is now valid, so reject 4-arg ("wrong number"), reject 3-arg with non-integer rounds ("Invalid argument type"), reject out-of-range or non-multiple-of-1000 rounds ("Invalid rounds: ..."). Verified against mysql95 backend (rounds=10000): test_sqlite3_pass_exts-t passes 2117/2117, test_auth_methods-t passes 10774/10774 (previously failing with 50+122 not-ok respectively before the base-16 parse fix in MySQL_Protocol.cpp).	1 month ago
Rene Cannao	d5b796cdea	fix(test/tap): halve expected backend conn count in test_sqlite3_pass_exts-t on 9.x ... Follow-up to cbbd10ba7 (skip native_password backend fixtures on MySQL 9.x). The Phase-3 end-to-end loop runs RAND_USERS_GEN (100) iterations on 8.4 — 50 with mysql_native_password + 50 with caching_sha2_password — and each successful login creates one backend connection. On 9.x the native half is skipped, so only 50 actual connections are made. The post-loop assertion "Number of backend conns created should match conn attempts" was hardcoded to compare against RAND_USERS_GEN. When native was skipped, actual=50 but expected=100, producing: not ok 2113 - Number of backend conns created should match conn attempts exp:'100', act:'50' Fix: compute expected_conns based on g_mysql_supports_native_password (the same flag that gates the Phase-3 loop range) and use it both for the wait_for_cond() condition string and the assertion. Verified on a live mysql90 backend: test now reports ok 2113 - ... exp:'50', act:'50' and exits 0 (2113/2113 assertions pass in 3.4s).	1 month ago
Rene Cannao	cbbd10ba74	fix(test/tap): skip native_password backend fixtures on MySQL 9.x in test_sqlite3_pass_exts-t ... Fixes #5631. The test has three logical phases: Phase 1 Admin SQLite3 extension validation for MYSQL_NATIVE_PASSWORD() and CACHING_SHA2_PASSWORD() — pure hash computation inside ProxySQL, does not touch the backend. Phase 2 MySQL/Admin hash compatibility — creates USER_GEN_COUNT (100) users on the backend, half with mysql_native_password and half with caching_sha2_password, then compares the backend's authentication_string with the hash that ProxySQL's Admin SQLite3 function produces. Phase 3 End-to-end connection test — creates RAND_USERS_GEN (100) users with the same 50/50 split and attempts to connect through ProxySQL. On MySQL 9.0+ the mysql_native_password plugin is not loadable, so the first CREATE USER IDENTIFIED WITH 'mysql_native_password' in Phase 2 fails with ER_PLUGIN_IS_NOT_LOADED and the test bails after only 10 assertions (all of Phase 1 passes — ProxySQL's internal hash extensions work fine on 9.x; this was a good green signal). Fix: - Add g_mysql_supports_native_password; set to false on server_version >= 9.0. - Adjust actual_test_count so plan() matches reality: if (has_native) { count += USER_GEN_COUNT + RAND_USERS_GEN; } else { count += USER_GEN_COUNT / 2 + RAND_USERS_GEN / 2; } - Wrap the Phase 2 native_password loop in 'if (has_native)'. - Phase 3 uses 'for (i = 0 .. RAND_USERS_GEN)' with 'i < 50 ? native : sha2'. Skip the native half by starting the loop at RAND_USERS_GEN/2 when has_native is false. Phase 1 coverage is fully preserved — the ProxySQL Admin SQLite3 hash functions (including MYSQL_NATIVE_PASSWORD()) still work on 9.x; only the backend-side CREATE USER path is skipped.	1 month ago
Rene Cannao	fe21aafbe8	fix(test/tap): eliminate compiler warnings in TAP tests ... - Replace diag("") with diag("%s", "") to avoid zero-length format warnings - Increase buffer and use unsigned format in unique_ip() to fix sprintf overflow - Use printf-style format strings instead of .c_str() for ok() calls - Fix %zu for size_t loop variable in fast_forward_switch_replication_deprecate_eof - Use explicit function pointer type instead of decltype(&pclose) - Replace string_format with plain assignment when no format args needed	1 month ago
Rene Cannao	186ce308c6	Fix test_sqlite3_pass_exts plan for MySQL version differences ... Move plan() call after MySQL version detection to set correct test count: - MySQL 8.0+: 2213 tests (includes BY RANDOM PASSWORD tests) - MySQL 5.7: 2012 tests (skips BY RANDOM PASSWORD tests) Previously the test always planned 2213 tests, causing TAP failures when running against MySQL 5.7 because only 2113 tests executed.	2 months ago
Rene Cannao	242eef0241	Address code review feedback ... - test_binlog_reader_uses_previous_hostgroup-t.cpp: Use relative path when TEST_DEPS is unset. - test_com_register_slave_enables_fast_forward-t.cpp: Use relative path when TEST_DEPS is unset. - test_ffto_pgsql-t.cpp: Escape credentials before using them in SQL. - charset_unsigned_int-t.cpp: Ensure mysql_b connects and verifies latin1 before reset. - test_cluster_sync-t.cpp: Use mysql_query instead of system() for diagnostics. - test_cluster_sync_config: Replace tracked runtime stderr file with .example and gitignore it. - test_cluster_sync_withmonitor: Use relative path for datadir in config. - test_sqlite3_pass_exts-t.cpp: Use cl.admin_host for admin connection and improve version check. - test_auth_methods-t.cpp: Correctly detect MariaDB and use plan(0) for skip.	3 months ago
Rene Cannao	7995ce524e	Test: Fix test_sqlite3_pass_exts for MySQL 5.7 compatibility ... - Detect MySQL version and skip MySQL 8.0+ specific tests - Use cl.mysql_host for backend connection - Remove hardcoded env overrides from env file	3 months ago
Rene Cannao	6eedf0808e	Test: Fix test_sqlite3_pass_exts for isolated CI environment ... - Changed MySQL backend connection to use cl.mysql_host instead of cl.host - Added verbose test header explaining test purpose and scenarios - Added diagnostic messages for connection attempts and success	3 months ago
Javier Jaramago Fernández	1da6dfec29	Remove unnecessary/unused utils from tests	1 year ago
Javier Jaramago Fernández	ef3360f102	Several enhancements for TAP tests compilation ... - Split 'libtap' into different binaries. This allows for the reuse of 'TAP' utilities that make use of MySQL or other third party library versions. Each of these tests that require special library versions that aren't the common ones embedded into the dynamic library 'libtap.so' should be compiled defining special helper targets, in the 'tests' folder Makefile itself. These helper targets with specify the linking of the required version of the library for the test. Each MySQL client version supported by the 'tap' tests that breaks headers compatibility should be compiled into a different object file, following the previous described procedure. - Add MySQL 8.4.0 client library as a new TAP test dependency. - Multiple compilation fixes consequence of the introduced change to 'libtap.a'. - Added as ProxySQL dependency the forward declaration header for 'nlohmann::json'. This header is the proper way of including the library is headers which are sensible of being included in multiples files. This speeds compilation times of each TAP test. - Removed 'std::regex' dependency from 'utils.cpp', and replaced by project dependency 're2'. Library 'std::regex' should not be used in any place that introduces it as a dependency for later objects, it's heavy, slow, and should be avoided in general.	2 years ago
Javier Jaramago Fernández	b6569872f0	Add end-to-end pass gen testing to 'test_sqlite3_pass_exts-t'	2 years ago
Javier Jaramago Fernández	44db1dfb40	Add test for Admin SQLite3 password extensions	2 years ago