aherman
/
proxysql
mirror of https://github.com/sysown/proxysql
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(test/tap): skip native_password backend fixtures on MySQL 9.x in test_sqlite3_pass_exts-t

Browse Source 
Fixes #5631.

The test has three logical phases:

  Phase 1  Admin SQLite3 extension validation for MYSQL_NATIVE_PASSWORD()
           and CACHING_SHA2_PASSWORD() — pure hash computation inside
           ProxySQL, does not touch the backend.

  Phase 2  MySQL/Admin hash compatibility — creates USER_GEN_COUNT (100)
           users on the backend, half with mysql_native_password and half
           with caching_sha2_password, then compares the backend's
           authentication_string with the hash that ProxySQL's Admin
           SQLite3 function produces.

  Phase 3  End-to-end connection test — creates RAND_USERS_GEN (100)
           users with the same 50/50 split and attempts to connect
           through ProxySQL.

On MySQL 9.0+ the mysql_native_password plugin is not loadable, so the
first CREATE USER IDENTIFIED WITH 'mysql_native_password' in Phase 2
fails with ER_PLUGIN_IS_NOT_LOADED and the test bails after only 10
assertions (all of Phase 1 passes — ProxySQL's internal hash extensions
work fine on 9.x; this was a good green signal).

Fix:

  - Add g_mysql_supports_native_password; set to false on server_version
    >= 9.0.
  - Adjust actual_test_count so plan() matches reality:
      if (has_native) {
          count += USER_GEN_COUNT + RAND_USERS_GEN;
      } else {
          count += USER_GEN_COUNT / 2 + RAND_USERS_GEN / 2;
      }
  - Wrap the Phase 2 native_password loop in 'if (has_native)'.
  - Phase 3 uses 'for (i = 0 .. RAND_USERS_GEN)' with 'i < 50 ? native
    : sha2'. Skip the native half by starting the loop at
    RAND_USERS_GEN/2 when has_native is false.

Phase 1 coverage is fully preserved — the ProxySQL Admin SQLite3 hash
functions (including MYSQL_NATIVE_PASSWORD()) still work on 9.x; only
the backend-side CREATE USER path is skipped.
v3.0-dbdeployer-mysql84-gr
Rene Cannao 1 month ago
parent 5bb19a99b1
commit cbbd10ba74
1 changed files with 45 additions and 16 deletions
Show Stats Download Patch File Download Diff File

61
test/tap/tests/test_sqlite3_pass_exts-t.cpp
Unescape View File

@ -33,6 +33,13 @@ using std::pair;
// Global flag for MySQL version check
static bool g_mysql_supports_random_password = false;
static bool g_mysql_version_checked = false;
// MySQL 9.0 removed the 'mysql_native_password' server plugin. CREATE USER
// IDENTIFIED WITH 'mysql_native_password' returns ER_PLUGIN_IS_NOT_LOADED on
// 9.x backends. This flag gates the backend-side native_password fixtures
// (Phase 2 hash compat + Phase 3 end-to-end). ProxySQL's internal
// MYSQL_NATIVE_PASSWORD() SQLite3 extension is unaffected — hash generation
// is pure computation and still works.
static bool g_mysql_supports_native_password = true;
/**
* @brief Check if MySQL server supports 'BY RANDOM PASSWORD' syntax (MySQL 8.0+)
@ -454,20 +461,37 @@ int main(int argc, char** argv) {
// MySQL 8.0+ supports 'BY RANDOM PASSWORD' syntax, MySQL 5.7 does not
check_mysql_random_password_support(mysql);
// Detect whether the 'mysql_native_password' server plugin is usable.
// MySQL 9.0 removed it; we skip the native_password halves of Phase 2
// (MySQL/Admin hash compat) and Phase 3 (end-to-end) on 9.x backends.
unsigned long server_version = mysql_get_server_version(mysql);
if (server_version >= 90000) {
g_mysql_supports_native_password = false;
diag("Backend MySQL %lu: 'mysql_native_password' plugin not loadable. "
"Skipping native_password backend-side fixtures.", server_version);
}
// Calculate the actual number of tests based on MySQL version
uint32_t actual_test_count =
INV_INPUTS.size() + // Always run
PASS_GEN_COUNT * 2 + // Always run
PASS_GEN_COUNT * 2 + // Always run (ProxySQL Admin SQLite3 extensions)
2; // EXTRA: Two extra correctness tests
if (g_mysql_supports_random_password) {
// These tests only run on MySQL 8.0+
actual_test_count += USER_GEN_COUNT; // MySQL/Admin hash compatibility tests
actual_test_count += RAND_USERS_GEN; // End-to-end connection tests
// Phase 2: MySQL/Admin hash compatibility tests (USER_GEN_COUNT total,
// half native + half sha2). On 9.x only the sha2 half runs.
actual_test_count +=
(g_mysql_supports_native_password ? USER_GEN_COUNT : USER_GEN_COUNT / 2);
// Phase 3: End-to-end connection tests (RAND_USERS_GEN total, same split).
actual_test_count +=
(g_mysql_supports_native_password ? RAND_USERS_GEN : RAND_USERS_GEN / 2);
actual_test_count += 1; // Connection count check
}
diag("MySQL version supports 'BY RANDOM PASSWORD': %s", g_mysql_supports_random_password ? "yes" : "no");
diag("MySQL server supports 'mysql_native_password' plugin: %s", g_mysql_supports_native_password ? "yes" : "no");
diag("Planned test count: %u", actual_test_count);
plan(actual_test_count);
@ -502,17 +526,19 @@ int main(int argc, char** argv) {
if (g_mysql_supports_random_password) {
vector<user_def_t> users {};
for (size_t i = 0; i < USER_GEN_COUNT/2; i++) {
const string name { "rndextuser" + std::to_string(i) };
pair<int,user_def_t> user_def {
create_mysql_user_rnd_creds(mysql, name, "mysql_native_password")
};
if (user_def.first) {
diag("User creation failed user:'%s'", name.c_str());
goto cleanup;
} else {
users.push_back(user_def.second);
if (g_mysql_supports_native_password) {
for (size_t i = 0; i < USER_GEN_COUNT/2; i++) {
const string name { "rndextuser" + std::to_string(i) };
pair<int,user_def_t> user_def {
create_mysql_user_rnd_creds(mysql, name, "mysql_native_password")
};
if (user_def.first) {
diag("User creation failed user:'%s'", name.c_str());
goto cleanup;
} else {
users.push_back(user_def.second);
}
}
}
@ -594,7 +620,10 @@ int main(int argc, char** argv) {
);
MYSQL_QUERY(admin, "LOAD MYSQL SERVERS TO RUNTIME");
for (uint32_t i = 0; i < RAND_USERS_GEN; i++) {
// On MySQL 9.x the native_password plugin is unavailable on the backend,
// so skip the first RAND_USERS_GEN/2 iterations (those are the native ones).
uint32_t rand_users_start = g_mysql_supports_native_password ? 0 : (RAND_USERS_GEN / 2);
for (uint32_t i = rand_users_start; i < RAND_USERS_GEN; i++) {
const string name { "username_" + std::to_string(i) };
const string pass { random_string(20) };
const string auth { i < 50 ? "MYSQL_NATIVE_PASSWORD" : "CACHING_SHA2_PASSWORD" };

Write Preview
Loading…
Cancel
Save