proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	d880330c17	feat: add SAVE MYSQLX handlers and first-class LOAD/SAVE dispatch Replace the PLUGIN MYSQLX command namespace with canonical ProxySQL admin syntax matching the MYSQL/PGSQL convention. Plugin changes (mysqlx_admin_schema.cpp): - Add three SAVE handlers (save_users_from_runtime, save_routes_from_runtime, save_backend_endpoints_from_runtime) that copy runtime tables back to config tables (reverse of LOAD) - Register 6 commands with canonical names: LOAD MYSQLX USERS/ROUTES/BACKEND ENDPOINTS TO RUNTIME SAVE MYSQLX USERS/ROUTES/BACKEND ENDPOINTS TO MEMORY Admin handler changes (Admin_Handler.cpp): - Add 6 MYSQLX alias vector definitions following the existing LOAD_MYSQL_USERS_FROM_MEMORY pattern (4 aliases each: FROM MEMORY, FROM MEM, TO RUNTIME, TO RUN) - Replace the generic plugin fallback dispatch with MYSQLX-specific alias matching using is_admin_command_or_alias(), matching how MYSQL and PGSQL commands are dispatched - Use 'return false' pattern consistent with other admin commands	2 months ago
Rene Cannao	d34fb38162	refactor: remove PLUGIN prefix gate from plugin command registration Remove the 'PLUGIN ' prefix requirement from the plugin manager's command registration and dispatch. This allows plugins to register any canonical command string (e.g. 'LOAD MYSQLX USERS TO RUNTIME') instead of being forced into the 'PLUGIN <name> ...' namespace. Changes to lib/ProxySQL_PluginManager.cpp: - Delete kPluginCommandPrefix constant and has_plugin_command_prefix() - Remove prefix validation from register_command() - now only rejects empty canonical forms - Remove prefix check from dispatch_admin_command() - any registered command string can be dispatched Updated plugin_registry_unit-t.cpp to use canonical 'LOAD MYSQLX USERS TO RUNTIME' syntax instead of 'PLUGIN MYSQLX LOAD USERS TO RUNTIME'. The 'SELECT 1' test now succeeds (any string accepted) since the namespace restriction is gone.	2 months ago
Rene Cannao	7cc246c71f	fix: core plugin ABI safety issues 1. Init ordering: move LoadConfiguredPlugins() after ProxySQL_Main_init_Admin_module() so get_admindb/configdb/statsdb return valid handles during plugin init(), not nullptr. 2. Null snapshot callbacks: assign stub functions returning nullptr to get_mysql_users_snapshot, get_mysql_servers_snapshot, and get_mysql_group_replication_hostgroups_snapshot instead of leaving them as null function pointers that crash when called. 3. Lifecycle: stop_all() now only calls stop() on plugins where started=true, not merely initialized. Prevents calling stop() on plugins that were never start()ed. 4. Destructor: remove unsynchronized read of g_active_plugin_manager (callers already clear it under the mutex before destruction).	2 months ago
Rene Cannao	9b87260b70	fix: harden plugin init failures and command dispatch	2 months ago
Rene Cannao	5dd717a8f1	fix: fail fast on plugin table conflicts	2 months ago
Rene Cannao	d036ba8327	fix: canonicalize plugin command registration	2 months ago
Rene Cannao	2430516600	fix: reject conflicting plugin registrations	2 months ago
Rene Cannao	123bb7eaf0	fix: harden plugin registry ABI and ownership	2 months ago
Rene Cannao	fd5f029474	fix: expose plugin db handles during startup	2 months ago
Rene Cannao	cd15afdd1e	feat: support plugin-owned admin tables and commands	2 months ago
Rene Cannao	80fa6bee24	fix: cover configured plugin lifecycle wiring	2 months ago
Rene Cannao	804771271b	feat: wire configured plugins into ProxySQL startup	2 months ago
Rene Cannao	da7e182719	fix: align plugin loader ABI and tests	2 months ago
Rene Cannao	7e1a12b8f7	feat: add generic plugin ABI and loader	2 months ago
René Cannaò	7510d8073a	Merge pull request #5553 from sysown/fix/5539-ffto-default-by-tier Disable FFTO by default in 3.1.x, keep enabled in 4.0.x	2 months ago
René Cannaò	3659ba85fb	Merge branch 'v3.0' into advisory/com-stmt-send-long-data-fix-1 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rene Cannao	151169da9b	Fix COM_STMT_SEND_LONG_DATA short packet handling	2 months ago
René Cannaò	b94c855d4c	Merge branch 'v3.0' into advisory-fix-1 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	fa6ebcdcc9	Merge commit from fork Fix PROXY protocol v1 address overflow	2 months ago
René Cannaò	419cd7608b	Merge commit from fork Fix COM_STMT_CLOSE short packet handling	2 months ago
René Cannaò	7a574a537a	Merge commit from fork Validate COM_CHANGE_USER packet bounds	2 months ago
Rene Cannao	b2f4b4f9a0	Fix crash when COM_BINLOG_DUMP received with idle backends from other hostgroups (#5556 ) When a session has backend connections to multiple hostgroups and receives COM_BINLOG_DUMP, GPFC_Replication_SwitchToFastForward() transitions the session to FAST_FORWARD mode but only manages the active backend. Idle backends from other hostgroups remain in the session's mybes array with async_state_machine==ASYNC_IDLE. If MySQL's wait_timeout closes one of these idle connections, the resulting POLLIN event causes handler() to be called with ASYNC_IDLE, which has no case in the switch and hits assert(0). Fix: Clean up idle backends from other hostgroups during the FAST_FORWARD transition in GPFC_Replication_SwitchToFastForward(). These connections will never be used again, so they are destroyed immediately. Includes a regression test (test_binlog_dump_multi_backend_crash-t) that: - Sets up two hostgroups with query rules routing SELECTs to reader HG - Creates backend connections to both hostgroups on one session - Sends COM_BINLOG_DUMP to enter FAST_FORWARD mode - Waits for wait_timeout to close the idle backend - Verifies ProxySQL does not crash	2 months ago
Rene Cannao	61fc7a129c	Disable FFTO by default in 3.1.x, keep enabled in 4.0.x (#5539 ) Gate the ffto_enabled default on PROXYSQLGENAI so that: - 3.1.x (PROXYSQL31): FFTO compiled in but disabled by default - 4.0.x (PROXYSQLGENAI): FFTO enabled by default (unchanged) Users on 3.1.x can still opt in via SET mysql-ffto_enabled='true'.	2 months ago
René Cannaò	d0625dc243	Merge pull request #5549 from sysown/v3.0-CodeCov0325 Add 32 unit test files (2963 assertions) and CI workflow improvements	2 months ago
René Cannaò	2fcc5729ee	Merge pull request #5548 from yuji-hatakeyama/5306-fix_show_warnings_with_comment Fix #5306 - SHOW WARNINGS with inline comments incorrectly sets warning_count	2 months ago
Rene Cannao	8b0c7be827	Add fallback to raw query when digest_text is unavailable When query digests are disabled (digest_text is NULL), the SHOW WARNINGS detection would always return false, losing the original behavior for plain "SHOW WARNINGS" queries. Add an else branch that falls back to checking query.ptr, preserving the pre-fix behavior when digests are off.	2 months ago
Rene Cannao	b40c77c48d	Revert "fix(#5306 ): SHOW WARNINGS with inline comments incorrectly sets warning_count" This reverts commit `049ea8ce84`.	2 months ago
Rene Cannao	049ea8ce84	fix(#5306 ): SHOW WARNINGS with inline comments incorrectly sets warning_count When SHOW WARNINGS queries contain inline comments (e.g., "SHOW /* comment */ WARNINGS"), ProxySQL incorrectly includes warning_count in the EOF packet because the detection used raw query text which still contains comments. Fix: use digest_text (comments stripped by the query processor) for SHOW WARNINGS detection, with fallback to raw query.ptr when digest_text is unavailable (digests disabled). This preserves the original behavior for both digest-enabled and digest-disabled modes. Reported by DBIx::Sunny (Perl) users who send annotated queries. Closes #5306	2 months ago
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	2 months ago
Yuji Hatakeyama	604c020857	Fix #5306 : Use digest_text to suppress warning_count for SHOW WARNINGS	2 months ago
Rene Cannao	99dcb5b160	fix: namespace stats_utils helpers to avoid symbol collision ProxySQL_Admin_Tests2.cpp defines its own parse_int_or_zero() in an anonymous namespace. Our declaration in Stats_Tool_Handler.h (included transitively via cpp.h) created an ambiguous overload error. Fix: wrap the 4 helper functions in namespace stats_utils in both the header and implementation. A using-directive within the .cpp keeps existing call sites working without qualification.	2 months ago
Rene Cannao	1d2f16b506	test: add 4 more unit test files with 198 assertions (Tier 1) Expand coverage for charset lookups, GenAI Query/LLM/MCP components. New test files (test/tap/tests/unit/): Core: - charset_find_unit-t (62 tests): all 4 proxysql_find_charset functions — edge cases for NULL returns, utf8mb3→utf8 translation, case-insensitive matching, collation preference GenAI/MCP (PROXYSQLGENAI=1): - genai_query_handler_unit-t (65 tests): validate_sql_identifier, escape_string_literal, strip_leading_comments, json_string/ json_int/json_double safe extraction, is_pgsql_protocol, is_runtime_online_status, uppercase_or_unknown - genai_llm_clients_unit-t (35 tests): is_retryable_error HTTP status codes (408/429/5xx) and CURL error codes, plus LLM_WriteCallback data accumulation - genai_mcp_endpoint_unit-t (36 tests): validate_bearer_token extraction/comparison, create_jsonrpc_response/error JSON-RPC 2.0 formatting Minimal production changes for testability: - include/Query_Tool_Handler.h: friend class + extern declarations for 8 pure helper functions - lib/Query_Tool_Handler.cpp: remove static from 8 file-local pure functions (no behavioral change) - include/MCP_Endpoint.h: friend class + new static validate_bearer_token() extracted from authenticate_request() - lib/MCP_Endpoint.cpp: extract token validation into static method - lib/LLM_Clients.cpp: remove static from is_retryable_error() and rename WriteCallback to LLM_WriteCallback (avoid collisions) Running totals: 15 test files, 718 assertions, all passing.	2 months ago
Rene Cannao	accc68c9dc	test: add 11 new unit test files with 520 assertions for lib/ coverage Add targeted unit tests for pure functions and isolated components across lib/, increasing test coverage for both core utilities and GenAI/MCP components. New test files (test/tap/tests/unit/): Core utilities: - pgsql_variables_validator_unit-t (75 tests): bool, float, string, memory size, search_path, and client_encoding validators - gen_utils_unit-t (28 tests): mywildcmp wildcard matching, escape_string_single_quotes, Proxy_file_regular - mysql_encode_unit-t (23 tests): mysql_encode_length, CPY3/CPY8, proxy_my_crypt XOR, write_encoded_length - proxysql_utils_unit-t (23 tests): hex/unhex, sql_escape, split_str, replace_str, generate_multi_rows_query, checksums - proxy_protocol_unit-t (22 tests): PROXY v1 header parsing, subnet validation, IPv4/IPv6 network matching - pgsql_error_helper_unit-t (139 tests): SQLSTATE code mapping, all 38 error class branches, severity classification, fill/reset - pgsql_txn_state_unit-t (54 tests): TxnCmdParser for BEGIN, COMMIT, ROLLBACK, SAVEPOINT, RELEASE, AND CHAIN variants - sqlite3db_unit-t (21 tests): execute, return_one_int, check_table_structure, build_table, row ops, locking GenAI/MCP (PROXYSQLGENAI=1): - genai_stats_parsing_unit-t (79 tests): parse_server_filter, parse_digest_filter, parse_ll_or_zero, get_interval_config, calculate_percentile - genai_fts_string_unit-t (32 tests): MySQL_FTS sanitize_name, escape_identifier, escape_sql, table name construction - genai_anomaly_unit-t (24 tests): normalize_query SQL normalization, check_sql_injection pattern detection Minimal production changes for GenAI testability: - include/Anomaly_Detector.h: add friend class for test access - include/Stats_Tool_Handler.h: declare 4 parsing helpers, move 2 pure computation methods (get_interval_config, calculate_percentile) to public - lib/Stats_Tool_Handler.cpp: remove static from 4 free helper functions (no behavioral change, only linkage visibility)	2 months ago
Rene Cannao	c6f442b4d1	feat(ffto): record PostgreSQL FF errors in stats_pgsql_errors	2 months ago
Rene Cannao	c3df4ee014	feat(ffto): record MySQL FF errors in stats_mysql_errors	2 months ago
Rene Cannao	fe701d29aa	feat(ffto): add pgsql_parse_error_response() helper with unit tests	2 months ago
Rene Cannao	1c559e96d8	feat(ffto): add mysql_parse_err_packet() helper with unit tests	2 months ago
Rene Cannao	7f5bbf0f19	Fix compilation error: add missing #include <cstdint> in MonitorHealthDecision.cpp The int64_t cast in can_unshun_server() requires <cstdint>, which was not included, causing build failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2 months ago
René Cannaò	4d2bcc303e	Merge remote-tracking branch 'origin/v3.0' into copilot/feature-load-restapi-routes-config # Conflicts: # test/tap/groups/groups.json	2 months ago
René Cannaò	da13ab59e5	Merge remote-tracking branch 'origin/v3.0' into copilot/add-ssl-tls-certificate-stats-table # Conflicts: # test/tap/groups/groups.json	2 months ago
René Cannaò	9781f5992d	Merge remote-tracking branch 'origin/v3.0' into copilot/feature-load-restapi-routes-config	2 months ago
René Cannaò	efedd93c92	Rename stats_global to stats_proxysql_global to avoid strstr substring collision stats_global is a substring of stats_mysql_global and stats_pgsql_global, causing the strstr-based dispatch to match incorrectly. Exclusion guards don't work either because a query referencing both tables would suppress the stats_proxysql_global refresh. Renaming to stats_proxysql_global follows the existing naming convention (stats_mysql_global, stats_pgsql_global) and eliminates the substring collision entirely.	2 months ago
René Cannaò	c3564af9cf	Fix timeout_ms validation and write path section name consistency 1. Validate timeout_ms against the CHECK constraint (100..100000000) and skip routes with invalid or missing values with an error message. Previously, omitting timeout_ms defaulted to 0, which silently failed the SQLite CHECK constraint and dropped the route. 2. Update Write_Restapi_to_configfile to emit 'restapi_routes:' instead of 'restapi:' so save-then-reload cycles use the preferred section name consistently.	2 months ago
René Cannaò	9850d9daeb	Fix stats_global substring collision and reload failure tracking 1. stats_global strstr match: add exclusion guards for stats_mysql_global and stats_pgsql_global to prevent spurious stats___global() calls and unnecessary ssl_mutex contention on every MySQL/PgSQL global stats query. 2. TLS reload failure tracking: set tls_last_load_ok=false and update tls_load_count/tls_last_load_timestamp on non-bootstrap reload failures. Previously, a failed PROXYSQL RELOAD TLS would leave stale SUCCESS status in stats_global.	2 months ago
René Cannaò	ea16ebb8ad	Merge branch 'v3.0-5473' into v3.0-5499 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	d872a392a6	Merge branch 'v3.0-5473' into v3.0-5498 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	8d7459e560	Merge branch 'v3.0-5473' into v3.0-5497 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	9bccd2d1fa	Merge branch 'v3.0-5473' into v3.0-5495 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	cffd85f0ff	Merge pull request #5511 from sysown/v3.0-5494 Phase 3.6: Backend variable sync decisions + unit tests	2 months ago
René Cannaò	f5ace60850	Address review on PgSQL error classifier (PR #5514 ) - Fix: 57014 (query_canceled) is now classified as REPORT_TO_CLIENT instead of FATAL (it's a normal cancellation, not a server crash) - Fix docstring: crash_shutdown is 57P02 (class 57), not class 58; class 58 is system/I/O errors - Add test for 57014 exception (+1 test, plan 25→26)	2 months ago

1 2 3 4 5 ...

5116 Commits (cf867e46fd8757d5a898bdf4e6796c8658bf42e5)