9292 Commits (cf867e46fd8757d5a898bdf4e6796c8658bf42e5)

 

All Branches   

Search

Author	SHA1	Message	Date
Rene Cannao	cf867e46fd	test/docs: update admin tables test and docs for canonical MYSQLX syntax ... Update test_mysqlx_admin_tables-t.cpp to use canonical LOAD/SAVE MYSQLX command syntax and add SAVE roundtrip coverage. Plan count: 23 -> 42. New test coverage: - 3 SAVE command tests verifying runtime->config data copy - 7 LOAD edge cases: empty tables, double LOAD replaces (not appends), modified config reflected after LOAD, null db handle returns error, multiple rows copied correctly - 8 alias dispatch tests: case-insensitive matching and whitespace normalization for all command variants Update wrap-up doc to list canonical command names with alias patterns.	2 months ago
Rene Cannao	d880330c17	feat: add SAVE MYSQLX handlers and first-class LOAD/SAVE dispatch ... Replace the PLUGIN MYSQLX command namespace with canonical ProxySQL admin syntax matching the MYSQL/PGSQL convention. Plugin changes (mysqlx_admin_schema.cpp): - Add three SAVE handlers (save_users_from_runtime, save_routes_from_runtime, save_backend_endpoints_from_runtime) that copy runtime tables back to config tables (reverse of LOAD) - Register 6 commands with canonical names: LOAD MYSQLX USERS/ROUTES/BACKEND ENDPOINTS TO RUNTIME SAVE MYSQLX USERS/ROUTES/BACKEND ENDPOINTS TO MEMORY Admin handler changes (Admin_Handler.cpp): - Add 6 MYSQLX alias vector definitions following the existing LOAD_MYSQL_USERS_FROM_MEMORY pattern (4 aliases each: FROM MEMORY, FROM MEM, TO RUNTIME, TO RUN) - Replace the generic plugin fallback dispatch with MYSQLX-specific alias matching using is_admin_command_or_alias(), matching how MYSQL and PGSQL commands are dispatched - Use 'return false' pattern consistent with other admin commands	2 months ago
Rene Cannao	d34fb38162	refactor: remove PLUGIN prefix gate from plugin command registration ... Remove the 'PLUGIN ' prefix requirement from the plugin manager's command registration and dispatch. This allows plugins to register any canonical command string (e.g. 'LOAD MYSQLX USERS TO RUNTIME') instead of being forced into the 'PLUGIN <name> ...' namespace. Changes to lib/ProxySQL_PluginManager.cpp: - Delete kPluginCommandPrefix constant and has_plugin_command_prefix() - Remove prefix validation from register_command() - now only rejects empty canonical forms - Remove prefix check from dispatch_admin_command() - any registered command string can be dispatched Updated plugin_registry_unit-t.cpp to use canonical 'LOAD MYSQLX USERS TO RUNTIME' syntax instead of 'PLUGIN MYSQLX LOAD USERS TO RUNTIME'. The 'SELECT 1' test now succeeds (any string accepted) since the namespace restriction is gone.	2 months ago
Rene Cannao	136b8d7bfd	plan: mysqlx canonical admin commands implementation ... 6-task plan to replace PLUGIN MYSQLX prefix with canonical LOAD/SAVE MYSQLX ... TO RUNTIME/FROM MEMORY syntax.	2 months ago
Rene Cannao	0b18ae09ee	spec: mysqlx canonical admin commands design ... Replace PLUGIN MYSQLX prefix with first-class LOAD/SAVE MYSQLX commands matching the existing MYSQL/PGSQL admin command convention.	2 months ago
Rene Cannao	994d46dfd6	fix: use PRIu64 for portable uint64_t formatting in stats flush	2 months ago
Rene Cannao	31b9e86b59	fix: register mysqlx tests in CI groups and document proto source ... Register all plugin and mysqlx unit tests in groups.json under unit-tests-g1 so they run in CI: - plugin_manager_unit-t, plugin_config_unit-t, plugin_registry_unit-t - mysqlx_config_store_unit-t, mysqlx_protocol_unit-t, mysqlx_route_store_unit-t, mysqlx_stats_unit-t - test_mysqlx_plugin_load-t, test_mysqlx_admin_tables-t, test_mysqlx_listener_smoke-t Document protobuf source location and regeneration command in plugins/mysqlx/Makefile.	2 months ago
Rene Cannao	7cc246c71f	fix: core plugin ABI safety issues ... 1. Init ordering: move LoadConfiguredPlugins() after ProxySQL_Main_init_Admin_module() so get_admindb/configdb/statsdb return valid handles during plugin init(), not nullptr. 2. Null snapshot callbacks: assign stub functions returning nullptr to get_mysql_users_snapshot, get_mysql_servers_snapshot, and get_mysql_group_replication_hostgroups_snapshot instead of leaving them as null function pointers that crash when called. 3. Lifecycle: stop_all() now only calls stop() on plugins where started=true, not merely initialized. Prevents calling stop() on plugins that were never start()ed. 4. Destructor: remove unsynchronized read of g_active_plugin_manager (callers already clear it under the mutex before destruction).	2 months ago
Rene Cannao	1900db9e57	fix: correct MYSQL41 auth wire format for real MySQL 8.x ... The MySQL X Protocol MYSQL41 AuthenticateContinue auth_data must be formatted as schema\0username\0*UPPERCASE_HEX(scramble), not raw binary. Backend: AuthenticateContinue now sends \0user\0*HEX(scramble) instead of raw 20-byte binary. This matches what MySQL 8.x X Plugin expects. Frontend: handle_authenticate now parses \0user\0*HEX(scramble) from the client's AuthenticateContinue, hex-decodes the scramble, then verifies. This matches what mysqlsh and other conforming clients send. Backend: Add Notice-skipping loops before reading CONN_CAPABILITIES and SESS_AUTHENTICATE_CONTINUE from MySQL 8.x, which may send Notice frames at any point during the handshake sequence. Add mysqlx_hex_encode/mysqlx_hex_decode helpers.	2 months ago
Rene Cannao	f8f9debbe1	fix: address important code review findings ... 1. Replace select() with poll() in accept loop and relay to avoid FD_SETSIZE undefined behavior with high file descriptors 2. Make g_rr_index atomic for safe concurrent access 3. Add SO_RCVTIMEO/SO_SNDTIMEO (10s backend, 30s frontend) to prevent indefinite blocking from slow peers 4. Reject TLS CapabilitiesSet requests explicitly in Phase 1 5. Enforce require_tls per user — reject if set since Phase 1 does not implement TLS negotiation 6. Enforce allowed_auth_methods per user — check the comma-separated list before proceeding with auth	2 months ago
Rene Cannao	9a3b399eb0	fix: address critical code review findings ... 1. SQL injection in stats flush: escape route names with sqlite_escape() 2. Timing attack in PLAIN auth: use CRYPTO_memcmp for constant-time password comparison 3. OOM via oversized frame: add MYSQLX_MAX_PAYLOAD_SIZE (16MB) check in mysqlx_read_frame before allocating payload buffer 4. Thread safety: add shared_mutex to MysqlxConfigStore, shared_lock for readers (resolve_identity, pick_endpoint), unique_lock for writer (load_from_runtime), separate rr_mutex_ for round-robin counter mutation	2 months ago
Rene Cannao	d28980ddd8	docs: update mysqlx plugin wrap-up with tasks 6-9 complete	2 months ago
Rene Cannao	c2e90d3696	feat: add mysqlx stats tables and topology invalidation seam ... Add MysqlxStatsStore with atomic route counters (conn_ok, conn_err, bytes_sent, bytes_recv) and flush_to_sqlite() for stats_mysqlx_routes. Register stats_mysqlx_routes and stats_mysqlx_processlist tables in the plugin admin schema. Wire stats recording into the worker: record_conn_ok on successful backend connect, record_conn_err on failure. Add topology generation capture at session bind time as the Phase 2 seam for GR notification-driven route invalidation.	2 months ago
Rene Cannao	e087fdda4c	feat: add backend X sessions and hostgroup-based routing ... Add MysqlxBackendSession with TCP connect, X Protocol MYSQL41 auth to backend, and bidirectional byte-level relay via select(). Implement round_robin and round_robin_with_fallback endpoint selection strategies in MysqlxConfigStore::pick_endpoint(). Workers now connect to the backend after frontend auth and relay traffic until close. Phase 1 is one frontend = one backend, no pooling.	2 months ago
Rene Cannao	05ca510f2d	feat: implement frontend X Protocol handshake and auth ... Add mysqlx_protocol.h/cpp with frame encode/decode, MYSQL41 scramble auth using EVP SHA1, and protobuf message helpers for X Protocol Error/Ok/Capabilities/Auth frames. Add mysqlx_frontend_session.h/cpp implementing the full handshake state machine: CapabilitiesGet→Capabilities, CapabilitiesSet→Ok, AuthenticateStart→challenge→AuthenticateContinue→AuthenticateOk. Supports MYSQL41 and PLAIN auth methods. Enforces x_enabled flag, rejects pass_through backend auth mode. Workers now run the frontend session instead of immediately closing connections.	2 months ago
Rene Cannao	2beb621515	feat: add protobuf-compiled X Protocol message definitions ... Compile mysqlx*.proto files from MySQL Connector-C 8.4.0 into C++ sources. The plugin .so now links -lprotobuf for X Protocol frame/message encoding and decoding needed by Tasks 7-8.	2 months ago
Rene Cannao	5b5bbfbcaf	feat: add mysqlx listener sockets and worker threads ... Plugin start now opens TCP listeners for each active route in runtime_mysqlx_routes. An accept thread dispatches incoming connections to worker threads round-robin. Phase 1 workers accept-then-close; Tasks 7-8 will add X Protocol handshake and backend relay.	2 months ago
Rene Cannao	0b11bce37e	feat: add mysqlx runtime config store and load commands	2 months ago
Rene Cannao	782e019a8c	wip: capture mysqlx task 5 scaffolding and wrap-up status	2 months ago
Rene Cannao	ba45e631c5	fix: rebuild mysqlx plugin on ABI changes	2 months ago
Rene Cannao	f067f4ad0c	fix: keep mysqlx plugin smoke test rebuilds fresh	2 months ago
Rene Cannao	6df15c63c6	fix: complete mysqlx scaffold schema and test build	2 months ago
Rene Cannao	e24f54261a	fix: keep mysqlx plugin smoke test bridge fresh	2 months ago
Rene Cannao	8e7a99d36a	fix: align mysqlx plugin schema and smoke test	2 months ago
Rene Cannao	19d48bdc13	feat: scaffold mysqlx plugin module	2 months ago
Rene Cannao	9b87260b70	fix: harden plugin init failures and command dispatch	2 months ago
Rene Cannao	5dd717a8f1	fix: fail fast on plugin table conflicts	2 months ago
Rene Cannao	d036ba8327	fix: canonicalize plugin command registration	2 months ago
Rene Cannao	2430516600	fix: reject conflicting plugin registrations	2 months ago
Rene Cannao	123bb7eaf0	fix: harden plugin registry ABI and ownership	2 months ago
Rene Cannao	fd5f029474	fix: expose plugin db handles during startup	2 months ago
Rene Cannao	cd15afdd1e	feat: support plugin-owned admin tables and commands	2 months ago
Rene Cannao	80fa6bee24	fix: cover configured plugin lifecycle wiring	2 months ago
Rene Cannao	804771271b	feat: wire configured plugins into ProxySQL startup	2 months ago
Rene Cannao	95f5c71fe7	fix: keep paused plugin config test out of unit suite	2 months ago
Rene Cannao	da7e182719	fix: align plugin loader ABI and tests	2 months ago
Rene Cannao	7e1a12b8f7	feat: add generic plugin ABI and loader	2 months ago
Rene Cannao	8cecd064fa	chore: ignore local git worktrees	2 months ago
Rene Cannao	5392c0a6a2	Add mysqlx plugin design spec	2 months ago
René Cannaò	d7a26b79e9	Merge pull request #5577 from sysown/v3.0-ci0405 ... Fix CI test failures and workflow race conditions	2 months ago
Rene Cannao	78c8a3d5e3	Fail fast in purge-trigger setup if connection or stmt fails ... Address review feedback: instead of silently continuing when the purge-trigger reconnect/prepare/deallocate fails, return false immediately with a diagnostic message.	2 months ago
Rene Cannao	3296ed5a07	Moving test_cluster_sync_mysql_servers-t from legacy-g3 to legacy-g5	2 months ago
Rene Cannao	26c5a25724	Fix read_only test assuming default_hostgroup=0 ... The test configures mysql_servers with writer_hostgroup=0 and reader_hostgroup=1, but the CI infrastructure sets users' default_hostgroup to 1300. When the test opens a proxy connection and runs BEGIN, ProxySQL routes to hostgroup 1300 which has no servers, causing a 10s timeout. Fix by setting default_hostgroup=0 for the test user at the start of each scenario.	2 months ago
Rene Cannao	1261d18a95	Fix SHOW WARNINGS test to work with MySQL 5.7 ... CAST('abc' AS DOUBLE) is MySQL 8.0+ syntax and fails on the legacy test group which uses MySQL 5.7. Use CAST('abc' AS SIGNED) instead, which produces a truncation warning on all MySQL versions. Fixes regression from PR #5548.	2 months ago
Rene Cannao	9098992f82	Fix timing issue in PgSQL prepared statement purge test ... The purge verification in test 1 was checking the statement count immediately after creating statements. The purge mechanism has a 1-second minimum interval between attempts and only removes statements with ref_count_client == 0. Fix by closing the connection (dropping refcounts), waiting 3 seconds, then triggering a new refcount change to invoke the purge before checking.	2 months ago
Rene Cannao	73a561450d	Fix race condition in CI-legacy-* workflow triggers ... All 4 CI-legacy workflows used `types: [ in_progress ]` which fired them before CI-builds finished, causing cache-miss failures on the build artifacts. Change to `types: [ completed ]` and add success guard, matching the pattern used by CI-taptests-groups. Affected workflows: - CI-legacy-clickhouse-g1 - CI-legacy-g2 - CI-legacy-g2-genai - CI-legacy-g4	2 months ago
Rene Cannao	fe5a819051	Add 3 missing tests to groups.json ... Register newly compiled test binaries that were missing from groups.json, causing check_groups.py to block CI runs: - gtid_server_data_unit-t → unit-tests-g1 - test_ffto_mysql_errors-t → legacy-g4, mysql84-g4 - test_ffto_pgsql_error_stats-t → legacy-g4, mysql84-g4	2 months ago
René Cannaò	7510d8073a	Merge pull request #5553 from sysown/fix/5539-ffto-default-by-tier ... Disable FFTO by default in 3.1.x, keep enabled in 4.0.x	2 months ago
René Cannaò	ceb9690891	Merge commit from fork ... Fix COM_STMT_SEND_LONG_DATA short packet handling	2 months ago
René Cannaò	3659ba85fb	Merge branch 'v3.0' into advisory/com-stmt-send-long-data-fix-1 ... Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago