1010 Commits (cdfd1543a4e8b81b7e0ac7aefb35d0857ea8fcd9)

Author	SHA1	Message	Date
René Cannaò	9b24fdf4b8	Prevent crash COM_STMT_EXECUTE and invalid stmt_id ... If an invalid stmt_id is passed to COM_STMT_EXECUTE , ProxySQL used to crash due to an assert(). It seems that some buggy clients execute COM_STMT_EXECUTE with an invalid stmt_id after an auto-reconnect. This commit returns an error to the client. Closes #3371 Closes #3808 Closes #4474	2 years ago
René Cannaò	45b517ac7b	Removed dead code	2 years ago
René Cannaò	27a1bbb810	Adding MySQL_Session::set_previous_status_mode3() ... This function helps removing some redundant code	2 years ago
René Cannaò	acbedfb4b3	Call housekeeping_before_pkts() only if hgs_expired_conns.size()	2 years ago
René Cannaò	1bc9d9e5f4	Several code documentation	2 years ago
René Cannaò	9d788c04a9	Merge pull request #4467 from sysown/v2.6-4466 ... ssl_params: use NULL instead of empty string #4466	2 years ago
René Cannaò	c971d401a4	Use of ssl_params in kill_query_thread()	2 years ago
René Cannaò	b1e998ba71	Fix incorrect error handling in kill_query_thread	2 years ago
Javier Jaramago Fernández	a9e7af8a7b	Add 'session_id' to server lost during query error msg ... If multiple backend connections are lost at the same time, the same message will appear multiple times, one per backend connection that was lost during a query, this info wasn't reflected in the msg before.	2 years ago
Javier Jaramago Fernández	caed360eeb	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x_sha2pass_draft3	2 years ago
Javier Jaramago Fernández	ab8af07c19	Add 'switching_auth_sent' to 'PROXYSQL INTERNAL SESSION' ... Improved observability for auth switch performed during authentication. The new field 'switching_auth_sent' is only updated when an actual auth switch requested to the client.	2 years ago
René Cannaò	7f57f20e5a	Merge pull request #4430 from sysown/v2.x-4241 ... Added metric MultiplexDisabled_ext #4241	2 years ago
René Cannaò	41cd740701	Added metric MultiplexDisabled_ext #4241 ... In the output of PROXYSQL INTERNAL SESSION and stats_mysql_processlist.extended_info , MultiplexDisabled was only returning the output of MySQL_Connection::MultiplexDisabled() . If there was a transaction, or an error, multiplexing was disabled but MultiplexDisabled() was still reporting false. Therefore it was necessary to also check server_status flag and last_errno. This commits intruduces MultiplexDisabled_ext , that reports the output of: MySQL_Connection::MultiplexDisabled() || MySQL_Connection::isActiveTransaction() This should make troubleshooting easier. Also, removed any reference to deprecated STATUS_MYSQL_CONNECTION_TRANSACTION . Closes #4241	2 years ago
René Cannaò	e958946b82	Handle STATUS command without backends ... Handles special queries executed by the STATUS command in mysql cli . Specifically: - "select DATABASE(), USER() limit 1" - "select @@character_set_client, @@character_set_connection, @@character_set_server, @@character_set_database limit 1" Closes #4396 Closes #4426	2 years ago
René Cannaò	c3c9746bbc	Merge branch 'v2.x' into v2.x_sha2pass_draft3	2 years ago
Javier Jaramago Fernández	e8d2254689	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x-aurora_autodiscovery-refactor_cluster_mysql_servers-gr_bootstrap_mode	2 years ago
René Cannaò	3c2418246c	Merge branch 'v2.x' into v2.x_sha2pass_draft3	2 years ago
René Cannaò	699fe7efcd	Moved proxysql_find_charset_* functions out of MySQL_Thread.cpp	2 years ago
René Cannaò	1e98de78af	Merge pull request #4365 from sysown/v2.x_warning_support ... Added warnings handling	2 years ago
Rahim Kanji	8606742583	Merge remote-tracking branch 'Master/v2.x' into v2.x_warning_support_final ... # Conflicts: # test/tap/tests/set_testing-240-t.cpp	2 years ago
Rahim Kanji	09eb50a83e	Remove any trailing spaces and semicolons from the SET statement	2 years ago
Rahim Kanji	e1c489acb1	* If the backend server has CLIENT_DEPRECATE_EOF enabled, and the client does not support CLIENT_DEPRECATE_EOF, warning_count will be '0' in intermediate EOF packet. ... * Suppress the display of warning counts in the "SHOW WARNINGS" statement.	2 years ago
René Cannaò	b6deb15ec3	Merge pull request #4372 from sysown/v2.x_prep_stmt_mem_usage ... Added memory usage monitoring for the prepared statement cache.	2 years ago
Rahim Kanji	045d6bcaeb	* Execute all test cases with 'CLIENT_DEPRECATE_EOF' both enabled and disabled. ... * Introduced 'ps_type' enum to differentiate between preparing a statement and executing a statement * Fixed issue where the warning count fails to reset when the SET statement generates a warning. * Resolved the issue where the 'server_status' and 'warning count' were not accurately represented in the statement. * Replaced 'mysql_warning_count' with 'mysql_stmt_warning_count' for retrieving the warning count in statements. * Added 'handle_warning' field in hostgroup_attributes TAP test * Updated warnings TAP test	2 years ago
Rahim Kanji	dae3d669b9	* Setting 'warning_count' as soon as query is executed. ... * 'MySQL_Connection::warning_count' will be globally employed for managing multiplexing control and transmitting the warning count to the client * Fixed prepare statement bug: When preparing, if the digest matches, the result set is retrieved from the cache and sent to the client. Note: Currently using 'mysql_warning_count' to retrieve the warning count for prepared statement.	2 years ago
Rahim Kanji	05208e2839	* Update warning_count as soon as query is executed.	2 years ago
Rahim Kanji	743cd502a5	* Updated variable name from 'mysql-query_cache_with_warnings_support' to 'mysql-query_cache_handle_warnings' ... * Introduced global variable 'mysql-handle_warnings' to control warning support in ProxySQL * Included 'handling_warnings' flag in the 'mysql_hostgroup_attributes' table (hostgroup_settings). This flag holds top priority and can override the value of the global variable 'mysql_handle_warnings'.	2 years ago
Rahim Kanji	1807315950	Merge branch 'v2.x_hostgroup_attr_settings' into v2.x_warnings_support	2 years ago
Rahim Kanji	b588798a08	Few fixes	2 years ago
Rahim Kanji	989687c68a	Implemented memory usage monitoring for the prepared statement cache with the following changes: ... * Added two new variables to the 'stats_memory_metrics' table: prepare_statement_metadata_memory prepare_statement_backend_memory * Introduced corresponding variables in the Prometheus exporter to measure memory usage of prepare statement metadata and prepare statement backend.	2 years ago
Rahim Kanji	d2b8f7d54e	Fixed code style	2 years ago
Rahim Kanji	6b295477d6	Enhanced Warnings handling in ProxySQL: ... * Implemented 'SHOW WARNINGS' and 'SHOW COUNT(*) FROM WARNINGS' query handling. * When a query produces warnings, the warning count is now included in the query response. Additionally, a new variable 'mysql-query_cache_with_warnings_support' has been introduced for the query cache feature: * A value of '0' means that if a query execution produces warnings, the resultset will not be saved in the query cache. * A value of '1' indicates that if a query produces warnings, the resultset will be saved in the query cache, but the warning count in that resultset will be set to '0'. ** Note: * Warning handling is dependent on the query digest and 'mysql-query_digests' must be enabled for it to work. * Warnings saved in logfile ['mysql-log_mysql_warnings_enabled'] and the current feature can work in conjunction with each other.	2 years ago
Miro Stauder	b1dc534757	refactor out pktH	3 years ago
Miro Stauder	917154bf93	fix pktH init/destructor	3 years ago
Miro Stauder	61f0c4636b	various warnings fixes	3 years ago
Javier Jaramago Fernández	bfca112ca7	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x-4300	3 years ago
Javier Jaramago Fernández	ecf4f69fe0	Fix Admin support for MySQL client '8.1.0' - Closes #4300 ... MySQL client check command for dollars quote support ('SELECT $$'), is now intercepted in both MySQL and Admin interfaces. The error reported to the client is dependent of 'mysql-server_version' variable value.	3 years ago
Javier Jaramago Fernández	bb40e9e431	Fix 'COMMIT|ROLLBACK' forwarding to backend connections - Closes #4264 ... These commands are now forwarded to the backend connections from a session with potential transaction statuses, using the following priority order: 1. Connections flagged with 'SERVER_STATUS_IN_TRANS', or 'autocommit=0' when 'autocommit_false_is_transaction' is set. 2. Connections with 'autocommit=0' holding a 'SAVEPOINT'. 3. Connections with 'unknown transaction status', e.g: connections with errors.	3 years ago
Javier Jaramago Fernández	858c430b59	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x-gr_bootstrap_mode	3 years ago
René Cannaò	299c833eb3	Merge pull request #4283 from sysown/v2.x_reordering_mysql_variables ... Reordered SQL_ISOLATION_LEVEL, SQL_TRANSACTION_READ, and SQL_WSREP_SYNC_WAIT tracked variables	3 years ago
Rahim Kanji	8d03589cf9	Moved SQL_ISOLATION_LEVEL, SQL_TRANSACTION_READ, and SQL_WSREP_SYNC_WAIT to the higher bound.	3 years ago
Rahim Kanji	a908f2a17b	Added transaction_isolation_level and transaction_read_only variable support.	3 years ago
Rahim Kanji	a3d29863e8	Adding SET TRANSACTION ISOLATION LEVEL * support	3 years ago
René Cannaò	e3865be3a8	Minor changes in branches ... Also added few FIXME to review part of the code	3 years ago
René Cannaò	9ede04de52	Merge branch 'v2.x' into v2.x_sha2pass_draft3	3 years ago
René Cannaò	37f8a50b90	Adding variable mysql-set_parser_algorithm ... Variable mysql-set_parser_algorithm defines which algorithm is used by SetParser for the parsing of SET statements. If value is 1: parse1() is used If value is 2: parse1v2() is used parse1v2() allows also the using a single SetParser per MySQL_Thread to process all SET statements. Regex is compiled only once. set_testing-240-t was also modified to test both algorithms	3 years ago
René Cannaò	86ce115529	Merge pull request #4216 from sysown/v2.x-track_slow_query_vars ... Track some slow query variables	3 years ago
René Cannaò	73ac61b0fb	Remove tracking of log_queries_not_using_indexes ... log_queries_not_using_indexes is not enabled because in MySQL it is *only* a global variable, while in MariaDB is a global *and* session variable . We believe it is not the time to create a lot of exceptions and complex logic for conflicting backend implementations	3 years ago
René Cannaò	dc732c5628	Add support for sql_quote_show_create #4254	3 years ago
René Cannaò	8106ae5ee3	Merge branch 'v2.x' into v2.x_sha2pass_draft3	3 years ago
René Cannaò	629aa3d93b	Drafting TAP test_change_user-t	3 years ago
Rahim Kanji	95b22b96fb	Added SSL connection support in kill_query_thread	3 years ago
Rahim Kanji	a1fcf5d94f	Added SSLKeylog in ProxySQL Modules	3 years ago
Rahim Kanji	8f899e34f9	Added support for SSLKEYLOGFILE ... * 'admin-ssl_keylog_file' variable has been introduced to allow users to specify the path for the SSLKEYLOG file. The file path can be an absolute path or relative to the ProxySQL data directory. * Assigning an empty path to the 'admin-ssl_keylog_file' variable signifies that the SSLKEYLOG file feature is disabled. * In case an invalid path is provided for the SSLKEYLOG file, ProxySQL will automatically revert to the last valid path value. * 'PROXYSQL FLUSH LOGS' command can be used to rotate SSLKEYLOG file. # Conflicts: # lib/mysql_connection.cpp	3 years ago
Javier Jaramago Fernández	3a8256082e	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x-gr_bootstrap_mode	3 years ago
Javier Jaramago Fernández	fe8428e1cf	Remove/Move several explicit 'MySQL_Session' status flag changes ... Setting 'MySQL_Session::status', and 'client_myds::DSS' flags before a call to 'RequestEnd' is redundant, and in some scenarios even dangerous. 'RequestEnd' should handle this for regular sessions.	3 years ago
Javier Jaramago Fernández	ff2e1a2b85	Fix crash when attempting to log failed 'SET NAMES' ... Session 'status' and 'client_myds->DSS' should never be modified for a regular session prior to calling 'RequestEnd'. It's 'RequestEnd' responsibility to appropriately change these statuses after the rest of cleanup operations for the request has taken place, including logging.	3 years ago
René Cannaò	3453c0306f	Do not perform query logging in fast_forward mode	3 years ago
René Cannaò	cf6f4f765e	Working prototype of caching_sha2_password ... Now mysql_users.password can store the authentication_string as in MySQL's mysql.user table. Note: this commit also changes SALT_LEN_MAX in SHA-crypt code from 16 to 20 because MySQL caching_sha2_password uses 20 bytes salt	3 years ago
René Cannaò	7f727b3aca	Merge pull request #4213 from sysown/v.2x_dns_cache_issue_4210 ... DNS module no longer regards the UNIX socket path as a hostname	3 years ago
Phil Porada	41211f5b39	Track some slow query variables	3 years ago
Rahim Kanji	3865c81873	DNS Cache module has been updated so that it no longer regards the UNIX socket path as a hostname.	3 years ago
René Cannaò	d23b286af1	2nd refactoring of process_pkt_handshake_response	3 years ago
René Cannaò	2f016dd6d0	Merge pull request #4205 from sysown/v2.x-ssl3_warnings2 ... Fixes several compiler warnings - DO NOT MERGE	3 years ago
René Cannaò	f7b2c5e766	Merge pull request #4203 from sysown/v2.x-log_insert_id2 ... V2.x log last_insert_id	3 years ago
René Cannaò	a31f83473d	Fix several warnings	3 years ago
René Cannaò	af710229b3	Move the end timer for stats_time_query_processor	3 years ago
René Cannaò	c0745b42c2	Adding last_insert_id and last_gtid to MySQL_Logger	3 years ago
Javier Jaramago Fernández	04fb2cad33	Add two new session tracking variables ... - Added variable 'sql_generate_invisible_primary_key'. - Added variable 'sql_require_primary_key'.	3 years ago
Samantha	77ebc606cd	Add support for MariaDB max_statement_time	3 years ago
Jorge Vallecillo	6673efcfaa	Fix typo - consecutive 'the' occurrences	3 years ago
René Cannaò	1902eb5a7b	More testing in test_max_transaction_time-t ... IN PROXYSQL SESSION INTERNAL replace transaction_started_at with transaction_time_ms	3 years ago
René Cannaò	069140f79e	Automatically start a transaction when running a query ... This commit also introduces 2 output for PROXYSQL INTERNAL SESSION: - active_transactions - transaction_started_at Enhanced the TAP tests to also verify the above metrics	3 years ago
Javier Sánchez Parra	66e7f1da88	Set active_transactions and transaction_started_at when the query completes	3 years ago
Javier Sánchez Parra	0aa60813fb	save unneeded fetching of all 'server_status'	3 years ago
Javier Sánchez Parra	b2312c07ff	Fix max_transaction_time boundaries between transactions ... Fixes issue #3957	3 years ago
René Cannaò	8b066330d4	Merge pull request #4110 from sysown/v2.x-HG_init_connect ... mysql_hostgroup_attributes.init_connect	3 years ago
René Cannaò	347608b00f	Merge pull request #4114 from sysown/v2.x_fast_forward_SSL_2302 ... Set correct backend encryption when switching to fast_forward	3 years ago
René Cannaò	e7eb690ea2	Merge pull request #4105 from sysown/v2.x-assign_hostgroup_from_previous_query ... Assign hostgroup from previous query	3 years ago
René Cannaò	e487ddf8ec	Set correct backend encryption when switching to fast_forward ... When receiving MYSQL_COM_BINLOG_DUMP , MYSQL_COM_BINLOG_DUMP_GTID or MYSQL_COM_REGISTER_SLAVE , proxysql automatically switches to fast_forward . Although it is important to correctly configure "encrypted" in the backend data stream if needed. Used PMC-10005 for reference , as this is implemented similarly in many parts of the code. During the switch proxy_info() now also reports the client and the command received.	3 years ago
René Cannaò	d655695d08	mysql_hostgroup_attributes.init_connect ... Implementation of MySQL HostGroup Attribute mysql_hostgroup_attributes.init_connect	3 years ago
Javier Jaramago Fernández	bd83a90f27	Fix 'user-after-free' when logging rewrited 'SET NAMES' queries	3 years ago
Javier Sánchez Parra	1e00e1f021	Assign hostgroup from previous COM_QUERY ... The destination hostgroup assigned from previous COM_QUERY commands is the one used to establish the fast_forward connection. As a result, multiple binlog clients can consume binlog events from different MySQL hostgroups using the same username.	3 years ago
René Cannaò	cfe5c0bcf0	Merge pull request #4091 from sysown/v2.x-HGMimpr01_mysql_hostgroup_attributes ... Drafting mysql_hostgroup_attributes	3 years ago
René Cannaò	f3c604eb84	Implemented mysql_hostgroup_attributes.multiplex ... If mysql_hostgroup_attributes.multiplex: - 0 : multiplexing is always disabled - 1 : multiplexing is enabled for the hostgroup, but other criteria can disable multiplexing (transaction, temp tables, query rules, etc)	3 years ago
Javier Jaramago Fernández	b66f23fcbd	Improve comments for 'MYSQL_COM_BINLOG_DUMP' session preparation	3 years ago
Javier Jaramago Fernández	982272aa96	Fix 'connect_timeout' and 'connect_retries' for 'MYSQL_COM_BINLOG_DUMP' ... Fix honoring of 'connect_timeout_server_max' and 'connect_retries_on_failure' for 'fast_forward' sessions created by 'MYSQL_COM_BINLOG_DUMP' when session still doesn't own a backend connection.	3 years ago
Javier Sánchez Parra	fb4740929e	Commands that read the binlog enable fast forward ... For commands BINLOG_DUMP, BINLOG_DUMP_GTID and REGISTER_SLAVE a lot of the features provided by ProxySQL aren't useful, like multiplexing, query parsing, etc. For this reason, ProxySQL enable fast_forward when it receives these commands.	3 years ago
Jared Jetsel	1424967ed6	Receiving COM_BINLOG_DUMP_GTID enabled session fast forwaring ... * If the COM_BINLOG_DUMP_GTID is received, a warning is logged, and then the session_fast_foward is set to true	3 years ago
René Cannaò	71e2510ef6	Code cleanup on MySQL_HostGroups_Manager ... Some rework to try to reduce duplicated code	3 years ago
René Cannaò	709149f243	Merge pull request #4052 from sysown/v2.x-fix_autocommit_handshake_resp ... Fix autocommit invalidly reported in several cases	3 years ago
Javier Jaramago Fernández	c64d5a125a	Fix invalid memory access in 'handler_CommitRollback' for empty queries	3 years ago
Javier Sánchez Parra	697a9b600f	Fix autocommit invalidly reported in several cases ... Otherwise, autocommit status flag is always zero, instead of displaying its true value. OK responses were reporting an invalid autocommit during handshake, reset_connection and change_user petitions.	3 years ago
Javier Jaramago Fernández	2f2e385185	Fix delete call on pointer to incomplete type 'ProxySQL_Node_Address' ... Deleting a pointer to an incomplete type may cause undefined behavior	3 years ago
Javier Jaramago Fernández	48d070229b	Merge pull request #4051 from sysown/v2.x-parse_failure_logs_digest_fixes ... Fix some logging cases for `mysql-parse_failure_logs_digest`	3 years ago
Javier Jaramago Fernández	4e556c6c4f	Fix some logging cases for 'parse_failure_logs_digest' #4000	3 years ago
Javier Jaramago Fernández	cdaa8b1764	Honor 'mysql-verbose_query_error' format for warnings #3935	3 years ago
Javier Jaramago Fernández	300532d6e2	Fix multiple warnings in logging function calls	3 years ago
René Cannaò	6bbed9683e	Merge pull request #4045 from sysown/v2.x-4000 ... Add new variable 'mysql-parse_failure_logs_digest'	3 years ago
René Cannaò	ec93211d02	Merge pull request #4024 from sysown/v2.x_LocalDNSCache ... Feature: ProxySQL local DNS Cache	3 years ago