1010 Commits (cdfd1543a4e8b81b7e0ac7aefb35d0857ea8fcd9)

Author	SHA1	Message	Date
René Cannaò	20446ebae7	Merge pull request #3826 from bpmdoty/v2.x ... Don't intercept SELECT CONNECTION_ID() as COM_STMT_PREPARE	4 years ago
Mike Doty	565799b92b	Update conditional to check speifically for COM_QUERY instead of specifically ignoring COM_STMT_PREPARE. Add conditional to SELECT LAST_INSERT_ID(), SELECT LAST_INSERT_ID() LIMIT 1, SELECT @@IDENTITY, SELECT @@IDENTITY LIMIT 1 intercepts.	4 years ago
Javier Jaramago Fernández	fd968f4b02	Create new message code 'PCM-10002' for 'Unable to parse query' error	4 years ago
Javier Jaramago Fernández	ca7f5ea91f	Create new message code 'PCM-10001' for 'Unexpected packet from client' error	4 years ago
Mike Doty	a5b020a5b2	Do not intercept COM_STMT_PREPARE packets for SELECT CONNECTION_ID() ... Hopefully this fixes issue #2564.	4 years ago
Javier Jaramago Fernández	4452faa037	Add missing newline char at end of 'SSL is required' error message	4 years ago
René Cannaò	b5bdb47dae	Add support for wsrep_osu_method	4 years ago
René Cannaò	25fc1def8e	Fixed a buffer overflow in new variables	4 years ago
René Cannaò	fd05b37762	Added support for more session variables: ... - aurora_read_replica_read_committed - group_replication_consistency - query_cache_type	4 years ago
Javier Jaramago Fernández	3a19f717ac	Fix 'mysql-connect_retries_delay' not being honored	4 years ago
René Cannaò	43c6acb218	Merge branch 'v2.x' into v2.1.2-cluster	4 years ago
René Cannaò	db8275a66d	Merge branch 'v2.x' into v2.x-3504	4 years ago
Javier Jaramago Fernández	c51d78c10b	Fix 'create_new_connection' annotation failure due to thread-local connection pool ... A thread local connection should be retrieved only if 'fast_forward' is disabled AND 'create_new_connection' wasn't present in the query.	4 years ago
René Cannaò	d20683c589	Merge pull request #3702 from sysown/v2.x-variables ... Improvements on how MySQL variables are processed	4 years ago
René Cannaò	8d83bd3562	Merge branch 'v2.x' into v2.1.2-cluster	4 years ago
René Cannaò	e983fc6827	Adding support for more MySQL variables ... New variables supported: - lc_messages - lc_time_names - long_query_time - max_execution_time - max_heap_table_size - max_sort_length - optimizer_prune_level - optimizer_search_depth - optimizer_switch - sort_buffer_size - sql_big_selects - timestamp - tmp_table_size Note: sql_big_selects is still not fully supported when combined with max_join_size. In set testing TAP ,set large max_execution_time. If max_execution_time is too small, the TAP test may fails because the queries will timeout.	4 years ago
René Cannaò	2ba9c401f1	Bug fixes in the new implementation of tracking mysql variables ... Better parsing of SET SQL_LOG_BIN . SQL_LOG_BIN is now managed by the same functions that handle boolean variables instead of the now deprecated MySQL_Session::handler_WCD_SS_MCQ_qpo_Parse_SQL_LOG_BIN() For naming convention, enum value SQL_LOG_BIN was renamed to SQL_SQL_LOG_BIN In MySQL_Thread we also deprecated match_regexes[0] , previously used to parse `set sql_log_bin`. Functions Variable::fill_server_internal_session() and Variable::fill_client_internal_session() seems to handle sql_log_bin as a special value. This exception was removed. Fixed a bug in MySQL_Session::generate_proxysql_internal_session_json() where when backend variables needed to be generated, fill_client_internal_session() was incorrectly called instead of fill_server_internal_session() , leading to incorrect values reported by `PROXYSQL INTERNAL SESSION`	4 years ago
René Cannaò	e0e149d9b2	Merge pull request #3710 from sysown/v2.x-3690 ... Fixed invalid handling of large packets for Admin - Closes #3690	4 years ago
Javier Jaramago Fernández	8cd505bde6	Added support for 'COM_RESET_CONNECTION' #2021	4 years ago
Javier Jaramago Fernández	bcb009fc24	Revert "Merge pull request #3645 from sysown/v2.x-2021" ... This reverts commit 9561cb3ef2, reversing changes made to 7edfec6f3f.	4 years ago
Javier Jaramago Fernández	88dc295781	Fixed invalid handling of large packets in 'SQLite3_to_MySQL' function #3690 ... - Provided a new function to partially initialize 'MySQL_ResultSet'. - Replaced 'generate_pkt_row' in favor of 'generate_pkt_row3' for resulset writing.	4 years ago
René Cannaò	497ef76478	Merge branch 'v2.x' into v2.x-variables	4 years ago
René Cannaò	d335bfb899	Improvements on how MySQL variables are processed ... Deprecated variables: - net_write_timeout Renamed set_testing-t.csv to set_testing-t.csv.obsolete , and removed net_write_timeout from set_testing-t.csv Variables added to ignore list: - net_write_timeout - net_buffer_length - read_buffer_size - read_rnd_buffer_size Added support for quoting with backtick Renamed `enum variable_name` into `enum mysql_variable_name` for better readibility `enum mysql_variable_name` has variable names alphabetically ordered after SQL_NAME_LAST_LOW_WM `mysql_tracked_variables` has variable names alphabetically ordered after SQL_NAME_LAST_LOW_WM A lot of new variables added in `mysql_tracked_variables` , although not all tracked yet (TODO) In `MySQL_Variables::MySQL_Variables()`: - if `internal_variable_name` in `mysql_tracked_variables` is NULL , it will be automatically initialized - it performs some sanity check between `enum mysql_variable_name` and `mysql_tracked_variables` Testing: - refactored code in set_testing-t.cpp and set_testing-multi-t.cpp - added set_testing-240-t.cpp to test improvements in 2.4.0 - generate_set_session_csv to automatically create set_testing-240.csv used by set_testing-240-t	4 years ago
René Cannaò	e892413d1a	Merge branch 'v2.x' into v2.x-2021	4 years ago
René Cannaò	aed1f205d4	Merge branch 'v2.x' into v2.x-3655	4 years ago
René Cannaò	a6edd02a9b	Revert "Merge branch 'v2.x' into v2.x-2021" ... This reverts commit 3a3931f2d4, reversing changes made to 4694ab775e.	4 years ago
René Cannaò	3a3931f2d4	Merge branch 'v2.x' into v2.x-2021	4 years ago
René Cannaò	22ed00e2f7	Merge pull request #3652 from sysown/v2.x-3606 ... Fixes MySQL warnings are returned as results of the next executed query - Closes #3606	4 years ago
Javier Jaramago Fernández	dc4bf3ccce	Added 'schemaname' to userinfo for 'PROXYSQL INTERNAL SESSION' command #3655	4 years ago
Javier Jaramago Fernández	86e5caf6ea	Fixed handling of splitted packets during 'CONNECTING_SERVER' state for 'FAST_FORWARD' mode	4 years ago
Javier Jaramago Fernández	062381efd4	Fixed crashes in 'MySQL_Session::get_pkts_from_client' when 'mysql-query_digests' are disabled #3655	4 years ago
Javier Jaramago Fernández	a49433cc91	Manually set 'POLLOUT' event for 'SHOW_WARNINGS' session status to ensure sending by 'MySQL_Connection' #3606	4 years ago
Javier Jaramago Fernández	4312cd9a72	Moved session cleanup after error report for 'SHOW_WARNINGS' #3606	4 years ago
Javier Jaramago Fernández	c3d0ecd84f	Improved implementation of 'mysql-log_mysql_warnings_enabled' #3606	4 years ago
Javier Jaramago Fernández	e76882c2f9	Added support for 'COM_RESET_CONNECTION' #2021	4 years ago
Javier Jaramago Fernández	d7bef92b57	Added missing new-line character for access denied 'proxy_error' for 'COM_CHANGE_USER' #3504	5 years ago
Javier Jaramago Fernández	8e97f5a19c	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x-3504	5 years ago
Javier Jaramago Fernández	b4c7b9323d	Merge pull request #3621 from sysown/v2.x-3620 ... Fixes memory leaks detected during testing - Closes #3620	5 years ago
Javier Jaramago Fernández	c268259bde	Fixed memory leak of client received packet when SSL connection is initiated #3620	5 years ago
Javier Jaramago Fernández	36abd62314	Fixed memory leak for 'client_addr' in case of wrong credentials for frontend connection #3620	5 years ago
Javier Jaramago Fernández	6e533cb5d9	Merge branch 'v2.x' of github.com:sysown/proxysql into v2.x-client_err_limit	5 years ago
René Cannaò	3a481ecb89	Removing some printf	5 years ago
René Cannaò	b485623d6f	Reimplemented the handling of comments in 'USE' statements #3493 ... This commits partially revert 0dde4adb21 It also improve the TAP test reg_test_3493-USE_with_comment-t.cpp with a variety of combinations, that helped find a bug in the tokenizer mysql_query_digest_and_first_comment()	5 years ago
René Cannaò	48562faaf1	Merge branch 'v2.x' into v2.1.2-cluster	5 years ago
René Cannaò	aceeaf79ed	Disabled prometheus metrics dump , see #3571 ... This commit also fixes some minor memory corruptions	5 years ago
René Cannaò	0da250ec8d	Merge pull request #3491 from csoulios/ldap-auth-changes ... Clean up LDAP authenticator	5 years ago
René Cannaò	08ea308033	Merge pull request #3552 from sysown/v2.x-ssl_no-rsa ... Allows SSL privake keys other than RSA , and implement PROXYSQL RELOAD TLS	5 years ago
René Cannaò	ebbd9845bd	Merge branch 'v2.x' into v2.1.2-cluster	5 years ago
René Cannaò	228c0bfd79	Merge branch 'v2.x' into v2.x-3504	5 years ago
Javier Jaramago Fernández	25df228960	Fixed double-free memory corruption due to unitialized memory in prepared statements bind buffers #3546	5 years ago
René Cannaò	148264cd8b	Disabled prometheus metrics dump , see #3571 ... This commit also fixes some minor memory corruptions	5 years ago
René Cannaò	af27c0b108	Merge branch 'v2.x' into v2.1.2-cluster	5 years ago
René Cannaò	3de13665e8	Merge pull request #3557 from sysown/v2.x-ccov2 ... More code coverage	5 years ago
René Cannaò	2145507c22	If a session is locked on hostgroup , autocommit is copied from backend connection ... Closes #3459	5 years ago
Javier Jaramago Fernández	e2dd0a30cd	Initial implementation for 'client_error_limit' ... Add initial support for FR limiting the number of connection errors that can be initiated from a particular address before deniying future connections from that address. Feature is controlled by new introduced variables: - mysql-client_host_error_counts - mysql-client_host_cache_size	5 years ago
René Cannaò	194243503a	Adding LCOV_EXCL_START around assert(0) ... LCOV_EXCL_START and LCOV_EXCL_STOP around assert(0) will improve code coverage	5 years ago
René Cannaò	b912d978b0	Removing or commenting legacy/unused code	5 years ago
René Cannaò	241a5e54d7	Draft to reimplement how session variables are handled	5 years ago
René Cannaò	fd7b5f8f50	Implemented PROXYSQL RELOAD TLS ... Command PROXYSQL RELOAD TLS is able to load new key/cert files and create a new SSL context. Loading of SSL can happens in two stages: * during bootstrap: if it fails, proxysql dies * running PROXYSQL RELOAD TLS: if it fails, proxysql will keep the old SSL context This new method should successfully handle errors like missing or corrupted files. We are also adding two buffers used to store the key/cert, to be used by the web interface.	5 years ago
René Cannaò	e38562df40	Merge branch 'v2.x' into v2.x-PS-err3024	5 years ago
René Cannaò	fce7a0204c	Handle binary protocol resultset with ERR #3547 ... This commit add the support of ERR packet in binary protocol resultset, for example due to MAX_EXECUTION_TIME while running a prepared statement. It also changes how EOF packets are added: instead of writing the EOF in the resultset buffer, the EOF packet is written in its own packet. This allows to easily remove it if needed. It also fix what seems (not sure) a bug in MariaDB client library, where if a prepared statement is interrupted it cannot be executed again	5 years ago
Christos Soulios	6030677258	Merge branch 'v2.x' into ldap-auth-changes	5 years ago
Christos Soulios	8136a6f4d0	Addressed reviewer comments	5 years ago
Javier Jaramago Fernández	1c319c021d	Fixed check for 'enable_load_data_local_infile' placement and added conditional extra verbosity to warning message #3500	5 years ago
Christos Soulios	9d19c70e8c	Merge branch 'v2.x' into ldap-auth-changes	5 years ago
Javier Jaramago Fernández	1f4f86d5ce	Added mysql variable to enable unsupported query 'LOAD DATA LOCAL INFILE' issuing warning message #3500	5 years ago
Christos Soulios	21803220e1	Merge branch 'v2.x' into ldap-auth-changes	5 years ago
Christos Soulios	4359b1f72f	Count connections for frontend user, not backend	5 years ago
Javier Jaramago Fernández	5e0dc81e5e	Added support for 'Auth Switch Request' for 'COM_CHANGE_USER' #3504	5 years ago
René Cannaò	1ee232bf85	Removed dead code from MySQL_Session	5 years ago
René Cannaò	81e0bf7edb	Merge pull request #3467 from sysown/v2.x-misc1 ... V2.x misc1	5 years ago
René Cannaò	805301107f	Merge pull request #3488 from sysown/v2.x-3487 ... Closes #3487: Add client information for multi-statements parsing error message	5 years ago
Javier Jaramago Fernández	0dde4adb21	Added support for comments in 'USE' statements #3493	5 years ago
Javier Jaramago Fernández	29697db578	Added client information to error generated when multi-statement command fails to be parsed #3487	5 years ago
Christos Soulios	524d23947d	Minor cleanup	5 years ago
Christos Soulios	df19d16f14	Passed attributes as param to LDAP auth ... Removed ldap_ctx as ldap context is managed in the plugin itself	5 years ago
René Cannaò	6c7503f85f	Improve debugging when unable to reach hostgroup ... When we generate an error "Max connect timeout reached while reaching hostgroup" for the client, now the error log is more verbose.	5 years ago
René Cannaò	b8b840fe30	More verbosity when proxysql detects a broken connection ... Added function MySQL_Session::detected_broken_connection() that unifies the way broken connections are logged. It also logs username, and last time used. Added also a new macro proxy_error_inline()	5 years ago
René Cannaò	e14accd78b	Merge pull request #3453 from sysown/v2.2.0-3427 ... Closes #3427: Read/Write Split query rules do not work while using sysbench to evaluate perfromance	5 years ago
Javier Jaramago Fernández	3a394834e1	Added null check for 'stmt_info->first_comment' before accessing it during 'PROCESSING_STMT_EXECUTE' #3427	5 years ago
Javier Jaramago Fernández	adb5ed6b28	"Fixed invalid reads due to memory from 'first_comment' being freed from global 'stmt_info' #3427" ... 'CurrentQuery.QueryParserArgs.first_comment' needs to hold it's own copy of 'first_comment', otherwise, the 'first_comment' from global 'stmt_info' will be freed by 'Query_Info::end' at the end of the life of 'CurrentQuery'.	5 years ago
Javier Jaramago Fernández	9e70e3918b	Reversed adding 'first_comment' to 'compute_hash' #3427 ... Information from 'first_comment' is redundant since the comment itself is already contained in 'query' when reaching 'compute_hash'.	5 years ago
Javier Jaramago Fernández	18de7a0837	Added default initialization for 'Query_Info' fields 'start_time' and 'end_time' #3458	5 years ago
Javier Jaramago Fernández	028623c06c	Added 'first_comment' to 'MySQL_STMT_Global_info' to allow processing it during 'STMT_EXECUTE' #3427	5 years ago
Javier Jaramago Fernández	a5208f62b7	Fixed parameters for 'process_mysql_query' call during 'STMT_EXECUTE' #3427	5 years ago
René Cannaò	d521468cf4	Fix typo in handler_special_queries	5 years ago
René Cannaò	dc10bee4d5	Adding some comments and a quick exit on handler_special_queries for locked_on_hostgroup	5 years ago
Javier Jaramago Fernández	cba171c07d	Introduced delayed parsing failure for SET statements ... All variables that are not known by ProxySQL should fail to be parsed. A best effor should also be done for tracking all the variables present in a 'SET' statement prior to returning the parsing failure.	5 years ago
Javier Jaramago Fernández	f2668c455c	Added new checks in 'handler_special_queries' for 'locked_on_hostgroup' for several simple statements	5 years ago
Javier Jaramago Fernández	3a122aaf3c	Added new case to 'SETTING_GENERIC_VARIABLE' quote surrounding for queries starting with '('	5 years ago
Javier Jaramago Fernández	f403402755	Added call to 'connect_cont' on timed out connections preventing 'fd' leak in connection destruction #3404	5 years ago
René Cannaò	7cc750a111	Merge branch 'v2.1.1' into v2.1.2-cluster	5 years ago
René Cannaò	618a77d550	Merge pull request #3387 from sysown/v2.1.1-833 ... Closes #833: Return ERR when receiving 'LOAD DATA LOCAL INFILE'	5 years ago
Javier Jaramago Fernández	bcb5589506	Fixed typo in comment	5 years ago
Javier Jaramago Fernández	4e58e36860	Closes #833: Return ERR when receiving 'LOAD DATA LOCAL INFILE' to let client know operation is unsupported	5 years ago
René Cannaò	76deab2fad	Add lock on hostgroup for any not parsed variable	5 years ago
René Cannaò	f0e3a87159	Introduce ignore_vars in MySQL_Variables ... This vector lists all the variables that proxysql will parse but ignore	5 years ago
René Cannaò	d53578f269	Merge pull request #3353 from sysown/v2.1.1-deprecate_forward_autocommit ... Deprecate mysql-forward_autocommit #3253	5 years ago
René Cannaò	428f2e7e4f	Merge pull request #3358 from sysown/v2.1.1-3357 ... Closes #3357: Port 'v1.4.14-show-warnings' branch into v2.1.1 and add new mysql-variable to control it	5 years ago
René Cannaò	206698d179	Avoid crash in MySQL_Result_to_MySQL_wire without myds #3363	5 years ago
René Cannaò	ca3499054e	Merge pull request #3352 from sysown/v2.1.1-3350 ... Closes #3350: Memory leak reported by Valgrind in ''MySQL_Protocol::get_binds_from_pkt"	5 years ago
René Cannaò	3266cfc506	Merge pull request #3343 from sysown/v2.1.1-spiffe ... V2.1.1 spiffe	5 years ago
Javier Jaramago Fernández	228fe0640f	Closes #3357: Ported 'v1.4.14-show-warnings' and added new mysql-variable to control it	5 years ago
René Cannaò	a0fb4821cc	Deprecate mysql-forward_autocommit #3253	5 years ago
Javier Jaramago Fernández	60bb5a65ae	Closes #3350: Free memory when allocated for specific 'stmt_execute_metadata_t' bind buffers types	5 years ago
René Cannaò	d258361258	Merge pull request #3348 from sysown/v2.1.1-3339 ... Fixing an inifinite loop in case of multi-statements and closed backend connection	5 years ago
René Cannaò	bd5d882770	Fixing an inifinite loop in case of multi-statements and closed backend connection ... If a backend connection was terminated in the middle of the execution of multiple statements in a multi-statements command, the worker thread was entering an infinite loop. Furthermore, this commit disables query retry in case of multi-statements if the first one completed successfully This fixes #3339 This commit is the port to 2.1 of 90a4922ed8	5 years ago
René Cannaò	7c0bde5f99	Working prototype for SPIFFE	5 years ago
René Cannaò	306fc0e2bb	Merge pull request #3330 from sysown/v2.1.1-3248 ... Closes #3248: Create metric to track number of times multiplexing is disabled due to `mysql-auto_increment_delay_multiplex`	5 years ago
René Cannaò	5455b7d228	Merge pull request #3328 from sysown/v2.1.1-3327 ... Closes #3327: Call 'ProcessQueryAndSetStatusFlags' check even if query failed	5 years ago
Javier Jaramago Fernández	75af796049	Merge remote-tracking branch 'origin/v2.1.1' into v2.1.1-3248	5 years ago
René Cannaò	b233819514	Merge pull request #3309 from sysown/v2.1.1-1574 ... Closes #1574: Packets out of order. expected 1 received 27.	5 years ago
Javier Jaramago Fernández	d507880cbb	Added new metric 'proxysql_myhgm_auto_increment_multiplex_total' tracking the number of times that 'auto_increment_delay_multiplex' is triggered	5 years ago
Javier Jaramago Fernández	c0547d0cec	Closes #3327: Moved call to 'ProcessQueryAndSetStatusFlags' to 'MySQL_Session::RequestEnd'	5 years ago
Javier Jaramago Fernández	7c1c829565	Compressed multiple 'p_update_mysql_error_counter' with ternary operator and replaced zero error codes with ER_PROXYSQL_OFFLINE_SRV	5 years ago
Javier Jaramago Fernández	851339b5f3	Closes #3310: Improve error reporting for 'MySQL_Monitor' and 'MySQL_Session' backend connections via counters	5 years ago
Javier Jaramago Fernández	ac0b018a4d	Update prepared statements metadata during 'PROCESSING_STMT_EXECUTE'	5 years ago
René Cannaò	259d07c9ab	Merge pull request #3295 from sysown/v2.1.0-ps_buffer ... V2.1.0 ps buffer	5 years ago
Javier Jaramago Fernández	8141642bfc	Merge branch 'v2.1.1' into v2.1.1-3280	5 years ago
René Cannaò	fca4055b50	Merge branch 'v2.1.1' into v2.1.0-ps_buffer	5 years ago
René Cannaò	a592402902	Implementation of table stats_proxysql_servers_clients_status and PROXYSQL CLUSTER_NODE_UUID command	5 years ago
René Cannaò	f3dba4dcae	Do ot use charset_name if not available in SQL3_Free_Connections() ... This fix a crashing bug	5 years ago
Javier Jaramago Fernández	1ee832affd	Closes #3280: Add support to control 'CLIENT_DEPRECATE_EOF' in client and backend connections through global variables	5 years ago
René Cannaò	7921e130d2	Third commit to buffer resultsets in Prepared Statements ... * MySQL_ResultSet() stores a pointer to the PS * MySQL_ResultSet::init_with_stmt() doesn't need anymore the pointer to the PS Furthermore, it isn't anymore an "init" but an end (we will rename it) * Added MySQL_ResultSet::add_row(MYSQL_ROWS *rows) for PS only * MySQL_Protocol::generate_pkt_row3() accepts an optional row length. If passed, it will know the length of the row without computing it * MyRS initialized during ASYNC_STMT_EXECUTE_STORE_RESULT_START * Implemented throttling during ASYNC_STMT_EXECUTE_STORE_RESULT_START * MySQL_Connection::process_rows_in_ASYNC_STMT_EXECUTE_STORE_RESULT_CONT() always generates a heartbeat. For now unnecessary, and we will better tune it later * test_ps_async-t.cpp tunes mysql-threshold_resultset_size to trigger buffering More testing is required	5 years ago
Javier Jaramago Fernández	2eb5d507df	Fixed error log and errors reported to clients when several statements fails	5 years ago
Javier Jaramago Fernández	ef53973018	Fixed memory leak due packet not being freed in 'switching_auth' during 'SERVER_HANDSHAKE'	5 years ago
René Cannaò	045bb460b1	Reset client connection when client issues a CHANGE_USER command	5 years ago
René Cannaò	cd11e85e8c	Minor code cleanup	5 years ago
René Cannaò	9225edbddd	Merge branch 'v2.1.0' into v2.1.0-deprecate_eof	5 years ago
Javier Jaramago Fernández	79e3d7a1b7	Added support to convert EOF packets into OK packets for 'Query_Cache' entries	5 years ago
Javier Jaramago Fernández	7150c7d8ed	Added metadata to 'Query_Cache' entries for supporting EOF deprecation	5 years ago
René Cannaò	149530a8b2	Default eof_identifier=false in generate_pkt_OK()	5 years ago
Bibek Shrestha	60f2151fe1	Fix special queries response for CLIENT_DEPRECATE_EOF ... Few special queries are handled separately in ProxySQL 1. select @@version_comment limit 1 2. SHOW WARNINGS 3. SELECT USER() 4. PROXYSQL INTERNAL SESSION 5. SELECT LAST_INSERT_ID() 6. SELECT CONNECTION_ID() 7. C code mysql_set_server_option(mysql, MYSQL_OPTION_MULTI_STATEMENTS_ON) We now remove EOF1 for these and respond with OK packets intead of EOF2	5 years ago
Bibek Shrestha	b16bb275f7	Hardcode false instead of default value	5 years ago
René Cannaò	8fb875aec1	First commit to split handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_QUERY_qpo	5 years ago
René Cannaò	3ab0054af9	Some code cleanup	5 years ago
René Cannaò	cc4d8f232c	Some code cleanup	5 years ago
René Cannaò	001351b880	More changes in get_pkts_from_client()	5 years ago
René Cannaò	da43919b77	Refactoring MySQL_Session::get_pkts_from_client()	5 years ago
René Cannaò	8b5812f769	Removed dead code from MySQL_Session ... * void handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_STMT_PREPARE(PtrSize_t *); * void handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_STMT_EXECUTE(PtrSize_t *);	5 years ago
René Cannaò	f3ff10e989	Splitting MySQL_Session::get_pkts_from_client ... Adding functions: * void handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_STMT_RESET(PtrSize_t&); * void handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_STMT_CLOSE(PtrSize_t&);	5 years ago
René Cannaò	b2e3ae4222	Splitting MySQL_Session::handler() ... To make it easier to read, MySQL_Session::handler() was split into multiple functions	5 years ago
René Cannaò	dd04dc3da4	Do not increment mysql counter error when there is no error	5 years ago
René Cannaò	aaddb4e568	Port of #3001 to 2.1.0 , related to #3000 ... A client connection can use a backend connection with a session variable set by a different client	6 years ago
René Cannaò	fdff65daea	Implementation of max_transaction_idle_time ... Former max_transaction_time is now renamed to max_transaction_idle_time. mysql-max_transaction_idle_time defines the maximum time a transaction can stay idle. mysql-max_transaction_time defines the maximum time of a transaction since its start.	6 years ago
Valentin Rakush	2d4b0a25ca	Fix QPO timeout overflow	6 years ago
René Cannaò	5fd6baba65	Removed commented code	6 years ago
René Cannaò	dd017bbaf5	Fix a bug related to SET autocommit=1 filtered ... If SET autocommit=1 was used to terminate a transaction, proxysql wasn't executing it and the transaction was staying open.	6 years ago
René Cannaò	47d3420662	Change default of exit_after_SetParse ... In handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_QUERY_qpo() Changing the default of exit_after_SetParse from false to true. If a variable isn't parsed or it needs to be forwarded, exit_after_SetParse is set to false	6 years ago
René Cannaò	848ddb2177	Added variable mysql-connect_timeout_client ... This also fix bug #1132	6 years ago
Rene Cannao	41b173a83c	Fixing a lot of compiler warnings	6 years ago
René Cannaò	33d8db02a6	Change the mapping logic for SESSION_TRACK_GTIDS ... Changing the mapping logic in SESSION_TRACK_GTIDS in frontend and backend connections. Up to now, frontend and backend `SESSION_TRACK_GTIDSs match. This is now changed: * backend connections are by default set to `mysql-default_session_track_gtids` * if `mysql-default_session_track_gtids=OFF` (the default) , `session_track_gtids` is not changed on backend * if the client asks for `session_track_gtids=OFF` , proxysql ignores it (it just acknowledge it) * if the client asks for `session_track_gtids=OWN_GTID` , proxysql will apply it * if the client asks for `session_track_gtids=ALL_GTIDS` , proxysql will switch to OWN_GTID and generate a warning * if the backend doesn't support `session_track_gtids` (for example in MySQL 5.5 and MySQL 5.6), proxysql won't apply it. It knows checking server capabilities This commit also deprecates function `MySQL_Session::handler_again___verify_backend__generic_variable()` ProxySQL is now also able to know when proxysql binlog reader is perhaps in use tracking all gtid_port in mysql_servers. This feature in future will be used to deprecate `mysql-default_session_track_gtids`	6 years ago
René Cannaò	6b4d576e6a	Adding some internal comment	6 years ago
René Cannaò	61bca42ef3	Adding charset debugging	6 years ago
René Cannaò	a0fc25fd8a	Change DSS to STATE_MARIADB_GENERIC after async_change_user()	6 years ago
René Cannaò	b9645b39dc	Merge branch 'v2.1.0' into v2.1.0-cherrypicks_2.0.13_2	6 years ago
René Cannaò	5ce13abc36	Merge pull request #2881 from sysown/v2.1.0-2717 ... Refactored MySQL_Connection setter/getter functions functions for 'status_flags' #2717	6 years ago
Javier Jaramago Fernández	e7b69bc269	Added extra info from 'QueryProcessor' to 'internal_session_info'	6 years ago
Javier Jaramago Fernández	4409044398	Added support for annotation 'create_new_connection' that prevents reusing backend connections	6 years ago
Javier Jaramago Fernández	9eda5a6d0a	Removed 'sql_log_bin0' from 'conn.status' because it's a session variable and added 'compression'	6 years ago
René Cannaò	d79ddad00b	Merge pull request #2844 from sysown/v2.1.0-cherrypicks_2.0.13 ... V2.1.0 cherrypicks 2.0.13	6 years ago
René Cannaò	3d74ef4828	Merge pull request #2882 from sysown/v2.1.0-2862 ... Port PR 2829 to 2.1.0 #2862	6 years ago
Javier Jaramago Fernández	d10f519e4a	Refactored 'MySQL_Session' set/get status functions ... - Added extra doc about the 'status_flags' and 'server_status'. - Added 'sql_log_bin0' and 'prepared_statement' to the 'conn.status' from PROXYSQL SESSION INFO.	6 years ago
René Cannaò	00ce76e57e	Add support for SAVEPOINT #948	6 years ago
Javier Jaramago Fernández	8fafa66336	Removed unused variables from 'MySQL_Connection()'	6 years ago
Javier Jaramago Fernández	7b82a3774a	Set 'with_gtid' flag each time a GITD is going to be used	6 years ago
Javier Jaramago Fernández	adaca60c1f	Fixes segfault related to accesses to 'GloMyLogger' and 'GloMTH' when are already deinitialized	6 years ago
René Cannaò	416260ab53	Ignore last semicolon from SET statements #2838	6 years ago
René Cannaò	507f034a23	Merge pull request #2826 from sysown/v2.1.0-from2013-1 ... V2.1.0 from2013 1	6 years ago
Arthur Schreiber	8ed63e8404	Reset data stream status after switching users. ... When a backend connection is reused for a different user, the data stream status is set to `STATE_MARIADB_QUERY`, but was not set back to `STATE_MARIADB_GENERIC` once the user was switched successfully. This caused additional connection setup (like executing `init_connect`) to be skipped on the first query after switching users. If another query using the the same user was executed, this new query would end up performing this additional connection setup. By setting the data stream status back to `STATE_MARIADB_GENERIC`, we can ensure connection setup happens correctly after switching users.	6 years ago
Arthur Schreiber	32d6ba65c0	Actually set `session_track_gtids` on new backends. ... When a new backend connection was selected, the `session_track_gtids` config variable would be marked as set, but was never actually set on the backed connection.	6 years ago
René Cannaò	2bbd84d2c9	Support for SQLite3 plugin ... This commit prepares proxysql for further development related to SQLite3. Specifically, it allows to either use built-in SQLite3 library, or to load it from a plugin.	6 years ago
Valentin Rakush	b0d36acb2f	Session variable group_concat_max_len ... (cherry picked from commit f56a9429fc)	6 years ago
René Cannaò	23db1d7f22	Merge branch 'v2.1.0' into v2.1.0-testQP_stmt	6 years ago
René Cannaò	9acfaa211c	Merge pull request #2723 from sysown/v2.0.11-QP_stmt_2 ... Do not cache routing metadata for COM_STMT_EXECUTE	6 years ago
René Cannaò	9998555eff	Port of v2.0.11-QP_stmt_2 into v2.1.0-QP_stmt_2	6 years ago
René Cannaò	4b2107b7c3	Splitting MySQL_Session::get_pkts_from_client() ... Adding the following methods: * handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_STMT_RESET() * handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_STMT_CLOSE() * handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_STMT_SEND_LONG_DATA()	6 years ago
René Cannaò	c0a3efdd7f	Merge branch 'v2.1.0' into v2.0.11-QP_stmt_2	6 years ago
René Cannaò	4bed506067	Breaking MySQL_Session::handler() in 2 main blocks ... The two main blocks are: * get_pkts_from_client() : handling the main loop around label __get_pkts_from_client * handler() : handling the main loop around label handler_again	6 years ago
René Cannaò	c95ad4bc03	Code cleanup	6 years ago
René Cannaò	1adceeb9d6	Merge branch 'v2.1.0_session_handler_split' into v2.1.0_session_handler_split_2	6 years ago
René Cannaò	0a78949d98	Merge branch 'v2.1.0' into v2.0.11-prometheus	6 years ago
René Cannaò	8d6b48f21d	Adding new method MySQL_Session::handler_again___multiple_statuses() ... First commit to simplify MySQL_Session::handler() It handles the following statuses: * CHANGING_USER_SERVER * CHANGING_AUTOCOMMIT * SETTING_MULTI_STMT * SETTING_SESSION_TRACK_GTIDS * SETTING_SET_NAMES	6 years ago
Valentin Rakush	d0acdcd5c2	Crashing often with strange new error (Error setting MYSQL_OPTION_MULTI_STATEMENTS) ... (cherry picked from commit 4fc76a2590)	6 years ago
René Cannaò	308639d0dc	Renamed session_status NONE to session_status___NONE	6 years ago
René Cannaò	8083561058	Added a comment in MySQL_Session.cpp	6 years ago
val	890ad06868	Merge branch 'v2.0.11-QP_stmt_2' into v2.1.0-testQP_stmt	6 years ago
René Cannaò	543b96facf	Merge pull request #2651 from sysown/v2.0.11-aux ... V2.0.11 aux	6 years ago
Javier Jaramago Fernández	7f8b07a0db	Created new metric counters for registering 'mysql_errors'	6 years ago
René Cannaò	7b021e027a	Do not cache routing metadata for COM_STMT_EXECUTE ... From 1.3.0 till 2.0.x , when COM_STMT_PREPARE is executed and Query Processor is executed, metadata are stored in MySQL_STMT_Global_info(). These metadata include routing information. Is a prepared statement is prepared on a specific hostgroup, it will always be executed on the same hostgroup. This causes negative consequences, like the one reported in issue #2691 . This commit: * remove hostgroup_id from MySQL_STMT_Global_info() and other metadata * Query Processor is called also during COM_STMT_EXECUTE * removes hostgroup from table stats_mysql_prepared_statements_info * Query Processor do not perform any query rewrite ruding COM_STMT_EXECUTE	6 years ago
Javier Jaramago Fernández	a53988cc90	Removed deprecated double counters metric updates in favor of callback approach	6 years ago
René Cannaò	8cc88ce58e	Migration of threads status variables as array	6 years ago
Javier Jaramago Fernández	b6bca5a3ee	Added metrics help and replaced metrics impl with new array based one for 'mysql_threads_handler' module	6 years ago
Javier Jaramago Fernández	c48b109019	Replaced 'hostgroups_manager' prometheus metrics with new array based impl	6 years ago
Javier Jaramago Fernández	c319db2c3d	Added new prometheus metrics mimicking current ones	6 years ago
René Cannaò	a863ec4ece	Merge pull request #2675 from sysown/v2.0.11-var2 ... V2.0.11 var2	6 years ago
René Cannaò	b7834cc3d3	Fix multistatement error with SET NAMES #2655	6 years ago
René Cannaò	c4b1dfb29b	wsrep_sync_wait parsed via parse_variable_number()	6 years ago
René Cannaò	3454c625c2	Adding ability to parse some variables based ontheir attributes ... Expanded mysql_variable_st to include is_number and is_bool	6 years ago
René Cannaò	54ee4e9b69	Simplified the number of session statuses ... * removed 14 statuses * configured the MySQL_Session status to SETTING_VARIABLE for 14 session variables * extended MySQL_Session to introduce a new variable that tracks the session variable to change * MySQL_Threads_Handler::SQL3_Processlist() can handle all variables * removed unnecessary loops * improved performance removing unnecessary function calls	6 years ago
René Cannaò	d83f2974b6	on_connect_to_backend() to accept a MySQL_Connection as argument instead of a MySQL_Session	6 years ago
René Cannaò	f3ba5159d6	Removed reference to "special_handling" variables	6 years ago
val	08c6622eb0	set charset command sets connection character set to empty	6 years ago
val	246a9d828a	use separate function for set names verification	6 years ago
val	66788863b3	set names optimization	6 years ago
val	d0d7018e34	rollback session_track_gtids	6 years ago
val	ade8491f47	Re-evaluate on_connect_to_backend	6 years ago
val	6e75ac7033	do not change mysql_tracked_variables. do not use special_handling as for now	6 years ago
val	abd0555852	remove is_connected_to_backend	6 years ago
val	b0ca1a030f	make MySQL_Variables a global variable	6 years ago
val	3e790c9083	Polishing and cleanup ... - cleanup code - performance optimization - use default value for connection	6 years ago
Valentin Rakush	61c1913334	Character set handling implementation	6 years ago
René Cannaò	c28deb7c7d	Generalize the use of session variables ... Added new array mysql_tracked_variables[] that defines the tracked variables. Ideally, tracking a new session variable will requires adding only a couple of lines of code. Removed session variables from mysql_thread_variables_names: - now both MySQL_Threads_Handler::get_variables_list() and MySQL_Threads_Handler::has_variable() rely on mysql_tracked_variables[] Simplified MySQL_Variables, as it now also uses mysql_tracked_variables[] . Simplify parser in MySQL_Session Generalized code to handle two variables together: - sql_auto_is_null - sql_safe_updates Migrating more session variables to new algorithm - collation_connection - net_write_timeout - max_join_size Migrating more session variables to new algorithm - collation_connection - net_write_timeout - max_join_size	6 years ago
Valentin Rakush	0e79eb39f7	Implementation of the session variables array ... - SQL_SAFE_UPDATES - SQL_SELECT_LIMIT - SQL_SQL_MODE - SQL_TIME_ZONE - CHARACTER_SET_RESULTS - SQL_TRANSACTION_ISOLATION - SQL_TRANSACTION_READ - SQL_SESSION_TRACK_GTIDS - SQL_SQL_AUTO_IS_NULL	6 years ago
René Cannaò	75606bb94d	Simplifying MySQL_Thread::run() phase 1	6 years ago
val	07990f8a57	Proper error reporting	6 years ago
val	5d6debcb65	fix multi statement	6 years ago
val	cdbf70817a	Revert "Implementation of the session variables array" ... This reverts commit 1fb5c9cf06.	6 years ago
val	b1339faefd	Revert "Generalize the use of session variables" ... This reverts commit d242771a25.	6 years ago
val	eb08620181	Revert "Character set handling implementation" ... This reverts commit 796ea5b215.	6 years ago
val	8696ece34b	Revert "Polishing and cleanup" ... This reverts commit dbafde2ff4.	6 years ago
val	dbafde2ff4	Polishing and cleanup ... - cleanup code - performance optimization - use default value for connection	6 years ago
Valentin Rakush	796ea5b215	Character set handling implementation	6 years ago
René Cannaò	d242771a25	Generalize the use of session variables ... Added new array mysql_tracked_variables[] that defines the tracked variables. Ideally, tracking a new session variable will requires adding only a couple of lines of code. Removed session variables from mysql_thread_variables_names: - now both MySQL_Threads_Handler::get_variables_list() and MySQL_Threads_Handler::has_variable() rely on mysql_tracked_variables[] Simplified MySQL_Variables, as it now also uses mysql_tracked_variables[] . Simplify parser in MySQL_Session Generalized code to handle two variables together: - sql_auto_is_null - sql_safe_updates Migrating more session variables to new algorithm - collation_connection - net_write_timeout - max_join_size Migrating more session variables to new algorithm - collation_connection - net_write_timeout - max_join_size	6 years ago
Valentin Rakush	1fb5c9cf06	Implementation of the session variables array ... - SQL_SAFE_UPDATES - SQL_SELECT_LIMIT - SQL_SQL_MODE - SQL_TIME_ZONE - CHARACTER_SET_RESULTS - SQL_TRANSACTION_ISOLATION - SQL_TRANSACTION_READ - SQL_SESSION_TRACK_GTIDS - SQL_SQL_AUTO_IS_NULL	6 years ago
val	70b9f25937	edge case : offset==0 and limit==0	6 years ago
René Cannaò	6dc9606ac4	Update heartbeat during connections ... This reduced the probability of missed heartbeats	6 years ago
val	a78dbfb6b3	report mysql thread_id in case of error during query	6 years ago
René Cannaò	5a842772c4	Better handling of transactions in SQLite3	6 years ago
René Cannaò	b0af4d272d	Fix 2 bugs related to firewall ... * Query_Processor::find_firewall_whitelist_rule() wasn't correctly finding rules * SQL injection algorithm should only be triggered if the query isn't blocked already	6 years ago
Valentin Rakush	7b7b94a20f	More verbose output for failed SET statements	6 years ago
René Cannaò	3d2fd599db	Merge pull request #2469 from kirs/min-gtid ... Support min_gtid annotation	6 years ago
Kir Shatrov	3b031f3518	Prevent crash on index() returning NULL ... in handler___client_DSS_QUERY_SENT___server_DSS_NOT_INITIALIZED__get_connection	6 years ago
Kir Shatrov	0922949b8c	Support min_gtid comment	6 years ago
René Cannaò	5a346864de	Merge pull request #2449 from val214/v2.0.9-set-option ... MYSQL_SET_OPTION multiplexing [FR]	6 years ago
Valentin Rakush	a9b0e6648e	Return error 1290	6 years ago
Valentin Rakush	b93b5f50bf	MYSQL_SET_OPTION multiplexing	6 years ago
René Cannaò	b8ecdaa708	Removing some comments	6 years ago
René Cannaò	e9dc7a9b60	Implementation of SQLI fingerprints whitelist ... libsqlinjection generates a lot of false positives. This commit introduces a new table: mysql_firewall_whitelist_sqli_fingerprints This table can list fingerprints generated by libsqlinjection: if the fingerprint is listed in this table, proxysql will consider it as a false positive. This commit also enables SQLi algorithm only if the query is not already explicitly whitelisted.	6 years ago
Valentin Rakush	49181ac1bb	Add host:port to unknown charset log messages	6 years ago
Valentin Rakush	cfdbedeb54	unsigned int charset: add collation name in a log message	6 years ago
René Cannaò	b9d155b4a5	Set variables before setting lock_hostgroup ... This commit fix the following bug: If some session variables were set by the client before proxysql turned on lock_hostgroup, these variables were not set. This commit also makes proxysql aware that this query causes lock_hostgroup: `SET SESSION information_schema_stats_expiry=0`	6 years ago
René Cannaò	8954b46a02	Error log now lists the SQL injection query ... Also added status variable automatic_detected_sql_injection to count detected SQL injection	6 years ago
René Cannaò	e12a3b2792	Support for automatic SQL injection detection ... Library libjection is being used. New variable mysql-automatic_detect_sqli defines if the feature is enabled or not. If an SQL injection is detected: - the client connection is immediately terminated - an entry in the error log is reported	6 years ago
René Cannaò	9afe6824ff	Merge pull request #2407 from sysown/v2.0.9-libmicrohttpd-0.9.68 ... V2.0.9 libmicrohttpd 0.9.68	6 years ago
René Cannaò	57e0b2eb2f	Merge pull request #2403 from sysown/v2.0.9-whitelist ... V2.0.9 whitelist	6 years ago
René Cannaò	c967bc179b	Several improvements to SQLite3 Server module: ... - ability to handle transactions - in OK packets and resultsets, SERVER_STATUS_IN_TRANS flag is set if a transaction is running - a persistent database file in datadir is used instead of in-memory database - database file uses WAL (Write-Ahead Logging) - WAL journal size is set to 64MB - monitor user can always login to SQLite3 Server - in case of database lock within a transaction, an error is immediately returned to client	6 years ago
René Cannaò	ce4a4a2464	Code cleanup and speeding compile time	6 years ago
René Cannaò	45e701b54d	Code cleanup and speeding compile time	6 years ago
René Cannaò	80e92b144d	[WIP] Second commit for mysql firewall whitelist ... Improved also compiling time	6 years ago