proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	ade0130e67	discoveryagent: update Claude Code headless flow for target_id-scoped MCP tools Enhance the existing Claude Code custom-prompt discovery examples to match the new MCP contract introduced by multi-target routing and target-scoped catalog semantics. Changes included: - static_harvest.sh - added required --target-id argument (with MCP_TARGET_ID env fallback) - always sends target_id in discovery.run_static arguments - updated usage/help/examples to include target_id - two_phase_discovery.py - added required --target-id argument - static-harvest bootstrap call now passes target_id - improved run_id error guidance with target_id-aware commands - injects <TARGET_ID> placeholder into user prompt template - improved runtime logging to display target_id - Prompt templates - two_phase_discovery_prompt.md: - catalog/agent/llm tool signatures updated to include target_id - Stage 0 and workflow text updated to use provided target_id + run_id - removed contradictory instruction that asked to call discovery.run_static in Phase 2 - two_phase_user_prompt.md: - added target_id input section - all example calls updated to pass target_id - start instructions now require target_id + run_id - README and utility example - README quick-start curl and script examples now include target_id - test_catalog.sh now accepts/prints target_id and passes it to catalog/llm calls Validation: - bash -n passed for updated shell scripts - python3 -m py_compile passed for two_phase_discovery.py	2 months ago
Rene Cannao	2538e303cf	tap ai: add dual-backend static-harvest fixtures and target_id coverage test Implement phase-A (static harvesting) TAP coverage for MCP multi-target discovery by seeding deterministic schemas on both MySQL and PostgreSQL and validating discovery/catalog behavior per target_id. What this commit adds: - AI group deterministic seed datasets - Added test/tap/groups/ai/mysql-seed.sql with: - tap_mysql_static_customers - tap_mysql_static_orders (FK to customers) - Added test/tap/groups/ai/pgsql-seed.sql with: - tap_pgsql_static_accounts - tap_pgsql_static_events (FK to accounts) - pre-proxysql hook integration - Updated test/tap/groups/ai/pre-proxysql.bash to seed both backends after container startup: - seed_mysql_test_data() executes mysql-seed.sql via mysql CLI - seed_pgsql_test_data() executes pgsql-seed.sql via psql (or docker compose exec fallback) - Existing monitor-user/profile setup is preserved - New TAP test: test/tap/tests/test_mcp_static_harvest-t.sh - Validates MCP/ProxySQL reachability - Validates list_targets exposes both mysql and pgsql target_id entries - Runs discovery.run_static for MySQL target_id and validates run_id + protocol=mysql - Validates catalog.list_objects returns seeded MySQL table for that run - Runs discovery.run_static for PostgreSQL target_id and validates run_id + protocol=pgsql - Validates catalog.list_objects returns seeded PostgreSQL table for that run - Validates run isolation across targets (cross-target run_id lookup fails as expected) - Documentation update - Updated test/tap/groups/ai/README.md with seeded-table details and manual run instructions for the new static-harvest test Notes: - This commit focuses strictly on phase-A static harvesting, as requested. - Phase-B (LLM-driven discovery) tests are intentionally not included here.	2 months ago
Rene Cannao	9685cdaa4b	mcp discovery: enforce target-scoped run model and add protocol-aware static harvesting (mysql+pgsql) Refactor the MCP query/discovery stack to remove prototype-era MySQL-only assumptions and make discovery/catalog semantics explicitly target-scoped. This commit is intentionally not backward compatible with legacy single-target catalog metadata. Key implementation details: - Discovery_Schema: - runs table now stores target_id, protocol, and server_version - resolve_run_id() now requires target_id and resolves schemas within target scope - create_run() now records target/protocol/server version - added legacy schema detection + destructive catalog table rebuild when old runs layout is found - fixed resultset lifetime/escaping issues in target-aware run resolution - New PostgreSQL static harvester: - added PgSQL_Static_Harvester class and build wiring - harvests schemas/objects/columns/indexes/fks/view definitions into Discovery_Schema - maps pg metadata to object_id-based insert APIs used by Discovery_Schema - Query_Tool_Handler: - constructor simplified to catalog_path only (no mcp-mysql_* runtime ctor deps) - discovery.run_static now requires target_id and dispatches protocol-aware harvester at runtime - catalog., agent.run_start, and llm. tool contracts now require target_id when resolving run_id - all run_id resolution call sites switched to resolve_run_id(target_id, ...) - list_schemas catalog query now scoped by target_id via runs join - digest logging path now resolves run_id in target context - ProxySQL_MCP_Server: - updated Query_Tool_Handler construction to new signature - Docs updated: - added explicit target_id scoping guidance for discovery/catalog/agent/llm workflows - clarified protocol-aware routing and noted legacy examples still present in large script docs Build validation: - Recompiled changed objects with PROXYSQLGENAI=1: - Query_Tool_Handler.oo - Discovery_Schema.oo - PgSQL_Static_Harvester.oo - ProxySQL_MCP_Server.oo	2 months ago
Rene Cannao	7e54883ba5	mcp query debugging: surface rule-id context for blocks and add backend failure SQL details Observed confusion: - MCP failures like 'Error 100' / 'Error 101' were visible at endpoint level but gave no direct clue whether they came from query-rule blocks or backend execution failures. - Connection/firewall-style failures also lacked enough target/query context in lower-level logs. Changes in this commit: 1) Log MCP query-rule block/OK matches with rule id and context - In Discovery_Schema::evaluate_mcp_query_rules(): - when error_msg rule action is applied, log: rule_id, tool, target_id, schema, error_msg, query preview. - when OK_msg rule action is applied, log: rule_id, tool, target_id, schema, ok_msg. - This makes it explicit which runtime_mcp_query_rules row produced the returned error. 2) Add detailed backend execution error logs in Query_Tool_Handler - For MySQL and PostgreSQL execution paths (with and without schema switching), failures now log: - target_id - schema (when applicable) - backend error text - SQL query text - Added context for PG search_path failures too. - This disambiguates rule-block errors from actual backend connectivity/authorization/firewall failures. Behavioral notes: - API responses are unchanged (to avoid breaking tests expecting exact messages). - Logging is now sufficiently descriptive to trace each failure to either: - a specific MCP rule id/action, or - a concrete backend execution error. Validation: - Recompiled successfully: - lib/obj/Discovery_Schema.oo - lib/obj/Query_Tool_Handler.oo	2 months ago
Rene Cannao	8fbd570c79	mcp variables: stop writing runtime_global_variables during LOAD MCP VARIABLES TO RUNTIME Issue: - MCP variable load path was writing rows into runtime_global_variables. - For MCP this is incorrect and misleading; runtime_global_variables should not be used as a write target in this flow. - Logs showed explicit INSERT statements into runtime_global_variables for mcp-* entries. Fix implemented: 1) Removed runtime_global_variables population from MCP database->runtime flow - In flush_mcp_variables___database_to_runtime(), removed the block that called: flush_mcp_variables___runtime_to_database(..., runtime=true, ...) - LOAD MCP VARIABLES TO RUNTIME now applies mcp-* variables to GloMCPH and reloads MCP server state, without runtime_global_variables writes. 2) Removed runtime_global_variables writes from MCP runtime->database helper - In flush_mcp_variables___runtime_to_database(): - removed DELETE FROM runtime_global_variables WHERE variable_name LIKE 'mcp-%' - removed INSERT INTO runtime_global_variables(...) per variable - Function now persists MCP variables only to global_variables (main/disk paths), which is the intended save behavior. 3) Removed temporary MCP info-level debug noise related to runtime_global_variables inserts - Deleted MCP info logs that printed per-variable INSERT SQL into runtime_global_variables. Build validation: - Recompiled successfully: - lib/obj/Admin_FlushVariables.oo Expected result after this commit: - Executing LOAD MCP VARIABLES TO RUNTIME should no longer emit any INSERT/DELETE against runtime_global_variables for mcp-* variables. - MCP runtime behavior remains: variables are applied in-memory and MCP server reload logic is triggered via load_mcp_server().	2 months ago
Rene Cannao	f15460348c	mcp query diagnostics: include runtime hostgroup status breakdown when target lacks ONLINE backend Adds targeted debug context for non-executable MCP targets. When Query_Tool_Handler reports that a target has no ONLINE backend, it now appends a status summary read from the corresponding runtime server table for that hostgroup: - MySQL: runtime_mysql_servers - PostgreSQL: runtime_pgsql_servers Example diagnostics now include status aggregates such as: - ONLINE=0, SHUNNED=1 - OFFLINE_SOFT=1 - no rows in runtime_*_servers for hostgroup X This closes the observability gap where users saw 'target non-executable' but could not immediately tell why the hostgroup failed ONLINE eligibility. Validation: - Recompiled lib/obj/Query_Tool_Handler.oo successfully.	2 months ago
Rene Cannao	f4bc1943fb	mcp query diagnostics: restore strict ONLINE requirement and explain target non-executable failures This change does two things: 1) Reverts executable-target policy to strict ONLINE backend status - Query target resolution in Query_Tool_Handler is restored to require UPPER(status)='ONLINE' in runtime_mysql_servers/runtime_pgsql_servers. - This matches expected semantics: non-ONLINE backends should not be considered executable MCP targets. 2) Replaces generic non-executable errors with actionable diagnostics - Added Query_Tool_Handler::format_target_unavailable_error(target_id). - All query-tool paths that previously returned the generic: 'Target is not executable by this handler' now return a reasoned error with context, including: - target_id - protocol - hostgroup_id - auth_profile_id - concrete reason (for example: empty db_username in auth profile, or no ONLINE backend in runtime_*_servers) - Internal logs in get_connection()/get_pgsql_connection() now emit the same detailed reason. 3) Improves MCP endpoint failure logging with SQL/target context - In MCP_JSONRPC_Resource::handle_tools_call(), failed tool calls now log: - endpoint/tool/error - full arguments payload (existing) - additional parsed details when present: target_id, schema, sql (trimmed for safety) - This makes it explicit what SQL was requested when a tool call fails before execution. 4) Protocol normalization retained for robustness - MCP_Threads_Handler::load_target_auth_map() lowercases protocol values when loading runtime profile joins. - This avoids protocol-casing drift causing inconsistent routing behavior. Build validation: - Successfully recompiled modified objects: - lib/obj/Query_Tool_Handler.oo - lib/obj/MCP_Endpoint.oo - lib/obj/MCP_Thread.oo Resulting behavior expected on next test run: - If a target is non-executable, the response and logs will state exactly why (ONLINE/backend/auth reason), instead of a generic error. - Failure logs will also include the attempted SQL text (for tool calls that carry sql arguments), clarifying whether a backend query was actually executed or blocked before execution.	2 months ago
Rene Cannao	49f811a638	mcp query: stop misclassifying reachable targets as non-executable Observed failure: - MCP tools received valid target_id values, but /mcp/query returned 'Target is not executable by this handler'. - This prevented rule evaluation, digest accounting, and hit counters from advancing, causing multiple TAP phases to fail. Root cause addressed in this commit: - Target endpoint resolution required runtime server status to be exactly ONLINE. - In practice, reachable backends can temporarily appear in other statuses (for example monitor-related transitions), while MCP direct connections with profile credentials are still valid. - Protocol casing inconsistencies could also lead to fragile routing behavior when profile data is consumed. Changes: 1) Relax backend eligibility during endpoint resolution - In Query_Tool_Handler::refresh_target_registry(), endpoint discovery now accepts any server status except OFFLINE_HARD. - ONLINE is still preferred deterministically via ORDER BY, but non-ONLINE candidates remain eligible for MCP execution. 2) Normalize protocol values to lowercase - In MCP_Threads_Handler::load_target_auth_map(), target protocol is normalized to lowercase when loaded from runtime profiles. - In Query_Tool_Handler::refresh_target_registry(), protocol is normalized again defensively before routing decisions. 3) Improve diagnostics for target executability - Added explicit warnings when: - a target resolves to a backend but has empty db_username, - a target has no eligible backend for its hostgroup/protocol. - These logs make it clear why a target is being marked non-executable. Expected behavioral impact: - MCP query tools should execute for valid target_id entries even when monitor status is not strictly ONLINE. - Query-rules blocking/rewriting/OK actions should be exercised again. - stats_mcp_query_rules hits and stats_mcp_query_digest counters should resume incrementing once queries run. Validation performed: - Recompiled modified objects successfully: - lib/obj/Query_Tool_Handler.oo - lib/obj/MCP_Thread.oo	2 months ago
Rene Cannao	6a788e48c4	mcp: make /mcp/query self-healing when targets/backends appear after startup Problem addressed: - MCP query endpoint could stay unusable with 'Tool Handler not initialized' after restart/reload flows. - This was triggered when Query_Tool_Handler could not build an executable pool at init time (for example profiles loaded before ONLINE servers), leaving runtime commands like 'LOAD MCP QUERY RULES FROM MEMORY' blocked behind a NULL query tool handler. - Users had to manually toggle MCP enablement to recover, which is the opposite of expected self-healing behavior. What this commit changes: 1) Query_Tool_Handler pool init is now resilient and idempotent - init_connection_pool() now starts with close() so reinitialization fully resets stale mysql/pgsql pool state before rebuilding from runtime profile + server tables. - If no executable targets are available, init_connection_pool() now returns success with a warning instead of hard failure. This allows the query tool handler (and /mcp/query endpoint) to stay initialized even before backends are ready. 2) Lazy auto-rebuild on first query usage - get_connection() and get_pgsql_connection() now: - refresh target registry before resolution, - attempt to use an existing pooled connection, - if unavailable, trigger a full pool rebuild (init_connection_pool()) and retry once. - This provides automatic recovery when hostgroups/servers/profiles are loaded or changed after MCP startup, without requiring manual MCP disable/enable. 3) Admin runtime rule load path attempts MCP recovery - load_mcp_query_rules_to_runtime() now detects NULL query tool handler and calls load_mcp_server() once before failing. - This turns a hard, immediate admin error into a self-recovery attempt consistent with MCP runtime semantics. Behavioral impact: - /mcp/query endpoint remains online even when there are temporarily zero executable targets. - As soon as compatible runtime targets/backends exist, run_sql_readonly/explain_sql can recover automatically on demand. - LOAD MCP QUERY RULES TO/FROM RUNTIME no longer fails immediately on first NULL handler condition; it retries after MCP server recovery. Validation performed: - Recompiled modified objects successfully: - lib/obj/Query_Tool_Handler.oo - lib/obj/ProxySQL_Admin.oo - Full TAP runtime test execution is not possible in this sandbox due blocked local TCP socket creation; validation should be run in the normal test environment where ProxySQL/MySQL/PGSQL are reachable.	2 months ago
Rene Cannao	998bd82387	MCP TAP startup: fix tool-handler initialization order, improve MCP PROFILES observability, and seed monitor users This change fixes recurring MCP TAP failures where `/mcp/query` returned: Tool Handler not initialized for endpoint: query and where backend monitor auth failures flooded logs. Problem summary - MCP server startup can occur before runtime target/auth profiles and backend server mappings are loaded. - If that happens, Query_Tool_Handler initialization sees no executable targets and remains NULL. - MCP endpoint resources bind the handler pointer at creation time, so a NULL query handler at startup breaks `/mcp/query` until server restart. Code changes 1) Add explicit admin command logging for MCP PROFILES commands - Added `Received <command>` logging in the MCP PROFILES command block, matching behavior of other admin command handlers. - File: `lib/Admin_Handler.cpp` 2) Trigger MCP server refresh after `LOAD MCP PROFILES TO RUNTIME` - After copying profiles into runtime and rebuilding target/auth map, call `ProxySQL_Admin::load_mcp_server()`. - This allows MCP to self-heal when profiles become available after initial startup. - File: `lib/Admin_Handler.cpp` 3) Restart MCP server when query handler is missing - Extended `ProxySQL_Admin::load_mcp_server()` restart checks to include: - running server + `query_tool_handler == NULL` - Restart reason now includes tool handler initialization mismatch. - File: `lib/ProxySQL_Admin.cpp` 4) Fix TAP configurator load order to avoid early MCP startup - Reordered `test/tap/tests/mcp_rules_testing/configure_mcp.sh` runtime sequence: - `LOAD MYSQL SERVERS TO RUNTIME` - `LOAD PGSQL SERVERS TO RUNTIME` (best effort) - `LOAD MCP PROFILES TO RUNTIME` - `LOAD MCP VARIABLES TO RUNTIME` (last) - This ensures MCP starts only after routing/auth context is present. 5) Seed monitor credentials in AI local infra pre-hook - Added backend user/role creation for default monitor credentials `monitor/monitor`: - MySQL: create user + monitor-relevant grants - PostgreSQL: create role + `pg_monitor` + DB connect grants - Reduces monitor auth noise in local AI TAP dockerized setup. - File: `test/tap/groups/ai/pre-proxysql.bash` 6) Mark new TAP phase scripts executable - `test_phase10_eval_explain.sh` - `test_phase11_pgsql_target.sh` Expected outcome - MCP query endpoint no longer stays stuck with an uninitialized tool handler after TAP configuration. - MCP query-rules admin commands stop failing due to missing Query_Tool_Handler. - MCP profile command flow is visible in logs for easier debugging. - Local AI TAP infra no longer emits continuous monitor authentication failures for default monitor credentials.	2 months ago
Rene Cannao	af0411bd46	MCP: add target-aware rules/stats tests, explain_sql rule coverage, and AI local docker TAP infra This commit completes end-to-end MCP query-rules validation for multi-target routing and introduces a self-contained TAP infra for the `ai` group that can run both in Jenkins and manually. Main MCP/runtime changes: - Extended MCP query-rule matching context to include both `target_id` and resolved backend `username`. - Added `target_id` column to `mcp_query_rules` and `runtime_mcp_query_rules` table definitions. - Extended `stats_mcp_query_rules` to include `username` and `target_id` alongside `rule_id` and `hits`. - Updated load/save/runtime refresh paths to persist and rehydrate the expanded MCP rule schema. - Wired the rule engine into `explain_sql` so MCP rules apply consistently across `run_sql_readonly` and `explain_sql`. - Included startup-order fix in `src/main.cpp` to initialize MCP/GenAI thread handlers early, preventing startup crashes in PROXYSQLGENAI builds. Test coverage changes: - Updated existing MCP TAP phases to assert target-aware and username-aware behavior: - `test_phase4_stats.sh` - `test_phase6_eval_block.sh` - Added new MCP TAP phases: - `test_phase10_eval_explain.sh` (rule engine coverage for `explain_sql`) - `test_phase11_pgsql_target.sh` (pgsql target routing/rule/stats coverage; graceful skip if no pgsql target is configured) - Updated `test_mcp_query_rules-t.sh` runner to execute new phases. AI group isolated infra (manual + CI compatible): - Added `test/tap/groups/ai/docker-compose.yml` with MySQL 9.0 and PostgreSQL 16 backends. - Added lifecycle scripts: - `docker-compose-init.bash` - `docker-compose-destroy.bash` - `pre-proxysql.bash` - `post-proxysql.bash` - Extended `test/tap/groups/ai/env.sh` with local default ports/credentials/target IDs used by MCP TAP tests. - Added `test/tap/groups/ai/README.md` documenting manual execution flow outside Jenkins. Outcome: - MCP tests now validate routing-aware rule enforcement and stats attribution for both MySQL and PostgreSQL targets. - The `ai` TAP group can be run with an isolated local backend stack without relying on external Jenkins infra repositories.	2 months ago
Rene Cannao	b46fb575ea	TAP MCP client: port PR5372 coverage to MCP profiles/target_id routing model This commit ports the TAP MCP client test coverage from PR #5372 to the new MCP profiles architecture, replacing legacy direct backend variable assumptions with target/profile-based routing. What was updated: - Reworked test setup to use `mcp_target_profiles` + `mcp_auth_profiles` rather than legacy `mcp-mysql_*` config variables. - Updated MCP request payloads and helper flows to route via `target_id`. - Aligned assertions with profile-backed runtime behavior and removed obsolete expectations tied to static mysql host/user/password globals. Why this was needed: - The previous tests were written before MCP target/profile routing existed. - Without this update, TAP coverage would exercise deprecated paths and miss regressions in the current MCP execution model. Result: - Test suite now validates the same functional intent as PR #5372 but against the current profile-driven MCP routing implementation.	2 months ago
Rene Cannao	67cb1b72b5	MCP TAP: pass target_id explicitly in query-rules test payloads This commit updates MCP TAP query-rules tests to always include `target_id` in tool call payloads where query execution is expected. Details: - Added explicit `target_id` arguments to MCP `/mcp/query` tool invocations in rule evaluation tests. - Removed implicit dependence on server-selected defaults during test execution. Why this change is important: - Query-rules behavior is now route-aware and can depend on logical target selection. - Explicit routing in tests prevents non-determinism and ensures assertions are tied to the intended backend target. Result: - More deterministic TAP behavior and clearer validation of rule evaluation under target-based routing.	2 months ago
Rene Cannao	4a8b224038	MCP TAP/docs: migrate tests and documentation from legacy MCP mysql vars to profile-based routing This commit migrates MCP TAP assets and related docs away from deprecated `mcp-mysql_*` style configuration toward the profile-based model centered on auth profiles, target profiles, and `target_id` routing. Changes included: - Updated TAP configuration helpers and test inputs to build and load MCP auth/target profiles. - Replaced legacy variable-driven setup assumptions with runtime profile loading (`LOAD MCP PROFILES ...`). - Refreshed documentation snippets and examples to describe the profile-based configuration flow. Motivation: - Keep test and documentation surfaces aligned with the current MCP architecture. - Eliminate ambiguity between old POC paths and supported profile-driven routing. Outcome: - TAP and docs now consistently describe and exercise MCP routing through profile tables and `target_id` selection.	2 months ago
Rene Cannao	013864b36f	MCP: introduce profile-based target/auth routing and unified LOAD/SAVE MCP PROFILES commands This commit introduces the core MCP routing architecture that decouples client-facing target selection from backend connection details. Architecture introduced: - New MCP auth profile table to store backend credentials/policy (`mcp_auth_profiles`). - New MCP target profile table to map opaque `target_id` -> protocol/hostgroup/auth profile (`mcp_target_profiles`). - Runtime mirrors for both profile tables. Behavioral changes: - MCP query tools resolve execution context by `target_id` and route internally by protocol + hostgroup. - Client no longer needs backend-specific connection details; only logical target identifiers. - Unified admin commands for profile lifecycle management: - `LOAD MCP PROFILES TO/FROM MEMORY/RUNTIME/DISK` - `SAVE MCP PROFILES TO/FROM MEMORY/RUNTIME/DISK` Design goals: - Support multi-backend MCP execution (MySQL + PostgreSQL) behind one endpoint. - Provide server-side credential management and cleaner operational model. - Replace legacy one-backend POC configuration with scalable target/auth abstractions. Result: - MCP routing is now dynamic, protocol-agnostic at the client layer, and fully managed through profile tables and unified load/save commands.	2 months ago
René Cannaò	5de836a4c1	Merge pull request #5373 from sysown/v3.0_improve_mysql_monitoring_5256 Improve MySQL Monitor connection management	2 months ago
René Cannaò	3b578db4bf	Merge pull request #5374 from sysown/v3.0-test0213 Fix Valgrind-reported uninitialized memory issues	2 months ago
René Cannaò	83209da487	Merge pull request #5356 from sysown/v3.0-5355 Fix #5355: Add null pointer check in RequestEnd() to prevent use-after-free crash	2 months ago
Rene Cannao	37e72ea3f9	Fix PROXY protocol detection in MySQL_Data_Stream::read_from_net When pkts_recv==0, the code reads 4 bytes expecting a MySQL packet header, but PROXY protocol starts with 'PROXY ' which gets misinterpreted as a MySQL header with a huge packet length (0x504f5250 = ~1.3GB). Add check for 'PROX' prefix before parsing as MySQL header. This prevents passing an incorrect length parameter to recv() that exceeds the buffer size. Fixes #5376	2 months ago
Rene Cannao	11a43bf768	Fix uninitialized max_allowed_pkt in MySQL_Connection constructor Initialize options.max_allowed_pkt to 0 to prevent Valgrind errors when logging handshake debug information.	2 months ago
Rene Cannao	ca4f858b29	Fix uninitialized memory read in pgsql tokenizer Change malloc() to calloc() in get_result_buffer() to zero-initialize the query digest buffer before use. This prevents stage_2_parsing() from reading uninitialized memory when processing query digests. Fixes #5375	2 months ago
Rene Cannao	85952373d9	Fix uninitialized mondb pointer in MySQL_Monitor_State_Data constructor Add mondb = NULL initialization to prevent Valgrind errors when monitor threads access the pointer before it's properly set.	2 months ago
Rene Cannao	200fdecb8d	Apply AI agent review fixes to PR #5374 Critical Fixes: - Fix NULL pointer dereferences in MySQL_Logger.cpp: * Add null checks for myds->myconn->parent in log_audit_entry() * Fix cleanup code in log_request() and log_audit_entry() * Change sprintf to snprintf for buffer safety - Remove redundant pthread_rwlock_init in debug.cpp: * filters_rwlock already initialized with PTHREAD_RWLOCK_INITIALIZER * Re-initialization caused undefined behavior per POSIX Major Improvements: - Add bounded wait helper wait_for_glo_mth() in proxysql_utils.h: * Replaces indefinite while loops with 10s timeout * Applied to 26 locations across 4 files Build System: - Require C++17 in Makefile (remove C++11 fallback): * Code uses C++17 structured bindings extensively * Cleanest solution vs adding fallback guards to 27+ locations Compilation fixes: - Add unistd.h include for usleep - Remove conflicting GloMyMon extern declaration Files changed: - Makefile - include/proxysql_utils.h - lib/MySQL_Logger.cpp - lib/debug.cpp - lib/MySQL_Monitor.cpp - lib/ProxySQL_Admin.cpp - lib/ClickHouse_Server.cpp - src/SQLite3_Server.cpp	2 months ago
Rahim Kanji	1cccfb3220	Fix connection cleanup in failure paths	2 months ago
Rene Cannao	941e6b7320	Fix filters_rwlock initialization race condition Add static initialization PTHREAD_RWLOCK_INITIALIZER to filters_rwlock in debug.cpp to prevent race condition where proxy_debug() is called before init_debug_struct() initializes the rwlock. This fixes Valgrind errors in filter_debug_entry() where threads were accessing an uninitialized rwlock.	2 months ago
Rene Cannao	3c85c593cf	Add GloMTH initialization wait to all monitor and server threads Fix race condition where threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int() and related functions. Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to ensure GloMTH is fully initialized before use: In lib/MySQL_Monitor.cpp: - monitor_connect(), monitor_ping(), monitor_read_only() - monitor_group_replication(), monitor_galera(), monitor_replication_lag() - monitor_AWS_Aurora_thread_HG(), monitor_aws_aurora() - init_mysql_thread_struct() In src/SQLite3_Server.cpp: - SQLite3_Server_session_handler In lib/ProxySQL_Admin.cpp: - admin_session_handler In lib/ClickHouse_Server.cpp: - ClickHouse_Server_session_handler The pattern ensures threads wait for GloMTH initialization during startup, then check for NULL during shutdown to exit cleanly.	2 months ago
Rene Cannao	aa53d990ed	Add GloMTH initialization wait to all monitor threads Fix race condition where monitor threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int(). Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to: - monitor_ping_thread - monitor_read_only_thread - monitor_replication_lag_thread - monitor_group_replication_thread (also moved check before MySQL_Thread creation) - monitor_galera_thread (also moved check before MySQL_Thread creation) This matches the existing pattern in monitor_connect_thread.	2 months ago
Rene Cannao	f4cd34be5c	Fix race condition in monitor_connect_thread Add wait loop for GloMTH initialization before accessing variables. Other monitor threads (MonitorPing, MonitorReadOnly, etc.) already had this pattern, but monitor_connect_thread was missing it. This fixes Valgrind errors about uninitialized values in get_variable_uint16() when strcasecmp reads from memory that hasn't been fully initialized yet.	2 months ago
Rahim Kanji	33ce4217f0	Merge remote-tracking branch 'v3.0' into v3.0_improve_mysql_monitoring_5256	2 months ago
Rahim Kanji	9eac5f6420	Improve async ping mmsd ownership tracking and pool validation	2 months ago
Rene Cannao	09d0dcb808	Fix uninitialized tmp_charset in Data_Stream constructors Initialize tmp_charset=0 in MySQL_Data_Stream and PgSQL_Data_Stream constructors. This field was used uninitialized in process_pkt_handshake_response() when calling proxy_debug(), causing Valgrind errors about uninitialized values in vsnprintf.	2 months ago
Rene Cannao	7c67eb25f1	Fix uninitialized fd and status in Data_Stream constructors Initialize fd=-1 and status=0 in MySQL_Data_Stream and PgSQL_Data_Stream constructors. These fields were not initialized, causing Valgrind errors when GPFC_Statuses2() checked mybe->server_myds->status and fd.	2 months ago
Rene Cannao	2af3b0d333	Add notes about Valgrind and SQLite memory management Add comments to Makefile and deps/Makefile explaining that SQLite's internal memory allocator (enabled by SQLITE_ENABLE_MEMORY_MANAGEMENT) can cause false positives in Valgrind. To avoid this when running Valgrind, rebuild SQLite without this flag.	2 months ago
Rene Cannao	4e39297ef9	Fix more Valgrind uninitialized value errors 1. Base_Thread.cpp: Initialize member variables in constructor - curtime, last_move_to_idle_thread_time, epoll_thread, shutdown, mysql_sessions were not initialized, causing uninitialized value use in ProcessAllMyDS_BeforePoll and ProcessAllMyDS_AfterPoll. 2. MySQL_Logger.cpp: Initialize query_ptr, query_len, and buf in MySQL_Event constructor. These fields were used without initialization, causing Valgrind errors in JSON serialization and other operations.	2 months ago
Rene Cannao	fdbea2a32e	Fix uninitialized memory in Command_Counter::_counters Replace _counters{} initialization syntax with explicit memset() to ensure the _counters array is properly zero-initialized. The _counters{} syntax may not reliably zero-initialize arrays in all compiler implementations, causing Valgrind to report use of uninitialized values when add_and_reset() reads from the array. Also remove the safety checks added previously since the root cause is now properly fixed.	2 months ago
Rene Cannao	c2f82b3d4e	Fix more Valgrind uninitialized value errors 1. MySQL_Logger.cpp: Initialize username_len, schemaname_len, and server_len to 0 in MySQL_Event constructor. These fields were uninitialized and used in copy constructor and JSON serialization. 2. debug.cpp: Add default member initializers to DebugLogEntry struct to ensure POD fields are zero-initialized. Move errno save/restore to after early return checks to avoid potential TLS access issues before thread is fully initialized.	2 months ago
Rene Cannao	ee7ee0b387	Fix multiple Valgrind-reported uninitialized memory issues 1. MySQL_Logger.cpp: Add NULL checks for myconn->parent before accessing address/port. Client connections (frontend) have parent=NULL, causing uninitialized value reads when logging. 2. debug.cpp: Add NULL check for GloVars.global.gdbg_lvl before accessing debug level configuration. Prevents use of uninitialized data when proxy_debug_func is called before init_debug_struct() completes. 3. ProxySQL_Admin.cpp: Add NULL checks for debug filter database fields before constructing filter strings. Prevents undefined behavior when constructing std::string from NULL pointers.	2 months ago
Rene Cannao	af58865b06	Fix uninitialized memory in QueryParserArgs.buf Use memset to zero-initialize the entire QueryParserArgs struct instead of individually setting only digest_text and first_comment to NULL. This fixes Valgrind errors about use of uninitialised values in strcasestr() when reading from the uninitialized buf array. Fixes errors like: Use of uninitialised value of size 8 at tolower (ctype.c:46) by strcasestr by MySQL_Connection::ProcessQueryAndSetStatusFlags(char*)	2 months ago
Rene Cannao	cc53ddca23	Merge branch 'v3.0-openssl-fix' into v3.0-test0213	2 months ago
Rene Cannao	52718df11f	Fix memory leak in stats processlist functions - Add missing delete resultset in stats___mysql_processlist - Add missing delete resultset in stats___pgsql_processlist	2 months ago
René Cannaò	0654efd62b	Merge pull request #5371 from sysown/v3.0-fixes0212 Fix admin shutdown races, RAII sqlite3 statements, and unsafe sprintf usage	2 months ago
Rene Cannao	746eca9f7c	More sprintf to snprintf conversions and indentation fixes - Replace remaining sprintf with snprintf in Admin_FlushVariables.cpp - Fix indentation in flush_GENERIC_variables__process__database_to_runtime - Apply same pattern to ProxySQL_Admin.cpp and ProxySQL_Admin_Stats.cpp	2 months ago
Rene Cannao	3e37337877	Use RAII for sqlite3 statements across codebase - Convert prepare_v2() calls to use unique_ptr RAII pattern - Remove manual sqlite3_finalize calls (now handled by RAII) - Update flush_*_variables functions to use new prepare_v2 return pattern - Apply changes to Admin, Cluster, Monitor, Catalog, and other modules	2 months ago
Rene Cannao	335be9ec72	Fix unsafe sprintf and error message handling - Replace sprintf with snprintf in flush_*_variables functions - Add null value safety with safe_val in variable flushing - Fix error message to use send_error_msg_to_client instead of send_ok_msg_to_client	2 months ago
Rene Cannao	61ce0a96e8	Remove redundant sqlite3_finalize calls in pgSQL stats Statements are managed by RAII and auto-finalized	2 months ago
Rene Cannao	afd6dffb05	Fix admin shutdown races and implement graceful teardown - Add coordinated shutdown for PROXYSQL KILL/SHUTDOWN in debug builds - Track active admin client threads with admin_client_threads_active counter - Add shutdown checks to prevent new connections during shutdown - Wait for all admin client threads to finish before cleanup in admin_shutdown() - Handle accept failures gracefully	2 months ago
Rene Cannao	368a9e3a63	Fix log_buffer debug leak during shutdown	2 months ago
Rene Cannao	ba86be70a6	Fixed some bugs in PR 5358	2 months ago
Rahim Kanji	bed851471a	Fix MySQL Monitor assertion failure in DEBUG builds Introduce destroy_mysql_connection() helper to centralize the pattern of unregistering, closing, and nullifying MySQL connections in monitor threads.	2 months ago
Rene Cannao	da7c8e5cf5	Fix missing variable	2 months ago

1 2 3 4 5 ...

8497 Commits (ade0130e67e88b9052d0dc4e76d48d98d3328485) All Branches Search

8497 Commits (ade0130e67e88b9052d0dc4e76d48d98d3328485)

All Branches