proxysql

Commit Graph

Author	SHA1	Message	Date
Rahim Kanji	a82d653c0b	Handle late COPY protocol messages after session exits fast_forward mode When a COPY FROM STDIN operation encounters an error, the session switches back to normal mode. However, the client may have already pipelined CopyData('d'), CopyDone('c'), or CopyFail('f') messages that are still in the input queue. Previously, these messages fell through to the default case, generating a spurious "Feature not supported" error. This change adds explicit handling to discard these messages when session_fast_forward == SESSION_FORWARD_TYPE_NONE, preventing the race condition from causing errors. The client does not expect a response for these messages in this scenario.	2 months ago
Rahim Kanji	194e20b3e8	Revert "Reset current_hostgroup to default when no query rule matches" This reverts commit `1b3d20388e`.	2 months ago
Rahim Kanji	1f0756b59f	Correct bytes_sent tracking for extended query protocol Fix missing and incorrect update_bytes_sent() calls in PgSQL_Connection async state machine.	2 months ago
Rahim Kanji	49da3fb07f	Created new group 'pgsql17-repl'	2 months ago
Rahim Kanji	ab1173ea4e	Add TAP test for query rules routing Added TAP test to verify query routing works correctly for both text protocol and extended query protocol. Test cases: - Test 1: Basic read/write split (^SELECT -> HG 1, others -> HG 0) - Test 2: Table-specific routing rules - Test 3: SELECT ... FOR UPDATE exception handling Each test validates routing by checking query counts in stats.stats_pgsql_connection_pool for both protocols.	2 months ago
Rahim Kanji	db5f1ea498	Track query count for extended query protocol executions The queries_sent counter in stats.stats_pgsql_connection_pool was not being incremented for prepared statement executions (ASYNC_STMT_EXECUTE_START), only for regular queries (ASYNC_QUERY_START) and statement preparation (ASYNC_STMT_PREPARE_START).	2 months ago
Rahim Kanji	1b3d20388e	Reset current_hostgroup to default when no query rule matches In the extended query protocol flow (Parse/Bind/Execute/Sync messages), queries without matching query rules were incorrectly retaining the current_hostgroup value from the previous query instead of being reset to the default_hostgroup. This happened because: - Simple query protocol goes through STATE_SLEEP between queries, which resets current_hostgroup to default_hostgroup - Extended query protocol does NOT go through STATE_SLEEP between Parse/Bind/Execute messages, so current_hostgroup was never reset	2 months ago
René Cannaò	28b1114cd9	Merge pull request #5353 from sysown/v3.0_pgsql-prepared-statement-refcount-race-5352 Fix PostgreSQL prepared statement purge crash: use memory_order_acquire instead of memory_order_relaxed	2 months ago
René Cannaò	acd955b9d6	Merge pull request #5382 from sysown/v3.0-webui_2602 feat: add friend declaration for MetricsCollector to access MyHostGroups	2 months ago
René Cannaò	5de836a4c1	Merge pull request #5373 from sysown/v3.0_improve_mysql_monitoring_5256 Improve MySQL Monitor connection management	2 months ago
René Cannaò	3b578db4bf	Merge pull request #5374 from sysown/v3.0-test0213 Fix Valgrind-reported uninitialized memory issues	2 months ago
René Cannaò	83209da487	Merge pull request #5356 from sysown/v3.0-5355 Fix #5355: Add null pointer check in RequestEnd() to prevent use-after-free crash	2 months ago
Rene Cannao	37e72ea3f9	Fix PROXY protocol detection in MySQL_Data_Stream::read_from_net When pkts_recv==0, the code reads 4 bytes expecting a MySQL packet header, but PROXY protocol starts with 'PROXY ' which gets misinterpreted as a MySQL header with a huge packet length (0x504f5250 = ~1.3GB). Add check for 'PROX' prefix before parsing as MySQL header. This prevents passing an incorrect length parameter to recv() that exceeds the buffer size. Fixes #5376	2 months ago
Rene Cannao	11a43bf768	Fix uninitialized max_allowed_pkt in MySQL_Connection constructor Initialize options.max_allowed_pkt to 0 to prevent Valgrind errors when logging handshake debug information.	2 months ago
Rene Cannao	ca4f858b29	Fix uninitialized memory read in pgsql tokenizer Change malloc() to calloc() in get_result_buffer() to zero-initialize the query digest buffer before use. This prevents stage_2_parsing() from reading uninitialized memory when processing query digests. Fixes #5375	2 months ago
Rene Cannao	85952373d9	Fix uninitialized mondb pointer in MySQL_Monitor_State_Data constructor Add mondb = NULL initialization to prevent Valgrind errors when monitor threads access the pointer before it's properly set.	2 months ago
Rahim Kanji	d42d89ae36	Fix TAP test when statement count after worker threads is below cache limit. Calculate dynamically how many statements to create to ensure we exceed CACHE_LIMIT (1024) and trigger a purge.	2 months ago
Rahim Kanji	8ca6323eef	Merge remote-tracking branch 'Master/v3.0' into v3.0_pgsql-prepared-statement-refcount-race-5352	2 months ago
Rene Cannao	200fdecb8d	Apply AI agent review fixes to PR #5374 Critical Fixes: - Fix NULL pointer dereferences in MySQL_Logger.cpp: * Add null checks for myds->myconn->parent in log_audit_entry() * Fix cleanup code in log_request() and log_audit_entry() * Change sprintf to snprintf for buffer safety - Remove redundant pthread_rwlock_init in debug.cpp: * filters_rwlock already initialized with PTHREAD_RWLOCK_INITIALIZER * Re-initialization caused undefined behavior per POSIX Major Improvements: - Add bounded wait helper wait_for_glo_mth() in proxysql_utils.h: * Replaces indefinite while loops with 10s timeout * Applied to 26 locations across 4 files Build System: - Require C++17 in Makefile (remove C++11 fallback): * Code uses C++17 structured bindings extensively * Cleanest solution vs adding fallback guards to 27+ locations Compilation fixes: - Add unistd.h include for usleep - Remove conflicting GloMyMon extern declaration Files changed: - Makefile - include/proxysql_utils.h - lib/MySQL_Logger.cpp - lib/debug.cpp - lib/MySQL_Monitor.cpp - lib/ProxySQL_Admin.cpp - lib/ClickHouse_Server.cpp - src/SQLite3_Server.cpp	2 months ago
Rahim Kanji	1cccfb3220	Fix connection cleanup in failure paths	2 months ago
Rene Cannao	941e6b7320	Fix filters_rwlock initialization race condition Add static initialization PTHREAD_RWLOCK_INITIALIZER to filters_rwlock in debug.cpp to prevent race condition where proxy_debug() is called before init_debug_struct() initializes the rwlock. This fixes Valgrind errors in filter_debug_entry() where threads were accessing an uninitialized rwlock.	2 months ago
Rene Cannao	3c85c593cf	Add GloMTH initialization wait to all monitor and server threads Fix race condition where threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int() and related functions. Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to ensure GloMTH is fully initialized before use: In lib/MySQL_Monitor.cpp: - monitor_connect(), monitor_ping(), monitor_read_only() - monitor_group_replication(), monitor_galera(), monitor_replication_lag() - monitor_AWS_Aurora_thread_HG(), monitor_aws_aurora() - init_mysql_thread_struct() In src/SQLite3_Server.cpp: - SQLite3_Server_session_handler In lib/ProxySQL_Admin.cpp: - admin_session_handler In lib/ClickHouse_Server.cpp: - ClickHouse_Server_session_handler The pattern ensures threads wait for GloMTH initialization during startup, then check for NULL during shutdown to exit cleanly.	2 months ago
Rene Cannao	aa53d990ed	Add GloMTH initialization wait to all monitor threads Fix race condition where monitor threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int(). Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to: - monitor_ping_thread - monitor_read_only_thread - monitor_replication_lag_thread - monitor_group_replication_thread (also moved check before MySQL_Thread creation) - monitor_galera_thread (also moved check before MySQL_Thread creation) This matches the existing pattern in monitor_connect_thread.	2 months ago
Rene Cannao	f4cd34be5c	Fix race condition in monitor_connect_thread Add wait loop for GloMTH initialization before accessing variables. Other monitor threads (MonitorPing, MonitorReadOnly, etc.) already had this pattern, but monitor_connect_thread was missing it. This fixes Valgrind errors about uninitialized values in get_variable_uint16() when strcasecmp reads from memory that hasn't been fully initialized yet.	2 months ago
Rahim Kanji	33ce4217f0	Merge remote-tracking branch 'v3.0' into v3.0_improve_mysql_monitoring_5256	2 months ago
Rahim Kanji	9eac5f6420	Improve async ping mmsd ownership tracking and pool validation	2 months ago
Rene Cannao	09d0dcb808	Fix uninitialized tmp_charset in Data_Stream constructors Initialize tmp_charset=0 in MySQL_Data_Stream and PgSQL_Data_Stream constructors. This field was used uninitialized in process_pkt_handshake_response() when calling proxy_debug(), causing Valgrind errors about uninitialized values in vsnprintf.	2 months ago
Rene Cannao	7c67eb25f1	Fix uninitialized fd and status in Data_Stream constructors Initialize fd=-1 and status=0 in MySQL_Data_Stream and PgSQL_Data_Stream constructors. These fields were not initialized, causing Valgrind errors when GPFC_Statuses2() checked mybe->server_myds->status and fd.	2 months ago
Rene Cannao	2af3b0d333	Add notes about Valgrind and SQLite memory management Add comments to Makefile and deps/Makefile explaining that SQLite's internal memory allocator (enabled by SQLITE_ENABLE_MEMORY_MANAGEMENT) can cause false positives in Valgrind. To avoid this when running Valgrind, rebuild SQLite without this flag.	2 months ago
Rene Cannao	4e39297ef9	Fix more Valgrind uninitialized value errors 1. Base_Thread.cpp: Initialize member variables in constructor - curtime, last_move_to_idle_thread_time, epoll_thread, shutdown, mysql_sessions were not initialized, causing uninitialized value use in ProcessAllMyDS_BeforePoll and ProcessAllMyDS_AfterPoll. 2. MySQL_Logger.cpp: Initialize query_ptr, query_len, and buf in MySQL_Event constructor. These fields were used without initialization, causing Valgrind errors in JSON serialization and other operations.	2 months ago
Rene Cannao	fdbea2a32e	Fix uninitialized memory in Command_Counter::_counters Replace _counters{} initialization syntax with explicit memset() to ensure the _counters array is properly zero-initialized. The _counters{} syntax may not reliably zero-initialize arrays in all compiler implementations, causing Valgrind to report use of uninitialized values when add_and_reset() reads from the array. Also remove the safety checks added previously since the root cause is now properly fixed.	2 months ago
Rene Cannao	c2f82b3d4e	Fix more Valgrind uninitialized value errors 1. MySQL_Logger.cpp: Initialize username_len, schemaname_len, and server_len to 0 in MySQL_Event constructor. These fields were uninitialized and used in copy constructor and JSON serialization. 2. debug.cpp: Add default member initializers to DebugLogEntry struct to ensure POD fields are zero-initialized. Move errno save/restore to after early return checks to avoid potential TLS access issues before thread is fully initialized.	2 months ago
Rene Cannao	ee7ee0b387	Fix multiple Valgrind-reported uninitialized memory issues 1. MySQL_Logger.cpp: Add NULL checks for myconn->parent before accessing address/port. Client connections (frontend) have parent=NULL, causing uninitialized value reads when logging. 2. debug.cpp: Add NULL check for GloVars.global.gdbg_lvl before accessing debug level configuration. Prevents use of uninitialized data when proxy_debug_func is called before init_debug_struct() completes. 3. ProxySQL_Admin.cpp: Add NULL checks for debug filter database fields before constructing filter strings. Prevents undefined behavior when constructing std::string from NULL pointers.	2 months ago
Rene Cannao	af58865b06	Fix uninitialized memory in QueryParserArgs.buf Use memset to zero-initialize the entire QueryParserArgs struct instead of individually setting only digest_text and first_comment to NULL. This fixes Valgrind errors about use of uninitialised values in strcasestr() when reading from the uninitialized buf array. Fixes errors like: Use of uninitialised value of size 8 at tolower (ctype.c:46) by strcasestr by MySQL_Connection::ProcessQueryAndSetStatusFlags(char*)	2 months ago
Rene Cannao	cc53ddca23	Merge branch 'v3.0-openssl-fix' into v3.0-test0213	2 months ago
Rene Cannao	52718df11f	Fix memory leak in stats processlist functions - Add missing delete resultset in stats___mysql_processlist - Add missing delete resultset in stats___pgsql_processlist	2 months ago
René Cannaò	0654efd62b	Merge pull request #5371 from sysown/v3.0-fixes0212 Fix admin shutdown races, RAII sqlite3 statements, and unsafe sprintf usage	2 months ago
Rene Cannao	746eca9f7c	More sprintf to snprintf conversions and indentation fixes - Replace remaining sprintf with snprintf in Admin_FlushVariables.cpp - Fix indentation in flush_GENERIC_variables__process__database_to_runtime - Apply same pattern to ProxySQL_Admin.cpp and ProxySQL_Admin_Stats.cpp	2 months ago
Rene Cannao	3e37337877	Use RAII for sqlite3 statements across codebase - Convert prepare_v2() calls to use unique_ptr RAII pattern - Remove manual sqlite3_finalize calls (now handled by RAII) - Update flush_*_variables functions to use new prepare_v2 return pattern - Apply changes to Admin, Cluster, Monitor, Catalog, and other modules	2 months ago
Rene Cannao	335be9ec72	Fix unsafe sprintf and error message handling - Replace sprintf with snprintf in flush_*_variables functions - Add null value safety with safe_val in variable flushing - Fix error message to use send_error_msg_to_client instead of send_ok_msg_to_client	2 months ago
Rene Cannao	61ce0a96e8	Remove redundant sqlite3_finalize calls in pgSQL stats Statements are managed by RAII and auto-finalized	2 months ago
Rene Cannao	afd6dffb05	Fix admin shutdown races and implement graceful teardown - Add coordinated shutdown for PROXYSQL KILL/SHUTDOWN in debug builds - Track active admin client threads with admin_client_threads_active counter - Add shutdown checks to prevent new connections during shutdown - Wait for all admin client threads to finish before cleanup in admin_shutdown() - Handle accept failures gracefully	2 months ago
Rene Cannao	368a9e3a63	Fix log_buffer debug leak during shutdown	2 months ago
Rene Cannao	ba86be70a6	Fixed some bugs in PR 5358	2 months ago
Rahim Kanji	bed851471a	Fix MySQL Monitor assertion failure in DEBUG builds Introduce destroy_mysql_connection() helper to centralize the pattern of unregistering, closing, and nullifying MySQL connections in monitor threads.	2 months ago
Rene Cannao	da7c8e5cf5	Fix missing variable	2 months ago
Rene Cannao	4ae5bd852a	Revert "fix: prevent dangling pointer in flush_*_variables___runtime_to_database" This reverts commit `a20b2704f4`.	2 months ago
René Cannaò	02ea4f90be	Merge pull request #5360 from sysown/v3.0-5359 fix: crash on macOS/FreeBSD when running PostgreSQL queries	2 months ago
René Cannaò	e82ff6f8aa	Merge pull request #5361 from sysown/v3.0-5069 Add protocol labels for all PostgreSQL metrics and extend prometheus metrics coverage	2 months ago
Rene Cannao	a69b925932	Minor typo fixes	2 months ago

1 2 3 4 5 ...

8497 Commits (a82d653c0bbb25db93b8a124f4efd2fb45950d8a) All Branches Search

8497 Commits (a82d653c0bbb25db93b8a124f4efd2fb45950d8a)

All Branches