proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	7a0026fc03	Address review feedback on connection pool unit tests (PR #5502 ) - ConnectionPoolDecision.h: expand docstring for calculate_eviction_count to clarify max_connections=0 edge case behavior - connection_pool_unit-t.cpp: check test_init_minimal() return code instead of ignoring it (+1 test, plan updated to 23)	2 months ago
René Cannaò	37ce0525bb	Fix connection pool extraction: separate header, proper unit tests Fixes the Copilot-generated PR #5500 production code and test file: Production fixes: - Create standalone ConnectionPoolDecision.h header with the struct and function declarations (no circular dependency issues) - Include ConnectionPoolDecision.h in MySrvConnList.cpp and PgSQL_HostGroups_Manager.cpp to resolve compilation errors - Replace inline declarations in Base_HostGroups_Manager.h with #include "ConnectionPoolDecision.h" Test fixes: - Remove misplaced test from test/tap/tests/ (tested reimplemented copies of functions instead of the real code) - Add proper unit test at test/tap/tests/unit/connection_pool_unit-t.cpp using the test harness (test_globals.h, test_init.h) - 22 test cases covering eviction, throttling, pool state decisions, warming, and edge cases - Register in unit test Makefile	2 months ago

Author

SHA1

Message

Date

René Cannaò

7a0026fc03

Address review feedback on connection pool unit tests (PR #5502 )

- ConnectionPoolDecision.h: expand docstring for calculate_eviction_count
  to clarify max_connections=0 edge case behavior
- connection_pool_unit-t.cpp: check test_init_minimal() return code
  instead of ignoring it (+1 test, plan updated to 23)

René Cannaò

37ce0525bb

Fix connection pool extraction: separate header, proper unit tests

Fixes the Copilot-generated PR #5500 production code and test file:

Production fixes:
- Create standalone ConnectionPoolDecision.h header with the struct
  and function declarations (no circular dependency issues)
- Include ConnectionPoolDecision.h in MySrvConnList.cpp and
  PgSQL_HostGroups_Manager.cpp to resolve compilation errors
- Replace inline declarations in Base_HostGroups_Manager.h with
  #include "ConnectionPoolDecision.h"

Test fixes:
- Remove misplaced test from test/tap/tests/ (tested reimplemented
  copies of functions instead of the real code)
- Add proper unit test at test/tap/tests/unit/connection_pool_unit-t.cpp
  using the test harness (test_globals.h, test_init.h)
- 22 test cases covering eviction, throttling, pool state decisions,
  warming, and edge cases
- Register in unit test Makefile

2 Commits (90e888e1d0ebe4dd9b95ad86dfe8a4bbd377799d)