proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	3f25fb6c4e	Enhance anomaly detector unit tests with additional edge case coverage - Add edge case tests for SQL injection pattern detection: * Empty and NULL query handling * Very long query processing - Add edge case tests for query normalization: * Empty query handling * Unicode character support * Nested comment processing * Multiple line comment handling - Add edge case tests for risk scoring: * Negative match handling * Large match count capping * Boundary condition validation - Fix test assertions for more robust validation - All 39 tests now pass successfully These improvements address potential feedback from code reviewers by providing more comprehensive test coverage for edge cases and boundary conditions.	5 months ago
Rene Cannao	2888ee3f45	Fix gemini-code-assist recommendations and implement comprehensive anomaly detection tests - Fix retry logic to use is_retryable_error function for proper HTTP error handling - Add exception handling to get_json_int function with try-catch around std::stoi - Improve validate_numeric_range to use strtol instead of atoi for better error reporting - Fix Chinese characters in documentation (non-zero -> non-zero) - Replace placeholder tests with actual comprehensive tests for anomaly detection functionality - Create new standalone unit test anomaly_detector_unit-t.cpp with 29 tests covering: * SQL injection pattern detection (12 tests) * Query normalization (8 tests) * Risk scoring calculations (5 tests) * Configuration validation (4 tests) - All tests pass successfully, providing meaningful validation of core anomaly detection logic Thanks to gemini-code-assist for the thorough code review and recommendations.	5 months ago

Author

SHA1

Message

Date

Rene Cannao

3f25fb6c4e

Enhance anomaly detector unit tests with additional edge case coverage

- Add edge case tests for SQL injection pattern detection:
  * Empty and NULL query handling
  * Very long query processing
- Add edge case tests for query normalization:
  * Empty query handling
  * Unicode character support
  * Nested comment processing
  * Multiple line comment handling
- Add edge case tests for risk scoring:
  * Negative match handling
  * Large match count capping
  * Boundary condition validation
- Fix test assertions for more robust validation
- All 39 tests now pass successfully

These improvements address potential feedback from code reviewers by providing more comprehensive test coverage for edge cases and boundary conditions.

Rene Cannao

2888ee3f45

Fix gemini-code-assist recommendations and implement comprehensive anomaly detection tests

- Fix retry logic to use is_retryable_error function for proper HTTP error handling
- Add exception handling to get_json_int function with try-catch around std::stoi
- Improve validate_numeric_range to use strtol instead of atoi for better error reporting
- Fix Chinese characters in documentation (non-zero -> non-zero)
- Replace placeholder tests with actual comprehensive tests for anomaly detection functionality
- Create new standalone unit test anomaly_detector_unit-t.cpp with 29 tests covering:
  * SQL injection pattern detection (12 tests)
  * Query normalization (8 tests)
  * Risk scoring calculations (5 tests)
  * Configuration validation (4 tests)
- All tests pass successfully, providing meaningful validation of core anomaly detection logic

Thanks to gemini-code-assist for the thorough code review and recommendations.

2 Commits (7e1a12b8f707d1f0d64c31eaf655bc3cee4e27df)