proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	7e1a12b8f7	feat: add generic plugin ABI and loader	2 months ago
Rene Cannao	8cecd064fa	chore: ignore local git worktrees	2 months ago
Rene Cannao	5392c0a6a2	Add mysqlx plugin design spec	2 months ago
René Cannaò	d7a26b79e9	Merge pull request #5577 from sysown/v3.0-ci0405 Fix CI test failures and workflow race conditions	2 months ago
Rene Cannao	78c8a3d5e3	Fail fast in purge-trigger setup if connection or stmt fails Address review feedback: instead of silently continuing when the purge-trigger reconnect/prepare/deallocate fails, return false immediately with a diagnostic message.	2 months ago
Rene Cannao	3296ed5a07	Moving test_cluster_sync_mysql_servers-t from legacy-g3 to legacy-g5	2 months ago
Rene Cannao	26c5a25724	Fix read_only test assuming default_hostgroup=0 The test configures mysql_servers with writer_hostgroup=0 and reader_hostgroup=1, but the CI infrastructure sets users' default_hostgroup to 1300. When the test opens a proxy connection and runs BEGIN, ProxySQL routes to hostgroup 1300 which has no servers, causing a 10s timeout. Fix by setting default_hostgroup=0 for the test user at the start of each scenario.	2 months ago
Rene Cannao	1261d18a95	Fix SHOW WARNINGS test to work with MySQL 5.7 CAST('abc' AS DOUBLE) is MySQL 8.0+ syntax and fails on the legacy test group which uses MySQL 5.7. Use CAST('abc' AS SIGNED) instead, which produces a truncation warning on all MySQL versions. Fixes regression from PR #5548.	2 months ago
Rene Cannao	9098992f82	Fix timing issue in PgSQL prepared statement purge test The purge verification in test 1 was checking the statement count immediately after creating statements. The purge mechanism has a 1-second minimum interval between attempts and only removes statements with ref_count_client == 0. Fix by closing the connection (dropping refcounts), waiting 3 seconds, then triggering a new refcount change to invoke the purge before checking.	2 months ago
Rene Cannao	73a561450d	Fix race condition in CI-legacy-* workflow triggers All 4 CI-legacy workflows used `types: [ in_progress ]` which fired them before CI-builds finished, causing cache-miss failures on the build artifacts. Change to `types: [ completed ]` and add success guard, matching the pattern used by CI-taptests-groups. Affected workflows: - CI-legacy-clickhouse-g1 - CI-legacy-g2 - CI-legacy-g2-genai - CI-legacy-g4	2 months ago
Rene Cannao	fe5a819051	Add 3 missing tests to groups.json Register newly compiled test binaries that were missing from groups.json, causing check_groups.py to block CI runs: - gtid_server_data_unit-t → unit-tests-g1 - test_ffto_mysql_errors-t → legacy-g4, mysql84-g4 - test_ffto_pgsql_error_stats-t → legacy-g4, mysql84-g4	2 months ago
René Cannaò	7510d8073a	Merge pull request #5553 from sysown/fix/5539-ffto-default-by-tier Disable FFTO by default in 3.1.x, keep enabled in 4.0.x	2 months ago
René Cannaò	ceb9690891	Merge commit from fork Fix COM_STMT_SEND_LONG_DATA short packet handling	2 months ago
René Cannaò	3659ba85fb	Merge branch 'v3.0' into advisory/com-stmt-send-long-data-fix-1 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rene Cannao	151169da9b	Fix COM_STMT_SEND_LONG_DATA short packet handling	2 months ago
René Cannaò	49b60b24a6	Merge commit from fork Fix unterminated HandshakeResponse username parsing	2 months ago
René Cannaò	b94c855d4c	Merge branch 'v3.0' into advisory-fix-1 Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
René Cannaò	fa6ebcdcc9	Merge commit from fork Fix PROXY protocol v1 address overflow	2 months ago
René Cannaò	419cd7608b	Merge commit from fork Fix COM_STMT_CLOSE short packet handling	2 months ago
René Cannaò	7a574a537a	Merge commit from fork Validate COM_CHANGE_USER packet bounds	2 months ago
René Cannaò	63007cfa39	Merge pull request #5559 from sysown/v3.0-issue5556 Fix crash when COM_BINLOG_DUMP received with idle backends (#5556)	2 months ago
Rene Cannao	499896e44b	Address PR review feedback for test_binlog_dump_multi_backend_crash - Move wait_timeout mutation after hostgroup discovery skip check so early returns don't leave backend state modified (Copilot review) - Add precondition assertion verifying connections exist in both writer and reader hostgroups before sending COM_BINLOG_DUMP, using ConnOK pool stats (CodeRabbit review)	2 months ago
Rene Cannao	b2f4b4f9a0	Fix crash when COM_BINLOG_DUMP received with idle backends from other hostgroups (#5556 ) When a session has backend connections to multiple hostgroups and receives COM_BINLOG_DUMP, GPFC_Replication_SwitchToFastForward() transitions the session to FAST_FORWARD mode but only manages the active backend. Idle backends from other hostgroups remain in the session's mybes array with async_state_machine==ASYNC_IDLE. If MySQL's wait_timeout closes one of these idle connections, the resulting POLLIN event causes handler() to be called with ASYNC_IDLE, which has no case in the switch and hits assert(0). Fix: Clean up idle backends from other hostgroups during the FAST_FORWARD transition in GPFC_Replication_SwitchToFastForward(). These connections will never be used again, so they are destroyed immediately. Includes a regression test (test_binlog_dump_multi_backend_crash-t) that: - Sets up two hostgroups with query rules routing SELECTs to reader HG - Creates backend connections to both hostgroups on one session - Sends COM_BINLOG_DUMP to enter FAST_FORWARD mode - Waits for wait_timeout to close the idle backend - Verifies ProxySQL does not crash	2 months ago
Rene Cannao	61fc7a129c	Disable FFTO by default in 3.1.x, keep enabled in 4.0.x (#5539 ) Gate the ffto_enabled default on PROXYSQLGENAI so that: - 3.1.x (PROXYSQL31): FFTO compiled in but disabled by default - 4.0.x (PROXYSQLGENAI): FFTO enabled by default (unchanged) Users on 3.1.x can still opt in via SET mysql-ffto_enabled='true'.	2 months ago
René Cannaò	d0625dc243	Merge pull request #5549 from sysown/v3.0-CodeCov0325 Add 32 unit test files (2963 assertions) and CI workflow improvements	2 months ago
Rene Cannao	6d6015a203	fix: align MCP Bearer token test with case-insensitive implementation The test expected lowercase 'bearer' to be rejected, but the implementation uses strncasecmp() per RFC 7235 (auth-scheme is case-insensitive). Update test to expect true for lowercase prefix.	2 months ago
René Cannaò	2fcc5729ee	Merge pull request #5548 from yuji-hatakeyama/5306-fix_show_warnings_with_comment Fix #5306 - SHOW WARNINGS with inline comments incorrectly sets warning_count	2 months ago
Rene Cannao	8b0c7be827	Add fallback to raw query when digest_text is unavailable When query digests are disabled (digest_text is NULL), the SHOW WARNINGS detection would always return false, losing the original behavior for plain "SHOW WARNINGS" queries. Add an else branch that falls back to checking query.ptr, preserving the pre-fix behavior when digests are off.	2 months ago
Rene Cannao	b40c77c48d	Revert "fix(#5306 ): SHOW WARNINGS with inline comments incorrectly sets warning_count" This reverts commit `049ea8ce84`.	2 months ago
Rene Cannao	049ea8ce84	fix(#5306 ): SHOW WARNINGS with inline comments incorrectly sets warning_count When SHOW WARNINGS queries contain inline comments (e.g., "SHOW /* comment */ WARNINGS"), ProxySQL incorrectly includes warning_count in the EOF packet because the detection used raw query text which still contains comments. Fix: use digest_text (comments stripped by the query processor) for SHOW WARNINGS detection, with fallback to raw query.ptr when digest_text is unavailable (digests disabled). This preserves the original behavior for both digest-enabled and digest-disabled modes. Reported by DBIx::Sunny (Perl) users who send annotated queries. Closes #5306	2 months ago
René Cannaò	e067683f4e	Merge pull request #5545 from sysown/feat/ffto-error-recording feat(ffto): record error details from fast-forward sessions	2 months ago
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	2 months ago
Rene Cannao	4fb7aac73f	fix: restore groups.json to compact one-line-per-entry format Previous commits inadvertently reformatted groups.json with Python's json.dump(indent=2), breaking the compact format required by test/tap/groups/README.md. The correct format is one entry per line with compact arrays so grep works for quick lookups.	2 months ago
Rene Cannao	0441d5026d	security: fix all 48 Dependabot alerts — bump Python test deps Update all vulnerable Python packages in test infrastructure: Package Old New Severity CVEs PyMySQL 0.9.2 >=1.1.1 CRITICAL CVE-2024-36039 (SQL injection) requests 2.26.0 >=2.33.0 HIGH CVE-2024-35195, CVE-2024-47081, CVE-2023-32681, CVE-2026-25645 urllib3 1.26.6 >=2.6.3 HIGH CVE-2023-43804, CVE-2023-45803, CVE-2024-37891, CVE-2025-50181, CVE-2025-66418, CVE-2025-66471, CVE-2026-21441 certifi 2021.5.30 >=2024.7.4 HIGH CVE-2022-23491, CVE-2023-37920, CVE-2024-39689 idna 2.10 >=3.7 MEDIUM CVE-2024-3651 Changes: - requirements.txt: bump all 6 packages, use >= instead of == - requirements-ubuntu24.txt: same bumps - Pipfile: bump pymysql/requests, update python_version 2.7 → 3 - Remove stale Pipfile.lock (generated for Python 2.7, all hashes outdated) API compatibility verified: - PyMySQL: pymysql.connect(), DictCursor, OperationalError, CLIENT.MULTI_STATEMENTS, defer_connect all work in 1.1.x. `passwd` kwarg is aliased to `password` internally. - requests: basic requests.post() usage unchanged - urllib3/certifi/idna: transitive deps, no direct API usage Note: CI Docker image (ubuntu:24.04) installs packages via apt-get, not pip. These requirements files are used for local dev and some CI fallback paths.	3 months ago
Rene Cannao	cde4cc78eb	ci: add CI workflows for legacy-g4 and legacy-clickhouse-g1 Add dispatcher workflows that trigger on CI-trigger: - CI-legacy-g4.yml — runs legacy-g4 TAP test group - CI-legacy-clickhouse-g1.yml — runs legacy-clickhouse-g1 TAP tests Both use in_progress trigger type (start immediately with CI-trigger) matching the pattern of CI-legacy-g2.yml. Also includes draft reusable workflows in gh-actions-reusable/ that need to be pushed to the GH-Actions branch: - ci-legacy-g4.yml — adapted from ci-legacy-g2.yml - ci-legacy-clickhouse-g1.yml — adapted with clickhouse23 infra To activate: 1. Push ci-legacy-g4.yml and ci-legacy-clickhouse-g1.yml to sysown/proxysql GH-Actions branch under .github/workflows/ 2. The dispatcher workflows on feature branches will then find them Already active (no changes needed): - CI-legacy-g2.yml — already exists - CI-basictests.yml — already exists	3 months ago
Rene Cannao	e806b0219c	test: register 5 new unit tests in groups.json for CI	3 months ago
Rene Cannao	c8408d76b3	test: add 6 unit test files with 588 assertions (Round 5) New test files (test/tap/tests/unit/): Core: - pgsql_tokenizer_unit-t (65 tests): PgSQL SQL digest — dollar- quoted strings, ::type casts, ARRAY literals, boolean literal replacement, E/B/X/U& prefix strings, comment handling, grouping/IN-list collapsing, edge cases - admin_disk_upgrade_unit-t (60 tests): all 6 disk_upgrade_*() schema migration functions with in-memory SQLite — scheduler v1.2.0→current, mysql_users v1.3.0→current, rest_api_routes v2.0.15→current, mysql_servers v1.1.0→current (with weight cap and compression normalization bugs), pgsql_replication_hostgroups v3.0.1→current, mysql_query_rules v1.2.2→current - gtid_utils_unit-t (37 tests): addGtid interval merging (adjacent, non-consecutive, duplicate, bridge, reverse-order, within- existing), addGtidInterval (update, duplicate, non-overlapping), gtid_executed_to_string formatting - glovars_unit-t (78 tests): GloVars constructor defaults, ProxySQL_Checksum_Value (set/replace_zeros/version/epoch), generate_global_checksum determinism, command-line parsing (--initial/--reload/--no-version-check/-D/--bootstrap/-n/-f/-M) - query_processor_unit-t (+217 tests, 259 total): EXTENDED with PgSQL-specific tests — all-fields rule creation, client_addr wildcard, flagOUT attributes JSON, command counters, stats, rule text 35-column serialization, query_parser_command_type for 100+ PgSQL commands (DML/DDL/views/sequences/functions/ triggers/policies/LISTEN/NOTIFY/VACUUM/TEXT SEARCH/etc.), fast routing hashmap, firewall whitelist, query digests GenAI/MCP (PROXYSQLGENAI=1): - genai_mysql_catalog_unit-t (89 tests): MySQL_Catalog with in-memory SQLite — upsert/get/remove, schema isolation, list with pagination, FTS search, merge, multiple kinds, special character handling Production changes for testability: - include/proxysql_admin.h: add friend class TestDiskUpgrade - test/tap/tests/unit/Makefile: add DEBUG auto-detection from libproxysql.a symbols (fixes struct layout ODR violations when library is built with -DDEBUG) Running totals: 32 test files, 2553 assertions, all passing.	3 months ago
Rene Cannao	8df688dd8a	test: register 5 new unit tests in groups.json for CI	3 months ago
Rene Cannao	a36834f968	test: add 6 unit test files with 676 assertions (Round 4) New test files (test/tap/tests/unit/): Core: - c_tokenizer_unit-t (59 tests): tokenizer/tokenize/free_tokenizer, c_split_2, mysql_query_digest_and_first_comment (literal replacement, comment stripping, NULL handling, grouping_limit, IN-clause), mysql_query_digest_first_stage, strip_comments - config_write_unit-t (111 tests): all 7 Write_*_to_configfile() functions with in-memory SQLite — MySQL users/servers/query rules, scheduler, restapi, global variables, proxysql_servers; tests field formatting, NULL handling, double-quote escaping, prefix grouping - listen_validator_unit-t (112 tests): trim_copy, split_listener_list, is_ipv4/ipv6_wildcard, parse_listener (IPv4/IPv6/Unix socket/ invalid/edge cases), sets_intersect, listeners_conflict, validate_module_listener_conflicts - ezoption_parser_unit-t (110 tests): standalone ezOptionParser — flags, string/int/float options, defaults, required/unknown, aliases, multi-value, usage layout, export/import, validators, vector getters - pgsql_txn_state_unit-t (+58 tests, 112 total): EXTENDED with PgSQL_ExplicitTxnStateMgr state machine tests — BEGIN/COMMIT/ ROLLBACK lifecycle, ROLLBACK AND CHAIN, savepoint add/release/ rollback_to, reset_state, fill_internal_session JSON, case- insensitive savepoints, END/ABORT synonyms. Uses minimal PgSQL_Session mock with variable snapshots. GenAI/MCP (PROXYSQLGENAI=1): - genai_discovery_schema_unit-t (172 tests): Discovery_Schema with in-memory SQLite — run/agent_run management, schema/object/column/ index/FK insertion, profile/LLM summary/domain/metrics/notes, list_objects pagination+ordering, get_object with columns/indexes, get_relationships FK mappings, FTS rebuild+search, fingerprint_mcp_args, compute_mcp_digest determinism, MCP_Query_Digest_Stats timing, MCP_Query_Processor_Output, MCP_Query_Rule defaults Running totals: 27 test files, 1944+ assertions, all passing.	3 months ago
Rene Cannao	a8c5432fc5	fix: remove stale proxysql.db before launching cluster sync replicas test_cluster_sync_mysql_servers-t spawns replica ProxySQL instances with a specific config file setting admin port to 96061/96062. If a proxysql.db from a previous run exists in the workdir, ProxySQL ignores the config file and loads from the DB instead, using the old admin port. The test then fails to connect on the expected port. Fix: remove proxysql.db and proxysql_stats.db before launching the replica, not just after. The post-launch cleanup is kept as well for normal operation.	3 months ago
Rene Cannao	0f76a18329	fix: resolve CI failures in charset_find and statistics unit tests charset_find_unit-t: - Fix plan count mismatch: plan(63) but only 62 ok() calls. Changed to plan(62). statistics_unit-t: - Root cause: TSDB auto-detect in Makefile searched for symbol 'ProxySQL_TSDB' which doesn't exist. Changed to 'init_tsdb_variables'. Without TSDB detection, struct layout mismatch caused statsdb_disk to appear as NULL (member offset shifted by #ifdef PROXYSQLTSDB). - Added statsdb_ok guard + skip() for test_init_creates_tables to prevent segfault if construction fails (graceful degradation). - Use TMPDIR/tmp directly instead of GloVars.datadir for statsdb path.	3 months ago
Yuji Hatakeyama	eda537ac6c	Add reg_test_5306 to test groups, excluding digest-disabled configs	3 months ago
Yuji Hatakeyama	604c020857	Fix #5306 : Use digest_text to suppress warning_count for SHOW WARNINGS	3 months ago
Yuji Hatakeyama	7e1b8ac0e4	Fix #5306 : Add regression test for SHOW WARNINGS with comments	3 months ago
Rene Cannao	99dcb5b160	fix: namespace stats_utils helpers to avoid symbol collision ProxySQL_Admin_Tests2.cpp defines its own parse_int_or_zero() in an anonymous namespace. Our declaration in Stats_Tool_Handler.h (included transitively via cpp.h) created an ambiguous overload error. Fix: wrap the 4 helper functions in namespace stats_utils in both the header and implementation. A using-directive within the .cpp keeps existing call sites working without qualification.	3 months ago
Rene Cannao	99c86e5759	test: run check_groups.py at start of run-multi-group.bash Abort CI early if any compiled test binaries are missing from groups.json. This prevents silent test omissions — if a developer adds a test but forgets to register it, CI fails immediately with a clear message instead of silently skipping it.	3 months ago
Rene Cannao	093693ba06	test: add check_groups.py to verify groups.json completeness Python tool that checks consistency between groups.json and compiled TAP test binaries: - WARNING (exit 0): tests in groups.json that aren't compiled yet - ERROR (exit 1): compiled tests missing from groups.json Scans test/tap/tests/, test/tap/tests/unit/, and test/tap/tests_with_deps/ for ELF binaries matching *-t pattern. Usage: python3 test/tap/groups/check_groups.py	3 months ago
Rene Cannao	fa668d646a	test: register 21 new unit tests in groups.json for CI Add all new unit test binaries to the CI test group configuration: - 13 core tests → unit-tests-g1 - 8 GenAI tests → ai-g1 This ensures CI pipelines discover and run all new tests.	3 months ago
Rene Cannao	ece648fc16	test: add 6 more unit test files with 550 assertions (Tier 2+3) Expand coverage for firewall whitelist, statistics, config validation, logging, and GenAI thread variable management. New test files (test/tap/tests/unit/): Core: - query_processor_firewall_unit-t (44 tests): load_firewall() users/rules/sqli fingerprints, find_firewall_whitelist_user/rule, whitelisted_sqli_fingerprint, reload/clear, memory accounting, PgSQL parity, multiple digest bsearch - statistics_unit-t (20 tests, 95 with TSDB): timer functions (timetoget for MySQL threads, query cache, CPU, logger, digest), TSDB set/get/has variable with range validation, insert/query metrics, backend health, downsampling, retention - config_validation_unit-t (54 tests): addField() formatting and escaping, validate_backend_users() duplicate detection for MySQL/PgSQL, validate_backend_servers() with field aliases and default ports, validate_proxysql_servers() - log_utils_unit-t (42 tests): LogBuffer append/write/operator<< overloads, data() accessor, reset(), should_log() rate limiting, GetLogBufferThreadContext() lifecycle GenAI/MCP (PROXYSQLGENAI=1): - genai_mcp_thread_unit-t (197 tests): MCP_Threads_Handler constructor defaults (26 vars), boolean/port/timeout/string variable set/get with range validation, has_variable, get_variables_list, null safety, target auth map - genai_thread_unit-t (193 tests): GenAI_Threads_Handler constructor defaults (31 vars), integer range validation for 15+ variables, double/boolean/string round-trips, has_variable, get_variables_list, overwrite and rejection persistence Note: found potential bug — llm_cache_enabled has no get/set handler despite being listed in variables array Minimal production change: - include/proxysql_config.h: add friend class for test access to private validate_backend_users/servers/proxysql_servers methods Running totals: 21 test files, 1268 assertions, all passing.	3 months ago
Rene Cannao	1d2f16b506	test: add 4 more unit test files with 198 assertions (Tier 1) Expand coverage for charset lookups, GenAI Query/LLM/MCP components. New test files (test/tap/tests/unit/): Core: - charset_find_unit-t (62 tests): all 4 proxysql_find_charset functions — edge cases for NULL returns, utf8mb3→utf8 translation, case-insensitive matching, collation preference GenAI/MCP (PROXYSQLGENAI=1): - genai_query_handler_unit-t (65 tests): validate_sql_identifier, escape_string_literal, strip_leading_comments, json_string/ json_int/json_double safe extraction, is_pgsql_protocol, is_runtime_online_status, uppercase_or_unknown - genai_llm_clients_unit-t (35 tests): is_retryable_error HTTP status codes (408/429/5xx) and CURL error codes, plus LLM_WriteCallback data accumulation - genai_mcp_endpoint_unit-t (36 tests): validate_bearer_token extraction/comparison, create_jsonrpc_response/error JSON-RPC 2.0 formatting Minimal production changes for testability: - include/Query_Tool_Handler.h: friend class + extern declarations for 8 pure helper functions - lib/Query_Tool_Handler.cpp: remove static from 8 file-local pure functions (no behavioral change) - include/MCP_Endpoint.h: friend class + new static validate_bearer_token() extracted from authenticate_request() - lib/MCP_Endpoint.cpp: extract token validation into static method - lib/LLM_Clients.cpp: remove static from is_retryable_error() and rename WriteCallback to LLM_WriteCallback (avoid collisions) Running totals: 15 test files, 718 assertions, all passing.	3 months ago

1 2 3 4 5 ...

9256 Commits (7e1a12b8f707d1f0d64c31eaf655bc3cee4e27df) All Branches Search

9256 Commits (7e1a12b8f707d1f0d64c31eaf655bc3cee4e27df)

All Branches