proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	8a6143c63c	session_track_variables: add observability for misconfiguration and runtime backoff Context ------- PR #5166 introduced a three-mode 'mysql-session_track_variables' variable (DISABLED / OPTIONAL / ENFORCED) whose behavior silently depends on two other MySQL capability toggles and on the capabilities of each backend: * In OPTIONAL mode the feature is a no-op when 'mysql-enable_server_deprecate_eof=false' or when the backend does not advertise CLIENT_DEPRECATE_EOF / CLIENT_SESSION_TRACKING. The operator sees the variable set to 1, but 'PROXYSQL INTERNAL SESSION' shows no tracked variables and there is no indication why. * In ENFORCED mode ProxySQL forces CLIENT_DEPRECATE_EOF on both the client and server sides of the protocol even if the operator explicitly set 'mysql-enable_client_deprecate_eof=false' / 'mysql-enable_server_deprecate_eof=false'. This is a protocol-visible behavior change for clients that did not negotiate CLIENT_DEPRECATE_EOF, and it was previously silent. * In ENFORCED mode backends that cannot honor tracking (missing CLIENT_SESSION_TRACKING or CLIENT_DEPRECATE_EOF) are placed in a 30-second selection backoff via 'MySrvC::session_track_backoff_until'. The server is NOT shunned and no connect-error counter is incremented, so in a mixed-version hostgroup an incompatible backend sits idle indefinitely with no log trail. Changes ------- * lib/Admin_FlushVariables.cpp: add a cross-variable validator at the tail of 'ProxySQL_Admin::flush_mysql_variables___database_to_runtime()', right next to the existing 'mysql-use_tcp_keepalive' warning. It runs once per 'LOAD MYSQL VARIABLES TO RUNTIME' and only when the feature is actually requested (mode != DISABLED). Emitted warnings: - ENFORCED + !enable_client_deprecate_eof -> "will force CLIENT_DEPRECATE_EOF on frontend connections; older clients may be affected" - ENFORCED + !enable_server_deprecate_eof -> equivalent for backends - OPTIONAL + !enable_server_deprecate_eof -> "has no effect while mysql-enable_server_deprecate_eof=false; backend session tracking will be skipped" The checks use the global 'GloMTH->get_variable_int()' view (same pattern as the TCP keepalive warning above it), and deliberately do not name any backend -- this is a global-configuration warning; per-backend capability mismatches are handled separately below. * lib/MySQL_Session.cpp: in 'handle_session_track_capabilities()', at the point where the code stores a new 'session_track_backoff_until' deadline for an incompatible backend, add a 'proxy_warning' naming the backend's address:port and the reason. Because this path only runs on new connection establishment -- and is itself gated by the 30-second backoff on the selection path -- the warning is naturally rate-limited to at most once per 30 seconds per backend. In a mixed fleet that rate is just enough for an operator to notice the incompatible server without drowning the log. Behaviour --------- * DISABLED mode (the default): no new log output; validator is skipped entirely. The hot selection path was already skipping the atomic read in the previous commit, so DISABLED remains free of new work. * OPTIONAL / ENFORCED: at most three warnings at 'LOAD MYSQL VARIABLES TO RUNTIME' time (cross-variable validator) plus one periodic warning per incompatible backend (ENFORCED path only). No per-query log output.	1 month ago
Rene Cannao	ac0f9304b0	fix: address code review findings for pgsql cluster sync 1. Remove dead declarations and implementations: PullOperationConfig, pull_from_peer_unified, fetch_query_with_metrics, compute__checksum, ScopedChar wrappers, and all safe_* memory helpers (-690 lines) 2. Document mutex sharing: pgsql pull functions intentionally reuse MySQL mutexes since pulls are sequential in the monitoring thread 3. Fix variable shadowing: rename local 'error' to 'exec_error' in Admin_Handler.cpp pgsql_servers_v2 fallback to avoid shadowing the outer error variable 4. Fix misleading debug message in process_component_checksum: the else branch fires when peer checksum is unchanged, not different 5. Fix indentation in ProxySQL_Admin.cpp (3 lines with double-tab) and Admin_FlushVariables.cpp (NULL-guard block with extra indent)	2 months ago
Rene Cannao	b60635f1c5	fix: address critical bugs and add missing test coverage for PGSQL cluster sync Critical bug fixes: - Add NULL check after execute_statement in flush_GENERIC_variables__checksum__database_to_runtime to prevent segfault when SQLite returns NULL resultset - Add NULL checks after mysql_store_result in all pgsql pull functions to prevent dereference of nullptr from OOM or protocol errors - Add proxy_error logging for double-NULL fallthrough in Admin_Handler pgsql query rules when both get_current_query_rules_inner() and get_current_query_rules() return NULL - Check execute_statement error output for pgsql_servers_v2 fallback query to detect schema corruption or disk failures instead of silently using empty results - Add NULL guards for MYSQL_ROW fields in update_pgsql_users to prevent atoll(NULL) undefined behavior on corrupted peer responses Test coverage additions: - Add check_pgsql_variables_sync: end-to-end test for pgsql variable propagation - Add check_diffs_before_sync_disabled: verify diffs_before_sync=0 prevents sync - Add SHUNNED and OFFLINE_SOFT server test cases to verify status handling - SHUNNED servers verified as mapped to ONLINE in runtime by cluster sync	2 months ago
Rene Cannao	47758a468d	merge: resolve groups.json conflict with v3.0 Take v3.0's groups.json as base (legacy-gN naming, mysql84-gN groups, new test entries) and add test_cluster_sync_pgsql-t from this branch. Drop duplicate pgsql_admin_metacmds-t (already exists as pgsql-admin_metacmds-t in v3.0).	2 months ago
Rene Cannao	6b9918fdcc	chore: refine guard structures and fix indentation - Fixed indentation for TSDB methods in include/proxysql_admin.h. - Refined PROXYSQLTSDB guard structure in lib/Admin_FlushVariables.cpp. - Cleaned up indentation and redundant code in lib/ProxySQL_RESTAPI_Server.cpp. - Ensured consistent formatting across modified files.	3 months ago
Rene Cannao	c2f678a9de	feat: implement release tiers and feature guards for v3.0, v3.1, and v4.0 This commit introduces a structured release tier system controlled by environment variables, allowing three distinct ProxySQL versions to be built from the same codebase while maintaining a clear upgrade path. Key Changes: - Tier 1 (v3.0.x Stable): Default build including bug fixes and core enhancements. - Tier 2 (v3.1.x Innovative): Enabled via PROXYSQL31=1. Adds FFTO and TSDB. - Tier 3 (v4.0.x AI/MCP): Enabled via PROXYSQLGENAI=1. Adds the AI stack. Implementation Details: - Makefile: Implemented dynamic versioning logic that increments the minor version for v3.1 and the major version for v4.0. Added tier documentation. - Feature Guards: Introduced PROXYSQLFFTO and PROXYSQLTSDB guards across ProxySQL_Admin, ProxySQL_Statistics, REST API, and HTTP server. - FFTO: Guarded Fast Forward Traffic Observer in MySQL and PgSQL sessions, including thread-local variables and configuration parameters. - TSDB: Guarded the entire Time Series Database subsystem, including SQLite table definitions, background loops, and REST API endpoints. - Build Fixes: * Fixed 'proxy_debug_func' linkage by adding extern "C" and moving the definition outside of DEBUG guards to ensure non-debug builds link correctly. * Corrected misplaced/nested DEBUG and PROXYSQLFFTO guards. * Verified build stability for all tiers (unset, PROXYSQL31=1, PROXYSQLGENAI=1).	3 months ago
Wazir Ahmed	5421a382ab	fix: Load TSDB variables from disk during startup - TSDB variables stored on disk were not being loaded into runtime during startup. Add the missing `flush_tsdb_variables___database_to_runtime()` and invoke it during init. - Inline the existing load/save wrappers in the header as thin delegations to the underlying flush functions Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	3 months ago
Wazir Ahmed	c05bc66655	fix: MCP variables overwritten due to incorrect flush logic `flush_mcp_variables___runtime_to_database()` ignores the `replace` parameter. The prepared statement is hardcoded to `REPLACE INTO`, so even when callers pass `replace=false` (e.g. `GenericRefreshStatistics`), the function overwrites values in memory config with stale runtime values. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	3 months ago
Rene Cannao	5c7e616f9b	PR5297: resolve remaining actionable review findings for PGSQL checksum sync and TAP assertions This commit addresses the review findings that are still reproducible on top of fix/postgresql-cluster-sync_2 after the v3.0 merge, while leaving already-resolved or no-longer-applicable reports untouched. Changes included: - Admin_FlushVariables: restore active PGSQL checksum generation path in flush_pgsql_variables___database_to_runtime(). - Remove the stale commented-out checksum block. - After releasing GloPTH write lock, compute runtime PGSQL vars snapshot and call flush_GENERIC_variables__checksum__database_to_runtime("pgsql", checksum, epoch) under checksum mutex, matching the mysql/admin pattern. - ProxySQL_Admin::set_variable(checksum_pgsql_variables): when disabling, reset all PGSQL *_diffs_before_sync thresholds (variables/query_rules/servers/users) in both admin variables and GloProxyCluster state, and update warning text accordingly. - TAP test hardening in test_cluster_sync_pgsql-t: - Ensure each checksum-loop failure path emits an explicit failing ok(false, ...) before continue, preventing TAP plan/accounting mismatches. - Simplify pgsql_servers_v2 test tuple shape by removing the unused int field and using the comment field consistently. Validation performed: - make -C lib -j4 (pass) - make -C test/tap/tests test_cluster_sync_pgsql-t -j4 (pass) Note: - The previously reported double wrunlock() in flush_pgsql_variables__from_memory_to_disk() is not present in current HEAD; function has a single wrlock/wrunlock pair.	3 months ago
Rene Cannao	6dbd0e9cb1	Merge branch 'v3.0' into fix/postgresql-cluster-sync_2 Resolve merge conflicts in: - lib/ProxySQL_Cluster.cpp - test/tap/tap/Makefile Conflict resolution details: - Kept PostgreSQL/MySQL cluster-sync updates from this branch (SQLQueries delete constants and pgsql sync flow changes) while adopting upstream SQLite prepare_v2 RAII usage where introduced in v3.0 conflict regions. - Combined TAP archive fixes from this branch (archive recreation via rm -f to prevent stale objects) with upstream v3.0 mcp_client.o additions to libtap archives. Validation performed after conflict resolution: - make -C test/tap/tap debug -j4 (success) - make -C lib -j4 (fails in current workspace due missing sqlite-vec.h/vec.o dependency in broader v3.0 content, not conflict markers) - make -C test/tap/tests admin-listen_on_unix-t -j4 (fails in current workspace due missing deps/sqlite3/sqlite3/vec.o, same dependency issue) No conflict markers remain.	3 months ago
Rene Cannao	9b5d52308f	fix: Use legacy prepare_v2 for conditional statement preparation Use the legacy db->prepare_v2(const char, sqlite3_stmt*) overload for the runtime_global_variables statement, which allows conditional preparation only when the runtime flag is set. Properly finalize the statement when done.	3 months ago
Rene Cannao	de60fe2b3f	fix: Use db->execute() for runtime_global_variables inserts Simplified the code to use db->execute() instead of prepared statements for runtime_global_variables inserts. This avoids complex unique_ptr deleter type matching issues and the table not existing during early initialization.	3 months ago
Rene Cannao	7479f2168e	fix: Only prepare runtime_global_variables stmt when runtime=true The runtime_global_variables table may not exist during early initialization, so we should only prepare the statement for it when the runtime flag is true. This fixes a crash on startup when init_mcp_variables() is called before the admin database schema is fully initialized.	3 months ago
Rene Cannao	8b1fb84d5c	fix: Populate runtime_global_variables for MCP variables The MCP variables were not being exposed in runtime_global_variables table after LOAD MCP VARIABLES TO RUNTIME. This fix: 1. Adds runtime_global_variables handling to flush_mcp_variables___runtime_to_database: - Clears existing mcp-* entries from runtime_global_variables when runtime=true - Inserts current runtime values into runtime_global_variables 2. Calls flush_mcp_variables___runtime_to_database with runtime=true from flush_mcp_variables___database_to_runtime to ensure the runtime table is populated after variables are loaded to runtime. This matches the behavior of other variable modules (admin, ldap, mysql, pgsql).	3 months ago
René Cannaò	762afaa44f	Merge branch 'v3.0' into v4.0-mcp-stats Signed-off-by: René Cannaò <rene@proxysql.com>	3 months ago
Rene Cannao	8fbd570c79	mcp variables: stop writing runtime_global_variables during LOAD MCP VARIABLES TO RUNTIME Issue: - MCP variable load path was writing rows into runtime_global_variables. - For MCP this is incorrect and misleading; runtime_global_variables should not be used as a write target in this flow. - Logs showed explicit INSERT statements into runtime_global_variables for mcp-* entries. Fix implemented: 1) Removed runtime_global_variables population from MCP database->runtime flow - In flush_mcp_variables___database_to_runtime(), removed the block that called: flush_mcp_variables___runtime_to_database(..., runtime=true, ...) - LOAD MCP VARIABLES TO RUNTIME now applies mcp-* variables to GloMCPH and reloads MCP server state, without runtime_global_variables writes. 2) Removed runtime_global_variables writes from MCP runtime->database helper - In flush_mcp_variables___runtime_to_database(): - removed DELETE FROM runtime_global_variables WHERE variable_name LIKE 'mcp-%' - removed INSERT INTO runtime_global_variables(...) per variable - Function now persists MCP variables only to global_variables (main/disk paths), which is the intended save behavior. 3) Removed temporary MCP info-level debug noise related to runtime_global_variables inserts - Deleted MCP info logs that printed per-variable INSERT SQL into runtime_global_variables. Build validation: - Recompiled successfully: - lib/obj/Admin_FlushVariables.oo Expected result after this commit: - Executing LOAD MCP VARIABLES TO RUNTIME should no longer emit any INSERT/DELETE against runtime_global_variables for mcp-* variables. - MCP runtime behavior remains: variables are applied in-memory and MCP server reload logic is triggered via load_mcp_server().	3 months ago
Rene Cannao	746eca9f7c	More sprintf to snprintf conversions and indentation fixes - Replace remaining sprintf with snprintf in Admin_FlushVariables.cpp - Fix indentation in flush_GENERIC_variables__process__database_to_runtime - Apply same pattern to ProxySQL_Admin.cpp and ProxySQL_Admin_Stats.cpp	3 months ago
Rene Cannao	3e37337877	Use RAII for sqlite3 statements across codebase - Convert prepare_v2() calls to use unique_ptr RAII pattern - Remove manual sqlite3_finalize calls (now handled by RAII) - Update flush_*_variables functions to use new prepare_v2 return pattern - Apply changes to Admin, Cluster, Monitor, Catalog, and other modules	3 months ago
Rene Cannao	335be9ec72	Fix unsafe sprintf and error message handling - Replace sprintf with snprintf in flush_*_variables functions - Add null value safety with safe_val in variable flushing - Fix error message to use send_error_msg_to_client instead of send_ok_msg_to_client	3 months ago
Rene Cannao	ba86be70a6	Fixed some bugs in PR 5358	3 months ago
Rene Cannao	4ae5bd852a	Revert "fix: prevent dangling pointer in flush_*_variables___runtime_to_database" This reverts commit `a20b2704f4`.	3 months ago
Wazir Ahmed	ae92ae265f	Merge branch 'v3.0' into v4.0-mcp-stats	3 months ago
Rene Cannao	a20b2704f4	fix: prevent dangling pointer in flush_*_variables___runtime_to_database Move statement2_unique to function scope to prevent use-after-free. The unique_ptr was declared inside the if (runtime) block but statement2 (raw pointer) was used in the loop outside that block, causing the statement to be finalized before use. Affected functions: - flush_variables___runtime_to_database (PgSQL variables) - flush_genai_variables___runtime_to_database (GenAI variables) - flush_mysql_variables___runtime_to_database (MySQL variables) Reported-by: CodeRabbit AI	3 months ago
Rene Cannao	2c8c27bf64	refactor: migrate prepare_v2 to RAII API in Admin_FlushVariables Migrate 4 functions from deprecated prepare_v2() to the new RAII-based API: - flush_pgsql_variables___runtime_to_database() - flush_genai_variables___runtime_to_database() - flush_mysql_variables___runtime_to_database() - flush_mcp_variables___runtime_to_database() All early returns happen before prepare_v2(), making these simple cases. Uses raw pointer aliases to avoid .get() verbosity. Pattern used: auto [rc, statement_unique] = db->prepare_v2(query); sqlite3_stmt *statement = statement_unique.get(); // ... use statement directly ... // No manual finalize - RAII handles it This addresses 4 of the ~150 deprecated prepare_v2 warnings.	4 months ago
Wazir Ahmed	643b322f29	MCP: Add stats endpoint and tools Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Rene Cannao	48bc7dd7bf	Merge v4.0 GenAI features into v3.0 with conditional compilation This commit merges the experimental v4.0 GenAI/MCP features into the stable v3.0 branch using conditional compilation. All v4.0 features are disabled by default and only enabled when PROXYSQLGENAI=1 is set at compile time. Changes: Build System: - Modified main Makefile to pass PROXYSQLGENAI flag to sub-makefiles - Modified deps/Makefile to conditionally build sqlite-vec and sqlite-rembed - Modified lib/Makefile to add PSQLGA flag and include GenAI object files - Modified src/Makefile to add PSQLGA flag and conditional linking Headers (wrapped with #ifdef PROXYSQLGENAI): - All 20 new GenAI header files in include/ - Modified cpp.h, proxysql_glovars.hpp, proxysql_admin.h - Modified ProxySQL_Admin_Tables_Definitions.h for GenAI/MCP tables Source Files: - All 22 new GenAI source files in lib/ wrapped with #ifdef PROXYSQLGENAI - Modified src/main.cpp for conditional global variables and init/shutdown - Modified Admin_Handler.cpp for conditional command handlers - Modified Admin_Bootstrap.cpp for conditional table registration - Modified Admin_FlushVariables.cpp for conditional variable flushing - Modified ProxySQL_Admin.cpp for conditional admin methods - Modified ProxySQL_Admin_Stats.cpp for conditional MCP stats functions - Modified proxy_sqlite3_symbols.cpp to always compile (needed by core) - Modified MySQL_Session.cpp for conditional GenAI function calls Test Files: - Renamed test_mcp_query_rules-t to test_mcp_query_rules-t.sh - Renamed test_mcp_rag_metrics-t to test_mcp_rag_metrics-t.sh - Modified anomaly_detection-t.cpp for conditional test execution Usage: # Build without GenAI (v3.0 mode - default) make clean && make build_deps -j$(nproc) && make build_lib -j$(nproc) && make build_src -j$(nproc) # Build with GenAI (v4.0 mode) make clean && PROXYSQLGENAI=1 make build_deps -j$(nproc) && PROXYSQLGENAI=1 make build_lib -j$(nproc) && PROXYSQLGENAI=1 make build_src -j$(nproc)	4 months ago
Wazir Ahmed	cecb975f66	fix: LOAD GENAI TO RUNTIME does not initialize the module Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Wazir Ahmed	50de536534	MCP: Fix crash during server restarts Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	4 months ago
Rahim Kanji	5b8bb1952e	Merge remote-tracking branch 'wqv3.1-vec' into v3.1_mcp-http-ssl-toggle	4 months ago
Rahim Kanji	9b66224df1	Fix critical double-free bug, SQL injection vulnerability, and hardcoded path This commit addresses three issues identified by code review: 1. CRITICAL: Fix double-free bug in MCP server restart logic - Remove manual handler deletions in Admin_FlushVariables.cpp - ProxySQL_MCP_Server destructor already properly cleans up all handlers - Previously caused crashes when toggling SSL mode or changing port - Simplified restart: delete server (destructor cleanup) → create new server - Verified with 10+ rapid SSL toggles without crashes 2. HIGH: Fix SQL injection vulnerability in catalog search - Rewrite MySQL_Catalog::search() to use prepared statements - Use parameter binding (proxy_sqlite3_bind_text/bind_int) for user input - Escape single quotes in FTS5 MATCH clause (doesn't support parameters) - Tested against multiple injection attempts (single quote, backslash, comments, UNION SELECT, kind/tags parameter injection) - All 21 catalog tests still pass with new implementation 3. MEDIUM: Fix hardcoded user-specific path in config - Revert datadir from user-specific absolute path to /var/lib/proxysql - Ensures portability across different environments Testing: - SSL toggle: 7 tests passed (HTTP↔HTTPS, port changes, stress test) - SQL injection: 10 tests passed (various injection attempts blocked) - Catalog functionality: 21 tests passed (FTS5, BM25 ranking, etc.) - Total: 38 tests passed, 0 failed Fixes issues identified in GitHub PR #16 review.	4 months ago
Rahim Kanji	ddc4e65706	Add plain HTTP support for MCP server and fix SSL/port restart issues * Add full support for both HTTP and HTTPS modes in MCP server via the mcp_use_ssl configuration variable, enabling plain HTTP for development and HTTPS for production with proper certificate validation * Server now automatically restarts when SSL mode or port configuration changes, fixing silent configuration failures where changes appeared to succeed but didn't take effect until manual restart. Features: - Explicit support for HTTP mode (mcp_use_ssl=false) without SSL certificates - Explicit support for HTTPS mode (mcp_use_ssl=true) with certificate validation - Configurable via configure_mcp.sh with --no-ssl or --use-ssl flags - Settable via admin interface: SET mcp-use_ssl=true/false - Automatic restart detection for SSL mode changes (HTTP ↔ HTTPS) - Automatic restart detection for port changes (mcp_port)	4 months ago
Rene Cannao	a3f0bade4e	feat: Convert NL2SQL to generic LLM bridge - Rename NL2SQL_Converter to LLM_Bridge for generic prompt processing - Update MySQL protocol handler from /* NL2SQL: / to / LLM: / - Remove SQL-specific fields (sql_query, confidence, tables_used) - Add GENAI_OP_LLM operation type to GenAI module - Rename all genai_nl2sql_ variables to genai_llm_* - Update AI_Features_Manager to use LLM_Bridge - Deprecate ai_nl2sql_convert MCP tool with error message - LLM bridge now handles any prompt type via MySQL protocol This enables generic LLM access (summarization, code generation, translation, analysis) while preserving infrastructure for future NL2SQL implementation via Web UI + external agents.	4 months ago
Rene Cannao	3fe8a48f70	Fix genai variable handling and add API key masking - Add has_variable() method to GenAI_Threads_Handler for variable validation - Add genai- prefix check in is_valid_global_variable() - Auto-initialize NL2SQL converter when genai-nl2sql_enabled is set to true at runtime - Make init_nl2sql() public to allow runtime initialization - Mask API keys in logs (show only first 2 chars, rest as 'x')	4 months ago
Rene Cannao	6ffb59b856	fix: Use db parameter instead of hardcoded admindb in GenAI database_to_runtime The flush_genai_variables___database_to_runtime() function was using hardcoded 'admindb' instead of the 'db' parameter passed to the function. This caused the function to always query from admindb, ignoring the actual database parameter. This fixes the issue where runtime_global_variables table was not being populated on startup because the query was always hitting the same database regardless of the parameter.	4 months ago
Rene Cannao	4018a0ad3b	fix: Follow MCP pattern for GenAI variables runtime table population Update flush_genai_variables___database_to_runtime() to match the MCP pattern exactly: - Add 'lock' parameter (default true) for flexibility - Use ProxySQL_Admin's wrlock()/wrunlock() instead of GloGATH's - Use consistent variable naming (var_name = name + 6 for 'genai-' prefix) - Follow exact same locking pattern as MCP variables This fixes the issue where runtime_global_variables table was not being populated on startup because the locking pattern was incorrect.	4 months ago
Rene Cannao	1ea67900ab	fix: Populate runtime_global_variables for GenAI variables on startup The flush_genai_variables___database_to_runtime() function was only setting internal state in GloGATH but not populating the runtime_global_variables table. This caused variables to appear in global_variables but not in runtime_global_variables after startup. Fix: Add call to flush_genai_variables___runtime_to_database() with runtime=true to populate the runtime table, following the same pattern used by MCP variables.	4 months ago
Rahim Kanji	01f08ea901	Fix a crash (SIGABRT) that occurred when reloading MCP variables while the MCP server was already running. The issue was caused by improper cleanup of handler objects during reinitialization. Root cause: - ProxySQL_MCP_Server destructor deletes mysql_tool_handler - The old code tried to delete handlers again after deleting the server, causing double-free corruption The fix properly handles handler lifecycle during reinitialization: 1. Delete Query_Tool_Handler first (server destructor doesn't clean this) 2. Delete the server (which also deletes MySQL_Tool_Handler via destructor) 3. Delete other handlers (config/admin/cache/observe) created by old server 4. Create new MySQL_Tool_Handler with updated configuration 5. Create new Query_Tool_Handler 6. Create new server (recreates all handlers with new endpoints) This ensures proper cleanup and prevents double-free issues while allowing runtime reconfiguration of MySQL connection parameters.	4 months ago
Rene Cannao	f9e3e85e68	fix: address all AI review concerns for PostgreSQL cluster sync - Fix critical Admin_FlushVariables bug where PostgreSQL SELECT appended to MySQL checksum query - Add security check for integer overflow in pgsql_variable_validate_integer - Fix test suite tuple indexing and NULL safety issues - Add missing admin variables for PostgreSQL replication hostgroups and attributes - Implement checksum_pgsql_variables get/set variable behavior - Fix misleading log messages for PostgreSQL disable operations - Fix cluster_pgsql_variables_diffs_before_sync gating logic - Add missing sync_delayed metrics for pgsql modules - Fix CLUSTER_QUERY_RUNTIME_PGSQL_SERVERS macro numeric vs VARCHAR comparison Resolves issues identified by coderabbitai and gemini-code-assist reviews in PR 5297.	4 months ago
René Cannaò	5154f9e4c4	Merge branch 'v3.0' into fix/postgresql-cluster-sync_2 Signed-off-by: René Cannaò <rene@proxysql.com>	4 months ago
René Cannaò	313f637cf0	Merge branch 'v3.1-vec' into v3.1-MCP1 Signed-off-by: René Cannaò <rene.cannao@gmail.com>	4 months ago
Rene Cannao	991f0138d8	Reinitialize MySQL Tool Handler when MCP variables change When LOAD MCP VARIABLES TO RUNTIME is called and the MCP server is already running, the MySQL Tool Handler is now recreated with the current configuration values. This allows changing MySQL connection parameters without restarting ProxySQL. The reinitialization: 1. Deletes the old MySQL Tool Handler 2. Creates a new one with current mcp-mysql_* values 3. Initializes the new handler 4. Logs success or failure	4 months ago
Rene Cannao	60d4a7378c	Implement automatic MCP server start/stop and add environment variable support - Add automatic MCP HTTPS server start/stop based on mcp-enabled flag - Server starts when mcp-enabled=true and LOAD MCP VARIABLES TO RUNTIME - Server stops when mcp-enabled=false and LOAD MCP VARIABLES TO RUNTIME - Validates SSL certificates before starting - Added to both flush_mcp_variables___database_to_runtime() and flush_mcp_variables___runtime_to_database() functions - Update configure_mcp.sh to respect environment variables - MYSQL_HOST, MYSQL_PORT, MYSQL_USER, MYSQL_PASSWORD - TEST_DB_NAME (mapped to MYSQL_DATABASE) - MCP_PORT - Updated --help documentation with all supported variables	4 months ago
Rene Cannao	5af4011c51	feat: add CLUSTER_SYNC_INTERFACES_PGSQL interface filtering Add PostgreSQL interface variable filtering to match existing MySQL patterns: - Define CLUSTER_SYNC_INTERFACES_PGSQL macro for 'pgsql-interfaces' variable - Add PostgreSQL filtering to Admin_FlushVariables.cpp checksum generation - Add PostgreSQL filtering to ProxySQL_Cluster.cpp sync operations - Follows established pattern of excluding interface variables when cluster_sync_interfaces=false This ensures that pgsql-interfaces variable is properly excluded from cluster synchronization when interface filtering is enabled, maintaining consistency with MySQL and admin modules.	4 months ago
Rene Cannao	5a85ef04f6	Fix MCP variables persistence and add DISK command support This commit fixes several issues with MCP (Model Context Protocol) variables not being properly persisted across storage layers and adds support for DISK commands. Changes: 1. lib/Admin_FlushVariables.cpp: - Fixed flush_mcp_variables___runtime_to_database() to properly insert variables into runtime_global_variables using db->execute() with formatted strings (matching admin pattern) - Fixed SQL format string to avoid double-prefix bug (qualified_name already contains "mcp-" prefix) - Fixed lock ordering by releasing outer wrlock before calling runtime_to_database with use_lock=true, then re-acquiring - Removed explicit BEGIN/COMMIT transactions to match admin pattern 2. lib/Admin_Handler.cpp: - Added MCP DISK command handlers that rewrite commands to SQL queries: * LOAD MCP VARIABLES FROM DISK -> INSERT OR REPLACE INTO main.global_variables * SAVE MCP VARIABLES TO DISK -> INSERT OR REPLACE INTO disk.global_variables * SAVE MCP VARIABLES FROM MEMORY/MEM -> INSERT OR REPLACE INTO disk.global_variables - Separated DISK command handlers from MEMORY/RUNTIME handlers 3. lib/ProxySQL_Admin.cpp: - Added flush_mcp_variables___runtime_to_database() call to stats section to ensure MCP variables are repopulated when runtime_global_variables is cleared and refreshed 4. tests/mcp_module-t.cpp: - Added verbose diagnostic output throughout tests - Added section headers and test numbers for clarity - Added variable value logging and error logging All 52 MCP module tests now pass.	4 months ago
Rene Cannao	b70b07ead7	Skip checksum generation for MCP until feature is complete The checksum generation caused an assert failure because the MCP module was not yet added to the checksums_values struct. For now, we skip checksum generation for MCP until the feature is complete and stable. Changes: - Removed flush_GENERIC_variables__checksum__database_to_runtime() call - Kept flush_mcp_variables___runtime_to_database() to populate runtime_global_variables - Added comment explaining checksum is skipped until MCP is complete This allows ProxySQL to start without crashing while MCP is under development.	4 months ago
Rene Cannao	2e7109d894	Fix lock ordering in flush_mcp_variables___database_to_runtime The crash was caused by incorrect lock ordering. The admin version has: 1. wrlock() (acquire admin lock) 2. Process variables 3. checksum_mutex lock() (acquire checksum lock) 4. flush to runtime + generate checksum 5. checksum_mutex unlock() (release checksum lock) 6. wrunlock() (release admin lock) The MCP version had the wrong order with the checksum_mutex lock outside the wrlock/wrunlock region. This also added the missing 'lock' parameter that exists in the admin version but was missing in MCP. Changes: - Added 'lock' parameter to flush_mcp_variables___database_to_runtime() - Added conditional wrlock()/wrunlock() calls (if lock=true) - Moved checksum generation inside the wrlock/wrunlock region - Updated function signature in header file	4 months ago
Rene Cannao	2874c9ad54	Fix flush_mcp_variables___database_to_runtime to populate runtime_global_variables The MCP module's flush_mcp_variables___database_to_runtime() was missing the logic to populate runtime_global_variables table. This caused the table to remain empty even though global_variables was correctly populated. Following the same pattern as admin variables (line 268), this commit adds: 1. Call to flush_mcp_variables___runtime_to_database(admindb, ..., true) to populate runtime_global_variables 2. Checksum generation for cluster sync After this fix, both global_variables and runtime_global_variables will contain MCP variables after ProxySQL startup.	4 months ago
Rene Cannao	87fff9e046	Add MCP (Model Context Protocol) module skeleton Add new MCP module supporting multiple MCP server endpoints over HTTPS with JSON-RPC 2.0 protocol skeleton. Each endpoint (/mcp/config, /mcp/observe, /mcp/query, /mcp/admin, /mcp/cache) is a distinct MCP server with its own authentication configuration. Features: - HTTPS server using existing ProxySQL TLS certificates - JSON-RPC 2.0 skeleton implementation (actual protocol TBD) - 5 MCP endpoints with per-endpoint auth configuration - LOAD/SAVE MCP VARIABLES admin commands - Configuration file support (mcp_variables section) Implementation follows GenAI module pattern: - MCP_Threads_Handler: Main module handler with variable management - ProxySQL_MCP_Server: HTTPS server wrapper using libhttpserver - MCP_JSONRPC_Resource: Base endpoint class with JSON-RPC skeleton	4 months ago
Rene Cannao	c476f56f97	Add initial GenAI module placeholder Implement a new GenAI module for ProxySQL with basic infrastructure: - GenAI_Threads_Handler class for managing GenAI module configuration - Support for genai- prefixed variables in global_variables table - Dummy variables: genai-var1 (string) and genai-var2 (integer) - Config file support via genai_variables section - Flush functions for runtime_to_database and database_to_runtime - Module lifecycle: initialization at startup, graceful shutdown - LOAD/SAVE GENAI VARIABLES admin command infrastructure Core functionality verified: - Config file loading works - Variables persist in global_variables table - Disk save/load via SQL works - Module initializes and shuts down properly Related files: - include/GenAI_Thread.h: New GenAI thread handler class - lib/GenAI_Thread.cpp: Implementation with dummy variables - lib/Admin_Handler.cpp: Added GENAI command vectors and handlers - lib/Admin_FlushVariables.cpp: Added genai flush functions - lib/ProxySQL_Admin.cpp: Added init_genai_variables() and load_save_disk_commands entry - include/proxysql_admin.h: Added function declarations - lib/Makefile: Added GenAI_Thread.oo to build - src/main.cpp: Added module initialization and cleanup - src/proxysql.cfg: Added genai_variables configuration section	5 months ago
Rene Cannao	6ed82ef8cb	Fix crash in TCP keepalive warnings for issue #5212 - Fix crash by using get_variable_int() instead of get_variable_string() for boolean use_tcp_keepalive variable - use_tcp_keepalive is a boolean variable, not a string, so get_variable_int() returns 0/1 instead of a string - Fix syntax errors by removing duplicate code and fixing brace structure - Add comprehensive Doxygen documentation for both MySQL and PostgreSQL warnings Resolves assertion failure: "Not existing variable: use_tcp_keepalive" Resolves: #5212	6 months ago

1 2

59 Commits (6d8dff293973edd1be9cc67be03aac400e85cb4c)