mirror of https://github.com/sysown/proxysql
Fix crash in TCP keepalive warnings for issue #5212
- Fix crash by using get_variable_int() instead of get_variable_string() for boolean use_tcp_keepalive variable - use_tcp_keepalive is a boolean variable, not a string, so get_variable_int() returns 0/1 instead of a string - Fix syntax errors by removing duplicate code and fixing brace structure - Add comprehensive Doxygen documentation for both MySQL and PostgreSQL warnings Resolves assertion failure: "Not existing variable: use_tcp_keepalive" Resolves: #5212pull/5228/head
Rene Cannao
5 months ago
parent
cf454b8ef2
commit
6ed82ef8cb
@ -0,0 +1,129 @@
|
||||
#include <stdio.h>
|
||||
#include <stdlib.h>
|
||||
#include <string.h>
|
||||
#include <unistd.h>
|
||||
|
||||
#include <iostream>
|
||||
#include <fstream>
|
||||
#include <regex>
|
||||
|
||||
#include "mysql.h"
|
||||
#include "tap.h"
|
||||
#include "command_line.h"
|
||||
#include "utils.h"
|
||||
|
||||
using namespace std;
|
||||
|
||||
int main(int argc, char** argv) {
|
||||
CommandLine cl;
|
||||
|
||||
// Plan for 4 tests
|
||||
plan(4);
|
||||
|
||||
// Get connections
|
||||
MYSQL* admin = mysql_init(NULL);
|
||||
if (!admin) {
|
||||
diag("Failed to initialize admin connection");
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
if (!mysql_real_connect(admin, cl.host, cl.admin_username, cl.admin_password, NULL, cl.admin_port, NULL, 0)) {
|
||||
diag("Failed to connect to ProxySQL admin: %s", mysql_error(admin));
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
// Get the log file path
|
||||
const string log_path { get_env("REGULAR_INFRA_DATADIR") + "/proxysql.log" };
|
||||
|
||||
// Test 1: MySQL TCP keepalive warning
|
||||
diag("Testing MySQL TCP keepalive warning when set to false");
|
||||
{
|
||||
fstream logfile {};
|
||||
int open_err = open_file_and_seek_end(log_path, logfile);
|
||||
if (open_err != EXIT_SUCCESS) {
|
||||
diag("Failed to open log file: %s", log_path.c_str());
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
// Set MySQL TCP keepalive to false
|
||||
int query_err = mysql_query(admin, "SET mysql-use_tcp_keepalive='false'");
|
||||
ok(query_err == 0, "SET mysql-use_tcp_keepalive='false' should succeed");
|
||||
if (query_err != 0) {
|
||||
diag("Error setting mysql-use_tcp_keepalive: %s", mysql_error(admin));
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
// Load MySQL variables to runtime to trigger warning
|
||||
query_err = mysql_query(admin, "LOAD MYSQL VARIABLES TO RUNTIME");
|
||||
ok(query_err == 0, "LOAD MYSQL VARIABLES TO RUNTIME should succeed");
|
||||
if (query_err != 0) {
|
||||
diag("Error loading MySQL variables: %s", mysql_error(admin));
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
// Wait a bit for the warning to be written to log
|
||||
usleep(100000); // 100ms
|
||||
|
||||
// Check for the warning in the log
|
||||
const string warning_regex { ".*\\[WARNING\\].*mysql-use_tcp_keepalive is set to false.*" };
|
||||
const auto& [match_count, warning_lines] = get_matching_lines(logfile, warning_regex, true);
|
||||
|
||||
ok(match_count > 0, "MySQL TCP keepalive warning should appear in log when set to false");
|
||||
if (match_count == 0) {
|
||||
diag("Expected warning not found in log file");
|
||||
} else {
|
||||
diag("Found MySQL TCP keepalive warning in log: %s", std::get<LINE>(warning_lines[0]).c_str());
|
||||
}
|
||||
}
|
||||
|
||||
// Test 2: PostgreSQL TCP keepalive warning
|
||||
diag("Testing PostgreSQL TCP keepalive warning when set to false");
|
||||
{
|
||||
fstream logfile {};
|
||||
int open_err = open_file_and_seek_end(log_path, logfile);
|
||||
if (open_err != EXIT_SUCCESS) {
|
||||
diag("Failed to open log file: %s", log_path.c_str());
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
// Set PostgreSQL TCP keepalive to false
|
||||
int query_err = mysql_query(admin, "SET pgsql-use_tcp_keepalive='false'");
|
||||
ok(query_err == 0, "SET pgsql-use_tcp_keepalive='false' should succeed");
|
||||
if (query_err != 0) {
|
||||
diag("Error setting pgsql-use_tcp_keepalive: %s", mysql_error(admin));
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
// Load PgSQL variables to runtime to trigger warning
|
||||
query_err = mysql_query(admin, "LOAD PGSQL VARIABLES TO RUNTIME");
|
||||
ok(query_err == 0, "LOAD PGSQL VARIABLES TO RUNTIME should succeed");
|
||||
if (query_err != 0) {
|
||||
diag("Error loading PgSQL variables: %s", mysql_error(admin));
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
|
||||
// Wait a bit for the warning to be written to log
|
||||
usleep(100000); // 100ms
|
||||
|
||||
// Check for the warning in the log
|
||||
const string warning_regex { ".*\\[WARNING\\].*pgsql-use_tcp_keepalive is set to false.*" };
|
||||
const auto& [match_count, warning_lines] = get_matching_lines(logfile, warning_regex, true);
|
||||
|
||||
ok(match_count > 0, "PostgreSQL TCP keepalive warning should appear in log when set to false");
|
||||
if (match_count == 0) {
|
||||
diag("Expected warning not found in log file");
|
||||
} else {
|
||||
diag("Found PostgreSQL TCP keepalive warning in log: %s", std::get<LINE>(warning_lines[0]).c_str());
|
||||
}
|
||||
}
|
||||
|
||||
mysql_close(admin);
|
||||
return exit_status();
|
||||
}
|
||||
Loading…
Reference in new issue