proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	667f0f0f2d	Address review feedback on transaction state tests (PR #5510 ) - Docstring: specify microsecond units for timestamps, clarify max_transaction_time_ms accepts 0 or negative as disabled - Docstring: replace stale line number references with function name (handler_rc0_Process_Resultset) - Add test: locked HG stays unchanged when current_hostgroup differs during active transaction - Add test: boundary case where elapsed == limit → NOT timed out (strict > comparison) - Plan updated from 17 to 19	1 month ago
René Cannaò	3ed5e889c8	Address review feedback on hostgroup routing tests (PR #5509 ) - Add test for transaction+lock HG mismatch (txn on HG 3 but locked on HG 5 → error), as suggested by reviewer - Fix trailing "... fix" comment in test count - Plan updated from 20 to 21	1 month ago
René Cannaò	8d12befb5f	Add transaction state unit tests + pattern rule (Phase 3.8, #5496 ) 17 test cases: persistence disabled, txn start/end, no-change cases, full lifecycle (BEGIN→query→COMMIT), timeout exceeded/not/disabled. Also replaces individual Makefile rules with pattern rule.	1 month ago
René Cannaò	3f0281651e	Extract transaction state tracking logic (Phase 3.8, #5496 ) New files: - include/TransactionState.h: 2 pure function declarations - lib/TransactionState.cpp: implementations Functions: - update_transaction_persistent_hostgroup(): mirrors session logic for locking/unlocking HG on transaction start/end - is_transaction_timed_out(): checks if transaction exceeded max time Logic identical for MySQL and PgSQL (shared via Base_Session).	1 month ago
René Cannaò	98249bcd5a	Add hostgroup routing unit tests + Makefile pattern rule (Phase 3.5, #5493 ) 20 test cases: basic routing, transaction affinity, lock acquire/enforce, locking disabled, transaction+lock interaction, edge cases. Also replaces all individual unit test build rules with a single pattern rule (%-t: %-t.cpp) — adding new tests now only requires appending the name to UNIT_TESTS.	1 month ago
René Cannaò	aaa02bb400	Extract hostgroup routing decision logic (Phase 3.5, #5493 ) New files: - include/HostgroupRouting.h: HostgroupRoutingDecision struct + resolve_hostgroup_routing() declaration - lib/HostgroupRouting.cpp: implementation mirroring the routing block in get_pkts_from_client() (~lines 5340-5377) Logic covers: QP destination override, transaction affinity, hostgroup lock acquisition/enforcement, error on HG mismatch. Identical for both MySQL and PgSQL protocols.	1 month ago
René Cannaò	586fb734f8	Move git workflow to top of task template — agents skip buried instructions Learned from agent post-mortem: agents prioritize technical content over administrative instructions. Even when branch info is present, agents skim past it while focusing on code requirements, then use heuristics to fill the gap they don't realize they have. Fix: git workflow is now the FIRST section with "do this before reading anything else" label. Also updates common-mistakes.md with the expanded root cause analysis.	1 month ago
Rene Cannao	c3004c1039	Fix code coverage collection for ProxySQL core code Two fixes required: 1. Mount gcov directory in test runner container so it can access the .gcda files written by ProxySQL 2. Call 'PROXYSQL GCOV DUMP' after each TAP test to flush coverage counters from memory to disk Without these fixes, coverage data was never flushed from the running ProxySQL process, resulting in 0% coverage for ProxySQL core files.	1 month ago
René Cannaò	7e49c41975	Address review feedback on server selection (PR #5508 ) - Fix truncation: use uint64_t modulo instead of unsigned int cast when computing target from total_weight (prevents skewed selection when total_weight > UINT_MAX) - Remove unused #include <cstdlib> - Add docstring note about max_latency_us=0 semantics: in production this means "use thread default", this extraction treats it as "no limit" — callers should resolve defaults before populating the struct - Remove trailing "fix" comment from test	1 month ago
René Cannaò	7697d4f43e	Add server selection unit tests (Phase 3.4, #5492 ) 21 test cases covering: - Eligibility: all 5 status types, max_connections, latency, repl lag, disabled limits (max=0) - Selection: single server, empty list, all offline, weight=0 - Weighted distribution: equal weights → ~50/50, 3:1 → ~75/25 (statistical verification over 10000 iterations) - Determinism: same seed produces same result - Mixed eligibility: only eligible server selected 100% of the time	1 month ago
René Cannaò	dba1294585	Extract server selection algorithm into pure functions (Phase 3.4, #5492 ) New files: - include/ServerSelection.h: ServerCandidate struct (lightweight, no MySrvC dependency) + is_candidate_eligible() + select_server_from_candidates() - lib/ServerSelection.cpp: implementations ServerCandidate decouples selection logic from connection pool: contains only weight, status, connections, latency, and replication lag — no MySQL_Connection pointers or pool objects. Selection algorithm: 1. Filter candidates by eligibility (ONLINE, below max_connections, within latency/lag thresholds) 2. Weighted random selection using seeded LCG (deterministic for testing, avoids polluting global srand() state) Uses its own ServerSelectionStatus enum to avoid pulling in proxysql_structs.h and its entire dependency chain.	1 month ago
Rene Cannao	a1042ce13f	Fix code coverage collection: mount gcov directory in test runner The test runner container needs access to the /gcov directory where ProxySQL writes its coverage data (.gcda files). Without this mount, the coverage collection script could only see .gcno files (compile-time) but not the runtime coverage data from ProxySQL. This fix adds the gcov volume mount to the test runner container, allowing it to merge coverage data from each ProxySQL instance.	1 month ago
René Cannaò	f7f93e3973	Merge pull request #5507 from sysown/v3.0-5491 Phase 3.3: Monitor health state decision extraction + unit tests	1 month ago
René Cannaò	99980ca196	Address review feedback on monitor health (PR #5507 ) - Fix integer overflow: cast shun_recovery_time_sec to int64_t before multiplying by 1000 to prevent overflow for large values (>24 days) - Add docstring note about production lag==-2 override path (issue #959) not covered by this simplified extraction - Remove trailing "fix plan" comment from test	1 month ago
Rene Cannao	60e1d03442	Fix admin connection and authentication in TAP tests Address PR #5470 review feedback: - max_connections_ff-t: Use cl.admin_host for admin connection - test_query_rules_routing-t: Use cl.admin_host for admin connection - test_tsdb_api-t: Use stats:stats credentials for web dashboard, admin credentials for REST API (they use separate auth)	1 month ago
René Cannaò	24db561c09	Add monitor health unit tests (Phase 3.3, #5491 ) 31 test cases covering all monitor health decision branches: - Connect error shunning: threshold computation, boundary values - Unshun recovery: time elapsed, timeout cap, kill_all drain check, recovery disabled, clock skew, min 1s floor - Replication lag shunning: threshold, consecutive count, disabled, unknown lag, boundary - Replication lag recovery: below/at/above threshold, unknown lag	1 month ago
René Cannaò	59654e48a3	Extract monitor health decision logic into pure functions (Phase 3.3, #5491 ) New files: - include/MonitorHealthDecision.h: declarations for 4 pure functions - lib/MonitorHealthDecision.cpp: implementations Extracted functions: - should_shun_on_connect_errors(): mirrors MySrvC::connect_error() threshold logic (min(shun_on_failures, connect_retries+1)) - can_unshun_server(): mirrors MyHGC recovery loop with time check, connect_timeout_max cap, min 1s floor, and kill_all drain check - should_shun_on_replication_lag(): mirrors MySQL_HostGroups_Manager lag check with consecutive count threshold - can_recover_from_replication_lag(): mirrors lag recovery check All functions are pure (no global state, no I/O) and added to libproxysql.a via lib/Makefile.	1 month ago
Rene Cannao	be290c5aeb	Address PR review feedback on test infrastructure - Remove redundant host-side coverage collection in run-tests-isolated.bash (coverage is already collected via trap inside the container) - Initialize TAP_GROUP, group_has_tests, groups before try block in proxysql-tester.py to avoid UnboundLocalError on early exceptions - Differentiate skipped tests from missing tests in TAP_GROUP validation so intentionally skipped tests don't count as missing	1 month ago
René Cannaò	b0889e1313	Merge pull request #5506 from sysown/v3.0-5478 HostGroups Manager unit tests (Phase 2.6)	1 month ago
René Cannaò	1549370053	Address review feedback on hostgroups unit tests (PR #5506 ) - test_init.h: remove duplicate test_cleanup_query_processor() declaration (copy-paste artifact at line 130) - test_init.cpp: check MyHGM and PgHGM independently instead of using OR guard, so one can't be left null while the other exists	1 month ago
René Cannaò	e4972ac739	Fix hostgroups_unit-t hang: do not call MyHGM->init() MySQL_HostGroups_Manager::init() starts two background threads (HGCU_thread and GTID_syncer_thread) that run forever in a blocking loop. The destructor does not call shutdown() to stop them, so the test process hangs indefinitely after main() returns — std::thread destructor calls std::terminate() on joinable threads. Fix: skip init() entirely. The constructor alone sets up the internal SQLite3 database and all data structures needed for unit testing. The background threads are only needed for real connection pool management (connection reuse, GTID sync), not for server add/remove/ shun operations.	1 month ago
René Cannaò	f772c104de	Add HostGroups Manager unit tests (Phase 2.6, #5478 ) Unit tests for MySQL_HostGroups_Manager and PgSQL_HostGroups_Manager covering 17 test cases. Runs in <0.01s with no infrastructure deps. Test coverage: - Server creation via create_new_server_in_hg() (single, multiple in same HG, different HGs) - Server removal via remove_server_in_hg() (existing, non-existent) - shun_and_killall() (existing server returns true, non-existent false) - set_server_current_latency_us() (latency tracking without crash) - Multiple hostgroups independence (shunning in one HG doesn't affect another) - Duplicate server handling - PgSQL: create, remove, and shun operations with PgSQL-specific types (PgSQL_srv_info_t, PgSQL_srv_opts_t) Infrastructure: - New test_init_hostgroups() / test_cleanup_hostgroups() helpers in test_init.h/.cpp - Creates real MySQL_HostGroups_Manager and PgSQL_HostGroups_Manager with internal SQLite3 databases - Requires Prometheus registry (auto-created if nullptr) Note: Methods like shun_and_killall() and set_server_current_latency_us() acquire their own write locks internally — callers must NOT hold the lock beforehand or a deadlock occurs.	1 month ago
René Cannaò	c54e6e1805	Expand task assignment template with learnings from CodeRabbit plans Adds four new checklist items based on analyzing CodeRabbit's auto- generated plans for issues #5491 and #5492: - #9: Write ready-made prompts for executing agents — pre-digest the task into imperative, sequential, agent-optimized format - #10: Document design decisions with rationale — prevent agents from re-litigating settled architecture choices - #11: Show the research — make codebase analysis visible for verification and context transfer - #12: For refactoring tasks, specify what to replace — exact line ranges, replacement calls, include dependencies Also adds two new entries to the common mistakes table: - "Recreates existing infrastructure" (research contradicts plan) - "Uses wrong infrastructure" (multiple similar patterns exist) Updates the good-vs-bad example to demonstrate the new items.	1 month ago
René Cannaò	bf250c6307	Add agent guidelines documentation Adds doc/agents/ with three guidance documents for AI coding agents, based on lessons learned from Milestone 2-3 unit testing work: - project-conventions.md: ProxySQL-specific rules — directory layout, build system, unit test harness usage, header conventions, circular include dependency warnings, git workflow, dual-protocol coverage - task-assignment-template.md: Generic template and orchestrator checklist for writing GitHub issues that agents can execute correctly. Covers: specifying WHERE/HOW/environment, DO NOT lists, binary acceptance criteria, and the good-vs-bad issue example - common-mistakes.md: Catalog of 9 observed failure patterns with root cause analysis, prevention strategies, and shell commands for detection in agent PRs Also updates CLAUDE.md with a reference to the agent guidelines and a note about the unit test harness.	1 month ago
René Cannaò	c0ab3bd1df	Merge pull request #5503 from sysown/v3.0-5490 Phase 3.2: Query rule matching extraction + unit tests	1 month ago
René Cannaò	666eb4a75c	Address review feedback on rule matching unit tests (PR #5503 ) - Add test case for null session username: verifies that a rule with a username filter correctly rejects when session username is nullptr (+1 test, plan updated to 23)	1 month ago
René Cannaò	aae1ad4019	Fix rule matching extraction: proper unit tests with harness Fixes the Copilot-generated PR #5501 test file: - Remove misplaced test from test/tap/tests/ (wouldn't link against libproxysql.a with the default TAP build rules) - Add proper unit test at test/tap/tests/unit/rule_matching_unit-t.cpp using the test harness (test_globals.h, test_init.h) - 22 test cases covering all matching criteria: flagIN, username, schemaname, client_addr wildcard, proxy_addr/port, digest, match_digest (RE2 + PCRE), match_pattern, negate_match_pattern, CASELESS modifier, rewritten query, combined AND logic, null rule - Register in unit test Makefile Production code (rule_matches_query extraction) cherry-picked from Copilot's original commit — no changes to the extraction itself.	1 month ago
copilot-swe-agent[bot]	0477a5b355	test: fix wildcard prefix setup Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/15475838-0841-46d6-9afd-ebdc5847a3ae	1 month ago
copilot-swe-agent[bot]	54a2af325f	refactor: extract query rule matching helper Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/15475838-0841-46d6-9afd-ebdc5847a3ae	1 month ago
René Cannaò	60a7718584	Merge pull request #5502 from sysown/v3.0-5489 Phase 3.1: Connection pool decision extraction + unit tests	1 month ago
René Cannaò	7a0026fc03	Address review feedback on connection pool unit tests (PR #5502 ) - ConnectionPoolDecision.h: expand docstring for calculate_eviction_count to clarify max_connections=0 edge case behavior - connection_pool_unit-t.cpp: check test_init_minimal() return code instead of ignoring it (+1 test, plan updated to 23)	1 month ago
René Cannaò	37ce0525bb	Fix connection pool extraction: separate header, proper unit tests Fixes the Copilot-generated PR #5500 production code and test file: Production fixes: - Create standalone ConnectionPoolDecision.h header with the struct and function declarations (no circular dependency issues) - Include ConnectionPoolDecision.h in MySrvConnList.cpp and PgSQL_HostGroups_Manager.cpp to resolve compilation errors - Replace inline declarations in Base_HostGroups_Manager.h with #include "ConnectionPoolDecision.h" Test fixes: - Remove misplaced test from test/tap/tests/ (tested reimplemented copies of functions instead of the real code) - Add proper unit test at test/tap/tests/unit/connection_pool_unit-t.cpp using the test harness (test_globals.h, test_init.h) - 22 test cases covering eviction, throttling, pool state decisions, warming, and edge cases - Register in unit test Makefile	1 month ago
copilot-swe-agent[bot]	5e8b1e3e5a	Extract connection pool decision logic into pure functions (MySQL + PgSQL) Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/89d35f54-3313-48d4-8252-70e3c1f3b036	1 month ago
René Cannaò	f3b9eda296	Merge pull request #5485 from sysown/v3.0-5474 MySQL/PgSQL Authentication unit tests (Phase 2.2)	1 month ago
René Cannaò	051435f810	Address review feedback on auth unit tests (PR #5485 ) - Add null guards before strcmp() in test_mysql_add_overwrites and test_mysql_frontend_backend_separation to prevent segfaults on unexpected lookup failures - Fix misleading "skipped - null" message in SHA1 test fallback to clearly indicate an unexpected null - Free sha1 pointer in PgSQL lookup test to prevent potential memory leak if sha1_pass is ever set - Enhance test_mysql_clear_text_password to verify stored PRIMARY and ADDITIONAL passwords are actually retrievable via lookup(), not just that set_clear_text_password() returns true (2 new test cases, plan updated from 58 to 60)	1 month ago
René Cannaò	a968b049a2	Add auth_unit-t to unit test Makefile Registers the Authentication unit test binary in the build system so it is built alongside smoke_test-t via 'make build_tap_tests'.	1 month ago
René Cannaò	2e52deffd4	Add MySQL/PgSQL Authentication unit tests (Phase 2.2, #5474 ) Comprehensive unit tests for MySQL_Authentication and PgSQL_Authentication covering 58 test cases across 13 test functions. Runs in <0.01s with no infrastructure dependencies. MySQL_Authentication coverage: - Core CRUD: add/exists/lookup/del with frontend and backend users - Duplicate handling: add() overwrites password, hostgroup, max_connections - exists() only checks frontends (not backends) — documented quirk - lookup() returns empty struct for nonexistent users - SHA1 credential storage and retrieval via set_SHA1() - Clear-text password management (PRIMARY and ADDITIONAL slots) - Connection counting: increase/decrease with max_connections enforcement - Bulk operations: set_all_inactive + remove_inactives config reload pattern - reset() clears all frontend and backend users - Runtime checksum: zero when empty, changes on add/modify - Memory tracking: increases on add, returns to baseline on reset - Frontend/backend separation: same username, different credentials PgSQL_Authentication coverage: - Core CRUD with PgSQL-specific lookup() signature (returns char*) - del() and reset() behavior - Connection counting (no PASSWORD_TYPE parameter) - Inactive pattern (set_all_inactive + remove_inactives)	1 month ago
René Cannaò	87e3280abb	Merge pull request #5488 from sysown/v3.0-5477 Protocol encoding/decoding and utility unit tests (Phase 2.5)	1 month ago
René Cannaò	045ff26068	Address review feedback on protocol unit tests (PR #5488 ) - test_decode_length_3byte: pad buffer to 5 bytes (CPY3 reads 4 bytes via uint32_t* cast from buf+1, causing OOB read with 4-byte buffer) - test_cpy3: use 4-byte buffers with padding to avoid OOB read - test_encode_decode_roundtrip: initialize prefix[0]=0 each iteration to avoid UB when mysql_encode_length doesn't write for 1-byte values - test_mysql_query_digest: free first_comment between calls to prevent memory leak (malloc'd by digest function when comment present) - test_pgsql_query_digest: use strlen() instead of hardcoded q_len to avoid off-by-one, free first_comment after use - test_escape_single_quotes: fix misleading comment — function returns original pointer (not copy) when no quotes are present	1 month ago
René Cannaò	e6e8590209	Add protocol_unit-t to unit test Makefile	1 month ago
René Cannaò	a7424f0abe	Add protocol encoding/decoding and utility unit tests (Phase 2.5, #5477 ) Unit tests for standalone protocol functions and utility routines covering 43 test cases across 11 test functions. Runs in <0.01s with no infrastructure dependencies. Test coverage: - MySQL length-encoded integer decoding: 1-byte (0-250), 2-byte (0xFC prefix), 3-byte (0xFD prefix), 8-byte (0xFE prefix) - MySQL length-encoded integer encoding: boundary values at each encoding tier (251, 65535, 65536, 16777216) - Encode/decode roundtrip: 10 values across all encoding ranges survive write_encoded_length() → mysql_decode_length_ll() - mysql_hdr packet header: structure size (4 bytes), field packing, 24-bit max length - CPY3/CPY8 byte copy helpers: little-endian semantics, boundary values - MySQL query digest: normalization via mysql_query_digest_and_first_ comment_2(), whitespace collapsing, comment handling, empty query - PgSQL query digest: normalization via pgsql_query_digest_and_first_ comment_2(), whitespace collapsing - escape_string_single_quotes: no-op on clean strings, single quote doubling, multiple quotes - mywildcmp wildcard matching: exact match, % prefix/suffix/both, _ single char, non-match cases, empty string edge cases	1 month ago
René Cannaò	89016046a6	Merge pull request #5487 from sysown/v3.0-5476 Query Processor rule management unit tests (Phase 2.4)	1 month ago
René Cannaò	b25cf6d54f	Address review feedback on query processor unit tests (PR #5487 ) - test_mysql_reset_all: remove 2 leaked mysql_simple_rule() calls whose return values were discarded (memory leak under ASAN) - test_mysql_rule_creation: fix misleading "Don't free" comment — rule is NOT inserted into QP and IS freed manually - test_init.cpp: free individual strings from get_variables_list() before freeing the array (was leaking all variable name strings) - test_init.cpp: fix misleading comment claiming GloMTH/GloPTH are cleaned up by test_cleanup_minimal() — they rely on process exit	1 month ago
René Cannaò	c57bd36e98	Add query_processor_unit-t to build and fix QP initialization - tests/unit/Makefile: Register query_processor_unit-t in build system - test_init.cpp: Create MySQL_Threads_Handler and PgSQL_Threads_Handler in test_init_query_processor() since QP constructors read variables from GloMTH/GloPTH. Trigger lazy initialization of VariablesPointers maps via get_variables_list() before constructing QP instances. Add extern declaration for GloPTH (not declared in any header).	1 month ago
René Cannaò	76f1f2f5cd	Add Query Processor rule management unit tests (Phase 2.4, #5476 ) Comprehensive unit tests for MySQL_Query_Processor and PgSQL_Query_ Processor covering 42 test cases across 10 test functions. Runs in <0.01s with no infrastructure dependencies. Test coverage: - Rule creation via new_query_rule() with all 35 fields verified - Rule field storage: username, schemaname, match_digest, match_pattern, destination_hostgroup, cache_ttl, timeout, retries, sticky_conn, multiplex, apply, log, client_addr, comment - Regex modifier parsing: CASELESS, GLOBAL, combined (CASELESS,GLOBAL) - Rule insertion, sorting by rule_id, and commit - Rule retrieval via get_current_query_rules() SQLite3 result - Sort verification: rules inserted in reverse order, sorted ascending - Special fields: error_msg, OK_msg, replace_pattern - flagIN/flagOUT chaining setup - Username filter rules - reset_all() clears all rules - get_stats_commands_counters() returns valid result - PgSQL rule creation, insertion, and reset Note: Full process_query() testing requires a MySQL_Session with populated connection data, which is beyond isolated unit tests. The existing E2E TAP tests cover those scenarios.	1 month ago
René Cannaò	17f9a0fb21	Merge pull request #5486 from sysown/v3.0-5475 Query Cache unit tests (Phase 2.3)	1 month ago
René Cannaò	bcba8039cd	Address review feedback on query cache unit tests (PR #5486 ) - test_pgsql_flush: flush() at start for clean state, assert == 10 - test_mysql_construction_and_flush: fix tautology (flushed == 0 \|\| flushed >= 0 is always true for uint64_t), double-flush to ensure empty cache, then assert == 0 - test_pgsql_purge_expired: use max_memory_size=1 instead of 1GB to force the purge path to actually run (3% threshold wasn't reached) - test_pgsql_many_entries: fix misleading docstring claiming hash table distribution verification	1 month ago
Rene Cannao	86e86c8ce3	Fix parallel coverage collection and improve multi-group runner - Fix code coverage race condition: Each ProxySQL instance now writes .gcda files to its own directory using GCOV_PREFIX, preventing parallel groups from overwriting each other's coverage data - Add TAP_USE_NOISE documentation for noise injection testing - Replace random stagger delay with sequential delay (STAGGER_DELAY) to guarantee proper spacing between group startups - Update README with multi-group runner, coverage, and noise injection docs	1 month ago
René Cannaò	5129d55d00	Merge pull request #5484 from sysown/v3.0-issue5483 Fix TSDB TAP tests for Docker-based CI	1 month ago
René Cannaò	2ae866b59c	Add query_cache_unit-t to build and init Prometheus registry - tests/unit/Makefile: Register query_cache_unit-t in the build system - test_init.cpp: Create a real Prometheus registry in test_init_query_ cache() since the Query_Cache constructor registers metrics via GloVars.prometheus_registry (nullptr would crash)	1 month ago

... 2 3 4 5 6 ...

9212 Commits (6d6015a2034dbee2ea4eb50d2e84381df008fa46) All Branches Search

9212 Commits (6d6015a2034dbee2ea4eb50d2e84381df008fa46)

All Branches