proxysql

Commit Graph

Author	SHA1	Message	Date
Rahim Kanji	5810978e4e	Unify ABORT and ROLLBACK command parsing Remove separate early-return handling for ABORT that was bypassing parse_rollback(). Treat ABORT as a synonym of ROLLBACK.	1 month ago
Rahim Kanji	abb66cc19f	Addressed AI review feeback	1 month ago
Rahim Kanji	e84433159b	Merge remote-tracking branch 'v3.0' into v3.0_pgsql-pipeline-set-reset-discard-fix-5432	1 month ago
Rene Cannao	ff1398ead5	fix: plumb real hostgroup_id for pgsql replication lag monitoring - Add hostgroup_id to mon_srv_t and ext_srvs.\n- Update fetch_updated_conf queries to return hostgroup_id.\n- Use real hostgroup_id in replication_lag_action call.	1 month ago
Rene Cannao	1911b02157	feat: temporarily disable pgsql monitor replication lag group_by_host	1 month ago
René Cannaò	16f8837e0d	Merge branch 'v3.0' into v3.0-pgsql_monitor_repl_lag Signed-off-by: René Cannaò <rene@proxysql.com>	1 month ago
Rene Cannao	c4fc60bdb0	fix: address security and logic issues in PostgreSQL replication lag monitoring - Fix SQL injection in pt-heartbeat query concatenation.\n- Fix copy-paste errors between mysql_thread_ and pgsql_thread_ variables.\n- Restore monitor_replication_lag_group_by_host logic.	1 month ago
Rahim Kanji	96bc668735	Fix pipeline mode transaction state handling and SET/RESET/DISCARD support Addresses issues with PostgreSQL Extended Query Protocol (Pipeline mode) in ProxySQL: Transaction State Handler Migration: - Moved handle_transaction_state() from PgSQL_Session::RequestEnd() to PgSQL_Session::handler() - Now called only for client queries (PROCESSING_QUERY/PROCESSING_STMT_EXECUTE) - Prevents internal SET commands from triggering transaction logic incorrectly - Added transaction state reset at 7 locations for clean connection pool return SET/RESET/DISCARD Pipeline Mode Support (lib/PgSQL_Session.cpp): - SET statements now execute properly in pipeline mode via RunQuery() - RESET ALL and DISCARD ALL blocked with proper error messages in pipeline mode - Added startup parameter mismatch detection for RESET with locked hostgroup	1 month ago
Rahim Kanji	aca91c3bd2	Optimize PgSQL_Protocol::generate_ok_packet to use direct buffer writes Replace format-specifier based PG_pkt helper methods (write_CommandComplete, write_ParameterStatus, write_ReadyForQuery) with direct buffer writes using put_char(), put_uint32(), and put_string().	1 month ago
Rahim Kanji	5dd27500f3	Addressed AI review feedback	1 month ago
Rahim Kanji	742ff05ecc	Fix PostgreSQL transaction state management for pipeline mode Move transaction state tracking from RequestEnd to connection handler to enable proper binary pipeline mode support: - Call handle_transaction_state() at ASYNC_QUERY_END/ASYNC_STMT_EXECUTE_END in PgSQL_Connection instead of RequestEnd - Add reset_state() calls in 7 locations to prevent stale state: * Session reset * Connection detach (finishQuery) * Error handlers (4 paths) * Base session housekeeping - Refactor destructor to use reset_state() Fixes transaction state tracking in pipeline mode where connections can be returned to pool mid-transaction.	1 month ago
Rahim Kanji	4d86e6949c	Add defensive null guard before reading PSarrayIN->len	1 month ago
Rahim Kanji	c309facaa2	Fixed typo	1 month ago
Rahim Kanji	ed8890b6a5	Added bounds checking for Describe and Close messages to prevent reads beyond packet boundaries	1 month ago
Rahim Kanji	8c9af56f38	Address AI review feedback	1 month ago
Rahim Kanji	83d16f3c22	Fix buffer handling in PostgreSQL admin session handler Improve error handling in admin_session_handler when processing PostgreSQL query packets: * Fix potential underflow in query_length calculation when handling very small packets (< 2 bytes) * Fix NULL pointer dereference in strcasecmp when query_no_space is not initialized due to early packet validation failures	1 month ago
Rahim Kanji	05b5821fbc	Fix integer underflow in PostgreSQL query packet handling and null terminator checking * Add validation to reject packets smaller than 6 bytes before processing * Add null terminator check	1 month ago
Rahim Kanji	d71090864f	Improve startup packet parsing Replace strlen() with memchr() to safely search for null terminators within buffer bounds. If no null terminator is found, treat the packet as malformed and break out of the processing loop.	1 month ago
Rahim Kanji	03ad2c3aae	Fix underallocation for undersized PostgreSQL packets The buffer2array() function could allocate less than 5 bytes for a packet when pkgsize was malformed to be smaller than the header size. This violated PostgreSQL protocol assumptions that packets are always >= 5 bytes. Ensure minimum allocation of sizeof(header) bytes regardless of the claimed packet size in the header.	1 month ago
Javier Jaramago Fernández	ff729a657e	chore: disable 'pt-heartbeat' in 'PgSQL_Threads_Handler::get_variable' This isn't for functional purposes, just for consistency in reporting the motivation for disabling the feature in the codebase.	2 months ago
Wazir Ahmed	5421a382ab	fix: Load TSDB variables from disk during startup - TSDB variables stored on disk were not being loaded into runtime during startup. Add the missing `flush_tsdb_variables___database_to_runtime()` and invoke it during init. - Inline the existing load/save wrappers in the header as thin delegations to the underlying flush functions Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Wazir Ahmed	1684d30725	fix: Refresh Prometheus metrics before TSDB sampling - `tsdb_sampler_loop()` calls `registry->Collect()` without refreshing module metrics, causing stale metric values to be stored in the TSDB. - Added `update_modules_metrics()` call before `Collect()` in the sampler. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
René Cannaò	148dfb2af3	Merge pull request #5423 from sysown/v3.0-genai_keys v3.0-genai_keys: GenAI live validations, LLM bridge tests, and portability fix	2 months ago
Rene Cannao	cffd980bb9	fix: Conditionally include sys/eventfd.h only on Linux Add #ifdef __linux__ guard around sys/eventfd.h include to fix compilation on non-Linux platforms.	2 months ago
Javier Jaramago Fernández	a4ea3b2174	Merge branch 'v3.0' of github.com:sysown/proxysql into v3.0-pgsql_monitor_repl_lag	2 months ago
Javier Jaramago Fernández	4103d69979	feat: disable 'pt-heartbeat' support for PostgreSQL The feature has been disabled until 'pt-heartbeat' support for PostgreSQL is fixed. See https://perconadev.atlassian.net/browse/PT-2030.	2 months ago
Rahim Kanji	866c3593bb	Set query retries for PostgreSQL extended query protocol operations Add query_retries_on_failure configuration for PARSE, DESCRIBE, and EXECUTE operations in PostgreSQL extended query protocol.	2 months ago
Rahim Kanji	27119169e4	Reset extended query frame if an unsupported message type is received	2 months ago
Rahim Kanji	7a062a3444	Add PgSQL notice handling in reset session paths Register the PostgreSQL notice handler during reset session operations. Previously, the handler was not set in this path, which could result in unhandled backend notices.	2 months ago
Rahim Kanji	1ffb4f13ac	Fix PostgreSQL resync error detection Add flush() call in resync_start() for immediate socket error detection instead of deferring to event loop	2 months ago
Wazir Ahmed	daa0b2037e	fix: Use consistent value representation in MCP query rules `mcp_query_rules` and `runtime_mcp_query_rules` uses different representations for the same fields, causing the web UI to always report config differences even after loading to runtime. - Use `-1` sentinel for nullable int fields (`flagOUT`, `timeout_ms`, `log`) so `NULL` values from main are preserved when written to runtime, following the `MySQL QP_rule_t` pattern. - Serialize `re_modifiers` bitmask back to `VARCHAR` (`1→"CASELESS"`) to match the format used in main table - Update `evaluate_mcp_query_rules()` to handle tri-state log field Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Wazir Ahmed	c05bc66655	fix: MCP variables overwritten due to incorrect flush logic `flush_mcp_variables___runtime_to_database()` ignores the `replace` parameter. The prepared statement is hardcoded to `REPLACE INTO`, so even when callers pass `replace=false` (e.g. `GenericRefreshStatistics`), the function overwrites values in memory config with stale runtime values. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Rene Cannao	f29a326ca0	Fix QueryDigestTopK heap comparator semantics	2 months ago
Rene Cannao	3e73787753	Revert "fix: Handle optimizer hints /+ / correctly in query tokenizers" This reverts commit `178f679fad`.	2 months ago
Rahim Kanji	176362c77d	Addressed feedback from AI review	2 months ago
Rahim Kanji	a82d653c0b	Handle late COPY protocol messages after session exits fast_forward mode When a COPY FROM STDIN operation encounters an error, the session switches back to normal mode. However, the client may have already pipelined CopyData('d'), CopyDone('c'), or CopyFail('f') messages that are still in the input queue. Previously, these messages fell through to the default case, generating a spurious "Feature not supported" error. This change adds explicit handling to discard these messages when session_fast_forward == SESSION_FORWARD_TYPE_NONE, preventing the race condition from causing errors. The client does not expect a response for these messages in this scenario.	2 months ago
Rene Cannao	6be9dd1bfa	fix: Address AI code review feedback from PR #5410 - Fix Top-K heap comparator in Query_Processor.cpp: use 'worse' comparator so heap top is the worst candidate (not best), enabling proper Top-K selection - Add packet/message size guards in MySQLFFTO and PgSQLFFTO on_server_data() to prevent memory exhaustion from large result sets - Add _exit(1) in utils.cpp when /dev/null open fails to prevent FD pollution - Add NULL checks and consume query result in test_ffto_bypass-t.cpp - Fix TAP message formatting in mcp_show_connections_commands_inmemory-t.cpp - Add run_admin_checked() helper in pgsql-issue5384-t.cpp for proper error handling	2 months ago
Rene Cannao	178f679fad	fix: Handle optimizer hints /+ / correctly in query tokenizers The query tokenizers for both MySQL and PostgreSQL did not correctly handle optimizer hint comments in the format /+ ... /. When parsing queries like `/+ hostgroup=1000 / SELECT 1`, the '+' character was incorrectly included in the extracted first comment content, resulting in the parsed key being '+hostgroup' instead of 'hostgroup'. This caused the query_processor_first_comment_parsing variable (modes 1 and 3) to not work correctly when using optimizer hint syntax. Changes: - c_tokenizer.cpp: Detect both /! and /+ comment formats - pgsql_tokenizer.cpp: Detect /*+ comment format - issue5384-t.cpp: Re-enable tests 2 and 3 (previously skipped) - pgsql-issue5384-t.cpp: Re-enable tests 2 and 3, add hostgroup 1000 setup Fixes #5413 (MySQL tokenizer) Fixes #5414 (PostgreSQL tokenizer)	2 months ago
Rene Cannao	70647fb426	fix: Remove unused legacy mcp-mysql_* variables These variables were deprecated in favor of profile-based routing but were never removed from the code. They existed in the struct definition, getters, and setters but were not consumed anywhere - Query_Tool_Handler uses target_auth_map via mcp_auth_profiles and mcp_target_profiles. Removed: - mcp-mysql_hosts, mcp-mysql_ports, mcp-mysql_user, mcp-mysql_password, mcp-mysql_schema from MCP_Thread.h struct - Variable names from mcp_thread_variables_names array - Initialization, cleanup, getters, and setters in MCP_Thread.cpp - Documentation in doc/MCP/VARIABLES.md	2 months ago
Rene Cannao	9b5d52308f	fix: Use legacy prepare_v2 for conditional statement preparation Use the legacy db->prepare_v2(const char, sqlite3_stmt*) overload for the runtime_global_variables statement, which allows conditional preparation only when the runtime flag is set. Properly finalize the statement when done.	2 months ago
Rene Cannao	de60fe2b3f	fix: Use db->execute() for runtime_global_variables inserts Simplified the code to use db->execute() instead of prepared statements for runtime_global_variables inserts. This avoids complex unique_ptr deleter type matching issues and the table not existing during early initialization.	2 months ago
Rene Cannao	7479f2168e	fix: Only prepare runtime_global_variables stmt when runtime=true The runtime_global_variables table may not exist during early initialization, so we should only prepare the statement for it when the runtime flag is true. This fixes a crash on startup when init_mcp_variables() is called before the admin database schema is fully initialized.	2 months ago
Rene Cannao	8b1fb84d5c	fix: Populate runtime_global_variables for MCP variables The MCP variables were not being exposed in runtime_global_variables table after LOAD MCP VARIABLES TO RUNTIME. This fix: 1. Adds runtime_global_variables handling to flush_mcp_variables___runtime_to_database: - Clears existing mcp-* entries from runtime_global_variables when runtime=true - Inserts current runtime values into runtime_global_variables 2. Calls flush_mcp_variables___runtime_to_database with runtime=true from flush_mcp_variables___database_to_runtime to ensure the runtime table is populated after variables are loaded to runtime. This matches the behavior of other variable modules (admin, ldap, mysql, pgsql).	2 months ago
Rene Cannao	e53d2c76f9	Address PR #5410 review findings across FFTO, sessions, TAP, and docs Apply actionable bot review feedback from PR #5410 without behavior drift:\n- fix MySQL/PgSQL FFTO digest normalization and max-length hashing\n- add early FFTO packet/message size guards for bypass safety\n- restore MySQL session GTID reset and harden GenAI async error ownership\n- add null-check for stripped KILL query normalization path\n- call FFTO on_close() before observer reset/bypass in session flows\n- fix processlist query-options default pagination limit semantics\n- fix TAP noise_failures locking race and noise-aware plan count\n- extend wait_get_enpoint_ready with optional basic-auth passthrough\n- update MCP architecture docs from observe->stats naming\n- clean corrupted character in pgsql query-cache test comment\n\nValidation run:\n- git diff --check\n- make -C test/tap/tap tap.o utils_mariadb.o utils_mysql57.o utils_mysql8.o -j4\n- make -C lib obj/MySQLFFTO.oo obj/PgSQLFFTO.oo obj/MySQL_Session.oo obj/PgSQL_Session.oo obj/Query_Processor.oo -j4	2 months ago
Rene Cannao	79c0b383e8	integration: fix pre-CI issues in unified branch	2 months ago
Rene Cannao	acef17a8c1	Merge branch 'v3.0-ff_inspect' into v3.0-unified-large-pr # Conflicts: # test/tap/tests/Makefile	2 months ago
Rene Cannao	e2ebc0c449	Merge branch 'v4.0-mcp-stats2' into v3.0-unified-large-pr	2 months ago
Rene Cannao	54bcb5eeca	Merge branch 'v3.0-5384' into v3.0-unified-large-pr	2 months ago
Rene Cannao	90462f6d5a	ffto: harden MySQL/PgSQL observer state handling and align tests/docs Address outstanding review findings for FFTO on v3.0-ff_inspect and tighten protocol-state correctness for both engines. MySQL FFTO - Restrict on_close() reporting to true in-flight states and always clear query tracking state after close. - Add explicit active-query cleanup helpers and invoke them on state transitions to IDLE. - Preserve accounting on mid-resultset server ERR packets by reporting current query in READING_COLUMNS/READING_ROWS before reset. - Keep prepared-statement lifecycle cleanup robust (pending prepare cleared on prepare completion paths). MySQL session integration - Extract duplicated FAST_FORWARD client FFTO feed logic into observe_ffto_client_packet() and reuse it from all call sites. PostgreSQL FFTO - Replace regex-based CommandComplete parsing with lightweight token parsing, including NUL/whitespace trimming and strict numeric validation. - Add queued tracking for pipelined extended-protocol executes so query text and response attribution stay aligned under Parse/Bind/Execute pipelining. - Distinguish finalize semantics (execute-finalize on CommandComplete vs sync-finalize on ReadyForQuery) and centralize finalize/activation helpers. - Add frontend Close ('C') handling to evict statement/portal mappings. - Harden client/server message parsing with additional length checks. - Extend affected-row command tag coverage to COPY and MERGE. TAP tests - Stabilize test plans for failure paths by replacing early returns with a fail-and-skip-remaining flow and shared cleanup labels. - Ensure both MySQL and PgSQL FFTO tests preserve planned assertion counts under setup/prepare/execute failures. Documentation - Align FFT0 design doc state/response descriptions with current implementation (ReadyForQuery handling, pipelined queueing, supported PG command tags). - Fix wording/typo issues in protocol section. Validation performed - make -C lib -j4 - make -C test/tap/tests test_ffto_mysql-t test_ffto_pgsql-t -j4 Runtime execution of the two TAP binaries remains environment-dependent (admin endpoint connectivity required).	2 months ago
Rene Cannao	5519080ac2	mcp stats: address review findings and remove --genai CLI flag	2 months ago

1 2 3 4 5 ...

5004 Commits (5810978e4e186c17f09bb38eccbaeb67ad6b59ea)