proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	37e72ea3f9	Fix PROXY protocol detection in MySQL_Data_Stream::read_from_net When pkts_recv==0, the code reads 4 bytes expecting a MySQL packet header, but PROXY protocol starts with 'PROXY ' which gets misinterpreted as a MySQL header with a huge packet length (0x504f5250 = ~1.3GB). Add check for 'PROX' prefix before parsing as MySQL header. This prevents passing an incorrect length parameter to recv() that exceeds the buffer size. Fixes #5376	2 months ago
Rene Cannao	11a43bf768	Fix uninitialized max_allowed_pkt in MySQL_Connection constructor Initialize options.max_allowed_pkt to 0 to prevent Valgrind errors when logging handshake debug information.	2 months ago
Rene Cannao	ca4f858b29	Fix uninitialized memory read in pgsql tokenizer Change malloc() to calloc() in get_result_buffer() to zero-initialize the query digest buffer before use. This prevents stage_2_parsing() from reading uninitialized memory when processing query digests. Fixes #5375	2 months ago
Rene Cannao	85952373d9	Fix uninitialized mondb pointer in MySQL_Monitor_State_Data constructor Add mondb = NULL initialization to prevent Valgrind errors when monitor threads access the pointer before it's properly set.	2 months ago
Rene Cannao	200fdecb8d	Apply AI agent review fixes to PR #5374 Critical Fixes: - Fix NULL pointer dereferences in MySQL_Logger.cpp: * Add null checks for myds->myconn->parent in log_audit_entry() * Fix cleanup code in log_request() and log_audit_entry() * Change sprintf to snprintf for buffer safety - Remove redundant pthread_rwlock_init in debug.cpp: * filters_rwlock already initialized with PTHREAD_RWLOCK_INITIALIZER * Re-initialization caused undefined behavior per POSIX Major Improvements: - Add bounded wait helper wait_for_glo_mth() in proxysql_utils.h: * Replaces indefinite while loops with 10s timeout * Applied to 26 locations across 4 files Build System: - Require C++17 in Makefile (remove C++11 fallback): * Code uses C++17 structured bindings extensively * Cleanest solution vs adding fallback guards to 27+ locations Compilation fixes: - Add unistd.h include for usleep - Remove conflicting GloMyMon extern declaration Files changed: - Makefile - include/proxysql_utils.h - lib/MySQL_Logger.cpp - lib/debug.cpp - lib/MySQL_Monitor.cpp - lib/ProxySQL_Admin.cpp - lib/ClickHouse_Server.cpp - src/SQLite3_Server.cpp	2 months ago
Rene Cannao	941e6b7320	Fix filters_rwlock initialization race condition Add static initialization PTHREAD_RWLOCK_INITIALIZER to filters_rwlock in debug.cpp to prevent race condition where proxy_debug() is called before init_debug_struct() initializes the rwlock. This fixes Valgrind errors in filter_debug_entry() where threads were accessing an uninitialized rwlock.	2 months ago
Rene Cannao	3c85c593cf	Add GloMTH initialization wait to all monitor and server threads Fix race condition where threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int() and related functions. Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to ensure GloMTH is fully initialized before use: In lib/MySQL_Monitor.cpp: - monitor_connect(), monitor_ping(), monitor_read_only() - monitor_group_replication(), monitor_galera(), monitor_replication_lag() - monitor_AWS_Aurora_thread_HG(), monitor_aws_aurora() - init_mysql_thread_struct() In src/SQLite3_Server.cpp: - SQLite3_Server_session_handler In lib/ProxySQL_Admin.cpp: - admin_session_handler In lib/ClickHouse_Server.cpp: - ClickHouse_Server_session_handler The pattern ensures threads wait for GloMTH initialization during startup, then check for NULL during shutdown to exit cleanly.	2 months ago
Rene Cannao	aa53d990ed	Add GloMTH initialization wait to all monitor threads Fix race condition where monitor threads were accessing GloMTH before it was fully initialized, causing Valgrind errors in get_variable_int(). Added wait loop pattern (while GloMTH==NULL { usleep(50000); }) followed by usleep(100000) to: - monitor_ping_thread - monitor_read_only_thread - monitor_replication_lag_thread - monitor_group_replication_thread (also moved check before MySQL_Thread creation) - monitor_galera_thread (also moved check before MySQL_Thread creation) This matches the existing pattern in monitor_connect_thread.	2 months ago
Rene Cannao	f4cd34be5c	Fix race condition in monitor_connect_thread Add wait loop for GloMTH initialization before accessing variables. Other monitor threads (MonitorPing, MonitorReadOnly, etc.) already had this pattern, but monitor_connect_thread was missing it. This fixes Valgrind errors about uninitialized values in get_variable_uint16() when strcasecmp reads from memory that hasn't been fully initialized yet.	2 months ago
Rene Cannao	09d0dcb808	Fix uninitialized tmp_charset in Data_Stream constructors Initialize tmp_charset=0 in MySQL_Data_Stream and PgSQL_Data_Stream constructors. This field was used uninitialized in process_pkt_handshake_response() when calling proxy_debug(), causing Valgrind errors about uninitialized values in vsnprintf.	2 months ago
Rene Cannao	7c67eb25f1	Fix uninitialized fd and status in Data_Stream constructors Initialize fd=-1 and status=0 in MySQL_Data_Stream and PgSQL_Data_Stream constructors. These fields were not initialized, causing Valgrind errors when GPFC_Statuses2() checked mybe->server_myds->status and fd.	2 months ago
Rene Cannao	4e39297ef9	Fix more Valgrind uninitialized value errors 1. Base_Thread.cpp: Initialize member variables in constructor - curtime, last_move_to_idle_thread_time, epoll_thread, shutdown, mysql_sessions were not initialized, causing uninitialized value use in ProcessAllMyDS_BeforePoll and ProcessAllMyDS_AfterPoll. 2. MySQL_Logger.cpp: Initialize query_ptr, query_len, and buf in MySQL_Event constructor. These fields were used without initialization, causing Valgrind errors in JSON serialization and other operations.	2 months ago
Rene Cannao	fdbea2a32e	Fix uninitialized memory in Command_Counter::_counters Replace _counters{} initialization syntax with explicit memset() to ensure the _counters array is properly zero-initialized. The _counters{} syntax may not reliably zero-initialize arrays in all compiler implementations, causing Valgrind to report use of uninitialized values when add_and_reset() reads from the array. Also remove the safety checks added previously since the root cause is now properly fixed.	2 months ago
Rene Cannao	c2f82b3d4e	Fix more Valgrind uninitialized value errors 1. MySQL_Logger.cpp: Initialize username_len, schemaname_len, and server_len to 0 in MySQL_Event constructor. These fields were uninitialized and used in copy constructor and JSON serialization. 2. debug.cpp: Add default member initializers to DebugLogEntry struct to ensure POD fields are zero-initialized. Move errno save/restore to after early return checks to avoid potential TLS access issues before thread is fully initialized.	2 months ago
Rene Cannao	ee7ee0b387	Fix multiple Valgrind-reported uninitialized memory issues 1. MySQL_Logger.cpp: Add NULL checks for myconn->parent before accessing address/port. Client connections (frontend) have parent=NULL, causing uninitialized value reads when logging. 2. debug.cpp: Add NULL check for GloVars.global.gdbg_lvl before accessing debug level configuration. Prevents use of uninitialized data when proxy_debug_func is called before init_debug_struct() completes. 3. ProxySQL_Admin.cpp: Add NULL checks for debug filter database fields before constructing filter strings. Prevents undefined behavior when constructing std::string from NULL pointers.	2 months ago
Rene Cannao	af58865b06	Fix uninitialized memory in QueryParserArgs.buf Use memset to zero-initialize the entire QueryParserArgs struct instead of individually setting only digest_text and first_comment to NULL. This fixes Valgrind errors about use of uninitialised values in strcasestr() when reading from the uninitialized buf array. Fixes errors like: Use of uninitialised value of size 8 at tolower (ctype.c:46) by strcasestr by MySQL_Connection::ProcessQueryAndSetStatusFlags(char*)	2 months ago
Rene Cannao	cc53ddca23	Merge branch 'v3.0-openssl-fix' into v3.0-test0213	2 months ago
Rene Cannao	52718df11f	Fix memory leak in stats processlist functions - Add missing delete resultset in stats___mysql_processlist - Add missing delete resultset in stats___pgsql_processlist	2 months ago
Rene Cannao	746eca9f7c	More sprintf to snprintf conversions and indentation fixes - Replace remaining sprintf with snprintf in Admin_FlushVariables.cpp - Fix indentation in flush_GENERIC_variables__process__database_to_runtime - Apply same pattern to ProxySQL_Admin.cpp and ProxySQL_Admin_Stats.cpp	2 months ago
Rene Cannao	3e37337877	Use RAII for sqlite3 statements across codebase - Convert prepare_v2() calls to use unique_ptr RAII pattern - Remove manual sqlite3_finalize calls (now handled by RAII) - Update flush_*_variables functions to use new prepare_v2 return pattern - Apply changes to Admin, Cluster, Monitor, Catalog, and other modules	2 months ago
Rene Cannao	335be9ec72	Fix unsafe sprintf and error message handling - Replace sprintf with snprintf in flush_*_variables functions - Add null value safety with safe_val in variable flushing - Fix error message to use send_error_msg_to_client instead of send_ok_msg_to_client	2 months ago
Rene Cannao	61ce0a96e8	Remove redundant sqlite3_finalize calls in pgSQL stats Statements are managed by RAII and auto-finalized	2 months ago
Rene Cannao	afd6dffb05	Fix admin shutdown races and implement graceful teardown - Add coordinated shutdown for PROXYSQL KILL/SHUTDOWN in debug builds - Track active admin client threads with admin_client_threads_active counter - Add shutdown checks to prevent new connections during shutdown - Wait for all admin client threads to finish before cleanup in admin_shutdown() - Handle accept failures gracefully	2 months ago
Rene Cannao	368a9e3a63	Fix log_buffer debug leak during shutdown	2 months ago
Rene Cannao	ba86be70a6	Fixed some bugs in PR 5358	2 months ago
Rene Cannao	da7c8e5cf5	Fix missing variable	2 months ago
Rene Cannao	4ae5bd852a	Revert "fix: prevent dangling pointer in flush_*_variables___runtime_to_database" This reverts commit `a20b2704f4`.	2 months ago
René Cannaò	02ea4f90be	Merge pull request #5360 from sysown/v3.0-5359 fix: crash on macOS/FreeBSD when running PostgreSQL queries	2 months ago
René Cannaò	e82ff6f8aa	Merge pull request #5361 from sysown/v3.0-5069 Add protocol labels for all PostgreSQL metrics and extend prometheus metrics coverage	2 months ago
Rene Cannao	a69b925932	Minor typo fixes	2 months ago
Rahim Kanji	9460520999	Add more tests	2 months ago
Rahim Kanji	e76d9dc130	Cleanup	2 months ago
Rahim Kanji	331b0d6bce	Add support for PostgreSQL psql meta-commands in admin interface Implement handling for psql meta-commands (\dt, \di, \dv, \d, \l) in ProxySQL's PostgreSQL admin interface by intercepting expanded queries and converting them to appropriate SQLite queries. Supported commands: - \l, \l+: List databases (maps to PRAGMA DATABASE_LIST) - \dt [pattern]: List tables with optional pattern matching - \di [pattern]: List indexes with optional pattern matching - \dv [pattern]: List views with optional pattern matching - \d: List all relations (tables, views, indexes, triggers) Pattern matching supports psql regex syntax like '\dt mytest' by converting PostgreSQL regex patterns (^(pattern).$) to SQLite LIKE patterns (pattern%).	2 months ago
Rene Cannao	3ab964010d	Add protocol labels to Query Cache metrics and enable PostgreSQL QC metrics This commit resolves the prometheus metric collision between MySQL and PostgreSQL Query Cache instances by creating separate metric maps with protocol labels and using compile-time type trait selection. Changes: - Add #include <type_traits> to Query_Cache.cpp - Create qc_metrics_map_mysql with { "protocol", "mysql" } labels (8 metrics) - Create qc_metrics_map_pgsql with { "protocol", "pgsql" } labels (8 metrics) - Modify Query_Cache constructor to use if constexpr with std::is_same_v to select the appropriate metrics map based on derived type - Enable GloPgQC metrics export in update_modules_metrics() This allows MySQL and PostgreSQL query cache metrics to coexist without collision, following the same pattern as Thread Handler metrics. Related: #5068, #5069	2 months ago
Rene Cannao	778e01174c	Add protocol labels to Thread Handler metrics and enable PostgreSQL metrics This commit extends PR #5069 by adding protocol labels to distinguish MySQL and PostgreSQL metrics in the Thread Handler modules. Changes: - Add { "protocol", "mysql" } labels to 65 MySQL_Thread.cpp metrics - Add { "protocol", "pgsql" } labels to 60 PgSQL_Thread.cpp metrics - Enable GloPTH (PostgreSQL threads handler) metrics export - Document Query Cache limitation (template base class collision) This resolves Issue #5068 by ensuring PostgreSQL prometheus metrics are properly exported with protocol labels, distinguishing them from MySQL metrics. Related: #5068, #5069	2 months ago
René Cannaò	fa35bda62b	Merge pull request #5069 from evkuzin/v3.0-fix-prometheus-metrics-dumplication add protocol labels for shared metrics between mysql and psql	2 months ago
Rene Cannao	17054cd14f	fix: memory leak in pull_global_variables_from_peer The statement1 was prepared but never finalized, causing a memory leak. Migrated to RAII pattern for automatic cleanup. Also updates mysql_hostgroup_attributes and mysql_servers_ssl_params to use RAII for consistency (lines 2231 and 2267), even though those had manual finalize calls. Reported-by: CodeRabbit AI	2 months ago
Rene Cannao	deb19a021c	fix: remove double-finalization in stats___save_mysql_query_digest_to_sqlite The RAII-managed unique_ptr already handles statement finalization. Manual finalize calls cause double-free which leads to undefined behavior. Reported-by: CodeRabbit AI	2 months ago
Rene Cannao	a20b2704f4	fix: prevent dangling pointer in flush_*_variables___runtime_to_database Move statement2_unique to function scope to prevent use-after-free. The unique_ptr was declared inside the if (runtime) block but statement2 (raw pointer) was used in the loop outside that block, causing the statement to be finalized before use. Affected functions: - flush_variables___runtime_to_database (PgSQL variables) - flush_genai_variables___runtime_to_database (GenAI variables) - flush_mysql_variables___runtime_to_database (MySQL variables) Reported-by: CodeRabbit AI	2 months ago
René Cannaò	fcaa904135	fix: crash on macOS/FreeBSD when running PostgreSQL queries Fix NULL pointer dereference in CopyCmdMatcher that caused ProxySQL to crash immediately when running any PostgreSQL query on macOS and FreeBSD systems. Root cause: copy_cmd_matcher was guarded by #ifdef IDLE_THREADS, but IDLE_THREADS is explicitly disabled on macOS (__APPLE__) and FreeBSD in proxy_defines.h. This caused the pointer to be NULL when accessed. The fix removes #ifdef IDLE_THREADS guards from copy_cmd_matcher since COPY command detection is a fundamental PostgreSQL feature for fast- forward mode and has no dependency on idle threads. Affected systems: macOS, FreeBSD (where IDLE_THREADS is disabled) Fixes: #5359	2 months ago
Rene Cannao	6f415dfdb2	fix: correct RAII migration issues - variable naming and redundant declarations - Fixed SAFE_SQLITE3_STEP2 macro errors: renamed 'rc1' to 'rc' in PgSQL_Monitor.cpp functions (update_connect_table, update_ping_table, update_readonly_table, maint_monitor_table) to match the macro's expected variable name - Removed redundant NULL declarations in ProxySQL_Admin_Stats.cpp functions (stats___pgsql_processlist, stats___pgsql_free_connections, stats___pgsql_errors, stats___save_pgsql_query_digest_to_sqlite) - Completed migration of stats___pgsql_errors and stats___save_pgsql_query_digest_to_sqlite to RAII pattern	2 months ago
Rene Cannao	7c0ff770f6	refactor: migrate prepare_v2 SIMPLE cases in ProxySQL_Admin_Stats.cpp Migrated all prepare_v2 calls to RAII-based pattern in 5 functions: - stats___mysql_processlist(): 2 statements (statement1, statement32) - stats___pgsql_processlist(): 2 statements - stats___mysql_free_connections(): 2 statements - stats___mysql_query_rules(): 2 statements - stats___mysql_query_digest(): 2 statements And removed manual finalization calls for all functions. The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	2 months ago
Rene Cannao	ee85b11ad5	refactor: migrate prepare_v2 SIMPLE case in PgSQL_HostGroups_Manager.cpp Migrated 1 function with 2 prepare_v2 calls to RAII-based pattern in: - generate_pgsql_hostgroup_attributes_table(): 2 statements (statement1, statement2) The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	2 months ago
Rene Cannao	e4704c5a51	refactor: migrate prepare_v2 SIMPLE cases in PgSQL_Monitor.cpp Migrated 5 prepare_v2 calls to RAII-based pattern in: - update_monitor_pgsql_servers(): 2 statements (stmt1, stmt32) - update_connect_table(): 1 statement (stmt) - update_ping_table(): 1 statement (stmt) - update_readonly_table(): 1 statement (stmt) - maint_monitor_table(): 1 statement (stmt) Note: Functions shunn_non_resp_srv() and update_srv_latency() were NOT migrated because they use global thread_local cached statements, which is a valid use case for the old API. The RAII pattern ensures automatic cleanup and eliminates manual sqlite_finalize_statement() calls.	2 months ago
Rene Cannao	73555410e9	refactor: migrate prepare_v2 SIMPLE case in FlushDigestTableToDisk template Migrated the template function FlushDigestTableToDisk to use RAII-based prepare_v2. This function is instantiated for both MySQL and PostgreSQL, eliminating 8 deprecation warnings (4 instantiations x 2 prepare_v2 calls). The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls.	2 months ago
Rene Cannao	2e907bdd3a	refactor: migrate prepare_v2 SIMPLE cases in ProxySQL_Cluster.cpp Migrated 4 prepare_v2 calls to RAII-based pattern in: - pull_mysql_query_rules_from_peer(): 3 statements (statement1, statement1fr, statement32fr) - update_mysql_users(): 1 statement (also fixes memory leak - missing finalize) - update_ldap_mappings(): 1 statement (also fixes memory leak - missing finalize) The RAII pattern ensures automatic cleanup and eliminates manual (*proxy_sqlite3_finalize) calls, reducing the risk of resource leaks.	2 months ago
Rene Cannao	e3ee454369	fix: remove duplicate 'int rc' declarations in prepare_v2 migrated functions The RAII-based prepare_v2 migration introduced duplicate variable declarations that caused compilation errors. Removed duplicate 'int rc;' declarations in: - dump_checksums_values_table() - save_mysql_users_runtime_to_database() - save_pgsql_users_runtime_to_database() The 'int rc' variable was already declared at function scope, so the duplicate declarations after the structured bindings were redundant.	2 months ago
Rene Cannao	5b6381b329	refactor: migrate remaining prepare_v2 SIMPLE cases in ProxySQL_Admin Migrated: - save_pgsql_ldap_mapping_runtime_to_database() - save_mysql_servers_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	2 months ago
Rene Cannao	2a83a30972	refactor: migrate more prepare_v2 SIMPLE cases in ProxySQL_Admin Migrated: - save_pgsql_users_runtime_to_database() - save_mysql_ldap_mapping_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	2 months ago
Rene Cannao	ca9b72a9df	refactor: migrate more prepare_v2 SIMPLE cases in ProxySQL_Admin Migrated: - dump_checksums_values_table() - save_mysql_users_runtime_to_database() All statements are now automatically managed by RAII smart pointers.	2 months ago

1 2 3 4 5 ...

4857 Commits (37e72ea3f98cb83b2ea832166c14905de643e620)