proxysql

Commit Graph

Author	SHA1	Message	Date
copilot-swe-agent[bot]	8d358cbfdc	feat: load restapi routes from config aliases Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/40d309f0-bd3d-4616-9cd6-fa7d8f1cb355	1 month ago
René Cannaò	0e955cd4bc	Merge pull request #5465 from sysown/v3.0-mac260320 Fix macOS compilation and add static zstd linking	1 month ago
René Cannaò	7918e1737d	Merge pull request #5464 from sysown/freebsd-build-fixes Fix FreeBSD build compatibility	1 month ago
René Cannaò	3f1b0a1510	Add static linking for zstd compression library - Add zstd v1.5.7 as a static dependency in deps/ - Add zstd build rules to deps/Makefile - Add ZSTD_PATH, ZSTD_IDIR, ZSTD_LDIR to makefiles_paths.mk - Add zstd include path to lib/Makefile and src/Makefile - Link zstd statically in LIBPROXYSQLAR for all platforms - Remove -lzstd from dynamic linking flags (Linux and macOS) - Replace clickhouse-cpp bundled zstd with our static zstd This eliminates the runtime dependency on system/Homebrew zstd and ensures consistent behavior across platforms. Related: #5462	1 month ago
Rene Cannao	c5ebab5589	Fix FreeBSD build compatibility - Replace grep -Po (Perl regex) with grep -Eo (extended regex) for BSD compatibility - Use CC ?= cc instead of export CC=gcc to respect user's compiler choice - Add FreeBSD to std::conjunction check (already defined in BSD libc++) - Use reinterpret_cast<uintptr_t> for pthread_self() (pointer type on BSD) - Add missing FreeBSD headers: sys/socket.h and netinet/in.h Tested on FreeBSD 14.3 with clang and Linux with gcc.	1 month ago
copilot-swe-agent[bot]	e274862857	feat: introduce stats_global table and move TLS metrics out of stats_mysql_global; add TAP tests - Add STATS_SQLITE_TABLE_GLOBAL definition (stats_global table for non-MySQL/PgSQL metrics) - Register stats_global in Admin_Bootstrap.cpp - Add stats___global() implementation and declaration; document with Doxygen comment - Remove TLS_* variables from stats___mysql_global() - they were misplaced there - Move all TLS tracking metrics to stats___global() under ssl_mutex - Wire up stats_global query detection and refresh in GenericRefreshStatistics() - Add TAP test test_tls_stats-t.cpp: - Verifies stats_global contains all 6 TLS tracking variables - Checks value ranges and validity of each TLS variable - Verifies stats_tls_certificates has 2 rows (server + ca) with correct fields - Verifies TLS_Load_Count increments and TLS_Last_Load_Timestamp increases after PROXYSQL RELOAD TLS - Confirms TLS variables are absent from stats_mysql_global Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	1 month ago
René Cannaò	88be1449d3	Fix compilation issues on macOS - Add Homebrew include paths for zstd headers on macOS - Fix pthread_t cast on macOS where it's a pointer type On macOS, pthread_t is defined as _opaque_pthread_t * (a pointer), unlike Linux where it's an integral type. Use reinterpret_cast<uintptr_t> for proper conversion. Related: #5462	1 month ago
Rene Cannao	2fcfd648e5	Merge remote-tracking branch 'origin/v3.0' into copilot/support-zstd-compression # Conflicts: # test/infra/infra-mysql84/docker-compose-init.bash # test/tap/groups/groups.json	1 month ago
Rene Cannao	8c6a6444db	fix: support zstd compression in mysql84 TAP	1 month ago
Rene Cannao	3458cbd28b	fix: address zstd review feedback	1 month ago
Rene Cannao	c22056c37c	Finalize fixes and add TAP group for no-infra tests	1 month ago
Rene Cannao	4517edea78	Address review feedback and create no-infra TAP group - Fix retry loop in admin_set_credentials_logging-t.cpp to clear eofbit (CodeRabbit) - Fix spelling in lib/Admin_Handler.cpp (CodeRabbit) - Create new 'no-infra-g1' TAP group in groups.json - Add 'tests_no_infra' target to Makefiles to run tests without backends	1 month ago
copilot-swe-agent[bot]	33e125ef59	fix: tighten zstd handshake parsing Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	1 month ago
copilot-swe-agent[bot]	ec44a15058	feat: add mysql protocol zstd compression support Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	1 month ago
copilot-swe-agent[bot]	14ac53379a	test: harden admin credential logging regression Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	1 month ago
copilot-swe-agent[bot]	b4cd4a198e	fix: redact admin credentials in set logging Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	1 month ago
copilot-swe-agent[bot]	0357862590	fix: address code review feedback - use strdup for file paths, check ASN1_TIME_diff return, refactor dup cert loading, larger CN buffer Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	1 month ago
copilot-swe-agent[bot]	4f88740b20	feat: add stats_tls_certificates table and TLS tracking metrics - Add STATS_SQLITE_TABLE_TLS_CERTIFICATES definition with cert_type, file_path, subject_cn, issuer_cn, serial_number, not_before, not_after, days_until_expiry, sha256_fingerprint, and loaded_at columns - Add TLS tracking fields to GloVars.global: tls_load_count, tls_last_load_timestamp, tls_last_load_ok, tls_cert_file, tls_ca_file, tls_key_file - Update ProxySQL_create_or_load_TLS() to populate tracking fields on success - Register stats_tls_certificates table in Admin_Bootstrap - Add stats___tls_certificates() function that reads certs from disk at query time, extracts metadata (CN, serial, validity dates, SHA-256 fingerprint, days_until_expiry) and populates the table - Add TLS variables to stats___mysql_global(): TLS_Load_Count, TLS_Last_Load_Timestamp, TLS_Last_Load_Result, TLS_Server_Cert_File, TLS_CA_Cert_File, TLS_Key_File - Wire up query detection and refresh in GenericRefreshStatistics() Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	1 month ago
Rahim Kanji	9ab9787c91	Addressed AI review feedback	1 month ago
Rahim Kanji	0ed5879df6	Added two more query handling	1 month ago
Rahim Kanji	2046d92b70	Merge remote-tracking branch 'v3.0' into v3.0_pgsql_meta_command_describe_table	1 month ago
René Cannaò	9d921bdda3	Merge pull request #5444 from sysown/v3.0_unify-PR-5433-5442 Unify PR#5433 & 5442	1 month ago
Rahim Kanji	ca45405942	Merge remote-tracking branch 'Master/v3.0-moveInfra' into v3.0_pgsql-pipeline-set-reset-discard-fix-5432	1 month ago
Rahim Kanji	8e047398ce	Change memcpy to memmove which correctly handles overlapping memory regions.	1 month ago
Rahim Kanji	4cb14109d4	Fixed error message	1 month ago
Wazir Ahmed	fc12e9a6ab	Add protocol label to connpool Prometheus metrics MySQL and PgSQL share the same metric family names for connection pool metrics. Since they have independent hostgroup ID namespaces, add a protocol label to distinguish metrics from each module. Affected metrics: - `proxysql_connpool_conns` - `proxysql_connpool_conns_total` - `proxysql_connpool_conns_queries_total` - `proxysql_connpool_conns_latency_us` - `proxysql_connpool_conns_status` - `proxysql_connpool_data_bytes_total` Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	1 month ago
Rahim Kanji	7c6664e308	Three malformed cases now rejected in 'options': 1. Token doesn't start with -c or -- 2. No = after key 3. Empty key	1 month ago
Rahim Kanji	8249fead6b	Fix options parameter parsing to reject unescaped spaces The parse_options() function now properly validates the options connection parameter to detect and reject unescaped spaces in values, matching PostgreSQL's behavior.	1 month ago
Rahim Kanji	000a9794e4	Don't short-circuit in pipeline mode, fall through to backend execution	2 months ago
Rahim Kanji	5810978e4e	Unify ABORT and ROLLBACK command parsing Remove separate early-return handling for ABORT that was bypassing parse_rollback(). Treat ABORT as a synonym of ROLLBACK.	2 months ago
René Cannaò	4d58ce473e	Merge pull request #5435 from sysown/v3.0-ci_fix0301 Fix tests for isolated CI environment and enhance diagnostics	2 months ago
Rahim Kanji	abb66cc19f	Addressed AI review feeback	2 months ago
Rene Cannao	6b9918fdcc	chore: refine guard structures and fix indentation - Fixed indentation for TSDB methods in include/proxysql_admin.h. - Refined PROXYSQLTSDB guard structure in lib/Admin_FlushVariables.cpp. - Cleaned up indentation and redundant code in lib/ProxySQL_RESTAPI_Server.cpp. - Ensured consistent formatting across modified files.	2 months ago
Rene Cannao	17225e8e23	fix: resolve syntax error in ProxySQL_Statistics.cpp and verify build stability across tiers - Fixed a mismatched #endif and closing brace in ProxySQL_Statistics::disk_upgrade_mysql_connections. - Verified build stability for all three tiers (base, v3.1, v4.0) with clean builds.	2 months ago
Rene Cannao	6b46b26931	chore: implement PR review feedback for release tier system - Makefile: normalized GIT_VERSION by stripping 'v' prefix before arithmetic. - Makefile: corrected .PHONY declaration for build_deps_debug_default. - Admin Handler: properly guarded TSDB commands to return error when disabled. - REST API: removed redundant nested guards inside tsdb_resource class. - Statistics: implemented rigorous input validation for set_variable. - Statistics: added return value checks and rollback logic for TSDB migrations. - Statistics: implemented bounded concurrency (batching) for backend probes. - FFTO: implemented cumulative buffer limit enforcement in MySQL and PgSQL. - FFTO: ensured initial packet capture in PgSQL_Session by early initialization. - FFTO: improved reassembly buffer compaction logic. - Headers: default-initialized ffto_bypassed to false. - Code cleanup: merged redundant PROXYSQLFFTO guards.	2 months ago
Rene Cannao	c2f678a9de	feat: implement release tiers and feature guards for v3.0, v3.1, and v4.0 This commit introduces a structured release tier system controlled by environment variables, allowing three distinct ProxySQL versions to be built from the same codebase while maintaining a clear upgrade path. Key Changes: - Tier 1 (v3.0.x Stable): Default build including bug fixes and core enhancements. - Tier 2 (v3.1.x Innovative): Enabled via PROXYSQL31=1. Adds FFTO and TSDB. - Tier 3 (v4.0.x AI/MCP): Enabled via PROXYSQLGENAI=1. Adds the AI stack. Implementation Details: - Makefile: Implemented dynamic versioning logic that increments the minor version for v3.1 and the major version for v4.0. Added tier documentation. - Feature Guards: Introduced PROXYSQLFFTO and PROXYSQLTSDB guards across ProxySQL_Admin, ProxySQL_Statistics, REST API, and HTTP server. - FFTO: Guarded Fast Forward Traffic Observer in MySQL and PgSQL sessions, including thread-local variables and configuration parameters. - TSDB: Guarded the entire Time Series Database subsystem, including SQLite table definitions, background loops, and REST API endpoints. - Build Fixes: * Fixed 'proxy_debug_func' linkage by adding extern "C" and moving the definition outside of DEBUG guards to ensure non-debug builds link correctly. * Corrected misplaced/nested DEBUG and PROXYSQLFFTO guards. * Verified build stability for all tiers (unset, PROXYSQL31=1, PROXYSQLGENAI=1).	2 months ago
Rahim Kanji	e84433159b	Merge remote-tracking branch 'v3.0' into v3.0_pgsql-pipeline-set-reset-discard-fix-5432	2 months ago
Rene Cannao	ff1398ead5	fix: plumb real hostgroup_id for pgsql replication lag monitoring - Add hostgroup_id to mon_srv_t and ext_srvs.\n- Update fetch_updated_conf queries to return hostgroup_id.\n- Use real hostgroup_id in replication_lag_action call.	2 months ago
Rene Cannao	1911b02157	feat: temporarily disable pgsql monitor replication lag group_by_host	2 months ago
René Cannaò	16f8837e0d	Merge branch 'v3.0' into v3.0-pgsql_monitor_repl_lag Signed-off-by: René Cannaò <rene@proxysql.com>	2 months ago
Rene Cannao	c4fc60bdb0	fix: address security and logic issues in PostgreSQL replication lag monitoring - Fix SQL injection in pt-heartbeat query concatenation.\n- Fix copy-paste errors between mysql_thread_ and pgsql_thread_ variables.\n- Restore monitor_replication_lag_group_by_host logic.	2 months ago
Rene Cannao	cf1fd5cb35	Admin: Add support for loading sqliteserver variables from config file Previously, sqliteserver variables (e.g., sqliteserver-mysql_ifaces) were not loaded from the configuration file during startup or via the LOAD SQLITESERVER VARIABLES FROM CONFIG command. This fix adds: - LOAD SQLITESERVER VARIABLES FROM CONFIG command handling in Admin_Handler - sqliteserver variables loading during bootstrap in Admin_Bootstrap	2 months ago
Rahim Kanji	96bc668735	Fix pipeline mode transaction state handling and SET/RESET/DISCARD support Addresses issues with PostgreSQL Extended Query Protocol (Pipeline mode) in ProxySQL: Transaction State Handler Migration: - Moved handle_transaction_state() from PgSQL_Session::RequestEnd() to PgSQL_Session::handler() - Now called only for client queries (PROCESSING_QUERY/PROCESSING_STMT_EXECUTE) - Prevents internal SET commands from triggering transaction logic incorrectly - Added transaction state reset at 7 locations for clean connection pool return SET/RESET/DISCARD Pipeline Mode Support (lib/PgSQL_Session.cpp): - SET statements now execute properly in pipeline mode via RunQuery() - RESET ALL and DISCARD ALL blocked with proper error messages in pipeline mode - Added startup parameter mismatch detection for RESET with locked hostgroup	2 months ago
Rahim Kanji	aca91c3bd2	Optimize PgSQL_Protocol::generate_ok_packet to use direct buffer writes Replace format-specifier based PG_pkt helper methods (write_CommandComplete, write_ParameterStatus, write_ReadyForQuery) with direct buffer writes using put_char(), put_uint32(), and put_string().	2 months ago
Rahim Kanji	5dd27500f3	Addressed AI review feedback	2 months ago
Rahim Kanji	742ff05ecc	Fix PostgreSQL transaction state management for pipeline mode Move transaction state tracking from RequestEnd to connection handler to enable proper binary pipeline mode support: - Call handle_transaction_state() at ASYNC_QUERY_END/ASYNC_STMT_EXECUTE_END in PgSQL_Connection instead of RequestEnd - Add reset_state() calls in 7 locations to prevent stale state: * Session reset * Connection detach (finishQuery) * Error handlers (4 paths) * Base session housekeeping - Refactor destructor to use reset_state() Fixes transaction state tracking in pipeline mode where connections can be returned to pool mid-transaction.	2 months ago
Rahim Kanji	4d86e6949c	Add defensive null guard before reading PSarrayIN->len	2 months ago
Rahim Kanji	c309facaa2	Fixed typo	2 months ago
Rahim Kanji	ed8890b6a5	Added bounds checking for Describe and Close messages to prevent reads beyond packet boundaries	2 months ago
Rahim Kanji	8c9af56f38	Address AI review feedback	2 months ago
Rahim Kanji	83d16f3c22	Fix buffer handling in PostgreSQL admin session handler Improve error handling in admin_session_handler when processing PostgreSQL query packets: * Fix potential underflow in query_length calculation when handling very small packets (< 2 bytes) * Fix NULL pointer dereference in strcasecmp when query_no_space is not initialized due to early packet validation failures	2 months ago
Rahim Kanji	05b5821fbc	Fix integer underflow in PostgreSQL query packet handling and null terminator checking * Add validation to reject packets smaller than 6 bytes before processing * Add null terminator check	2 months ago
Rahim Kanji	d71090864f	Improve startup packet parsing Replace strlen() with memchr() to safely search for null terminators within buffer bounds. If no null terminator is found, treat the packet as malformed and break out of the processing loop.	2 months ago
Rahim Kanji	03ad2c3aae	Fix underallocation for undersized PostgreSQL packets The buffer2array() function could allocate less than 5 bytes for a packet when pkgsize was malformed to be smaller than the header size. This violated PostgreSQL protocol assumptions that packets are always >= 5 bytes. Ensure minimum allocation of sizeof(header) bytes regardless of the claimed packet size in the header.	2 months ago
Javier Jaramago Fernández	ff729a657e	chore: disable 'pt-heartbeat' in 'PgSQL_Threads_Handler::get_variable' This isn't for functional purposes, just for consistency in reporting the motivation for disabling the feature in the codebase.	2 months ago
Wazir Ahmed	5421a382ab	fix: Load TSDB variables from disk during startup - TSDB variables stored on disk were not being loaded into runtime during startup. Add the missing `flush_tsdb_variables___database_to_runtime()` and invoke it during init. - Inline the existing load/save wrappers in the header as thin delegations to the underlying flush functions Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Wazir Ahmed	1684d30725	fix: Refresh Prometheus metrics before TSDB sampling - `tsdb_sampler_loop()` calls `registry->Collect()` without refreshing module metrics, causing stale metric values to be stored in the TSDB. - Added `update_modules_metrics()` call before `Collect()` in the sampler. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
René Cannaò	148dfb2af3	Merge pull request #5423 from sysown/v3.0-genai_keys v3.0-genai_keys: GenAI live validations, LLM bridge tests, and portability fix	2 months ago
Rene Cannao	cffd980bb9	fix: Conditionally include sys/eventfd.h only on Linux Add #ifdef __linux__ guard around sys/eventfd.h include to fix compilation on non-Linux platforms.	2 months ago
Javier Jaramago Fernández	a4ea3b2174	Merge branch 'v3.0' of github.com:sysown/proxysql into v3.0-pgsql_monitor_repl_lag	2 months ago
Javier Jaramago Fernández	4103d69979	feat: disable 'pt-heartbeat' support for PostgreSQL The feature has been disabled until 'pt-heartbeat' support for PostgreSQL is fixed. See https://perconadev.atlassian.net/browse/PT-2030.	2 months ago
Rahim Kanji	866c3593bb	Set query retries for PostgreSQL extended query protocol operations Add query_retries_on_failure configuration for PARSE, DESCRIBE, and EXECUTE operations in PostgreSQL extended query protocol.	2 months ago
Rahim Kanji	27119169e4	Reset extended query frame if an unsupported message type is received	2 months ago
Rahim Kanji	7a062a3444	Add PgSQL notice handling in reset session paths Register the PostgreSQL notice handler during reset session operations. Previously, the handler was not set in this path, which could result in unhandled backend notices.	2 months ago
Rahim Kanji	1ffb4f13ac	Fix PostgreSQL resync error detection Add flush() call in resync_start() for immediate socket error detection instead of deferring to event loop	2 months ago
Wazir Ahmed	daa0b2037e	fix: Use consistent value representation in MCP query rules `mcp_query_rules` and `runtime_mcp_query_rules` uses different representations for the same fields, causing the web UI to always report config differences even after loading to runtime. - Use `-1` sentinel for nullable int fields (`flagOUT`, `timeout_ms`, `log`) so `NULL` values from main are preserved when written to runtime, following the `MySQL QP_rule_t` pattern. - Serialize `re_modifiers` bitmask back to `VARCHAR` (`1→"CASELESS"`) to match the format used in main table - Update `evaluate_mcp_query_rules()` to handle tri-state log field Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Wazir Ahmed	c05bc66655	fix: MCP variables overwritten due to incorrect flush logic `flush_mcp_variables___runtime_to_database()` ignores the `replace` parameter. The prepared statement is hardcoded to `REPLACE INTO`, so even when callers pass `replace=false` (e.g. `GenericRefreshStatistics`), the function overwrites values in memory config with stale runtime values. Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	2 months ago
Rene Cannao	f29a326ca0	Fix QueryDigestTopK heap comparator semantics	2 months ago
Rene Cannao	3e73787753	Revert "fix: Handle optimizer hints /+ / correctly in query tokenizers" This reverts commit `178f679fad`.	2 months ago
Rahim Kanji	176362c77d	Addressed feedback from AI review	2 months ago
Rahim Kanji	a82d653c0b	Handle late COPY protocol messages after session exits fast_forward mode When a COPY FROM STDIN operation encounters an error, the session switches back to normal mode. However, the client may have already pipelined CopyData('d'), CopyDone('c'), or CopyFail('f') messages that are still in the input queue. Previously, these messages fell through to the default case, generating a spurious "Feature not supported" error. This change adds explicit handling to discard these messages when session_fast_forward == SESSION_FORWARD_TYPE_NONE, preventing the race condition from causing errors. The client does not expect a response for these messages in this scenario.	2 months ago
Rene Cannao	6be9dd1bfa	fix: Address AI code review feedback from PR #5410 - Fix Top-K heap comparator in Query_Processor.cpp: use 'worse' comparator so heap top is the worst candidate (not best), enabling proper Top-K selection - Add packet/message size guards in MySQLFFTO and PgSQLFFTO on_server_data() to prevent memory exhaustion from large result sets - Add _exit(1) in utils.cpp when /dev/null open fails to prevent FD pollution - Add NULL checks and consume query result in test_ffto_bypass-t.cpp - Fix TAP message formatting in mcp_show_connections_commands_inmemory-t.cpp - Add run_admin_checked() helper in pgsql-issue5384-t.cpp for proper error handling	2 months ago
Rene Cannao	178f679fad	fix: Handle optimizer hints /+ / correctly in query tokenizers The query tokenizers for both MySQL and PostgreSQL did not correctly handle optimizer hint comments in the format /+ ... /. When parsing queries like `/+ hostgroup=1000 / SELECT 1`, the '+' character was incorrectly included in the extracted first comment content, resulting in the parsed key being '+hostgroup' instead of 'hostgroup'. This caused the query_processor_first_comment_parsing variable (modes 1 and 3) to not work correctly when using optimizer hint syntax. Changes: - c_tokenizer.cpp: Detect both /! and /+ comment formats - pgsql_tokenizer.cpp: Detect /*+ comment format - issue5384-t.cpp: Re-enable tests 2 and 3 (previously skipped) - pgsql-issue5384-t.cpp: Re-enable tests 2 and 3, add hostgroup 1000 setup Fixes #5413 (MySQL tokenizer) Fixes #5414 (PostgreSQL tokenizer)	2 months ago
Rene Cannao	70647fb426	fix: Remove unused legacy mcp-mysql_* variables These variables were deprecated in favor of profile-based routing but were never removed from the code. They existed in the struct definition, getters, and setters but were not consumed anywhere - Query_Tool_Handler uses target_auth_map via mcp_auth_profiles and mcp_target_profiles. Removed: - mcp-mysql_hosts, mcp-mysql_ports, mcp-mysql_user, mcp-mysql_password, mcp-mysql_schema from MCP_Thread.h struct - Variable names from mcp_thread_variables_names array - Initialization, cleanup, getters, and setters in MCP_Thread.cpp - Documentation in doc/MCP/VARIABLES.md	2 months ago
Rene Cannao	9b5d52308f	fix: Use legacy prepare_v2 for conditional statement preparation Use the legacy db->prepare_v2(const char, sqlite3_stmt*) overload for the runtime_global_variables statement, which allows conditional preparation only when the runtime flag is set. Properly finalize the statement when done.	2 months ago
Rene Cannao	de60fe2b3f	fix: Use db->execute() for runtime_global_variables inserts Simplified the code to use db->execute() instead of prepared statements for runtime_global_variables inserts. This avoids complex unique_ptr deleter type matching issues and the table not existing during early initialization.	2 months ago
Rene Cannao	7479f2168e	fix: Only prepare runtime_global_variables stmt when runtime=true The runtime_global_variables table may not exist during early initialization, so we should only prepare the statement for it when the runtime flag is true. This fixes a crash on startup when init_mcp_variables() is called before the admin database schema is fully initialized.	2 months ago
Rene Cannao	8b1fb84d5c	fix: Populate runtime_global_variables for MCP variables The MCP variables were not being exposed in runtime_global_variables table after LOAD MCP VARIABLES TO RUNTIME. This fix: 1. Adds runtime_global_variables handling to flush_mcp_variables___runtime_to_database: - Clears existing mcp-* entries from runtime_global_variables when runtime=true - Inserts current runtime values into runtime_global_variables 2. Calls flush_mcp_variables___runtime_to_database with runtime=true from flush_mcp_variables___database_to_runtime to ensure the runtime table is populated after variables are loaded to runtime. This matches the behavior of other variable modules (admin, ldap, mysql, pgsql).	2 months ago
Rene Cannao	e53d2c76f9	Address PR #5410 review findings across FFTO, sessions, TAP, and docs Apply actionable bot review feedback from PR #5410 without behavior drift:\n- fix MySQL/PgSQL FFTO digest normalization and max-length hashing\n- add early FFTO packet/message size guards for bypass safety\n- restore MySQL session GTID reset and harden GenAI async error ownership\n- add null-check for stripped KILL query normalization path\n- call FFTO on_close() before observer reset/bypass in session flows\n- fix processlist query-options default pagination limit semantics\n- fix TAP noise_failures locking race and noise-aware plan count\n- extend wait_get_enpoint_ready with optional basic-auth passthrough\n- update MCP architecture docs from observe->stats naming\n- clean corrupted character in pgsql query-cache test comment\n\nValidation run:\n- git diff --check\n- make -C test/tap/tap tap.o utils_mariadb.o utils_mysql57.o utils_mysql8.o -j4\n- make -C lib obj/MySQLFFTO.oo obj/PgSQLFFTO.oo obj/MySQL_Session.oo obj/PgSQL_Session.oo obj/Query_Processor.oo -j4	2 months ago
Rene Cannao	79c0b383e8	integration: fix pre-CI issues in unified branch	2 months ago
Rene Cannao	acef17a8c1	Merge branch 'v3.0-ff_inspect' into v3.0-unified-large-pr # Conflicts: # test/tap/tests/Makefile	2 months ago
Rene Cannao	e2ebc0c449	Merge branch 'v4.0-mcp-stats2' into v3.0-unified-large-pr	2 months ago
Rene Cannao	54bcb5eeca	Merge branch 'v3.0-5384' into v3.0-unified-large-pr	2 months ago
Rene Cannao	90462f6d5a	ffto: harden MySQL/PgSQL observer state handling and align tests/docs Address outstanding review findings for FFTO on v3.0-ff_inspect and tighten protocol-state correctness for both engines. MySQL FFTO - Restrict on_close() reporting to true in-flight states and always clear query tracking state after close. - Add explicit active-query cleanup helpers and invoke them on state transitions to IDLE. - Preserve accounting on mid-resultset server ERR packets by reporting current query in READING_COLUMNS/READING_ROWS before reset. - Keep prepared-statement lifecycle cleanup robust (pending prepare cleared on prepare completion paths). MySQL session integration - Extract duplicated FAST_FORWARD client FFTO feed logic into observe_ffto_client_packet() and reuse it from all call sites. PostgreSQL FFTO - Replace regex-based CommandComplete parsing with lightweight token parsing, including NUL/whitespace trimming and strict numeric validation. - Add queued tracking for pipelined extended-protocol executes so query text and response attribution stay aligned under Parse/Bind/Execute pipelining. - Distinguish finalize semantics (execute-finalize on CommandComplete vs sync-finalize on ReadyForQuery) and centralize finalize/activation helpers. - Add frontend Close ('C') handling to evict statement/portal mappings. - Harden client/server message parsing with additional length checks. - Extend affected-row command tag coverage to COPY and MERGE. TAP tests - Stabilize test plans for failure paths by replacing early returns with a fail-and-skip-remaining flow and shared cleanup labels. - Ensure both MySQL and PgSQL FFTO tests preserve planned assertion counts under setup/prepare/execute failures. Documentation - Align FFT0 design doc state/response descriptions with current implementation (ReadyForQuery handling, pipelined queueing, supported PG command tags). - Fix wording/typo issues in protocol section. Validation performed - make -C lib -j4 - make -C test/tap/tests test_ffto_mysql-t test_ffto_pgsql-t -j4 Runtime execution of the two TAP binaries remains environment-dependent (admin endpoint connectivity required).	2 months ago
Rene Cannao	5519080ac2	mcp stats: address review findings and remove --genai CLI flag	2 months ago
Rene Cannao	5988468521	Query Processor: re-initialize parser on rewritten queries and enhance test coverage - Fixed Query Processor to re-extract comments and re-compute digest if a query rule rewrites the query. - Enhanced issue5384-t with better regex, robust NULL checks, and teardown logic. - Added pgsql-issue5384-t to provide parity coverage for the PostgreSQL module. - Registered the new test in groups.json.	2 months ago
René Cannaò	2b710e518f	Merge pull request #5401 from sysown/v3.0_fix-pgsql-extended-query-routing_5387 Revert "Reset current_hostgroup to default when no query rule matches"	2 months ago
Rene Cannao	3ccf0982e6	AI: Fix retry logic bug and synchronize TAP tests - Fixed a bug in LLM_Bridge (LLM_Clients.cpp) where negative max_retries would prevent the initial API call from being made. - Improved numeric range validation in TAP tests by replacing atoi() with strtol() to correctly reject non-numeric suffixes (e.g., "50abc"). - Adjusted API key format validation in tests to match actual test data lengths for OpenAI and Anthropic prefixes. - Enhanced URL validation to correctly reject hosts starting with colons. - Updated test plans and added missing test cases to achieve full synchronization between planned and executed tests in: - ai_llm_retry_scenarios-t - ai_error_handling_edge_cases-t - ai_validation-t	2 months ago
Rene Cannao	3240a3a942	Fix SIGSEGV caused by double-finalize of sqlite3_stmt	2 months ago
René Cannaò	3647678193	Merge pull request #5399 from sysown/v3.0_3596_3597 Tokenizer: fix type mismatch for grouping limit variables	2 months ago
René Cannaò	1dbe9fde97	Merge pull request #5385 from sysown/v3.0-2233 Fix #2233: Mirror sessions destination_hostgroup overwritten by fast routing	2 months ago
Javier Jaramago Fernández	ba5af979ff	feat-wip: Add replication lag support for PostgreSQL monitoring	2 months ago
Rene Cannao	1c25787b88	Introduce {mysql,pgsql}-query_processor_first_comment_parsing variable (#5384 ) This universal fix allows controlling when the first comment of a query is processed relative to the query rules. By setting this variable to 1, ProxySQL-specific annotations (like GTID) can be parsed immediately, allowing subsequent query rules to strip them from the query string. This prevents prepared statement cache bloat and improves backend statement reuse when annotations with unique literals are used.	2 months ago
Rene Cannao	ca73b9eced	Tokenizer: fix type mismatch for grouping limit variables Fixes issues #5396 and #5397. The variables mysql_thread___query_digests_grouping_limit and mysql_thread___query_digests_groups_grouping_limit (and their PgSQL counterparts) were incorrectly declared as bool instead of int in the tokenizer files. This caused any value greater than 0 to be treated as 1, effectively forcing a hardcoded grouping limit of 1 regardless of user configuration. By correcting the types to int, the tokenizer now correctly honors the configured values. Also added regression tests to regular_tokenizer_digests.hjson.	2 months ago
Rene Cannao	797d4b580c	mcp stats: move show_users to in-memory auth snapshots Rework stats.show_users so it no longer queries runtime-populated stats tables via admindb. The tool now reads user connection counters directly from authentication runtime structures, matching the direction taken for other MCP stats tools that must avoid stale stats schema reads. Implementation details: - Replaced show_users SQL path over stats_mysql_users/stats_pgsql_users with in-memory collection from GloMyAuth::dump_all_users(..., false) and GloPgAuth::dump_all_users(..., false). - Preserved Admin semantics by excluding internal/admin-style accounts (default_hostgroup < 0). - For MySQL, included LDAP user counters from GloMyLdapAuth->dump_all_users() to keep parity with stats___mysql_users population behavior. - Added deterministic argument handling for db_type validation and pagination bounds (limit capped to 1000, offset clamped to >= 0). - Kept output contract unchanged (username, frontend_connections, frontend_max_connections, utilization_pct, status) and ordering by frontend_connections DESC then username ASC. Documentation and tests: - Added extensive doxygen comments describing in-memory data sources, filtering semantics, and result construction in show_users implementation. - Extended TAP test mcp_show_connections_commands_inmemory-t with show_users coverage for MySQL and PgSQL, including payload shape checks and username filter validation. - Updated TAP plan count accordingly. - Included current tap groups updates present in working tree (test_ffto_* entries in groups.json), as requested.	2 months ago
Rene Cannao	1258a1f2f2	Address PR reviews: improve performance, safety, and robustness of FFTO	2 months ago
Rene Cannao	db04a54c92	Fix memory corruption and stack overflow in FFTO due to large queries	2 months ago
Rahim Kanji	194e20b3e8	Revert "Reset current_hostgroup to default when no query rule matches" This reverts commit `1b3d20388e`.	2 months ago
Rene Cannao	5d786520b0	Merge remote-tracking branch 'origin/v3.0' into merge/v3.0-into-v3.0-5243 # Conflicts: # include/PgSQL_Logger.hpp # lib/Makefile # lib/PgSQL_Logger.cpp # lib/ProxySQL_Admin.cpp # test/tap/groups/groups.json	2 months ago
Rene Cannao	5d45d17456	mcp stats: split connection metrics from debug free-pool snapshots Refactor MCP stats connection tools so operational pool metrics remain lightweight while debug-level free-connection details are exposed through a dedicated gated tool. Changes in this commit: - Updated stats tool catalog and dispatch to add show_free_connections and keep show_connections focused on per-server pool metrics only. - Removed free-connection payload from show_connections and added explicit compatibility error when callers still pass detail=true, with guidance to use show_free_connections. - Implemented show_free_connections using in-memory hostgroup manager snapshots (MySQL and PgSQL) with hostgroup/server filtering and summary counters. - Added MCP runtime variable mcp-stats_enable_debug_tools (default false), including variable registration, getter/setter handling, and config default in proxysql.cfg. - Added extensive doxygen comments across modified code paths to document behavior, rationale, filters, and output contracts. - Added TAP coverage in mcp_show_connections_commands_inmemory-t for: show_commands baseline, show_connections aggregate-only contract, debug tool gating behavior, and enabled-path validation for show_free_connections on both MySQL and PgSQL. - Registered the new TAP test in test groups.	2 months ago

1 2 3 4 5 ...

5091 Commits (v3.0_pgsql_sslkeylog_5281)