proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	8d12befb5f	Add transaction state unit tests + pattern rule (Phase 3.8, #5496 ) 17 test cases: persistence disabled, txn start/end, no-change cases, full lifecycle (BEGIN→query→COMMIT), timeout exceeded/not/disabled. Also replaces individual Makefile rules with pattern rule.	3 months ago
René Cannaò	98249bcd5a	Add hostgroup routing unit tests + Makefile pattern rule (Phase 3.5, #5493 ) 20 test cases: basic routing, transaction affinity, lock acquire/enforce, locking disabled, transaction+lock interaction, edge cases. Also replaces all individual unit test build rules with a single pattern rule (%-t: %-t.cpp) — adding new tests now only requires appending the name to UNIT_TESTS.	3 months ago
René Cannaò	7e49c41975	Address review feedback on server selection (PR #5508 ) - Fix truncation: use uint64_t modulo instead of unsigned int cast when computing target from total_weight (prevents skewed selection when total_weight > UINT_MAX) - Remove unused #include <cstdlib> - Add docstring note about max_latency_us=0 semantics: in production this means "use thread default", this extraction treats it as "no limit" — callers should resolve defaults before populating the struct - Remove trailing "fix" comment from test	3 months ago
René Cannaò	7697d4f43e	Add server selection unit tests (Phase 3.4, #5492 ) 21 test cases covering: - Eligibility: all 5 status types, max_connections, latency, repl lag, disabled limits (max=0) - Selection: single server, empty list, all offline, weight=0 - Weighted distribution: equal weights → ~50/50, 3:1 → ~75/25 (statistical verification over 10000 iterations) - Determinism: same seed produces same result - Mixed eligibility: only eligible server selected 100% of the time	3 months ago
René Cannaò	99980ca196	Address review feedback on monitor health (PR #5507 ) - Fix integer overflow: cast shun_recovery_time_sec to int64_t before multiplying by 1000 to prevent overflow for large values (>24 days) - Add docstring note about production lag==-2 override path (issue #959) not covered by this simplified extraction - Remove trailing "fix plan" comment from test	3 months ago
Rene Cannao	60e1d03442	Fix admin connection and authentication in TAP tests Address PR #5470 review feedback: - max_connections_ff-t: Use cl.admin_host for admin connection - test_query_rules_routing-t: Use cl.admin_host for admin connection - test_tsdb_api-t: Use stats:stats credentials for web dashboard, admin credentials for REST API (they use separate auth)	3 months ago
René Cannaò	24db561c09	Add monitor health unit tests (Phase 3.3, #5491 ) 31 test cases covering all monitor health decision branches: - Connect error shunning: threshold computation, boundary values - Unshun recovery: time elapsed, timeout cap, kill_all drain check, recovery disabled, clock skew, min 1s floor - Replication lag shunning: threshold, consecutive count, disabled, unknown lag, boundary - Replication lag recovery: below/at/above threshold, unknown lag	3 months ago
René Cannaò	f772c104de	Add HostGroups Manager unit tests (Phase 2.6, #5478 ) Unit tests for MySQL_HostGroups_Manager and PgSQL_HostGroups_Manager covering 17 test cases. Runs in <0.01s with no infrastructure deps. Test coverage: - Server creation via create_new_server_in_hg() (single, multiple in same HG, different HGs) - Server removal via remove_server_in_hg() (existing, non-existent) - shun_and_killall() (existing server returns true, non-existent false) - set_server_current_latency_us() (latency tracking without crash) - Multiple hostgroups independence (shunning in one HG doesn't affect another) - Duplicate server handling - PgSQL: create, remove, and shun operations with PgSQL-specific types (PgSQL_srv_info_t, PgSQL_srv_opts_t) Infrastructure: - New test_init_hostgroups() / test_cleanup_hostgroups() helpers in test_init.h/.cpp - Creates real MySQL_HostGroups_Manager and PgSQL_HostGroups_Manager with internal SQLite3 databases - Requires Prometheus registry (auto-created if nullptr) Note: Methods like shun_and_killall() and set_server_current_latency_us() acquire their own write locks internally — callers must NOT hold the lock beforehand or a deadlock occurs.	3 months ago
René Cannaò	666eb4a75c	Address review feedback on rule matching unit tests (PR #5503 ) - Add test case for null session username: verifies that a rule with a username filter correctly rejects when session username is nullptr (+1 test, plan updated to 23)	3 months ago
René Cannaò	aae1ad4019	Fix rule matching extraction: proper unit tests with harness Fixes the Copilot-generated PR #5501 test file: - Remove misplaced test from test/tap/tests/ (wouldn't link against libproxysql.a with the default TAP build rules) - Add proper unit test at test/tap/tests/unit/rule_matching_unit-t.cpp using the test harness (test_globals.h, test_init.h) - 22 test cases covering all matching criteria: flagIN, username, schemaname, client_addr wildcard, proxy_addr/port, digest, match_digest (RE2 + PCRE), match_pattern, negate_match_pattern, CASELESS modifier, rewritten query, combined AND logic, null rule - Register in unit test Makefile Production code (rule_matches_query extraction) cherry-picked from Copilot's original commit — no changes to the extraction itself.	3 months ago
copilot-swe-agent[bot]	0477a5b355	test: fix wildcard prefix setup Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/15475838-0841-46d6-9afd-ebdc5847a3ae	3 months ago
copilot-swe-agent[bot]	54a2af325f	refactor: extract query rule matching helper Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/15475838-0841-46d6-9afd-ebdc5847a3ae	3 months ago
René Cannaò	7a0026fc03	Address review feedback on connection pool unit tests (PR #5502 ) - ConnectionPoolDecision.h: expand docstring for calculate_eviction_count to clarify max_connections=0 edge case behavior - connection_pool_unit-t.cpp: check test_init_minimal() return code instead of ignoring it (+1 test, plan updated to 23)	3 months ago
René Cannaò	37ce0525bb	Fix connection pool extraction: separate header, proper unit tests Fixes the Copilot-generated PR #5500 production code and test file: Production fixes: - Create standalone ConnectionPoolDecision.h header with the struct and function declarations (no circular dependency issues) - Include ConnectionPoolDecision.h in MySrvConnList.cpp and PgSQL_HostGroups_Manager.cpp to resolve compilation errors - Replace inline declarations in Base_HostGroups_Manager.h with #include "ConnectionPoolDecision.h" Test fixes: - Remove misplaced test from test/tap/tests/ (tested reimplemented copies of functions instead of the real code) - Add proper unit test at test/tap/tests/unit/connection_pool_unit-t.cpp using the test harness (test_globals.h, test_init.h) - 22 test cases covering eviction, throttling, pool state decisions, warming, and edge cases - Register in unit test Makefile	3 months ago
copilot-swe-agent[bot]	5e8b1e3e5a	Extract connection pool decision logic into pure functions (MySQL + PgSQL) Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/89d35f54-3313-48d4-8252-70e3c1f3b036	3 months ago
René Cannaò	051435f810	Address review feedback on auth unit tests (PR #5485 ) - Add null guards before strcmp() in test_mysql_add_overwrites and test_mysql_frontend_backend_separation to prevent segfaults on unexpected lookup failures - Fix misleading "skipped - null" message in SHA1 test fallback to clearly indicate an unexpected null - Free sha1 pointer in PgSQL lookup test to prevent potential memory leak if sha1_pass is ever set - Enhance test_mysql_clear_text_password to verify stored PRIMARY and ADDITIONAL passwords are actually retrievable via lookup(), not just that set_clear_text_password() returns true (2 new test cases, plan updated from 58 to 60)	3 months ago
René Cannaò	a968b049a2	Add auth_unit-t to unit test Makefile Registers the Authentication unit test binary in the build system so it is built alongside smoke_test-t via 'make build_tap_tests'.	3 months ago
René Cannaò	2e52deffd4	Add MySQL/PgSQL Authentication unit tests (Phase 2.2, #5474 ) Comprehensive unit tests for MySQL_Authentication and PgSQL_Authentication covering 58 test cases across 13 test functions. Runs in <0.01s with no infrastructure dependencies. MySQL_Authentication coverage: - Core CRUD: add/exists/lookup/del with frontend and backend users - Duplicate handling: add() overwrites password, hostgroup, max_connections - exists() only checks frontends (not backends) — documented quirk - lookup() returns empty struct for nonexistent users - SHA1 credential storage and retrieval via set_SHA1() - Clear-text password management (PRIMARY and ADDITIONAL slots) - Connection counting: increase/decrease with max_connections enforcement - Bulk operations: set_all_inactive + remove_inactives config reload pattern - reset() clears all frontend and backend users - Runtime checksum: zero when empty, changes on add/modify - Memory tracking: increases on add, returns to baseline on reset - Frontend/backend separation: same username, different credentials PgSQL_Authentication coverage: - Core CRUD with PgSQL-specific lookup() signature (returns char*) - del() and reset() behavior - Connection counting (no PASSWORD_TYPE parameter) - Inactive pattern (set_all_inactive + remove_inactives)	3 months ago
René Cannaò	045ff26068	Address review feedback on protocol unit tests (PR #5488 ) - test_decode_length_3byte: pad buffer to 5 bytes (CPY3 reads 4 bytes via uint32_t* cast from buf+1, causing OOB read with 4-byte buffer) - test_cpy3: use 4-byte buffers with padding to avoid OOB read - test_encode_decode_roundtrip: initialize prefix[0]=0 each iteration to avoid UB when mysql_encode_length doesn't write for 1-byte values - test_mysql_query_digest: free first_comment between calls to prevent memory leak (malloc'd by digest function when comment present) - test_pgsql_query_digest: use strlen() instead of hardcoded q_len to avoid off-by-one, free first_comment after use - test_escape_single_quotes: fix misleading comment — function returns original pointer (not copy) when no quotes are present	3 months ago
René Cannaò	e6e8590209	Add protocol_unit-t to unit test Makefile	3 months ago
René Cannaò	a7424f0abe	Add protocol encoding/decoding and utility unit tests (Phase 2.5, #5477 ) Unit tests for standalone protocol functions and utility routines covering 43 test cases across 11 test functions. Runs in <0.01s with no infrastructure dependencies. Test coverage: - MySQL length-encoded integer decoding: 1-byte (0-250), 2-byte (0xFC prefix), 3-byte (0xFD prefix), 8-byte (0xFE prefix) - MySQL length-encoded integer encoding: boundary values at each encoding tier (251, 65535, 65536, 16777216) - Encode/decode roundtrip: 10 values across all encoding ranges survive write_encoded_length() → mysql_decode_length_ll() - mysql_hdr packet header: structure size (4 bytes), field packing, 24-bit max length - CPY3/CPY8 byte copy helpers: little-endian semantics, boundary values - MySQL query digest: normalization via mysql_query_digest_and_first_ comment_2(), whitespace collapsing, comment handling, empty query - PgSQL query digest: normalization via pgsql_query_digest_and_first_ comment_2(), whitespace collapsing - escape_string_single_quotes: no-op on clean strings, single quote doubling, multiple quotes - mywildcmp wildcard matching: exact match, % prefix/suffix/both, _ single char, non-match cases, empty string edge cases	3 months ago
René Cannaò	b25cf6d54f	Address review feedback on query processor unit tests (PR #5487 ) - test_mysql_reset_all: remove 2 leaked mysql_simple_rule() calls whose return values were discarded (memory leak under ASAN) - test_mysql_rule_creation: fix misleading "Don't free" comment — rule is NOT inserted into QP and IS freed manually - test_init.cpp: free individual strings from get_variables_list() before freeing the array (was leaking all variable name strings) - test_init.cpp: fix misleading comment claiming GloMTH/GloPTH are cleaned up by test_cleanup_minimal() — they rely on process exit	3 months ago
René Cannaò	c57bd36e98	Add query_processor_unit-t to build and fix QP initialization - tests/unit/Makefile: Register query_processor_unit-t in build system - test_init.cpp: Create MySQL_Threads_Handler and PgSQL_Threads_Handler in test_init_query_processor() since QP constructors read variables from GloMTH/GloPTH. Trigger lazy initialization of VariablesPointers maps via get_variables_list() before constructing QP instances. Add extern declaration for GloPTH (not declared in any header).	3 months ago
René Cannaò	76f1f2f5cd	Add Query Processor rule management unit tests (Phase 2.4, #5476 ) Comprehensive unit tests for MySQL_Query_Processor and PgSQL_Query_ Processor covering 42 test cases across 10 test functions. Runs in <0.01s with no infrastructure dependencies. Test coverage: - Rule creation via new_query_rule() with all 35 fields verified - Rule field storage: username, schemaname, match_digest, match_pattern, destination_hostgroup, cache_ttl, timeout, retries, sticky_conn, multiplex, apply, log, client_addr, comment - Regex modifier parsing: CASELESS, GLOBAL, combined (CASELESS,GLOBAL) - Rule insertion, sorting by rule_id, and commit - Rule retrieval via get_current_query_rules() SQLite3 result - Sort verification: rules inserted in reverse order, sorted ascending - Special fields: error_msg, OK_msg, replace_pattern - flagIN/flagOUT chaining setup - Username filter rules - reset_all() clears all rules - get_stats_commands_counters() returns valid result - PgSQL rule creation, insertion, and reset Note: Full process_query() testing requires a MySQL_Session with populated connection data, which is beyond isolated unit tests. The existing E2E TAP tests cover those scenarios.	3 months ago
René Cannaò	bcba8039cd	Address review feedback on query cache unit tests (PR #5486 ) - test_pgsql_flush: flush() at start for clean state, assert == 10 - test_mysql_construction_and_flush: fix tautology (flushed == 0 \|\| flushed >= 0 is always true for uint64_t), double-flush to ensure empty cache, then assert == 0 - test_pgsql_purge_expired: use max_memory_size=1 instead of 1GB to force the purge path to actually run (3% threshold wasn't reached) - test_pgsql_many_entries: fix misleading docstring claiming hash table distribution verification	3 months ago
René Cannaò	2ae866b59c	Add query_cache_unit-t to build and init Prometheus registry - tests/unit/Makefile: Register query_cache_unit-t in the build system - test_init.cpp: Create a real Prometheus registry in test_init_query_ cache() since the Query_Cache constructor registers metrics via GloVars.prometheus_registry (nullptr would crash)	3 months ago
René Cannaò	96387be177	Add Query Cache unit tests (Phase 2.3, #5475 ) Comprehensive unit tests for MySQL_Query_Cache and PgSQL_Query_Cache covering 26 test cases across 11 test functions. Runs in <0.01s with no infrastructure dependencies. PgSQL_Query_Cache is used for most tests because its set()/get() API is simpler (no MySQL protocol parsing required). The underlying Query_Cache<T> template logic is identical for both protocols. Test coverage: - Basic set/get cycle with value verification - Cache miss on nonexistent key - User hash isolation (same key, different user_hash = miss) - Cache replacement (same key overwrites previous value) - Hard TTL expiration (expire_ms in the past) - Soft TTL expiration (cache_ttl parameter to get()) - flush() clears all entries and returns correct count - Set/flush cycle (entry retrievable then unretrievable) - Stats counters (SET and GET via SQL3_getStats()) - SQL3_getStats() result format (2 columns, has rows) - MySQL_Query_Cache construction, flush, and SQL3_getStats() - purgeHash() eviction of expired entries (live entries survive) - Bulk insert (100 entries) across 32 internal hash tables Key implementation note: Query_Cache constructor requires a valid Prometheus registry (GloVars.prometheus_registry). The test_init_ query_cache() helper creates one automatically.	3 months ago
Rene Cannao	ca409366cb	Address review feedback on TSDB tests - Use cl.admin_host instead of cl.host for admin HTTP endpoints - Don't log auth credentials (security issue) - Fail fast when prerequisite SET/LOAD commands fail - Assert on specific test_downsample_metric rows in hourly table	3 months ago
René Cannaò	b187f9ac96	Address review feedback on test harness (PR #5482 ) Fixes from Copilot and Greptile review comments: - test_globals.cpp: Replace fixed-size datadir_buf[256] with std::string to avoid truncation on long TMPDIR paths - test_globals.cpp: Initialize glovars.has_debug to match build type (DEBUG vs release) so component constructors that validate debug compatibility do not abort - test/tap/Makefile: Remove 'tap' dependency from unit_tests target since unit tests compile tap.o directly and don't need the full libtap.so/cpp-dotenv build chain. Also remove $(MAKECMDGOALS) pass- through which would cause failures when invoked as 'make unit_tests' - tests/unit/Makefile: Fix default goal — make 'all' the first target so 'make' without arguments builds unit tests correctly	3 months ago
Rene Cannao	809878c253	Fix TSDB TAP tests for Docker-based CI test_tsdb_variables-t: - Add verbose logging for downsampling test - Insert test data with timestamps from 2 hours ago before downsampling - The TSDB downsample logic only processes completed hours, so we need historical data for the test to succeed - Add cleanup of test data after the test test_tsdb_api-t: - Use configurable host from environment (cl.host) instead of hardcoded 127.0.0.1 - Add verbose logging for configuration and test progress - Use proper authentication credentials from command line - Increase retries for dashboard endpoint - Add detailed error messages Fixes #5483	3 months ago
René Cannaò	43c04fb394	Add unit test Makefile and smoke test Adds the build system and initial smoke test for the unit test framework (Phase 2.1, #5473). - test/tap/tests/unit/Makefile: Compiles unit test binaries linked against libproxysql.a + test_globals.o. Compiles tap.o directly from tap.cpp to avoid the cpp-dotenv dependency chain, making unit tests buildable on both Linux and macOS. Handles platform-specific linker flags (Darwin vs Linux). - test/tap/tests/unit/smoke_test-t.cpp: Validates the test harness by exercising test_init_minimal() (GloVars setup), test_init_auth() (MySQL_Authentication add/lookup/exists cycle), and idempotency of all init/cleanup functions. Runs in <1 second with no Docker or network dependencies.	3 months ago
Rene Cannao	186ce308c6	Fix test_sqlite3_pass_exts plan for MySQL version differences Move plan() call after MySQL version detection to set correct test count: - MySQL 8.0+: 2213 tests (includes BY RANDOM PASSWORD tests) - MySQL 5.7: 2012 tests (skips BY RANDOM PASSWORD tests) Previously the test always planned 2213 tests, causing TAP failures when running against MySQL 5.7 because only 2113 tests executed.	3 months ago
Rene Cannao	4a0300f844	Fix test_query_rules_routing for Docker-based CI - complete fix Two additional issues fixed: 1. Query hint hostgroup: ProxySQL query hints like /* ;hostgroup=0;... */ were hardcoded to hostgroup 0. Now dynamically replaced with the discovered writer hostgroup. 2. Also removed hardcoded TAP_MYSQLPASSWORD=root from test_sqlite3_pass_exts-t.env to allow infrastructure-provided password to be used.	3 months ago
Rene Cannao	e9a16550c6	Improve test_query_rules_routing hostgroup discovery - Query runtime_mysql_users instead of mysql_users for default_hostgroup - Use mysql_replication_hostgroups to find writer/reader hostgroup pairs - Fallback to runtime_mysql_servers if no replication hostgroups configured - Remove hardcoded TAP_MYSQLPASSWORD from test_sqlite3_pass_exts-t.env These changes allow tests to work correctly with Docker-based CI infrastructure where hostgroups may differ from hardcoded defaults.	3 months ago
Rene Cannao	f2db3cbb1e	Fix test_sqlite3_pass_exts for Docker-based CI infrastructure Remove hardcoded TAP_MYSQLPORT=14806 from test .env files to use the infrastructure-provided port (3306). The hardcoded port was causing connection failures when tests run inside Docker containers.	3 months ago
Rene Cannao	7bbda48f29	Fix test_query_rules_routing for Docker-based CI infrastructure - Add dynamic hostgroup discovery from mysql_servers table - Replace hardcoded hostgroups (0, 1) with discovered ones (e.g., 1300, 1301) - Add comprehensive debugging output for troubleshooting: - Current server and user configuration - Discovered hostgroups - Query execution details (before/after counts) - Routing failures with specific queries The test was failing because it used hardcoded hostgroups 0 and 1, but the Docker CI infrastructure uses dynamic hostgroups (1300, 1301, etc.) depending on the infrastructure type.	3 months ago
Rene Cannao	e3ccdb7d12	Fix test_load_from_config_validation for Docker-based CI - Use REGULAR_INFRA_DATADIR environment variable for config file path (falls back to /tmp for local mode) - Add initial diag messages describing test purpose - Add step-by-step debugging messages during test execution - Update file header comment with test description This fixes the issue where ProxySQL running in a Docker container couldn't access config files created in /tmp on the test runner host.	3 months ago
Rene Cannao	9450bf52e2	Fix COM_STMT_CLOSE short packet handling	3 months ago
Rene Cannao	179644fed9	Fix ClickHouse test: use 0.0.0.0 interface for Docker compatibility The interface was set to 127.0.0.1 which is not accessible from another container. Changed to 0.0.0.0 which is replaced by the extract_module_host_port function with the correct hostname. Also update expected row count from 2 to 3 due to additional successful INSERT.	3 months ago
Rene Cannao	8ec472c771	Fix ClickHouse test: update expected row count after MergeTree fix After updating to new MergeTree syntax, the INSERT with NULL values now succeeds, resulting in 3 rows instead of 2.	3 months ago
Rene Cannao	3f91a44770	Fix ClickHouse tests: update MergeTree syntax and handle 0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.8ash - Added explicit `clickhouse-only` test group for isolated testing - Added quotes around hostname value in SET statements - Fixed 0.0.0 Docker.com doesn (including quotes around MergeTree syntax)	3 months ago
Rene Cannao	eac1adf7e1	Fix clickhouse tests for Docker-based CI infrastructure - Fix variable name: 'clickhouse-host' -> 'clickhouse-hostname' - Add quotes around hostname value in SET command - Handle 0.0.0.0 bind address: use 'proxysql' container hostname in Docker mode, or '127.0.0.1' for local execution	3 months ago
Rene Cannao	010b053c0c	Fix PROXY protocol v1 address overflow	3 months ago
Rene Cannao	96e5558732	Add unterminated HandshakeResponse TAP regression	3 months ago
Rene Cannao	3acd6b31d6	Fix max_connections_ff-t: Use dynamic hostgroup discovery - Add discover_user_hostgroup() helper function to query default_hostgroup from mysql_users table instead of hardcoding hostgroup=0 - Update test_ff_sess_exceeds_max_conns() to use discovered hostgroup - Update test_ff_only_one_free_conn() to use discovered hostgroup - Update documentation to reflect dynamic hostgroup discovery - Add test/README.md with local CI execution instructions This allows the test to work with any infrastructure configuration (e.g., isolated CI where sbtest1 uses hostgroup 1300 instead of 0).	3 months ago
Rene Cannao	7b875dfddd	Add malformed COM_CHANGE_USER TAP regression	3 months ago
Rene Cannao	3ac0c2dd8a	Fix legacy TAP tests: clickhouse_php_conn and reg_test_3317 - clickhouse_php_conn-t.php: Fix deprecated ClickHouse MergeTree syntax Change from deprecated ENGINE=MergeTree(EventDate, (EventDate), 8192) to new syntax ENGINE=MergeTree() ORDER BY (EventDate) - reg_test_3317-lock_hostgroup_special_queries-t.cpp: Add query annotations Add /* ;hostgroup=1300 */ hints to SELECT statements to ensure proper routing when connection is locked to hostgroup 1300	3 months ago
Rene Cannao	730f77e64e	test: add summary and step-by-step reporting to TLS stats TAP test	3 months ago
copilot-swe-agent[bot]	04c5e58e6b	fix: escape restapi config values Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/40d309f0-bd3d-4616-9cd6-fa7d8f1cb355	3 months ago
copilot-swe-agent[bot]	8d358cbfdc	feat: load restapi routes from config aliases Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com> Agent-Logs-Url: https://github.com/sysown/proxysql/sessions/40d309f0-bd3d-4616-9cd6-fa7d8f1cb355	3 months ago
Rene Cannao	cf54bff262	Fix docker-proxy-post.bash to use absolute path for .env sourcing The scripts were using relative path [ -f .env ] which failed when called from test/infra/control/, causing all SQL template variables (PREFIX, WHG, RHG, etc.) to be empty. This resulted in query rules with NULL match_digest patterns and incorrect rule IDs.	3 months ago
copilot-swe-agent[bot]	e274862857	feat: introduce stats_global table and move TLS metrics out of stats_mysql_global; add TAP tests - Add STATS_SQLITE_TABLE_GLOBAL definition (stats_global table for non-MySQL/PgSQL metrics) - Register stats_global in Admin_Bootstrap.cpp - Add stats___global() implementation and declaration; document with Doxygen comment - Remove TLS_* variables from stats___mysql_global() - they were misplaced there - Move all TLS tracking metrics to stats___global() under ssl_mutex - Wire up stats_global query detection and refresh in GenericRefreshStatistics() - Add TAP test test_tls_stats-t.cpp: - Verifies stats_global contains all 6 TLS tracking variables - Checks value ranges and validity of each TLS variable - Verifies stats_tls_certificates has 2 rows (server + ca) with correct fields - Verifies TLS_Load_Count increments and TLS_Last_Load_Timestamp increases after PROXYSQL RELOAD TLS - Confirms TLS variables are absent from stats_mysql_global Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	3 months ago
René Cannaò	540fa174b4	Merge pull request #5458 from sysown/copilot/support-zstd-compression Add MySQL protocol ZSTD compression support	3 months ago
Rene Cannao	834785e170	Merge branch 'private-origin/v3.0' into public/pr260319	3 months ago
René Cannaò	0c4e0cae6a	Merge pull request #8 from sysown/copilot/fix-tap-tests-legacy-g1 Fix legacy-g1 TAP tests broken by CI migration to per-container hostnames	3 months ago
sysown1	b354cb6639	fix(tests): Replace hardcoded 127.0.0.1 with env-driven host/port CI migration to Docker containers requires tests to use environment variables for host/port configuration instead of hardcoded localhost addresses. Changes: - test_cluster_sync-t.cpp: Use cl.host and cl.admin_port for DELETE queries - test_cluster_sync_mysql_servers-t.cpp: Use cl.host and cl.admin_port - test_read_only_actions_offline_hard_servers-t.cpp: Use cl.host and cl.admin_port - test_simple_embedded_HTTP_server-t.cpp: Use cl.host for HTTP requests The CommandLine class reads from TAP_ADMINHOST and TAP_ADMINPORT environment variables set by CI infrastructure, enabling tests to work in containerized environments where ProxySQL runs on a different hostname.	3 months ago
Rene Cannao	2fcfd648e5	Merge remote-tracking branch 'origin/v3.0' into copilot/support-zstd-compression # Conflicts: # test/infra/infra-mysql84/docker-compose-init.bash # test/tap/groups/groups.json	3 months ago
René Cannaò	1a0dea6da0	Merge pull request #5457 from sysown/copilot/fix-admin-credentials-logging Redact `admin-admin_credentials` from admin SET command logs	3 months ago
Rene Cannao	ffb610f4b8	Fix no-infra TAP group setup	3 months ago
Rene Cannao	c22056c37c	Finalize fixes and add TAP group for no-infra tests	3 months ago
Rene Cannao	d21c165ae9	Merge branch 'copilot/fix-proxysql-multiple-modules-port' into copilot/fix-admin-credentials-logging	3 months ago
Rene Cannao	4517edea78	Address review feedback and create no-infra TAP group - Fix retry loop in admin_set_credentials_logging-t.cpp to clear eofbit (CodeRabbit) - Fix spelling in lib/Admin_Handler.cpp (CodeRabbit) - Create new 'no-infra-g1' TAP group in groups.json - Add 'tests_no_infra' target to Makefiles to run tests without backends	3 months ago
René Cannaò	40716dcb46	Merge pull request #5455 from sysown/copilot/fix-proxysql-multiple-modules-port Fail fast on cross-module listener port conflicts	3 months ago
Rene Cannao	71c4742b56	Address review: improve listener parsing and startup failure integration - Corrected listener parsing to avoid misclassifying malformed TCP endpoints as UNIX sockets. - Refactored ProxySQL_Main_init_phase3___start_all() to return failure status instead of direct exit, enabling cleaner daemon shutdown and preventing unwanted restart loops. - Added regression test for malformed listener strings.	3 months ago
copilot-swe-agent[bot]	307fff98e0	Fix TAP tests failing in legacy/legacy-g1 after CI migration to per-container hostnames Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	3 months ago
copilot-swe-agent[bot]	ec44a15058	feat: add mysql protocol zstd compression support Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	3 months ago
copilot-swe-agent[bot]	14ac53379a	test: harden admin credential logging regression Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	3 months ago
copilot-swe-agent[bot]	b4cd4a198e	fix: redact admin credentials in set logging Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	3 months ago
Rene Cannao	e9b78ec572	Fix reg_test_3847_admin_lock for isolated CI runtime layout The legacy version of reg_test_3847_admin_lock assumed the old TAP execution model where everything effectively lived on 127.0.0.1 behind docker port mappings. In the new legacy-g2 infrastructure the test process and the primary ProxySQL run in separate containers, while the test still launches a second local ProxySQL instance inside the test container. That split exposed several test-side assumptions that were no longer valid and caused the child replica setup to fail before the actual deadlock coverage even started. The most important issue was how the secondary ProxySQL was started. The test passed a static proxysql_sec.cfg, but it did not give the child process an isolated datadir. On the new CI the child could therefore discover and reuse an existing proxysql.db from the default runtime location, which meant the tracked config file was not actually authoritative. The test would then wait for a replica on 127.0.0.1:26081 that never came up with the expected credentials or cluster topology. This change makes the secondary runtime explicit and self-contained. The test now creates a private runtime directory under test/tap/tests/reg_test_3847_node_datadir/runtime, generates the child config dynamically for the current environment, and launches the child with -D pointing at that runtime directory. The generated config keeps the local child replica on 127.0.0.1:26081/36081 while wiring the primary cluster peer to the real TAP admin endpoint discovered from CommandLine. That removes the stale single-host assumption and makes the test match how the isolated container environment is actually wired. The fix also cleans up endpoint usage inside the test body. Connections to the primary ProxySQL admin interface now use cl.admin_host/cl.admin_port instead of the generic frontend host, while the worker that talks to the locally spawned child explicitly targets 127.0.0.1:26081. This matters in the new CI because the primary lives in a different container but the child lives next to the test process. There was also a correctness bug in the thread bookkeeping. The previous code could overwrite a real worker error with success, and failed worker connections did not stop execution immediately. The worker status flags and launcher status are now atomic, connect failures return immediately, main-loop checks only treat positive errno values as failures, and shutdown waits report the live state instead of silently racing past it. Since this class of failure is expensive to diagnose remotely, the TAP diagnostics are intentionally much more verbose now. The test logs the primary and replica endpoints it is using, the generated config path, runtime directory, launcher capture log, internal ProxySQL log path, worker startup messages, periodic progress from the two background loops, wait-loop heartbeats, and shutdown progress. That should make future CI failures explain themselves from the TAP log instead of requiring ad hoc reproduction. Finally, add a local .gitignore entry for reg_test_3847_node_datadir/runtime/. That directory is generated by the test and contains transient databases, logs, and certificates for the spawned child ProxySQL instance; it should not be committed.	3 months ago
Rene Cannao	7384bea084	Fix reg_test_unexp_ping_pkt for isolated CI networking and Prometheus labels The reg_test_unexp_ping_pkt TAP failure on legacy-g2 was caused by multiple test-side issues that became visible after moving from host-local 127.0.0.1 execution with port mapping to isolated Docker containers on a private network. The first failure happened during the initial setup path: the test connected with ProxySQL root credentials and root host, but used cl.mysql_port instead of cl.root_port. In the old port-mapped layout this mistake could be masked more easily. In the isolated DNS-based setup used by legacy-g2, root/admin/frontend and backend ports are distinct and the mismatch causes an immediate connect failure. This change routes the setup connections through the correct ProxySQL root port and adds targeted connection diagnostics so future CI failures show the exact host, port, user, and MySQL error involved. The second failure was a latent prepared-statement bug in the test data loader. MYSQL_BIND.length pointed to a block-local variable that went out of scope before mysql_stmt_execute(), which led to intermittent or immediate client-side failures such as 'Client run out of memory' when inserting the large LONGTEXT payload used by the test. This change keeps the bound length alive for the full execution window and adds payload-size logging so the expensive setup phase is visible in TAP logs. The final failure was in metric validation, not in ProxySQL behavior. ProxySQL exports proxysql_mysql_unexpected_frontend_com_ping_total as a labeled Prometheus series, for example with {protocol="mysql"}. The test previously looked up the metric by exact key, which silently read zero from the parsed map and made the assertion fail even though ProxySQL was correctly detecting and handling the unexpected COM_PING packets. This change resolves the metric by prefix, records how many matching series were found, and logs the before/after values and delta explicitly. Verification: - rebuilt test/tap/tests/reg_test_unexp_ping_pkt-t - executed the test directly against the live legacy-g2 ProxySQL instance and observed ok 9 / exit 0 - executed the isolated CI-style path with TEST_PY_TAP_INCL=reg_test_unexp_ping_pkt-t via test/infra/control/run-tests-isolated.bash and observed PASS 1/294 : FAIL 0/294 This commit intentionally does not include unrelated orchestrator configuration edits that were already present in the worktree.	3 months ago
Rene Cannao	98c03d6fc6	Fix stale per-connection state tracking in set_testing-multi set_testing-multi batches 10 queries on the same MYSQL* connection, but it was still generating a fresh random connection index on every loop iteration. The test then used that random index for two different purposes that should have referred to the active batched connection instead:\n\n- logging conn_idx in the debug output\n- saving vars back into varsperconn\n\nThat meant 9 out of every 10 iterations could store one connection's accumulated expected session state into a different slot. When a later batch reused that slot, the test loaded stale or foreign expectations and reported a ProxySQL mismatch even though the backend and ProxySQL session state were correct.\n\nTrack the active connection index for the duration of each queries_per_connections batch and use it consistently when loading state, logging, and saving varsperconn. This makes the debug output trustworthy and prevents intermittent false failures such as the legacy-g2 set_testing-multi regression that appeared to implicate variable synchronization.	3 months ago
copilot-swe-agent[bot]	8e37bbaa52	Refine listener conflict validation Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	3 months ago
copilot-swe-agent[bot]	1dace933e2	Validate conflicting listener ports at startup Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	3 months ago
René Cannaò	8c4252814f	Merge branch 'v3.0-ci_84' into v3.0-ci_84_mysql84 Signed-off-by: René Cannaò <rene@proxysql.com>	3 months ago
Rahim Kanji	cac8dfaf2f	Fix charset_unsigned_int-t for MySQL 8.4	3 months ago
Rene Cannao	b9ee38360c	Clean up set_testing debugging and improve connection tracking - Remove GTID-specific debugging from set_testing.h and set_testing-multi-t.cpp - Remove verbose [DEBUG] prefixes from test logging - Add thread ID and connection index tracking to correlate queries with connections - Log expected_vars, mysql_vars, and proxysql_vars for each query execution - Simplify check_session_track_gtids function (remove debug logging) This provides cleaner logging to diagnose which client connection triggers variable errors like the wsrep_sync_wait issue.	3 months ago
Rene Cannao	8957dc99e4	Add debugging output to set_testing-multi-t test Added comprehensive debug logging to help diagnose session_track_gtids failures in set_testing-multi-t: - Log connection switching and reuse events - Track varsperconn state throughout test execution - Log all variable updates from test cases - Add detailed session_track_gtids comparison logging - Log ProxySQL internal session values - Add debug output to check_session_track_gtids function Also includes critical fix: save vars back to varsperconn after each test iteration to persist expected variable state across connection switches.	3 months ago
Rene Cannao	7c7def55e9	Add debugging to test_binlog_reader-t and add missing sbtest users - Add extensive debugging output to test_binlog_reader-t.cpp including: - Test description and purpose - Connection settings and credentials - Environment variable values - Detailed error diagnostics with troubleshooting steps - Additional logging in create_testing_tables() and perform_rnd_selects() - Add missing sbtest7 and sbtest8 users to infra-mysql57 proxysql config These users are required by test_binlog_reader-t and were present in the old CI infra-mysql57-binlog but missing in the new infra.	3 months ago
Rene Cannao	e582973ff8	Fix: Correct python33 shebang typo to python3	3 months ago
Rene Cannao	b91642c2c5	Fix: Update python shebang for regression test script Updated the shebang line in test/tap/tests/reg_test_3992_fast_forward_malformed_packet-pymysql-t.py from '#!/usr/bin/env python' to '#!/usr/bin/env python3'. This ensures the script correctly uses the 'python3' interpreter, resolving potential 'command not found' errors in environments where 'python' is not directly available or aliased to python2. The rest of the codebase appears to consistently use 'python3' shebangs.	3 months ago
Rene Cannao	06af3f6c61	Fix: Update python shebangs to python3 Updated shebang lines in several Python scripts from '#!/usr/bin/env python' to '#!/usr/bin/env python3'. This ensures that these scripts correctly use the python3 interpreter, which is standard in the environment and avoids 'command not found' errors for 'python'. Affected files: - docker/scenarios/repl1/test1.py - docker/scenarios/repl1/test1_.py - scripts/kill_idle_backend_conns.py - scripts/legacy/export_users.py - scripts/legacy/metrics.py - scripts/stats_scrapper.py - test/tap/tests/reg_test_3992_fast_forward_malformed_packet-pymysql-t.py	3 months ago
Rene Cannao	725575a913	Fix test_flush_logs-t for Dockerized and remote environments Reworked the log flushing TAP test to support environments where the test runner and ProxySQL are in separate containers: - Implemented 'Scheduler Hack': Since the test runner lacks docker CLI/daemon access, signaling SIGUSR1 is performed by injecting a temporary task into ProxySQL's own scheduler. This task uses /bin/sh to find the correct worker PID via 'pidof' and signals it internally. - Optimized Log Reading: Updated fn_get_rotations to prioritize the shared volume mount (/var/lib/proxysql) available in the runner, falling back to remote docker exec only if necessary. - Improved Path Resolution: Replaced the potentially infinite loop for locating ProxySQL root with a safe directory traversal. - Environment Support: Exported PROXY_CONTAINER in env-isolated.bash to allow tests to identify the target ProxySQL container. - Updated Orchestrator passwords in MySQL 5.7 infra to match current INFRA_ID derived credentials.	3 months ago
René Cannaò	3803f11077	Merge pull request #5381 from sysown/v3.0_pgsql_meta_command_describe_table Implement PostgreSQL \d tablename meta-command support (Admin interface)	3 months ago
Rahim Kanji	9ab9787c91	Addressed AI review feedback	3 months ago
Rahim Kanji	778d6d2978	Add multi-version testing across 14 PostgreSQL versions (16.x, 17.x, 18.x)	3 months ago
Rahim Kanji	8066070927	Add comprehensive version testing	3 months ago
Rahim Kanji	2046d92b70	Merge remote-tracking branch 'v3.0' into v3.0_pgsql_meta_command_describe_table	3 months ago
Rene Cannao	b4687daa74	Rollback test_binlog_reader-t.cpp to tag v3.0.5 The test_binlog_reader-t.cpp test was previously modified to attempt fixing issues in the new CI infrastructure. However, these fixes depended on the 'proxysql_mysqlbinlog' tool which is currently missing or not correctly provisioned in the new environment. As the previous attempts to workaround the missing tool by dynamically detecting hostgroups and enabling GTID ports did not lead to a passing test, we are rolling back this file to its known stable state from tag v3.0.5. This aligns with the requirement to maintain test integrity while the infrastructure provisioning for the binlog reader tool is addressed.	3 months ago
René Cannaò	9d921bdda3	Merge pull request #5444 from sysown/v3.0_unify-PR-5433-5442 Unify PR#5433 & 5442	3 months ago
Rene Cannao	8033f75edc	Restore test_unsupported_queries-t.cpp to original scope with CI stabilization - Surgically restore all original test logic, helper functions, and documentation from v3.0. - Re-implement self-provisioning of LOAD DATA test files to the shared ProxySQL volume. - Fix TAP plan count to match actual execution (15 tests). - Add descriptive header and granular diagnostics for environment context. - Ensure C++ compatibility by adding missing namespaces and headers.	3 months ago
Rahim Kanji	ca45405942	Merge remote-tracking branch 'Master/v3.0-moveInfra' into v3.0_pgsql-pipeline-set-reset-discard-fix-5432	3 months ago
Rene Cannao	0cd6fea331	Fix COM_REGISTER_SLAVE test and enhance binlog reader diagnostics This commit addresses failure in test_com_register_slave_enables_fast_forward-t by ensuring the required test user exists and increasing verbosity. Key changes: - In test_binlog_reader-t.cpp: - Added explicit ProxySQL Admin commands to create/replace the 'sbtest8' user with 'fast_forward=0' before the test begins. This ensures the user exists regardless of pre-existing database state. - Added logic to verify user existence in 'runtime_mysql_users' if initial connection fails, providing better debugging context. - Integrated detailed diag() messages across all major steps: table creation, data insertion, and GTID tracking checks. - Fixed a printf format warning by using %llu for my_ulonglong. - In test_com_register_slave_enables_fast_forward-t.cpp: - Added initial diagnostic messages to explain test intent. - Improved error reporting when the sub-test (test_binlog_reader-t) fails.	3 months ago
Rahim Kanji	33a6682bb9	* Use libpq to authenticate in Phase2 * Added support for hostnames	3 months ago
Rene Cannao	6c482de17e	Enhance unsupported queries test with detailed diagnostics and provisioning The test_unsupported_queries-t.cpp test was updated to: - Implement automated provisioning of data files for LOAD DATA LOCAL INFILE to /var/lib/proxysql, ensuring compatibility with containerized environments where the server needs access to the local file. - Add comprehensive diagnostic headers and step-by-step logging to trace the execution of both naturally unsupported queries and conditionally-enabled queries. - Improve error reporting by showing both expected and actual error codes/messages. - Clean up query execution loops for better readability and more robust ProxySQL Admin interaction tracking.	3 months ago
Rene Cannao	b7fdec15cd	Fix COM_BINLOG_DUMP fast forward test and isolated environment dependency paths This commit resolves multiple issues in the new CI infrastructure related to binary dependency discovery and COM_BINLOG_DUMP protocol testing. Key changes: - In test_com_binlog_dump_enables_fast_forward-t.cpp: - Fixed a path construction bug where an empty TEST_DEPS resulted in attempting to execute '/mysqlbinlog' (root directory) instead of searching the system PATH. - Added comprehensive diagnostics (diag()) to show connection details, TEST_DEPS status, and detailed file system checks (stat() and 'which') to ensure mysqlbinlog is found and executable. - Improved error reporting by dumping current PATH and CWD on failure. - In infra/control/env-isolated.bash and run-tests-isolated.bash: - Standardized TEST_DEPS and TEST_DEPS_PATH to use workspace-relative paths ('/test-scripts/deps') instead of Jenkins-specific hardcoded paths. - Updated symlink creation logic in run-tests-isolated.bash to correctly map detected binaries (mysqlbinlog, test_binlog_reader-t) into the workspace-relative dependency directory inside the test container.	3 months ago
Rene Cannao	de4340b2e2	Fix ProxySQL SQL template replacement in test_warnings-t.cpp - Correct character offset for VALUES (0, replacement. - Ensures valid SQL syntax when dynamically updating hostgroup IDs.	3 months ago
Rene Cannao	a719a6c36e	Fix firewall whitelist test by dynamically detecting client address and schema The firewall whitelist test (test_firewall-t.cpp) was failing in the new CI infrastructure because it used hardcoded '127.0.0.1' and 'information_schema' in its whitelist rules. While these values worked in the old local-only CI, the new environment uses Docker networks where the client IP is typically a container or gateway IP (e.g., 172.21.0.14). This commit enhances the test by: - Implementing dynamic discovery of the actual 'cli_host' and 'db' as seen by ProxySQL for the current session by querying stats_mysql_processlist using the specific SessionID (mysql_thread_id). - Adding comprehensive TAP diagnostic messages (diag()) to trace the execution flow, show detected values, and provide detailed error context (errno and error messages) in case of failures. - Ensuring more robust cleanup and resource management by checking MYSQL_RES pointers before freeing. - Improving overall test observability by providing a clear explanation of the test's intent at the start.	3 months ago
Rene Cannao	5133ca3c5f	Fix hostgroup discovery and enhance diagnostics in test_binlog_fast_forward-t.cpp - Implement dynamic default_hostgroup discovery for root user. - Add detailed diagnostic headers and step-by-step protocol tracking. - Resolves 'connection is locked' errors in multi-infra environments.	3 months ago
Rene Cannao	4af1217947	Fix RESTAPI script provisioning and enhance diagnostics in reg_test_4001-restapi_scripts_num_fds-t.cpp - Implement self-provisioning of RESTAPI scripts to /var/lib/proxysql. - Explicitly enable RESTAPI via Admin interface during test setup. - Add comprehensive diagnostic headers and step-by-step logging.	3 months ago
Rene Cannao	367c90d4f3	Fix UNIQUE constraint error in test_hostgroup_attributes_online_servers-t.cpp - Use SELECT DISTINCT when populating Hostgroup 1 to prevent duplicate server insertions.	3 months ago
Rene Cannao	7c3527bf5c	Fix idempotent ProxySQL configuration in test_hostgroup_attributes_online_servers-t.cpp - Reset Hostgroups 0 and 1 before populating to avoid UNIQUE constraint errors. - Add granular diagnostic logging for each configuration step.	3 months ago
Rene Cannao	0b0d7a842f	Enhance verbosity and stability of test_hostgroup_attributes_online_servers-t.cpp - Resolve compilation errors by moving variable declarations to the top of main. - Add detailed diagnostic headers and connection context. - Implement self-configuration logic to ensure Hostgroup 1/0 availability and correct routing. - Add granular step-by-step debug information.	3 months ago
Rahim Kanji	5a5b7dfe7a	Added more test cases	3 months ago
Rahim Kanji	45707f5a07	Added more testcases	3 months ago
Rahim Kanji	4894bf4d72	Added pgsql-options_startup_params-t.cpp test	3 months ago
Rene Cannao	91e95fddd0	Updated gitignore	3 months ago
Rene Cannao	e142f7e24e	Fix ProxySQL environment configuration in mysql-init_connect-2-t.cpp - Clear existing query rules to prevent interference. - Explicitly route testuser SELECT queries to hostgroup 1.	3 months ago
Rene Cannao	785fbef3e4	Fix ProxySQL user registration collisions in multi-infra environments (ref #5439 ) - Replace REPLACE INTO with INSERT OR IGNORE INTO for mysql_users. - Prevents subsequent infrastructures from overwriting shared users like testuser/root. - Ensures the first infra in the loading order defines the primary default_hostgroup.	3 months ago
Rene Cannao	6f8598b90b	Implement transient SSL copies for PostgreSQL to preserve repo permissions - Refactor all docker-compose-init.bash scripts to copy SSL files to a transient directory. - Apply strict 0640/999 permissions only to the transient copies. - Update docker-compose.yml to mount SSL volumes from the transient log directory. - This resolves 'Permission denied' errors in git status/diff during active test runs.	3 months ago
Rahim Kanji	11b3e2be0f	Update pgsql-transaction_variable_state_tracking-t.cpp	3 months ago
Rene Cannao	864fc94b92	Removing files committed by mistake	3 months ago
Rene Cannao	6f2831a59b	Removed cluster_sync_node_stderr.txt	3 months ago
René Cannaò	4d58ce473e	Merge pull request #5435 from sysown/v3.0-ci_fix0301 Fix tests for isolated CI environment and enhance diagnostics	3 months ago
Rene Cannao	f93ec31d73	Fix compilation errors in TAP tests - charset_unsigned_int-t.cpp: Fix misplaced closing brace and return. - test_auth_methods-t.cpp: Correctly declare and use has_sha2 scope. - test_cluster_sync-t.cpp: Replace remaining system() calls with dump_mysql_servers lambda.	3 months ago
Rene Cannao	242eef0241	Address code review feedback - test_binlog_reader_uses_previous_hostgroup-t.cpp: Use relative path when TEST_DEPS is unset. - test_com_register_slave_enables_fast_forward-t.cpp: Use relative path when TEST_DEPS is unset. - test_ffto_pgsql-t.cpp: Escape credentials before using them in SQL. - charset_unsigned_int-t.cpp: Ensure mysql_b connects and verifies latin1 before reset. - test_cluster_sync-t.cpp: Use mysql_query instead of system() for diagnostics. - test_cluster_sync_config: Replace tracked runtime stderr file with .example and gitignore it. - test_cluster_sync_withmonitor: Use relative path for datadir in config. - test_sqlite3_pass_exts-t.cpp: Use cl.admin_host for admin connection and improve version check. - test_auth_methods-t.cpp: Correctly detect MariaDB and use plan(0) for skip.	3 months ago
Rene Cannao	8dfb970a90	Add verbosity and diagnostics to reg_test_3992_fast_forward_malformed_packet-t - Add verbose test header and descriptive diagnostics. - Dump initial ProxySQL configuration (servers and users) from Admin interface. - Add detailed logging for connection attempts and query executions.	3 months ago
Rene Cannao	2047379acb	Fix test_auth_methods-t and improve diagnostics - Use cl.mysql_host and cl.mysql_port for backend MySQL connection. - Add backend MySQL 8.0+ version requirement check. - Add verbose test header and diagnostic messages for connection attempts. - Remove hardcoded passwords and ports from test_auth_methods-t.env to allow environment variable overrides.	3 months ago
Rene Cannao	ecf2b1c259	Fix test_auto_increment_delay_multiplex-t and add extra verbosity - Revert to using cl.username/password for ProxySQL connection. - Ensure test user is configured with default_hostgroup=0 and transaction_persistent=1 before connecting. - Add explicit query rule to route SELECT 1 to HG 1. - Use /* hostgroup=0 */ hint for DO 1 queries to ensure they hit the same hostgroup as the initial INSERT (HG 0). - Add verbose test header and descriptive function headers. - Add helper functions to dump users and query rules for debugging.	3 months ago
Rene Cannao	7ae2e0e9db	Fix reg_test_4264-commit_rollback-t and add extra debugging for TAP tests - Update reg_test_4264-commit_rollback-t to set default_hostgroup=0 and correct transaction_persistent for all sbtest% users. - Add helper functions to dump relevant users and query rules for better diagnostics. - Add verbose headers and debug logging to EOF support TAP tests.	3 months ago
Rahim Kanji	abb66cc19f	Addressed AI review feeback	3 months ago
Rene Cannao	032ca6511d	Test: Fix test_unsupported_queries for isolated CI environment Use REGULAR_INFRA_DATADIR environment variable to locate the load_data_local_datadir files in the shared volume when running in containerized CI environment. Falls back to cl.workdir for local testing.	3 months ago
Rene Cannao	6f7aa050e7	Test: Fix test_sqlite3_server for isolated CI environment Change hardcoded '127.0.0.1' to '0.0.0.0' for sqliteserver-mysql_ifaces configuration. In Docker isolated environments, 127.0.0.1 is not reachable from other containers, but 0.0.0.0 allows connections via container hostname.	3 months ago
Rahim Kanji	e84433159b	Merge remote-tracking branch 'v3.0' into v3.0_pgsql-pipeline-set-reset-discard-fix-5432	3 months ago
Rene Cannao	41e9351b46	Test: Add verbose test header and fix SQLite3 server connection to use cl.host - Changed host_port.first.c_str() to cl.host for SQLite3 server connections - Added verbose test header explaining test purpose and scenarios	3 months ago
Rene Cannao	7995ce524e	Test: Fix test_sqlite3_pass_exts for MySQL 5.7 compatibility - Detect MySQL version and skip MySQL 8.0+ specific tests - Use cl.mysql_host for backend connection - Remove hardcoded env overrides from env file	3 months ago
Rene Cannao	6eedf0808e	Test: Fix test_sqlite3_pass_exts for isolated CI environment - Changed MySQL backend connection to use cl.mysql_host instead of cl.host - Added verbose test header explaining test purpose and scenarios - Added diagnostic messages for connection attempts and success	3 months ago
Rene Cannao	21ef7a6101	Test: Fix test_sqlite3_from_unixtime for isolated CI environment - Renamed test file to have .py extension - Added environment variable support for connection parameters: - TAP_ADMINHOST, TAP_ADMINPORT, TAP_ADMINUSERNAME, TAP_ADMINPASSWORD - TAP_HOST, TAP_PORT, TAP_USERNAME, TAP_PASSWORD - Added verbose test header explaining test purpose - Added diagnostic messages for connection status	3 months ago
René Cannaò	16f8837e0d	Merge branch 'v3.0' into v3.0-pgsql_monitor_repl_lag Signed-off-by: René Cannaò <rene@proxysql.com>	3 months ago
Rene Cannao	61ab968fdb	Test: Add verbose header and diagnostics to sqlite_autocommit test Added detailed test header explaining test purpose and scenarios. Added diagnostic messages for connection attempt, success, and failure.	3 months ago
Rahim Kanji	1877a7d5f0	Added more tests in pgsql-set_statement_test-t.cpp and pgsql-transaction_variable_state_tracking-t.cpp	3 months ago
Rene Cannao	7c8f3c03d0	Test: Fix max_connections_ff test for isolated CI environment The test was failing because it1. Admin connection used cl.host instead of cl.admin_host 2. Hardcoded hostgroup_id=0 and username 'sbtest1' instead of using the user's default hostgroup from3. No verbose test header Changes: - Added get_user_default_hostgroup() to dynamically query the the user's default hostgroup - Modified test functions to accept tg_hg and username parameters - Use cl.admin_host for admin connection - Use cl.username instead of hardcoded 'sbtest1' - Added verbose test headers explaining test purpose - Added diagnostic output for for hostgroup and server configuration	3 months ago
Rene Cannao	1746ed8eec	Test #3504 : Fix change_user test for isolated CI environment The test was failing because it used hardcoded 127.0.0.1 for connections instead of using the environment-configured host. In the isolated CI environment, ProxySQL runs in a container with hostname 'proxysql'. Changes to main test: - Use cl.admin_host instead of hardcoded 127.0.0.1 for admin connection - Pass CommandLine cl to perform_helper_test function - Add host field to JSON input sent to helper binaries - Add verbose test header with diag() explaining test purpose Changes to helper: - Add host variable extracted from JSON input - Use dynamic host in mysql_real_connect calls instead of 127.0.0.1	3 months ago
Rene Cannao	37b75fba9d	Test #3549 : Fix autocommit tracking test for isolated CI The test used hardcoded hostgroup=0 in query hints, but in the isolated environment the test user's default hostgroup is 1300. When SET @session_var locks the connection to hostgroup 1300, subsequent queries trying to route to hostgroup 0 fail with error 9006. Changes: - Add TAP_NAME constant and MYSQL_SERVER_HOSTGROUP from environment - Create build_select_query() helper for dynamic hostgroup hints - Convert static test_definitions to build_test_definitions() function - Add verbose test header with diag() explaining test purpose	3 months ago
Rene Cannao	de9da7dede	PostgreSQL: Fix connection_parameters_test for hostname resolution - Replace inet_addr() with getaddrinfo() in connect_server() to support hostname resolution (required for Docker DNS like "proxysql") - Add verbose header explaining test purpose and scenarios - Add connection info output showing host/port configuration - Add diagnostic output in connect_server for debugging	3 months ago
Rene Cannao	10e143ba1f	Test #5212 : Fix TCP keepalive warnings test for isolated CI - Add cl.getEnv() call to load environment variables (was missing) - Fix cl.host to cl.admin_host for admin connection - Fix variable names: mysql.tcp_keepalive -> mysql-use_tcp_keepalive - Add REGULAR_INFRA_DATADIR environment variable check - Add verbose header with test description - Fix structured binding with std::get<LINE>()	3 months ago
Rene Cannao	39df4f89bb	tests: Fix RESTAPI tests for isolated container environment - Use REGULAR_INFRA_DATADIR environment variable for script path resolution in reg_test_3223-restapi_return_codes-t (was hardcoded to cl.workdir) - Add verbose diagnostic output with PURPOSE and TEST SCENARIOS sections - Log the actual script base path being used for easier debugging - Consistent formatting with diag() headers across both tests	3 months ago
Rene Cannao	eaecc26d22	test: Fix RESTAPI tests for containerized CI and improved debuggability Update RESTAPI tests to use 'proxysql' hostname instead of 'localhost' for compatibility with containerized CI environments. Add comprehensive diagnostic logging including test headers, connection progress, and better error reporting for easier debugging of test failures.	3 months ago
Rene Cannao	e086a236b6	test: Fix reg_test_4055_restapi-t for containerized CI and improved debuggability - Align RESTAPI tests with the new CI network architecture by replacing 'localhost' and '127.0.0.1' with 'proxysql' and cl.host. - Implement proper hostname resolution using getaddrinfo() instead of assuming cl.host is a literal IP address compatible with inet_addr(). - Add missing <netdb.h> header required for network resolution functions. - Add a descriptive diagnostic header using diag() to summarize the test's purpose and strategy. - Significantly increase execution verbosity with detailed diag() calls at each major step: ProxySQL Admin connection, socket creation, hostname resolution, malformed data transmission, and responsiveness verification.	3 months ago
Rene Cannao	f10258db2d	test: Update reg_test_3838-restapi_eintr-t for containerized CI and improved debuggability - Implement environment detection to skip signaling tests when running against a remote or containerized ProxySQL (detected via TAP_HOST). This prevents failures caused by PID namespace isolation that prevents the test runner from finding or signaling (SIGCONT/SIGSTOP/SIGTERM) processes inside the ProxySQL container. - Update RESTAPI base address from 'localhost:6070' to 'proxysql:6070' to match the new CI network architecture. - Add a comprehensive diagnostic header explaining the test's purpose and strategy. - Significantly increase execution verbosity with diag() calls at every major step: connection, route configuration, endpoint readiness, PID discovery, signaling, and result verification. - Refine child process PID detection loop with increased timeout (2s) and more robust shell pipeline handling. - Improve error reporting for signaling and JSON response parsing.	3 months ago
Rene Cannao	3c6864c0fb	test: Improve child PID detection and signaling robustness in reg_test_3838-restapi_eintr-t.cpp	3 months ago
Rene Cannao	f1f420ac13	test: Fix reg_test_3838-restapi_eintr-t by using correct ProxySQL address and adding diagnostics	3 months ago
Rene Cannao	c74933168a	test: Remove obsolete .env file for reg_test_4556-ssl_error_queue-t	3 months ago
Rene Cannao	140ca03c9b	test: Fix reg_test_4556-ssl_error_queue-t by using correct backend port and adding diagnostics - Use cl.mysql_host and cl.mysql_port for direct backend connections. - Add descriptive diagnostic summary at the start of the test. - Improve logging in connection creation and warmup phases. - Prometheus endpoint updated to proxysql:6070 (already in file).	3 months ago
Rene Cannao	076a71bc8a	test: Add descriptive diagnostics to mysql-sql_log_bin-error-t.cpp	3 months ago
Rene Cannao	12dc2777b9	test: Fix test_connection_annotation-t by adding warmup and forcing HG1	3 months ago
Rene Cannao	9dd5d7442a	test: Make malformed packet stability check more robust for Admin interface	3 months ago
Rene Cannao	069d6aca6f	test: Enhance malformed packet stability test and CI configuration - Improve diagnostics and add hostname resolution to malformed packet test. - Fix plan count and credential handling in mysql-test_malformed_packet-t.cpp. - Add Cluster sync test configuration and SSL certificates for regression testing. - Include SIGTERM handler verification script marker.	3 months ago
Rene Cannao	43d62a63e6	test: Enhance diagnostics and align test infrastructure with CI - Add connection failure diagnostics to init_mysql_conn in utils.cpp. - Format and cleanup admin-listen_on_unix-t.cpp. - Update multiple tests (charset, clickhouse, mysql-init, protocol) to use CommandLine credentials and dynamic ports. - Fix hostname resolution and credential handling in various TAP tests.	3 months ago
Rahim Kanji	ea619d7816	Added TAP test	3 months ago
Rene Cannao	00e18636c4	test: Align credentials and paths with CI environment in FFT-O and config tests	3 months ago

1 2 3 4 5 ...

1689 Commits (mysqlx-plugin-impl)