Thread: Check for m_running == 1 only once in destructor

8 years ago · 4c35682ec0
parent 3a4f11fe75
commit 4c35682ec0
1 changed files with 3 additions and 3 deletions
--- a/lib/thread.cpp
+++ b/lib/thread.cpp
@ -31,10 +31,10 @@ Thread::Thread() : m_tid(0), m_running(0), m_detached(0) {}

 Thread::~Thread()
 {
-    if (m_running == 1 && m_detached == 0) {
-        pthread_detach(m_tid);
-    }
    if (m_running == 1) {
+        if (m_detached == 0) {
+             pthread_detach(m_tid);
+        }
        pthread_cancel(m_tid);
    }
 }