From 4c35682ec0b8aedbba5febad0a792b85ba67b56e Mon Sep 17 00:00:00 2001 From: Dominic Tubach Date: Mon, 21 May 2018 18:12:45 +0200 Subject: [PATCH] Thread: Check for m_running == 1 only once in destructor --- lib/thread.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/thread.cpp b/lib/thread.cpp index 30a70f863..af355524a 100644 --- a/lib/thread.cpp +++ b/lib/thread.cpp @@ -31,10 +31,10 @@ Thread::Thread() : m_tid(0), m_running(0), m_detached(0) {} Thread::~Thread() { - if (m_running == 1 && m_detached == 0) { - pthread_detach(m_tid); - } if (m_running == 1) { + if (m_detached == 0) { + pthread_detach(m_tid); + } pthread_cancel(m_tid); } }