18404 Commits (525b0a7c4cff4635da6c971abb7fdd101ea81aa2)

 

All Branches   

Search

Author	SHA1	Message	Date
Lucas Bajolet	525b0a7c4c	plugin: use API version for loading plugins ... While migrating to a unified approach for loading plugins, the API major and minor versions were not added to the constraints for discovering plugins from the environment, leading to Packer potentially considering plugins that are not compatible with itself. This should not be possible, but was due to this omission, which we fix with this commit.	2 years ago
Lucas Bajolet	7113dea5ef	plugin-getter: fix typo in API mismatch error	2 years ago
Lucas Bajolet	2e2038bc30	command: migrate tests using the comment plugin ... In order to test the Packer subcommands, some tests rely on a plugin: github.com/sylviamoss/comment. This plugin is outdated compared to our SDK, and some of the binaries releases don't match what is expected by Packer, i.e. v1.0.0 vs. v0.2.8. To fix that, we migrate to use the hashicups plugin, which is our demo plugin for Packer, and is actually maintained, and up-to-date, which will make those tests more reliable moving forward.	2 years ago
Lucas Bajolet	503768c683	command: trim trailing spaces from help message	2 years ago
Lucas Bajolet	9a6e74a66b	command: add dev support for plugins install ... Since we now support loading pre-releases with Packer subcommands, we relax the contraints we had placed on the `--path' option, so it will accept any `-dev' binary, in addition to final releases.	2 years ago
Lucas Bajolet	b5848b9913	command: add --release-only flag to validate/build ... Since we added the capability for the plugin discovery to ignore installed pre-releases of plugins, we give that capacity to the validate and build commands, through a new command-line flag: release-only.	2 years ago
Lucas Bajolet	9f7e6ca52b	plugins: add a release only flag to Discover ... Since we now support loading pre-releases, we also want Packer to be able to ignore them by user demand, so we put in place the infrastructure to modulate this.	2 years ago
Lucas Bajolet	e099c5c661	main: move Discover to DetectPluginBinaries ... When Packer is loaded, we used to perform plugin discovery. This was done for every call to Packer, including when it is executed as a plugin, arguably against what the comments document. Doing this as early in the loading process makes it harder to change this behaviour, as we'd need to introduce flags aside from the rest, and handle them manually, which is not optimal. Therefore, we change this: now when Packer starts executing, it will not attempt to discover installed plugins anymore, and instead will only try to load them when a configuration has been parsed, and is being used to perform actions (typically build/validate).	2 years ago
Lucas Bajolet	5bcf6dacca	packer: support loading pre-release plugins ... When a pre-release version of a plugin is locally installed, it may or may not be loaded depending on the constraints expressed in the template being executed. If the template contains constraints for loading the plugin, it would be ignored, while if that wasn't present, it would be loaded. This is inconsistent, and deserves to be addressed, which is what this commit does. With this change, plugin pre-releases are now loaded, provided the version reported matches the constraints, independently from its pre-release suffix `-dev'. Also, if a release with the same version is also installed alongside the pre-release version of a plugin, it will have precedence over the pre-release.	2 years ago
Lucas Bajolet	b51c350bd6	packer: fix plugin version sorting and pickup ... When Packer orders the plugins by their version, we'd assumed it was ordered from highest to lowest. However, this was the case because our implementation of `Less' was actually returning `>=', which is not what it was supposed to do. This commit therefore fixes the implementation of `Less' to do what it is documented to do, and ensures the behaviour is correct through additional testing. Changing this requires some changes to the loading process as well because of the aforementioned assumption with regards to ordering.	2 years ago
Lucas Bajolet	ee01cf8ba9	command: move plugins remove tests outside of repo ... Since the plugins remove subcommand now only loads valid plugins, it cannot run on mock data anymore, and the logic for creating a valid plugin hierarchy is not present in this repository, but does in another, so we move those tests from here to that repository in order to continue testing them.	2 years ago
Lucas Bajolet	492cb72000	plugin-getter: reject plugin version mismatches ... When a plugin is loaded from Packer, we now check that the version it reports matches what the name implies. In case there's a mismatch, we log, and reject the binary.	2 years ago
Lucas Bajolet	fd5f668ee9	plugin: consolidate loading logic ... Right now we had two paths for discovering installed plugins, i.e. through plugin-getter's `ListInstallations' function, or through the `Discover' call, which relied on a glob to list the installations. This was required since we allowed plugins to be installed in multiple locations, and with different constraints. Now that we force a certain convention, we can consolidate the logic into ListInstallations, and rely on that logic in `Discover' to load a plugin into the PluginConfig for the current Packer run.	2 years ago
Lucas Bajolet	698bcdc2a9	plugin-getter: implement Sort interface for List ... The plugin installation list should be sorted according to a name first, then version second basis. Right now, we only rely on the glob to add plugin installs to this list, making the order unreliable since the lexicographical order is not the order in which we want to see the same plugin ordered (e.g. v1.0.9 > 1.0.10). To fix this, we implement a logic for sorting a list of installations that does what's described above with more accuracy.	2 years ago
Lucas Bajolet	2af3ff0e72	plugin-getter: fix docs for Installation ... The comments weren't capitalised correctly, and the directory example included the `packer-plugin-' prefix, which should not be the case in reality.	2 years ago
Lucas Bajolet	4cda3b64ac	packer: remove path argument to discover installed ... Since the plugin directory should now be unique instead of a list, we can use it directly from the receiver's structure instead of as a parameter to the function.	2 years ago
Lucas Bajolet	4b00a81bf3	packer: remove directory slices from structs ... Since we'll only look in the plugin directory, and not from multiple sources now, for installing/listing plugins, we can simplify the structures which used to accept multiple directories so they only accept one.	2 years ago
Lucas Bajolet	664700d0c0	packer: rm support for manually-installed plugins ... Since we'll be only accepting plugins installed locally along with a shasum, and those that adopt the convention we introduced with required_plugins, we remove support for plugins that only have a packer-plugin-.* type name.	2 years ago
Lucas Bajolet	94aaff44a1	packer: only support one directory for plugins ... Since we're removing the alternative plugin installation directories in favour of only supporting installing them in the PACKER_PLUGIN_PATH directory, we only return one directory when getting the known plugin directories.	2 years ago
Lucas Bajolet	32f89015fe	hcp: fix hcp artifact extraction method ... With Packer 1.10.1 we started warning when a build failed to complete because of a potential incompatibility with the builder being used. This led to cases in which the build failed for other reasons, and Packer would still warn of potential incompatibilities, even if the builder was in effect HCP compatible. We attempted to fix this issue by introducing a new error type, and checks when we read the artifacts linked to a build, however this loop would fail when any one of the artifacts is not compatible with HCP Packer, leading to false failures. To avoid this problem, we log incompatibilities to the verbose logger, and only signal the problem if all the artifacts could not be used to upload data to HCP Packer, in which case it's almost certain that if the build succeeded and no artifacts are registered to the build, that all the components used are not compatible with HCP, and should be reported as such to users.	2 years ago
dependabot[bot]	8a1d1e0c88	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.83.0 to 0.85.0 (#12850) ... Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.83.0 to 0.85.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.83.0...v0.85.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Jenna Goldstrich	72db1c35e9	Don't use old nomenclature in terminology docs (#12843)	2 years ago
Lucas Bajolet	548893bbee	build: don't suggest lack of HCP support on fail ... When running a build with HCP Packer enabled, Packer attempts to push the build status to HCP. If the build fails, we update the status to BUILD_FAILED, and that's the end of it. If however the build succeeds, Packer attempts to get the HCP artifact from the builder, which will only succeed if the builder supports it. Otherwise, we'll get either nil, or an artifact type that is not compatible with what is expected for HCP support. When either of those happens, we warn that the builder may not support HCP Packer at all, so users are aware of the problem. However, when the error was introduced, it only looked at the fact that an error was produced, independently of the type of error. This caused legitimate errors while building to be reported as potential incompatibility between the builder and HCP, which was confusing to users. This commit changes this by introducing a new error type, only produced when the artifact either is nil, or failed to be deserialised into a HCP artifact, which lets us produce the incompatibility warning with more accuracy.	2 years ago
dependabot[bot]	9b01bfa486	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.82.0 to 0.83.0 (#12827) ... Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.82.0 to 0.83.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.82.0...v0.83.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Wilken Rivera	4d38323ae1	Remove external Plugins from left navbar	2 years ago
Lucas Bajolet	dff49df129	hcl2template: check bucket name at parse-time ... Not validating the bucket's name during parse leads to configurations being marked as valid, even if the bucket name is not, which will fail during a real build afterwards. To avoid this problem and fail with an error as quickly as possible, we add a check during parsing, so that it gets reported for validate as well.	2 years ago
Heat Hamilton	767005149c	website: fix husky command (#12821) ... * Change husky pre-commit hook to work in sub-directory of .git * Added dart-linkcheck back in for linkcheck command	2 years ago
Wilken Rivera	08d41c2679	Fix URL rewrite check error for DevDot portal (#12818) ... Refer to job https://github.com/hashicorp/packer/actions/runs/7709708630/job/21011464094	2 years ago
Wilken Rivera	ca066f73bf	Update CHANGELOG	2 years ago
Wilken Rivera	1e6041ab05	docs/plugins:Fix incorrect plugin directory path	2 years ago
Heat Hamilton	ec403555dc	Updated next, node, npm, nvmrc and Docker node versions; added husky pre-commit hook v9	2 years ago
Wilken Rivera	da65323918	Remove all external plugin docs ... This change removes all external plugin docs using the old remote docs framework from the Packer core documentation in favor of the Packer integration framework. Remove plugins will be enabled on the integration portal and contacted to merge their PRs to finalize the integration migration.	2 years ago
Devashish	682eca2877	Remove repeated code	2 years ago
Devashish	4b591d6937	Add PR suggestions	2 years ago
Devashish	14ce2a559c	fix shell session in the docs	2 years ago
Devashish	b77d581cda	Add the deprecation warning and update docs	2 years ago
Devashish	cbc16cfed5	Add versionFingerprint to EvalContext	2 years ago
Devashish	91ce35f439	Expose versionFingerprint instead of versionId from packer template	2 years ago
Wilken Rivera	12b8c885a3	Update error messaging for HCP incompatible plugin builds (#12800) ... * Update error messaging for HCP incompatible plugin builds * Update command/build.go Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com> --------- Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>	2 years ago
Devashish	3fa637c608	Migrate HCP Packer to API V2 and new nomenclature changes (#12794) ... * add hcp packer new nomenclature updates * Update docs with nomenclature changes * Update navigation bar links * Bump github.com/hashicorp/hcp-sdk-go from 0.81.0 to 0.82.0 * fix acceptance test template --------- Co-authored-by: sylviamoss <moss@hashicorp.com> Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	2 years ago
dependabot[bot]	91ce018cf1	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.79.0 to 0.81.0 ... Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.79.0 to 0.81.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.79.0...v0.81.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2 years ago
Wilken Rivera	96755d2f7b	Remove migrated integrations from plugin manifest ... This change removes Scaleway and Mondoo from the external plugins manifest in favor of the integration framework, which they have migrated to.	2 years ago
Lucas Bajolet	6c99f387a0	packer: remove single-component plugins ... Single-component plugins are a relic from the past that has been deprecated from version 1.7.0 and onwards. Since we're revisiting how plugins are installed/loaded, and the changes will be incompatible with those, we remove them in preparation of this work.	2 years ago
Wilken Rivera	beb5fcf470	Bump github.com/cloudflare/circl to address GHSA-9763-4f94-gfch (#12781)	2 years ago
dependabot[bot]	a9000f3a70	build(deps): bump github.com/hashicorp/hcp-sdk-go from 0.74.0 to 0.79.0 ... Bumps [github.com/hashicorp/hcp-sdk-go](https://github.com/hashicorp/hcp-sdk-go) from 0.74.0 to 0.79.0. - [Release notes](https://github.com/hashicorp/hcp-sdk-go/releases) - [Changelog](https://github.com/hashicorp/hcp-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/hcp-sdk-go/compare/v0.74.0...v0.79.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcp-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2 years ago
Wilken Rivera	bfc3f8b564	Bump github.com/go-git/go-git/v5 to address CVE-2023-49568	2 years ago
Wilken Rivera	2515aa27a7	Bump golang.org/x/crypto to address CVE-2023-48795	2 years ago
Wilken Rivera	0a64a5fb90	Bump Go version to 1.20.12 ... Bumped to pull in security fixes to the go command, the net/http package, and path/filepath package.	2 years ago
Aidan Mundy	0b06cb58a3	Fix Typo `make check-generate` -> `make generate-check`	2 years ago
Lucas Bajolet	311a3b1d6a	website: remove UpCloud from manifest ... Since the UpCloud plugin has moved to the integrations model, we don't want to continue looking for a docs.zip in their repo, as it doesn't exist anymore with this migration.	2 years ago