14821 Commits (304f615bc3bb40bfcbbb38c665343dabdefbc4df)

 

All Branches   

Search

Author	SHA1	Message	Date
Adrien Delorme	304f615bc3	Update website/pages/docs/from-1.5/expressions.mdx ... Co-Authored-By: Megan Marsh <megan@hashicorp.com>	6 years ago
Adrien Delorme	c5c3585df1	make docs a bit more readable for KeyValues too	6 years ago
Adrien Delorme	73242e8de4	make sure keyvalue and namevalue filters are using the same naming as the service being used	6 years ago
Sylvia Moss	553b1fb9f8	Add RetriedProvisioner to allow retry provisioners (#9061)	6 years ago
Wilken Rivera	d580ea7950	Merge pull request #9069 from tencentyun/master ... builder/tencent: fixed InstanceOperationInProgress error #9054	6 years ago
Wilken Rivera	7ec55860e5	Revert golangci-lint to use new-from-rev pinned at 1.23.8 (#9072) ... Turns out linting each file individually causes issues with the linter not being able to find the import types.	6 years ago
Wilken Rivera	e8f8ebf132	builder/vmware: Add some additional debug logging to the driver version check (#9064)	6 years ago
Li Kexian	632610d9c0	fixed InstanceOperationInProgress error #9054	6 years ago
Megan Marsh	f10ab4135a	Merge pull request #9065 from Charliekenney23/update-linode-codeowners ... add linode codeowners	6 years ago
Wilken Rivera	57e49e8c34	Merge pull request #9066 from hashicorp/remove_appveyor_build ... stop using redundant appveyor builds	6 years ago
Megan Marsh	cf576d9b4e	stop using redundant appveyor builds	6 years ago
Megan Marsh	f12269f124	fix builds on linux (#9031) ... * fix builds on linux * Build: Move to CGO_ENABLED=0 (#9057) After further investigation on cross-compiling Go bins on Linux. I found that statically linking against GCC (for libc) failed to build for ARM and introduced a possible licensing issue as our bins would essentially be bundling libc into the bin. Diving further into cross compiling on Linux I found that the defacto solution is to compile with CGO disabled - this was also found to be the case for other HashiCorp products. Disabling CGO has the limitation of not allowing the use of any pkg that calls out to C (net, os), but in looking into the Packer code base and the relevant Go code base it appears that the latest versions of Go have pure Go implementations of the said packages so I believe we are good to go. I should also point out that CGO is disabled by default when cross compiling via `go build`. However, the GOX tool will enable it if it is not explicitly disabled. Below are three test cases executed to validate the compile bins work as expected. Build results after change ``` ⇶ make bin WARN: 'make bin' is for debug / test builds only. Use 'make release' for release builds. ==> Checking for necessary tools... ==> Entering Packer source dir... ==> Ensuring output directories are present... ==> Removing old builds... ==> Building... Number of parallel builds: 7 --> windows/amd64: github.com/hashicorp/packer --> linux/arm64: github.com/hashicorp/packer --> linux/386: github.com/hashicorp/packer --> linux/arm: github.com/hashicorp/packer --> darwin/amd64: github.com/hashicorp/packer --> windows/386: github.com/hashicorp/packer --> linux/amd64: github.com/hashicorp/packer --> darwin/386: github.com/hashicorp/packer ==> Copying binaries for this platform... './pkg/linux_amd64/packer' -> 'bin/packer' './pkg/linux_amd64/packer' -> '/home/wilken/Development/go/bin/packer' ==> Results: total 111M -rwxr-xr-x 1 wilken wilken 111M Apr 13 12:29 packer ``` Packer executed on ARM based machine ``` ubuntu@ip-172-31-10-18:~$ ./packer version Packer v1.5.6-dev (314ac5b65+CHANGES ubuntu@ip-172-31-10-18:~$ uname -a Linux ip-172-31-10-18 4.15.0-1054-aws #56-Ubuntu SMP Thu Nov 7 16:18:50 UTC 2019 aarch64 aarch64 aarch64 GNU/Linux ubuntu@ip-172-31-10-18:~$ ./packer build build.json null: output will be in this color. ==> null: Running local shell script: /tmp/packer-shell170248556 null: UUID from Packer: 79cc8532-6114-925d-2a79-33ef6ce281cd Build 'null' finished. ==> Builds finished. The artifacts of successful builds are: --> null: Did not export anything. This is the null builder ``` Custom Docker image with updated bin ``` ⇶ docker run packertest:latest version Packer v1.5.6-dev (314ac5b65+CHANGES) ⇶ docker run packertest:latest build build.json null: output will be in this color. ==> null: Running local shell script: /tmp/packer-shell065599452 null: UUID from Packer: 852f0604-2be4-9e16-99af-6d7df972ac2e Build 'null' finished. ==> Builds finished. The artifacts of successful builds are: --> null: Did not export anything. This is the null builder ``` Windows AMI ``` [...] ==> amazon-ebs: Launching a source AWS instance... ==> amazon-ebs: Adding tags to source instance amazon-ebs: Adding tag: "Name": "Packer Builder" amazon-ebs: Instance ID: i-04387545cf3e2acd3 ==> amazon-ebs: Waiting for instance (i-04387545cf3e2acd3) to become ready... ==> amazon-ebs: Skipping waiting for password since WinRM password set... ==> amazon-ebs: Using winrm communicator to connect: 18.206.100.104 ==> amazon-ebs: Waiting for WinRM to become available... amazon-ebs: WinRM connected. ==> amazon-ebs: Connected to WinRM! ==> amazon-ebs: Uploading packertest => c:/Windows/Temp ==> amazon-ebs: Provisioning with Powershell... ==> amazon-ebs: Provisioning with powershell script: /tmp/powershell-provisioner173180945 amazon-ebs: Packer v1.5.6-dev (314ac5b65+CHANGES) amazon-ebs: null: output will be in this color. amazon-ebs: ``` Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	6 years ago
Charles Kenney	ba53a01405	add linode codeowners	6 years ago
Megan Marsh	3df20fc40b	Merge pull request #9018 from VladRassokhin/vsphere-efi-secure-boot ... builder/vsphere-iso: support EFI Secure Boot	6 years ago
Megan Marsh	440f540e28	fix merge issues with generated code	6 years ago
Vladislav Rassokhin	5f2849b5b4	builder/vsphere-clone: support firmware changing	6 years ago
Vladislav Rassokhin	91a1ad63fa	builder/vsphere-iso: support EFI Secure Boot using another value in `firmware` (#8873)	6 years ago
Megan Marsh	31946d551e	Merge pull request #9063 from hashicorp/codeowners-tencentcloud ... CODEOWNERS: Add code owner for tencentcloud	6 years ago
Wilken Rivera	78642536b4	CODEOWNERS: Add code owner for tencentcloud	6 years ago
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Wilken Rivera	5075fc6ff7	Merge pull request #9059 from hashicorp/d-update-getting-started ... docs/getting-started: Update PATH install instructions	6 years ago
Wilken Rivera	9eccbb4cfe	docs/getting-started: Update PATH install instructions	6 years ago
Wilken Rivera	c9c0ee65d3	circle-ci: update ci-lint steps (#9043) ... * new-from-rev option is showing inconsistent results on circle and locally. This change moves to a custom command `script/lint.sh` that gets a list of added go files and pipes them to golangci-lint for testing. * Add a git fetch as a step before retrieving merge-base changes to fix the issue described at https://discuss.circleci.com/t/checkout-script-adds-commits-to-master-from-circle-branch/14194/2 * Moved source code out of GOPATH to ensure go mod support and reduce the risk of having golangci-lint trying to scan all of the files within GOPATH. This was an issue in the past, in changing it I found less OOM issues on circle.	6 years ago
Wilken Rivera	cc257387f1	Merge pull request #9056 from jhawk28/bug_9051 ... clean up documentation for new vsphere NIC and storage params	6 years ago
Joshua Foster	7f0dbdebb2	clean up documentation for new NIC and storage params ... adding examples, updating .gitattributes so *.mdx files have LF endings for windows	6 years ago
Marc Carmier	a1d14c75f4	Update vsphere documentation with link to the `vsphere-iso` builder (#9041)	6 years ago
Wilken Rivera	6b52df0c50	update changelog	6 years ago
Wilken Rivera	be6fe60306	Merge pull request #9037 from hashicorp/fix_9032 ... golang 1.14 doesn't like calling NewFile on existing files. Port solution over from Terraform	6 years ago
Paul Meyer	7e949182a8	Update CHANGELOG.md	6 years ago
Paul Meyer	df47fd5076	Merge pull request #9021 from paulmey/azure-chroot-shared-image-destination ... [azure/chroot] Add azure-chroot shared image destination	6 years ago
Megan Marsh	217dcbb97f	golang 1.14 doesn't like calling NewFile on existing files. Port solution over from Terraform	6 years ago
Paul Meyer	621bd8ccac	Fix error message grammar	6 years ago
Paul Meyer	89a8238a07	Fix artifact output	6 years ago
Paul Meyer	47107e6355	Default polling delay 5 sec	6 years ago
Megan Marsh	73c349d09c	Merge pull request #8908 from hashicorp/fix_4795 ... provisioner/powershell: Add cleanup step to remove any temporarily created scripts	6 years ago
Adrien Delorme	2af40c762b	HCL2: pass on builder type and name (#8956) ... * sets `packer_build_name` and `packer_builder_type` variables for builder provisioners and post-processors in HCL2 * allows to use the new `${source.type}` and `${source.name}` variables in HCL2 * fixes #8932 Note that the common.PackerConfig is used everywhere and was not set for HCL2, this had some implications: For #8923 you can see the issue here: dde74232f2/builder/lxd/config.go (L61-L63) More random examples of where this could cause an issue : 0785c2f6fc/provisioner/ansible-local/provisioner.go (L380-L381) b4efd13a4d/builder/amazon/ebs/builder.go (L232-L236) * [All references to PackerConfig.PackerBuildName](https://sourcegraph.com/github.com/hashicorp/packer@ff6a039d5bb45e34ff761d9c52e8b98972288447/-/blob/common/packer_config.go#L7:2&tab=references) * [All references to PackerConfig.PackerBuilderType](https://sourcegraph.com/github.com/hashicorp/packer@ff6a039d5bb45e34ff761d9c52e8b98972288447/-/blob/common/packer_config.go#L8:2&tab=references)	6 years ago
Wilken Rivera	c358682411	Merge pull request #9030 from hashicorp/document_headless_vmware ... update docs for headless to help users know they may need to launch the gui	6 years ago
Paul Meyer	4ffe5611b8	Add more tests	6 years ago
Megan Marsh	a48c0ecf49	update docs for headless to help users know they may need to launch the gui	6 years ago
Megan Marsh	e845632d3d	Merge pull request #9027 from alrs/fix-powershell-provisioner-err ... provisioner/powershell: Test Error Improvements	6 years ago
Lars Lehtonen	49f28c9439	provisioner/powershell: fix dropped error ... provisioner/powershell: improve error message	6 years ago
Wilken Rivera	4a46d6ff7b	docs/provisioner/powershell: Add documentation for `skip_clean` option	6 years ago
Wilken Rivera	fe721d8e11	test/provisioner/powershell: Add acceptance test for powershell provisioner cleanup ... Passing Tests ``` --- PASS: TestAccPowershellProvisioner_basic (282.02s) --- PASS: TestAccPowershellProvisioner_basic/testing_amazon-ebs_builder_against_powershell_provisioner (282.01s) PASS ok github.com/hashicorp/packer/provisioner/powershell 282.046s ``` Failing tests on master ``` 2020/04/08 09:59:34 Uploading file to 'c:/Windows/Temp/script.bat' 2020/04/08 09:59:36 [INFO] starting remote command: set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat" 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: C:\Users\Administrator>dir C:\Windows\Temp\packer-*.ps1 2020/04/08 09:59:36 ui: amazon-ebs: Volume in drive C has no label. 2020/04/08 09:59:36 [INFO] command 'set "PACKER_BUILDER_TYPE=amazon-ebs" && set "PACKER_BUILD_NAME=amazon-ebs" && "c:/Windows/Temp/script.bat"' exited with code: 0 2020/04/08 09:59:36 ui: amazon-ebs: Volume Serial Number is 46CA-4083 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: Directory of C:\Windows\Temp 2020/04/08 09:59:36 ui: amazon-ebs: 2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 102 packer-acc-test-script-test.ps1 2020/04/08 09:59:36 ui: amazon-ebs: 04/08/2020 01:59 PM 76 packer-acc-test-vars.ps1 2020/04/08 09:59:36 ui: amazon-ebs: 2 File(s) 178 bytes 2020/04/08 09:59:36 ui: amazon-ebs: 0 Dir(s) 9,735,806,976 bytes free 2020/04/08 09:59:36 ui: ==> amazon-ebs: Provisioning step had errors: Running the cleanup provisioner, if present... 2020/04/08 09:59:36 ui: ==> amazon-ebs: Terminating the source AWS instance... 2020/04/08 10:00:09 ui: ==> amazon-ebs: Cleaning up any extra volumes... 2020/04/08 10:00:09 ui: ==> amazon-ebs: No volumes to clean up, skipping 2020/04/08 10:00:09 ui: ==> amazon-ebs: Deleting temporary security group... 2020/04/08 10:00:10 ui: ==> amazon-ebs: Deleting temporary keypair... 2020/04/08 10:00:11 ui error: Build 'amazon-ebs' errored: Script exited with non-zero exit status: 0.Allowed exit codes are: [1] 2020/04/08 10:00:11 machine readable: error-count []string{"1"} 2020/04/08 10:00:11 ui error: ==> Some builds didn't complete successfully and had errors: 2020/04/08 10:00:11 machine readable: amazon-ebs,error []string{"Script exited with non-zero exit status: 0.Allowed exit codes are: [1]"} 2020/04/08 10:00:11 ui error: --> amazon-ebs: Script exited with non-zero exit status: 0.Allowed exit codes are: [1] ``` test: Fix windows-shell command	6 years ago
Wilken Rivera	91c8afda8e	provisioner/elevated: Add cleanup logic to remove elevated user scheduled task artifacts	6 years ago
Wilken Rivera	11db6014fa	provisioner/powershell: Update remote clean up logic ... * Add retry logic so that the provisioner will retry if it fails to upload/execute because of some restart provisioner step * Add a testConfigWithSkipClean for testing that the provisioner executes the correct commands * Add a test case for toggling the "skip_clean" config option	6 years ago
Wilken Rivera	f6a61e2511	provisioner/powershell: Add post clean up step to remove temp script files	6 years ago
Wilken Rivera	3892e0905a	Merge pull request #9022 from hashicorp/document_boot_wait ... properly document how to set boot_wait to 0s	6 years ago
Megan Marsh	346dcae78e	make generate	6 years ago
Megan Marsh	6fc3c4eb49	properly document how to set boot_wait to 0s	6 years ago
Paul Meyer	b12aedcda9	Remove lint	6 years ago