packer

Commit Graph

Author	SHA1	Message	Date
Jenna Goldstrich	078ad45860	HCP Packer Buckets: Change UpsertBucket to call GetBucket (#13059 ) * Update UpsertBucket to first call GetBucket, this will allow bucket level role based authentication, as CreateBucket uses project level auth * Fix one incorrect test failure message	2 years ago
dependabot[bot]	dd3b2e51f0	build(deps): bump github.com/hashicorp/packer-plugin-sdk from 0.5.3 to 0.5.4 (#13061 ) * build(deps): bump github.com/hashicorp/packer-plugin-sdk Bumps [github.com/hashicorp/packer-plugin-sdk](https://github.com/hashicorp/packer-plugin-sdk) from 0.5.3 to 0.5.4. - [Release notes](https://github.com/hashicorp/packer-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/packer-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](https://github.com/hashicorp/packer-plugin-sdk/compare/v0.5.3...v0.5.4) --- updated-dependencies: - dependency-name: github.com/hashicorp/packer-plugin-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump Go mod version to 1.21.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	2 years ago
Wilken Rivera	d406613387	Document use of TMPDIR required for remote plugin installation (#13056 ) * Document use of TMPDIR required for remote plugin installation * Update website/content/docs/configure.mdx Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com> --------- Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>	2 years ago
dependabot[bot]	5843c86c7e	build(deps): bump google.golang.org/grpc in /packer_test/plugin_tester Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.1 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.50.1...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	2 years ago
Lucas Bajolet	13c52124de	packer_test: check for a panic during execution When a command is run, it is the expectation that no test should make Packer panic. If it did, something is wrong and Packer should be fixed so it doesn't panic anymore in that situation. The way we did the check before was adding a PanicCheck after the command ran, so we could make sure of that during `Assert`. However, since we introduced the possibility to have multiple runs, having this addition as part of the run loop meant that the PanicCheck would be run as many times as there were runs. While this worked, this implied that we'd do the same check multiple times on a single command output, which is not optimal. Instead, this commit moves the check to within the `Run` function, this way for each run of the command we do the check once, and then we can assert the results of the command on what output it produced.	2 years ago
Lucas Bajolet	36e43e30ee	hcl2template: detect duplicate locals during parse Previously duplicate detection for local variables happened during `Initialise`, through a call to `checkForDuplicateLocalDefinition`. This works in a majority of cases, but for commands like `console`, this was not detected as the return diagnostics for `Initialise` are ignored. That check can be done as early as during parsing however, as the names of blocks are not dynamic in the slightest (no interpolation possible), so we move that detection logic into `Parse`, so that the behaviour is coherent between all commands.	2 years ago
Lucas Bajolet	14cf4b40d4	hcl2template: recursively evaluate local variables The logic for evaluating local variables used to rely on their definition order, with some edge cases. Typically `locals` blocks define multiple local variables, which don't necessarily appear in the same order at evaluation as within the template, leading to inconsistent behaviour, as the order in which those are added to the list of local variables is non-deterministic. To avoid this problem, we change how local variables are evaluated, and we're adopting a workflow similar to datasources, where the local variables first build a list of direct dependencies. Then when evaluation happens, we evaluate all the dependencies recursively for each local variable, which takes care of this issue. As with Datasources, we add a cap to the recursion: 10. I.e. if the evaluation of a single variable provokes an infinite recursion, we stop at that point and return an error to the user, telling them to fix their template.	2 years ago
Lucas Bajolet	5673af108f	hcl2template: split GetVarsByType in two functions GetVarsByType is a function that gets a list of Traversals from a hcl Block. This approach works when what we are visiting is indeed one, however when we can get an immediate list of Traversals, but want to filter them based on their roots, we have to reimplement parts of that function. Therefore, we split this function in two, GetVarsByType still keeps its current behaviour, but the filtering step is exposed as another function now: FilterTraversalsByType, so we can reuse it elsewhere.	2 years ago
Lucas Bajolet	9d1dc7d41d	packer_test: disable checkpoint for test cmds	2 years ago
Lucas Bajolet	dbaaab512a	packer_test: add SkipNoAcc function The SkipNoAcc function on PackerTestSuite allows to mark a test run as not to be run every time we run `make test`, but only when PACKER_ACC=1 is set in the environment. This allows us to skip executing tests that are either long-running, or that depend on external dependencies (typically Github), which have a higher potential to fail on a normal run of Packer tests.	2 years ago
Lucas Bajolet	d65074c05c	packer_test: dump command outs in case of failure When a test fails to exert its assertions on the command-line output, a test fails, but we don't necessarily can troubleshoot what happened, especially when this happens in a CI environment. Therefore, for convenience, we add the faculty for packerCommand.Assert to automatically dump a command's output (both stdout and stderr) if a test fails.	2 years ago
Lucas Bajolet	4a05d19a89	packer_test: add capability to provide stdin Some commands need to have an input in order to work. For those, we add the capability for the packerCommand struct to have their stdin defined from a string, which is then fed to the command being executed.	2 years ago
Lucas Bajolet	39a483f762	packer_test: add func to test a cmd multiple times When a Packer command is created for testing the tool, we generally run it once, then the command is essentially nooping. This change allows us to run Packer multiple times with the same parameters, and make sure all runs conform to a specific list of checks. This allows us to more reliably test non-deterministic behaviours.	2 years ago
Ryan Johnson	5e9f5f4a99	docs: update provisioners Updates the provisioners documentation for a better reader experience by including a list of the built-in provisioners and a link to the community supported provisioners that are all withing the navigation tree. Ref: #12898 Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>	2 years ago
Ryan Johnson	66abaaeb4e	docs: string templates Adds an example of a string template being used. The example demonstrates how a template sequence can be used to embed the value of a variable into a string that can be used as script content. Ref: #12651 Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>	2 years ago
Ryan Johnson	51cbe0ba81	docs: update ssh Adds documentation for `ssh_keypair_name`, `ssh_agent_auth`, `temporary_key_pair_name`, and `ssh_private_key_file`. The note is updated noting that not all builders support these options. Ref: #10722 Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>	2 years ago
Ryan Johnson	f7cf9ede19	docs: update init Adds additional examples and help regarding the use of `packer init`. Ref: #11541 Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>	2 years ago
dependabot[bot]	e6acdd5f52	build(deps): bump golang.org/x/net in /packer_test/plugin_tester Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](https://github.com/golang/net/compare/v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	2 years ago
dependabot[bot]	5e7607184d	build(deps): bump github.com/go-jose/go-jose/v3 Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose) from 3.0.0 to 3.0.3. - [Release notes](https://github.com/go-jose/go-jose/releases) - [Changelog](https://github.com/go-jose/go-jose/blob/v3.0.3/CHANGELOG.md) - [Commits](https://github.com/go-jose/go-jose/compare/v3.0.0...v3.0.3) --- updated-dependencies: - dependency-name: github.com/go-jose/go-jose/v3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	2 years ago
Lucas Bajolet	6e45bf3c31	packer_test: add remote install with pre-rel test Remotely installing plugins with a pre-release as part of the constraint is unsupported by Packer, and should error if that happens. This test makes sure that this gets treated as an error if that's the case, even before attempting to connect to the source.	2 years ago
Lucas Bajolet	8d7a8f126d	packer_test: remove %d from workdir path '%d' gets output as-is in the temporary workdir we create. This is unnecessary and could even be problematic in some cases, so we scrub it from the MkdirTemp call.	2 years ago
Lucas Bajolet	8402e00222	packer_test: add test with config.json/components Since legacy config files may declare single plugin components, we need to warn that they're not supported anymore. This is in process of being PR'd into main, but to ensure the config works as intended and we do get the error, we add some tests for that.	2 years ago
Wilken Rivera	1d65ad676f	Add test cases for init command These changes include a series of test cases for validating packer init using the force and upgrade flag. Include in this test is a test case for validating the plugin installation error when init encounters a plugin whose reported version does not match the version within the plugin name. ``` --- PASS: Test_PackerCoreSuite (18.66s) --- PASS: Test_PackerCoreSuite/TestPackerInitForce (4.91s) --- PASS: Test_PackerCoreSuite/TestPackerInitForce/installs_any_missing_plugins (2.76s) --- PASS: Test_PackerCoreSuite/TestPackerInitForce/reinstalls_plugins_matching_version_constraints (2.14s) --- PASS: Test_PackerCoreSuite/TestPackerInitUpgrade (3.70s) --- PASS: Test_PackerCoreSuite/TestPackerInitUpgrade/upgrades_a_plugin_to_the_latest_matching_version_constraints (2.02s) --- PASS: Test_PackerCoreSuite/TestPackerInitWithMixedVersions (1.96s) --- PASS: Test_PackerCoreSuite/TestPackerInitWithMixedVersions/skips_the_plugin_installation_with_mixed_versions_before_exiting_with_an_error (1.96s) --- PASS: Test_PackerCoreSuite/TestPackerInitWithNonGithubSource (1.22s) --- PASS: Test_PackerCoreSuite/TestPackerInitWithNonGithubSource/try_installing_from_a_non-github_source,_should_fail (0.07s) --- PASS: Test_PackerCoreSuite/TestPackerInitWithNonGithubSource/manually_install_plugin_to_the_expected_source (0.59s) --- PASS: Test_PackerCoreSuite/TestPackerInitWithNonGithubSource/re-run_packer_init_on_same_template,_should_succeed_silently (0.55s) ```	2 years ago
Lucas Bajolet	19594be808	packer_test: add test with both pre/meta in plugin To make sure we do scrub the metadata in the plugin name when installing it from a local binary, we add a test that does that installation with both alternatives: 1.0.0-dev and 1.0.0-dev+metadata, which should result in only one alternative being installed (the last one that succeeded).	2 years ago
Lucas Bajolet	51cdd9c4a9	packer_test: amend installation with meta test The installation with a metadata part in the version for a plugin had one test that relied on the plugin directories being populated with packer plugins install --path. This could change in the future, while the command should remain functional, so we explicitely call it in the test instead of through the function that creates/populates a temp plugin dir.	2 years ago
Lucas Bajolet	3661d97fc0	packer_test: add convenience func for line count When building a pipeline to count the number of lines returned by Packer, it can be a bit cumbersome to have to chain the calls to MkPipeCheck to do that check, so we add one convenience function for the simplest case: counting the number of lines on stdout, without any kind of filtering.	2 years ago
Wilken Rivera	c6388d4680	packer_test: Add tests for invalid plugin remove use cases	2 years ago
Wilken Rivera	1cace90289	packer_test: Add tests for valid plugin remove use cases	2 years ago
Lucas Bajolet	9f7098b230	packer_test: fix typo in error message for cleanup	2 years ago
Lucas Bajolet	a2e08329a3	packer_test: fix shasum file name for tests When manually installing a plugin to the plugin directory, we compute a SHA256SUM file from the plugin binary, and install it alongside it so we can test the loading process for Packer. In the introduction of the function, we added a check that if we were running on Windows, we'd remove the extension of the sumfile's name before writing it. This is actually not necessary (and breaks the loading logic) as Packer looks for the name of the plugin with extension, followed by _SHA256SUM in order to compare the effective digest of the file to the one written to this file. Since this prevents the tests that use this function from succeeding in a Windows environment, we remove this extra step.	2 years ago
Lucas Bajolet	2a414af35f	packer_test: set TMP envvar for commands Windows relies on the `TMP` (or alternatives) being set in the environment in order to be able to create temporary directories and files. If this is not set, the `os.TempDir` function defaults on the windows installation root directory (typically C:\Windows), leading to permission errors when running Packer in the context of a test, as we're installing plugins in a temporary directory. To avoid this problem, we get the current setting from the test's invocation environment, and forward it to the subcommand we execute for our tests.	2 years ago
Lucas Bajolet	f77da46b3f	packer_test: compile packer with .exe for Windows Since on Windows extensions are mandatory in order to have something executable, we compile Packer with a `.exe` suffix during tests, so we can use the executable afterwards to run tests with.	2 years ago
Lucas Bajolet	7124cf81fa	packer_test: test build/validate with ignore flag As we're introducing a --ignore-prerelease-plugins flag to both the validate and build subcommands, we need to make sure they work as we expect it to, so we add a test case for that.	2 years ago
Lucas Bajolet	66e70a863d	packer_test: add test for plugin with meta in name Plugins with metadata information in their file name (i.e. v1.0.0+metadata) should be ignored by Packer as they could introduce ambiguity since the metadata is free-form, so we add that test to make sure Packer behaves coherently.	2 years ago
Lucas Bajolet	a49da98350	packer_test: test non-canonical plugin loading If a plugin is installed with a non-canonical version in its name (e.g. 01.01.01), Packer rejects it with a message to that effect in stderr, so we add a test for this use-case.	2 years ago
Lucas Bajolet	707e40e2e6	packer_test: add func for "manual" plugin install Installing a plugin manually to a directory is something needed for some tests, especially those not relying on packer commands to install plugins as they reject/correct the path/version. Therefore this function is introduced so we have an easy way to install a binary as a plugin somewhere on the provided plugin directory.	2 years ago
Lucas Bajolet	901f31ad82	packer_test: fix ExpectedName to not clean version The ExpectedInstalledName function used to compute the expected name of a plugin binary for a given version, based on the invoker's environment, used to cleanup the version string passed in parameter of the function, which could be problematic. Besides the logic applied would produce some invalid binary names as the prerelease plugin would not have a `-` separator, so the resulting plugin would be ignored, and we couldn't test metadata rejection with this logic. This commit therefore changes how the function works: the version string is still parsed to account for manipulation errors, but the string is left as-is for the final binary name.	2 years ago
Lucas Bajolet	7e0b27adaa	packer_test: add init test on non-gh source URI	2 years ago
Lucas Bajolet	4e20956bae	packer_test: don't error on empty pipeline If for some reason we only want to run a test on either stream without doing some manipulation beforehand, we can run a PipeChecker, however these would error if no pipe gadget was defined, preventing this use-case. Instead of errorring then, this commit just ignores if no pipe is present, as none is required for the test to run.	2 years ago
Lucas Bajolet	7943b8ce4e	packer_test: add test for plugin remove with path	2 years ago
Lucas Bajolet	7f9276d439	packer_test: rename mini_plugin to plugin_tester Since the tester plugin used for blackbox testing is called packer-plugin-tester, we rename the directory it's stored in to plugin_tester.	2 years ago
Lucas Bajolet	9ebc961374	packer_test: remove testing.T arg on Assert Since the command object is created using the TestSuite as argument, we can keep a reference to the test suite's scoped T() instance for the command's lifecycle, and reuse it later during `Assert`, instead of needing to pass it as argument when invoking the function.	2 years ago
Lucas Bajolet	95b9a3c03e	packer_test: migrate envvar test to pipe funcs	2 years ago
Lucas Bajolet	ee9b4943da	packer_test: remove local alias to ts.T()	2 years ago
Lucas Bajolet	2d114a044a	packer_test: add functions for managing pipechecks Instead of manually creating and populating a PipeChecker, we add functions to do this.	2 years ago
Lucas Bajolet	d175625869	packer_test: add Tee pipe gadget When troubleshooting a pipeline for a test, it can be useful to print the input out without necessarily preventing the pipeline to work. The Tee gadget is exactly made for this purpose, the input of the Tee is printed out through `t.Log`, and the input is forwarded to the next step in the pipeline.	2 years ago
Lucas Bajolet	830ac98e39	packer_test: add test for multiple plugin paths When the PACKER_PLUGIN_PATH envvar is defined in the environment, Packer uses it as the source of truth for the directories in which to look for plugins to load. Previously, we used to support multiple directories separated by the OS-specific path separator (i.e. : on UNIX, ; on Windows). Since this changed, and Packer returns an error to the user, we make sure that this is well-documented and tested through this extra test.	2 years ago
Lucas Bajolet	ae78d78736	packer_test: fix int compare checker The IntCompare checker converts the input string into an int through strconv.Atoi, which fails when the string isn't valid base 10. This definition of "valid" also excludes whitespace, which occurs often through piping gadgets, but shouldn't be a reason to fail that check, so we trim the whitespace from the input string.	2 years ago
Wilken Rivera	2fe567d3d5	Move into a packer_test pkg for black-box testing	2 years ago
Lucas Bajolet	4a028ec735	test: add more tests for Packer core	2 years ago

1 2 3 4 5 ...

18614 Commits (078ad45860feb0be2db62d62bc79244ed7ced09b) All Branches Search

18614 Commits (078ad45860feb0be2db62d62bc79244ed7ced09b)

All Branches