builder/googlecompute: Derive network and subnetwork IDs locally

This change constructs partial URLs for networks and subnetworks if they
are not already partial or full URLs (i.e., they do not contain a '/' in
their name). Network and subnetwork self-links are no longer retrieved
from the API.

Previously, if a user did not provide the network or subnetwork as a
fully-qualified URL (i.e., self-link), the builder would make
compute.(sub)networks.get API calls with the provided identifier to
discover the self-link. This requires the user or service account Packer
is using to have permission to describe those network resources, which
is becoming less common as IAM is used more. Specifically, a user may
have permission to launch a VM into a network/subnetwork, but will not
have permission to call APIs to describe network resources.

builder/googlecompute/driver_gce.go

@@ -10,7 +10,6 @@ import (
 	"fmt"
 	"log"
 	"net/http"
-	"net/url"
 	"runtime"
 	"strings"
 	"time"
@@ -299,55 +298,54 @@ func (d *driverGCE) RunInstance(c *InstanceConfig) (<-chan error, error) {
 	}
 	// TODO(mitchellh): deprecation warnings
 
-	networkSelfLink := ""
+	networkId := ""
-	subnetworkSelfLink := ""
+	subnetworkId := ""
-
+
-	if u, err := url.Parse(c.Network); err == nil && (u.Scheme == "https" || u.Scheme == "http") {
+	// Apply network naming requirements per
-		// Network is a full server URL
+	// https://cloud.google.com/compute/docs/reference/latest/instances#resource
-		// Parse out Network and NetworkProjectId from URL
+	switch c.Network {
-		// https://www.googleapis.com/compute/v1/projects/<ProjectId>/global/networks/<Network>
+	// It is possible to omit the network property as long as a subnet is
-		networkSelfLink = c.Network
+	// specified. That will be validated later.
-		parts := strings.Split(u.String(), "/")
+	case "":
-		if len(parts) >= 10 {
+		d.ui.Message(fmt.Sprintf("Network: will be inferred from subnetwork"))
-			c.NetworkProjectId = parts[6]
+		break
-			c.Network = parts[9]
+	// This special short name should be expanded.
+	case "default":
+		networkId = "global/networks/default"
+	// A value other than "default" was provided for the network name.
+	default:
+		// If the value doesn't contain a slash, we assume it's not a full or
+		// partial URL. We will expand it into a partial URL here and avoid
+		// making an API call to discover the network as it's common for the
+		// caller to not have permission against network discovery APIs.
+		if !strings.Contains(c.Network, "/") {
+			networkId = "projects/" + c.NetworkProjectId + "/global/networks/" + c.Network
+			d.ui.Message(fmt.Sprintf("Network name: %q was expanded to the partial URL %q", c.Network, networkId))
 		}
 	}
-	if u, err := url.Parse(c.Subnetwork); err == nil && (u.Scheme == "https" || u.Scheme == "http") {
-		// Subnetwork is a full server URL
-		subnetworkSelfLink = c.Subnetwork
-	}
-
-	// If subnetwork is ID's and not full service URL's look them up.
-	if subnetworkSelfLink == "" {
 
-		// Get the network
+	// Apply subnetwork naming requirements per
-		if c.NetworkProjectId == "" {
+	// https://cloud.google.com/compute/docs/reference/latest/instances#resource
-			c.NetworkProjectId = d.projectId
+	switch c.Subnetwork {
+	case "":
+		// You can't omit both subnetwork and network
+		if networkId == "" {
+			return nil, fmt.Errorf("both network and subnetwork were empty.")
 		}
-		d.ui.Message(fmt.Sprintf("Loading network: %s", c.Network))
+		// An empty subnetwork is only valid for networks in legacy mode or
-		network, err := d.service.Networks.Get(c.NetworkProjectId, c.Network).Do()
+		// auto-subnet mode. We could make an API call to get that information
-		if err != nil {
+		// about the network, but it's common for the caller to not have
-			return nil, err
+		// permission to that API. We'll proceed assuming they're correct in
-		}
+		// omitting the subnetwork and let the compute.insert API surface an
-		networkSelfLink = network.SelfLink
+		// error about an invalid network configuration if it exists.
-
+		break
-		// Subnetwork
+	default:
-		// Validate Subnetwork config now that we have some info about the network
+		// If the value doesn't contain a slash, we assume it's not a full or
-		if !network.AutoCreateSubnetworks && len(network.Subnetworks) > 0 {
+		// partial URL. We will expand it into a partial URL here and avoid
-			// Network appears to be in "custom" mode, so a subnetwork is required
+		// making a call to discover the subnetwork.
-			if c.Subnetwork == "" {
+		if !strings.Contains(c.Subnetwork, "/") {
-				return nil, fmt.Errorf("a subnetwork must be specified")
+			subnetworkId = "projects/" + c.NetworkProjectId + "/regions/" + c.Region + "/subnetworks/" + c.Subnetwork
-			}
+			d.ui.Message(fmt.Sprintf("Subnetwork: %q was expanded to the partial URL %q", c.Subnetwork, subnetworkId))
-		}
-		// Get the subnetwork
-		if c.Subnetwork != "" {
-			d.ui.Message(fmt.Sprintf("Loading subnetwork: %s for region: %s", c.Subnetwork, c.Region))
-			subnetwork, err := d.service.Subnetworks.Get(c.NetworkProjectId, c.Region, c.Subnetwork).Do()
-			if err != nil {
-				return nil, err
-			}
-			subnetworkSelfLink = subnetwork.SelfLink
 		}
 	}
 
@@ -417,8 +415,8 @@ func (d *driverGCE) RunInstance(c *InstanceConfig) (<-chan error, error) {
 		NetworkInterfaces: []*compute.NetworkInterface{
 			{
 				AccessConfigs: []*compute.AccessConfig{accessconfig},
-				Network:       networkSelfLink,
+				Network:       networkId,
-				Subnetwork:    subnetworkSelfLink,
+				Subnetwork:    subnetworkId,
 			},
 		},
 		Scheduling: &compute.Scheduling{