1961 Commits (5.0)

Author	SHA1	Message	Date
John Ralls	89f41a305c	Merge new potfile reflecting string changes.	3 years ago
John Ralls	576fc9b52c	Fix quotes on Windows. ... Boost process wchar_t conversion chokes if it's fed an empty string. This would happen when the user had no alphavantage key. Separate the process invocation to not present the empty value to boost process.	3 years ago
John Ralls	90e1e2d1c3	Merge Bob Fewell's 'bug798558' into master.	3 years ago
John Ralls	0c3e85404d	Avoid crash from trying to free an unallocated char*.	3 years ago
Christopher Lam	97f0653238	[gnc-quotes] g_free a char* from gnc_prefs_get_string ... ultimately gets char* from g_settings_get_string and must be freed	3 years ago
Robert Fewell	a576dd87a4	Bug798558 - Irregular line spacing in Account Tree View ... When securities are in the list, the rows look twice as high as though there is a linefeed at the end. This is partly due to commit for bug 797501 which worked at the time but a change in pango 50.4 to do with wrapping has highlighted this bug. To fix this only wrap currencies with ltr bidi isolate characters in gnc_print_amount_with_bidi_ltr_isolate	3 years ago
John Ralls	00c560d8f5	Move operator==(const GncGUID&, const GncGUID&) to guid.[ch]pp.	3 years ago
John Ralls	352ab8a0e5	Merge Richard Cohen's 'minor-options-fixes' into master.	3 years ago
John Ralls	d192be5307	Merge Richard Cohen's 'cleanup-cflags-deprecated' into master.	3 years ago
Richard Cohen	24f52d9b17	Remove incorrect operator!= for GncItem ... It's better to use the default std::pair implementation - spotted by clang-tidy bugprone-suspicious-string-compare - will always return false, because type is the same Also, - remove redundant "using GncItem ..."	3 years ago
Richard Cohen	b5f3f99035	Fix incorrect use of remove_if() ... - spotted by clang-tidy bugprone - probably no visible effects because of uniqueness, and other checks libgnucash/engine/gnc-optiondb.cpp:149:5: warning: this call will remove at most one item even when multiple items should be removed [bugprone-inaccurate-erase] m_options.erase(std::remove_if(m_options.begin(), m_options.end(), ^ libgnucash/engine/gnc-optiondb.cpp:358:5: warning: the value returned by this function should be used [bugprone-unused-return-value] std::remove_if(m_callbacks.begin(), m_callbacks.end(), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libgnucash/engine/gnc-optiondb.cpp:358:5: note: cast the expression to void to silence this warning	3 years ago
John Ralls	b4b8431984	Bug 798778 - GnuCashquits abruptly when attempting to edit options… ... for certain reports. Those reports being ones using complex options, apparently because the callbacks weren't protected from Guile's garbage collector. So replace the anyway ugly hack of a void* with a std::any wrapping a class holding a std::unique_ptr with a custom deleter. The constructor calls scm_gc_protect_object on the SCM containing the callback and the custom deleter calls scm_gc_unprotect_object. The copy constructor, required for std::any, makes a new std::unique_ptr and calls scm_gc_protect_object again ensuring that the protect and unprotect calls are symmetrical. Meanwhile std::any hides the Guile dependency from all the classes that don't need to know about it. The only ugliness is that there's no good place to put a common implementation of SCNCallbackWrapper so it's repeated in gnc-optiondb.i and dialog-options.cpp.	3 years ago
Richard Cohen	30586ac3e6	Push -Wno-error=deprecated-declarations from C*_FLAGS down to the target	3 years ago
Geert Janssens	1f0a69a804	Properly parse plus signs while importing numbers ... Silly copy/paste error.	3 years ago
John Ralls	a44b3664e2	[c++options] Implement GncOptionGncOwnerValue class. ... GncOwners aren't QofInstances and have limited lifetimes so an option must hold its own, wrapped in std::unique_ptr for memory management.	3 years ago
John Ralls	8db8105850	[c++options] Warn when an option variant type's set_value isn't found.	3 years ago
John Ralls	83829e6513	Merge branch 'maint'	3 years ago
John Ralls	1020bde89c	Fix crashes in test-engine on Arch Linux. ... Root cause is mutating a list while it's iterating. We're able to protect it in two cases, have to copy it in xaccTransScrubGainsDate.	3 years ago
Geert Janssens	d75ab275f1	Eliminate gnc-csv-account-map.[ch] ... The code is was only used by the csv import assistant and forced gtk as a dependency on gnc-imp-props-tx Part has been moved to Account, other bits have been moved to the importer code where they were used.	3 years ago
Geert Janssens	13ec4bb594	xaccParseAmount... - some code cleanups ... - declare at first use - compact tests - reduce use of {}	3 years ago
Geert Janssens	8010d9646c	Restore proper indentation ... It got mixed up while refactoring the various xaccParseAmountXYZ functions	3 years ago
John Ralls	07d8ebd90c	Add JSON::Parse to gnc-fq-update. ... Required by finance-quote-wrapper to interpret quoter output.	3 years ago
Richard Cohen	329a2f7d42	Guard against some possible null pointer dereferences ... Found by gcc 12 when compiling with "-O2 -Wnull-dereference"	3 years ago
Richard Cohen	3a7464a312	Remove redundant uses of cmake -E env ... - In GncAddTest, set_tests_properties() is already setting the env - In the other uses, there is no change to the environment	3 years ago
John Ralls	cdb674ebf1	[c++options]Really fix the gnc_option_db_lookup_string_value leak ... By deleting the function and using GncOptionDbImpl::lookup_string_option directly. It returns a string that we don't have to worry about memory-managing. Also create a new GncOptionDbImpl::set_string_option to replace gnc_option_db_set_string_value.	3 years ago
John Ralls	92071e8844	[c++options] Fix leak.	3 years ago
John Ralls	f735c64cac	Merge Richard Cohen's 'extern-c-part2' into master.	3 years ago
Richard Cohen	7b47c07f8e	Don't use extern "C" around #includes ... Some I missed the first time. Some are new.	3 years ago
Frank H. Ellenberger	bdb12fd94f	I18N: Change TaxTable to "Tax Table" for consistency	3 years ago
John Ralls	bbfa378783	Don't crash and do pass tests.	3 years ago
John Ralls	af02dae286	Fixups for merging into master instead of maint.	3 years ago
John Ralls	1eecb9f5c0	[c++ options] Fix locale dependency in test-gnc-option-scheme-output. ... Created by using std::to_string() in GncOptionRangeValue::serialize. It wraps sprintf that reads the locale. Use ostringstream instead.	3 years ago
Christopher Lam	76014f18a0	[account.cpp] don't cache char* [fails]	3 years ago
Christopher Lam	3d381eb6fd	[gnc-lot] don't cache char*	3 years ago
Christopher Lam	50f998fad8	[gncInvoice] don't cache char*	3 years ago
Christopher Lam	c9dc71978b	[gnc-commodity] don't cache char*	3 years ago
Christopher Lam	57fcaabd8f	[Split.c] don't cache char*	3 years ago
Richard Cohen	be41bde58a	Add missing MAKE_LINKS, and the local scm directory to %load-path ... Before this change, "make check" would fail after rm -rf ${build}/share/guile/site/*/gnucash/	3 years ago
John Ralls	675d894128	Merge Richard Cohen's 'cleanup-options' into master.	3 years ago
John Ralls	ca73b00039	Merge Richard Cohen's 'cleanup-boost' into master.	3 years ago
John Ralls	3d5e27982f	Merge branch 'maint'	3 years ago
John Ralls	7f0353adc4	Fix a missed g_value_dup_string and some no longer used variables.	3 years ago
John Ralls	8a7c539258	Bug 798748 - Transaction Notes field's value does not appear in... ... reverse transaction. The proximate cause was that xaccTransBeginEdit put the KVP cache variable of the new transaction in a state that prevented the value from being copied. More generally the KVP cache variables didn't handle any invalidating events. With the change to GValue usage in qof_instance_get_kvp it's now a simple memory dereference with no copying except for POD types so caching is no longer useful. This commit removes caching from Transaction, eliminating the notes problem.	3 years ago
John Ralls	ddc3f28899	[kvp] Use static strings and boxed in gvalue_from_kvp_value. ... Saves allocating and copying complex values, avoiding potential memory leaks.	3 years ago
Richard Cohen	9f06859390	Remove references to old boost versions ... we already require 1.67	3 years ago
Richard Cohen	3d995de2ab	Refactor: use default GncOptionValue copy constructor	3 years ago
Richard Cohen	1b0af4246a	Refactor: remove extra template parameter from member functions	3 years ago
Richard Cohen	87c52f53fa	Update some references to hello-world.scm	3 years ago
Richard Cohen	ec169e6e24	Fix some non-translatable typos	3 years ago
Christopher Lam	47b85d3b2f	[gnc-xml-backend.cpp] g_free char* from g_path_get_dirname	3 years ago