1462 Commits (fa4de5fd36b8013aa240fbb4630df103db4141ed)

Author	SHA1	Message	Date
Frank H. Ellenberger	bdb12fd94f	I18N: Change TaxTable to "Tax Table" for consistency	3 years ago
John Ralls	7f0353adc4	Fix a missed g_value_dup_string and some no longer used variables.	3 years ago
John Ralls	8a7c539258	Bug 798748 - Transaction Notes field's value does not appear in... ... reverse transaction. The proximate cause was that xaccTransBeginEdit put the KVP cache variable of the new transaction in a state that prevented the value from being copied. More generally the KVP cache variables didn't handle any invalidating events. With the change to GValue usage in qof_instance_get_kvp it's now a simple memory dereference with no copying except for POD types so caching is no longer useful. This commit removes caching from Transaction, eliminating the notes problem.	3 years ago
John Ralls	ddc3f28899	[kvp] Use static strings and boxed in gvalue_from_kvp_value. ... Saves allocating and copying complex values, avoiding potential memory leaks.	3 years ago
Christopher Lam	47b85d3b2f	[gnc-xml-backend.cpp] g_free char* from g_path_get_dirname	3 years ago
Christopher Lam	89e63ef672	Bug 798754 - Build fails with gcc 13 and glib > 2.76, ter	3 years ago
Christopher Lam	abcce5000c	Bug 798754 - Build fails with gcc 13 and glib > 2.76, bis	3 years ago
John Ralls	184669f517	Bug 798754 - Build fails with gcc 13 and glib > 2.76 ... GLib 2.76 introduced a no-discard warning on g_string_free if the second parameter is FALSE. This revealed a string leak and a correct usage that didn't use the return value.	3 years ago
John Ralls	ce3447e6ea	Bug 798740 - Build fails with gcc 13 ... Protect against passing an lseek failure rv to read().	3 years ago
Geert Janssens	894f8241e1	Revisit invoice payment in multi-currency context ... - Show proper amount in dialog when applying or editing an existing transaction as payment - Be more careful not to waste the existing payment split - If the user changed the payment amount while starting from an existing transaction unreconcile the changed payment split - Avoid needlessly changing transaction currency (only do so if the user chose a new transfer account and the old currency is neither the new transfer account's currency nor the post account's currency)	3 years ago
luzpaz	67ab9e90d2	Fix some typos	3 years ago
John Ralls	f4c6d65395	Merge Bob Fewell's 'nofree' into maint.	3 years ago
John Ralls	46f9fb01c9	Simplify gnc_commodity equality and compare functions. ... gnc_commodity_compare is used for sorting and so needs to have a less-than return value. The only place it's used presents nothing to the UI; a GncGUID ordering is fast and stable. GnuCash allows only one commodity per book for any namespace/mnemonic pair, so the exhaustive string comparisons are superflous. While the current engine design allows only one instance of any object, meaning that a pointer comparison is sufficient to determine equality, that may not be true in the future, but the GncGUID is guaranteed to sufficiently identify a single commodity. Note that gnc_commodity_equiv is used to enforce that single-commodity rule and so cannot use GncGUID comparison.	3 years ago
Richard Cohen	19bbde7000	Fix some typos	3 years ago
richardcohen	f3cc223f5f	Fix some bad code formatting	3 years ago
Robert Fewell	6df866f876	Add tests for the reconcile account functions	3 years ago
Robert Fewell	fd37ee997d	Fix getting xaccAccountGetReconcilePostponeBalance ... Change the G_VALUE from a INT64 to BOXED.	3 years ago
Alex Aycinena	1085d8920b	Update Form/Schedule line references for 2022 for the US Income Tax Report	3 years ago
John Ralls	b922cfd78d	Bug 798679 - Unicode normalization should be used for comparison but not stored. ... Change to NFC normalization for all comparisons because the Unicode meaning of compatible might collide with the user's intent.	3 years ago
John Ralls	091d4aff22	Bug 798657 - Import Summary language is wrong ... Root cause is using boost::locale::translate because it ignores the LANGUAGES environment variable and doesn't support different values for LC_MESSAGES, LC_DATE, LC_MONETARY, and LC_NUMERIC. That makes it impossible to configure a user environment that presents translated strings in a different locale from the one applied to formatting dates and numbers. To correct this replace all use of boost::locale::translate with GNU gettext.	3 years ago
John Ralls	73a134730f	Bug 798680 - Not able to match a reverse transaction of a... ... previously matched transaction. Cloned transactions and copied splits shouldn't keep the online-id slot.	3 years ago
John Ralls	b4bab92da2	Bug 798664 - Result of 'gnucash --nofile' is marked dirty ... Don't create a new book in the new-user dialog unless the user says to. Don't automatically create a new book when retrieving default commodities because the retrieve might be requested in a context like the Preferences dialog when there is no book. Some report tests relied on requesting the default commodity creating the book, so in those tests ensure that the book is created first.	3 years ago
John Ralls	fae5de80d3	Undo unintended change in Bug 798679 commit.	3 years ago
John Ralls	fd2761bd68	Bug 798679 - Fullwidth characters cannot be pasted as-is in register fields ... Control character check doesn't need normalization, the control character codepoints aren't graphic and so can't be composed nor have compatible equivalents.	3 years ago
Geert Janssens	98251d59a6	Bug 798672 - Preferences are not saved nor loaded, ERROR <GLib-GIO> g_settings_new_full: assertion 'schema != NULL' failed ... Apparently it was a failure on our side to properly look up requested gsettings schema.	3 years ago
Marco Scardovi	6fe2028bca	Fix test ... Signed-off-by: Marco Scardovi <mscardovi@icloud.com>	3 years ago
Robert Fewell	59d95a4ce6	Bug 798545 - Crash when updating document link on vendor bill ... There were two issues here, the first one was that the copied doclink was pointing to the original doclink which lead to a double-free. The second is the setting of the doclink on the copied invoice needs to be done with gncInvoiceSetDocLink otherwise on closure the doclink value will disappear.	3 years ago
Christopher Lam	3d8a28898d	[gnc-budget] gnc_budget_get_account_period_note returns a const ... to harmonize with all other char getters	3 years ago
Christopher Lam	2ee0c98200	[gnc-budget] use operator[] instead of find() and insert() ... - avoid hashing Account* twice. one call to operator[] is sufficient. - don't need use std::move with better constructors - sanity check - can't have a budget with num_periods = 0 - remove unused headers	3 years ago
Christopher Lam	6f80c548e6	[gtest-qofevent.cpp] comprehensive tests for qofevent	4 years ago
Christopher Lam	b87aa004f9	[test-qofbook] add tests for unknown features ... tests that gnc_features_test_unknown returns a suitable error message	4 years ago
John Ralls	b9077bccd3	Bug 798640 - Segfault when running saved report	4 years ago
Christopher Lam	f2354d6b2a	[test-qofbook.c] add test for gnc_features_set_unused	4 years ago
Christopher Lam	1516bb18b0	[gnc-features.cpp] backport gnc_features_set_unused from master	4 years ago
Christopher Lam	a078921a33	[qofbook.cpp] backport qof_book_unset_feature from master	4 years ago
John Ralls	cf088f2a70	Merge John Ralls's 'Bug798614' into maint.	4 years ago
Christopher Lam	093aa81ed1	[qofbook.cpp] deprecate qof_book_get_features	4 years ago
Christopher Lam	8192deff37	[gnc-features.cpp] convert to cpp ... - don't need to create/destroy GHashTable for each feature query - plugs leak: g_hash_table_unref (features_used) not always called properly - to check 1 feature, don't need to traverse whole GHashTable	4 years ago
Christopher Lam	6f6d2fef48	[test-qofbook] basic features test ... sets a feature and tests it's set. it's impossible to design a book with unknown features using the API.	4 years ago
John Ralls	f24c2c8bdd	Instrument failure to set the account when creating a split.	4 years ago
Mike Alexander	2d3e80ea08	Compatibility with XCode's "new build system" ... With XCode 14 or newer CMake tries to use the "new build system" which has a requirement that if two targets depend on the same generated file one of them must depend on the other. This commit adds reduntant dependencies to satisfy this requirement.	4 years ago
John Ralls	c7d1b6ab26	Bug 798633 - 4.12 build failure on 32-bit Linux: "No code for module"	4 years ago
John Ralls	8cb8f5067d	Remove non-ISO4217 currency codes from gnc-euro table. ... They're not reachable because they don't have commodities associated with them.	4 years ago
John Ralls	d8417c3cfa	Move gnc-euro.[ch] to engine and unit test it.	4 years ago
John Ralls	2774f8f88c	Bug 798614 - Croatia to join the Euro ... Add HRK to the conversion array.	4 years ago
John Ralls	2505955ab9	Fix test failure from Bug 798616 fix.	4 years ago
John Ralls	7c350c3ae5	Bug 798616 - Can't register amount greater than 9,000,000,000 ... Because when loading the value the split in the xml backend doesn't yet have a parent so the code tried to convert to GNC_COMMODITY_MAX_FRACTION and if the numerator was larger than 10^10 that would overflow. To fix it this changes the "don't know" response to get_currency_denom and get_commodity_denom to GNC_DENOM_AUTO which will normally leave the denominator alone.	4 years ago
Frank H. Ellenberger	47fa8b281e	Merge PR #1425 into maint	4 years ago
John Ralls	a807d3e6b7	Create function gnc_tm_get_today_neutral. ... To complement gnc_tm_get_today_begin and gnc_tm_get_today_end.	4 years ago
luz paz	ba94730a23	Fix various typos ... Found via `codespell`	4 years ago