gnucash

Commit Graph

Author	SHA1	Message	Date
John Ralls	9a1a90d8d0	Merge branch 'maint'	3 years ago
richardcohen	f3cc223f5f	Fix some bad code formatting	3 years ago
richardcohen	8044f79f75	Silence the boost (<1.76) warning message from .../gnucash-4.8/libgnucash/app-utils/gnc-quotes.cpp:33: /usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’ The issue was fixed in boost 1.76, but, e.g ubuntu 22.04 has boost 1.74	3 years ago
Christopher Lam	fd007a0af1	Merge branch 'maint'	3 years ago
Robert Fewell	6df866f876	Add tests for the reconcile account functions	3 years ago
Robert Fewell	fd37ee997d	Fix getting xaccAccountGetReconcilePostponeBalance Change the G_VALUE from a INT64 to BOXED.	3 years ago
John Ralls	fb9947b7b6	Rename GncDateTime's ymd to gnc_ymd to avoid a name conflict with Carbon.	3 years ago
John Ralls	fed4daf4e7	[c++ quotes] Make sure to include all of the required Boost libraries. Also Boost-iostreams needs winsock but doesn't tell Cmake, so explicitly add it to the link list.	3 years ago
Christopher Lam	c65b36490a	Merge branch 'master-progress'	3 years ago
Frank H. Ellenberger	506a1b3c5e	Merge branch 'maint'	3 years ago
Alex Aycinena	1085d8920b	Update Form/Schedule line references for 2022 for the US Income Tax Report	3 years ago
John Ralls	b922cfd78d	Bug 798679 - Unicode normalization should be used for comparison but not stored. Change to NFC normalization for all comparisons because the Unicode meaning of compatible might collide with the user's intent.	3 years ago
John Ralls	31d79e3004	Merge Bob Fewell's 'bug798673' into master.	3 years ago
John Ralls	5c17950a59	Merge Bob Fewell's 'mainwin2' into master.	3 years ago
Christopher Lam	259881f940	[gnc-optiondb] add some more renamed options following `ab13b01f8c` Replace ... with … in all translatable strings.	3 years ago
John Ralls	ab13b01f8c	Replace ... with … in all translatable strings. Also a few other places like translator comments and report options. Replaces https://github.com/Gnucash/gnucash/pull/1033.	3 years ago
Geert Janssens	734f90bd36	Replace string literal 'gnucash' with PROJECT_NAME parameter where it makes sense The idea behind this is to not assume the project is always built as "gnucash" exactly. One example where it can be useful to use a different project name would be when building multiple development versions of the project on the same system and don't want these different versions share the same settings in GSettings or the same stored passwords.	3 years ago
John Ralls	b8c0673526	Merge branch 'maint'	3 years ago
Robert Fewell	7536fcaf2f	Change the balance limit icon if both limits are zero When higher and lower limits are zero, when used for a a suspense account, change the icon to 'dialog-warning'. This type of use is to indicate that a non zero balance exists.	3 years ago
John Ralls	091d4aff22	Bug 798657 - Import Summary language is wrong Root cause is using boost::locale::translate because it ignores the LANGUAGES environment variable and doesn't support different values for LC_MESSAGES, LC_DATE, LC_MONETARY, and LC_NUMERIC. That makes it impossible to configure a user environment that presents translated strings in a different locale from the one applied to formatting dates and numbers. To correct this replace all use of boost::locale::translate with GNU gettext.	3 years ago
Robert Fewell	3be25ff0a9	Add some tests for the account functions	3 years ago
Robert Fewell	a15c6f81b3	Allow the balances of sub accounts to be used in limits	3 years ago
Robert Fewell	60ab654d2b	Add account balance test functions to gnc-ui-balance	3 years ago
John Ralls	73a134730f	Bug 798680 - Not able to match a reverse transaction of a... previously matched transaction. Cloned transactions and copied splits shouldn't keep the online-id slot.	3 years ago
John Ralls	b4bab92da2	Bug 798664 - Result of 'gnucash --nofile' is marked dirty Don't create a new book in the new-user dialog unless the user says to. Don't automatically create a new book when retrieving default commodities because the retrieve might be requested in a context like the Preferences dialog when there is no book. Some report tests relied on requesting the default commodity creating the book, so in those tests ensure that the book is created first.	3 years ago
John Ralls	fae5de80d3	Undo unintended change in Bug 798679 commit.	3 years ago
John Ralls	fd2761bd68	Bug 798679 - Fullwidth characters cannot be pasted as-is in register fields Control character check doesn't need normalization, the control character codepoints aren't graphic and so can't be composed nor have compatible equivalents.	3 years ago
Robert Fewell	518ecfe041	Add some functions that would allow adding a balance limit to accounts	3 years ago
Geert Janssens	98251d59a6	Bug 798672 - Preferences are not saved nor loaded, ERROR <GLib-GIO> g_settings_new_full: assertion 'schema != NULL' failed Apparently it was a failure on our side to properly look up requested gsettings schema.	3 years ago
Christopher Lam	bfc325f63c	Merge branch 'maint'	3 years ago
Marco Scardovi	6fe2028bca	Fix test Signed-off-by: Marco Scardovi <mscardovi@icloud.com>	3 years ago
Robert Fewell	59d95a4ce6	Bug 798545 - Crash when updating document link on vendor bill There were two issues here, the first one was that the copied doclink was pointing to the original doclink which lead to a double-free. The second is the setting of the doclink on the copied invoice needs to be done with gncInvoiceSetDocLink otherwise on closure the doclink value will disappear.	3 years ago
Christopher Lam	3d8a28898d	[gnc-budget] gnc_budget_get_account_period_note returns a const to harmonize with all other char getters	3 years ago
Christopher Lam	2ee0c98200	[gnc-budget] use operator[] instead of find() and insert() - avoid hashing Account* twice. one call to operator[] is sufficient. - don't need use std::move with better constructors - sanity check - can't have a budget with num_periods = 0 - remove unused headers	3 years ago
Christopher Lam	3e5fcc8709	Merge branch 'maint'	3 years ago
Robert Fewell	4f8643674b	Remove all references to GncDisplayItem	4 years ago
Robert Fewell	078d7875d3	Change all references to plugin_class->actionsb Change all references to plugin_class->actionsb and n_actionsb to plugin_class->actions and n_actions	4 years ago
Christopher Lam	6f80c548e6	[gtest-qofevent.cpp] comprehensive tests for qofevent	4 years ago
Christopher Lam	05ffd3d4eb	[budget-feature] move unset_feature call to gnc_budget_gui_delete_budget because gnc_budget_gui_delete_budget is a more general function to delete a budget.	4 years ago
Christopher Lam	b87aa004f9	[test-qofbook] add tests for unknown features tests that gnc_features_test_unknown returns a suitable error message	4 years ago
Robert Fewell	0f70143c55	Initial change to plugin source files	4 years ago
John Ralls	b9077bccd3	Bug 798640 - Segfault when running saved report	4 years ago
Christopher Lam	fc94b41c81	Merge branch 'maint'	4 years ago
Christopher Lam	4716af24e4	Merge branch 'maint'	4 years ago
Christopher Lam	ba44f720c1	Merge branch 'maint'	4 years ago
Christopher Lam	f2354d6b2a	[test-qofbook.c] add test for gnc_features_set_unused	4 years ago
Christopher Lam	1516bb18b0	[gnc-features.cpp] backport gnc_features_set_unused from master	4 years ago
Christopher Lam	a078921a33	[qofbook.cpp] backport qof_book_unset_feature from master	4 years ago
John Ralls	cf088f2a70	Merge John Ralls's 'Bug798614' into maint.	4 years ago
Christopher Lam	093aa81ed1	[qofbook.cpp] deprecate qof_book_get_features	4 years ago
Christopher Lam	8192deff37	[gnc-features.cpp] convert to cpp - don't need to create/destroy GHashTable for each feature query - plugs leak: g_hash_table_unref (features_used) not always called properly - to check 1 feature, don't need to traverse whole GHashTable	4 years ago
Christopher Lam	6f6d2fef48	[test-qofbook] basic features test sets a feature and tests it's set. it's impossible to design a book with unknown features using the API.	4 years ago
John Ralls	14a0ea4ed3	[price-quotes] Sort and format source list.	4 years ago
John Ralls	1a906b00aa	[price-quotes] Enable gnucash-cli to retrieve preferences on macOS. By embedding a minimal Info.plist with a bundle ID into the executable. This necessitated a change to binreloc because the unix-style install depended on there being a bundle ID only when the program was run from an application bundle.	4 years ago
John Ralls	2767587874	[price-quotes] Fix setting alphavantage API key.	4 years ago
John Ralls	939a77407c	Merge branch 'price-quotes-cpp'	4 years ago
John Ralls	7f2a09a69f	[price-quotes] Handle short error strings from finance-quote-wrapper. This keeps the translation work in GnuCash and improves the error signalling in gnc-quotes.	4 years ago
John Ralls	fe9b23ff2b	[price quotes] Pass short errors to gnc-quotes. And wordier but not translated messages when STDERR is a tty.	4 years ago
John Ralls	88d658fef0	[price-quotes] Date::Manip is no longer required.	4 years ago
John Ralls	50c72b4f88	[price-quotes] Remove m_ready and usable() from GncQuoteSource. GncQuoteSource ctor throws if something is wrong so usable is always true.	4 years ago
John Ralls	7d93774dd2	[price-quotes] Throw instead of returning if there aren't any commodities to quote. So that the user gets sees an error instead of silent failure.	4 years ago
John Ralls	81d4ea9550	[price-quotes] Remove F::Q version format check. We don't care what the version string looks like as long as there is one.	4 years ago
John Ralls	c78fe37ff7	[price-quotes] General typo fixes and code cleanup.	4 years ago
John Ralls	70c9d4c9e3	[price-quotes] Fix version retrieval. Plus there's no need for a "not found" version string because GncQuotes construction will throw if Finance::Quote isn't correctly installed. No object, nothing to call version() on.	4 years ago
John Ralls	97e730b8d8	[price-quotes] Reformat test quote response strings to one line per quote.	4 years ago
John Ralls	f24c2c8bdd	Instrument failure to set the account when creating a split.	4 years ago
Mike Alexander	3c306eae65	Merge branch 'maint'	4 years ago
Mike Alexander	2d3e80ea08	Compatibility with XCode's "new build system" With XCode 14 or newer CMake tries to use the "new build system" which has a requirement that if two targets depend on the same generated file one of them must depend on the other. This commit adds reduntant dependencies to satisfy this requirement.	4 years ago
John Ralls	c7d1b6ab26	Bug 798633 - 4.12 build failure on 32-bit Linux: "No code for module"	4 years ago
John Ralls	673a925554	[price-quotes] Remove superseded gnc-fq-dump and Quotes-example.pl	4 years ago
John Ralls	e817091de1	[price-quotes] Warn only once if the AlphaVantage Key isn't set. And check the environment if it's not in preferences.	4 years ago
John Ralls	d97ea77762	[price quotes] Add report member function to display quote information to stdout. Instead of creating price instances in the database.	4 years ago
John Ralls	6ffb0bb633	[price-quotes] Report quote fetch failures to the user.	4 years ago
John Ralls	4c47e91180	[price-quotes] Implement error codes for currency and quote failures.	4 years ago
John Ralls	6db7800ca5	[price-quotes] Doxygen docs.	4 years ago
John Ralls	29ce925646	[price-quotes] Test the other fetch overloads and quote values.	4 years ago
John Ralls	b5bc6463a3	[price-quotes] Rework date-time handling. A check of the F::Q modules found that the only ones that return a quote time return a bogus one and do so only to mollify GnuCash. Since there's no good way to determine the TZ of the exchange originating the quote there's no good way to decide if the quote is current or from a previous market session, so we just punt and use a time of 16:00 for all quotes.	4 years ago
John Ralls	19064093d2	[price-quotes] Remove m_comm_vec and m_fq_answer. Passing the intermediate values comm_vec and quote_str on the stack instead.	4 years ago
John Ralls	734fb6ce2a	[price-quotes] Switch error handling to exceptions. Allows for cleaner code with less state, less coupling of the GncQuotes class, and better transfer of error messages to client code. Also translates some error messages for presentation to users.	4 years ago
John Ralls	d307295076	[price-quotes] Paramaterize GncMockQuoteSource construction. So we can have different results passed back for different tests.	4 years ago
John Ralls	2b87066687	[price-quotes] Extract some static functions. To get GncQuoteImpl::parse_one_quote to a reasonable size.	4 years ago
John Ralls	a82c72cfb9	[price-quotes] Remove level of indirection when parsing quote data.	4 years ago
John Ralls	37dfab7f31	[price-quotes] Convert long quote parsing lambda to a regular function. To begin separating price parsing from inserting in the price db.	4 years ago
John Ralls	dd8316714b	[price-quotes] Extract function GncQuotesImpl::comm_vec_to_json_string.	4 years ago
John Ralls	e3ab384504	[price-quotes] Log messages instead of writing them to std::streams.	4 years ago
John Ralls	b8642e55d9	[price-quotes] Implement mock quote source. Note that because the non-default constructor exists only on GncQuotesImpl we must use that directly and violate the pimpl.	4 years ago
John Ralls	4dd3922871	[price-quotes] Make wiggle test conditional on F::Q being installed.	4 years ago
John Ralls	784aca5a4c	[price-quotes] Extract class GncQuoteSource. Provide a specialization GncFQQuoteSource and move the F::Q command construction and query functions to GncFQQuoteSource. This allows for dependency injection to provide testing that doesn't need F::Q to be installed.	4 years ago
John Ralls	e9577b7996	[price-quotes] Basic wiggle test.	4 years ago
Geert Janssens	277f299ad6	GncQuotes - cleanups - make more use of auto - mark user visible strings as translatable - return early on input errors - fix date conversion fallback to actually fall back to today	4 years ago
Geert Janssens	585de5d134	GncQuotes - break actual interaction with Finance::Quote out into a separate function query_fq That allows for later reuse and easier testing.	4 years ago
Geert Janssens	70ab8a8a46	GncQuotes - drop parameterized constructor The book parameter is only needed while fetching quotes. In case the user passes one or more commodities to process the book can be readily derived from the commodity/commodities. In the other case (fetch all quotes) the user now is required to pass a book to the call.	4 years ago
Geert Janssens	4c2863966b	GncQuotes - rename fetch_all to be an overload of fetch And add a third overload to fetch only a single quote	4 years ago
Geert Janssens	7765e13704	Bindings - move log wrappers into the swig interface files They are only used for guile (and possibly python, so there's no need to carry them around in core-utils.	4 years ago
Geert Janssens	e5c6f6026b	Remove support code that was only used by price-quotes.scm	4 years ago
Geert Janssens	e97fc3e408	Drop price-quotes.scm, gnc-fq-helper.in and gnc-fq-check.in - no longer used	4 years ago
Geert Janssens	bf357315fd	finance-quote-wrapper - implement check and fetch in one file via command line switches This obsoletes gnc-fq-check as the same function can now be performed with 'finance-quote-wrapper -v'	4 years ago
Geert Janssens	fbf9aecd25	Use GncQuotes in transfer dialog	4 years ago
Geert Janssens	a00bce168c	GncQuotes - cache default currency	4 years ago
Geert Janssens	fcbe6cf10c	Add code to parse json data returned by our F::Q wrapper This code will convert the json data into GncPrice objects and add them to the pricedb, effectively doing what price-quotes.scm does. A few notable remarks: - still requires plenty of cleaning up. This is the first proof of concept - like the original scm based code, this parser completely ignores timezone information. As it wasn't used before and nobody complained, it may not be that important. Or it can be implemented later. - price-quotes.scm would first check if a price already existed in the pricedb and try to update that one instead of adding one (only if the old price's type is inferior). However that is redundant as gnc_pricedb_add_price does the same check. So I have omitted this extra check from GncQuotes. - currency quotes can be inverted. I have slightly changed the way to handle this. The perl wrapper code will simply set an "inverted" flag in that case, but will otherwise not swap currency and commodity as it used to be the case. On parsing, the inversion flag will cause the GncNumeric that's parsed from the price to be inverted. As it's still a GncNumeric that shouldn't result in any loss of precision, while keeping prices in the db always in the default currency.	4 years ago
Geert Janssens	6ecc1ef73f	GncQuotes - switch to Pimpl idiom That allows the private implementation to pass a number of variables based on various boost libraries. It's better to not have them in the public interface to keep compilation times down.	4 years ago
Geert Janssens	65ae46426b	GncQuotes - add parameterized construction For all but the basic check a book is required. Might as well be able to pass it directly and store a reference to it. That will simplify member function declarations.	4 years ago
Geert Janssens	3685e5de73	Factor out the async call to perl This will allow us to reuse it for several F::Q commands, like check, fetch,...	4 years ago
Geert Janssens	6ce91d7f49	Drop the single quotes instance code for now I have been reading on singleton implementations and there appears to be a lot of pushback against those. We can revisit this if it turns out performance degrades significantly by running the F::Q check multiple times.	4 years ago
Geert Janssens	616a672d52	Rewrite boost::process call to properly capture both stdout and stderr The previous version of the code could only capture one but not both at the same time.	4 years ago
Geert Janssens	a6771754d5	GncQuotes - start implementation of fetch/fetch_all	4 years ago
Geert Janssens	f3fdc5de12	Rewrite gnc-fq-helper as finance-quote-wrapper This rewritten version takes JSON input and spits out JSON. Additionally inverted currency quotes will only be flagged. The old code also swapped currencies in the result. GncQuotes will be written towards these new implementation choices.	4 years ago
Geert Janssens	1d94887a0b	Rewrite gnc_commodity_table_get_quotable_commodities as gnc_quotes_get_quotable_commodities It only makes sense in that context.	4 years ago
Geert Janssens	466db526b2	Move source files for GncQuotes to app-utils It will depend on functions in that library. This can probably be fixed by cleaning up app-utils, but that's not the topic of this feature.	4 years ago
Geert Janssens	9d62755b4a	Make GncQuotes::check() a private function, returning nothing At the same time do an explicit reinstantiation of quotes_cached at first use to work around what seems to be a race condition between static instantiation and binreloc.	4 years ago
Geert Janssens	32df095d4f	Catch potential boost::process exceptions Could happen if the perl executable isn't found and perhaps also if there's a stream exception.	4 years ago
Geert Janssens	d79306f7db	Protect boost process output read loop from deadlock As per the boost::process tutorials	4 years ago
Geert Janssens	8b772384cd	Various performance fixes based on feedback - const correctnes - avoid unnecessary copying - avoid need to reverse GList	4 years ago
Geert Janssens	2f7ed7f25d	Initial version of libgnc-quotes This library intends to wrap Finance::Quote the way price-quotes.scm currently does. In this first commit the library replaces price-quotes.scm's library to install quote sources. In addition it exposes a new command line parameter in gnucash-cli to show which version of Finance::Quote is installed on the system (if any) and which quotes sources that verions exposes.	4 years ago
John Ralls	eb24099a91	Limit instantiation of GncInt128 constructors to integral values. Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	23ca899a77	Fix build on Apple Silicon or maybe Apple-clang-14.0 The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	b0ae402c23	Limit instantiation of GncInt128 constructors to integral values. Instead of using static_assert. This prevents the compiler from even trying and avoids weird compilation errors when testing types for instantiating other templates.	4 years ago
John Ralls	3c75d212ab	Fix build on Apple Silicon or maybe Apple-clang-14.0 The compiler complains that there's no matching gnc_register_number_range_option for GncOptionDB, which without this commit is true because the explicit templates are for GncOptionDBPtr&. Note that the original template definition is for GncOptionDB and that the header-defined inlines that take GncOptionDBPtr& call the GncOptionDB* version.	4 years ago
John Ralls	283a5b7ce9	Fix dist, files moved	4 years ago
John Ralls	8cb8f5067d	Remove non-ISO4217 currency codes from gnc-euro table. They're not reachable because they don't have commodities associated with them.	4 years ago
John Ralls	d8417c3cfa	Move gnc-euro.[ch] to engine and unit test it.	4 years ago
John Ralls	2774f8f88c	Bug 798614 - Croatia to join the Euro Add HRK to the conversion array.	4 years ago
John Ralls	3949821da6	Merge branch 'maint'	4 years ago
John Ralls	2505955ab9	Fix test failure from Bug 798616 fix.	4 years ago
John Ralls	7c350c3ae5	Bug 798616 - Can't register amount greater than 9,000,000,000 Because when loading the value the split in the xml backend doesn't yet have a parent so the code tried to convert to GNC_COMMODITY_MAX_FRACTION and if the numerator was larger than 10^10 that would overflow. To fix it this changes the "don't know" response to get_currency_denom and get_commodity_denom to GNC_DENOM_AUTO which will normally leave the denominator alone.	4 years ago
Christopher Lam	161b07b241	Merge branch 'maint'	4 years ago
Frank H. Ellenberger	47fa8b281e	Merge PR #1425 into maint	4 years ago
John Ralls	a807d3e6b7	Create function gnc_tm_get_today_neutral. To complement gnc_tm_get_today_begin and gnc_tm_get_today_end.	4 years ago
luz paz	ba94730a23	Fix various typos Found via `codespell`	4 years ago
Christopher Lam	ecd2cdf425	[gnc-glib-utils] gnc_g_list_stringjoin skips NULL data	4 years ago
John Ralls	95361ad060	[options] Move gnc-options test to engine/test/CMakeLists.txt.	4 years ago
John Ralls	4ae17d12c7	[options] Move options from app-utils to engine. Options is required for book options that are stored as part of the data file and so belongs in engine.	4 years ago
John Ralls	f24f29830b	[options] Change std::cerr stream output to PWARN. Remove temporary diagnostic.	4 years ago
Christopher Lam	3e02859277	Merge branch 'maint'	4 years ago
Christopher Lam	b7a3652de7	[date-utilities] avoid report crash if start>end date	4 years ago
John Ralls	087501d316	Bug 798262 - Scheduled transactions with blank amounts do not get created. Handle template transactions that don't have any splits with empty credit and debit strings and those having no set transaction account. Set the concrete transaction commodity to the first found of: The template transaction's commodity The commodity of the first split with a credit or debit string The commodity of the first split.	4 years ago
John Ralls	410db42df0	Test case where the template txn doesn't have a set currency.	4 years ago
John Ralls	229f6f5e85	Fix gdate adjustments.	4 years ago
Simon Arlott	4c1fc1d555	Bug 798262 - Add test case for basic scheduled transactions Test these scheduled transactions: * 2 splits with fixed amounts "123" * 2 splits with fixed amounts "0" * 2 splits with empty amounts "" Verify that automatically created scheduled transactions exist.	4 years ago
Christopher Lam	6ba912ee0d	Merge branch 'maint'	4 years ago
Christopher Lam	de7a63082b	[gnc-sx-instance-model] leaks: free temporal_state it's a simple struct containing GDate and int	4 years ago
Christopher Lam	ad27be333e	[gnc-sx-instance-model] prepend GList loops instead of append	4 years ago
John Ralls	8b07ac88cd	[options] Add "key" to the register-option documentation blocks.	4 years ago
John Ralls	e29ab5336f	[options] Remove key and doc_string from gnc_register_query_option. It's always used as an internal option with no UI component so it doesn't use them.	4 years ago
John Ralls	6faaf3b427	[options] Provide a const char* value flavor for register_commodity And register_currency_option	4 years ago
John Ralls	1ff844c195	[options] Fix implementation of gnc_register_owner_option To take an owner-type parameter and to set the UIType accordingly.	4 years ago
John Ralls	aa0b0921f4	[options] Add a function to check if an option is internal. Instead of relying on the legacy underscore-section-name hack.	4 years ago
John Ralls	da0eff2cac	[options] Implement widget-changed callbacks. Enables full functionality for complex-boolean and multichoice-callback options. Note that setter-function callback isn't used in any GnuCash code so it is not implemented and is not present in the register-callback functions.	4 years ago
John Ralls	552aa438ff	[options] Implement gnc_register_internal_option.	4 years ago
John Ralls	0e9ed8cf0a	[options] Provide float variants to gnc_register_plot_size_option.	4 years ago
John Ralls	0213787a2f	[options] Enable registering an absolute date option.	4 years ago
John Ralls	cf2870b71a	[options] Change RelativeDate and Multichoice index type to uint16_t. From size_t because clang thinks that std::is_same_v<size_t, time64> is true and we need to differentiate the handling of the two.	4 years ago
John Ralls	0b2d14ee72	Fix distribution for expressions target.	4 years ago
Christopher Lam	b94440b16a	Bug 798588 - sx scrubbing was using incorrect free function the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	ea56d67797	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	bfa0fd1819	Bug 798588 - sx scrubbing was using incorrect free function the GHashTable values are gnc_numeric*.	4 years ago
Christopher Lam	f0ac8d69b2	[gnc-sx-instance-model.c] indent attributes properly	4 years ago
Christopher Lam	0b5a4cd298	Merge branch 'maint'	4 years ago
Christopher Lam	d1aefc851d	[sx-book] free sx_list before g_object_unreffing sxes	4 years ago
John Ralls	688832b5f8	Bug 798585 - segfault running sample script The root cause of which is that on recent releases of GLib (recent meaning 2.66 in the current Debian stable!) g_type_instance_get_private looks in the wrong place for the private data. When running the script in question it returned NULL and since the code didn't check for a valid pointer, it crashed. So this change replaces all calls to g_type_instance_get_private with the function [type_prefix]_get_instance_private() added in glib-2.36 except for two register2 files that have been removed from master; those are ignored to avoid unnecessary merge conflicts.	4 years ago
Christopher Lam	67a1b7a873	[gnc-sx-instance-model] free GHashTable keys when destroying	4 years ago
Christopher Lam	ebf3439558	[gnc-sx-instance-model] free some GHashTable keys & Values	4 years ago
Christopher Lam	7c2a249511	[gnc-sx-instance-model.c] refactor Scrub function This scrubbing function calls xaccTransRollbackEdit which is leaky. Instead of trying to fix xaccTransRollbackEdit which requires superhuman skills, it's easiest to track the changes separately in a GList, and use xaccTransBeginEdit/xaccTransCommitEdit only if necessary.	4 years ago
Christopher Lam	7880f9b16f	[SchedXaction.c] free list of recurrences	4 years ago
Christopher Lam	c16840b840	more leaks because qof_instance_get returns a new char*	4 years ago
Christopher Lam	f1adb5da34	Merge branch 'TXN_TYPE-is-dynamic' xaccTransGetTxnType into maint #1201	4 years ago
Christopher Lam	ec3e996f92	tests xaccTransGetTxnType heuristics tests TXN_TYPE_NONE in utest-Transaction.c testing TXN_TYPE_INVOICE, TXN_TYPE_PAYMENT, and TXN_TYPE_LINK will require valid posted invoices, so, are best tested in utest-Invoice.c	4 years ago
Christopher Lam	fd12d3900c	[Transaction.c] use heuristics to determine txn->txn_type	4 years ago
John Ralls	f4c27d4494	Move gnc_ui_account_get_tax_info_string to gnc-locale-tax.c To prevent a circular dependency between libgnc-app-utils and libgnucash-guile.	4 years ago
Robert Fewell	ce4768c357	Bug 798565 - Import map editor entry deletion When a top level bayesian entry is deleted, the book is not marked dirty and so the save button is not highlighted. Deleting individual entries did mark book dirty. Fixed in gnc_account_delete_all_bayes_maps by wrapping the deletion with xaccAccountBeginEdit/CommitEdit block.	4 years ago
Robert Fewell	d688a17ef6	Merge 'luzpaz' branch 'source-typos' into maint PR #1364	4 years ago
John Ralls	3e2f7bc66a	Create separate shared library for expression parser and SX instance model. These functions depend on both libgnc-app-utils and libgnucash-guile, creating a circular dependency when the app-utils bindings are added to libgnucash-guile.	4 years ago
John Ralls	47904a858e	Fix distcheck in master. Several gnc-optiondb dependencies left out of tarball.	4 years ago
John Ralls	3fd8bd9ddf	Merge branch 'maint'	4 years ago
Christopher Lam	263f007d5c	[gnc-filepath-utils] new: gnc_list_all_paths	4 years ago
Christopher Lam	aa43c198c6	[Transaction.c] don't set TxnType kvp if it is the same as before will avoid dirtying the transaction.	4 years ago
John Ralls	9f6d495ca1	Fix use-after-free crash in utest-Invoice.	4 years ago
luz paz	cfc6e9d7e0	Fix source typo begining->beginning	4 years ago
John Ralls	1e6c679e71	Merge branch 'maint'	4 years ago
John Ralls	903cbdcad3	Bug 798547 - Calculated Due Date is short 1 day when posting on... day of fall change from Daylight Time to Standard Time. Really any day where the period crosses the dst->std change, and since the date dialog returns local midnight for the time that includes the day of the change. Convert both the parameter time and the return time to neutral time to ensure that the interval is handled correctly.	4 years ago
John Ralls	564d73a553	Bug 798531 - Selecting "Print" from the file menu on a report... crashes gnucash Ensure that every call to gnc_prefs_get_string correctly handles both a NULL or empty string return value without crashing or leaking.	4 years ago
Christopher Lam	670902d5a8	Bug 798535 - Crash when increasing the number of periods in a budget because in the SQL backend, gnc_budget_commit_edit will update the sql by reading from vectors with an increased priv->num_periods.	4 years ago
Robert Fewell	27cab58bf2	Correct some text describing some date functions.	4 years ago
Robert Fewell	c000a890ad	Bug 798501 - Balance wrong date end of account period With the accounting period preference settings set to 'Start/End of previous quarter' and balance sheet report using 'End of accounting period' the date is wrong, currently is 30/03/2022 when it should be 31/03/2022. Simplify gnc_gdate_set_quarter_end to get correct last day and subtract the 3 months befor calling said function.	4 years ago
Christopher Lam	a5cae6c5eb	Don't export undefined functions	4 years ago
Christopher Lam	fcc3b27f92	Merge branch 'maint'	4 years ago
Robert Fewell	ee7ed89b68	This partly fixes the currency and commodity combos With these changes the currency works but the commodity allows you to set the commodity but will crash if you save config or leave report open, this was tested on the 'Price scatter plot' report. Fixed with John's commit `a8e6a59`	4 years ago
Robert Fewell	db6a8f809b	Tax Tables combo does not set the active one Fixed by correcting spelling of tax table qof type, should 'gncTaxTable'. Also fixed setting tax table combo to 'none' when page reset button used.	4 years ago
Robert Fewell	0b67a91217	Fix the option GncOptionRangeValue The GncOptionRangeValue can be used with integers or doubles, the default being doubles. When used for setting the plot width/height, integers are used so all ValueTypes need to be integers other wise the when create_range_spinner is used you end up with the upper_bound value being G_MAXDOUBLE, a 309 character wide spin button. To differentiate the two, use 'set_alternate(true)' for integers.	4 years ago
Robert Fewell	506eb38493	Update Chart Width/Height Plot setting The new plot setting does both settings, values above 100 are treated as pixels and ones below are treated as a percentage. This means the maximum valid setting must be higher and also the tooltip needs to be changed.	4 years ago
John Ralls	1a186b953e	[C++options] Correct handling of multichoice scheme option types. Includes tests for save-to-scheme for each type.	4 years ago
John Ralls	a8e6a59bf8	[C++options] Fix Guile crash when restoring some reports. In particular those with commodity options or those using a stylesheet whose name has spaces like "Head or Tail".	4 years ago
Alex Aycinena	e381e70638	reverse commit `d48937c`. See discussion in Bug #79769 .	4 years ago
Christopher Lam	dc620d4b24	Merge branch 'maint'	4 years ago
Alex Aycinena	d48937cf9c	Bug #79769 - Allow US Income Tax txf code 296 (Returns and allowances) to be shown and assignable for both income and expense type accounts.	4 years ago
Christopher Lam	394e0a4b71	[gnc-sx-instance-model.c] leak: don't strdup char* for xaccTransSetNotes For a while now, xaccTransSetNotes would strdup the notes. Don't need to strdup it beforehand.	4 years ago
Christopher Lam	e1d52963ed	[account.cpp] restore breadth-first search for 2 functions gnc_account_lookup_by_name and gnc_account_lookup_by_code were searching breadth-first and accidentally changed to depth-first in 4.7. as reported in https://github.com/Gnucash/gnucash/pull/1101#issuecomment-1098146573	4 years ago
John Ralls	95487eb4a0	Merge branch 'maint' # Conflicts: # gnucash/gnome/window-reconcile2.c # libgnucash/app-utils/options.scm # libgnucash/engine/gnc-numeric.cpp	4 years ago
Christopher Lam	fae7ea02cd	[account.cpp] gnc_accounts_and_all_descendants converted from scm much more efficient than guile algorithm, avoids numerous repeated GList<->SCM conversions, and traversals of account descendants.	4 years ago
Frank H. Ellenberger	2298590316	Merge PR #1309 into maint	4 years ago

... 2 3 4 5 6 ...

1993 Commits (b3e3eb316620f2f97232f1b94de19c92973b531b)