gnucash

Commit Graph

Author	SHA1	Message	Date
Christopher Lam	a47413860a	Factor out GValue access for setters and getters	4 years ago
Christopher Lam	8f845df934	Factor out make_period_[data\|note]_path	4 years ago
Christopher Lam	919f392c7a	Use kvp C++ interface rather than GValue	4 years ago
Christopher Lam	6c4c2512db	Use C++ STL instead of GLib	4 years ago
Christopher Lam	9088acabd8	[gnc-budget.cpp] convert to c++	4 years ago
Christopher Lam	c1c198c9ff	Merge branch 'maint'	4 years ago
Christopher Lam	f0de54ac7a	Merge branch 'maint-798406' into maint #1240	4 years ago
Christopher Lam	8bc080b96d	[gnc-budget] store budget kvp data onto memory upon first call. then each getter will retrieve from memory rather than backend's kvp.	4 years ago
Christopher Lam	ef8d812d3f	[utest-Budget] test data retention when modifying budget num_periods	4 years ago
Christopher Lam	87b0a41e9b	[Split.c] return price==0 instead of 1, if !split, or amt==0	4 years ago
John Ralls	c1c75e8f81	Revert "Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint."" The original merge was of a PR based on master into maint, bringing along all of the development changes in master along with it. We don't want that so the merge was reverted and the PR's two changes cherry-picked in. That fixed maint, but then the next regular merge of maint into master naturally included that revert commit undoing the changes in master. Not so good. Reverting the revert, this commit, restores the changes, albeit with messed up history.	4 years ago
Christopher Lam	5603acba31	Merge branch 'maint'	4 years ago
Christopher Lam	f7ee644695	Amendment to `73822f97a` [1/2] use heuristics to scrub budget signs Testing income<0 to conclude "none reversal" is likely a more sound strategy than testing liability>0.	4 years ago
Christopher Lam	c3eaff9bb2	[account.cpp] gnc_account_and_descendants_empty: don't copy children	4 years ago
Kevin M. Buckley	1e22632687	Bug 798382 - Typo corrections in comments	4 years ago
John Ralls	5c7967c4a5	Revert "Merge Stefan Bayer's 'SepaInternalTransfer' into maint." This reverts commit `17a3f7fef2`, reversing changes made to `b8458d0732`.	4 years ago
John Ralls	ae7eaad018	Merge Chris Good's 'maintBug797678OfxAppend' into maint.	4 years ago
John Ralls	17a3f7fef2	Merge Stefan Bayer's 'SepaInternalTransfer' into maint.	4 years ago
Christopher Lam	73822f97a9	[1/2][Scrubbudget.c] use heuristics to scrub budget signs If book has budgets, and GNC_FEATURE_BUDGET_UNREVERSED isn't set, check and fix budget amount signs. Previously budgets were created with assumption that sign reversal was set to credit amounts. A heuristic approach is used: - if budgeted expense is negative, conclude sign reversal is "Income and Expense" - if budgeted liability is positive, conclude sign reversal is "None" - otherwise conclude sign reversal is "Credit Accounts" The above is calibrated to (hopefully) prefer sign reversal of Credit Accounts.	4 years ago
Christopher Lam	6070aecd69	[2/3][gnc-features.c] add & expose gnc_features_set_unused same as gnc_features_set_used but removes feature	4 years ago
Christopher Lam	5dab33694f	[1/3][qofbook.cpp] add & expose qof_book_unset_feature same as qof_book_set_feature but removes feature item	4 years ago
Christopher Lam	88ecf8dd17	Merge branch 'maint'	4 years ago
John Ralls	d1fe359e47	gnc_numeric_to_decimal: Change can't round warning to a debug. Routinely used as a check so a warning isn't appropriate.	5 years ago
John Ralls	cf5da9fffd	Resolve merge conflicts.	5 years ago
John Ralls	ff04ad3785	Bug 798346 - crashes when running check & repair Don't scrub trading accounts for imbalances, see the comment in the commit for why.	5 years ago
Christopher Lam	984d816a58	Merge branch 'maint'	5 years ago
Christopher Lam	79d8ef0299	Revert `b5f5129f7` using gnc_list_length_cmp	5 years ago
Christopher Lam	b5f5129f7d	Shortcut g_list_length comparison against small numbers It's more efficient to test node && node->next etc when testing GList length against small numbers	5 years ago
goodvibes2	8ad29feaba	Bug797678 OFX import should append not replace, existing Notes & Desc Add an "Append" checkbox to the bottom of the "Generic import transaction matcher" window to the left of the "Reconcile after match" checkbox. When ticked, this causes the imported Description/Notes to be appended to the matched transaction Description/Notes respectively. The selected ticked/unticked state of the "Append" checkbox is saved in a key value pair for the import account, so the next import for that account will automatically default it to the saved state. As these mods are limited to the code for the matcher window, this should work for all the imports that use it - ie ofx & csv file imports (both tested) & aqbanking (cannot test).	5 years ago
John Ralls	5a8cbf4193	Bug 798325 - New Currency for Venezuela (VED) Add latest Venezuelan revaluation of the Bolivar Soberano, following the ISO notation replacing VES (which the Venezualan central bank is keeping) with VED and the exchange code (ditto) with 926.	5 years ago
Christopher Lam	f40dbb8c28	Avoid unnecessary g_list_length in equality functions	5 years ago
Christopher Lam	f0970c8eb4	[gnc-features] don't repeatedly g_strconcat gchars*	5 years ago
Christopher Lam	31a0300abe	[Recurrence.c] avoid repeated calls to g_list_length	5 years ago
Christopher Lam	b480600dc8	[gnc-pricedb] gnc_price_list_equal: avoid 4 g_list_length calls	5 years ago
Christopher Lam	23e528f51a	[utest-gnc-pricedb] add tests for gnc_price_list_equal Also need to change PWARN which causes test failure, to PINFO	5 years ago
John Ralls	2f4438ab28	Bug 798335 - No longer possible to change trading account Strip trading splits only if "Use Trading Accounts" is enabled for the book so that users who want to manage trading accounts by hand may do so.	5 years ago
Christopher Lam	9eaa3eb23a	Merge branch 'maint'	5 years ago
John Ralls	7c9c2eba3c	Bug 798320 - Error message indicating a crash of GNUcash when closing... application - MacOS 10.15.7 (19H1419) Destruction order problem: The SX template accounts can't be destroyed until after the template splts and transactions are. Register them before the transactions and splits, as destruction occurs in reverse order of registration.	5 years ago
Geert Janssens	e64bcfe620	Merge branch 'maint'	5 years ago
John Ralls	67191203ae	Merge branch 'maint'	5 years ago
Christopher Lam	d82bb7b8a2	[Transaction.c] use is_unset static to denote uncached readonly_reason tests in `128c8d6f88`	5 years ago
Christopher Lam	128c8d6f88	[utest-Transaction] add tests for xaccTransGetReadOnly	5 years ago
Christopher Lam	87b61bf6fb	[account.cpp] GValue must be unset in old functions GValue in DxaccAccount[Set\|Get]Currency is unset correctly. However dxaccAccountGetPriceSrc and dxaccAccountSetQuoteTZ reuse a static char* therefore the latter must be used carefully before calling the function again. The functions are tested in `4309469730`.	5 years ago
Christopher Lam	86cf327f09	[account.cpp] GValue containing string must be unset already have comprehensive tests in `15852031d`	5 years ago
Christopher Lam	c8a53c54f2	[account.cpp] refactor gnc_account_get_map_entry Have comprehensive tests in `a5d101d1b`	5 years ago
Christopher Lam	4309469730	[utest-Account] test old dxaccAccount* functions dxaccAccountGetPriceSrc and dxaccAccountGetQuoteTZ. DxaccAccountSetCurrency remains untested - unsure how to retrieve an ISO4217 currency to use as parameter.	5 years ago
Christopher Lam	a5d101d1be	[utest-Account] test gnc_account_get_map_entry	5 years ago
Christopher Lam	aa0668f9e6	Revert "[account.cpp] deprecate old dxacc* functions" This reverts commit `d290c3c45d`. These functions are not deprecated after all.	5 years ago
Christopher Lam	d290c3c45d	[account.cpp] deprecate old dxacc* functions	5 years ago
Christopher Lam	374443747d	[account.cpp] new static: get/set_kvp_string_path exactly the same as set_kvp_string_tag but will accept the full kvp path.	5 years ago
John Ralls	824b515430	Fix qoflog's comments to reflect a preference for the macros over GLib functions.	5 years ago
John Ralls	74d0630867	Bug 798237 - Logging during XML file loading degrades performance... significantly Modify the DEBUG and PINFO macros to return unless qof_log_check is true. Replace almost all direct calls to g_debug and g_message with DEBUG and PINFO respectively. Track the highest logging level sent to qof_log_set_level to provide a short-circuit return in qof_log_check. Remove setting GNC_MOD_TESTS to QOF_LOG_DEBUG so that the short-circuit threshold isn't defeated by always being DEBUG. Net result: 33% improvement in xml load times.	5 years ago
Christopher Lam	15852031d4	[utest-account.cpp] increase test coverage adds getter/setter tests for xaccAccountSetLastNum xaccAccountSetTaxUSCode xaccAccountSetTaxUSPayerNameSource	5 years ago
Christopher Lam	017ab06939	Merge branch 'maint'	5 years ago
John Ralls	8ab8642e76	Fix leak of trading_splits list in xaccTransClearTradingSplits	5 years ago
John Ralls	1387d5f960	Fix unchecked ptr dereference. First crash in Bug 798225.	5 years ago
John Ralls	ab24c34660	Merge Simon Arlott's 'free-template-root' into maint.	5 years ago
Simon Arlott	4a8acf3fb2	Free template root accounts on book end The template root should be unset so that it's destroyed when the book is ending. This is required to free all the template accounts and referenced strings. The scheduled transactions themselves need to be freed first so reverse the order that SXRegister and gnc_sxtt_register are called in cashobjects_register: The list resulting from that function is traversed from the bottom up.	5 years ago
John Ralls	079a900300	Bug 798298 - Re-imported transactions no longer ignored Merges Jean Laroche's '798298_reimport_ofx' into maint.	5 years ago
Mike Alexander	068a5d2fa8	Fix xaccSplitGetOtherSplit which was broken by `028bf9826`, don't count splits that aren't really in the transaction. The rewrite left out one test. This was most obvious in the dummy transaction used to enter a new transaction into an account. xaccSplitGetOtherSplit never returned an "other split" for this transaction. It turns out the old code was broken too, but it worked for this case by coincidence.	5 years ago
jean	4e9fe0a4d1	Add missing function to mock account	5 years ago
Christopher Lam	8d502fcdd8	Merge branch 'maint'	5 years ago
Christopher Lam	1eb6709331	[test-lots.cpp] add kvp getter/setter changes	5 years ago
Christopher Lam	323182c9f7	[utest-Account.cpp] add kvp getter/setter changes	5 years ago
Christopher Lam	8a37c4c019	[utest-Invoice.c] add kvp getter/setter tests	5 years ago
Christopher Lam	9ec670f828	[test-commodities.cpp] add kvp setter/getter test	5 years ago
Christopher Lam	d4c8b36f9f	[utest-Transaction.cpp] add kvp setter/getter tests wasn't tested before	5 years ago
Christopher Lam	c3b50f0b58	[gnc-lot.c] fix - cache value properly	5 years ago
Christopher Lam	595e126a34	[account.cpp] modify set_kvp_string_tag to accept strstrip or nullptr - will remove a second call to g_strstrip (g_strdup (str))	5 years ago
Christopher Lam	c5a6383b43	[account.cpp] fix - incomplete #1117 - init struct members properly to: is_unset and TriState::Unset - test acct kvp "equity-type" for "opening-balance" instead of "true" - cached account->color/sort_order/notes/filter gets strstripped similarly to previous behavior	5 years ago
Christopher Lam	001b34616f	[Transaction.c] GValue string must be unset	5 years ago
Christopher Lam	a47bee97d6	[Split.c] GValue string must be unset	5 years ago
Christopher Lam	0ecbcb4ef1	[gnc-lot.c] GValue string must be unset	5 years ago
Christopher Lam	ac2afc7e13	[gncInvoice.c] GValue string must be unset	5 years ago
Christopher Lam	3bf49ed8d7	[Account.cpp] GValue string must be unset	5 years ago
Christopher Lam	e3af2f22f9	[gnc-commodity.c] cache user_symbol into commodity struct Continuation of `ff2ceb111` which introduced issue whereby user_symbol returned could become stale, leading to invalid read fixed with `c398bef59`. There are likely other user_symbol pointers becoming stale without this commit. This change will save the user_symbol into the commodity struct, avoids gchar* becoming stale.	5 years ago
John Ralls	57f73d70c7	Merge Yordan Miladinov's denom_lcd into maint.	5 years ago
Christopher Lam	c6d8333811	Merge branch 'maint'	5 years ago
Christopher Lam	c55ab50349	[gnc-budget.c] gnc_budget_get_account_period_note to be freed by the caller	5 years ago
Yordan Miladinov	6cb509ea7d	fix an uncaught exception: denom_lcd may throw an overflow exception if casting lcm to int64_t fails	5 years ago
Christopher Lam	7e41efc232	Merge branch 'maint-speedup-and-leaks' into maint #1109 Speedup xaccSplitGetOtherSplit	5 years ago
Christopher Lam	ff2ceb111d	[gnc-commodity] GValue must be unset	5 years ago
Christopher Lam	028bf9826b	[Split] xaccSplitGetOtherSplit don't test book trading-accts don't test trading-acct property when finding other split.	5 years ago
Robert Fewell	71d73beb6c	Original splits are not freed in xaccTransRollbackEdit At the beginning of a transactions edit, xaccTransBeginEdit is used and part of that duplicates the existing splits so that they can be restored if editing is cancelled. If cancelled, xaccTransRollbackEdit is used to restore the origin splits but if a split was not changed, the copy was not being freed so loop over the original split list and free them.	5 years ago
Robert Fewell	cacdb12aa5	Dereference the prices used in function convert_price The two prices used in convert_price had there reference count increased in extract_common_prices. This lead to the reference count continuously increasing and not being freed on close so add gnc_price_unref on both prices to reduce the reference count.	5 years ago
Robert Fewell	77cf90f198	Free the template root account after the scheduled transactions have been freed.	5 years ago
Christopher Lam	6bf5a618de	qof_instance_get gchar* must be freed A call to qof_instance_get expecting a gchar* receives a newly allocated string which must be freed.	5 years ago
Robert Fewell	a76fa5631c	Free schedule Transaction accounts There is no need to act differently when destroying the scheduled transactions accounts, they can be destroyed when the scheduled transaction is freed under normal conditions and on book close.	5 years ago
Robert Fewell	a9a3ed425a	Free Accounts on book close	5 years ago
Robert Fewell	6a9ff287cd	Wrap BillTermDecRef and TaxTableDecRef in test for shutdown When Gnucash is shutting down, the TaxTables and BillTerms will be destroyed/freed and may already have been so there is no point trying to decrement a reference that is used to stop them being destroyed if in use.	5 years ago
Christopher Lam	e4d808e674	[qofbook] qof_book_use_split_action_for_num_field: free a char* qof_instance_get allocates a new char* which must be freed.	5 years ago
Robert Fewell	b421b3d2af	Free Jobs for Customers and Vendors on book close	5 years ago
Robert Fewell	c2a6f1e911	Free TaxTable and BillTerms on book close	5 years ago
Christopher Lam	eafc290034	Merge branch 'maint'	5 years ago
Christopher Lam	40d886fa9d	gnc_account_list_name_violations elements must be freed	5 years ago
Christopher Lam	4c37f6d4ef	[account.cpp] gnc_g_list_stringjoin instead of repeated allocations	5 years ago
Christopher Lam	bedc85afa3	Merge branch 'maint-leaks' into maint #1101	5 years ago
Christopher Lam	0420ae6a66	[account.cpp] refactor gnc_account_list_name_violations	5 years ago
Christopher Lam	67bd513514	[account.cpp] rewrite gnc_account_foreach_descendant_until in C++	5 years ago
Christopher Lam	17953441cb	[account.cpp] refactor gnc_account_foreach_descendant	5 years ago
Christopher Lam	5698b67bf5	[account.cpp] refactor gnc_account_lookup_by_code	5 years ago
Christopher Lam	09e2e7613c	[account.cpp] refactor gnc_account_lookup_by_name	5 years ago
Christopher Lam	bebc366e88	[account.cpp] refactor gnc_account_n_descendants	5 years ago
John Ralls	f0926d66c1	Merge Simon Arlott's 'qof-instance-dispose' into maint.	5 years ago
Christopher Lam	e6c33a39bc	[account.cpp] refactor gnc_account_get_descendants{_sorted}	5 years ago
Christopher Lam	d2db43019c	[account.cpp] internal function account_foreach_descendant fast and efficient	5 years ago
Christopher Lam	de1ad9367a	g_free gnc_ctime which returns a new gchar*	5 years ago
Simon Arlott	7a0ea190ca	qof_instance_dispose should always complete dispose processes If QofInstancePrivate has no collection then qof_instance_dispose() returns without completing the rest of its dispose processes, skipping removal of its type string from the string cache resulting in a reference count leak. Change the check for a collection so that it only affects the call to qof_collection_remove_entity().	5 years ago
John Ralls	9062be3d47	Merge Simon Arlott's 'string-cache-fixes' into maint.	5 years ago
John Ralls	76b0001cbe	Remove option-util.	5 years ago
John Ralls	e2c87f23c3	Convert optiondb users in gnome and gnome-utils to C++. To enable using std::unique_ptr<GncObjectDB> and avoid memory management problems.	5 years ago
John Ralls	7dab089d49	Fix miscalculation of prev_quarter_end for the first quarter. If the current quarter ends June 30 backing up 3 months from there gets March 30, one day off. Back up first and calculate the end of the actual quarter of interest. Changed pre_quarter_start for consistency, it doesn't matter.	5 years ago
John Ralls	28438e3126	Rewire gnome and gnome-utils to use GncOptionDB.	5 years ago
John Ralls	67508ea039	Reimplement dialog-options for C++.	5 years ago
John Ralls	08bf3ec5b0	Merge branch 'maint'	5 years ago
Simon Arlott	4a5b5f3bf2	Don't cache the empty string Avoid unnecessary reference counting for uses of the empty string.	5 years ago
Simon Arlott	320df7e409	Use const return values for string cache This is a prerequisite for being able to return "" (which is const) and none of the returned values should ever be modified.	5 years ago
Simon Arlott	4132939612	Avoid leaking string cache entries for "" in Transaction and Split When g_object_new() is used, the strings that default to "" are added to the string cache. These are then not correctly removed when updating them with new values when cloning a Transaction/Split. Use CACHE_REPLACE instead of CACHE_INSERT.	5 years ago
John Ralls	81c5ac6689	Remove the incomplete book-currency code. Not everything from the 6 Book-Currency commits is removed: Switching the Num and split-action fields and restricting edits of transactions older than n days were included and those changes are left in place. Some other partly-implemented features were also part of these commits and were removed: Options for setting a default capital gains account and currency, completion of the LIFO cap-gains policy, and creation of a list of cap-gains policies. If any of these are to be revived they should each be done in a separate feature branch and submitted via Github pull request for a code review before merging; a design discussion on gnucash-devel before restarting work is also advisable.	5 years ago
John Ralls	d2535fe21b	KvpValue: Use boost::typeindex::type_id instead of buildtin typeid. Under some build conditions boost::typeindex will use an internal type identifier that's different from the C++ builtin. In that case type equality tests to C++ typeid in boost::variant will fail, breaking it. Using boost::typeindex::type_id ensures that the comparisons always work.	5 years ago
Robert Fewell	0f026f6a10	Bug 798221 - Transfer funds between accounts with different currencies crashes Gnucash on macOS In the scrub function find_account_matching_name_in_list there was a test for account names being the same for currency but condition was backwards so was matching on account names being different. There was also a g_list_free resulting in a double free which was removed.	5 years ago
Simon Arlott	08b56e9669	[gnc-pricedb] Don't lookup old prices when doing bulk updates	5 years ago
Christopher Lam	1b4d30b3b1	Merge branch 'maint'	5 years ago
Hong Xu	0fd0aca531	Explain out what AsOfDate means in the doc As discussed at https://lists.gnucash.org/pipermail/gnucash-user/2021-June/096893.html	5 years ago
John Ralls	601eb51361	Improve transaction sorting on effective num field. Inspired by PR #983. Transaction sorting on num broke down if the user had a non-numeric string or a number larger than an int in the effective num field (might be split-action if the option is set). The comparison first tries to use strtoull on the two strings and compares the results. If they're both nonzero and different then the numeric order is returned. If they're both nonzero but the same the unconverted parts of each are passed to g_utf8_collate; if either is 0 then the whole strings are passed to g_utf8_collate. strtoull will return 0 for a negative number.	5 years ago
John Ralls	985a6420fc	Bug 798196 - not building with Boost 1.76	5 years ago
John Ralls	6aa35ea7fb	Better fix for bug 798204, doesn't break trading account selection.	5 years ago
John Ralls	9eeff5dd7e	Bug 798204 - Creation of Imbalance Accounts Search recursively when getting account by name.	5 years ago
John Ralls	68ec80e68d	Bug 798203 - g_assert fault while reversing transaction * Re-commit the original transaction to ensure that there aren't any stray trading splits. * If the original and cloned transactions have a different number of splits don't leak the cloned transaction. * Check that the cloned transaction isn't NULL before trying to invert it.	5 years ago
John Ralls	80d6749989	Bug 787813 - Price change from editing a transaction not reflected... in pricedb. Allow PRICE_SOURCE_SPLIT_REG to overwrite PRICE_SOURCE_XFER_DLG_VAL.	5 years ago
Christopher Lam	321b5efabc	Merge branch 'maint-leaks' into maint #1019	5 years ago
John Ralls	42213c597c	Bug 798199 - Pasting invalid value in date column crashes GnuCash Catch boost::gregorian::bad_year in LDT_from_struct_tm and rethrow std::invalid_argument for C wrappers to catch and handle.	5 years ago
Christopher Lam	b095d1e7da	Revert "[qofquery] q->terms g_list members must be freed" This reverts commit `a3e3823ee7`. Already freed earlier in the same function.	5 years ago
Christopher Lam	c8a7b9edb3	[Account] g_value_unset	5 years ago
Christopher Lam	bfdec74a48	[qof-backend] gchar * gnc_path_get_pkglibdir must be g_freed	5 years ago
Christopher Lam	f6a9be45ba	[Split] g_value_unset	5 years ago
Christopher Lam	36901c5751	[gncJob] g_value_unset	5 years ago
Christopher Lam	1824a30bd0	[gncinvoice] g_value_unset	5 years ago
Christopher Lam	badd976e11	[gnc-lot] g_value_unset	5 years ago
Christopher Lam	c9565abe8b	[gnc-commodity] g_value_unset	5 years ago
Christopher Lam	302020fcb7	[gnc-budget] g_value_unset	5 years ago
Christopher Lam	ceeb1dff7a	[scrub.c] g_value_unset	5 years ago
Christopher Lam	92cd437562	[Transaction.c] g_value_unset to release GValue string	5 years ago
Christopher Lam	3353d3950b	[gnc-budget] g_value_unset GValue	5 years ago
Christopher Lam	a3e3823ee7	[qofquery] q->terms g_list members must be freed	5 years ago
Christopher Lam	8a6413342d	[SchedXaction] free GList*	5 years ago
Christopher Lam	c5585ebe2c	[gncInvoice] free GList*	5 years ago
Christopher Lam	d611538ae7	[gncTaxtable] free GSList*	5 years ago
Christopher Lam	b3101c9385	[gnc-pricedb.c] plug GList leak	5 years ago
Christopher Lam	8a56a00313	Modify documentation for gncEntryComputeValue Modify documentation for `be19b489e`	5 years ago
Christopher Lam	b25a444140	Merge branch 'maint'	5 years ago
John Ralls	da3c511b6c	Remove trading splits instead of trying to adjust them.	5 years ago
John Ralls	4f030aac6e	Bug 798093 - Changing the symbol/abbreviation of a security... after the trading account was created breaks GnuCash. Revisited. The original changeset looked for a top level trading account and a namespace account in the transaction currency; if either of those accounts had been created in a different currency it would duplicate them. This commit will accept any such account regardless of commodity. If more than one exists it will prefer the one in the root currency if there is one, otherwise it will select the first one found.	5 years ago
John Ralls	18c72baddf	Don't bother scrubbing for orphans if there's no transaction currency. If it found one it would try to create an orphan account with no currency which will crash later.	5 years ago
John Ralls	2b48fd375d	Revert "Fix duplicate trading accounts." This reverts commit `ed486a58a4`.	5 years ago
Hong Xu	888676eb31	from_price and to_price may be uninitialized in extract_comon_prices Fix the compilation error on gcc 10: gnucash/libgnucash/engine/gnc-pricedb.c: In function âextract_common_pricesâ: gnucash/libgnucash/engine/gnc-pricedb.c:2469:40: error: to_price may be used uninitialized in this function [-Werror=maybe-uninitialized] 2469 \| if (from_price == NULL \|\| to_price == NULL) \| ^ gnucash/libgnucash/engine/gnc-pricedb.c:2469:20: error: âfrom_priceâ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2469 \| if (from_price == NULL \|\| to_price == NULL) \| ^	5 years ago
Christopher Lam	ae7eb9b3ad	[gnc-pricedb] extract common code into get_nearest_price Extracts common code in: * gnc_pricedb_get_nearest_before_price * gnc_pricedb_get_nearest_price * gnc_pricedb_get_latest_price	5 years ago
Christopher Lam	a2f5223148	[gnc-pricedb] use g_list_find and plug memory leak found_coms was not being freed.	5 years ago
John Ralls	ed486a58a4	Fix duplicate trading accounts. In many cases GnuCash would create a new trading account hierarchy when one already existed because gnc_account_lookup_by_type_and_commodity didn't check the account presented and didn't recurse down the account hierarchy correctly.	5 years ago
John Ralls	2258e7a44e	xaccAccountTypes was backwards vs. the documentation. The unit tests and dialog-account were similarly backwards, but the use in gnucash/import-export/ofx followed the docs.	5 years ago
Christopher Lam	5ce8f78f77	Merge branch 'maint'	5 years ago
Robert Fewell	e535ba5411	Change some functions to use const gnc_commodity for gnc_pricedb	5 years ago
Robert Fewell	e75308e684	Rename a couple of gnc-pricedb functions that have not been used. To be more consistent change gnc_pricedb_lookup_latest_before_t64 and gnc_pricedb_lookup_latest_before_any_currency_t64 to be of the form '_nearest_before_' and add a missing utest.	5 years ago
Robert Fewell	d3bd7fda61	Add unit tests for new gnc-pricedb functions	5 years ago
Robert Fewell	4a491f7cde	Change a couple of docbook definitions in gnc-pricdb.h	5 years ago
Robert Fewell	05507008c5	Add retrieval functions for price before the date given Add a new function, gnc_pricedb_convert_balance_nearest_before_price_t64 that retrieves the balance using the last price dated before a specified date like today for the preset value. This uses another new function gnc_pricedb_get_nearest_before_price to do the retrieval.	5 years ago
Robert Fewell	b54c30e03d	Bug 798148 - Chart of Accounts page Present(xxx) value wrong If for some reason you have price information in the future for a security, the present value is based on the price retrieved for the greatest date and not a price which is before the current date. To fix this use the 'xaccAccountGetBalanceAsOfDateInCurrencyRecursive' function.	5 years ago
John Ralls	bbb4113a5a	Bug 798156 - glib 2.68.0 breaks gnucash Move all of the #include <glib> to before the extern "C" blocks so that the include guards will protect against headers inside the extern "C" block also including glib.h.	5 years ago
John Ralls	4eaa10c6be	Another extern-C glib.h, for Windows this time.	5 years ago
Christopher Lam	d28ff20ff7	Merge branch 'maint'	5 years ago
John Ralls	27435b1038	Don't filter use of TTInfo file section based on sizeof time_t. The whole point of GncDateTime is to work around 32-bit time_t.	5 years ago
John Ralls	b40589244c	Fix test-gnc-datetime failure on Ubunutu.	5 years ago
John Ralls	c49b45d8f1	Finish the glib 2.67 fixes for CI tests.	5 years ago
John Ralls	1221d7ebc1	Bug 798150 - Error on report over time Extract functions LDT_from_date_time and LDT_from_date_daypart to avoid duplicate code. Handle date-times in start-of-DST transitions and better handle those in end-of-DST transitions. Test the results.	5 years ago
John Ralls	ebb5eb1f17	Fix GncDateTime::format_zulu to emit the UTC timezone. Instead of the GncDateTime's timezone with the UTC timestamp.	5 years ago
John Ralls	3a35514d84	Fix the implementations of gnc_foo_get_day_neutral. As implemented these returned 10:59 AM local on the day but neutral time is 10:59 UTC.	5 years ago
Christopher Lam	2a2f080813	Merge branch 'maint'	5 years ago
Frank H. Ellenberger	4a983761d7	Fix a typo in a comment of the last commit	5 years ago
John Ralls	a11065b823	Fix fencepost error in calculating the week_num for POSIX timezone rules. Fixes CI failure caused by US starting DST in 2021, a year in which March began on a Monday.	5 years ago
John Ralls	8e41857014	Catch more exceptions in gnc_numeric_convert To enable fixing https://bugs.gnucash.org/show_bug.cgi?id=798132.	5 years ago
Christopher Lam	87473ed5f9	Merge branch 'maint'	5 years ago
Dong Lin	75209c024f	Update price database for imported transactions When a transaction is added from the ledger, price database is updated properly. But if the transaction is imported, there is no price db update. This change adds the proper pricedb update in the import path (qfx/ofx/qif). Tested with make check	5 years ago
Sumit Bhardwaj	df579c257b	Replace g_memdup by memcpy GLib is deprecating g_memdup. Since older versions of GLib wouldn't have g_memdup2, this PR replaces occurrences of g_memdup by memcpy.	5 years ago
Frank H. Ellenberger	93e2829ee5	Merge PR #899 into maint	5 years ago
luz paz	16b4976381	Fix typos in libgnucash/ Found via `codespell -q 3 -L ans,ba,parm,parms,numer`	5 years ago
Christopher Lam	e79db92d8d	[Split.c] xaccSplitListGetUniqueTransactionsReversed Same as xaccSplitListGetUniqueTransactions but doesn't reverse the list prior to returning. To be used by gnc-tree-model-split-reg.c Several optimizations * doesn't call g_list_find and g_list_append for every iteration * uses g_hash_table to cache list of txns already added instead of g_list_find * does not reverse the result, thereby returning a reversed list.	5 years ago
Christopher Lam	b2b8792110	prepend-and-reverse instead of O(N^2) append	5 years ago
Frank H. Ellenberger	6bc8679932	I18N: replace several spourious spaces	5 years ago
John Ralls	7a7c26f87e	Move glib and gtk includes out of extern C for tests. Needed to compile with glib 2.67 and later.	5 years ago
Bill Nottingham	c0f2c3ae25	Fix build with glib2 2.67.x. glib headers should not be included with 'extern "C"'.	5 years ago
Christopher Lam	092040c7fe	Merge branch 'maint'	5 years ago
John Ralls	4359243c08	Move glib and gtk includes out of extern C for tests. Needed to compile with glib 2.67 and later.	5 years ago
Bill Nottingham	f60b6354f8	Fix build with glib2 2.67.x. glib headers should not be included with 'extern "C"'.	5 years ago
Christopher Lam	c20a588e0f	Don't use g_list_append unnecessarily	5 years ago
Christopher Lam	d16f39046d	Merge branch 'maint'	5 years ago
John Ralls	0f8d9f6d7c	Bug 798093 - Changing the symbol/abbreviation of a security after... the trading account was created breaks GnuCash. Introduces a new function, gnc_account_lookup_by_type_and_commodity that does that, though it also looks at name for the one special case of finding/creating the Namespace placeholder account. Adds a parameter checkname to xaccScrubUtilityGetOrMakeAccount to flag whether to look for the name. Namespaces aside this makes it possible for the user to rename trading accounts or securities independent of each other.	5 years ago
John Ralls	bcbebe62b1	Make xaccScrubUtilityGetOrMakeAccount static and remove ScrubP.h It being the only declaration in ScrubP.h	5 years ago
Christopher Lam	ddc86579c0	Merge branch 'master-remove-deprecated' #855	5 years ago
Frank H. Ellenberger	84cc64daed	I18N: Remove annoying stars from translator comments	5 years ago
John Ralls	ffa2f606e3	Fix use-after-free in test_xaccTransEqual.	5 years ago
Christopher Lam	c5e7406c9f	[account.cpp] remove deprecated function	5 years ago
Allan Nordhøy	383b0b2f19	Replace 'Non Bayesian' with grammatically more correct 'non-Bayesian'.	5 years ago
Allan Nordhøy	8d4d1f1523	Replace 'Non Bayesian' with grammatically more correct 'non-Bayesian'.	5 years ago
Christopher Lam	f1c1fca023	[account.cpp][API] deprecate xaccAccountCountSplits	5 years ago
John Ralls	ae66da9632	Fix test-gnc-timezone failure caused by latest zoneinfo release. See the comment for details.	5 years ago
John Ralls	2ff3bf5877	Echo into CMakeLists.txt rename of gmock-qofqury to fake-qofquery.	5 years ago
Christopher Lam	d11bdb3e3a	Bug 798015 - cash flow numerical-overflow error is caused by pricedb containing an invalid gnc_numeric price. multiplication of (invalid) price with amount causes a report crash. Fix: if invalid price, return zero for amount converted to report currency.	6 years ago
Ralf Habacker	63580d91ba	Add feature GNC_FEATURE_EQUITY_TYPE_OPENING_BALANCE When the above function is activated, the slot 'equity type' is used and set in relation to opening balances and the checkbox for marking the opening balance in the accounts dialog can be changed.	6 years ago
Ralf Habacker	f8dcd23023	Add support for the opening balance accounts flag Up to now, opening balance accounts have been identified by means of fixed names and their translations, which in some cases is not appropriate. With this commit, therefore, opening balance accounts can now be identified by a special slot, which should solve the above problem. in gnc_find_or_create_equity_account(), when querying the EQUITY_OPENING_BALANCE type, the system now first searches for an account with an existing 'equity-type' slot having the value 'opening-balance' and returns it as an opening balance account if one exists. If no corresponding account is found, the search is continued as before. An account found in the process is automatically given the status of an opening balance account (it is given an 'equity-type' slot with value 'opening-balance') to simplify the future search. The opening balance status of an account is visualized in the account settings dialog with a check box. If a Gnucash file does not yet contain an opening balance account, one can be selected in the account settings dialog. https://bugs.gnucash.org/show_bug.cgi?id=797836	6 years ago
John Ralls	e09a26ba3a	Merge Christian Gruber's 'test_import_backend' into maint.	6 years ago
John Ralls	2290fa7c22	Fix exception when converting to decimal values that reduce to N/1. Before this the loop wouldn't terminate until the denominator had been reduced to 0 and trying to create a GncRational with a 0 denominator throws.	6 years ago
John Ralls	d03dc07b8d	Remove redundant and incorrectly named constant.	6 years ago
John Ralls	3bcf57e7f2	Fix timezone transition times. This is responsible for test failures on DST transition days. See the comments in gnc-timezone.cpp for an explanation of why this is correct. The rubric was tested on macOS, Arch Linux, Debian Unstable, Fedora 33, and Ubuntu 18.04 to confirm universal applicability.	6 years ago
McLayn	cebe6022c8	fix CZK partname to nominative singular	6 years ago
Christopher Lam	e833c8e1aa	[utest-gnc-pricedb.c] test: gnc_pricedb_get_[latest\|nearest]_price	6 years ago
Christopher Lam	2ecdd70e24	[gnc-pricedb.c][api] pull out composite pricedb price retriever * tries direct price retrieval from pricedb. * if fails, tries intermediate currency.	6 years ago
Christopher Lam	4d63eb922f	[gnc-pricedb.c] copy convert_amount to convert_price	6 years ago
Christopher Lam	26e7eada37	[gnc-pricedb.c] refactor amount converters, use common code	6 years ago
Robert Fewell	8e5e3480ad	Bug 797984 - Infinite loop while Check&Repair AR and AP accounts If using the Check&Repair option from the Chart of Accounts on 'Account Receivable or Payable' add has a voided transaction will cause an infinite loop. This occurs from checking the transaction split amount is zero in gncScrubBusinessSplit and trying to delete it. As the transaction is read only as a result of being voided this fails so add a further condition for the 'else if' statement to include !is_void.	6 years ago
Robert Fewell	122cd682f6	Add some additional places where Check&Repair can be aborted	6 years ago
Robert Fewell	6ee537e1a7	Allow the Check&Repair routine to be cancellable from CoA Add a callback for a keypress event when on the Accounts page that checks for the Escape key and presents a dialog to confirm whether to abort the Check&Repair. A similar dialog is used if you decide to quit Gnucash while the Check&Repair is still running.	6 years ago
John Ralls	94a68dca7c	Bug 797983 - v4.2 report numbers change over gnucash restarts;... Price Database dropping user:price-editor entries. A wider problem: QofInstance was unmarking itself dirty as long as the backend raised an error and unconditionally marking itself non-infant. This matters because the SQL backend depends on infant status to decide whether to do an insert or update query; either will fail if the infant status is wrong. The price editor dialog clones a price having only its commodity set and GncSqlPriceBackend declines to save if the currency isn't set. Since the instance marked itself non-infant even though it wasn't saved subsequent commits tried to use an update query and since the price wasn't in the table that inevitably failed. Requiring that QofBackend::commit should doing the marking-clean required implementing it in the backends where it wasn't already.	6 years ago
Christian Gruber	6394b6491b	fixup! Simplify type checking for GObject mockups	6 years ago
Christian Gruber	feba64624c	Fix xaccTransSetNotes() This is a bugfix for commit `954ce9577f`	6 years ago
Christopher Lam	6eb2e36c2d	minor optimisations, g_list_prepend then g_list_sort separately if building a g_list incrementally, don't sort on each insertion.	6 years ago
Christopher Lam	e6486e9d95	deprecate xaccAccountCountSplits with include_children = FALSE whereby xaccAccountCountSplits is called with with_children = FALSE, test xaccAccountGetSplitList against NULL.	6 years ago
Christopher Lam	1b31c06b29	[Account.cpp] add gnc_account_and_descendants_empty (acc) and deprecate xaccAccountCountSplits	6 years ago
John Ralls	5e6f9b3460	Fix some return of ptr-to-temporary errors Flagged by new clang Apple version 12.	6 years ago
John Ralls	1c5561714d	Fix ptr-comparison-to-string-literal error A new error raised in the latest versions of gcc and clang. The address of string literals is undefined in the C standard so the compiler raises an error if one tries to test for string equality by comparing them. A better fix would be to replace QOF_ID strings with an int-based identifier; an even better one would get rid of QOF_ID entirely and use the C++ type system.	6 years ago
Christian Gruber	e44cf9c61f	Add missing C linkage statements	6 years ago
Christian Gruber	63969e8628	Remove unecessary include	6 years ago
Christian Gruber	d673c32e35	Mock methods should not neccessarily return mock objects	6 years ago
Christian Gruber	0e634c5446	Relax runtime type checks Runtime type checks should only check for the mock up type, if neccessary. If objects of another class than the mocked object itself are processed, runtime type check should only check for the base-class type. It should be possible to use mockup objects and non-mockup objects within the same application. The included headers are adapted accordingly.	6 years ago
Christian Gruber	99256c385b	Add missing _get_type() functions of all mocked GObject classes If a GObject is replaced by a mock up, its _get_type() function has to be replaced as well. The replaced _get_type() functions have to return the type of the mock up now.	6 years ago
Christian Gruber	833edd0b29	Add missing comment	6 years ago
Christian Gruber	bc80bbb325	Simplify type checking for GObject mockups A type conversion function is introduced for each GObject mockup. This function does a runtime type check and generates a GoogleTest failure in case of any type error. This avoids checking GObject type twice.	6 years ago
Christian Gruber	b0906b5e2a	Use MOCK_CONST_METHODn() macro instead of MOCK_METHODn() macro if necessary	6 years ago
Christian Gruber	5408854c28	Rename GObject type names of mock classes According to a remark in PR #738 the lower case type name is changed. Underscores should only be used between namespace and type name and between type name and suffixes.	6 years ago
Robert Fewell	edaa0d7eea	Fix some spaces on blank lines is source files	6 years ago
Robert Fewell	416e234232	Bug 797945 - Imap bayes conversion runs many times When the Imap Editor is loaded, the bayes KVP entries are tested to see if they are required to be converted to flat entries. This involves a function that scans every account and if it finds entries that need changing, the change is made and book property GNC_FEATURE_GUID_FLAT_BAYESIAN is added so further scans are not made. As the Imap Editor loops over the account list also, if there are no bayes KVP changes then the conversion function gets called for every account in the list. This can also happen to a lesser degree when doing imports. To stop this a flag is set once the convert to flat function has been run so it only runs once and only lasts for the session.	6 years ago
John Ralls	9c8fa5cd2e	Bug 797895 - Hang for a long time (9 minutes per account) importing... a QFX file. Bug 797945 - Tools -> Import Map Editor causes GnuCash to lock up. Don't edit and commit the account if it has no BAYES_IMAP slots. Account committing is extremely expensive.	6 years ago
Robert Fewell	7c1026783b	Change the document link KVP symbol to original name To maintain compatibility with any existing document link entries the old 'assoc-head' and 'asooc_uri' entries will be used for the gsetting and KVP entries.	6 years ago
John Ralls	843282f583	Merge John Ralls's 'assoc_title' into maint.	6 years ago
John Ralls	db626de68a	Rename all Transaction and Invoice Association identifiers to DocLink. To better reflect the purpose and for consistency with other software (e.g. Libre Office).	6 years ago
Robert Fewell	d0309b39d9	Bug 797935 - Strange formal register headers The headers were made up from two parts, 'Tot' which was translated and 'Debit/Credit' which was not. Traced to some missing brackets around the returned dflt_acct_debit_str and dflt_acct_credit_str.	6 years ago
John Ralls	de0422da25	Merge G4js's missing-sentinels into maint.	6 years ago
Christopher Lam	f6d34f226f	[Scrub.c] improve responsiveness of progressbar during scrub Formerly would update progress bar every 100 splits. With scrub being slow, it's nicer to update every 10 splits. Also remove the (percentagefunc)(NULL, 0.0) which seems an error -- it would reset the progressbar back to zero immediately.	6 years ago
Gaming4JC	cca4524055	Fix warnings: missing sentinel in function calls When compiling with -Werror, GNUCash fails to build due to various error: missing sentinel in function call. This patch resolves the issue by passing nullptr instead of C-style casting NULL.	6 years ago
jean	bbdd4f34b6	Bug 797900 - Crash caused by Quitting while Check and Repair All is running The account tree page didn't have a "finish" function normally used to verify a page can close. I added one, along with two flags that indicate whether a scrubbing operation is currently ongoing and whether we should quit when the scrubbing is done. The result is: If a user attempts to quit while scrubbing isn't done, an alert pops up asking whether the user wants to abort the scrub. If so, the scrub is aborted (safely) and GC quits. If not the app does not quit. I have to say, I'm not sure this is the right way to do this. In my view, the right way would be: - Disable the "quit" menu when scrubbing is happening (for some reason gnc_suspend_gui_refresh() does not cause the quit menu to be grayed) so there's no chance of quitting while scrubbing is ongoing - If needed, add an abort scrubbing button to the main window. Not sure whether that's desirable or not. Let me know what you think: is what I have what we need, or would the above be better.	6 years ago
Christian Gruber	41c147a918	Use /* ... */ for multi-line comments	6 years ago
Christian Gruber	df6621f2b5	Add doxygen documentation to QofFakeQuery and QofFakeQueryPool	6 years ago
John Ralls	6d44d0675e	Reduce random transactions and iterations on test-lots.cpp. No point in generating 320 transactions or running the test 10 times for a simple does-it-crash test. Do it once with 32 transactions so it takes less than one second instead of 16.	6 years ago
Christopher Lam	00efc1696a	[Transaction.c] sanity check xaccTransGetAPARAcctSplitList prevent segfault if trans is NULL	6 years ago
jean	a9f79cf79c	Add a flag to the account structure to defer balance computation	6 years ago
Ralf Habacker	4df6493bc2	Fix API doc of gnc_account_lookup_by_code() Taken from PR #762, but it is separate issue and rest of the PR needs some discussion.	6 years ago
John Ralls	a93f3c198d	Warn against using xaccTransGetSplit for iteration. Instead of encouraging it.	6 years ago
jean	705f0dbf9e	Bug 797854 - Global Register Preference to prompt for interest payment is not being honored. A new per-account preference is added to let the user decide whether the interest transaction dialog should be opened automatically before the reconcile. This preference is only enabled for certain types of accounts and the code that decides that was moved to Account.h as is it now used in two separate place.	6 years ago
John Ralls	edd7efd951	Bug 797853 - Crash on 'Save As' in MacOS Mojave and Gnucash 4 Check and handle null books throughout GnuCash. Tests are left alone because they should fail if there's no book.	6 years ago
Christian Gruber	861a2482fe	Add a comment on using empty ctor for mock classes derived from GObjects	6 years ago
Christian Gruber	3d92d53917	Rename all class methods using snake_case instead of camelCase	6 years ago
Christian Gruber	1fa90a5429	Cleanup some comments	6 years ago
Christian Gruber	1e2236afdc	Use typed queries	6 years ago
Christian Gruber	fa82a8bcce	Replace query factory by a query pool Query factory was implemented using a public global variable qof_query_factory. Furthermore a query pool is easier to handle than a factory, since the whole management can be hidden from the user.	6 years ago
Christian Gruber	2639cdefdf	Remove unnecessary inclusion of qofquery-p.h	6 years ago
Christian Gruber	841111e37e	Rename class QofMockQuery to QofFakeQuery	6 years ago
Christian Gruber	bbfc30d70b	Rename gmock-qofquery to fake-qofquery	6 years ago
Christopher Lam	ebb462d06d	[account.cpp] prevent crash in gnc_account_get_currency_or_parent if the *account argument is NULL, it is not reasonable to have a g_assert crash. Passing NULL account returns NULL commodity instead.	6 years ago
John Ralls	0e0c27f80f	Bug 797850 - Account register credit/debit column headings untranslated Plus make the former globals static.	6 years ago
c-holtermann	22f91c407e	use same order in comment as in definition of SessionOpenMode enum	6 years ago
c-holtermann	e23bf0bc1c	fix SessionOpenMode explanation for SESSION_NEW_OVERWRITE	6 years ago
c-holtermann	7c8e0a28fc	better display for doxygen, typo and consistent naming	6 years ago
Christian Gruber	8ac640d5fa	Fix typo	6 years ago
Christian Gruber	610bbda23f	Add glib-object.h to includes	6 years ago
Christian Gruber	53c294f9e8	Remove unnecessary type check	6 years ago
Christian Gruber	bb0088c43c	Replace g_return_if_fail() and g_return_val_if_fail() by ASSERT_TRUE and EXPECT_TRUE	6 years ago
Christian Gruber	967cf0b430	Pass std::vector arguments by reference instead of by value	6 years ago
Christian Gruber	d084279891	State comment on unused GObject instance init function more precisely	6 years ago
Christian Gruber	67f63053fb	Remove todo comments on replacement of std::vector by std::list Replacing std::vector by std::list wouldn't have any advantage	6 years ago
Christian Gruber	a9d85e8f8e	Use std::vector of const char* instead of std::string where meaningful This avoids additional string allocation	6 years ago
John Ralls	6a1cb5eecd	Replace the three bool parameters to qof_session_begin to an enum. For clarity. In so doing found the backend behavior a bit inconsistent so it's modified to do what the enum values indicate. In the course of changing the various calls I found some implementation errors in the back end and corrected them.	6 years ago
John Ralls	a320035f42	QofSession, QofBackend: Change book_id to uri. It's more descriptive and less likely to be confused with the book:id value in XML files that is the book's GUID. Also changed the QofSessionImpl::begin new_uri parameter from std::string to const char*. There's no point in allocating a string just to call new_uri.c_str() all over the place.	6 years ago
John Ralls	65e2639de4	Delete QOF_STDOUT. Apparently a hack for the long-gone QSF backend.	6 years ago
Geert Janssens	a124e647db	Add files omitted in previous commit	6 years ago
Geert Janssens	5fc2b9519c	Add mock sources and import-export test to dist	6 years ago
Robert Fewell	2f9be87549	Replace tabs with spaces in gncInvoice.c/h Replace tabs with spaces, trim ending spaces and add spaces to function calls where appropriate.	6 years ago
Robert Fewell	69aeacb621	Add KVP Association property to GncInvoice	6 years ago
John Ralls	f2a13ecac7	Merge Christian Gruber's 'test_import_backend' into master.	6 years ago
John Ralls	a81f155408	Fix abort in qof_log_check. Apparently g_logv doesn't like recursive calls from its log handler.	6 years ago
Christopher Lam	09a8bee5c0	Merge branch 'speedup-aging' #638	6 years ago
John Ralls	1510f34926	Use std::unique_ptr instead of std::shared_ptr. No need to share ownership.	6 years ago
John Ralls	bd6840e035	Fix incorrecly logging all possible messages regardless of log level.	6 years ago
John Ralls	94fdc42f16	Fix wrong Boost library variable names.	6 years ago
John Ralls	b9b51efa8d	Don't use g_return_value_if_fail in qof_log_check. It causes GnuCash to crash if g_log is called without having set G_LOG_DOMAIN. Also extract a singleton getter function to ensure that the static root module has been created before use.	6 years ago
John Ralls	f23e3b2660	Fix undeclared std::find_if.	6 years ago
John Ralls	5da3bf7943	[QofLog] Replace hashtable with tree of vectors. 16x speedup.	6 years ago
John Ralls	3e442a0ef9	Make qof_log_set_file static. Used only internally.	6 years ago
John Ralls	0403e4906c	Move QofLogModule typedef to qoflog.h where it belongs.	6 years ago
John Ralls	4e6c497cd1	Don't ask to save a non-existant book. To accomplish that we separate creating a book and creating a session; gnc_get_session no longer automatically creates a book if one isn't connected. We also add an initially_insensitive GtkAction array to gnc-plugin-basic-commands with a call to make its contents insensitive at plugin load so that the save button on the toolbar isn't lighted when there's nothing to save.	6 years ago
John Ralls	8ff5af4c19	Decouple QofBook creation from QofSession. So that we don't create two books when loading a session. Step 1 to not having a dirty book when we think we should have no book at all.	6 years ago
Christopher Lam	a9a60c1831	[Account.cpp] more xaccAccountTypeGetFundamental types	6 years ago
Christopher Lam	14ea5d9751	Merge branch 'maint'	6 years ago
John Ralls	6a3fabc30d	Fix test failure for timezones west of the prime meridian. The previous fix didn't calculate the comparison time correctly and ended up in the wrong day because the GMT time is before the local time. In the course of checking the corner-case timezones (Midway and Kiritimati) I found an error in the GncDateTime calculation of the neutral time, so fixed that too.	6 years ago
John Ralls	b4177bc60a	Fix transaction post_date being set to midnight local. Reported for Invoices on gnucash-user. Checked all other uses of xaccTransSetPostDateSecs(), fixed the ones that weren't passing an already normalized time64. For Invoices change the post_date to also be normalized so that it stays the same as the transaction post_date. That also protects it from the displayed date changing depending on timezone. The python binding invoice post_time test had to be changed to match.	6 years ago
Christopher Lam	a3dae3bd4d	[gnc-lot.c] speed up gncInvoiceGetInvoiceFromLot by caching invoice	6 years ago
John Ralls	9822f2f486	Merge Jean Laroche's 'add_reconcile_after_ofx_import_master' into master. https://github.com/Gnucash/gnucash/pull/700	6 years ago
John Ralls	de9ee8dede	Merge branch 'maint'	6 years ago
jean	e0e7cf7dfb	Fix 3 problems with the scheduled transactions calculations This fixes 3 bugs: - Set a monthly recurrence on the 10th with a start date on the 20th of this month. The editor correctly shows the next occurrence to be on the 10th of the following month. The schedule transaction summary dialog incorrectly shows the next occurrence to be on the 10th of this month (before the start date!) - Set a monthly recurrence on the 19th, with a start date on the 20th of this month. The editor's calendar marks incorrectly show the next occurrence to be on the 19th of this month (before the start date). - Set a monthly recurrence on the 18th, with a start date on the 20th and an end date on the 17 of the following month. The calendar should show no mark, but fails to erase the marks that were present.	6 years ago
Geert Janssens	f7f4f42145	Drop several test-link type tests They were intended to test whether a gnc-module could be loaded correctly. However several were not even properly implemented and for the others the gnc-modules have been converted to ordinary libraries. Testing whether a library can be linked to is not a useful test. Link issues are triggered at build time already.	6 years ago
Geert Janssens	bbeb9a2b62	Drop all gnc-module dependencies and includes from compilation units that no longer use it This also drops the python wrapper for gnc-module. As for the guile wrappers, python should use other means of loading our shared libraries. This commit required a few tweaks to the dependency chain as some units inherited dependency information from gnc-module's public dependency interface.	6 years ago
Geert Janssens	abf29aa196	Drop the gnc-module wrapper around the test-engine library It's not adding anything	6 years ago
jean	2d0d7c40f8	Make the reconcile window close when the session closes, use full version of free	6 years ago
Bill Nottingham	592c3ad562	Fix building with link-time-optimization. Patch from Jeff Law (law@redhat.com): Rename one instance of struct _iterate to struct _qofid_iterate to avoid ODR problems with LTO	6 years ago
John Ralls	3ca8fa1229	Merge branch 'maint'	6 years ago
John Ralls	640171c211	Merge Jean Laroche's '797318_MRO' into maint.	6 years ago
John Ralls	8ccc1579d9	Bug 797666 - libgnucash/engine/test/test-recurrence.c: In function 'check_valid': 'result' may be used uninitialized	6 years ago
jean	4a8350ece2	797318 - Amounts ending in zero displayed as fractions	6 years ago
John Ralls	f85be03bb5	Merge branch 'maint'	6 years ago
John Ralls	33902a6793	Improve test building with the Xcode generator. Add CONFIGURATIONS keyword to unadorned tests, enables tests with multi-config generators. Add CONFIGURATION generator expression to libgtest.a and libgmock.a build directory specs when building with Xcode so that it can find them when building tests.	6 years ago
jean	66fce05308	Move the weekend adjust code in its own function	6 years ago
jean	268695f19c	Make test-recurrence handle wadj	6 years ago
jean	7a61eca4fe	Bug 685102 - Scheduled Transactions don't always respect weekends for first occurrence	6 years ago
goodvibes2	39c9aa4de3	Remove bad paths from CMakeLists.txt files	6 years ago
Robert Fewell	6b55222ca9	Add ability to show HBCI Online Account matches to 'Import Map Editor'	6 years ago
Christopher Lam	9865a99663	[account.cpp] refactor GetBalanceAsOfDate much more compact loop.	6 years ago
Christopher Lam	8def3ba26e	[account.cpp] refactor xaccAccountGetPresentBalance instead of starting from account->splits tail then backtrack, reuse existing code.	6 years ago
Christopher Lam	a8f03cf1c8	[account] add and expose xaccAccountGetReconciledBalanceAsOfDate	6 years ago
John Ralls	d744b79bef	Remove disabled code copied from utest-Account.c into utest-Budget.c.	6 years ago
John Ralls	8b61644978	Add more tests for neutral time.	6 years ago
Christopher Lam	e85b28f00f	Merge remote-tracking branch 'upstream/maint'	6 years ago
John Ralls	95857a8b99	Merge Christian Gruber's 'fix_bug_797587' into maint.	6 years ago
Geert Janssens	90345096e4	Merge branch 'maint'	6 years ago
Geert Janssens	feee495f2e	Bug 797624 - Wrong Decimal for Vietnam currencies	6 years ago
Christian Gruber	7509b542da	Simplify function build_bayes() Inline function parse_bayes_imap_info() into build_bayes() and remove temp_guid.	6 years ago
Christian Gruber	01c76e2391	Remove unused template of function for_each_slot_prefix() for_each_slot_prefix() is not used anywhere with two arguments	6 years ago
Christian Gruber	41863be9c7	Avoid copying local instance of AccountTokenCount	6 years ago
Christian Gruber	322f2d99de	Rework key prefix matching Use C string comparison instead of C++ function std::mismatch to increase performance.	6 years ago
Geert Janssens	301db9020d	Merge branch 'maint'	6 years ago
Geert Janssens	e79e82edcf	CMake - remove parameter repetition in else() and endif() statements This follows Professional CMake's recommended practises	6 years ago
Christian Gruber	a13184978a	Fix calculation of token info to find exactly matching tokens only In get_first_pass_probabilities() function qof_instance_foreach_slot_prefix() is called with a prefix path including closing slash after token now. This avoids, that also entries with token as a substring are included in token info, where key only starts with token. Finally function build_token_info() checks, if the key suffix after the token consists only of the GUID. This avoids, that also entries with the same prefix and slashes are included in token info.	6 years ago
Christian Gruber	da60560ac4	Change behaviour of KvpFrame::for_each_slot_prefix() Provided function func is now called with key suffix only instead of full key (prefix is omitted). This is neccessary for fixing function build_token_info() in the next commit.	6 years ago
Christian Gruber	9b3085a429	Add test cases to check for exact token matching	6 years ago
Geert Janssens	0131780b30	Add guile function to extract a lot's guid Useful for debugging lot issues in reports.	6 years ago
Geert Janssens	490b20d2da	Merge branch 'maint'	6 years ago
Geert Janssens	073e47801d	Drop useless ifdefs The parameter it checks is always defined these days	6 years ago
Geert Janssens	d8a304c2c9	Housekeeping - reduce the number of PACKAGE and VERSION related cmake variables This starts by setting the gnucash version number in the 'project' call. This will result in a number of variables set by cmake. The remainder of this commit is to reuse the auto-generated PROJECT_NAME, PROJECT_VERSION, PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR, PROJECT_VERSION_PATCH and PROJECT_VERSION_TWEAK instead of all the various instances of PACKAGE, GNUCASH_MAJOR_VERSION and so on. One parameter is worth mentioning - GETTEXT_PACKAGE GnuCash is not using this directly (any more) but it has to be set before including gi18n-lib.h.	6 years ago
Christopher Lam	c4ab772d4b	Bug 797576 - xaccAccountOrder shouldn't sort account codes as base-36 Thanks to yegor for discovering it is unreliable for sorting. It has been present since `50646f04`	6 years ago
Geert Janssens	45cfb8937a	Merge branch 'maint' Resolves most merge conflicts. The only bit I was unable to merge from maint into master is the use of match-lambda in category-barchart.scm. This will have to be redone manually.	6 years ago
John Ralls	df92200c8e	Restrict gnucash.pot comment collection to ones beginning with Translators. On recommendation of the Translation Project's Benno Schulenberg. Required re-annotating some comments. Also removed several comments about leaving a line break to prevent inserting it into gnucash.pot. That didn't actually work: they were inserted anyway.	6 years ago
Daniel Dittmann	31c0fed1dc	test_gnc_setlocale: use trailing whitespaces	6 years ago
Daniel Dittmann	5c478713d6	test_gnc_setlocale: add missing whitespaces to diagnostic message	6 years ago
John Ralls	d51b4d7f08	Bug 797532 - Crash/Coredump Lots Replace the asserts in cap-gains.c with g_return_val_if_fail. There's nothing about cap-gains.c that justifies crashing the program.	6 years ago
Geert Janssens	cd8698321d	Bug 797482 - Can't edit date when using Edit Payment function	6 years ago
Christopher Lam	8fb73c7ed1	[gnc-lot.h] amend description for gnc_lot_get_earliest_split this function doesn't necessarily point to the lot opening split.	6 years ago
Christopher Lam	5ebbb74435	[new-owner-report] invoice->payments displays lot links Change of algorithm to display invoice->payments. Previously: invoice->lot->splitlist; filtered to payments; retrieve splits->parent->xaccPaymentAcctSplitList This would find payment splits in originating currency. But this fails for lot-link txns whose PaymentAcctSplitList is null. New algorithm: - invoice->lot->split-list, each lot-split analysed - TXN-TYPE-PAYMENT lot-splits will query TransferAcct and each will be rendered in the originating currency, if they haven't been encountered before in this invoice. - TXN-TYPE-LINK lot-splits are rendered as a generic 'Offset Documents' link to lot-link splits. This helps link invoice to the link transaction to locate the corresponding credit-note. It is not possible to link to the corresponding credit-note because a link-transaction can group many invoices to many credit-notes. Also: Increase right-hand-side links from 3 to 4 columns. I think it's quite useful to add 'Credit Note' 'Invoice' 'Payment' as a separate column.	6 years ago
Robert Fewell	e4ac6b480f	Merge branch 'maint'	6 years ago
Robert Fewell	803d4c511e	Bug 797489 - No option to use account codes in Budget View - Part1 In the budget view there is no option to add the account code column which some uses use for sorting their accounts. This commit introduces a feature flag to be used in version 4.0 but if set in 3.8 will hide the new account code column so the view is not disrupted.	6 years ago
Christopher Lam	279a5fcde8	Merge branch 'maint'	6 years ago
Geert Janssens	4c77f7670e	engine - remove gncmod boilerplate engine is now an ordinary shared library This requires a few more places to run gnc_engine_init as this is no longer done as part of module loading.	6 years ago
Geert Janssens	759bbe1da0	app-utils - move gnc_get_debit/credit_str functions to Account Eliminates another scm file (prefs.scm). The old scm functions are declared deprecated.	6 years ago
Geert Janssens	0a635fadee	engine - cmake cleanups - drop no longer used GUILE_LDFLAGS and GUILE_INCLUDE_DIRS - use generator expressions where it makes sense	6 years ago
Geert Janssens	2e1b9f937b	engine - drop guile wrappers for obsolete functions These were marked deprecated early in the 3.x release cycle.	6 years ago
Geert Janssens	04f10d66fa	engine cosmetics - remove a few references to guile that are no longer relevant	6 years ago
Geert Janssens	c46c9682eb	engine/test - move guile related tests to bindings	6 years ago
Geert Janssens	02511401b7	bindings/guile cosmetic - rename source files for consistency	6 years ago
Geert Janssens	48f3195e5c	bindings - make business-core scm module part of the engine module There's no reason to expose it as an individual module as what it exports are support functions for first class engine objects.	6 years ago
Geert Janssens	1c7f835f47	engine - move guile code to bindings/guile This commit tries to do the minimum necessary to move the guile bits from engine to bindings/guile. As engine is a very central piece in the software, this unfortunately still touches many other source files: - A few helper objects have been squashed together: * engine-helpers-guile.[ch] (of which the c part is extracted from engine-helpers.c) * gncBusGuile.[ch] * gnc-hooks-scm.[ch] - The initialization function of gncmod-engine no longer initializes the scm bits. Any scm code that wants to interact with the engine code now has to load the (gnucash engine) scm module, or sometimes (gnucash business-core). The bulk of changes in this commit actually is updating all the scm consumers to do so. - scm-scm target has been removed. Instead (gnucash utilities) is part of scm-engine. A few dependency graphs have been updated for this. More refinements will be in followup commits.	6 years ago
Geert Janssens	b1ba16c33b	gnc-hooks - factor out scm calls into a separate source file This required the addition of an extra parameter to gnc_hook_add_dangler to allow the scm hooks to unprotect the scm data on hook destruction.	6 years ago
Geert Janssens	18093b5e82	core-utils - move guile utils to bindings/guile	6 years ago
Geert Janssens	33e1ff645c	Allow to pass include directories to the add_swig_xyz commands This will be needed when the wrappers no longer live in the same directory as the objects they are wrapping.	6 years ago
Geert Janssens	f5e28c3d0f	split register - drop scm copy interface	6 years ago
Christopher Lam	ded336f987	[gnc-features] enable reading of unreversed budgets	6 years ago
Christopher Lam	c06191a656	Transaction.c: avoid slow g_list_nth_data	6 years ago
John Ralls	ba5bd6b4d7	Merge branch 'maint'	7 years ago
Christopher Lam	2df672bdb2	[gncOwner] i18n gncOwnerGetTypeString types	7 years ago
Christopher Lam	f89691f73c	Merge branch 'maint'	7 years ago
Christopher Lam	644cb4100e	[gncOwner] add gncOwnerGetTypeString returns owner-type * will have several uses	7 years ago
Christopher Lam	02e86a4c6a	Merge branch 'maint'	7 years ago
Christopher Lam	b2fcfbd3c6	Bug 797326 - Enhancement: budget's Estimate tool should ignore Closing Entries Addendum to `8b8c957ed` -- if budgeted amounts exclude closing entries, actual amounts should also exclude closing entries. Amend documentation, modify budget test to add a closing entry which will be ignored.	7 years ago
Christopher Lam	5f6aa6ed45	Merge branch 'maint'	7 years ago
John Ralls	1dc22e53c5	Fix test_xaccTransEqual. Needed to make the noclosing_balances equal to get the balance-equality test to pass.	7 years ago
Christopher Lam	198570d8c8	Bug 797390 - xaccAccountRecomputeBalance also tallies no-closing balances Add a few API, enough for fixing bug 797326 easily.	7 years ago
Christopher Lam	af20f9ddac	[test-budget] add tests for budget notes in reports * also tests budget-note setters/getters	7 years ago
Adrian Panella	4b1ac6fa13	[budget] Add 'notes' functionality to engine Add ability to save notes on each budget value (account/period).	7 years ago
Geert Janssens	fa66f0fa7f	Drop comment referring to non-existing file	7 years ago
Christopher Lam	eb58bca7af	Merge branch 'maint'	7 years ago
Christopher Lam	c6195d6e7a	[test-budget] centralize gnc:create-budget-and-transactions it will be reused by test-stress-options	7 years ago
Christopher Lam	b49109b782	Merge branch 'maint'	7 years ago
Christopher Lam	22cdd237f1	[test-portfolios] initial commit 1.1.1980 seed $10,000 1.2.1980 buy 1 AAPL @ $100 1.3.1980 buy 1 AAPL @ $200 1.5.1980 sell 1 AAPL @ $400, FIFO capgain = $300, less $10 fee 1.10.1980 1:10 stock split 1 to 10 AAPL, price now $40 1.11.1980 1:10 stock split 10 to 100 AAPL, price now $4 1.12.1980 3:1 stock split 100 to 33 AAPL, price now $12; cash-in-lieu for 1/3 AAPL = $4 tests both portfolio.scm and advanced-portfolio.csm tests report output using average/fifo/lifo pending: DRP etc	7 years ago
John Ralls	b8b33b9591	Revert "More conversions from pkg-config variables to imported targets." This reverts commit `1a9fcfefad` because on MinGW cmake complains about the paths in pkgconfig files. This can be addressed by using the MSYS2 cmake instead of the MINGW32 one, but that requires some other changes... and there's also a path separator bug in that version of FindPkgConfig.cmake.	7 years ago
Christopher Lam	0f6ad8263b	Remove deprecated functions	7 years ago
John Ralls	6753b30b86	Convert GtkMacIntegration to package-style dependencies.	7 years ago
John Ralls	1a9fcfefad	More conversions from pkg-config variables to imported targets. Also converts ICU detection from pkgconfig to FindICU.	7 years ago
John Ralls	e38cc91452	Merge branch 'maint' Bumping the required cmake to 3.10 and removing GncPkgConfig.cmake as no longer required.	7 years ago
John Ralls	c23f3f05e3	Fix deprecated G_TYPE_INSTANCE_GET_PRIVATE and G_INLINE_FUNC with the function/declaration that they substituted. Note that this doesn't use the recommended new GObject creation macros because the class names in libgnucash/engine don't follow the gnome naming convention.	7 years ago
Geert Janssens	617c4c4ade	Fix several dependency issues in scheme code * Ensure all the files included in report.scm are built before any module calls '(use-modules (gnucash report))' * Break circular dependency between report.scm and the files it loads via '(load-from-path ...)' For example file 'gnucash/report/html-linechart' is loaded via '(load-from-path ...)' in 'reports.scm' it shouldn't call '(use-modules (gnucash report))'. That would make it indirectly depend on its own. * In the same way 'engine-utilities.scm' was in a circular dependency loop with 'engine.scm' though even more indirectly via (gnc-module-load ...)'. The initialization code of libgncmod-engine calls '(use-modules (gnucash engine))' which in turn tries to load-from-path 'engine-utilities.scm', completing the loop.	7 years ago
Frank H. Ellenberger	fa4fc551af	Remove obsolete "disambiguation prefix" translator comments https://lists.gnucash.org/pipermail/gnucash-devel/2019-September/044199.html Continuation of commit `d30fe7a`	7 years ago
John Ralls	e6e2258a74	Bug 797356 - ninja check fails with GCC-9	7 years ago
John Ralls	e16308b10f	Merge Christian Gruber's 'rework_gtest_integration' into master.	7 years ago
Christopher Lam	44adc0543f	Merge branch 'maint'	7 years ago
Christian Gruber	b303fc6d99	Use target gtest instead of GTEST_LIB and GTEST_INCLUDE_DIR This simplifies usage of GoogleTest, since independent handling of GTEST_LIB and GTEST_INCLUDE_DIR is not necessary anymore. Additionally CMake creates a dependency now between target gtest and all test applications using it. This improves build process when building GoogleTest from source code. When any test application is built, GoogleTest library is automatically rebuilt if necessary now for instance.	7 years ago
Robert Fewell	d677e3c5df	Do not log an error when no default tax tables set	7 years ago
John Ralls	f00777ca07	Add scm-srfi64-extras and scm-qif-import as check dependencies Fixes make check when make all hasn't been run.	7 years ago
Geert Janssens	9a48122d41	Merge maint	7 years ago
Craig	04aab7cea3	Correctly parse decimals between 0 and -1. The negative sign was being lost because stoll("-0") is 0. Also permits parsing decimals between -1 and 1 without the leading 0.	7 years ago
John Ralls	1fc831002d	Merge branch 'maint'	7 years ago
John Ralls	fcc1653822	Replace overly indirect gnc_business_get_default_tax_table. With gncTaxTableGetDefault. qof_book_get_default_tax_table would have been even better but it would have created a circular dependency between QofBook and GncTaxTable.	7 years ago
Geert Janssens	0e93e95c6c	Merge maint	7 years ago
John Ralls	8eb3819a3c	Merge Christian Gruber's 'rework_gtest_src' into maint.	7 years ago
John Ralls	24d4576617	Include libicu-i18n in libgncmod-engine linkage for new ICU API usage.	7 years ago
Christian Gruber	1b4e481296	Add gtest_main.cc to libgtest.a Currently when compiling GoogleTest from source code, source file gtest_main.cc from GoogleTest repository is not compiled into any library as in GoogleTest repository, where it is compiled into libgtest_main.a. Instead gtest_main.cc is added to source file list GTEST_SRC, which is then added to the list of source files of every single GoogleTest based test application. To simplify this gtest_main.cc is added to the source file list of target gtest now. Additionally GTEST_SRC is merged into lib_gtest_SOURCES, since both variables defined source files for GoogleTest libraries. Now target gtest generates library libgtest.a, which already contains the main function from source file gtest_main.cc. This is different to GoogleTest build system, where both are separated into two independent libraries libgtest.a and libgtest_main.a.	7 years ago
Geert Janssens	ec6602adf9	[gnc-date][API] find locale's start of week using ICU. gnc_start_of_week * ICU has a mature C++ api, so prefer that one in our C++ code * Use PERR instead of fprintf for consistent reporting * Add the ICU specific linker flags to the test case	7 years ago
Christopher Lam	5bd854c550	Merge branch 'maint'	7 years ago
Frank H. Ellenberger	a0a0ffbb77	Bug 797319 - Mauritanian ouguiya MRO shows too few decimals Add info about cash vs. banking	7 years ago
Frank H. Ellenberger	c77607c8c0	Bug 797316 - New Mauritanian ouguiya MRU not supported Add info, which Mauritanian ouguiya is recent	7 years ago
Christopher Lam	720f176417	Merge branch 'maint'	7 years ago
Christopher Lam	a4811b3b46	[test-extras] add (create-test-invoice-data) for tests this function creates some business data. moved from test-invoice.scm without the invoice-specific tests. verified all invoices/bills are created correctly. it returns a vector-list of the 8 invoices generated.	7 years ago
John Ralls	ca87572a2c	Bug 797319 - Mauritanian ouguiya MRO shows too few decimals Changed MRO smallest-fraction to 100 based on information provided by the reporter. ISO4217 has moved the MRO to the "Historical Currencies" list that doesn't include CcyMnrUnits.	7 years ago
John Ralls	b02f7ac409	Bug 797316 - New Mauritanian ouguiya MRU not supported Add new MRU with info from https://www.currency-iso.org/dam/downloads/lists/list_one.xml	7 years ago
Christopher Lam	63f484c555	Merge branch 'maint'	7 years ago
Christopher Lam	fdeff65f06	[business-core] refactor & document gnc:owner-from-split This function helps to establish UI link from register split to an owner's split. It should not be used anywhere else. Its use in reports will be removed. It is also unnecessarily complex -- it is called from an AP/AR account register split, it should have all necessary information via split metadata. e.g. this function can return a split owner if originating from an Asset/Liability account which settles an invoice, but this functionality is not used because there is no asset/liability register hook to call it.	7 years ago
Christopher Lam	d0bf4ad8ae	[test-business-core] add to dist_list	7 years ago
Christopher Lam	3514600841	[engine/test/CMakeLists] add new section for scheme tests	7 years ago
Christopher Lam	d3f43fe360	[test-business-core] fix: module names were changed	7 years ago
Christopher Lam	d0af343ee4	Merge branch 'maint'	7 years ago
Christopher Lam	0c433e02f7	[business-core] deprecate gnc:entry-type-percent-p This function is only used once. deprecate it.	7 years ago
Christopher Lam	e654bd34af	[business-core] simplify functions	7 years ago
Christopher Lam	57f291af86	[test-business-core] initial commit	7 years ago
Christopher Lam	cee6400779	Merge branch 'maint'	7 years ago
Christopher Lam	429077ee8e	completion wrap qoflog	7 years ago
Christopher Lam	898a9cdb8e	wrap qoflog	7 years ago
Geert Janssens	06fae12265	RptCleanup - Add compat interface for all module interfaces that were deprecated so far These can be permanently removed for the gnucash 5.x series. A comment has been added to that effect.	7 years ago
Geert Janssens	53f59f7794	RptCleanup - Restructure installation of gnucash scm files These files were installed fairly ad-hoc into the share/gnucash/scm directory making it hard to get an idea of where each file comes from. The files are now structured as follows: - any scm file authored by gnucash should go in share/gnucash/scm/gnucash or below - most scm modules will be directly in that directory - each module that comes with support files will get a subdirectory named after the module's base name. For example next to engine.scm there will be directory named engine for all support files of the engine module - scm files that are not modules, but are loaded by modules go into <module-dir>. For example gnc-utils.scm loads gnc-menu-extensions.scm so that file will be installed in gnc-utils/gnc-menu-extensions.scm - the report system is our largest module and only part of the restructuring is done at this point. It will be refined further in future commits. The same restructuring is also done for the compiled files.	7 years ago
Geert Janssens	7306f2dda3	Always add srfi64-extras.scm to dist tarball Even if the current machine doesn't have srfi-64 a machine downloading the dist tarball may and hence could compile and run the srfi-64 based tests.	7 years ago
Geert Janssens	30ac2cf266	Remove guile functions that were marked as deprecated in gnucash the 3.x series	7 years ago
John Ralls	9ec5eab714	Merge branch 'maint'	7 years ago
Geert Janssens	15a35e6a3b	Housekeeping - replace plenty of http links with https There are more, but these are most common ones. There are also a number of urls that don't behave well when https, so those are skipped At some point I have also started marking non-working URLs as [DEAD LINK], though that's not a full coverage.	7 years ago
Geert Janssens	4ffc4d046f	GncEntry - Fix inverted comparison	7 years ago
Geert Janssens	cc7ca438c0	Merge branch 'maint'	7 years ago
Geert Janssens	29b842ba99	Fix ubuntu 14.04 build failure srfi-64 is optional and hence should only be depended upon within the have-srfi-64 condition. Ubuntu 14.04 doesn't have srfi-64 yet.	7 years ago
John Ralls	06bc064379	Fix dependencies for Scheme tests requiring SRFI64. So ninja check passes without having run ninja first.	7 years ago
John Ralls	cac307602f	Build or link all Scheme test files into a directory "tests". Instead of random locations only occasionally related to the corresponding source. Includes renaming libgnucash/engine/test/test-extras.scm and gnucash/report/report-system/test/test-extras.scm to avoid a naming conflict.	7 years ago
John Ralls	141e777893	Suppress installing Scheme test programs.	7 years ago
John Ralls	2d4f771bed	Merge Adrién Panella's 'budget' into maint.	7 years ago
Adrian Panella	5bb54d073c	[budget] Fix error in qof_book property path The "Default budget" property had an erroneus path and was not returning any value.	7 years ago
John Ralls	217418bb8c	Merge Adrián Panella's 'numeric' into maint.	7 years ago
Adrian Panella	f905467a44	[numeric] Fix constructor from strings in range (0 ,1) Fix error that caused strings in the form 0.nnn to be converted to negative numerics.	7 years ago
John Ralls	e6c50357bb	Fix test error string to match actual error.	7 years ago
David Palma	aab89065da	Bug 796949 - Fix division and rounding of zero. Fix division of 128-bit integers so that the remainder inherits the dividend's sign. Fix rounding for truncated zero.	7 years ago
John Ralls	94bb28d9ab	Bug 797127 - Company name and address in reports not display properly Ensure that all includes of swig-runtime.h are followed by including guile-mappings.h so that the defines masking scm_to_utf8_string and scm_from_utf8_string are undone.	7 years ago
Robert Fewell	d1ee651bbc	Modify the qof log format based on max logger name from log.conf When you have multiple loggers enabled, the log file indentations are partly based on logger name length and so you can have false indentations which can cause confusion. This change gets the maximum name logger length and uses this for all with a minimum default length of 12 characters.	7 years ago

... 7 8 9 10 11 ...

1174 Commits (6cd8e4e4584cc2a3423a64dd8d5d62c32a8c5b89)