[business-core] deprecate gnc:entry-type-percent-p

This function is only used once. deprecate it.

gnucash/report/business-reports/invoice.scm

@@ -105,7 +105,7 @@
           (_ "Total"))))
 
 (define (monetary-or-percent numeric currency entry-type)
-  (if (gnc:entry-type-percent-p entry-type)
+  (if (eqv? entry-type GNC-AMT-TYPE-PERCENT)
       (string-append (gnc:default-html-gnc-numeric-renderer numeric #f) " " (_ "%"))
       (gnc:make-gnc-monetary currency numeric)))
 

libgnucash/engine/business-core.scm

@@ -94,6 +94,8 @@
       (else ""))))
 
 (define (gnc:entry-type-percent-p type-val)
+  (issue-deprecation-warning
+   "gnc:entry-type-percent-p is deprecated.")
   (let ((type type-val))
     (equal? type GNC-AMT-TYPE-PERCENT)))