gnucash

Commit Graph

Author	SHA1	Message	Date
John Ralls	8c2a8edbed	Implement gnc_option_db_set_string_value and gnc_optiondb_lookup_string_value.	5 years ago
John Ralls	86102e1be7	Return SCM_BOOL_F instead of nullptr to Scheme optiondb-lookup. Because unlike C, Scheme thinks (if 0) should return true. Besides, Swig hides pointers so a null check doesn't even work.	5 years ago
John Ralls	53ad0ba440	Prevent SWIG from trying to call delete on a std::unique_ptr.	5 years ago
John Ralls	08d1eebba2	Use GUID strings instead of QofInstance* for scheme value of QofInstance. Because that's what gets used everywhere else.	5 years ago
John Ralls	fba0248548	Support different GncOptionMultichoiceValue key types. Scheme can use strings, symbols, or ints as keys in multichoice options, but C++ can handle only strings. Add conversion and tracking so that the right key type gets sent back to Scheme.	5 years ago
John Ralls	55a2ed1df8	gnc-optiondb.i uses functions declared in gnc-optiondb.h. So it needs it declared in the swig file.	5 years ago
John Ralls	18b83874fd	Another bit of Remove test-option-utils	5 years ago
John Ralls	0b7ccfbd5b	Create gnc-make-foo-option functions. For compatibility with current Scheme code.	5 years ago
John Ralls	a602f64b17	SFINAE-constrain the GncOption constructor templates. So that one can't instantiate an invalid constructor. Unfortunately Swig doesn't understand SFINAE and will try to create the invalid constructors anyway but at least this generates a compile-time error when it tries to.	5 years ago
John Ralls	43f4bcb610	Make GncOptionUIType an enum class. So that Swig will create properly constrained identifiers for its values.	5 years ago
John Ralls	7fa6778b4b	Add a register_option overload to GncOptionDB For compatibility with existing scheme code.	5 years ago
John Ralls	cb7270cafe	Fix myriad gcc10 complaints.	5 years ago
John Ralls	76b0001cbe	Remove option-util.	5 years ago
John Ralls	e2c87f23c3	Convert optiondb users in gnome and gnome-utils to C++. To enable using std::unique_ptr<GncObjectDB> and avoid memory management problems.	5 years ago
John Ralls	ea835b31b7	Provide GncOptionPtr& overloads for register-option functions. Simplifies and makes safer calls from Scheme and C++ by not requiring a raw pointer.	5 years ago
John Ralls	472814d315	Change the normal internal option ValueType to SCM. Internal options are used as a Scheme hack and don't need to be interpreted on the C side so there's no point in converting them to C types.	5 years ago
John Ralls	e48416010d	Remove redundant GncOptionDB decl.	5 years ago
John Ralls	7022f5222d	Revert gnc_option_db_lookup\|set_glist_value to ...scm_value. GLists and SCM lists are not interchangeable.	5 years ago
John Ralls	8c77ce967b	Implement and test obsolete option name aliasing.	5 years ago
John Ralls	90b8fce59f	Fix build after merge.	5 years ago
John Ralls	4f3fd665cf	Fix counter and counter_format storage in KVP. So that they go to their own slots instead of to the options slot.	5 years ago
John Ralls	b19f3d383c	Protect some exceptions from being passed to Swig.	5 years ago
John Ralls	52600bbd1f	Instantiate gnc_register_number_range_option templates in SWIG.	5 years ago
John Ralls	31a0153fec	Another GncOptionDBPtr fix.	5 years ago
John Ralls	85db341afe	Remove test-option-utils It no longer works. Since that's all that test-app-utils called, delete it too.	5 years ago
John Ralls	21398dfda1	Testing fixups for using GncOptionDB* in register_option functions.	5 years ago
John Ralls	d1cfd62f31	Fix loading text fields from KVP into options.	5 years ago
John Ralls	276d33975a	Remove dialog-options.c, replaced by dialog-options.cpp. Adds new function reset_default_value to GncOption; doing it outside of the class requires knowing the Type of m_value.	5 years ago
John Ralls	5f9c66aa61	Save all options to KVP if clear_options is true.	5 years ago
John Ralls	6491c98563	Clean up some omitted type-forcing in set_option_from_ui_type() instances.	5 years ago
John Ralls	245a8fccc7	Correctly select UI types for GUID output.	5 years ago
John Ralls	c751e56184	Fix fail to load or save number-range values in KVP.	5 years ago
John Ralls	010ab1a965	Fix free of unallocated ptr crash.	5 years ago
John Ralls	4a4e5d36f8	Enable gnc_register_owner_option to handle the three types that GncOwner aliases.	5 years ago
John Ralls	d8f83d6ee6	Boolean simple won't work if its UI type is INTERNAL.	5 years ago
John Ralls	3514725a97	Make gnc_register_number_range_option a template on ValueType. GtkSpinButton works with doubles, but we want to preserve the ability to use other types. It really should have enable_if<is_arithmetic(ValueType)>.	5 years ago
John Ralls	e78c012699	Fill in the book options.	5 years ago
John Ralls	ae79fd016d	More skeletons	5 years ago
John Ralls	28438e3126	Rewire gnome and gnome-utils to use GncOptionDB.	5 years ago
John Ralls	41e59df71f	Remove unused and un-needed function.	5 years ago
John Ralls	1eef796f09	Add some skeleton functions to make the option-using code in gnucash/gnome-utils and gnucash/gnome happy.	5 years ago
John Ralls	99103ffd10	Change gnc-register-option functions to take GncOptionDB*. Instead of std::unique_ptr<GncOptionDB> because there's no way to get a unique_ptr through a C call.	5 years ago
John Ralls	9111f118e0	Business option create_option_widget specializations. Required creating a registration class for create_option_widget overload functions because without it the dispatch function complained of missing symbols at link time.	5 years ago
John Ralls	01c0fe2364	Include what we use.	5 years ago
John Ralls	25b717d47a	Add a rudimentary C API for GncOptionDB. So that most of the gnome-util and gnome consumers don't need to be converted to C++. Hide the corresponding functions in options-utils to stop the compiler whining. Note that this commit breaks the build but is necessary at least temporarily to compartmentalize the changes.	5 years ago
John Ralls	4451f58bd6	Rename RelativeDatePeriods missed earlier.	5 years ago
John Ralls	6feb92d4e8	Provide scheme function new-gnc-optiondb. Wraps creating a GncOptionDBPtr, freeing up gnc_option_db_new() to return a GncOptionDB* for use in C code. Convert gnc_option_db_new() calls in gtest-gnc-optiondb to call std::make_unique() as well.	5 years ago
John Ralls	f9e136dbac	Get the spelling of GncMultichoiceOptionEntry consistent.	5 years ago
John Ralls	eb6e31f803	dialog-options: Change signature of gnc_option_get_gtk_widget() So that it can be called from C.	5 years ago
John Ralls	67508ea039	Reimplement dialog-options for C++.	5 years ago
John Ralls	3b4785e744	Convert GncOptionSection from a std::pair to a class. Provides find_option(const char*) and foreach_option(func) for easy iteration. find_option and find_section now return plain const ptrs instead of std::optionals. Much less cumbersome though the compiler won't nag if you forget the nullptr check.	5 years ago
John Ralls	c63db36a60	Rename string_equal_charptr to operator==(const std::string&, const char*) Much prettier and more idiomatic as well as being a lot less typing.	5 years ago
John Ralls	0106176436	Provide GncOption::is_alternate() for GncOptionRangeValue<>. Needed for GncOptionUIType::PLOT_SIZE to indicate whether the option value represents pixels or percent.	5 years ago
John Ralls	5fd53c94de	Provide GncOption::GetLimits for setting a NUMBER_RANGE spin button.	5 years ago
John Ralls	a995343a8b	Provide for multiple selections in GncOptionMultichoiceValue To support the GncOptionUIType::LIST. This UI type is unused in GnuCash code but might be used in user custom reports.	5 years ago
John Ralls	16da3208fc	Make GncOptionDateValue::get_period_index return value size_t. Instead of int8_t to match the built-in vector index type.	5 years ago
John Ralls	ac0e7063c7	Move the GncOptionUIType and dirty members to GncOptionUIUtem. Even though it makes the class not pure virtual any more it is necessary behavior common to all possible subclasses.	5 years ago
John Ralls	3200bd4966	Add a multiselect boolean member to GncOptionAccountValue. To support a variation available in dialog-options. Even though it's not used in any GnuCash code nor documented anywhere it might be in some custom reports.	5 years ago
John Ralls	fce33799af	Change GncOptionUIItem to be a pure virtual class instead of a templated one. Simplifies the design because derived classes can have whatever save UI class they need and implement the void(void) set_ui_item_from option and set_option_from_ui_item with whatever functions are appropriate for the UI class. No need for callbacks or std::function members.	5 years ago
John Ralls	00aa0f603d	Add a PLOTSIZE option UI type. I'd missed this one earlier.	5 years ago
John Ralls	6c8e0e23f7	Redesign GncOptionDateValue. After getting a better understanding of how it interacts with dialog-options and finding some additional scheme API needing implementation (exposed only in hello-world.scm, but possibly used in user-written reports). Creates a new file-pair, gnc-options-date.[ch]pp to separate the creation of the static structs with the type info and strings for the various RelativeDatePeriod values from the already too large gnc-option-impl. Although the result is a rather C-ish design the alternative with classes or template specializations would be more complicated and offer no benefit. Implements the permissible_values functions of GncOptionMultichoiceValue for GncDateValue and provides for absolute, relative, and both UI values for the three widget configs afforded by dialog-options.	5 years ago
John Ralls	08bf3ec5b0	Merge branch 'maint'	5 years ago
Christopher Lam	f1e35daab3	Rename option name from "Extra notes" to "Extra Notes"	5 years ago
Christopher Lam	251db8c37b	Rename option name from "Report title" to "Report Title"	5 years ago
Christopher Lam	2606ddf905	Rename option name from "Invoice number" to "Invoice Number" This ensures it matches all other invoice reports.	5 years ago
John Ralls	3b78b6e894	Change the GncOptionMultichoiceValue permissible value return types to const char*. From std::string. The consumer is a GtkWidget so we might as well do the conversion inside the class and this will simplify adding these functions to GncOptionDateValue in the next commit.	5 years ago
John Ralls	d5f6a2539b	Replace GncOption::_get_option() with a friend function swig_get_option. Implemented in gnc-optiondb.i it more clearly indicates the intended use and restricts the access. Unfortunately further limiting the friend declaration with #ifdef SWIG prevented the declaration from working, raising the error "m_option is a private member of GncOption".	5 years ago
John Ralls	93a3716c00	Enable retrieval of a GncOptionDateValue's relative period. So that it can be displayed by dialog-option.	5 years ago
John Ralls	dc876d4041	Provide an accessor to GncOptionAccountValue::m_allowed To enable its use by gnc_account_sel_filter	5 years ago
John Ralls	102f36c3be	Provide more than one Date UI type to match options available in dialog-option.c Also differentiates begin-period and end-period controls.	5 years ago
John Ralls	99c2c5e439	GncOptionUIItem from the GncOptionVariant classes to GncOption. Separating the UI from the data model. Note that the GncOptionVariant classes still have a GncOptionUIType member to ensure that a GncOptionUIItem of the right type is attached.	5 years ago
John Ralls	1bea809cec	Remove the UI interface from GncOptionDB. UI operations occur only in dialog-option so there's no need to expose them from GncOptionDB.	5 years ago
John Ralls	cbf7d70ecd	Integrate gnc-option into app-utils. Includes converting swig-app-utils-guile to c++.	5 years ago
John Ralls	81c5ac6689	Remove the incomplete book-currency code. Not everything from the 6 Book-Currency commits is removed: Switching the Num and split-action fields and restricting edits of transactions older than n days were included and those changes are left in place. Some other partly-implemented features were also part of these commits and were removed: Options for setting a default capital gains account and currency, completion of the LIFO cap-gains policy, and creation of a list of cap-gains policies. If any of these are to be revived they should each be done in a separate feature branch and submitted via Github pull request for a code review before merging; a design discussion on gnucash-devel before restarting work is also advisable.	5 years ago
John Ralls	aa246d3096	Make implementation classes and template code visible only in app-utils. So only GncOption and the GncOptionDB free-function interface are public. We don't want to expose template headers widely, it would blow up compilation times and might lead to one definition rule violations.	5 years ago
John Ralls	20b3ef8a89	Handle some minor differences between libc++ (clang) and libstdc++ (gcc).	5 years ago
John Ralls	cd6ccbe331	Fix account-tree double-free in scheme test when built with gcc. Oddly when built with clang it doesn't exhibit the crash.	5 years ago
John Ralls	691cb0992e	Follow change in loading method for engine's guile bindings.	5 years ago
John Ralls	cbd0607e80	Implement load and store options from/to book options.	5 years ago
John Ralls	5a82aac639	Hide constexpr constants from SWIG. Swig bindings don't need them and SWIG can't digest constexpr.	5 years ago
John Ralls	ffc6866406	Changes to accommodate moving guile engine bindings to bindings/guile. Plus for changing targets gncmod-engine and gncmod-app-utils to gnc-engine and gnc-app-utils.	5 years ago
John Ralls	009219c63d	Much less ugly and fragile. Finding the right form now relies on the form name instead of its position in the parse tree.	5 years ago
John Ralls	276641ef15	Change parse of option input to generate a parse tree. This is I hope less brittle than the previous character-counting, though it's still brittle because it relies instead on counting form-depth.	5 years ago
John Ralls	51a1430c24	Remove stray diagnostic.	5 years ago
John Ralls	76172af239	Implement saving and loading OptionDB items to/from scheme and key-value string representations.	5 years ago
John Ralls	6ab5618b76	Set a 50-character limit on the saved size of option section and name. Allows use of istream::getline() to retrieve the values, simplifying delimiter detection.	5 years ago
John Ralls	d7a2a0ffff	Make a constant for std::numeric_limits<std::size_t>max(). Improves readability.	5 years ago
John Ralls	826d75af16	Use istream::getline instead of std::getline for date option type parsing.	5 years ago
John Ralls	c5294ed6b3	Fix missing-declaration errors in swig-gnc-optiondb-guile.cpp.	5 years ago
John Ralls	7ccba53739	Add stream functions to_scheme and from_scheme to GncOption. These add or parse the textual noise needed to replicate the Scheme options' serialization technique of saving scheme forms for saving report options and then evaluating those forms to restore the option values. Required for backward saved-reports compatibility.	5 years ago
John Ralls	1ea3822665	More operator <</>> Fixups.	5 years ago
John Ralls	98ca190700	Fix commodity in/out to use namespace & mnemonic instead of GUID.	5 years ago
John Ralls	4b997cd025	Fixups for GncOptionDateValue better design.	5 years ago
John Ralls	b2fb57d39e	Fix GncOption::set_value() to work with GncOptionDateValue::set_value(RelativeDatePeriod). Adjusting tests as necessary.	5 years ago
John Ralls	4dcf4a0e6a	Test GncOptionRangeValue as a GncOption. Better representation of how it will be used.	5 years ago
John Ralls	4cabd6c052	Change the GncOptionMultichoiceValue test to use a GncOption. Requires exposing the permissible values functions to GncOption.	5 years ago
John Ralls	e2a36a8be3	Expose function validate to GncOption and test it on GncOptionValidatedValue.	5 years ago
John Ralls	6df516dfcd	Clean up the commodity/currency tests with a better fixture class.	5 years ago
John Ralls	52d0ec5290	Change GncOptionDateValue design to better match usage. Added advantage that it handles (not correctly, but in the same way as the old code) the ambiguity between a period starting or ending with the stored value "relative . today".	5 years ago
John Ralls	883127a59d	Implement operators >> and << on GncOption.	5 years ago
John Ralls	e583c84f4e	Clean up comments for GncOptionDateValue.	5 years ago
John Ralls	aaf6b14c67	Remove commented-out code.	5 years ago
John Ralls	1b00399b14	Remove GncOptionValue<std::Vector<GncGUID>>. This going to be the Account List option implementation, but a more customized approach is better.	5 years ago
John Ralls	5a9c4ccaf8	Clean out copies of the option.scm comments used as a development guide.	5 years ago
John Ralls	b95ea2c4aa	Add Account-list options.	5 years ago
John Ralls	7183e7c43a	Fix begin/end of quarter calculations. Set the period to the calendar year if it's not set in prefs. Handle correctly the FY start month being after the current month.	5 years ago
John Ralls	399573a89d	Fix multichoice test construction.	5 years ago
John Ralls	12c5b94430	New scheme function gnc_option_default_value.	5 years ago
John Ralls	3f576671aa	Adapt GncOptionMultiChoiceValue to support list options. Main change adds a value field to the constructor to set the value and default value.	5 years ago
John Ralls	2f2ac99944	Replace the direct wrapping of GncOptionDB-set-option-string-foo. With a simple type-free function gnc_option_set. This mirrors the current (gnc:option-set(gnc:lookup-option... and takes care of SCM type conversion.	5 years ago
John Ralls	252ba9b477	Change GncOptionDB::lookup_option to gnc_option_value(). The old gnc:lookup-option returned the option object so that it could be manipulated rather than getting its value; gnc_option_value replicates the behavior of (gnc:option-value (gnc:lookup-option)).	5 years ago
John Ralls	ff7b263a5f	Fix up and test the int specialization of GncOptionRangeValue. Not sure yet that a double one is really needed.	5 years ago
John Ralls	39b7c9c74d	Convert scm_from_value() to templates for stricter overload resolution.	5 years ago
John Ralls	3dc4bc2377	Implement GncOptionDateValue.	5 years ago
John Ralls	435667e8fe	Implement GncOptionMultichoiceValue Replaces GncOptionValue<GncMultiChoiceOptionChoices> because having the vector as the value obviously wouldn't work and besides it needs additional functions.	5 years ago
John Ralls	8eedcb6d6d	Extract all SCM functions to gnc-optiondb.i. So that it can be moved to bindings/ when gnc-module-load-begone is ready.	5 years ago
John Ralls	d544f85256	Replace boost::variant and boost::optional with the C++17 std equivs.	5 years ago
John Ralls	694a15ed21	Extract SCM GncOptionDB::lookup_option to gnc-optiondb.i.	5 years ago
John Ralls	16d1f0655b	Get libswig-gnc-optiondb to install in the right place on Windows.	5 years ago
John Ralls	cee3cdaff9	Instantiate GncOption::set_option for guile, initial types string and int. For proof-of-concept. Guile obviously doesn't know about templates.	5 years ago
John Ralls	9cdcaf0da8	Remove GncOptionDB::set_selectable and convert set_option to a template.	5 years ago
John Ralls	935ce6db99	Move the SCM option value conversion from the GncOptionValue classes to GncOption.	5 years ago
John Ralls	e51faff3e3	Throw an exception if one tries to set a GncOption with an unsupported type.	5 years ago
John Ralls	c5fac51a8b	Change the type of OptionUIItem's m_ui_item from void* to GncOptionUIItem. A locally-opaque class wrapping whatever sort of widget ptr one needs. Thanks, warlord!	5 years ago
John Ralls	3296212aef	Sketch out the rest of the option types. Minimal implentation to get it to compile and pass tests, not functional yet.	5 years ago
John Ralls	0a13b4c518	Fix up the SWIG wrapper for GncOptionDBPtr. Thanks to Flexo@stackoverflow for https://stackoverflow.com/questions/27693812/how-to-handle-unique-ptrs-with-swig 5 years later, why isn't this in SWIG yet?	5 years ago
John Ralls	4146251cc7	Add GncOptionUIItem manipulation to GncOptionDB.	5 years ago
John Ralls	6ccb9dbb9e	Use a std::unique_ptr<GncOptionDB> instead of a raw ptr. Passing references to it to the gnc_register_option functions. Not tested yet with SWIG, might not work. Includes introducing fixtures to gtest-gnc-optiondb.cpp.	5 years ago
John Ralls	94628097e4	Use GncOptionUIType parameters in gnc_register_option functions.	5 years ago
John Ralls	3769a356d5	Extract functions find_section and find_option using boost::optional to handle not-found condition.	5 years ago
John Ralls	6deedd441f	Make the ptr returned by GncOption::get_ui_item() const but not the GtkWidget it points to.	5 years ago
John Ralls	40361ec854	gnc-opption.hpp needs to include <functional>.	5 years ago
John Ralls	41ef2c5d44	Add OptionUIItem composition class to GncOption. Provides a type and a raw pointer member with accessors. The type is one of enum GncOptionIUType and is either VOID (for internal options that don't get UI items) or one of the widget types specified in dialog-option.c or business-options-gnome.c.	5 years ago
John Ralls	083e5b93df	Replace the CRTP class GncOptionBase with direct calls in its former children. Benefit of CRTP too limited to accept the cost of understanding it.	5 years ago
John Ralls	cf0b1da4fa	Remove GncOptionWrapper. Move the GncOptions into the GncOptionDB. This works with tests but might not with real reports.	5 years ago
John Ralls	2ee0edaa16	Use targets instead of variables for GncOption* tests.	5 years ago
John Ralls	d2655d3fb0	Remove gnc-option-db business convenience functions. gnc_option_db_lookup_invoice_option used only once, so moved its guts there. The others weren't used at all.	5 years ago
John Ralls	ade7fc8b6e	Initial SWIG of GncOptionDB and Scheme tests. This class will be heavily used by reports so we need to ensure SWIG and Scheme compatibility from the start.	5 years ago
John Ralls	f3eee511e8	Add free functions to create a new GncOptionDB and to register options. The objective of the free functions is to hide the GncOption from language bindings so that the GncOptions can be moved into the GncOptionDB instead of having shared ptrs splattered around the heap. Nearly all access to the options can then be mediated through the GncOptionDB container. Note that gnc_option_db_new creates the GncOptionDB on the heap and returns a raw ptr, so it's up to the creator of the GncOptionDB to call delete on it when it's no longer needed.	5 years ago
John Ralls	455d3c2d60	Add GncOptionDB class.	5 years ago
John Ralls	16fd632ec8	Make the GncOption member variables private. GncOption is intended to be final, so there's no point in protected members.	5 years ago
John Ralls	13b94d2370	Test integer options, calling get_value with wrong type.	5 years ago
John Ralls	d88ec0dc1b	Replace the gnc_make_foo_option free functions with a template ctor. The free functions will reappear for GncOptionDB. This is to avoid having to pass naked pointers to Scheme with the attendant object lifetime issues.	5 years ago
John Ralls	01dc70cc60	Add GncOption accessors for Classifier strings.	5 years ago
John Ralls	01fcae6ac8	Make the OptionClassifier members non-const. Constness deletes the default copy assignment operator, making GncOption not copy-assignable.	5 years ago
John Ralls	b6fd844774	Wrap GncOptionValue/GncOptionValidatedValue in Boost::Variant. To provide a single type for containers.	5 years ago
John Ralls	c0ba3e2706	[C++ Options] Begin Implementation for basic and validated options.	5 years ago
John Ralls	b495da4e29	[C++ Options] Remove some unused C API from options-utils.	5 years ago
John Ralls	e1c153a516	Bug 798224 - Scheduled transactions are created with date-entered... copied from the template transaction.	5 years ago
Christopher Lam	1b4d30b3b1	Merge branch 'maint'	5 years ago
John Ralls	b33d7eb98d	Doxygenize some function description comments in gnc-ui-util.	5 years ago
John Ralls	7f62c5395a	Bug 743999 - Deleting a digit from an existing number greater than... four digits in length generates an error message. Because the grouping is off. Checking grouping on input is pointless so just ignore the grouping separator when parsing number input.	5 years ago
Robert Fewell	7ee9dac2e9	Add filter for currency symbol for GNCAmountEdit widget When pasting an amount that includes the currency symbol the validation will silently fail which may lead to unusual behaviour.	5 years ago
Robert Fewell	748dbf54e0	Change monetary value for gnc_default_share_print_info Share values are not currencies so set the monetary value to 0 for the GNCPrintAmountInfo	5 years ago
Robert Fewell	435bb1c76b	Parse the register monetary cells for a currency symbol Add the ability to strip the currency symbol from a registry monetary cell if it is pasted with one so it can be validated.	5 years ago
Robert Fewell	d55060c0fc	Bug 796761 - Control characters can be pasted in register fields If copied text includes control characters they are inserted when pasted which can cause alignment issues. This commit filters the clipboard text for control characters before it is pasted.	5 years ago
Christopher Lam	5ce8f78f77	Merge branch 'maint'	5 years ago
John Ralls	f7f35faefe	Bug 797928 - Since last run asks for security price when no shares traded Refactor a bit to ensure that the same price variable names and transaction currency is used for both extracting the variables and retrieving any required exchange rates, and that splits with no formula are ignored in both cases.	5 years ago
Robert Fewell	33b8a19253	Add depreciation warnings for the removal of individual option tool tips	5 years ago
Robert Fewell	02a6a0ae4a	Remove the function gnc_option_permissible_value_description Remove function and scheme using this function which deals with individual tool tips on multi-choice options.	5 years ago
Christopher Lam	67e65d436c	Remove duplicate definitions	5 years ago
Christopher Lam	9b671b2039	[date-utilities.scm] remove unused date selectors code & string	5 years ago
Christopher Lam	b06ee5efaf	Merge branch 'maint'	5 years ago
Christopher Lam	d316b01da7	[date-utilities] deprecate unused date selectors	5 years ago
Christopher Lam	d28ff20ff7	Merge branch 'maint'	5 years ago
Geert Janssens	a4cab54afc	i18n - Reuse strings for less translation work	5 years ago
John Ralls	c49b45d8f1	Finish the glib 2.67 fixes for CI tests.	5 years ago
Geert Janssens	e9dfd0d9ea	Still more fixes for Arch ci failure	5 years ago
Geert Janssens	cb04365013	More fixes for Arch ci failure	5 years ago
Christopher Lam	2a2f080813	Merge branch 'maint'	5 years ago
Geert Janssens	fbabcd58e0	Remove dead code	5 years ago
Geert Janssens	b9208eccbf	Remove duplicate declaration The function is also declared and defined in gnc-locale-utils	5 years ago
Geert Janssens	e973a1b60d	Drop default locale currency special case for euro The condition mentioned in the comment no longer applies. All European locales on Windows (MingW64) properly present EUR as currency these days	5 years ago
Christopher Lam	87473ed5f9	Merge branch 'maint'	5 years ago
Sumit Bhardwaj	df579c257b	Replace g_memdup by memcpy GLib is deprecating g_memdup. Since older versions of GLib wouldn't have g_memdup2, this PR replaces occurrences of g_memdup by memcpy.	5 years ago
Christopher Lam	3739d9121c	[date-utilities.scm] typo fix and deprecate unused functions	5 years ago
Frank H. Ellenberger	93e2829ee5	Merge PR #899 into maint	5 years ago
luz paz	16b4976381	Fix typos in libgnucash/ Found via `codespell -q 3 -L ans,ba,parm,parms,numer`	5 years ago
Christopher Lam	b2b8792110	prepend-and-reverse instead of O(N^2) append	5 years ago
Frank H. Ellenberger	6bc8679932	I18N: replace several spourious spaces	5 years ago
John Ralls	7a7c26f87e	Move glib and gtk includes out of extern C for tests. Needed to compile with glib 2.67 and later.	5 years ago
Bill Nottingham	c0f2c3ae25	Fix build with glib2 2.67.x. glib headers should not be included with 'extern "C"'.	5 years ago
Christopher Lam	092040c7fe	Merge branch 'maint'	5 years ago
John Ralls	4359243c08	Move glib and gtk includes out of extern C for tests. Needed to compile with glib 2.67 and later.	5 years ago
Christopher Lam	779c0521e0	[options.scm API] yank canonically-tabbed parent-subtotal-mode 'canonically-tabbed option is buggy and has never graduated out of experimental for 17 years. Time to put it to rest. All previous saved reports with this option will be switched to 't i.e. parent-subtotal-mode enabled..	5 years ago
Bill Nottingham	f60b6354f8	Fix build with glib2 2.67.x. glib headers should not be included with 'extern "C"'.	5 years ago
Micha Lenk	9386b276e5	Make prototypes static for autoclear unit test With the explicit prototypes not marked as static unit test builds on Debian Buster (using buster-backports) fail with error: testing::internal::ParamGenerator<TestCase*> gtest_InstantiationAutoClearTestAutoClearTest_EvalGenerator_() was declared extern and later static [-fpermissive] According to the comment preceding the declaration the only intent of the explicit prototype (in newer versions of googletest implicitly defined by the GTEST macros) seems to be to silence a warning which would cause a build failure on Ubuntu 18.04 when using -Werror. Builds on Debian unstable seem to build just fine without this explicit declaration, hence I consider it safe to just drop it. However, builds on Ubuntu 18.04 then fail (see above). Making the prototypes as static should make both build environments happy.	5 years ago
Christopher Lam	bbcffa3eca	Remove deprecated scheme modules	5 years ago
Christopher Lam	2fa5cba250	Merge branch 'maint'	5 years ago
John Ralls	b66eab2583	Bug 798100 - Equity totals calculating incorrectly Prevents creation of non-currency opening balance accounts.	5 years ago
Christopher Lam	ddc86579c0	Merge branch 'master-remove-deprecated' #855	5 years ago
Frank H. Ellenberger	84cc64daed	I18N: Remove annoying stars from translator comments	5 years ago
Christopher Lam	ebcb0bc478	[master] remove deprecated scheme functions	5 years ago
Christopher Lam	ca606e7694	[c-interface.scm] deprecate gnc:last-captured-error	5 years ago
John Ralls	c8c58bf349	Add test_autoclear_SOURCES to the dist list for inclusion in the tarball.	5 years ago
Christopher Lam	455ae59a56	[app-utils] fix dependency chain	5 years ago
Christopher Lam	0510ecfe85	[c-interface] internal defines must be declared first An internal (define) cannot be after a statement such as (issue-deprecation-warning). This rule was strict in guile-2.2 but relaxed in guile-3.0, hence, the mixed results in CI.	5 years ago
Christopher Lam	bf671d4fc7	[c-interface] Deprecate gnc:make-string-database It's only used by date-utilities.scm This removes the date-utilities -> c-interface dependency.	5 years ago
John Ralls	c2ba88d91d	Add MAKE_LINKS to app-utils and qif-import scheme targets. Needed to successfully build on Windows.	5 years ago
Christopher Lam	dcf90b98c0	[options.scm] use srfi-1 because list-index (used in options.scm) wants srfi-1 version rather than the one in guile-core. the guile-core one crashes when editing options.	5 years ago
Christopher Lam	59ec912928	[modularise] (gnucash app-utils)	5 years ago
Christopher Lam	0630c214f0	[options.scm] move gnc:options-fancy-date to business-options.scm it needs gnc:fancy-date-info which is defined in business-options	5 years ago
Christopher Lam	51e3a65762	[options.scm] typo ref -> list-ref	5 years ago
Christopher Lam	a2ef6ed6a5	Use proper format syntax	5 years ago
Christopher Lam	854c117820	[trep-engine] move currency options into their own section tidier, also includes backward compatibility with saved-reports	5 years ago
Christopher Lam	72982de588	Revert "[date-utilities] Convert reldate list into srfi-9 records" This reverts commit `3be7935965`.	6 years ago
Christopher Lam	8b5dd55dc4	Revert "[c-interface] deprecate gnc:make-string-database" This reverts commit `b67bf4b761`.	6 years ago
Christopher Lam	b67bf4b761	[c-interface] deprecate gnc:make-string-database	6 years ago
Christopher Lam	3be7935965	[date-utilities] Convert reldate list into srfi-9 records	6 years ago
Ralf Habacker	63580d91ba	Add feature GNC_FEATURE_EQUITY_TYPE_OPENING_BALANCE When the above function is activated, the slot 'equity type' is used and set in relation to opening balances and the checkbox for marking the opening balance in the accounts dialog can be changed.	6 years ago
Ralf Habacker	f8dcd23023	Add support for the opening balance accounts flag Up to now, opening balance accounts have been identified by means of fixed names and their translations, which in some cases is not appropriate. With this commit, therefore, opening balance accounts can now be identified by a special slot, which should solve the above problem. in gnc_find_or_create_equity_account(), when querying the EQUITY_OPENING_BALANCE type, the system now first searches for an account with an existing 'equity-type' slot having the value 'opening-balance' and returns it as an opening balance account if one exists. If no corresponding account is found, the search is continued as before. An account found in the process is automatically given the status of an opening balance account (it is given an 'equity-type' slot with value 'opening-balance') to simplify the future search. The opening balance status of an account is visualized in the account settings dialog with a check box. If a Gnucash file does not yet contain an opening balance account, one can be selected in the account settings dialog. https://bugs.gnucash.org/show_bug.cgi?id=797836	6 years ago
John Ralls	e09a26ba3a	Merge Christian Gruber's 'test_import_backend' into maint.	6 years ago
John Ralls	26fa239f89	Merge Christian Klein's 'auto-clear-tests' into maint.	6 years ago
Cristian Klein	69789b2b93	[auto-tests] Stick to CodingStandard for member variables	6 years ago
Cristian Klein	f26215feae	[auto-tests] Fix misspelling	6 years ago
Robert Fewell	65b7b8c4a2	Section help on windows not working Key and group names are case sensitive and in the gnucash-help.hhmap file the section name is [MAP] so change gnc-help-utils.c to match	6 years ago
Cristian Klein	e5378b2048	[auto-clear] Make test more future-proof with GoogleTest	6 years ago
Cristian Klein	982cf86deb	[auto-clear] Fix test with googletest 1.8	6 years ago
Cristian Klein	9d4c0b05db	[auto-clear] Improve #include style	6 years ago
Cristian Klein	1cf7defee8	[auto-clear] Address feedback	6 years ago
Cristian Klein	9bf550d38f	[auto-clear] Include test for ambiguous cases	6 years ago
Cristian Klein	5cd777b673	[auto-clear] Fix test: Add xaccAccountBeginEdit / xaccAccountCommitEdit	6 years ago
Cristian Klein	2faecb2074	[auto-clear] Avoid testing ambigous auto-clear	6 years ago
Cristian Klein	a1806a2f94	[auto-clear] Fix model	6 years ago
Cristian Klein	51715e454c	[auto-clear] Add tests	6 years ago
Christopher Lam	78c8b03c5e	[window-autoclear.c] cleanup, optimize, prevent UI lag abort: 1. if too many splits lead to >1,000,000 reachable amounts 2. if the end_balance is the same as cleared_balance also: - g_free lists properly - move knapsack algorithm to gnc-ui-balances.c - show newly cleared splits in a new register: "Cleared Transactions" - remove unneeded #includes	6 years ago
Robert Fewell	3c5066feb4	Change source files option-util.* for spaces and tabs	6 years ago
Robert Fewell	c11f4db96e	Bug 345924 - Report options 'Reset Button' always flags changes If a report is loaded with default settings and the 'Reset button' is pressed the 'OK/Apply' buttons will be enabled which should not happen as there are no changes to be made. Fixed by resetting the changed flag on options load and then comparing the current value to the default one when the 'Reset button' pressed.	6 years ago
Christopher Lam	39a6704169	[options.scm] rename new-owner-report "Links" to "Transaction Links"	6 years ago
Christian Gruber	e44cf9c61f	Add missing C linkage statements	6 years ago
John Ralls	db626de68a	Rename all Transaction and Invoice Association identifiers to DocLink. To better reflect the purpose and for consistency with other software (e.g. Libre Office).	6 years ago
John Ralls	50bf59d62e	Rename Transaction and Invoice Associations to Document Links. More clearly describes the actions and is more consistent with other software (e.g. Libre Office). This commit primarily changes the translatable strings, though it also removes the Remove menu item because that can be done in the Manage dialog box.	6 years ago
Geert Janssens	ad8b602fe2	I18n - Uppercase option name to align with other option names	6 years ago
Geert Janssens	56210de9a2	Rename report option for consistency In English each word in option and menu names starts with a capital letter. Also eliminates a redundant translatable string.	6 years ago
Christopher Lam	d546a617ad	ensure averaging-multipler returns exact numbers rather than floats	6 years ago
Christopher Lam	428c8c501c	[guile-3] change _ to G_ In guile-3 _ is a reserved symbol. Change to G_ by guile gettext convention.	6 years ago
Christian Gruber	3d92d53917	Rename all class methods using snake_case instead of camelCase	6 years ago
Christian Gruber	8425af784e	Check pointer to preferences backend before using it	6 years ago
Christian Gruber	766f88c02d	Replace singleton class MockPrefsBackend by an ordinary class	6 years ago
John Ralls	4ee573e23a	Link with libm.so on those platforms that require it.	6 years ago
Christopher Lam	851bc7f8d9	deprecations: clarify functions deprecated in 4.x.	6 years ago
Geert Janssens	a124e647db	Add files omitted in previous commit	6 years ago
Geert Janssens	5fc2b9519c	Add mock sources and import-export test to dist	6 years ago
Robert Fewell	785a6a8fa6	Add a new cell type for Transaction associations that supports the use of glyphs	6 years ago
John Ralls	f2a13ecac7	Merge Christian Gruber's 'test_import_backend' into master.	6 years ago
Christopher Lam	f8bad131a5	Merge branch 'maint-797743' #720 price renderers	6 years ago
Christopher Lam	3d25a40d1f	[gnc-ui-util] add gnc_price_print_info similar to gnc_default_price_print_info but also accepts a use_symbol specifier. for generating print_info for prices, either exact e.g. $1 + 2/3, or inexact e.g. $1.3333	6 years ago
Christopher Lam	f9dfdb3e6c	[c-interface] compact code, use (ice-9 match)	6 years ago
Mike Alexander	478112d8c0	Define log_module in gnc-sx-instance-model.c.	6 years ago
John Ralls	fbf7171ab6	Fix libgnc-app-utils.dylib install_name_dir. The install location changed as part of expunging libgnc-module.	6 years ago
John Ralls	758bd7b656	Merge branch 'maint'	6 years ago
Geert Janssens	bbeb9a2b62	Drop all gnc-module dependencies and includes from compilation units that no longer use it This also drops the python wrapper for gnc-module. As for the guile wrappers, python should use other means of loading our shared libraries. This commit required a few tweaks to the dependency chain as some units inherited dependency information from gnc-module's public dependency interface.	6 years ago
Geert Janssens	abf29aa196	Drop the gnc-module wrapper around the test-engine library It's not adding anything	6 years ago
Christopher Lam	8023065030	[fin.scm] return #f instead of -1 if n is out of range	6 years ago
Christopher Lam	96a6e1b0d5	Merge branch 'patch-1' of git://github.com/thetedmunds/gnucash into maint	6 years ago
Christopher Lam	6de712b501	[gnc-exp-parser] don't crash when gnc:fn returns non-number if gnc:fn returns anything other than a number, abort rather than crash	6 years ago
thetedmunds	d6c5b115d8	Adding lines missing from fix for Bug 797196 Adding definition of gnc:amort_balance() that got lost in the original pull-request for Bug 797196.	6 years ago
John Ralls	3ca8fa1229	Merge branch 'maint'	6 years ago
John Ralls	fdfaca5575	Merge Christoph Holtermann's 'python-session-instance-constructor' into maint.	6 years ago
c-holtermann	ab843c0b7a	include gnucash_core of python bindings in python swig app-utils	6 years ago
jean	4a8350ece2	797318 - Amounts ending in zero displayed as fractions	6 years ago
Geert Janssens	e78313147c	Cmake - rework gnc_add_scheme_deprecated_module to use keyword parameters Update all invocations accordingly	6 years ago
Geert Janssens	06ff8a292d	Use new keyword parameters for all calls to gnc_add_scheme_test_targets	6 years ago
Geert Janssens	c05281c582	Use new keyword parameters for all calls to gnc_add_scheme_targets	6 years ago
John Ralls	f85be03bb5	Merge branch 'maint'	6 years ago
Christopher Lam	50674ef632	[gnc-ui-balances] add and expose gnc_ui_account_get_reconciled_balance_as_of_date	6 years ago
Geert Janssens	301db9020d	Merge branch 'maint'	6 years ago
Geert Janssens	e79e82edcf	CMake - remove parameter repetition in else() and endif() statements This follows Professional CMake's recommended practises	6 years ago
Geert Janssens	490b20d2da	Merge branch 'maint'	6 years ago
Geert Janssens	d8a304c2c9	Housekeeping - reduce the number of PACKAGE and VERSION related cmake variables This starts by setting the gnucash version number in the 'project' call. This will result in a number of variables set by cmake. The remainder of this commit is to reuse the auto-generated PROJECT_NAME, PROJECT_VERSION, PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR, PROJECT_VERSION_PATCH and PROJECT_VERSION_TWEAK instead of all the various instances of PACKAGE, GNUCASH_MAJOR_VERSION and so on. One parameter is worth mentioning - GETTEXT_PACKAGE GnuCash is not using this directly (any more) but it has to be set before including gi18n-lib.h.	6 years ago
Christopher Lam	279a5fcde8	Merge branch 'maint'	6 years ago
Geert Janssens	e8451ae1db	tax - remove gncmod boilerplate This is now an ordinary shared library * Remove test to load the gnc-module in scheme * Rewrite test to load the module in C to actually test something.	6 years ago
Geert Janssens	d52aa0a0dd	app-utils - remove gnc-module boilerplate app-utils now is an ordinery shared library A few bits worth mentioning: 1. it's not guile-free just yet, so instead of a gnc_module_load your code may have to call scm_c_use_module("gnucash app-utils"); to expose the scm side of the app-utils api. This call has been added to gnucash-bin.c for example 2. while lots of noise in this commit is to rename from gncmodule-app-utils to gnc-app-utils, I'll point out the library has also been moved from <libdir>/gnucash to <libdir>. This required changes in app-util's CMakeLists.txt file for the install side and in the top level CMakeLists.txt file for the build directory structure. 3. The C side link module test has been removed as linking an ordinary shared library should be considered well tested by the compiler devs. The scheme side module load test has been slightly tweaked to no longer try to use gnc:module-load, but instead now checks whether the app-utils api is properly exposed to scheme after loading it via use-modules. 4. Dropped a completely obsolete README file.	6 years ago
Geert Janssens	90aa539908	app-utils - make gnc-expression-parser responsible for its own cleanup It already ensured it would initialize on first use. It can as well register the hooks it needs for its cleanup directly itself instead of depending on the module loading system to do so.	6 years ago
Geert Janssens	43647c7a54	app-utils - move component manager to gnome-utils It's primary purpose is to track gui objects' lifetimes. There's no need for libgnucash (a non-gui library) to deal with that. This required two book options related gui-only call backs to be moved to gnome-utils as well.	6 years ago
Geert Janssens	4c77f7670e	engine - remove gncmod boilerplate engine is now an ordinary shared library This requires a few more places to run gnc_engine_init as this is no longer done as part of module loading.	6 years ago
Geert Janssens	bd311d5dfb	report - expose wrapped api directly from report-core.scm With that in place we no longer need to (gnc:module-load "gnucash/report" 0) the report gncmodule. An ordinary (use-modules (gnucash report)) suffices Note: as gncmod-report did additional initialization, most reports needed additional tweaks like using app-utils. And in app-utils the initialization of the relative date terms has been tweaked as well to run whenever the app-utils module gets loaded first time, rather than having this initialized by gncmod-report.	6 years ago
Geert Janssens	c00bf6bcdb	app-utils - expose wrapped api directly from app-utils.scm With that in place we no longer need to (gnc:module-load "gnucash/app-utils" 0) the app-utils gncmodule. An ordinary (use-modules (gnucash app-utils)) suffices	6 years ago
Geert Janssens	6a3505d01f	app-utils - move price-quotes support functions directly into bindings - wrappers for glib functions go into glib-guile - engine convenience functions go into gnc-engine-guile	6 years ago
Geert Janssens	9ed9621363	app-utils - remove unused guile includes	6 years ago
Geert Janssens	d777128e6f	app-utils - simplify and move gettext wrappers 1. Instead of creating a C wrapper around gettext to then wrap in guile, use guile's builtin gettext support directly. The code still defines the _ and N_ shorthands. However it doesn't really warant a separate module just for these two shorthands. Instead define them in core-utils. So all code wanting to use _ or N_ in guile should now use the (gnucash core-utils) module. The bulk of this commit is actually deleting the scm-gettext target and using (gnucash core-utils) instead of (gnucash gettext). 2. As the definition of _ and N_ is removed from app-utils.scm, the app-utils test for a functional N_ macro has been moved to a new test file in the guile bindinds tests. 3. The (gnucash gettext) module has been deprecated. Use (gnucash core-utils) from now on.	6 years ago
Geert Janssens	759bbe1da0	app-utils - move gnc_get_debit/credit_str functions to Account Eliminates another scm file (prefs.scm). The old scm functions are declared deprecated.	6 years ago
Geert Janssens	02511401b7	bindings/guile cosmetic - rename source files for consistency	6 years ago
Geert Janssens	1c7f835f47	engine - move guile code to bindings/guile This commit tries to do the minimum necessary to move the guile bits from engine to bindings/guile. As engine is a very central piece in the software, this unfortunately still touches many other source files: - A few helper objects have been squashed together: * engine-helpers-guile.[ch] (of which the c part is extracted from engine-helpers.c) * gncBusGuile.[ch] * gnc-hooks-scm.[ch] - The initialization function of gncmod-engine no longer initializes the scm bits. Any scm code that wants to interact with the engine code now has to load the (gnucash engine) scm module, or sometimes (gnucash business-core). The bulk of changes in this commit actually is updating all the scm consumers to do so. - scm-scm target has been removed. Instead (gnucash utilities) is part of scm-engine. A few dependency graphs have been updated for this. More refinements will be in followup commits.	6 years ago
Geert Janssens	b1ba16c33b	gnc-hooks - factor out scm calls into a separate source file This required the addition of an extra parameter to gnc_hook_add_dangler to allow the scm hooks to unprotect the scm data on hook destruction.	6 years ago
Geert Janssens	18093b5e82	core-utils - move guile utils to bindings/guile	6 years ago
Geert Janssens	33e1ff645c	Allow to pass include directories to the add_swig_xyz commands This will be needed when the wrappers no longer live in the same directory as the objects they are wrapping.	6 years ago
Christopher Lam	2cd69e8d85	[budgets.c] handle both natural & reversed signs budgets introduce new API * gnc_using_unreversed_budgets - queries book's unreversed feature * gnc_reverse_budget_balance - check if book unreversal status matches 2nd argument. if so, return account's reversal status. else, return FALSE. * gnome-budget-view can now show both natural and reversed budgets * gnome-plugin-page-budget will now read&write both natural and reversed budgets.	6 years ago
Geert Janssens	9f5cbb3a82	app-utils - move register's copy operations to ledger-core They are only used by split-register.c in that directory	6 years ago
Geert Janssens	02afa33e54	app-utils - reduce guile-util api-surface Make internal-use only function static and drop two unused functions.	6 years ago
Geert Janssens	efefac3e1e	Dead code removal	6 years ago
Christopher Lam	e6c6d4e0bb	Merge branch 'maint'	7 years ago
John Ralls	9189bcbe41	Bug 797078 - "Automatic decimal point" Should Not Cause 2 Different Behaviors It's documented only for automatically inserting the decimal point so remove the code that affects number display.	7 years ago
John Ralls	ba5bd6b4d7	Merge branch 'maint'	7 years ago
Christopher Lam	d56a47f17a	[c-interface] gnc:backtrace-if-exception returns #f if error previous would return unspecified when error was captured. old code seems to expect #f to signal error	7 years ago
Christopher Lam	0c65c41b32	guile: remove support for guile < 2.0	7 years ago
Geert Janssens	0eb0b922d7	Python - remove 2.x only code paths	7 years ago
Christopher Lam	b49109b782	Merge branch 'maint'	7 years ago
Christopher Lam	9832fa397a	[window-report] show backtrace when report crashes * exposes a SCM string last-captured-error containing last backtrace * when rendering report-crash window, include it	7 years ago
John Ralls	b8b33b9591	Revert "More conversions from pkg-config variables to imported targets." This reverts commit `1a9fcfefad` because on MinGW cmake complains about the paths in pkgconfig files. This can be addressed by using the MSYS2 cmake instead of the MINGW32 one, but that requires some other changes... and there's also a path separator bug in that version of FindPkgConfig.cmake.	7 years ago

... 4 5 6 7 8 ...

724 Commits (1890c6ccfb1fbfa6063bf34c8a2e406b6e41c9d5)