pull/2/head
Broque Thomas 11 months ago
parent 8dfe802b1b
commit 106f5178a2

@ -36,60 +36,61 @@ The application will use a central `config.json` file to store:
- ✅ Audio streaming and playback from Soulseek search results
- ✅ Service status monitoring and connection indicators
- ✅ Configuration management system
- ✅ Download progress tracking for both singles and albums
- ✅ Enhanced filename matching system preventing false positives
- ✅ Compact download queue UI with proper space utilization
**Active Work**:
- 🔧 Download Manager functionality and UI improvements
- 🔧 Download tracking system (requires fixes - see Known Issues)
- 🔧 Download Manager button functionality (Cancel/Open buttons)
- ⏳ Additional UI polish and user experience improvements
**Known Issues Requiring Attention**:
**Recently Resolved Issues**:
### Download Tracking System Issues
**Priority**: High - Download tracking is partially broken
### ✅ Download Tracking System (RESOLVED)
- **FIXED**: Download progress tracking now works correctly for both singles and albums
- **FIXED**: Album tracks no longer show same name in active downloads - enhanced filename matching prevents false matches
- **FIXED**: Download ID management and API integration properly handles real UUIDs
- **FIXED**: UI state synchronization for completed downloads with proper queue transitions
**Problem Summary**: The download tracking system has ID management issues causing cancellation failures and incomplete UI updates.
**Current Issues Requiring Attention**:
### Download Manager Button Issues
**Priority**: High - Download queue buttons non-functional
**Problem Summary**: The Cancel and Open buttons in download queue interface are not working when clicked.
**Specific Issues**:
1. **Download Cancellation Fails (405 Errors)**:
- Location: `core/soulseek_client.py:809-819` (cancel_download method)
- Problem: Using constructed filename-based IDs instead of actual API download IDs
- API returns proper UUIDs like `"2f7e8184-e644-4439-b02d-e48f9c8d24ca"`
- Code tries to cancel with malformed IDs like `"systemdip_Music\Kendrick Lamar\DAMN. (2017)\01 - BLOOD.flac_1752258522"`
2. **Download ID Mismatch**:
- Location: `core/soulseek_client.py:639-732` (download method)
- Problem: Not properly storing/returning actual download IDs from API responses
- Need to capture and use the real download ID returned by slskd API
3. **Progress Tracking UI Updates**:
- Location: `ui/pages/downloads.py:3828-3865` (progress tracking)
- Problem: UI doesn't properly reflect download status changes
- Missing handling for completed downloads without `percentComplete` field
**What's Working**:
- slskd API is responding correctly (status 200)
- Downloads initiate successfully
- Transfer status endpoint returns proper data
- Download completion detection works
**What Needs Fixing**:
- Download ID storage and management
- Cancel download endpoint URL construction
- UI state synchronization for completed downloads
- Error handling for missing API fields
### Download Manager UI Improvements
**Priority**: Medium - User experience enhancements requested
**Requested Changes**:
1. **Cancel Button Not Working**:
- Location: CompactDownloadItem cancel button in active download queue
- Problem: Button clicks not triggering download cancellation
- Likely causes: Signal connection issues or incorrect download ID usage for API calls
- Expected behavior: Should cancel active downloads and remove from queue
2. **Open Button Not Working**:
- Location: CompactDownloadItem open button in finished downloads section
- Problem: Button clicks not opening download folder location
- Likely causes: Missing signal connections, incorrect file paths, or silent error handling
- Expected behavior: Should open file explorer to show downloaded files
**Investigation Needed**:
- Verify button signal connections in CompactDownloadItem class
- Check if download IDs are properly passed to cancellation methods
- Validate file paths for completed downloads
- Add user feedback for button operation failures
### Future UI Improvements
**Priority**: Low - Additional enhancements for later consideration
**Potential Changes**:
1. Remove "Pause All" button (not needed)
2. Fix "Clear Completed" functionality (currently doesn't work)
3. Replace "Details" button with "Reveal/Open" button that opens the folder containing downloaded files
3. Additional download queue management features
## Key Components Status
1. **Configuration Management**: ✅ Implemented - Secure handling of API keys and service credentials
2. **Spotify Integration**: ✅ Implemented - Playlist retrieval and metadata extraction
3. **Plex Integration**: ✅ Implemented - Media server synchronization and metadata updates
4. **Soulseek Integration**: 🔧 Partially Complete - Music discovery works, download tracking needs fixes
4. **Soulseek Integration**: ✅ Mostly Complete - Music discovery and download tracking working, minor button issues remain
5. **Matching Engine**: ⏳ Planned - Robust algorithms for matching tracks across services
6. **User Interface**: ✅ Mostly Complete - Spotify-inspired design with modern, animated elements

File diff suppressed because it is too large Load Diff
Loading…
Cancel
Save