From b16aa9c83286a4713aeb69a1e54c7f3687034df1 Mon Sep 17 00:00:00 2001 From: DanielDerefaka Date: Thu, 1 Jan 2026 11:07:16 +0100 Subject: [PATCH 1/7] fix(discord): hide empty Service URL and N/A Ping fields - Only show Service URL field when extractAddress returns a non-empty value - Only show Ping field when ping value is not null - This fixes unnecessary 'https://' and 'N/A' values showing for groups Fixes #3327 Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=101010297 --- server/notification-providers/discord.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/notification-providers/discord.js b/server/notification-providers/discord.js index 98e97b85f..155281cdc 100644 --- a/server/notification-providers/discord.js +++ b/server/notification-providers/discord.js @@ -58,7 +58,7 @@ class Discord extends NotificationProvider { name: "Service Name", value: monitorJSON["name"], }, - ...(!notification.disableUrl ? [{ + ...((!notification.disableUrl && this.extractAddress(monitorJSON)) ? [{ name: monitorJSON["type"] === "push" ? "Service Type" : "Service URL", value: this.extractAddress(monitorJSON), }] : []), @@ -98,7 +98,7 @@ class Discord extends NotificationProvider { name: "Service Name", value: monitorJSON["name"], }, - ...(!notification.disableUrl ? [{ + ...((!notification.disableUrl && this.extractAddress(monitorJSON)) ? [{ name: monitorJSON["type"] === "push" ? "Service Type" : "Service URL", value: this.extractAddress(monitorJSON), }] : []), @@ -106,10 +106,10 @@ class Discord extends NotificationProvider { name: `Time (${heartbeatJSON["timezone"]})`, value: heartbeatJSON["localDateTime"], }, - { + ...(heartbeatJSON["ping"] != null ? [{ name: "Ping", - value: heartbeatJSON["ping"] == null ? "N/A" : heartbeatJSON["ping"] + " ms", - }, + value: heartbeatJSON["ping"] + " ms", + }] : []), ], }], }; From c9381154a6013fedd3923f1201f4f4c5f301c4ba Mon Sep 17 00:00:00 2001 From: DanielDerefaka Date: Thu, 1 Jan 2026 11:41:11 +0100 Subject: [PATCH 2/7] feat(status-page): add og:type and og:image Open Graph meta tags Added additional Open Graph meta tags to status pages for better social media sharing: - og:type (set to "website") - og:image (uses the status page icon if configured) This complements the existing og:title and og:description tags. Fixes #6514 --- server/model/status_page.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/server/model/status_page.js b/server/model/status_page.js index 224441127..9842f0019 100644 --- a/server/model/status_page.js +++ b/server/model/status_page.js @@ -132,6 +132,14 @@ class StatusPage extends BeanModel { let ogDescription = $("").attr("content", description155); head.append(ogDescription); + let ogType = $(""); + head.append(ogType); + + if (statusPage.icon) { + let ogImage = $("").attr("content", statusPage.icon); + head.append(ogImage); + } + // Preload data // Add jsesc, fix https://github.com/louislam/uptime-kuma/issues/2186 const escapedJSONObject = jsesc(await StatusPage.getStatusPageData(statusPage), { From 6a95a882139926a2b625e713669536e92fe53b31 Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Fri, 2 Jan 2026 06:40:27 +0100 Subject: [PATCH 3/7] Update server/model/status_page.js --- server/model/status_page.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/server/model/status_page.js b/server/model/status_page.js index 9842f0019..7087e4e09 100644 --- a/server/model/status_page.js +++ b/server/model/status_page.js @@ -135,11 +135,6 @@ class StatusPage extends BeanModel { let ogType = $(""); head.append(ogType); - if (statusPage.icon) { - let ogImage = $("").attr("content", statusPage.icon); - head.append(ogImage); - } - // Preload data // Add jsesc, fix https://github.com/louislam/uptime-kuma/issues/2186 const escapedJSONObject = jsesc(await StatusPage.getStatusPageData(statusPage), { From 1532acaaf3d4c87f1c2d92b7161bcdc119a1549f Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Fri, 2 Jan 2026 06:46:50 +0100 Subject: [PATCH 4/7] don't call extractAddress twice --- server/notification-providers/discord.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/server/notification-providers/discord.js b/server/notification-providers/discord.js index 155281cdc..e560e38d5 100644 --- a/server/notification-providers/discord.js +++ b/server/notification-providers/discord.js @@ -47,6 +47,7 @@ class Discord extends NotificationProvider { // If heartbeatJSON is not null, we go into the normal alerting loop. if (heartbeatJSON["status"] === DOWN) { + let addess = this.extractAddress(monitorJSON); let discorddowndata = { username: discordDisplayName, embeds: [{ @@ -58,9 +59,9 @@ class Discord extends NotificationProvider { name: "Service Name", value: monitorJSON["name"], }, - ...((!notification.disableUrl && this.extractAddress(monitorJSON)) ? [{ + ...((!notification.disableUrl && addess) ? [{ name: monitorJSON["type"] === "push" ? "Service Type" : "Service URL", - value: this.extractAddress(monitorJSON), + value: addess, }] : []), { name: `Time (${heartbeatJSON["timezone"]})`, @@ -87,6 +88,7 @@ class Discord extends NotificationProvider { return okMsg; } else if (heartbeatJSON["status"] === UP) { + let addess = this.extractAddress(monitorJSON); let discordupdata = { username: discordDisplayName, embeds: [{ @@ -98,9 +100,9 @@ class Discord extends NotificationProvider { name: "Service Name", value: monitorJSON["name"], }, - ...((!notification.disableUrl && this.extractAddress(monitorJSON)) ? [{ + ...((!notification.disableUrl && addess) ? [{ name: monitorJSON["type"] === "push" ? "Service Type" : "Service URL", - value: this.extractAddress(monitorJSON), + value: addess, }] : []), { name: `Time (${heartbeatJSON["timezone"]})`, From e4552a2184963bf1ab74d74881c512f70fa21f43 Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Fri, 2 Jan 2026 06:47:29 +0100 Subject: [PATCH 5/7] simplify extractAddress(monitorJSON) a bit more --- server/notification-providers/discord.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/notification-providers/discord.js b/server/notification-providers/discord.js index e560e38d5..4c573d632 100644 --- a/server/notification-providers/discord.js +++ b/server/notification-providers/discord.js @@ -46,8 +46,8 @@ class Discord extends NotificationProvider { } // If heartbeatJSON is not null, we go into the normal alerting loop. + let addess = this.extractAddress(monitorJSON); if (heartbeatJSON["status"] === DOWN) { - let addess = this.extractAddress(monitorJSON); let discorddowndata = { username: discordDisplayName, embeds: [{ @@ -88,7 +88,6 @@ class Discord extends NotificationProvider { return okMsg; } else if (heartbeatJSON["status"] === UP) { - let addess = this.extractAddress(monitorJSON); let discordupdata = { username: discordDisplayName, embeds: [{ From c282c2ae3a7c14a96f9cbb05caa7d7b727841a7e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 2 Jan 2026 05:49:53 +0000 Subject: [PATCH 6/7] Initial plan From 78e9d9fb64603f0eb2218862b95334a683140361 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 2 Jan 2026 05:55:39 +0000 Subject: [PATCH 7/7] Add migration to change dns_last_result column to TEXT Co-authored-by: louislam <1336778+louislam@users.noreply.github.com> --- .../2026-01-02-0551-dns-last-result-to-text.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 db/knex_migrations/2026-01-02-0551-dns-last-result-to-text.js diff --git a/db/knex_migrations/2026-01-02-0551-dns-last-result-to-text.js b/db/knex_migrations/2026-01-02-0551-dns-last-result-to-text.js new file mode 100644 index 000000000..76874e3f0 --- /dev/null +++ b/db/knex_migrations/2026-01-02-0551-dns-last-result-to-text.js @@ -0,0 +1,14 @@ +// Change dns_last_result column from VARCHAR(255) to TEXT to handle longer DNS TXT records +exports.up = function (knex) { + return knex.schema + .alterTable("monitor", function (table) { + table.text("dns_last_result").alter(); + }); +}; + +exports.down = function (knex) { + return knex.schema + .alterTable("monitor", function (table) { + table.string("dns_last_result", 255).alter(); + }); +};