terraform

History

Martin Atkins 30e2fd6525 Handle marks a little more consistently In the very first implementation of "sensitive values" we were unfortunately not disciplined about separating the idea of "marked value" from the idea of "sensitive value" (where the latter is a subset of the former). The first implementation just assumed that any marking whatsoever meant "sensitive". We later improved that by adding the marks package and the marks.Sensitive value to standardize on the representation of "sensitive value" as being a value marked with _that specific mark_. However, we did not perform a thorough review of all of the mark-handling codepaths to make sure they all agreed on that definition. In particular, the state and plan models were both designed as if they supported arbitrary marks but then in practice marks other than marks.Sensitive would be handled in various inconsistent ways: dropped entirely, or interpreted as if marks.Sensitive, and possibly do so inconsistently when a value is used only in memory vs. round-tripped through a wire/file format. The goal of this commit is to resolve those oddities so that there are now two possible situations: - General mark handling: some codepaths genuinely handle marks generically, by transporting them from input value to output value in a way consistent with how cty itself deals with marks. This is the ideal case because it means we can add new marks in future and assume these codepaths will handle them correctly without any further modifications. - Sensitive-only mark preservation: the codepaths that interact with our wire protocols and file formats typically have only specialized support for sensitive values in particular, and lack support for any other marks. Those codepaths are now subject to a new rule where they must return an error if asked to deal with any other mark, so that if we introduce new marks in future we'll be forced either to define how we'll avoid those markings reaching the file/wire formats or extend the file/wire formats to support the new marks. Some new helper functions in package marks are intended to standardize how we deal with the "sensitive values only" situations, in the hope that this will make it easier to keep things consistent as the codebase evolves in future. In practice the modules runtime only ever uses marks.Sensitive as a mark today, so all of these checks are effectively covering "should never happen" cases. The only other mark Terraform uses is an implementation detail of "terraform console" and does not interact with any of the codepaths that only support sensitive values in particular.		2 years ago
..
remote	statemgr: Incorporate IntermediateStateConditionalPersister	2 years ago
statefile	Handle marks a little more consistently	2 years ago
statemgr	statemgr: Incorporate IntermediateStateConditionalPersister	2 years ago
checks.go	Update copyright file headers to BUSL-1.1	3 years ago
doc.go	Update copyright file headers to BUSL-1.1	3 years ago
instance_object.go	Handle marks a little more consistently	2 years ago
instance_object_src.go	Handle marks a little more consistently	2 years ago
instance_object_test.go	Handle marks a little more consistently	2 years ago
module.go	states: Local values no longer live in state	2 years ago
objectstatus_string.go	…
output_value.go	Update copyright file headers to BUSL-1.1	3 years ago
resource.go	addrs: Adopt DeposedKey as an address type; remove states.Generation	2 years ago
resource_test.go	Update copyright file headers to BUSL-1.1	3 years ago
state.go	providerreqs: Provider requirement/version types in their own package	2 years ago
state_deepcopy.go	Handle marks a little more consistently	2 years ago
state_equal.go	Update copyright file headers to BUSL-1.1	3 years ago
state_string.go	states: Only track root module output values	2 years ago
state_test.go	Handle marks a little more consistently	2 years ago
sync.go	states: Local values no longer live in state	2 years ago