terraform

History

Martin Atkins fa0d6484df configs/configupgrade: Detect and fix element(...) usage with sets Although sets do not have indexed elements, in Terraform 0.11 and earlier element(...) would work with sets because we'd automatically convert them to lists on entry to HIL -- with an arbitrary-but-consistent ordering -- and this return an arbitrary-but-consistent element from the list. The element(...) function in Terraform 0.12 does not allow this because it is not safe in general, but there was an existing pattern relying on this in Terraform 0.11 configs which this upgrade rule is intended to preserve: resource "example" "example" { count = "${length(any_set_attribute)}" foo = "${element(any_set_attribute, count.index}" } The above works because the exact indices assigned in the conversion are irrelevant: we're just asking Terraform to create one resource for each distinct element in the set. This upgrade rule therefore inserts an explicit conversion to list if it is able to successfully provide that the given expression will return a set type: foo = "${element(tolist(any_set_attribute), count.index}" This makes the conversion explicit, allowing users to decide if it is safe and rework the configuration if not. Since our static type analysis functionality focuses mainly on resource type attributes, in practice this rule will only apply when the given expression is a statically-checkable resource reference. Since sets are an SDK-only concept in Terraform 0.11 and earlier anyway, in practice that works out just right: it's not possible for sets to appear anywhere else in older versions anyway.		7 years ago
..
test-fixtures	configs/configupgrade: Detect and fix element(...) usage with sets	7 years ago
analysis.go	configs/configupgrade: Do type inference with input variables	7 years ago
analysis_expr.go	configs/configupgrade: Do type inference with input variables	7 years ago
doc.go	configupgrade: new package for upgrading configs for 0.12	8 years ago
module_sources.go	configupgrade: Load source code for a module and detect already upgraded	8 years ago
module_sources_test.go	configupgrade: Load source code for a module and detect already upgraded	8 years ago
upgrade.go	configs/configupgrade: Retain any .tf.json files unchanged	7 years ago
upgrade_body.go	configs/configupgrade: Remove redundant list brackets	7 years ago
upgrade_expr.go	configs/configupgrade: Detect and fix element(...) usage with sets	7 years ago
upgrade_native.go	configs/configupgrade: upgrade expressions inside heredocs	7 years ago
upgrade_test.go	configs/configupgrade: Detect and fix element(...) usage with sets	7 years ago
upgrader.go	terraform: More wiring in of new provider types	8 years ago