terraform

History

Martin Atkins 70bc432f85 command/views/json: Never generate invalid diagnostic snippet offsets Because our snippet generator is trying to select whole lines to include in the snippet, it has some edge cases for odd situations where the relevant source range starts or ends directly at a newline, which were previously causing this logic to return out-of-bounds offsets into the code snippet string. Although arguably it'd be better for the original diagnostics to report more reasonable source ranges, it's better for us to report a slightly-inaccurate snippet than to crash altogether, and so we'll extend our existing range checks to check both bounds of the string and thus avoid downstreams having to deal with out-of-bounds indices. For completeness here I also added some similar logic to the human-oriented diagnostic formatter, which consumes the result of the JSON diagnostic builder. That's not really needed with the additional checks in the JSON diagnostic builder, but it's nice to reinforce that this code can't panic (in this way, at least) even if its input isn't valid.		5 years ago
..
json	command/views/json: Never generate invalid diagnostic snippet offsets	5 years ago
add.go	remove IsMarked and ContainsMarked calls	5 years ago
add_test.go	remove IsMarked and ContainsMarked calls	5 years ago
apply.go	Move terraform/ to internal/terraform/	5 years ago
apply_test.go	update to use typed sensitive marks	5 years ago
hook_count.go	Move terraform/ to internal/terraform/	5 years ago
hook_count_test.go	Move terraform/ to internal/terraform/	5 years ago
hook_json.go	Move terraform/ to internal/terraform/	5 years ago
hook_json_test.go	Move terraform/ to internal/terraform/	5 years ago
hook_ui.go	Move terraform/ to internal/terraform/	5 years ago
hook_ui_test.go	Move terraform/ to internal/terraform/	5 years ago
json_view.go	command/views: Remove unused drift summary message	5 years ago
json_view_test.go	Move plans/ to internal/plans/	5 years ago
operation.go	Move terraform/ to internal/terraform/	5 years ago
operation_test.go	no drift with only deposed changes	5 years ago
output.go	Move states/ to internal/states/	5 years ago
output_test.go	Move states/ to internal/states/	5 years ago
plan.go	typo	5 years ago
plan_test.go	Move terraform/ to internal/terraform/	5 years ago
refresh.go	Move terraform/ to internal/terraform/	5 years ago
refresh_test.go	update to use typed sensitive marks	5 years ago
show.go	Move terraform/ to internal/terraform/	5 years ago
state_locker.go	Move command/ to internal/command/	5 years ago
test.go	Move command/ to internal/command/	5 years ago
test_test.go	Move command/ to internal/command/	5 years ago
validate.go	Move command/ to internal/command/	5 years ago
validate_test.go	Move command/ to internal/command/	5 years ago
view.go	Move command/ to internal/command/	5 years ago