You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Martin Atkins 0f936b9d80 plans/planfile: Read state snapshots as part of reading a plan ... Our model for plans/planfile has unfortunately grown inconsistent with changes to our modeling of plans.Plan. Originally we considered the plan "header" and the planned changes as an entirely separate artifact from the prior state, but we later realized that carrying the prior state around with the plan is important to ensuring we always have enough context to faithfully render a plan to the user, and so we added the prior state as a field of plans.Plan. More recently we've also added the "previous run state" to plans.Plan for similar reasons. Unfortunately as a result of that modeling drift our ReadPlan method was silently producing an incomplete plans.Plan object, causing use-cases like "terraform show" to produce slightly different results due to the plan object not round-tripping completely. As a short-term tactical fix, here we add state snapshot reading into the ReadPlan function. This is not an ideal solution because it means that in the case of applying a plan, where we really do need access to the state _file_, we'll end up reading the prior state file twice. However, the goal here is only to heal the modelling quirk with as little change as possible, because we're not currently at a point where we'd be willing to risk regressions from a larger refactoring.		5 years ago
..
internal/planproto	plans: Plan.Mode is now Plan.UIMode	5 years ago
objchange	use new dynamic decoding behavior	5 years ago
planfile	plans/planfile: Read state snapshots as part of reading a plan	5 years ago
action.go	Version tools per Go convention under tools.go	6 years ago
action_string.go	…
changes.go	plans: Track an optional extra "reason" for some planned actions	5 years ago
changes_src.go	plans: Track an optional extra "reason" for some planned actions	5 years ago
changes_state.go	…
changes_sync.go	s/FullDestroy/IsFullDdestroy/	5 years ago
doc.go	…
dynamic_value.go	Use UnmarkDeepWithPaths and MarkWithPaths	6 years ago
mode.go	core: Generalize the idea of a "plan mode", vs just destroy flag	5 years ago
mode_string.go	core: Generalize the idea of a "plan mode", vs just destroy flag	5 years ago
plan.go	plans: Track both the previous run and prior states in the plan	5 years ago
plan_test.go	don't render plan for module outputs	5 years ago
resourceinstancechangeactionreason_string.go	plans: Track an optional extra "reason" for some planned actions	5 years ago