You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

kmoe be2ad69eda plannable import: safer config generation and schema filters (#33232) ... * genconfig: fix nil nested block panic * genconfig: null NestingSingle blocks should be absent A NestingSingle block that is null in state should be completely absent from config. * configschema: make FilterOr variadic * configschema: apply filters to nested types * configschema: filter helper/schema id attribute The legacy SDK adds an Optional+Computed "id" attribute to the resource schema even if not defined in provider code. During validation, however, the presence of an extraneous "id" attribute in config will cause an error. Remove this attribute so we do not generate an "id" attribute where there is a risk that it is not in the real resource schema. * configschema: filter test * terraform: do not pre-validate generated config Config generated from a resource's import state may fail validation in the case of schema behaviours such as ExactlyOneOf and ConflictsWith. We don't want to fail the plan now, because that would give the user no way to proceed and fix the config to make it valid. We allow the plan to complete and output the generated config. * generate config alongside import process Rather than waiting until we call `plan()`, generate the configuration at the point of the import call, so we have the necessary data to return in case planning fails later. The `plan` and `state` predeclared variables in the plan() method were obfuscating the actual return of nil throughout, so those identifiers were removed for clarity. * move generateHCLStringAttributes closer to caller * store generated config in plan on error * test for config gen with error * add simple warning when generating config --------- Co-authored-by: James Bardin <j.bardin@gmail.com>		3 years ago
..
arguments	plannable import: write generated config to out flag (#33186)	3 years ago
cliconfig	[COMPLIANCE] Add Copyright and License Headers	3 years ago
clistate	[COMPLIANCE] Add Copyright and License Headers	3 years ago
e2etest	[COMPLIANCE] Add Copyright and License Headers	3 years ago
format	[COMPLIANCE] Add Copyright and License Headers	3 years ago
jsonchecks	checks: no longer experimental (#33184)	3 years ago
jsonconfig	[COMPLIANCE] Add Copyright and License Headers	3 years ago
jsonformat	plannable import: improve gen config human plan output (#33194)	3 years ago
jsonfunction	[COMPLIANCE] Add Copyright and License Headers	3 years ago
jsonplan	Plannable import: Add generated config to JSON and human-readable plan output (#33154)	3 years ago
jsonprovider	[COMPLIANCE] Add Copyright and License Headers	3 years ago
jsonstate	[COMPLIANCE] Add Copyright and License Headers	3 years ago
testdata	plannable import: safer config generation and schema filters (#33232)	3 years ago
views	plannable import: improve gen config human plan output (#33194)	3 years ago
webbrowser	[COMPLIANCE] Add Copyright and License Headers	3 years ago
workdir	[COMPLIANCE] Add Copyright and License Headers	3 years ago
apply.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
apply_destroy_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
apply_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
autocomplete.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
autocomplete_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
cli_ui.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
cli_ui_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
command.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
command_test.go	plannable import: write generated config to out flag (#33186)	3 years ago
console.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
console_interactive.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
console_interactive_solaris.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
console_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
flag_kv.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
flag_kv_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
fmt.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
fmt_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
get.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
get_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
graph.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
graph_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
helper.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
hook_module_install.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
import.go	Plannable import: Generate config for imported resources during the plan. (#33153)	3 years ago
import_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
init.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
init_test.go	add tests for init syntax error handling	3 years ago
login.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
login_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
logout.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
logout_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta.go	Revert "Plannable import: Make the streamed logs more consistent during a plan operation (#33155)"	3 years ago
meta_backend.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_backend_migrate.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_backend_migrate_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_backend_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_config.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_dependencies.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_new.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_providers.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
meta_vars.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
metadata_command.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
metadata_functions.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
metadata_functions_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
output.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
output_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
plan.go	plannable import: write generated config to out flag (#33186)	3 years ago
plan_test.go	plannable import: write generated config to out flag (#33186)	3 years ago
plugins.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
plugins_lock.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
plugins_lock_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
plugins_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
providers.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
providers_lock.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
providers_lock_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
providers_mirror.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
providers_mirror_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
providers_schema.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
providers_schema_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
providers_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
push.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
refresh.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
refresh_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
show.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
show_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_command.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_list.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_list_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_meta.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_mv.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_mv_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_pull.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_pull_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_push.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_push_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_replace_provider.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_replace_provider_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_rm.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_rm_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_show.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_show_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
state_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
taint.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
taint_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
test_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
ui_input.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
ui_input_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
unlock.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
unlock_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
untaint.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
untaint_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
validate.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
validate_test.go	check for duplicate import blocks (#33190)	3 years ago
version.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
version_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
workspace_command.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
workspace_command_test.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
workspace_delete.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
workspace_list.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
workspace_new.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
workspace_select.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago
workspace_show.go	[COMPLIANCE] Add Copyright and License Headers	3 years ago