You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Dennis Gursky 4e42d21837 Improve ModuleInstance String() performance (#28246) ... * Optimize (m ModuleInstance) String() Optimize (m ModuleInstance) String() to preallocate the buffer and use strings.Builder instead of bytes.Buffer This leads to a common case only doing a single allocation as opposed to a few allocations which the bytes.Buffer is doing. * adding a benchmark test Result: ``` $ go test -bench=String ./addrs -benchmem BenchmarkStringShort-12 18271692 56.52 ns/op 16 B/op 1 allocs/op BenchmarkStringLong-12 8057071 158.5 ns/op 96 B/op 1 allocs/op PASS $ git checkout main addrs/module_instance.go $ go test -bench=String ./addrs -benchmem BenchmarkStringShort-12 7690818 162.0 ns/op 80 B/op 2 allocs/op BenchmarkStringLong-12 2922117 414.1 ns/op 288 B/op 3 allocs/op ``` * Update module_instance_test.go switch spaces to tabs		5 years ago
..
count_attr.go	addrs: All Referenceable implementations support String()	8 years ago
doc.go	…
for_each_attr.go	Resource for_each	7 years ago
input_variable.go	Module Expansion: Part 2 (#24154)	6 years ago
instance_key.go	Add InstanceKey.Value method	6 years ago
local_value.go	addrs: flesh out functionality ready to replace terraform.ResourceAddress	8 years ago
module.go	core: Reduce string allocations for addrs Equal	5 years ago
module_call.go	Update addrs/module_call.go	6 years ago
module_instance.go	Improve ModuleInstance String() performance (#28246)	5 years ago
module_instance_test.go	Improve ModuleInstance String() performance (#28246)	5 years ago
module_test.go	core: Reduce string allocations for addrs Equal	5 years ago
output_value.go	core: Reduce string allocations for addrs Equal	5 years ago
output_value_test.go	core: Reduce string allocations for addrs Equal	5 years ago
parse_ref.go	parse module references as whole modules	6 years ago
parse_ref_test.go	parse module references as whole modules	6 years ago
parse_target.go	vendor: switch to HCL 2.0 in the HCL repository	7 years ago
parse_target_test.go	implement addrs.ConfigResource	6 years ago
path_attr.go	addrs: All Referenceable implementations support String()	8 years ago
provider.go	addrs: Fix LegacyString for builtin provider addrs	6 years ago
provider_config.go	addrs: detect builtin provider when parsing legacy provider string (#25154)	6 years ago
provider_config_test.go	remove LegacyProvider (#26433)	6 years ago
provider_test.go	addrs: Fix LegacyString for builtin provider addrs	6 years ago
referenceable.go	addrs: All Referenceable implementations support String()	8 years ago
resource.go	core: Reduce string allocations for addrs Equal	5 years ago
resource_phase.go	core: Produce correct references for destroy nodes	8 years ago
resource_test.go	core: Reduce string allocations for addrs Equal	5 years ago
resourcemode_string.go	stringer: Regenerate files with latest version	7 years ago
self.go	addrs: All Referenceable implementations support String()	8 years ago
target_test.go	unkeyed target ModulesInstance can be Modules	6 years ago
targetable.go	addrs: flesh out functionality ready to replace terraform.ResourceAddress	8 years ago
terraform_attr.go	addrs: All Referenceable implementations support String()	8 years ago