You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Martin Atkins 8f233cde4c cli: Diagnostics can include collections with sensitive elements ... We previously had a shallow IsMarked call in compactValueStr's caller but then a more-conservative deep ContainsMarked call inside compactValueStr with a different resulting message. As well as causing an inconsistency in messages, this was also a bit confusing because it made it seem like a non-sensitive collection containing a sensitive element value was wholly sensitive, making the debug information in the diagnostic messages not trustworthy for debugging certain varieties of problem. I originally considered just removing the redundant check in compactValueStr here, but ultimately I decided to keep it as a sort of defense in depth in case a future refactoring disconnects these two checks. This should also serve as a prompt to someone making later changes to compactValueStr to think about the implications of sensitive values in there, which otherwise wouldn't be mentioned at all. Disclosing information about a collection containing sensitive values is safe here because compactValueStr only discloses information about the value's type and element keys, and neither of those can be sensitive in isolation. (Constructing a map with sensitive keys reduces to a sensitive overall map.)		5 years ago
..
json	cli: Diagnostics can include collections with sensitive elements	5 years ago
apply.go	views: Fix missing source in diagnostic output	5 years ago
apply_test.go	…
hook_count.go	…
hook_count_test.go	…
hook_ui.go	…
hook_ui_test.go	…
operation.go	Fix typo in plan no changes output message	5 years ago
operation_test.go	…
output.go	views: Fix missing source in diagnostic output	5 years ago
output_test.go	…
plan.go	views: Fix missing source in diagnostic output	5 years ago
plan_test.go	cli: Migrate plan to command views	5 years ago
refresh.go	views: Fix missing source in diagnostic output	5 years ago
refresh_test.go	…
show.go	…
state_locker.go	views: Fix missing source in diagnostic output	5 years ago
test.go	…
test_test.go	…
validate.go	cli: Migrate validate command to views	5 years ago
validate_test.go	cli: Migrate validate command to views	5 years ago
view.go	views: Remove outdated comment	5 years ago