1462 Commits (fed6538dece2b0306d52f6c12facb5c4e5485725)

Author	SHA1	Message	Date
Rees Pozzi	fed6538dec	core: Correct typo in "Moved resource instances excluded by targeting" error message	3 years ago
James Bardin	76737a8966	Merge pull request #33151 from hashicorp/jbardin/import-refresh ... Import: only refresh an imported state once	3 years ago
James Bardin	be682f1d29	only refresh an import state once ... The imported resource was being stored in the wrong state, and only ended up in the refresh state because ReadResource was being called a second time in the normal refresh path. Make sure to only refresh the imported resource once. This is still done separately within importState so that we can handle the error slightly differently to let the user know if an imported instance does not exist.	3 years ago
Liam Cervante	77f10c4f68	Imports should come before Adds in change summaries (#33147)	3 years ago
Liam Cervante	81eb73731d	[Plannable Import] Implement streamed logs for plan (#33106) ... * [plannable import] embed the resource id within the changes * [Plannable Import] Implement streamed logs for -json plan * use latest structs * remove implementation plans from TODO	3 years ago
Liam Cervante	54c1c1162f	[Plannable Import] Implement human-readable plan rendering (#33113) ... * [plannable import] embed the resource id within the changes * add the plannable imports to the json and human plans * latest importing struct	3 years ago
Alisdair McDiarmid	b5658a46a2	Rebuild protobuf	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	4210d905c0	[plannable import] embed the resource id within the changes (#33134) ... * [plannable import] embed the resource id within the changes * make pointers and update docs	3 years ago
Liam Cervante	b5576159da	Migrate 'state show' command to new renderer (#33116) ... * Migrate 'state show' command to new renderer * handle error	3 years ago
kmoe	28643516b2	Plannable import 3: Make import plannable (#33085) ... During a plan, Terraform now checks for the presence of import blocks. For each resource in config, if an import block is present with a matching address, planning that node will now trigger an ImportResourceState and ReadResource. The resulting state is treated as the node's "refresh state", and planning proceeds as normal from there. The walkImport operation is now only used for the legacy "terraform import" CLI command. This is the only case under which the plan should produce graphNodeImportStates.	3 years ago
Zac Clifton	3bb6a5896b	Feat: Add strcontains function and documentation (#33069) ... * add strcontains function and documentation	3 years ago
Alisdair McDiarmid	0ffdd07980	Fix goimports discrepancies	3 years ago
kmoe	c6400fabb1	configs: add import block (#33081)	3 years ago
kmoe	531efd303b	add types for plannable import (#33080)	3 years ago
Lauren	50c3f53595	add resource_drift logtype	3 years ago
James Bardin	d47d475a03	Merge pull request #33079 from hashicorp/jbardin/destroy-plan-faster-providers ... skip inter-provider cycle check in destroy plan	3 years ago
James Bardin	583350a5c4	skip inter-provider cycle check in destroy plan ... Just like in the destroy apply, we can skip the inter-provider cycle check when creating the destroy plan, which can be expensive when there are a lot of resource instances with dependencies from another provider.	3 years ago
Liam Cervante	b54668f44c	make the unknown attribute renderer consider the force replacement metadata (#33065)	3 years ago
Liam Cervante	14123e277c	Include sensitive metadata from the schema when building the json state output (#33059) ... * include sensitive metadata from the schema when building the json state output * found another test case	3 years ago
Liam Cervante	519a18aedf	Propagate unknown and sensitive metadata to dynamic attributes (#33057) ... * propagate unknown and sensitive metadata to dynamic attributes * update goimports and add some comments	3 years ago
Liam Cervante	357012a2f3	Refactor of differ to make code reuse easier (#33054) ... * refactor of differ to make code reuse easier * fix imports	3 years ago
Liam Cervante	aae6990d38	Add native `plantimestamp` function to Terraform (#32980) ... * add plantimestamp function * documentation * add missing links * fix typo	3 years ago
Rémi Lapeyre	af571b2642	Improve environment variable support for the pg backend (#33045) ... * Improve environment variable support for the pg backend This patch does two things: - it adds environment variable support to the parameters that did not have it (and uses `PG_CONN_STR` instead of `PGDATABASE` which is actually more appropriate to match the behavior of other PostgreSQL utilities) - better documents how to give the connection parameters as environment variables for the ones that were already supported based on the recommendation of @bsouth00 I will prepare a backport of the documentation part of this once it is merged. Closes https://github.com/hashicorp/terraform/issues/33024 * Remove global variable in test of the PG backend	3 years ago
Glenn Sarti	7e2e834aff	Emit warnings for certain run events in cloud backend (#33020) ... The cloud backend, which communicates with TFC like APIs, can create runs which may have one more configuration parameters altered. These alterations are emitted as run-events on the run so that API clients can consume and display them to users. This commit adds a step in plan operation to query the run-events once a run is created and then emit specific run-event descriptions to the console as warnings for the user.	3 years ago
Sebastian Rivera	e6c3aab6c5	Merge pull request #33018 from hashicorp/tf-5529-sro-tfe-version-check	3 years ago
Liam Cervante	2c624acea1	Fix rendering unknown values in map and null string primitives (#33029) ... * fix rendering unknown values in map and null string primitives * Update map.go * fix code consistency checks	3 years ago
Sebastian Rivera	300a60f393	Fix typo in format version check	3 years ago
Sebastian Rivera	5634ae3e18	Unit tests to ensure renderer is appropriately called	3 years ago
Sebastian Rivera	b23cfaefe8	Refactor SRO check to prevent duplicate plan output	3 years ago
Liam Cervante	9c87006c34	checks: hide check diagnostics during plans that will not wait for approval (#32938) ... * checks: filter out check diagnostics during certain plans * wrap diagnostics produced by check blocks in a dedicated check block diagnostic * address comments	3 years ago
James Bardin	acbcbcb311	Merge pull request #32988 from hashicorp/jbardin/destroy-plan-null-type ... the destroy plan should use correct type	3 years ago
janaurka	1f603b1a7f	backend/pg: Accept connection string in PGDATABASE environment variable	3 years ago
James Bardin	c872cd6d96	the destroy plan should use correct type ... When we plan to destroy an instance, the change recorded should use the correct type for the resource rather than `DynamicPseudoType`. Most of the time this is hidden when the change is encoded in the plan, because any `null` is always encoded to the same value, and when decoded it will be converted to the schema type. However when apply requires creating a second plan for an instance's replacement that value is not going to be encoded, and remains a dynamic value which is sent to the provider. Most providers won't see that either, as the grpc request also encodes and decodes the value to conform with the correct schema. The builtin terraform provider does get the raw cty value though, and when that dynamic value is returned validation fails when the type does not match.	3 years ago
Liam Cervante	84dc498b90	checks: always reference the nested data source from the check graph node (#32946) ... * checks: always reference the nested data source from the check block graph node * goimports	3 years ago
James Bardin	81b74cdb22	don't compare plan marks for missing values ... If a resource has a change in marks from the prior state, we need to notify the user that an update is going to be necessary to at least store that new value in the state. If the provider however returns the prior state value in lieu of a new config value, we need to be sure to filter any new marks for comparison as well. The comparison of the prior marks and new marks must take into account whether those new marks could even be applied, because if the value is unchanged the new marks may be completely irrelevant.	3 years ago
James Bardin	a4e92f3fca	Merge pull request #32876 from hashicorp/jbardin/state-serialize-plan-error ... Remove planned data source objects from state on error	3 years ago
James Bardin	fdb00b9a46	Merge pull request #32900 from hashicorp/jbardin/target-drift-upgrade ... External changes report can fail with schema migrations and `-target`	3 years ago
Liam Cervante	c06db2aadd	checks: don't iterate through all the nodes when there is nothing to search for (#32927)	3 years ago
Liam Cervante	5f97f88025	ensure checks are reported before executed (#32925)	3 years ago
Liam Cervante	978263efe9	Checks: Introduce check blocks into the terraform node and transform graph (#32735) ... * Add support for scoped resources * refactor existing checks addrs and add check block addr * Add configuration for check blocks * introduce check blocks into the terraform node and transform graph * address comments * address comments * don't execute checks during destroy operations * don't even include check nodes for destroy operations	3 years ago
Liam Cervante	3827120c25	Checks: Add configuration for check blocks (#32734) ... * Add support for scoped resources * refactor existing checks addrs and add check block addr * Add configuration for check blocks * address comments	3 years ago
Liam Cervante	87c457781d	Checks: Refactor existing check addrs and add new check block addr (#32733) ... * Add support for scoped resources * refactor existing checks addrs and add check block addr * address comments	3 years ago
James Bardin	240e345b45	test for untargeted schema mismatch	3 years ago
James Bardin	b10c4c54d9	prevent errors with -target and provider upgrades ... In the case where a provider has been upgraded, and there are external changes to resources outside of terraform, and -target is being used, and resources which are not targeted require a schema migration; the untargeted resources will not have been migrated and cannot be decoded for the external changes report. Since there is no way to decode the resources which have been excluded via -target, we can only skip over them when inspecting driftedResources. Return warnings for now to indicate that these resources could not be decoded to help indicate that users will need to eventually apply these changes.	3 years ago
James Bardin	defd7f0cde	test that module outputs maintain sensitive marks	3 years ago
James Bardin	d33e627514	remove old comments	3 years ago
James Bardin	425c6bead2	store non-root sensitive outputs in state ... Module outputs are evaluated from state, so in order to have detailed information about sensitivity from non-root module outputs, we need to store the value along with all sensitive marks. This aligns with the usage of state being the in-memory store for other temporary values like locals and variables.	3 years ago
James Bardin	1ca631bda0	remove planned objects from state on error ... When planning encounters an error we were returning early without cleaning out any planed data sources which cannot be serialized. Move the cleanup to the common walkPlan method where the PriorState is assigned so that it cannot be missed.	3 years ago
Martin Atkins	9f827f57ae	go.mod: Revert cty minor version v1.13 upgrade ... We inadvertently incorporated the new minor release of cty into the 1.4 branch, and that's introduced some more refined handling of unknown values that is too much of a change to introduce in a patch release. Therefore this reverts back to the previous minor release for the v1.4 series, and then we'll separately get the main branch ready to work correctly with the new cty before Terraform v1.5. This reverts just the upgrade and the corresponding test changes from #32775, while retaining the HCL upgrade and the new test case it introduced for that bug it was trying to fix. That new test is still passing so it seems that the cty upgrade is not crucial to that fix.	3 years ago