4 Commits (fa2a76fa239dcd7ebbffecb79ce0ed96bced201b)

Author	SHA1	Message	Date
James Bardin	ad8642e2c2	have remote.ExitError format errors and status ... Since all use cases of ExitStatus are just putting it into fmt.Errorf, usually with the command string, have ExitStatus do that for the caller.	8 years ago
James Bardin	3fbdee0777	clean up remote.Cmd api ... Combine the ExitStatus and Err values from remote.Cmd into an error returned by Wait, better matching the behavior of the os/exec package. Non-zero exit codes are returned from Wait as a remote.ExitError. Communicator related errors are returned directly. Clean up all the error handling in the provisioners using a communicator. Also remove the extra copyOutput synchronization that was copied from package to package.	8 years ago
James Bardin	2d7dc605a0	get communicator errors from a remote.Cmd ... The remote.Cmd struct could not convey any transport related error to the caller, meaning that interrupted commands would show that they succeeded. Change Cmd.SetExited to accept an exit status, as well as an error to store for the caller. Make the status and error fields internal, require serialized access through the getter methods. Users of remote.Cmd should not check both Cmd.Err() and Cmd.ExitStatus() until after Wait returns. Require communicators to call Cmd.Init before executing the command. This will indicate incorrect usage of the remote.Cmd by causing a panic in SetExitStatus.	8 years ago
Sander van Harmelen	c9e9e374bb	Adding some abstractions for the communicators ... This is needed as preperation for adding WinRM support. There is still one error in the tests which needs another look, but other than that it seems like were now ready to start working on the WinRM part…	11 years ago