51 Commits (f8fb61de12dea9ac94de3060a0d3e97ce9b5480b)

Author	SHA1	Message	Date
Radek Simko	0fe906fa8c	make copyrightfix	3 months ago
Daniel Schmidt	6f828ea344	add clarifying comment	3 months ago
Daniel Schmidt	ad3837f37a	add testing helper that checks diagnostic extra infos	3 months ago
Daniel Schmidt	9a1e117ea9	pull range finding for expressions into separate method	4 months ago
Daniel Schmidt	379fa79c3e	ElaborateFromConfigBody handles deeply nested paths more precisely	4 months ago
Daniel Schmidt	5723a7a26b	refactor into switch statement	4 months ago
Daniel Schmidt	75445e1ef8	use a string as deprecation origin to help with indirect references ... We want to be able to give better information if e.g. the entire module is stored in a local and the deprecated value is only later used. Where the diag is emitted we might only see the local and not the true origin of the deprecation A string identifying the source of the deprecation should help	4 months ago
Daniel Schmidt	844bcd8e2c	contextualFromConfigBody should also apply for overridden diagnostics	4 months ago
Daniel Schmidt	ea7f1e3043	add extra origin information for deprecation diagnostics	4 months ago
Daniel Schmidt	2714cfde69	standardize on marks.Has	8 months ago
Samsondeen	719aefdb89	tf query: ready list blocks for beta (#37619)	9 months ago
Daniel Banck	1ac8497994	Add support for Terraform Search in the cloud backend (TF-25935) (#37479)	9 months ago
Sarah French	1c09e58b3d	Fix diagnostic comparison issues in `s3` backend tests (#37509) ... * Fix S3 backend test affected by making the Workspaces method return errors via diagnostics * Address diagnostics comparison issues in test by ensuring expected diagnostics are defined in the context of the config they're triggered by * Fix failing test case `TestBackendConfig_EC2MetadataEndpoint/envvar_invalid_mode` by making `diagnosticBase` struct comparable * Add compile-time checks that diagnostic types fulfil interfaces * Stop diagnosticBase implementing ComparableDiagnostic, re-add S3-specific comparer code to s3 package * Update tests to use the S3-specific comparer again * Fix test case missed in refactoring	9 months ago
Daniel Schmidt	6de74f5996	improve error reporting if asserting no diags	10 months ago
Daniel Banck	7414a3f76f	Fix import with optional identity attributes (#36887) ... * tfdiags: Support null values when printing objects * Use type with optional fields when decoding identity config * Use provider returned identity when importing * Add test case for import with optional identity attrs	1 year ago
James Bardin	87cdcc350e	Merge pull request #36825 from hashicorp/jbardin/diag-dedupe ... fix issues with diagnostic deduplication	1 year ago
James Bardin	291d26ce19	we can't compare location if either are nil	1 year ago
James Bardin	c6c21a89a1	hcl diagnostics must check Subject source ... The source check was skipped if either value was nil, but we can't be sure they are equal if there is no value. This may prove to be problematic is tests, as diagnostic equality for deduplication isn't strict equality, but rather relies on being able to prove the context is also equal.	1 year ago
James Bardin	aeb1c0db09	we can't dedupe extra values in diags ... Extra values can be any type, and are only asserted by interface by the party expecting that interface so we can't attempt to compare them for equality. The only diagnostic type with Extra values which implements Equals is and hcl diagnostic.	1 year ago
James Bardin	da42f6b29e	don't re-add non-comparable diagnostics ... Non-comparable diagnostics were being adding multiple times, which might also panic in the equality comparison	1 year ago
Daniel Banck	6917e69d12	Config-driven importing through identity (TF-23179) (#36703) ... * configschema: Add identity attribute to import block * Mark import target ID as legacy * Add test with import identity * Use ID or identity when importing via configuration * Add plan import tests * Review Feedback * Make sure to copy identity for ResourceInstanceObjects * Add helper for converting cty.Objects to string * Replace getProvider calls * Improve unknown object check	1 year ago
Sarah French	052646c3d2	Migrate more testing helpers into tfdiags package (#36474) ... * Add new `AssertNoDiagnostics` and `AssertDiagnosticCount` test helpers in tfdiags package * Add new `AssertNoErrors` and `LogDiagnostics` test helpers in tfdiags package * Refactor existing tests to use new helpers * Refactor more recent tests * Revert change - wrong function replaced * Refactor to account for function no longer returning a boolean * Fix comment	1 year ago
Radek Simko	c3dc197465	fix: Avoid duplicated warnings (#36579) ... * fix: Deduplicate attribute diagnostics * tfdiags: Allow HCL & rpcFriendly diags to be compared * add changelog entry * update comment per PR review * address PR feedback (more precise comparisons) * add some missing docs * avoid comparing address * compare subject range in rpc diags * Remove Equals method from diagnosticBase * correct positions in test * update comparison logic for TestBackendConfig_Proxy	1 year ago
Samsondeen	1bd312f155	Produce detailed diagnostic objects when test run assertions fail (#36522)	1 year ago
Sarah French	85b482e05a	Add testing helpers that allow comparing diagnostics, refactor existing tests to use them. (#36456) ... * Add testing helpers for comparing diagnostics with different levels of stringency * Refactor some existing tests to use the new helpers * Replace use of diag comparison test helpers in terraform package * Add header * Add return statement back in ephemeral test * Update internal/terraform/context_plan2_test.go	1 year ago
James Bardin	3b3e4bf003	update the rest of the go:generate calls	1 year ago
Sarah French	dcce20fdfb	Improve testing of diagnostic comparer (#36455) ... * Update simple comparer tests to show that sources (Subject or Context) don't impact matching diags * Add comparer that uses sources (Subject or Context) when comparing diags * Add test cases that show concrete types do affect comparison * Fix test case names * Remove `DiagnosticComparerWithSource`	1 year ago
James Bardin	17f4dcfd8d	Merge pull request #36465 from hashicorp/jbardin/sensitive-order ... Serialize `AttrSensitivePaths` in a consistent order	1 year ago
James Bardin	bd0a632f5b	create lang/format package ... Create a single place to generate some common formats, mostly the format of a cty.Path. These were used in the tfdiags package, but need to be split out to prevent import cycles if we want to use them in any core package.	1 year ago
James Bardin	c721dbd511	use slightly more efficient strings.Builder	1 year ago
Samsondeen	4161e88391	Continue test execution after an expected failure (#36447)	1 year ago
Bruno Schaatsbergen	61acb0cb3a	tfdiags: add Warnings method (#36392) ... Adds a new method to the tfdiags API: Warnings() returns a new Diagnostics list containing only diagnostics with a severity of Warning.	1 year ago
Sarah French	b16a50973f	Add reusable Diagnostic comparer to `tfdiags` package (#36385) ... * Add `DiagnosticComparer` to standardize how diagnostics are compared for equality. This uses code originally in the s3 backend. Co-authored-by: Graham Davison <gdavison@hashicorp.com> * Refactor `test` related code to use new comparer * Refactor `s3` related code to use new comparer * Replace use of reflect and go-spew with new diagnostics comparison approach * Fix whitespace * Make `tfdiags.DiagnosticComparer` a var * Fix DiagnosticComparer test --------- Co-authored-by: Graham Davison <gdavison@hashicorp.com>	1 year ago
Daniel Banck	d074d148e8	Hide ephemeral values in diagnostics output (#36314) ... * Hide ephemeral values in diagnostics output This is more in line with the rest of the implementation * Add test for CompactValueStr	1 year ago
Liam Cervante	a4e1e60a01	logging: add trace statements when changes are ignored (#36259) ... * logging: add trace statements when changes are ignored * copywrite headers	1 year ago
Martin Atkins	6f84623cb6	terraform: Initial partial support for ephemeral values ... This is a checkpoint commit on the path to supporting ephemeral values as a cross-cutting concern in the Terraform language. An ephemeral value is one that lives only in RAM during a single phase and so cannot persist from the plan phase to the apply phase, or between consecutive plan/apply rounds. Terraform tracks whether each value is ephemeral using the cty "marks" concept, thus achieving the same dynamic analysis as we already employ for the concept of "sensitive values" that prevents displaying a value in the user interface. This commit is just a starting point which gets some of the basics into place: - input variables and output values can both be statically declared as being ephemeral. Only ephemeral inputs/outputs can have ephemeral values assigned to them, and the recipient of the value sees it as ephemeral even if the assigned value was not already ephemeral. This creates a dynamic analysis cutoff point at module boundaries so that it's possible to determine in isolation whether a single module is using ephemeral values correctly, without having to test it in every possible calling context. - Managed and data resources cannot have ephemeral values assigned into their configurations because Terraform and providers both expect the resource attributes to persist between phases. - Ephemeral values _can_ be used in provider and provisioner configurations, because both of those effectively meet the definition of the new "ephemeral" concept despite it not previously having a name. - Ephemeral markings propagate through all of the built-in language features for dynamic analysis purposes, largely relying on cty's efforts to do that in similar vein as for sensitive marks. In particular, it's possible to define a local value whose expression produces an ephemeral result, and passing ephemeral values to functions should propagate the ephemeral mark to the results when appropriate. (I've not yet thoroughly reviewed all of the built-in functions for correct marks handling though, so there may be some gaps to address in later commits.) The next step for this work will be to change the modules runtime to have support for a workflow involving ephemeral _root_ input variables, where their values must be re-supplied during the apply phase. That will then achieve (in experimental capacity) the first goal of ephemeral values: to be able to provide non-persistent settings such as time-limited API tokens to use in provider configuration blocks.	2 years ago
Brandon Croft	3a5221269b	Revert "Add Warning for Deprecated Modules in `Init` (Second Revision)"	2 years ago
Mark DeCrane	1e7c29243e	Added Extra field for TFC diagnostic processing	2 years ago
Martin Atkins	e6ad0c282d	tfdiags: Support errors.Join and stdlib wrapped errors ... HashiCorp needed support for wrapping multiple errors into a single error and for wrapping one error inside another long before that was in the standard library, and so built its own libraries for those needs. However, the standard library now has its own answers for both and so the HashiCorp libraries are redundant. We've already eliminated all use of both elsewhere in Terraform (except for some legacy packages that predate tfdiags anyway), so we no longer need to support them in package tfdiags.	2 years ago
kmoe	a718f70f85	Add removed block (#34251) ... * terraform: remove redundant code NodeDestroyResourceInstance is never instantiated with a DeposedKey of anything other than states.NotDeposed, so the deleted code is never run. Deposed objects get a NodeDestroyDeposedResourceInstanceObject instead. * tfdiags: add helper func * configs: introduce removed block type * terraform: add forget action * renderer: render forget actions * terraform: deposed objects can be forgotten Deposed objects encountered during planning spawn NodePlanDeposedResourceInstanceObject, which previously generated a destroy change. Now it will generate a forget change if the deposed object is a forget target, and a destroy change otherwise. The apply graph gains a new node type, NodeForgetDeposedResourceInstanceObject, whose execution simply removes the object from the state. * configs: add RemoveTarget address type * terraform: modules can be forgotten * terraform: error if removed obj still in config * tests: better error on restore state fail * Update CHANGELOG.md	3 years ago
CJ Horton	98b81d3c50	add missing copyright headers	3 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
Liam Cervante	f74a8d16cf	[testing framework] implement expect_failures functionality (#33443)	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	9c87006c34	checks: hide check diagnostics during plans that will not wait for approval (#32938) ... * checks: filter out check diagnostics during certain plans * wrap diagnostics produced by check blocks in a dedicated check block diagnostic * address comments	3 years ago
Liam Cervante	978263efe9	Checks: Introduce check blocks into the terraform node and transform graph (#32735) ... * Add support for scoped resources * refactor existing checks addrs and add check block addr * Add configuration for check blocks * introduce check blocks into the terraform node and transform graph * address comments * address comments * don't execute checks during destroy operations * don't even include check nodes for destroy operations	3 years ago
Martin Atkins	783a07d9e8	build: Use Go 1.19 ... Go 1.19's "fmt" has some awareness of the new doc comment formatting conventions and adjusts the presentation of the source comments to make it clearer how godoc would interpret them. Therefore this commit includes various updates made by "go fmt" to acheve that. In line with our usual convention that we make stylistic/grammar/spelling tweaks typically only when we're "in the area" changing something else anyway, I also took this opportunity to review most of the comments that this updated to see if there were any other opportunities to improve them.	4 years ago
Martin Atkins	90ea7b0bc5	tfdiags: Treat unknown-related or sensitive-related messages differently ... By observing the sorts of questions people ask in the community, and the ways they ask them, we've inferred that various different people have been confused by Terraform reporting that a value won't be known until apply or that a value is sensitive as part of an error message when that message doesn't actually relate to the known-ness and sensitivity of any value. Quite reasonably, someone who sees Terraform discussing an unfamiliar concept like unknown values can assume that it must be somehow relevant to the problem being discussed, and so in that sense Terraform's current error messages are giving "too much information": information that isn't actually helpful in understanding the problem being described, and in the worst case is a distraction from understanding the problem being described. With that in mind then, here we introduce an explicit annotation on diagnostic objects that are directly talking about unknown values or sensitive values, and then the diagnostic renderer will react to that to avoid using the terminology "known only after apply" or "sensitive" in the generated diagnostic annotations unless we're rendering a message that is explicitly related to one of those topics. This ends up being a bit of a cross-cutting concern because the code that generates these diagnostics and the code that renders them are in separate packages and are not directly aware of each other. With that in mind, the logic for actually deciding for a particular diagnostic whether it's flagged in one of these special ways lives inside the tfdiags package as an intermediation point, which both the diagnostic generator (in the core package) and the diagnostic renderer can both depend on.	4 years ago
Martin Atkins	8405f46bc5	tfdiags: Expose the "extra information" concept from HCL ... HCL's diagnostic model now includes the idea of "extra information" which works by attaching an initially-opaque interface value to each diagnostic and then asking callers to type-assert against that value to sniff for particular interfaces in order to discover additional machine-readable context about a certain diagnostic message. This commit echoes that idea into our tfdiags API, for now only for diagnostics that are backed by an hcl.Diagnostic. All other implementations of the diagnostic interface just always return nil, which means they never carry any "extra information". As is typical for our wrapping abstraction, we have here also a modified copy of HCL's helper function for conveniently probing a diagnostic for information of a particular type, designed to work with our diagnostic interface instead of HCL's concrete diagnostic type.	4 years ago
Alisdair McDiarmid	a103c65140	core: Eval pre/postconditions in refresh-only mode ... Evaluate precondition and postcondition blocks in refresh-only mode, but report any failures as warnings instead of errors. This ensures that any deviation from the contract defined by condition blocks is reported as early as possible, without preventing the completion of a state refresh operation. Prior to this commit, Terraform evaluated output preconditions and data source pre/postconditions as normal in refresh-only mode, while managed resource pre/postconditions were not evaluated at all. This omission could lead to confusing partial condition errors, or failure to detect undesired changes which would otherwise cause resources to become invalid. Reporting the failures as errors also meant that changes retrieved during refresh could cause the refresh operation to fail. This is also undesirable, as the primary purpose of the operation is to update local state. Precondition/postcondition checks are still valuable here, but should be informative rather than blocking.	4 years ago