3649 Commits (f72944530d01bda68eee6b3fdd0d98e02e5aa8aa)

Author	SHA1	Message	Date
Daniel Schmidt	5fdbafd129	ensure destroy events can not be used	9 months ago
Daniel Schmidt	54160f82d6	add test case	9 months ago
Daniel Schmidt	ceb8bcbbe0	refactor: use simplified expansion	9 months ago
Daniel Schmidt	506e2752a6	remove todo	9 months ago
Daniel Schmidt	0f28ee1a82	handle actions without config block	9 months ago
Daniel Schmidt	bc4eb08da4	refactor: parse references outside of config	9 months ago
Daniel Schmidt	c3262b8e5d	remove config parsing related test case	9 months ago
Daniel Schmidt	b2d7056207	add config block to tests	9 months ago
Daniel Schmidt	66001080e6	actions: implement expansion and planning actions ... This implementation is very barebones, but builds the skelleton for all upcoming features in actions. It includes the graph implementation for planning actions including the expansion of actions and dealing with multiple action triggers. We plan all actions as part of their triggering resource for now. All action_triggers depend on the triggering resources plan to determine if an action should run or not, therefore we can plan the actions as part of the triggering resource. This implementation ignores conditions, deferrals, provider arguments and it does not add the actions to the planfile; mostly to enable more people to work on these issues in parallel.	9 months ago
Kristin Laemmert	9256074c43	Actions in plan/changes (#37320) ... * Add actions to the plans and change * jsonplan - ignoring LinkedResources for now, those are not in the MVP * pausing here: we'll work on the plan rendering later	9 months ago
Sarah French	7199fbd2bb	Update use of `testChdir` to standard library's `t.Chdir`, remove `testChdir` function from codebase (#37334) ... * Replace use of `testChdir` with `t.Chdir` * Update tests to use temporary directories with copied content, instead of using directories in the repo directly. * Remove stacks copy of testChdir function This has been replaced with t.Chdir from the standard library * Replace remaining simple usage of testChdir * Update guidance for using `tempWorkingDir` * Replace use of testChdir in a function reused in a single test * Update comments to no longer recommend using testChdir * Remove testChdir function!	9 months ago
Sarah French	e79b5a1628	Replace custom `testCwd` function with standard `testing` library (#37335) ... * Replace custom testCwd function with standard `testing` library * Update comments that reference testCwd function	9 months ago
Sarah French	15840b3eae	Replace use of `defer` with `t.Cleanup` in majority of `command` package tests, update `testChdir` to work with t.Cleanup (#37326) ... * Replace use of `defer` with `t.Cleanup` in tests * Fix test failures by making cleanup function permissive of the temp dir being already deleted.	9 months ago
Samsondeen	69fb908eaa	Always generate provider address for resources (#37318)	9 months ago
Sarah French	7a27366b39	PSS: Add ability to create hashes of the `state_store` block and of its nested `provider` block (#37278) ... * Add the ability to make a hash of state store config * Add test demonstrating that the provider block doesn't impact the hash of a state_store block * Make sure test asserts what would happen if the schema DID include the provider block * Update the Hash method to return diagnostics, ignore nested provider blocks, and validate incoming schema and config * Update tests to use more representative config, fix code under test as a result * Update Hash method to return hashes for both the state_store and provider blocks * Add test cases to cover how required fields are tolerated when making the hash This is because ENVs may supply those values. * Fix inaccurate comments * Add test to show that hashes are consistent and exclude the provider block * Update backend state file to contain hash of provider block's config * Fix test to expect a hash for the provider config block. * Fix bug in DeepCopy method, update test to have better error messages when diffs are detected * Update test to explicitly check hash values * Try make test intention clearer * Improve user feedback when state store schema contains the protected word "provider" * Update tests * Update test to test the Hash method in a more true-to-life way Copy of 04a1201878cd1f6f117c43c43c1ee9d0fc17cec1 by Radek Simko * Update test to use new approach * Fix `TestInit_stateStoreBlockIsExperimental` test failure	9 months ago
Samsondeen	92609fded1	Implicitly set include_resource when generating configuration (#37319)	9 months ago
Sarah French	145e152a57	Clarify usage of BackendOpts, rename field in struct to enable usage with PSS in future (#37085) ... * Update comments to distinguish between operations and state-storage backends more clearly * Rename `BackendOpts` field `Config` to more specific `BackendConfig`	10 months ago
Daniel Schmidt	688a1f9955	add todo	10 months ago
Daniel Schmidt	24773cf86e	improve allocation	10 months ago
Daniel Schmidt	a2ce38ce12	use gomock generated mocks for the action invoke stream API	10 months ago
Daniel Schmidt	d0e5c3cc7b	address review feedback	10 months ago
Daniel Schmidt	ac132d1b15	add provider implementation for actions	10 months ago
Daniel Schmidt	e6b848d5ab	add actions protobuf definitions	10 months ago
Kristin Laemmert	5adceda98f	feat: update Actions parsing with current syntax (#37313) ... * feat: update Actions parsing with current syntax Updating actions to match the current RFC: - config is in a block - linked_resource(s) exist and need parsing I added a very basic test for the decoding, and updated existing tests with the correct syntax. * very important copyrighted test file	10 months ago
Sarah French	39f7920387	PSS: Add packages for presenting a provider as an instance of backend.Backend (#37291) ... * Add code to 'wrap' a provider implementation so that it can behave like a backend.Backend * Add code for creating a state manager that will interact with a provider via grpc to interact with state * Remove prototyping code * Update old implementation of PrepareConfig on Pluggable to match new RPC names * Implement Configure method on Pluggable * Implement Workspaces and DeleteWorkspace methods on Pluggable * Prevent construction of a pluggable with missing data, add godoc comment to NewPluggable * Add godoc comment to ConfigSchema * Refactor how we create a state manager for interacting with PSS Now we reuse the remote.State struct and all the pre-existing logic there. We still wrap the provider interface to enable use of gRPC methods, but that's now done using the remote.Client interface. * Rename file * Move file into the remote package * Rename file and package to `pluggable` * Add test for the only method implemented fully on `grpcClient` : Delete * Add tests for `NewPluggable` * Add tests for (Pluggable).ConfigSchema method, make minor fixes * Change mocks: hardcoded response or logic should return before default logic in method. * Add tests for (Pluggable).PrepareConfig method * Add tests for (Pluggable).Configure method * Add tests for (Pluggable).Workspaces method * Add tests for (Pluggable).DeleteWorkspace method * Fix rebase * Run `make syncdeps` * Add headers * Add missing comments * No need to implement ClientForcePusher * Apply feedback from review, make small tweaks to test failure messages	10 months ago
Radek Simko	5437cd7c8a	Prepare main branch for 1.14 development (cleanup) (#37312) ... * Prepare main branch for 1.14 development (cleanup) * fix version-dependent tests * update PR template	10 months ago
Samsondeen	0f7a690d25	Skip query e2e test when we cannot build at runtime (#37307)	10 months ago
Radek Simko	71a300c8f7	go: bump version to 1.24.5 (#37304)	10 months ago
Liam Cervante	9992eb2a04	Fix broken test due to merge conflict (#37305)	10 months ago
Liam Cervante	2a1b4c3ed4	Update go-cty and HCL for 1.13 release (#37298)	10 months ago
Liam Cervante	e9c2c26427	relevant attributes: strip out invalid relevant attributes from the plan (#37290) ... * relevant attributes: strip out invalid relevant attributes from the plan * validate and fix refs rather than remove invalid * add changelog * copyright headers	10 months ago
Samsondeen	870bf99593	List implementation for simple provider and e2e tests (#37297)	10 months ago
Sarah French	677e5ea276	Add test coverage for Meta's determineInitReason method, fix error in diagnostic (#37303) ... * Add test coverage for Meta's determineInitReason method, fix error in diagnostic when migrating away from HCP Terraform * Add godoc comment to determineInitReason method	10 months ago
Sarah French	d02a1ed1b7	PSS: Make the state storage provider's config stateful (backend state, planfiles) (#37286)	10 months ago
Daniel Schmidt	8649eae35d	rename ActionInvocation for clarity	10 months ago
Daniel Schmidt	8c657163b2	add hooks for action invocation lifecycle	10 months ago
Daniel Schmidt	016daf647e	add addrs for action invocation	10 months ago
Radek Simko	3e8a08609d	pluginshared: Cleanup request path in tests (#37299)	10 months ago
Daniel Banck	6740c5e3d1	Only add import target nodes when they match (#37296) ... The config transformer has a resource matcher to control which nodes are added to the graph. The PR extends the check to the import targets, so we don't add resource nodes during a query run.	10 months ago
Sarah French	0f8e77a50f	PSS: Add GetStates and DeleteState RPCs to plugin protocol v6 (#37288) ... * Add GetStates RPC method to Plugin Protocol v6 * Add DeleteState RPC method to Plugin Protocol v6 * Add methods to provider-simple * Fix error messages * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Change how GetStates RPC returns the list of state names * Change GetStates implementation to use new data type * `make protobuf` to accommodate new code comments --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	10 months ago
Samsondeen	a1332299a5	Test run Parallelism of 1 should not result in deadlock (#37292)	10 months ago
Samsondeen	8d8b2bb694	Generate config for list results (#37173)	10 months ago
Samsondeen	79187d579d	Validate list block meta-arguments (#37281)	10 months ago
Daniel Banck	2b9d25c7fd	Add `terraform query` subcommand (TF-25494) (#37174) ... * WIP * Reuse plan command for query CLI * Basic CLI output * Only fail a list request on error * poc: store query results in separate field * WIP: odd mixture between JSONs * Fix list references * Separate JSON rendering The structured JSON now only logs a status on which list query is currently running. The new jsonlist package can marshal the query fields of a plan. * Remove matcher * Store results in an extra struct * Structured list result logging * Move list result output into hooks * Add help text and additional flag * Disable query runs with the cloud backend for now * Review feedback	10 months ago
Mark DeCrane	577f8f02ae	Merge pull request #37283 from hashicorp/TF-26979/central-binary-download-tf-stacks-cli ... Move `stacksplugin` cache to `.terraform.d`	10 months ago
Mark DeCrane	1529739017	remove the cache override arg from the args passed to the plugin	10 months ago
Mark DeCrane	60dbc8b12f	Move stacksplugin cache to .terraform.d, allow for overriding of cache dir location	10 months ago
Sarah French	2349481b23	Update data stored in plan files to enable using PSS with saved plans (#37246) ... * Implement `ForPlan` method on `StateStoreConfigState`, add `Planner` interface * Rename `ForPlan` method to `Plan` * Allow plan files to contain information about state stores * Add code needed for representing a state store in the Plan struct, which is used when handling plan files * Add ability to read/write either a backend or state store's data in a plan file. Add some test coverage. * Update plan's `ProviderAddrs` method to include the provider used for PSS, if present * Split interfaces * Apply feedback from code review * Refactor `SetVersion` to use appropriate constructor * Split `ProviderAddrs` method test into two * Fix method call after rename * Fix test * Remove change to `(p *Plan) ProviderAddrs()` We may re-add this when we implement PSS for use during apply commands with plan files * Remove changes to test, now that the plan doesn't report the provider used for PSS anymore.	10 months ago
Daniel Banck	ab04e5cfec	Include list resource schemas in provider json schemas (TF-25497) (#37163) ... * Include list schemas in provider json schemas * Only include list schemas in experimental builds	10 months ago
Sarah French	38e2ed42c4	Make the `workspace` command explicitly protect the default workspace, instead of relying on backend implementations (#37256) ... * Add test showing that users cannot delete the default workspace Note: in the test this validation is being returned from the local backend's `DeleteWorkspace` method, not the command itself. * Make the `workspace delete` command return early if the user is trying to delete the default workspace. Update test. * Clean up redundant parts of test	10 months ago
Sarah French	d3b02a8469	Refactor code to use backend config state's `SetConfig` method, protect against nil receiver (#37254) ... * Add protection against nil receivers to SetConfig * Refactor code to use SetConfig method instead of setting ConfigRaw directly	10 months ago
James Bardin	7b3d9bf1ba	Merge pull request #37280 from hashicorp/jbardin/assert-set-compat ... skip set elem comparison when already matched	10 months ago
James Bardin	64c983275e	skip set elem comparison when already matched ... If both elements of the set have already been matched, there is no need to compare them again.	10 months ago
Sarah French	a91d3aafa8	Fix bug in DeepCopy of backend state data that causes loss of StateStore data (#37276)	10 months ago
Sarah French	3617b909c1	Make `workspace delete` command reject empty string arguments (#37275) ... * Disallow "" as the argument to workspaces delete command * Add change file	10 months ago
Sarah French	9212a2efdd	Make Terraform reject empty strings as invalid workspace names (#37267) ... * Add tests defining what are valid workspace names * Update workspace name validation to mark an empty string as not valid * Add change file * Add command-level test showing the "" workspace cannot be created or selected * Update invalid name error text to include empty string as invalid.	10 months ago
Matej Risek	a9b67a6cdc	stacks: Don't require built-in providers to be listed under required providers. (#37234)	10 months ago
Samsondeen	3d3439e00e	Testing list blocks with the gRPC Provider (#37236)	10 months ago
Sarah French	4d2d773634	Add and refactor test in the `planfile` package (#37245) ... * Refactor existing `TestTFPlanRoundTrip` test * Add new test for validation errors when writing a new plan file with `writeTfplan`	10 months ago
Sarah French	f31477f9ab	Add missing `return`s (#37240)	10 months ago
Sarah French	481bef3759	backend/azure: Remove legacy helper/schema dependency [rebased] (#37225) ... * backend/azure: Remove legacy helper/schema dependency This now uses the backendbase package's "SDK-like" helpers instead, which provide a much smaller subset of the former legacy SDK functionality but enough for what this backend needs. * remove unused replace directive * Fix go.mod file after rebase * Fix schema errors after self-review of code * Change `metadata_host` to be an optional field in the schema, to match the current behavior of code --------- Co-authored-by: Martin Atkins <mart@degeneration.co.uk> Co-authored-by: James Bardin <j.bardin@gmail.com>	10 months ago
Daniel Banck	540512e27b	Add config to List response (#37237)	10 months ago
Samsondeen	e178088a5b	unwrap nested config (#37235)	10 months ago
Daniel Banck	bfe31123e0	Add `limit` attribute to list blocks (TF-26798) (#37231) ... * Add `limit` attribute to list blocks * Add limit and include_resource args to list RPC * Test list arguments from config * Collect list block related references	10 months ago
Samsondeen	f57642d1a6	tf test: parallelize teardown operations (#37220)	10 months ago
Sarah French	2559f0a3db	Update backend state file so it can describe PSS state (#37179) ... * Split code for backend state file vs backend state * Rename BackendState to BackendConfigState * Spelling error * Add `StateStorageConfigState` struct as new implementation of new `ConfigState[T any]` interface. * Split tests for backend state file vs backend config state structs * Rename StateStorageConfigState to StateStoreConfigState * Clarify test name, add comments * Add tests for StateStoreConfigState methods * Add test showing state_store in JSON is parsed correctly * Add detection of malformed backend state files that contain both backend and state_store fields * Add validation that stops a backend state file being written if it will contain state for both backend and state_store blocks * Rename `state_storage` to `state_store` * Rename `state_storage` to `state_store` in filenames * Move`ConfigState` to its own file * Fix test name, remove whitespace * Update `StateStoreConfigState` comment using review suggestion * Update error message to no longer allude to the environment TF is being run in * Update the state_store state to use `version.Version` and an adapted version of `tfaddr.Provider` for marshalling version and source data * Update test helper so it doesn't accidentally supply validation in tests * Add protection against saving an empty backend state file * Remove direct testing of (s *Source) MarshalText() and UnmarshalText() methods * Add Validate method to StateStoreConfigState, use in backend state encoding logic * Refactor to use new features in registry dependency	11 months ago
Radek Simko	af07bd388e	deps: Bump terraform-registry-address to v0.3.0 (#37230) ... * deps: Bump terraform-registry-address to v0.3.0 * make syncdeps	11 months ago
Samsondeen	cacd7861e5	add nested config block to list block (#37229)	11 months ago
Samsondeen	685ff9f192	Schema representation of list block config and results (#37209)	11 months ago
Sarah French	b3d7dae793	Add config parsing and validation for PSS (#37178) ... * Enable parsing of blocks in individual files Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Enable handling of state stores when parsing a module from its constituent files. This includes: validations of duplicates and clashes, supporting override files. Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Add tests for validation that detects conflicts between state_store blocks and others * Add tests for state_store override behavior * Add tests for validation that detects when conflicting state-related blocks are used, either in the same file or across separate files * Update error message summaries to explicitly say blocks conflict * Add small changes to assertions in state_store override tests * Update state_store block parsing to expect scoped provider block * Update tests following syntax change * Make config parsing experimental * Remove testModuleFromDirWithExperiment, as testModuleFromDirWithExperiments exists! * Update code comment --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> Co-authored-by: Radek Simko <radek.simko@gmail.com>	11 months ago
Liam Cervante	b4a3e56a19	terraform test: deprecate ambigious variable references in test files (#37218) ... * terraform test: deprecate ambigious variable references in test files * fix panic caused by merge	11 months ago
Liam Cervante	777a916435	terraform test: move providers into the graph (#37216) ... * terraform test: move providers into the graph * consistency checks * remove flaky cycle test * address comments * Update internal/moduletest/graph/node_test_run.go Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> * go fmt --------- Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com>	11 months ago
Liam Cervante	53afa2cd2f	terraform test: move variable evaluation into the terraform test graph (#37205) ... * terraform test: move variable evaluation into the terraform test graph * make copyrightfix	11 months ago
Liam Cervante	31bb18f149	Allow external providers to override explicit provider blocks (#37215)	11 months ago
Mark DeCrane	9e7c094ebe	Merge branch 'main' into update-stacks-plugin-binary-download-to-accomodate-crt-zip	11 months ago
Liam Cervante	063b7cf62b	terraform test: check specific dependencies before skipping run blocks (#37204) ... * terraform test: check specific dependencies before skipping run blocks * fix data race * complete comment	11 months ago
Mark DeCrane	e16c5f6807	Updating the plugin binary manager to accomodate CRT style release zip contents	11 months ago
James Bardin	5eabf97554	Merge pull request #37212 from hashicorp/jbardin/sensitive-output ... ensure outputs carry sensitive marks forward	11 months ago
James Bardin	d857f2013f	Merge pull request #37210 from hashicorp/jbardin/ephemeral-output ... allow output values without top-level ephemeral marks	11 months ago
James Bardin	bb1cd82d60	ensure outputs carry sensitive marks forward ... Sensitive marks were lost from module outputs during the namedvals rewrite. Ensure output are evaluated with sensitive in accordance with their configuration.	11 months ago
James Bardin	46444353df	allow outputs without top-level ephemeral marks ... There is currently no way to construct an output value which does not come directly from an ephemeral resource or input. Even if the constructed value is entirely composed of ephemeral attributes or elements, because there is no action to manually mark something as ephemeral (other than a variable block), the resulting value itself is not marked as ephemeral, and fails validation. Instead of strictly checking for an ephemeral mark on the output value, we can accept any value because the result will always be entirely ephemeral anyway. This mirrors the variable block behavior, which can accept any type of value as input, but is evaluated as ephemeral.	11 months ago
Daniel Banck	cb58a15f3d	Implement ListResource RPC (TF-25509) (#37092) ... * Implement ListResource RPC via callbacks * Implement ListResource with iterators * Change `ListResourceResponse` to slice * Turn ListResourceResponse into a struct * Add a limit for ListResource * explicitly cancel stream when listing resources --------- Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	11 months ago
Radek Simko	643266dc90	Add initial state store protocol skeleton (#37197) ... * Add initial state store protocol skeleton Introduce ValidateStateStoreConfig + ConfigureStateStore Update GetProviderSchema + GetMetadata (for mux) * address PR feedback	11 months ago
Liam Cervante	757efaed9a	terraform test: automatically create edges based on references (#37200) ... * terraform test: automatically create edges based on references * address comments * remove unused function	11 months ago
Samsondeen	2a79f5fa53	Use iterators for graph vertices (#36558) ... * Use iterators for graph vertices * use func filter * use type param instead of function filter One type parameter seem to be enough instead of 2	11 months ago
Liam Cervante	eaf3061789	deferrals: add source info to deferred-during-apply diagnostic (#37199)	11 months ago
Liam Cervante	f80762d3d5	terraform test: add variable definitions to test files (#37195) ... * terraform test: add variable definitions to test files Currently, `terraform test` attempts to work out the type of any external variables by delaying evaluation until each run block executes so it can use the definitions within the run blocks's module. This means that the values of variables can technically change between run blocks which isn't ideal. This commit is the first in a chain which will move the evaluation of variables into the terraform test graph. We need to give the users the option of specifying the type for external variables within the file as these variables are now going to be assessed outside of the context of a run block. To do this, we introduce the optional variable blocks that are added by this commit. * update comment	11 months ago
Liam Cervante	71af8f8858	terraform test: push context initialisation into the graph (#37194) ... * terraform test: refactor the context initialisation into specific node in the graph * Update internal/moduletest/graph/transform_providers.go Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> --------- Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com>	11 months ago
Liam Cervante	19540e30fe	terraform test: don't allow diags from executable nodes (#37193)	11 months ago
Radek Simko	dd4bf55dca	docs/plugin-protocol: Clarify use of GetMetadata (#37181) ... * docs/plugin-protocol: Clarify use of GetMetadata * Run `make protobuf` --------- Co-authored-by: Sarah French <sarah.french@hashicorp.com>	11 months ago
Syed Shahidh Ilhan F	434bbc4e2f	fix: Update K8s and Consul API dependencies to address security vulnerabilities (#37150) ... * bump vulnerable packages Signed-off-by: SYSHIL <ilhan.syed@gmail.com> * make syncdeps Signed-off-by: SYSHIL <ilhan.syed@gmail.com> --------- Signed-off-by: SYSHIL <ilhan.syed@gmail.com>	11 months ago
Sarah French	ab0947b8e3	Add warning when a `cloud` block is present in a child module (#37180) ... * Add warning when a `cloud` block is present in a child module * Add change file	11 months ago
Sarah French	6f07b460a7	Update and add new tests for module-parsing logic (#37176) ... * Add comments, rename tests, reorder tests This commit doesn't change or add any logic * Add test for overriding a cloud block with a backend block * Add tests showing multiple instances of cloud or backend blocks cause an error * Add test showing that backend and cloud blocks cannot be in the same terraform block * Add test case asserting it's not valid to have both cloud and backend blocks across files in a module * Clarify comments and replace some comments with test names * Replace comments with test names	11 months ago
James Bardin	2c72198209	Merge pull request #37164 from hashicorp/jbardin/unmark-for-each ... UnmarkDeep is not needed here	11 months ago
Daniel Banck	4e72321814	Validate list resource schemas (#37162)	11 months ago
Liam Cervante	f3489c0480	deferred actions: should still be experimental (#37167)	11 months ago
Mattias Fjellström	3252fa8f42	Add missing JUnit XML flag to test command help string (#37161) ... The test command supports outputting a JUnit XML file with the -junit-xml flag. This flag was missing from the test command help string.	11 months ago
James Bardin	b635542fba	UnmarkDeep is not needed here ... Calling LengthInt does not require unmarking all nested values. The UnmarkDeep call causes an unnecessary deep copy, and generate lots of garbage every time a for_each collection was evaluated, which is at least once for each instance.	11 months ago
James Bardin	10f3524bc5	Merge pull request #37155 from hashicorp/jbardin/graph-log-perf ... add TF_GRAPH_TRACE to turn off graph trace output	11 months ago
James Bardin	fa387fccdf	Merge pull request #37154 from hashicorp/jbardin/resource-changes-perf ... reduce instance change lookups in GetResource	11 months ago