43 Commits (f2dbf80badc8c7385a7b44bb040ae5e8550e7e60)

Author	SHA1	Message	Date
Josh Grancell	ac3578a0bc	command/output: Absence of outputs is not an error	6 years ago
Kristin Laemmert	c9d62bb2f6	command: discard output from flags package and return errs directly (#22373) ... Any command using meta.defaultFlagSet *might* occasionally exit before the flag package's output got written. This caused flag error messages to get lost. This PR discards the flag package output in favor of directly returning the error to the end user.	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Kristin Laemmert	1c95b21c6c	command/output: get the state path from the workspace or CLI argument (#20994) ... Previously this command was setting the state path to the default state file, instead of honoring the backend configuration.	7 years ago
Sander van Harmelen	ef9054562e	commands: make sure the correct flagset is used ... A lot of commands used `c.Meta.flagSet()` to create the initial flagset for the command, while quite a few of them didn’t actually use or support the flags that are then added. So I updated a few commands to use `flag.NewFlagSet()` instead to only add the flags that are actually needed/supported. Additionally this prevents a few commands from using locking while they actually don’t need locking (as locking is enabled as a default in `c.Meta.flagSet()`.	7 years ago
Martin Atkins	37bc187f95	command: "terraform output" mustn't panic when no state is present ... This is verified by TestOutput_noArgs.	7 years ago
Martin Atkins	73abb6e8f4	command: Re-enable showing outputs after successful "apply" ... We temporarily disabled this because it needed some further work to update it for the new state models, which has now been done. We no longer need the configuration objects for the outputs because the state itself contains all of the information needed for displaying these.	7 years ago
Martin Atkins	025540789c	command: Restore the "terraform output" functionality ... We previously stubbed most of this out because it hadn't yet been updated to support the new state types, etc. This restores all of the previous behavior as covered by the tests. We intentionally remove one behavior that was not covered by the tests: we used to allow retrieval of outputs from non-root modules using the -module option, but since we no longer persist non-root outputs in the state we can no longer support this without a full expression evaluation walk, and that'd be overkill for this otherwise-simple command. Descendant module outputs are not part of the public interface of a configuration anyway, so accessing them from outside in this way is an anti-pattern. (For debugging scenarios it is still possible to access these from "terraform console", which _does_ do a full evaluation graph walk to prepare its evaluation scope.)	7 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	7 years ago
Martin Atkins	c937c06a03	terraform: ugly huge change to weave in new HCL2-oriented types ... Due to how deeply the configuration types go into Terraform Core, there isn't a great way to switch out to HCL2 gradually. As a consequence, this huge commit gets us from the old state to a _compilable_ new state, but does not yet attempt to fix any tests and has a number of known missing parts and bugs. We will continue to iterate on this in forthcoming commits, heading back towards passing tests and making Terraform fully-functional again. The three main goals here are: - Use the configuration models from the "configs" package instead of the older models in the "config" package, which is now deprecated and preserved only to help us write our migration tool. - Do expression inspection and evaluation using the functionality of the new "lang" package, instead of the Interpolator type and related functionality in the main "terraform" package. - Represent addresses of various objects using types in the addrs package, rather than hand-constructed strings. This is not critical to support the above, but was a big help during the implementation of these other points since it made it much more explicit what kind of address is expected in each context. Since our new packages are built to accommodate some future planned features that are not yet implemented (e.g. the "for_each" argument on resources, "count"/"for_each" on modules), and since there's still a fair amount of functionality still using old-style APIs, there is a moderate amount of shimming here to connect new assumptions with old, hopefully in a way that makes it easier to find and eliminate these shims later. I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	7 years ago
Martin Atkins	ebafa51723	command: Various updates for the new backend package API ... This is a rather-messy, complex change to get the "command" package building again against the new backend API that was updated for the new configuration loader. A lot of this is mechanical rewriting to the new API, but meta_config.go and meta_backend.go in particular saw some major changes to interface with the new loader APIs and to deal with the change in order of steps in the backend API.	7 years ago
Lyle Franklin	26b907387d	cli: Remove error on empty outputs when `-json` is set (#11721) ... - Fixes #11696 - This changes makes `terraform output -json` return '{}' instead of throwing an error about "no outputs defined" - If `-json` is not set, the user will receive an error as before - This UX helps new users to understand how outputs are used - Allows for easier automation of TF CLI as an empty set of outputs is usually acceptable, but any other error from `output` would be re-raised to the user.	8 years ago
Robert Liebowitz	006744bfe0	Use all tfvars files in working directory ... As a side effect, several commands that previously did not have a failure state can now fail during meta-parameter processing.	9 years ago
Martin Atkins	418a8a8bc9	command + backend: rename various API objects to "Workspace" terminology ... We're shifting terminology from "environment" to "workspace". This takes care of some of the main internal API surface that was using the old terminology, though is not intended to be entirely comprehensive and is mainly just to minimize the amount of confusion for maintainers as we continue moving towards eliminating the old terminology.	9 years ago
James Bardin	b53704ed87	Thread the environment through all commands ... Add Env and SetEnv methods to command.Meta to retrieve the current environment name inside any command. Make sure all calls to Backend.State contain an environment name, and make the package compile against the update backend package.	9 years ago
Chris Paris	5812bae27f	RefreshState in output command	9 years ago
Seth Vargo	0d39123cb0	Update error message when no outputs are defined ... Terraform can't tell the difference between an empty output and an undefined output. This is often confusing for folks using interpolation. As much as it would be great to fix upstream, changing this error message to be a bit more helpful is a good stop-gap to avoid frustration.	9 years ago
Seth Vargo	037d4b6c87	Suggest refresh instead of apply ... Suggesting an apply could actually change remote resources whereas a refresh will at-worst modify local state.	9 years ago
Mitchell Hashimoto	ad7b063262	command: convert to use backends	9 years ago
Calle Pettersson	51ff5cba38	Align the help string of output with documentation (#9735)	9 years ago
James Nugent	0e4e94a86f	core: Fix -module for terraform output command ... The behaviour whereby outputs for a particular nested module can be output was broken by the changes for lists and maps. This commit restores the previous behaviour by passing the module path into the outputsAsString function. We also add a new test of this since the code path for indivdual output vs all outputs for a module has diverged.	10 years ago
James Nugent	b4048dfc1d	core: Add -json flag to `terraform output` ... This commit removes the ability to index into complex output types using `terraform output a_list 1` (for example), and adds a `-json` flag to the `terraform output` command, such that the output can be piped through a post-processor such as jq or json. This removes the need to allow arbitrary traversal of nested structures. It also adds tests of human readable ("normal") output with nested lists and maps, and of the new JSON output.	10 years ago
James Nugent	ef3aad1231	core: Correctly format nested outputs ... This commit pretty prints outputs which consist of nested complex structures (e.g. lists of lists, lists of maps). Fixes #7143.	10 years ago
James Nugent	7aec98237c	core: Format empty lists and maps in output ... `terraform output` and it's brethren now consolidate empty maps and lists on a single line of output instead of the pathological behaviour of taking three lines previously. The same code paths are used across all output mechanisms: ``` $ cat main.tf variable "emptystring" { type = "string" default = "" } variable "emptylist" { type = "list" default = [] } variable "emptymap" { type = "map" default = {} } output "emptystring" { value = "${var.emptystring}" } output "emptylist" { value = "${var.emptylist}" } output "emptymap" { value = "${var.emptymap}" } $ terraform apply Apply complete! Resources: 0 added, 0 changed, 0 destroyed. Outputs: emptylist = [] emptymap = {} emptystring = $ terraform output emptylist = [] emptymap = {} emptystring = $ terraform show Outputs: emptylist = [] emptymap = {} emptystring = ```	10 years ago
James Nugent	8e732c104b	core: Error over panic if output type unknown	10 years ago
James Nugent	3ea3c657b5	core: Use OutputState in JSON instead of map ... This commit forward ports the changes made for 0.6.17, in order to store the type and sensitive flag against outputs. It also refactors the logic of the import for V0 to V1 state, and fixes up the call sites of the new format for outputs in V2 state. Finally we fix up tests which did not previously set a state version where one is required.	10 years ago
James Nugent	6a20e8927d	core: Fix issues from rebasing dev-0.7 onto master ... - Fix sensitive outputs for lists and maps - Fix test prelude which was missed during conflict resolution - Fix `terraform output` to match old behaviour and not have outputs header and colouring - Bump timeout on TestAtlasClient_UnresolvableConflict	10 years ago
James Nugent	e57a399d71	core: Use native HIL maps instead of flatmaps ... This changes the representation of maps in the interpolator from the dotted flatmap form of a string variable named "var.variablename.key" per map element to use native HIL maps instead. This involves porting some of the interpolation functions in order to keep the tests green, and adding support for map outputs. There is one backwards incompatibility: as a result of an implementation detail of maps, one could access an indexed map variable using the syntax "${var.variablename.key}". This is no longer possible - instead HIL native syntax - "${var.variablename["key"]}" must be used. This was previously documented, (though not heavily used) so it must be noted as a backward compatibility issue for Terraform 0.7.	10 years ago
James Nugent	6aac79e194	state: Add support for outputs of multiple types ... This commit adds the groundwork for supporting module outputs of types other than string. In order to do so, the state version is increased from 1 to 2 (though the "public-facing" state version is actually as the first state file was binary). Tests are added to ensure that V2 (1) state is upgraded to V3 (2) state, though no separate read path is required since the V2 JSON will unmarshal correctly into the V3 structure. Outputs in a ModuleState are now of type map[string]interface{}, and a test covers round-tripping string, []string and map[string]string, which should cover all of the types in question. Type switches have been added where necessary to deal with the interface{} value, but they currently default to panicking when the input is not a string.	10 years ago
James Nugent	b62f6af158	core: Add support for marking outputs as sensitive (#6559) ... * core: Add support for marking outputs as sensitive This commit allows an output to be marked "sensitive", in which case the value is redacted in the post-refresh and post-apply list of outputs. For example, the configuration: ``` variable "input" { default = "Hello world" } output "notsensitive" { value = "${var.input}" } output "sensitive" { sensitive = true value = "${var.input}" } ``` Would result in the output: ``` terraform apply Apply complete! Resources: 0 added, 0 changed, 0 destroyed. Outputs: notsensitive = Hello world sensitive = <sensitive> ``` The `terraform output` command continues to display the value as before. Limitations: Note that sensitivity is not tracked internally, so if the output is interpolated in another module into a resource, the value will be displayed. The value is still present in the state.	10 years ago
Radek Simko	9596271b36	Code formatted via gofmt	11 years ago
Radek Simko	10f04c90a5	'terraform output' helptext spacing fixed	11 years ago
Eric Connell	85d1d15d81	output command supports printing all outputs ... if no output name is specified all outputs are displayed fixed formating and added missing help for -module parameter	11 years ago
Radek Simko	b7d41d2eed	Add -no-color to help text	11 years ago
Paul Hinze	aa39dc71de	command/output: fix error msg typo	11 years ago
Kirill Shirinkin	b05e36a6e3	Add module outputs	11 years ago
Mitchell Hashimoto	83cb277583	command/output: don't panic if no root module in state [GH-1263]	11 years ago
Mitchell Hashimoto	579f102f37	command: start migrating to new state package	11 years ago
Armon Dadgar	0c9436f37b	command/output: Remote enable	11 years ago
Mitchell Hashimoto	cdad3036ae	command: closer to compiling	12 years ago
Mitchell Hashimoto	642fed0356	command: terraform.tfvars loaded by default if it exists	12 years ago
Mitchell Hashimoto	3f803cb75c	command/output: protect againts blank params	12 years ago
Mitchell Hashimoto	2caff709d6	comand/output	12 years ago