575 Commits (f2dbf80badc8c7385a7b44bb040ae5e8550e7e60)

Author	SHA1	Message	Date
Sander van Harmelen	b62a22ab62	Add a VariableSourceType for names .tfvars files ... This new source type should be used for variables loaded from .tfvars files that were explicitly passed as command line arguments (e.g. -var-file=foo.tfvars)	8 years ago
Sander van Harmelen	b846c5f653	Make the test compile again ... Not sure if these checks still make sense, but without this change the test don’t compile for the related packages.	8 years ago
Sander van Harmelen	48ef7ecfa6	Updates after running `make fmt` with Go v1.11.1	8 years ago
James Bardin	0a0eece15c	add backend cli options after configuration ... The cli should override the config	8 years ago
Martin Atkins	541952bb8f	Revert some work that happened since v0.12-dev branched ... This work was done against APIs that were already changed in the branch before work began, and so it doesn't apply to the v0.12 development work. To allow v0.12 to merge down to master, we'll revert this work out for now and then re-introduce equivalent functionality in later commits that works against the new APIs.	8 years ago
Martin Atkins	98bbd560b5	command: Fix most (but not all) "terraform plan" tests	8 years ago
Martin Atkins	741d334ee4	command: Even more fixes for "apply" command tests	8 years ago
Martin Atkins	c5940f2438	backend/local: Increase log verbosity for backend context construction ... There are several steps here and a number of them can include reaching out to remote servers or executing local processes, so it's helpful to have some trace logs to better narrow down causes of errors and hangs during this step.	8 years ago
Martin Atkins	a6f399517b	backend/local: reinstate additional steps in plan file processing ... In earlier refactoring we skipped implementing prior state safety checks, propagating the target addresses from plan, and verifying that all of the providers are exactly the same from the plan being created. This change reinstates those checks, including a new error message for the "stale plan" situation.	8 years ago
Martin Atkins	91d2de6a25	backend/local: Stub out remaining planfile todos with errors ... This is just to make sure they show up later when we are working on the tests, so we can be sure not to forget to address them.	8 years ago
Martin Atkins	fa3b4fc9de	backend/local: Populate changes into a context built from planfile	8 years ago
Martin Atkins	cbc548eb36	command: Do CLI init of backend loaded from plan ... If we don't do this, we can't produce any output when applying a saved plan file. Here we also introduce a check to the local backend's ReportResult function so that it won't panic if CLI init is skipped, although that will no longer happen in the apply-from-file case due to the change described in the previous paragraph.	8 years ago
Martin Atkins	2b80df0163	backend/local: Require caller to set PlanOutBackend with PlanOutPath ... We can't generate a valid plan file without a backend configuration to write into it, but it's the responsibility of the caller (the command package) to manage the backend configuration mechanism, so we require it to tell us what to write here. This feels a little strange because the backend in principle knows its own config, but in practice the backend only knows the _processed_ version of the config, not the raw configuration value that was used to configure it.	8 years ago
Kristin Laemmert	2d3cb87789	backend/local tests tests tests ... converted the existing testPlanState() from terraform.State to states.State to fix various plan tests. reverted the "bandaid" in plans/planfile/tfplan.go - at this moment the backend tests do not include backend configuration, and so the planfile package can write the plan file but not read it back in. That will be revisted in a separate track of work.	8 years ago
Kristin Laemmert	6a37ee9277	backend/local: more tests passing ... I have no confidence in the change to plans/planfile/tfplan.go. The tests were passing an empty backend config, which planfile was able to write to a file but not read from the same file. This change let me move past that and it did not break any tests in the planfile package, but I am concerned that it introduces undesired behavior.	8 years ago
Kristin Laemmert	56b879d0c0	backend/local: updated DiffFn adn ReadResourceFn for new models	8 years ago
Kristin Laemmert	64f696d9b3	backend/local refresh tests refactor	8 years ago
Kristin Laemmert	e84def1e29	backend/local: test fixes ... for TestLocal_applyBackendFail, config is relative to the tests' wd	8 years ago
Kristin Laemmert	d865df7338	revert to explicitly declare schema for TestLocal_applyEmptyDirDestroy	8 years ago
Kristin Laemmert	739bd5ef0d	backend/local tests	8 years ago
Martin Atkins	1c007473ba	backend: TestBackendConfig to allow nil config body ... This is not normally considered valid, but since this is a test helper we will allow it and just treat it as an empty body.	8 years ago
Martin Atkins	8565c7460e	backend/remote-state/inmem: remove FIXME guards on tests that no longer hang	8 years ago
Martin Atkins	20727945ee	backend/remote-state/inmem: enable optional logging in tests	8 years ago
Martin Atkins	aaf405b662	backend/remote-state: Get all the backend tests building again ... The state manager refactoring in an earlier commit was reflected in the implementations of these backends, but not in their tests. This gets us back to a state where the backend tests will compile, and gets _most_ of them passing again, with a few exceptions that will be addressed in a subsequent commit.	8 years ago
Martin Atkins	b0016e9cf6	command: Allow tests to run to completion without panics or hangs ... There are still 160 test failures as of this commit, but at least the test program can run to completion and list out all the failures.	8 years ago
Kristin Laemmert	3da04ef9fc	backend/local: adding some informative comments to commented-out tests	8 years ago
Kristin Laemmert	c661157999	plans/objchange: further harden ProposedNewObject against ~weird~ ... incoming values Addresses an odd state where the priorV of an object to be changed is known but null. While this situation should not happen, it seemed prudent to ensure that core is resilient to providers sending incorrect values (which might also occur with manually edited state).	8 years ago
Kristin Laemmert	2808df48ec	backend/local WIP commit - fixing tests	8 years ago
Kristin Laemmert	fbe959ae6e	backend/local: fix panic in tests ... update the function names in testDelegateBackend to match what was being called in TestLocal_multiStateBackend (matching the test behavior in master)	8 years ago
Martin Atkins	a43b7df282	core: Handle forced-create_before_destroy during the plan walk ... Previously we used a single plan action "Replace" to represent both the destroy-before-create and the create-before-destroy variants of replacing. However, this forces the apply graph builder to jump through a lot of hoops to figure out which nodes need it forced on and rebuild parts of the graph to represent that. If we instead decide between these two cases at plan time, the actual determination of it is more straightforward because each resource is represented by only one node in the plan graph, and then we can ensure we put the right nodes in the graph during DiffTransformer and thus avoid the logic for dealing with deposed instances being spread across various different transformers and node types. As a nice side-effect, this also allows us to show the difference between destroy-then-create and create-then-destroy in the rendered diff in the CLI, although this change doesn't fully implement that yet.	8 years ago
Martin Atkins	5390fb1eed	backend/local: Don't count outputs for choosing diff action symbols ... We're not yet showing outputs in the rendered diff, so it doesn't make sense to count them for the purpose of deciding which change action symbols to include in the legend.	8 years ago
Martin Atkins	20318ca193	backend/local: Sort planned resource changes before rendering them ... As in the old plan renderer, they are ordered by the natural ordering of the resource addresses.	8 years ago
Martin Atkins	239a54ad6f	command: initial structural diff rendering ... This is a light adaptation of our earlier prototype of structural diff rendering, as a starting point for what we'll actually ship. This is not consistent with the latest mocks, so will need some additional work before it is ready, but integrating this allows us to at least see the plan contents while fixing up remaining issues elsewhere.	8 years ago
Martin Atkins	a6b5980a4f	backend/local: Bail immediately if terraform.Context can't be created	8 years ago
Martin Atkins	44bc7519a6	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	8 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	479c6b2466	move "configschema" from "config" to "configs" ... The "config" package is no longer used and will be removed as part of the 0.12 release cleanup. Since configschema is part of the "new world" of configuration modelling, it makes more sense for it to live as a subdirectory of the newer "configs" package.	8 years ago
Martin Atkins	ebc6238bee	backend/local: Update tests for changes in "terraform" package ... This mainly consists of adding schema information to the mock providers.	8 years ago
Martin Atkins	c937c06a03	terraform: ugly huge change to weave in new HCL2-oriented types ... Due to how deeply the configuration types go into Terraform Core, there isn't a great way to switch out to HCL2 gradually. As a consequence, this huge commit gets us from the old state to a _compilable_ new state, but does not yet attempt to fix any tests and has a number of known missing parts and bugs. We will continue to iterate on this in forthcoming commits, heading back towards passing tests and making Terraform fully-functional again. The three main goals here are: - Use the configuration models from the "configs" package instead of the older models in the "config" package, which is now deprecated and preserved only to help us write our migration tool. - Do expression inspection and evaluation using the functionality of the new "lang" package, instead of the Interpolator type and related functionality in the main "terraform" package. - Represent addresses of various objects using types in the addrs package, rather than hand-constructed strings. This is not critical to support the above, but was a big help during the implementation of these other points since it made it much more explicit what kind of address is expected in each context. Since our new packages are built to accommodate some future planned features that are not yet implemented (e.g. the "for_each" argument on resources, "count"/"for_each" on modules), and since there's still a fair amount of functionality still using old-style APIs, there is a moderate amount of shimming here to connect new assumptions with old, hopefully in a way that makes it easier to find and eliminate these shims later. I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	ebafa51723	command: Various updates for the new backend package API ... This is a rather-messy, complex change to get the "command" package building again against the new backend API that was updated for the new configuration loader. A lot of this is mechanical rewriting to the new API, but meta_config.go and meta_backend.go in particular saw some major changes to interface with the new loader APIs and to deal with the change in order of steps in the backend API.	8 years ago
Martin Atkins	5782357c28	backend: Update interface and implementations for new config loader ... The new config loader requires some steps to happen in a different order, particularly in regard to knowing the schema in order to decode the configuration. Here we lean directly on the configschema package, rather than on helper/schema.Backend as before, because it's generally sufficient for our needs here and this prepares us for the helper/schema package later moving out into its own repository to seed a "plugin SDK".	8 years ago
James Bardin	a79d620f03	remove legacy remote state code	8 years ago
James Bardin	979faa5dbe	move artifactory remote state to backend	8 years ago
James Bardin	18ef072325	move legacy http remote state to a backend	8 years ago
James Bardin	fe527ec9d7	move legacy etcd remote state to a backend	8 years ago
Martin Atkins	bd10b84a8e	command/format: include source snippets in diagnostics ... If we get a diagnostic message that references a source range, and if the source code for the referenced file is available, we'll show a snippet of the source code with the source range highlighted. At the moment we have no cache of source code, so in practice this codepath can never be visited. Callers to format.Diagnostic will be gradually updated in subsequent commits.	8 years ago
Sander van Harmelen	8875fa660f	Make sure we also output policies while planning	8 years ago
Sander van Harmelen	775f8a9626	Make sure we always set a custom header ... This is for TFE to recognize were the calls come from.	8 years ago
Sander van Harmelen	0a59e54933	Improve the output just a bit	8 years ago
Sander van Harmelen	c08cd597c5	Omit any empty lines containing STX/ETX markers	8 years ago
Sander van Harmelen	fb0af07696	Print status updates while waiting for the run to start	8 years ago
Sander van Harmelen	d78470ad5a	Don’t ask questions when -auto-approve is set ... We previously asked to override a soft-failed policy, even wehn -auto-approve was set. That is now fixed by returning a policy failed error.	8 years ago
Sander van Harmelen	53a8aaaf85	Merge pull request #19022 from hashicorp/f-auto-apply ... backend/remote: properly handle workspaces that auto apply changes	8 years ago
Sander van Harmelen	194863db4e	Properly handle workspaces that auto apply changes ... This commit adds logic to check if a workspace is configured to auto apply changes. And if it does, we make sure we output all steps correctly.	8 years ago
Sander van Harmelen	b1fdbd7db8	Allow enhanced backends to pass custom exit codes ... In some cases this is needed to keep the UX clean and to make sure any remote exit codes are passed through to the local process. The most obvious example for this is when using the "remote" backend. This backend runs Terraform remotely and stream the output back to the local terminal. When an error occurs during the remote execution, all the needed error information will already be in the streamed output. So if we then return an error ourselves, users will get the same errors twice. By allowing the backend to specify the correct exit code, the UX remains the same while preserving the correct exit codes.	8 years ago
Sander van Harmelen	67db9da000	Add checks for all flags we currently don’t support ... For Plan only: -module-depth=n For Plan & Apply -parallelism=m -refresh=false -var “foo=bar” and -var-file=foo	8 years ago
Sander van Harmelen	ffc67a8e90	Prevent running plan or apply without permissions	8 years ago
Sander van Harmelen	53d322ec69	Test lock timeout errors when running a plan	8 years ago
Sander van Harmelen	c12f0355a7	Revert "Merge pull request #18980 from hashicorp/f-policy-output" ... This reverts commit f09c2db8d2, reversing changes made to 8394dc797d.	8 years ago
Sander van Harmelen	a2241e7c43	backend/remote: introduce support for `-no-color` ... This is a bit of a hack to support the `-no-color` flag while we don’t have an option to set run variables. That is also the reason why the orginal method is commented out instead of deleted. This will be reverted when the TFE starts supporting run variables.	8 years ago
Sander van Harmelen	f09c2db8d2	Merge pull request #18980 from hashicorp/f-policy-output ... backend/remote: only show the full policy output when it fails	8 years ago
Sander van Harmelen	3979aec0ae	Ask to cancel a pending remote operation ... Except when a lock-timeout has exceeded or auto-approve is set.	8 years ago
Sander van Harmelen	37f5ab3500	Only show the full policy output when it fails ... If the policy passes, only show that instead of the full check output to prevent cluttering the output. So a passing policy will only show: ----------------------------------------------- Organization policy check: passed -----------------------------------------------	8 years ago
Sander van Harmelen	b28f47055d	backend/remote: extend mocks and add sentinel tests	8 years ago
Sander van Harmelen	2bd1040bbd	backend/remote: extend mocks and add apply tests	8 years ago
Sander van Harmelen	9f9bbcb0e7	backend/remote: lots of improvements ... This commit adds: - support for `-lock-timeout` - custom error message when a 404 is received - canceling a pending run when TF is Ctrl-C’ed - discard a run when the apply is not approved	8 years ago
Sander van Harmelen	621d589189	backend/remote: add support for the apply operation	8 years ago
Kristin Laemmert	813b5fd27f	Merge pull request #18825 from sean-/master-make-dev-drift ... build: Updates required to bump golang version to 1.11	8 years ago
Sander van Harmelen	4aeb67b8ff	backend/remote: handle empty results correctly ... The pagination info of a list call that returns an empty list contains: ```go CurrentPage: 1 TotalPages: 0 ``` So checking if we have seen all pages using `CurrentPage == TotalPages` will not work and will result in an endless loop. The tests are updated so they will fail (timeout after 1m) if this is handled incorreclty.	8 years ago
Sander van Harmelen	ea88daa499	backend/remote: add support for state locking	8 years ago
Sander van Harmelen	7c1da2ffaa	Merge pull request #18818 from hashicorp/b-associate-state ... backend/remote: add the run ID to associate state	8 years ago
Sander van Harmelen	cd6d75bc03	backend/remote: add the run ID to associate state ... If a run ID is available, we need to make sure we pass that when creating a new state version so the state will be properly associated with the run.	8 years ago
Sander van Harmelen	3cc58813f0	backend/remote: use a search query and use pagination ... To prevent making unnecessary heavy calls to the backend, we should use a search query to limit the result. But even if we use a search query, we should still use the pagination details to make sure we retrieved all items.	8 years ago
Sean Chittenden	d749420a25	Fix drift caused from gofmt when running make dev and go 1.11. ... A fresh checkout of `origin/master` does not build atm using the `dev` target because `master` has not been formatted using `gofmt` from Go 1.11 (tis has been the case for a while if you've been running devel). None of the drift in question is especially new but now that Go 1.11 has been released and gofmt's formatting guidelines have been updated, it would be *really* nice if the code in `master` reflected the current tooling in order to avoid having to fight this drift locally. * 8mo: https://github.com/hashicorp/terraform/blame/master/backend/remote-state/s3/backend_test.go#L260-L261 * 6mo: https://github.com/hashicorp/terraform/blame/master/builtin/provisioners/chef/linux_provisioner_test.go#L124 * 1yr: 7cfeffe36b/command/init.go (L75-L76) * 12d: 7cfeffe36b/command/meta_backend_test.go (L1437) * 2yr: 7cfeffe36b/helper/schema/resource_timeout_test.go (L26) * 4yr: 7cfeffe36b/helper/schema/schema_test.go (L2059) * 1yr: 7cfeffe36b/plugin/discovery/get_test.go (L151)	8 years ago
Sander van Harmelen	62ab84a319	backend/remote: compat changes for latest `go-tfe`	8 years ago
Sander van Harmelen	3cfc83e335	backend/remote: take working directories into account ... In TFE you can configure a workspace to use a custom working directory. When determining which directory that needs to be uploaded to TFE, this working directory should be taken into account to make sure we are uploading the correct root directory for the workspace.	8 years ago
Sander van Harmelen	ce2869dced	Merge pull request #18760 from hashicorp/f-remote-backend ... backend/migrations: migrate the default state	8 years ago
Sander van Harmelen	f410a5bb26	backend/migrations: migrate the default state ... Certain backends (currently only the `remote` backend) do not support using both the default and named workspaces at the same time. To make the migration easier for users that currently use both types of workspaces, this commit adds logic to ask the user for a new workspace name during the migration process.	8 years ago
Sander van Harmelen	77b9fad7f0	backend/manta: deprecate camelcase attribute name ... This change is needed (next to making it consistent as its the only attribute name that uses camelcase) because passing that attribute objectName in the update `terraform_remote_state` resource, ended up giving me this error: https://github.com/hashicorp/terraform/blob/master/helper/schema/schema.go#L736	8 years ago
Sander van Harmelen	7049d973a9	Do not use the TFE_TOKEN env variable ... Instead promote the use of shared credentials using the CLI Config File	8 years ago
Sander van Harmelen	83d5f4147b	backend/remote: use schema max/min items options	8 years ago
Sander van Harmelen	7fb2d1b8de	Implement the Enterprise enhanced remote backend	8 years ago
Sander van Harmelen	495d1ea350	Use New() instead of `once.Do(b.init)`	8 years ago
Sander van Harmelen	97d1c46602	Update the backend import names ... It’s a purely cosmetic change, but I find it easier to read them like this.	8 years ago
Kristin Laemmert	85be12d783	cli: show workspace name in destroy confirmation (#18253) ... * cli: show workspace name in destroy confirmation If the workspace name is not "default", include it in the confirmation message for `terraform destroy`. Fixes #15480	8 years ago
stack72	df9b2913ae	backend/manta: Add support for manta backend tiered path structure ... This was already added to triton-go and is now making its way to the manta backend ``` % acctests backend/remote-state/manta === RUN TestBackend_impl --- PASS: TestBackend_impl (0.00s) === RUN TestBackend --- PASS: TestBackend (27.36s) === RUN TestBackendLocked --- PASS: TestBackendLocked (16.24s) === RUN TestRemoteClient_impl --- PASS: TestRemoteClient_impl (0.00s) === RUN TestRemoteClient --- PASS: TestRemoteClient (3.40s) === RUN TestRemoteClientLocks --- PASS: TestRemoteClientLocks (7.17s) PASS ok github.com/hashicorp/terraform/backend/remote-state/manta ```	8 years ago
James Bardin	28c46d1a90	cleanup temp files from backend tests	8 years ago
stack72	a6f76aa0af	backend/manta: Manta Backend was not dealing with a ResourceNotFound ... Fixes: #17314 We now deal correctly with the creation of the state file - we were not dealing well with a ResourceNotFound error Now that this has been changed around, we try and create the statefile and if there is an error, we look for an existing statefile - previously this was not the order of operations	8 years ago
Martin Atkins	6aefa5835c	Merge #17218: Add -auto-approve to "terraform destroy" for consistency	8 years ago
Paul Tyng	c868092d2d	Standardize http.Client creation with User-Agent	8 years ago
James Bardin	e9a76808df	create clistate.Locker interface ... Simplify the use of clistate.Lock by creating a clistate.Locker instance, which stores the context of locking a state, to allow unlock to be called without knowledge of how the state was locked. This alows the backend code to bring the needed UI methods to the point where the state is locked, and still unlock the state from an outer scope. Provide a NoopLocker as well, so that callers can always call Unlock without verifying the status of the lock. Add the StateLocker field to the backend.Operation, so that the state lock can be carried between the different function scopes of the backend code. This will allow the backend context to lock the state before it's read, while allowing the different operations to unlock the state when they complete.	8 years ago
James Bardin	8242c773b8	missed the local state backend	8 years ago
James Bardin	57cbcbe99d	update remote state tests to use new test helpers	8 years ago
James Bardin	112c37458f	report the proper lock id from a state lock error ... Fix the now failing state unlock test by reporting the correct ID. The ID used by GCS is the generation number of the info object, which isn't known until the info is already written out. While we can't get the correct ID from the info data for the error rmessage, we can update it with the generation number after it's read.	8 years ago
James Bardin	1fee5ae172	update gcs to use the new backend tests	8 years ago
James Bardin	85d6b1d9cc	add test for lock error and force-unlock ... This adds a general test to verify that a remote state backend returns the expected error type when it cannot lock a state. It then extracts the ID reported in the error, and attempts to unlock the state using that ID, which simulated the force-unlock scenario. This is a separate test, since not all backends have persistent locks that can be unlocked later. We also split out the backend test to be called individually as needed.	8 years ago
James Bardin	ef8ed1e275	coalesce the backened interrupt code ... Moves the nested select statements for backend operations into a single function. The only difference in this part was that apply called PersistState, which should be harmless regardless of the type of operation being run.	8 years ago
James Bardin	7cba68326a	always wait for a RunningOperation to return ... If the user wishes to interrupt the running operation, only the first interrupt was communicated to the operation by canceling the provided context. A second interrupt would start the shutdown process, but not communicate this to the running operation. This order of event could cause partial writes of state. What would happen is that once the command returns, the plugin system would stop the provider processes. Once the provider processes dies, all pending Eval operations would return return with an error, and quickly cause the operation to complete. Since the backend code didn't know that the process was shutting down imminently, it would continue by attempting to write out the last known state. Under the right conditions, the process would exit part way through the writing of the state file. Add Stop and Cancel CancelFuncs to the RunningOperation, to allow it to easily differentiate between the two signals. The backend will then be able to detect a shutdown and abort more gracefully. In order to ensure that the backend is not in the process of writing the state out, the command will always attempt to wait for the process to complete after cancellation.	8 years ago
Laura Martin	6e1e614a56	Change -force to -auto-approve when destroying ... Since an early version of Terraform, the `destroy` command has always had the `-force` flag to allow an auto approval of the interactive prompt. 0.11 introduced `-auto-approve` as default to `false` when using the `apply` command. The `-auto-approve` flag was introduced to reduce ambiguity of it's function, but the `-force` flag was never updated for a destroy. People often use wrappers when automating commands in Terraform, and the inconsistency between `apply` and `destroy` means that additional logic must be added to the wrappers to do similar functions. Both commands are more or less able to run with similar syntax, and also heavily share their code. This commit updates the command in `destroy` to use the `-auto-approve` flag making working with the Terraform CLI a more consistent experience. We leave in `-force` in `destroy` for the time-being and flag it as deprecated to ensure a safe switchover period.	8 years ago
James Bardin	a5ed7d0ae4	Merge pull request #17086 from hashicorp/jbardin/GH-17083 ... only split the prefix string once from the s3 key	8 years ago
stack72	e9476c6765	backend/manta: Update manta dependencies ... Internally, triton-go has changed how it handles errors. We can now get rid of checking strings for errors, and we have introduced an errors library that wraps some of the major errors we encounter and test for	8 years ago
Masayuki Morita	f440dba137	Standardize on log level "WARN" rather than "WARNING"	8 years ago
James Bardin	43d000625d	only split the prefix string once from the s3 key ... Ensure that the prefix is only split off a single time when the workspace_key_prefix is a substring of the workspace or key name.	8 years ago
Stefan Schmidt	c200c170ad	Handle refresh errors.	8 years ago
Paddy	e4cdbd6c9f	Merge pull request #16936 from negz/gcskeys ... Support 'customer supplied encryption keys' in the GCS backend	8 years ago
James Bardin	7c703f2ab2	Merge pull request #16932 from rv-jmaggio/master ... Fixing issues with workspace_key_prefix for s3 backend	8 years ago
James Bardin	dd5882e5b2	Merge pull request #16992 from hashicorp/jbardin/go1.10-prep ... go1.10 prep	8 years ago
goraxe	fb6b349e58	backend/s3: Allow forcing use of the S3 path-style API ... This is useful when the underlying API is an S3-workalike service, rather than official S3.	8 years ago
Paul Stack	191cf283d5	backend/manta: Support Triton RBAC ... Triton Manta allows an account other than the main triton account to be used via RBAC. Here we expose the SDC_USER / TRITON_USER options to the backend so that a user can be specified.	8 years ago
James Bardin	4b49a323c3	go fmt ... slight change to go fmt coming in 0.10	8 years ago
rv-jmaggio	b313ce80c4	Changing prefix for empty workspace prefix	8 years ago
Henry Bell	56357c0ab7	Fix typo ('depracted' -> 'deprecated')	8 years ago
rv-jmaggio	bef64cfe91	Fixing implementation for empty string and making acceptance test work	8 years ago
rv-jmaggio	b02a1c8a46	clarifying tests and using SplitN in implementation	8 years ago
Nic Cope	011841124b	Support 'customer supplied encryption keys' in the GCS backend ... https://cloud.google.com/storage/docs/encryption#customer-supplied GCS state created using customer supplied encryption keys can only be read or modified using the same key.	8 years ago
rv-jmaggio	7f8d686074	refactor and add a test	8 years ago
rv-jmaggio	0889c118a8	Fixing issues with workspace_key_prefix	8 years ago
Rob Campbell	5daeee5f6d	Update various files for new version of "stringer" ... The latest version of stringer now uses strconv instead of fmt.	8 years ago
James Bardin	52eced589f	accept a path or contents for credentials ... Match the operation of the google provider, by accepting either a file path or contents for both `credentials` and `GOOGLE_CREDENTIALS`	8 years ago
James Bardin	2932203492	verify that a state can be read even when locked ... This should only happen when a state is loaded via the backend, as well as a remote state.	8 years ago
James Bardin	9dea2f78d4	create unique buckets for each test, and clean up ... This creates a unique bucket name for each test, so that the tests in parallel don't collide, and buckets left over from interrupted tests don't cause future failures. Also make sure that buckets are removed, regardless of content.	8 years ago
James Bardin	aec45e6967	backends should never create unmanaged resources ... The backend was creating bucket named in the configuration if it didn't exist. We don't allow other backends to do this, because these are not managed resources that terraform can control.	8 years ago
Kaveh Mousavi Zamani	7507e3cd21	backend/gcs: fix locking issue when used with terraform_remote_state ... Previously there was a problem with double-locking when using the GCS backend with the terraform_remote_state data source. Here we adjust the locking methodology to avoid that problem.	8 years ago
James Bardin	12b7dac124	Merge pull request #16833 from hashicorp/jbardin/plan-shutdown ... Fully enable shutdown for plan and refresh in the local backend	9 years ago
Sander van Harmelen	aaedf255c3	backend/s3: allow skipping the region check (#16757) ... Without the possibility to skip this check, it’s not possible to use a custom region with a third-party service that mimicks the S3 API.	9 years ago
James Bardin	85295e5c23	watch for cancellation in plan and refresh ... Cancellation in the local backend was only implemented for apply.	9 years ago
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods ... Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	9 years ago
James Bardin	00b7715710	Merge pull request #16586 from hashicorp/jbardin/providers ... Store resolved providers in state	9 years ago
Nic Cope	27ba7de77d	backend/gcs: automatically add trailing slash to prefix ... The backend doesn't function correctly if a trailing slash is not present, due to how workspaces are enumerated.	9 years ago
James Bardin	09180a10ff	cannot destroy without a config	9 years ago
James Bardin	d62e9217ae	update test state strings for backend/local	9 years ago
Malik Bougacha	ed0d57d1b7	Get the enviroment from the environment variable (#16326) ... * Get the enviroment from the enviroment variable * typo	9 years ago
stack72	1fd0f803e4	Migrate Manta Remote state to be a backend ... This PR changes manta from being a legacy remote state client to a new backend type. This also includes creating a simple lock within manta This PR also unifies the way the triton client is configured (the schema) and also uses the same env vars to set the backend up It is important to note that if the remote state path does not exist, then the backend will create that path. This means the user doesn't need to fall into a chicken and egg situation of creating the directory in advance before interacting with it	9 years ago
James Bardin	cf54ca3b0f	update tests for new consul packages ... Reuse the running consul server for all tests. Update the lostLockConnection package, since the api client should no longer lose a lock immediately on network errors.	9 years ago
James Bardin	3a03d3683e	update consul api packages ... This is from a commit just after the v1.0.0 release, because it removes the Porter service dependency for tests. The client api package was not changed.	9 years ago
Martin Atkins	671aace8ec	backend/local: disable local backup of remote state ... Previously we forced all remote state backends to be wrapped in a BackupState wrapper that generates a local "terraform.tfstate.backup" file before updating the remote state. This backup mechanism was motivated by allowing users to recover a previous state if user error caused an undesirable change such as loss of the record of one or more resources. However, it also has the downside of flushing a possibly-sensitive state to local disk in a location where users may not realize its purpose and accidentally check it into version control. Those using remote state would generally prefer that state never be flushed to local disk at all. The use-case of recovering older states can be dealt with for remote backends by selecting a backend that has preservation of older versions as a first-class feature, such as S3 versioning or Terraform Enterprise's first-class historical state versioning mechanism. There remains still one case where state can be flushed to local disk: if a write to the remote backend fails during "terraform apply" then we will still create the "errored.tfstate" file to allow the user to recover. This seems like a reasonable compromise because this is done only in an _exceptional_ case, and the console output makes it very clear that this file has been created. Fixes #15339.	9 years ago
James Bardin	55089e472d	Merge pull request #16484 from hashicorp/f-gcloud-backend ... Convert gcloud backend	9 years ago
Florian Forster	afa13a3d8e	backend/remote-state/gcs: Move toBucketName to the tests.	9 years ago
Florian Forster	3023ae2813	backend/remote-state/gcs: Include project ID in bucket names when testing. ... Since bucket names must be *globally* unique. By including the project ID in the bucket name we ensure that people don't step on each other's feet when testing.	9 years ago
Florian Forster	dcb84ee2c2	backend/remote-state/gcs: Sanitize bucket names.	9 years ago
Florian Forster	454d6bbe2a	backend/remote-state/gcs: Delete test buckets after tests complete. ... This way tests clean up after themselves and don't leak buckets.	9 years ago
Florian Forster	a6669c9e99	backend/remote-state/gcs: Don't enable versioning on new buckets. ... Enabling versioning without setting up lifecycle management leads to every lock file being archived, slowly accruing useless data.	9 years ago
Florian Forster	a84823f597	backend/remote-state/gcs: Require TF_ACC for tests using the network.	9 years ago
Florian Forster	72ccf22a92	backend/remote-state/gcs: Implement additional tests. ... This calls backend.TestBackend() and remote.TestRemoteLocks() for standardized acceptance tests. It removes custom listing tests since those are performed by backend.TestBackend(), too. Since each tests uses its own bucket, all tests can be run in parallel.	9 years ago
Florian Forster	927085289d	backend/remote-state/gcs: Implement the "region" config option. ... This allows to select the region in which a bucket is created. This copies behavior from the Google Cloud provider.	9 years ago
Florian Forster	9583d0945c	backend/remote-state/gcs: Add support for the GOOGLE_PROJECT environment variable. ... This copies behavior from the Google Cloud provider.	9 years ago
Florian Forster	37dc95158d	backend/remote-state/gcs: Enable versioning on automatically created buckets.	9 years ago
Florian Forster	df386d3133	backend/remote-state/gcs: Automatically create the bucket if needed. ... This resurrects the previously documented but unused "project" option. This option is required to create buckets (so they are associated with the right cloud project) but not to access the buckets later on (because their names are globally unique).	9 years ago
Florian Forster	14263223e7	backend/remote-state/gcs: Simplify initialization of the GCS client. ... This also implements the (already documented) behavior of checking the GOOGLE_CREDENTIALS environment variable.	9 years ago
Florian Forster	816c98f387	backend/remote-state/gcs: Read credentials with ioutil.ReadFile(). ... We never expect the raw JSON to appear in the config, so pathorcontents is not the right package here.	9 years ago
Florian Forster	c00e929ee5	backend/remote-state/gcs: Mark the "path" option as deprecated.	9 years ago
Florian Forster	91b1a39a40	backend/remote-state/gcs: Implement an end-to-end test. ... The code is loosely based on state/remote/gcs_test.go. If the GOOGLE_PROJECT environment variable is set, this test will 1) create a new bucket; error out if the bucket already exists. 2) create a new state 3) list states and ensure that the newly created state is listed 4) ensure that an object with the expected name exists 5) rum "state/remote".TestClient() 6) delete the state The bucket is deleted when the test exits, though this may fail if the bucket it not empty.	9 years ago
Florian Forster	14bfbf0617	backend/remote-state/gcs: Document the "prefix" option. ... "state_dir" has been renamed to "prefix" to better fix the GCS terminology.	9 years ago
Florian Forster	c054bd0939	backend/remote-state/gcs: Rename "gcloud" to "gcs" for backwards compatibility.	9 years ago
Florian Forster	93a55f15e9	backend/remote-state/gcloud: Add test for Backend.{state,lock}File().	9 years ago
Florian Forster	5a4e2076e9	backend/remote-state/gcloud: Add the "path" config option. ... This config option was used by the legacy "gcs" client. If set, we're using it for the default state -- all other states still use the "state_dir" setting.	9 years ago
Florian Forster	f80b872bc3	backend/remote-state/gcloud: Unify on the "context" package. ... We don't need to use the legacy package here.	9 years ago
Florian Forster	5d4e25ada4	backend/remote-state/gcloud: Make gcsBackend private. ... This class is only used via the "backend".Backend interface, so there is no need to export this type beyond the gcloud package.	9 years ago
Florian Forster	9ec39573ee	backend/remote-state/gcloud: Make remoteClient private. ... This class is only used via the "state/remote".State interface, so there is no need to export this type beyond the gcloud package.	9 years ago
Florian Forster	42e8441a2b	backend/remote-state/gcloud: Refactor Backend.State(). ... Fixes: * https://github.com/golang/go/wiki/CodeReviewComments#doc-comments * https://github.com/golang/go/wiki/CodeReviewComments#error-strings * https://github.com/golang/go/wiki/CodeReviewComments#initialisms	9 years ago
Florian Forster	5cb574035a	backend/remote-state/gcloud: Refactor Backend.remoteClient(). ... This replaces stateFileName() and lockFileName() with path.Join(). Fixes: * https://github.com/golang/go/wiki/CodeReviewComments#doc-comments * https://github.com/golang/go/wiki/CodeReviewComments#doc-comments	9 years ago
Florian Forster	9ae45e320f	backend/remote-state/gcloud: Refactor Backend.DeleteState(). ... Fixes: * https://github.com/golang/go/wiki/CodeReviewComments#doc-comments * https://github.com/golang/go/wiki/CodeReviewComments#error-strings	9 years ago
Florian Forster	fabba5c0c8	backend/remote-state/gcloud: Refactor Backend.States(). ... The previous code listed all objects in the bucket and used local filtering (using regular expressions) to find .tfstate objects. This new code sets the delimiter to "/", which causes GCS to only return objects directly in the given prefix, but not any sub"directories". Fixes: * https://github.com/golang/go/wiki/CodeReviewComments#doc-comments * https://github.com/golang/go/wiki/CodeReviewComments#error-strings	9 years ago
Florian Forster	97e1aa7ce9	backend/remote-state/gcloud: Use the lock file's generation as lock ID. ... This allows Unlock() to call Delete() without reading the lock file's content first.	9 years ago
Florian Forster	edf2096e28	backend/remote-state/gcloud: Use the context provided to configure(). ... Calling context.Background() from outside the main() function is discouraged. The configure functions are only called from "…/helper/schema".Backend.Configure which provides the Background context, i.e. a long-living context we can use for backend communication.	9 years ago
Florian Forster	2e5fca78c2	backend/remote-state/gcloud: Coding style changes. ... Refactorings to make the code more idiomatic.	9 years ago
Florian Forster	f33005faba	backend/remote-state/gcloud: Handle errors returned by Write(), too. ... Many GCS errors are returned by Close(), but not all.	9 years ago
Florian Forster	1ee194986d	backend/remote-state/gcloud: Add the RemoteClient.{state,lock}File() methods.	9 years ago
Florian Forster	e54d36b489	backend/remote-state/gcloud: Sort standard library imports before other imports.	9 years ago
Florian Forster	52ac764036	backend/remote-state/gcloud: Rename Url -> URL	9 years ago
Florian Forster	5313e15e07	backend/remote-state/gcloud: Move the definition of the Backend struct.	9 years ago
Florian Forster	def3279ec7	backend/remote-state/gcloud: Use package provided OAuth scope.	9 years ago
Piotrek Bzdyl	5854373018	Implemented GCloud backend supporting remote locking and multiple workspaces.	9 years ago
James Bardin	b040cd0837	dynamoDB reads are not fully consisten by default ... Use fully consistent reads for backend operations.	9 years ago
James Bardin	31912956ce	Merge pull request #16290 from hashicorp/jbardin/s3-errors ... retry on s3 state upload errors	9 years ago
James Bardin	611b1ced59	retry on s3 state upload errors ... While #16243 added the ability to retry getting a state from S3, Put can return the same InternalError status. Use the same retry logic when uploading state to S3.	9 years ago
James Bardin	f5e9a20c66	reset testLockHook	9 years ago
James Bardin	25a8227291	add broken test for lock lost on connection error ... Add a way to inject network errors by setting an immediate deadline on open consul connections. The consul client currently doesn't retry on some errors, and will force us to lose our lock. Once the consul api client is fixed, this test will fail.	9 years ago
James Bardin	fd9adcdb36	only init one consul client, and lower keepalive ... The consul Client is analogous to an http.Client, and we really don't need more than 1. Configure a single client and store it in the backend. Replace the default Transport's Dialer to reduce the KeepAlive setting from 30s to 17s. This avoids racing with the common network timeout value of 30s, and is also coprime to other common intervals.	9 years ago
James Bardin	d0ecb232ae	record consul session ID in lock info ... This can help correlate TF and consul logs	9 years ago
James Bardin	b20ab9f0bb	Merge pull request #16243 from hashicorp/jbardin/s3-errors ... retry on s3 backend internal errors	9 years ago
bclodius	fba02f0bea	retry on s3 backend internal errors ... Internal errors from S3 are usually transient, and can be immediately retried. Make 2 attempts at retreiving the state object before returning an error.	9 years ago
James Bardin	91442b7146	Merge pull request #15680 from brunomcustodio/etcdv3-backend ... [WIP] etcd v3 backend with lock support.	9 years ago
James Bardin	d477d1f6d4	Merge pull request #15553 from bonifaido/custom_s3_backend ... Allow non-AWS S3 backends	9 years ago
James Bardin	e0ee1e4d6e	Merge pull request #16070 from octo/defaultdatadir ... backend/local: Remove unused const DefaultDataDir.	9 years ago
Martin Atkins	0fe43c8977	cli: allow disabling "next steps" message in terraform plan ... In #15884 we adjusted the plan output to give an explicit command to run to apply a plan, whereas before this command was just alluded to in the prose. Since releasing that, we've got good feedback that it's confusing to include such instructions when Terraform is running in a workflow automation tool, because such tools usually abstract away exactly what commands are run and require users to take different actions to proceed through the workflow. To accommodate such environments while retaining helpful messages for normal CLI usage, here we introduce a new environment variable TF_IN_AUTOMATION which, when set to a non-empty value, is a hint to Terraform that it isn't being run in an interactive command shell and it should thus tone down the "next steps" messaging. The documentation for this setting is included as part of the "...in automation" guide since it's not generally useful in other cases. We also intentionally disclaim comprehensive support for this since we want to avoid creating an extreme number of "if running in automation..." codepaths that would increase the testing matrix and hurt maintainability. The focus is specifically on the output of the three commands we give in the automation guide, which at present means the following two situations: * "terraform init" does not include the final paragraphs that suggest running "terraform plan" and tell you in what situations you might need to re-run "terraform init". * "terraform plan" does not include the final paragraphs that either warn about not specifying "-out=..." or instruct to run "terraform apply" with the generated plan file.	9 years ago
Florian Forster	ce85600cd4	backend/local: Remove unused const DefaultDataDir. ... Not to be confused with the const of the same name in the "command" package.	9 years ago
Bruno Miguel Custodio	524c3934c6	Add TLS support.	9 years ago
Bruno Miguel Custodio	c8ff10f603	Reuse 'etcd' client.	9 years ago
Bruno Miguel Custodio	6daf1d9d84	Allow for username and password to be read from envvars.	9 years ago
Bruno Miguel Custodio	8f7b315037	Add documentation.	9 years ago
Bruno Miguel Custodio	54dc50ec5c	Cleanup 'etcd' after every test.	9 years ago
Bruno Miguel Custodio	3c21b9c56f	Get rid of 'keyEnvPrefix'.	9 years ago
Bruno Miguel Custodio	6570948bea	Fixing the test suite.	9 years ago
Bruno Miguel Custodio	038f5eb638	Remove 'lockSuffix' as not needed in 'etcd' v3.	9 years ago
Bruno Miguel Custodio	bb4dec6032	Make sure we don't relock.	9 years ago
Bruno Miguel Custodio	b8f4f6d3e2	Delete lock info when unlocking.	9 years ago
Bruno Miguel Custodio	b896348230	Sort the result of 'Backend.States()'.	9 years ago
Bruno Miguel Custodio	70aad79b6e	Make 'endpoints' a schema.TypeList.	9 years ago
Bruno Miguel Custodio	fee5cabeda	Make 'gofmt' happy.	9 years ago
Bruno Miguel Custodio	52c97e9fc9	First steps towards an 'etcdv3' backend.	9 years ago
tombuildsstuff	d074b0da29	Obtaining the current metadata before setting it	9 years ago
tombuildsstuff	a10d23dd95	Removing dead code	9 years ago
Minkyu Kim	f12a237747	Fix crash when using consul backend	9 years ago
Martin Atkins	83414beb8f	command: various adjustments to the diff presentation ... The previous diff presentation was rather "wordy", and not very friendly to those who can't see color either because they have color-blindness or because they don't have a color-supporting terminal. This new presentation uses the actual symbols used in the plan output and tries to be more concise. It also uses some framing characters to try to separate the different stages of "terraform plan" to make it easier to visually navigate. The apply command also adopts this new plan presentation, in preparation for "terraform apply" (with interactive plan confirmation) becoming the primary, safe workflow in the next major release. Finally, we standardize on the terminology "perform" and "actions" rather than "execute" and "changes" to reflect the fact that reading is now an action and that isn't actually a _change_.	9 years ago
Martin Atkins	3ea159297c	command/format: improve consistency of plan results ... Previously the rendered plan output was constructed directly from the core plan and then annotated with counts derived from the count hook. At various places we applied little adjustments to deal with the fact that the user-facing diff model is not identical to the internal diff model, including the special handling of data source reads and destroys. Since this logic was just muddled into the rendering code, it behaved inconsistently with the tally of adds, updates and deletes. This change reworks the plan formatter so that it happens in two stages: - First, we produce a specialized Plan object that is tailored for use in the UI. This applies all the relevant logic to transform the physical model into the user model. - Second, we do a straightforward visual rendering of the display-oriented plan object. For the moment this is slightly overkill since there's only one rendering path, but it does give us the benefit of letting the counts be derived from the same data as the full detailed diff, ensuring that they'll stay consistent. Later we may choose to have other UIs for plans, such as a machine-readable output intended to drive a web UI. In that case, we'd want the web UI to consume a serialization of the _display-oriented_ plan so that it doesn't need to re-implement all of these UI special cases. This introduces to core a new diff action type for "refresh". Currently this is used _only_ in the UI layer, to represent data source reads. Later it would be good to use this type for the core diff as well, to improve consistency, but that is left for another day to keep this change focused on the UI.	9 years ago
James Bardin	76eb65c911	Fix crash in consul backend ... A TLS config was being assigned to a Transport in a nil http.Client. The Transport is built in the consul config by default, but the http.Client is not built until later in NewClient.	9 years ago
Martin Atkins	c12d64f340	Use t.Helper() in our test helpers ... Go 1.9 adds this new function which, when called, marks the caller as being a "helper function". Helper function stack frames are then skipped when trying to find a line of test code to blame for a test failure, so that the code in the main test function appears in the test failure output rather than a line within the helper function itself. This covers many -- but probaly not all -- of our test helpers across various packages.	9 years ago
Loïc Albertin	21b287e919	backend/consul: allow specifying various Consul client security options ... These new options are equivalent to the consul CLI arguments -ca-file, -client-cert and -client-key.	9 years ago
James Bardin	5d50e764ea	deprecate the "azure" backend name ... Alert users to use the current "azurerm" naming.	9 years ago
James Bardin	0e873d70ed	Merge pull request #15840 from hashicorp/jbardin/deprecate-backend ... add the ability to mark a backend as deprecated	9 years ago
James Bardin	cc454fcc56	add the ability to mark a backend as deprecated ... This is a simple wrapper to allow a backend to be marked as deprecated during initialization.	9 years ago
Peter McAtominey	b74b26bcfa	backend: alias azurerm to azure	9 years ago
Peter McAtominey	6b9b5ec297	backend/azure: update to latest SDK	9 years ago
Peter McAtominey	f9e8e54835	backend: convert Azure remote state to a backend ... Added locking support via blob leasing (requires that an empty state is created before any lock can be acquired. Added support for "environments" in much the same way as the S3 backend.	9 years ago
James Bardin	2bb5007690	Merge pull request #15683 from hashicorp/jbardin/remote-state-lineage ... Remove strict lineage check in remote.State	9 years ago
James Bardin	4c7cd549cd	don't allow leading slashes in s3 remote state key ... S3 accepts objects with a leading slash and strips them off. This works fine except in our workspace hierarchy, which then can no longer find suffixes matching the full key name.	9 years ago
James Bardin	dc30761497	Merge pull request #15567 from hashicorp/jbardin/consul-update ... Update consul vendor and remote state	9 years ago
James Bardin	c3e943bed2	add another failing test for remote.State lineage ... Want to make sure we don't hit this again.	9 years ago
James Bardin	18d71f273e	make inmem behave more like remote backends ... When remote backend imeplemtations create a new named state, they may need to acquire a lock and/or save an actual empty state to the backend. Copy this behavior in the inmem backend for testing.	9 years ago
James Bardin	5deef9621d	export Reset() ... This package is used for testing, so there needs to be an easy method for reinitializing the stored data between tests.	9 years ago
James Bardin	ac60ddcd40	Support named states in inmeme backend ... Used to expand test coverage	9 years ago
James Bardin	1070d04b07	Remove consul context adapter for RenewPeriodic ... Updated the vendored consul which no longer requires the channel adapter to convert a `chan stuct{}` to a `<-chan struct{}`. Call testutil.NewTestServerConfigT with the new signature.	9 years ago
James Bardin	9a7ffbfb1b	Merge pull request #15566 from hashicorp/jbardin/state-serial ... Add warning to mismatched plan state	9 years ago
James Bardin	dd9a54c661	Merge pull request #15435 from hashicorp/jbardin/state-path-message ... only show state path help if state is local	9 years ago
James Bardin	50f412bff4	Merge pull request #15557 from hashicorp/jbardin/consul-lock-sessions ... have the consul client manage the lock session	9 years ago
James Bardin	a1727ec4c2	Add warning to mismatched plan state ... Forward-port the plan state check from the 0.9 series. 0.10 has improved the serial handling for the state, so this adds relevant comments and some more test coverage for the case of an incrementing serial during apply.	9 years ago
James Bardin	bcb11f6d89	have the consul client manage the lock session ... When a consul lock is lost, there is a possibility that the associated session is still active. Most commonly, the long request to watch the lock key may error out, while the session is continually refreshed at a rate of TTL/2. First have the lock monitor retry the lock internally for at least 10 seconds (5 attempts with the default 2 second wait time). In most cases this will reconnect on the first try, keeping the lock channel open. If the consul lock can't recover itself, then cancel the session as soon as possible (terminating the PreiodicRenew will call Session.Destroy), and start over. In the worse case, the consul agents were split, and the session still exists on the leader so we may need to wait for the old session TTL, plus the LockWait time to renew the lock. We use a Context for the cancellation channels here, because that removes the need to worry about double-closes and nil channels. It requires an awkward adapter goroutine for now to convert the Done() `<-chan` to a `chan` for PeriodicRenew, but makes the rest of the code safer in the long run.	9 years ago
James Bardin	193d4b868c	backend state tests must honor lineage ... Remote state implementations may initialize a lineage when creating a new named state (i.e. "workspace"). The tests were ignoring that initial lineage to write a new state to the backend.	9 years ago
Nandor Kracser	f6c77339f2	Allow non-AWS S3 backends ... This commit makes sts, metadata and other AWS related API calls optional, thus the backend initialization will not send non-AWS API tokens to AWS APIs	9 years ago
James Bardin	3fb76f3ebb	only show state path help if state is local	9 years ago
James Bardin	5066fa2151	Merge pull request #13871 from fatmcgav/swift_move_to_backend ... Move Swift remote state to backend	9 years ago
Martin Atkins	6afa72f6ca	command: minor adjustments to the -auto-approve=false UX ... Some tweaks to the messaging and presentation.	9 years ago
David Glasser	14af879fe0	command: also print plan for destroy	9 years ago
David Glasser	039d36bf91	command: add "apply -auto-approve=false" flag ... A common reason to want to use `terraform plan` is to have a chance to review and confirm a plan before running it. If in fact that is the only reason you are running plan, this new `terraform apply -auto-approve=false` flag provides an easier alternative to P=$(mktemp -t plan) terraform refresh terraform plan -refresh=false -out=$P terraform apply $P rm $P The flag defaults to true for now, but in a future version of Terraform it will default to false.	9 years ago
Martin Atkins	45a4ba1ea7	Merge #15344: Avoid double-counting resources to create	9 years ago
James Bardin	42cbb716b7	Merge pull request #15370 from rowleyaj/s3_backend_workspaces ... Add configurable workspace prefix for S3 Backend	9 years ago
Alex Rowley	2dd464cf8f	Clarify field description	9 years ago
Chris Marchesi	5654a676d9	core: Skip diff hooks for stubs on eval altogether ... Rather than overloading InstanceDiff with a "Stub" attribute that is going to be largely meaningless, we are just going to skip pre/post-diff hooks altogether. This is under the notion that we will eventually not need to "stub" a diff for scale-out, stateless nodes on refresh at all, so diff behaviour won't be necessary at that point, so we should not assume that hooks will run at this stage anyway. Also as part of this removed the CountHook test that is now failing because CountHook is out of scope of the new behaviour.	9 years ago
Chris Marchesi	50cd33f781	core: Move Refreh/Plan diff count to general operation test ... We are changing the behaviour of the "stub" diff operation to just have the pre/post-diff hooks skipped on eval, meaning that the test against CountHook will ultimately be meaningless and fail, hence we need a different test here that tests it on a more general level.	9 years ago
James Bardin	1fa7667ad4	s3 backend should use Client.Delete to DeleteState ... The s3.Backend was using it's own code for DeleteState, but the dynamo entries are only handled through the RemoteClient. Have DeleteState use a RemoteClient for delete.	9 years ago
James Bardin	ebf4413e95	add named named state delete+create-delete test ... This ensures that we don't leave any conflicting state artifacts preventing the recreation of a named state.	9 years ago
James Bardin	ac937a890d	improve plugin reinit error text	9 years ago
James Bardin	7a955f990c	make display plugin checksum error to user ... The error follows a generic message, so can be ignored by users who may not understand the implications.	9 years ago
Alex Rowley	db40dc06ab	Add configurable workspace prefix for S3 Backend ... Fixes #13184	9 years ago
James Bardin	5be15ed77c	have the local backend provide a plugin init msg ... During plan and apply, because the provider constraints need to be built from a plan, they are not checked until the terraform.Context is created. Since the context is always requested by the backend during the Operation, the backend needs to be responsible for generating contextual error messages for the user. Instead of formatting the ResolveProviders errors during NewContext, return a special error type, ResourceProviderError to signal that init will be required. The backend can then extract and format the errors.	9 years ago
Chris Marchesi	f249386c8a	core: Test to ensure PostDiff is ignoring stubs ... Added a test that shows that PostDiff is ignoring diffs where the Stub attribute is set.	9 years ago
Chris Marchesi	45528b2217	core: Instance/EvalDiff.Quiet -> Stub ... Changed the language of this field to indicate that this diff is not a "real" diff, in that it should not be acted on, versus a "quiet" mode, which would indicate just simply to act silently.	9 years ago
Chris Marchesi	eef933f2a7	core: Don't count scaled-out resources twice in the UI ... This fixes a bug with the new refresh graph behaviour where a resource was being counted twice in the UI on part of being scaled out: * We are no longer transforming refresh nodes without state to plannable resources (the transformer will be removed shortly) * A Quiet flag has been added to EvalDiff and InstanceDiff - this allows for the flagging of a diff that should not be treated as real diff for purposes of planning * When there is no state for a refresh node now, a new path is taken that is similar to plan, but flags Quiet, and does nothing with the diff afterwards. Tests pending - light testing has confirmed this should fix the double count issue, but we should have some tests to actually confirm the bug.	9 years ago
Gavin Williams	c2550e78cf	Rename openstack provider for swift remote backend	9 years ago