784 Commits (f2bc9164873bdec092456aba719d7e17d10fa342)

Author	SHA1	Message	Date
James Bardin	4883499a89	test non-string env var input variables ... Non-string input variables taken from the environment initially need to be parsed and stored as string, since there is no type associated type information. Make sure these are correctly handled when validated during apply.	1 year ago
Liam Cervante	f1bd8df9b0	jsonplan: sort the relevant attributes in the correct plan (#36093)	1 year ago
Liam Cervante	36d7e8706f	jsonplan: deterministic relevant attribute order (#36076) ... * jsonplan: deterministic relevant attribute order * simplify sort function	1 year ago
Mark DeCrane	b2a90cf587	Testing updates	1 year ago
Mark DeCrane	8d0db63571	Add human view for modules cmd	1 year ago
James Bardin	16fe12ef0b	synchronize schema and test fixture	1 year ago
James Bardin	c1f8152f10	undeclared variables must be allowed during apply ... Plan allows undeclared config variables with only warnings, and that behavior need to be carried forward to apply now that ephemeral variables can be passed in at apply time.	1 year ago
Bruno Schaatsbergen	a5d8673a41	Revert "Merge pull request #35929 from bschaatsbergen/b/fix-retry-messages-in-cloud-backend-json" ... This reverts commit f8cb25a246, reversing changes made to a25831d6ef.	1 year ago
Bruno Schaatsbergen	247302f47d	Merge branch 'main' into b/fix-retry-messages-in-cloud-backend-json	1 year ago
Bruno Schaatsbergen	6b0ba4d20d	refactor: gracefully handle marshalling error with empty output	1 year ago
Bruno Schaatsbergen	b358e333ee	refactor: make methods private	1 year ago
Daniel Schmidt	6f58dbe75c	write-only attributes: emit structural data on schema rendering	1 year ago
Bruno Schaatsbergen	515897a125	copyright: add missing header ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	45c38a6469	Merge branch 'main' into b/fix-retry-messages-in-cloud-backend-json	1 year ago
Bruno Schaatsbergen	ae661f3568	views: add comments for clarity ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	f1428b3388	backend/cloud: expose View to enable reuse in a (cloud) backend ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Daniel Schmidt	90973698bf	Merge branch 'main' into pass-ephemeral-variables-to-terraform-apply	1 year ago
Liam Cervante	eeacced8f0	Add go vet as a check to the Github commit actions (#31461) ... * Add go vet as a check to the Github commit actions * deliberately break to test * fix after successful test * Use directly * fix more errors	1 year ago
James Bardin	896f9e74b6	Merge pull request #35958 from hashicorp/jbardin/uknown-ephemeral-config ... Handle unknown values in ephemeral resource config	1 year ago
Daniel Schmidt	eccf39aa45	ephemeral: support interactive variable input for ephemeral values	1 year ago
Bruno Schaatsbergen	94c732b7a5	views: refactor RetryLog to use an elapsed time ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	93ae38dadf	views: add tests for cloud view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
James Bardin	c2a1070c23	create a ui hook for unknown ephemeral config ... This is a stopgap to give users some feedback when an ephemeral resource contains unknowns and cannot be opened. There is no json hook implementation so that the machine-readable spec is not bound to the new output until further review. It doesn't really fit with the current json ui model to have messages about what isn't going to happen.	1 year ago
Bruno Schaatsbergen	c1999a27ad	Merge branch 'main' into b/fix-retry-messages-in-cloud-backend-json	1 year ago
Daniel Schmidt	2e026dec0f	ephemeral: set ephemeral variables for combined plans as well ... they are by definition the same as in the plan, but there is no reason to skip the validation step	1 year ago
Bruno Schaatsbergen	c71a1a775e	views: refactor retry logic with retryHelper function ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Liam Cervante	7c4aeac5f3	stacks: load credentials from config file on startup (#35952) ... * stacks: load credentials from config file on startup * delete unneeded file	1 year ago
Bruno Schaatsbergen	558aa18be7	Merge branch 'main' into b/fix-retry-messages-in-cloud-backend-json	1 year ago
Bruno Schaatsbergen	ad1f3e0adc	views: add tests for cloud view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	c9f418d853	views: add PrepareMessage to cloud view interface ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Radek Simko	8176657c5b	command/views: Attempt to fix flaky JSON hook test (#35940)	1 year ago
Daniel Schmidt	d550c97553	ephermal: allow setting var and var files for apply	1 year ago
Daniel Schmidt	3207836729	ephemeral: tests for setting unplanned vars during apply	1 year ago
Daniel Schmidt	fa44937977	ephemeral: improve diagnostic message through compactValueStr	1 year ago
Daniel Schmidt	0e632aae86	ephemeral: allow setting non-ephemeral values during apply to same value as in plan	1 year ago
Daniel Schmidt	0a71f24453	disable interactive prompt test for now	1 year ago
Daniel Schmidt	a87b36a1a8	restructure tests	1 year ago
Daniel Schmidt	756a1a74ad	ephemeral: add apply tests	1 year ago
Daniel Schmidt	f4ff263d24	restructure existing test	1 year ago
Bruno Schaatsbergen	6c14e52d8e	test: use Cloud view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	d8bfe7a80b	cloud: Initialize a new cloud view in the backend to render messages based on view type. ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	377c959c33	views: add cloud view ... The cloud view is responsible for rendering messages related to cloud operations, presenting them to the user in either a human-readable format or as JSON output in the terminal. Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	a90930427a	chore: remove the retrylog hook from the init view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	fb878889f2	Merge branch 'main' into b/fix-retry-messages-in-cloud-backend-json	1 year ago
Bruno Schaatsbergen	f9797595e3	chore: initialize new view in meta backend ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Radek Simko	3d4dab01a0	command/views: Attempt to fix flaky hook test (#35927) ... Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>	1 year ago
Bruno Schaatsbergen	f5dc158709	views: render retry messages using the view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	8635cb1cfb	views: move retryLog hook to init view ... The cloud backend includes a retry hook that relies on a go-tfe implementation. Since these retry messages were not rendered through a view, the `-json` flag was not respected, leading to mixed (non-pure JSON) output in the terminal whenever retry messages were printed. Before passing the init view to the cloud backend, we ensure the retryLog hook is included in the init view. Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Radek Simko	0a266c88c4	terraform: Emit lifecycle phases of ephemeral resources to the UI (#35919)	1 year ago
Brandon Croft	c977f90bc3	Merge branch 'main' into brandonc/resource_tags_cloud_block	2 years ago
Brandon Croft	9d0133a541	Fix non-string elements in tags schema	2 years ago
Sebastian Rivera	59cea511dd	Only show referenced entries, add versioning ... This commit makes several modifications to the modules command. It downcases the field names in the resulting JSON string, adds a format version to the result. The result of this command will now only contain entries which have been declared in configuration, as opposed to the internal manifest which shows all installed modules for a working dir.	2 years ago
Sebastian Rivera	3498bc9815	Sort JSON objects before comparing to prevent rc error	2 years ago
Sebastian Rivera	f19d17cee7	Add missing license headers	2 years ago
Sebastian Rivera	a5294c2096	Impl tests for the modules command	2 years ago
Sebastian Rivera	ee1a2a7858	Implement the modules command ... The modules command provides a holistic view of all installed modules for a given root module. It also includes information on whether a installed module is currently referenced by configuration. As of now, this command only supports a machine-readable view format.	2 years ago
Brandon Croft	e87335a972	cloud: Allows object tag schema for selecting kv tagged workspaces ... When key-value tags are enabled and used in the workspace, users may define the tags attribute as a map of strings in the cloud block in order to more precicely match workspaces using those tags.	2 years ago
Bruno Schaatsbergen	098234e244	states: check root output value changes in refresh-only mode (#35812) ... * check root output values when determining plan applicability in refresh mode In refresh-only mode, we do not anticipate proposing any actions; however, a plan is marked as “applyable” if there are changes in the state between runs. Currently, a plan is considered “applyable” only when there are differences in managed resources. This approach seems to overlook changes in root output values. As a result, a plan can be marked as non-applyable, even when there are changes in the root output value, due to the lack of detected changes since only managed resources were checked. * set 'applyable' to true	2 years ago
Daniel Schmidt	b701e152e5	show value is ephemeral in terraform test	2 years ago
Daniel Schmidt	b9f273639d	handle ephemeral and sensitive case in diagnostics	2 years ago
Daniel Schmidt	3e7fdd0de9	improve wording of error message	2 years ago
Daniel Schmidt	ae103fc491	test: emit a nice error message if the user uses ephemeral resource in terrafom test	2 years ago
Daniel Schmidt	97ba67edea	test: ensure ephemeral values are not shown in diagnostics and warning is printed	2 years ago
Daniel Schmidt	725add6a1a	test: pass in variables during apply ... ephemeral variables need to be re-supplied	2 years ago
James Bardin	3a1a9408d9	fix Descendants spelling ... this has proliferated everywhere	2 years ago
Radek Simko	06fd817b7c	Remove handling of ephemeral root outputs (#35809) ... * Remove handling of ephemeral root outputs This is effectively reverting ~99% of https://github.com/hashicorp/terraform/pull/35676 The only changes not being reverted are some formatting and deprecation fixes which remain relevant. The code being removed is basically dead code now in the context of root ephemeral outputs being rejected per https://github.com/hashicorp/terraform/pull/35791 * Remove unrelated changes	2 years ago
Radek Simko	5e1d2303fb	jsonprovider: Expose ephemeral resource schemas (#35800) ... * jsonprovider: Expose ephemeral resource schemas * add ephemeral resource to the test	2 years ago
Daniel Schmidt	fbbf59a685	Merge pull request #35706 from ndouglas/patch-1 ... Fix typo in test.go	2 years ago
James Bardin	2cbb6bf92f	udpate code which was failing staticckeck ... Some updates to staticcheck were catching more errors. Most of these were format functions without a format string, but rather than adding more exceptions I just fixed them all. This did also catch some incorrectly wrapped errors.	2 years ago
Liam Cervante	332757894d	plan renderer: fix crash when updating a null attribute to unknown (#35709)	2 years ago
Liam Cervante	abd6b9ef1b	plan renderer: render unknown nested blocks properly (#35644)	2 years ago
Nate Douglas	df653772e1	Fix typo in test.go	2 years ago
kmoe	a2039517a5	states: store ephemeral output values in memory (#35676) ... Ephemeral root output values must be kept in the in-memory state representation, but not written to the state file. To achieve this, we store ephemeral root outputs separately from non-ephemeral root outputs, so Terraform can access them during a single plan or apply phase. Ephemeral root outputs always have a value of null in the state file. This means that the "terraform output" command, that reads the state file, reports null values for these outputs. Consumers of 'terraform output -json' should use the presence of '"ephemeral": true' in such output to interpret the value correctly.	2 years ago
makx	2a9a8c2aca	show deprecation warning if -state is used with plan, apply, refresh (#35660) ... * show deprecation warning if -state is used with plan, apply, refresh * show deprecation warning if -state is used with plan, apply, refresh * updated -state flag check condition * added better diagnostic details view * resolved failed test * updated the content of the -state flag warning	2 years ago
Radek Simko	91ea2cd6e0	internal/command: Avoid ignoring ephemeralasnull function (#35651)	2 years ago
kmoe	fab3673f8d	lang: stabilise ephemeral values experiment (#35636) ... * lang: stabilise ephemeral values experiment Stabilise the ephemeral values experiment and ephemeralasnull experimental function. * simplify handling of apply time input vars As the final step in stabilising the ephemeral values experiment, we can remove the separate code path for handling input variables supplied via -var and -var-file during apply. The intent here is conveyed in the tests: when applying a saved plan, all ephemeral variables set in the plan (the "apply-time variables"), must be set, and no others. As per the TODO copied from the prototype, there is some more work to be done here in making the handling of undeclared variables during apply as sophisticated as that during plan, emitting helpful warnings (for example) when input variables are supplied unnecessarily via environment variables. * experiments: officially conclude EV experiment --------- Co-authored-by: Radek Simko <radek.simko@gmail.com>	2 years ago
James Bardin	2ffbd0eb4e	remove old refactoring comments	2 years ago
James Bardin	0b8fbfe323	ignore unexported state field in comparison ... and unify the options used to compare changes in tests	2 years ago
James Bardin	16231373a4	update changes in command pkgs	2 years ago
James Bardin	bc750192e4	POC for always using decoded changes in core ... We should not need to encode and decode change values within core, since the encoded version is only technically needed for serialization. This pattern stems from the conversion to current changes system, but back then we did not have easy access to the correct schemas at the time to encode and decode the entire set of changes. Moving the core handling of changes to only use the decoded values will drastically improve evaluation efficiency, removing a round trip through encoded values for every resource reference.	2 years ago
James Bardin	04b442d419	allow slashes in git url parameters ... Git url refs often contain slashes, which were incorrectly being split and appended to the path as a go-getter subdir.	2 years ago
Daniel Schmidt	3b95a5f6b1	fix formatting ... Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	2 years ago
Daniel Schmidt	8e1f02843d	jsonformat: update tests	2 years ago
Daniel Schmidt	b9933789aa	jsonformat: render deferred diff with no current changes message	2 years ago
Daniel Schmidt	c619cd2536	improve wording ... Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	2 years ago
Daniel Schmidt	a00e015e24	jsonformat: render different no changes message on deferred actions	2 years ago
Daniel Schmidt	4afb3b2b48	jsonformat: render deferred actions	2 years ago
Liam Cervante	471bddf3ba	json plan: update resource index and import ids to support unknown values (#35518)	2 years ago
Liam Cervante	4f62fcac53	init: fix invalid + duplicate required provider blocks crashing (#35533)	2 years ago
Liam Cervante	3ce9e517ae	fix flaky test in views package (#35469)	2 years ago
James Bardin	fcfbd85aa5	add suggestion to run `terraform providers` ... On a default provider install failure we can always suggest running `terraform providers` to help in cases where it's not apparent to the user how to proceed. This would most commonly be encountered by conflicting provider requirements, but if we find there are other common situations we may want to generate a more precise error type for better diagnostics.	2 years ago
Niklas Rosenstein	50463774b0	Fix and clarify error message when -plugin-dir can't be saved to workspace directory	2 years ago
Martin Atkins	71d14e78fd	lang: Experimental "ephemeralasnull" function ... This is another part of the existing ephemeral_values experiment, taking a value of any type that might have ephemeral values in it and returning a value of the same type which has any ephemeral value replaced with a null value. The primary purpose of this is to allow a module to conveniently return an object that would normally contain nested ephemeral values -- such as an instance of a managed resource type that has a write-only attribute -- through an output value that isn't declared as ephemeral. This would then expose all of the non-ephemeral parts of the object but withhold the ephemeral parts. In the case of write-only attributes, it exposes the normal attributes while withholding the write-only ones. The name of this function could potentially change before stabilization, because it's quite long and clunky. I did originally consider "nonephemeral" to match with the existing "nonsensitive", but that didn't feel right because "nonsensitive" removes the sensitive mark while preserving the underlying value while this function removes the mark and the real value at the same time. (It would not be appropriate to have a function that just removes the ephemeral mark while preserving the value, because correct handling of ephemerality is important for correctness while sensitivity is primarily a UI concern so we don't need to be quite so picky about it.)	2 years ago
James Bardin	3bf06b18fc	update helptext and docs	2 years ago
James Bardin	3875ea3656	add -lock-file flag to providers mirror command ... The providers mirror command was updated to inspect the lock file, however that was not part of the original intent for the command, and it's possible that the command needs to be run without a lock file. Since we have been honoring the lock file for the past few releases, let's keep that consistent and allow disabling the file with `-lock-file=false`.	2 years ago
James Bardin	e57d8add35	Check lock file diags in mirror command ... The lock file diagnostic were not being checked in the mirror command, so an incomplete or broken lock file might cause the cli to crash.	2 years ago
Martin Atkins	9dd16a7fba	command: "terraform apply" accepts variable values with saved plan ... To support ephemeral values we need a more complicated set of rules about what input variables can and must be set when applying a saved plan. The command itself does not have enough information to implement those rules itself, so we'll let them pass through and check this in the local backend's apply phase instead. The local backend's apply phase already had basic support for dealing with apply-time variable values, but it'll now also be responsible for rejecting attempts to set variables when the experiment isn't enabled, to keep all of this logic in roughly the same place.	2 years ago
Martin Atkins	6f84623cb6	terraform: Initial partial support for ephemeral values ... This is a checkpoint commit on the path to supporting ephemeral values as a cross-cutting concern in the Terraform language. An ephemeral value is one that lives only in RAM during a single phase and so cannot persist from the plan phase to the apply phase, or between consecutive plan/apply rounds. Terraform tracks whether each value is ephemeral using the cty "marks" concept, thus achieving the same dynamic analysis as we already employ for the concept of "sensitive values" that prevents displaying a value in the user interface. This commit is just a starting point which gets some of the basics into place: - input variables and output values can both be statically declared as being ephemeral. Only ephemeral inputs/outputs can have ephemeral values assigned to them, and the recipient of the value sees it as ephemeral even if the assigned value was not already ephemeral. This creates a dynamic analysis cutoff point at module boundaries so that it's possible to determine in isolation whether a single module is using ephemeral values correctly, without having to test it in every possible calling context. - Managed and data resources cannot have ephemeral values assigned into their configurations because Terraform and providers both expect the resource attributes to persist between phases. - Ephemeral values _can_ be used in provider and provisioner configurations, because both of those effectively meet the definition of the new "ephemeral" concept despite it not previously having a name. - Ephemeral markings propagate through all of the built-in language features for dynamic analysis purposes, largely relying on cty's efforts to do that in similar vein as for sensitive marks. In particular, it's possible to define a local value whose expression produces an ephemeral result, and passing ephemeral values to functions should propagate the ephemeral mark to the results when appropriate. (I've not yet thoroughly reviewed all of the built-in functions for correct marks handling though, so there may be some gaps to address in later commits.) The next step for this work will be to change the modules runtime to have support for a workflow involving ephemeral _root_ input variables, where their values must be re-supplied during the apply phase. That will then achieve (in experimental capacity) the first goal of ephemeral values: to be able to provide non-persistent settings such as time-limited API tokens to use in provider configuration blocks.	2 years ago
James Bardin	a38be7d174	Merge pull request #35271 from hashicorp/jbardin/render-uknown-block ... render entirely unknown blocks in the plan output	2 years ago
James Bardin	6b19b9e82a	render entirely unknown blocks in the plan output ... The plan renderer was missing a check for entirely unknown blocks, causing them to be omitted from the human readable output. An unknown block can happen when using an unknown for_each value in a dynamic block assignment.	2 years ago