40 Commits (f1657bb3e35acad90f6aff79110c593b9462cc4d)

Author	SHA1	Message	Date
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods ... Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	9 years ago
James Bardin	b15258dfec	remove provider inheritance from Tree.Load ... Now that resources can be connected to providers with different paths in the core graph, handling the inheritance in config makes less sense. Removing this to make room for core to walk the Tree and connect resources directly to the proper provider instance.	9 years ago
James Bardin	b4e9240679	remove implicit provier tests from config/module ... No longer needed	9 years ago
James Bardin	4e8fe97556	add credentials to module.Storage ... Provide a way to pass in credentials to be used by the module.Storage when contacting registries. Remove the mockTLSServer and use a static discovery map pointing to the http url for tests.	9 years ago
James Bardin	3a495ffe56	rename ModuleStorage to Storage ... get rid of stutter and use module.Storage	9 years ago
James Bardin	36eb40a432	export ModuleStorage and use it for Tree.Load ... Exporting ModuleStorage allows us to explicitly pass in the storgae location rather than extracting it out of the getter.Storage interface, set a UI for communiating actions back to the user, and accepting a services Disco for discovery.	9 years ago
James Bardin	c01dfa7757	failing test for changing intermediate modules ... This test highlights how changing an intermediate source path prevents reloading of submodules. While this is somewhat of an edge case now, it becomes quite common in the cacse where module versions are updated.	9 years ago
James Bardin	1f44fd8eb2	move getStorage to moduleStorage too ... Add a test to ensure we don't store different modules with the same relative path in the same location.	9 years ago
James Bardin	7416e7a6e0	update the module manifest implementation ... The getter.Storage abstraction is proving entirely inadequate here, but we can't replace it wholesale at the moment. The Tree loader needs to know the location of the manifest before it can start loading any modules. Since the version will have to be part of the hashed storage key, there is no way to know what version of each module are stored. The storageDir function will extract the StorageDir field from the underlying FolderStorage instance for the tree to locate the manifest.	9 years ago
James Bardin	283d88551a	Add a new module storage manifest ... To add registry support, a workaround in the local module storage was added to record the subdirectory containing the module source from within the archive file. Here we replace that temporary implementation with the full manifest needed to record the necessary module metadata for module loading. In order to support versioned modules, the actual stored version needs to be recorded. This can't be derived from the configuration, because the configuration only contains the constraints, and at load time we need to be able to enumerate the stored modules and all versions in order to resolve them. While the local storage key will be derived from the source and version, that information is lost once it's hashed. While the entire storage layer could be replaced to encode the needed data in the path itself, this provides a minimal change to work with the existing storage code.	9 years ago
James Bardin	8933ef8f70	make //subdir notation work with registry modules ... Append the original source subdir to the discovered subdir when locating the files in the module tree.	9 years ago
James Bardin	4ab70ba09d	rename confusing test module name	9 years ago
James Bardin	2e505083cd	change ProviderConfig.Scope to Path ... Though it's intended for "interpolation scope", Path is generally used for this elsewhere.	9 years ago
James Bardin	cb0e37a870	implement provider inheritence during loading ... This implements provider inheritance during config loading, rather than during graph evaluation. At this point it's much simpler to find the desired configuration, and once all providers are declared, all the inheritance code in the graph can be removed. The inheritance is dome by simply copying the RawConfig from the parent ProviderConfig into the module. Since this happens before any evaluation, we record the original interpolation scope in the ProviderConfig so that it can be properly resolved later on.	9 years ago
James Bardin	f6e89bb8c3	record the subdirectory in the FolderStorage ... Module detection currently requires calling the registry to determine the subdirectory. Since we're not directly accessing the subdirectory through FolderStorage, and now handling it within terraform so modules can reference sibling paths, we need to call out to the registry every time we load a configuration to verify the subdirectory for the module, which is returned during the Detect. Record the subdirectories for each module in the top-level of the FolderStorage path for retrieval during Tree.Load. This lets us bypass Detection altogether, modules can be loaded without redetecting.	9 years ago
James Bardin	59089ef461	add test loading an archive with `//*` subdir ... The registry uses the `//*` subdir format to unpack github archives. Add a test to cover this pattern.	9 years ago
James Bardin	38569c8508	add tests for get from tar subdir ... Test that we can get a subdirectory from a tarball (or any other "packed" source that we support). The 'tar-subdir-to-parent' test highlights a regression where the subdirectory module references a module in its parent directory. This breaks the intended use ofr the subdirectory and the implementation in go-getter. We need to fix this in terraform, and possible plan warnings and deprecations for this type of source.	9 years ago
Mitchell Hashimoto	68ee4e0480	config/module: don't panic when referencing undefined module ... Fixes #12788 We would panic when referencing an output from an undefined module. The panic above this is correct but in this case Load will not catch interpolated variables that _reference_ an unloaded/undefined module. Test included.	9 years ago
James Bardin	2a949093ed	report all errors from module validation ... It can be tedious fixing a new module with many errors when Terraform only outputs the first random error it encounters. Accumulate all errors from validation, and format them for the user.	9 years ago
Mitchell Hashimoto	095b7e7831	config/module: disallow root modules named "root" ... Fixes #11038 This is a **short term fix**. Terraform core doesn't currently handle root modules named "root" well because the prefix `[]string{"root"}` has special meaning and Terraform core [currently] can't disambiguate between the root module and a module named "root" in the root module. This PR introduces a short term fix by simply disallowing root modules named "root". This shouldn't break any BC because since 0.8.0 this didn't work at all in many broken ways (including crashes). Longer term, this should be fixed by removing the special prefix at all and having empty paths be root. I started down this path but the core changes necessary are far too scary for a patch release. We can aim for 0.9.	9 years ago
Mitchell Hashimoto	0c30caec7d	config: smarter provider alias usage validation ... Fixes #4789 This improves the validation that valid provider aliases are used. Previously, we required that provider aliases be defined in every module they're used. This isn't correct because the alias may be used in a parent module and inherited. This removes that validation and creates the validation that a provider alias must be defined in the used module or _any parent_. This allows inheritance to work properly. We've always had this type of validation for aliases because we believe its a good UX tradeoff: typo-ing an alias is really painful, so we require declaration of alias usage. It may add a small burden to declare, but since relatively few aliases are used, it improves the scenario where a user fat-fingers an alias name.	9 years ago
Mitchell Hashimoto	55ef966b88	config/module: tree.Child on a nil tree works	10 years ago
Mitchell Hashimoto	098225dc0d	config/module: use the raw source as part of the key ... This changes the key for the storage to be the _raw_ source from the module, not the fully expanded source. Example: it'll be a relative path instead of an absolute path. This allows the ".terraform/modules" directory to be portable when moving to other machines. This was a behavior that existed in <= 0.7.2 and was broken with #8398. This amends that and adds a test to verify.	10 years ago
Mitchell Hashimoto	1099e3f59f	config: add module raw configs to InterpolatedConfigs [GH-1448]	11 years ago
Mitchell Hashimoto	f084d8d932	config/module: store the path with the module	11 years ago
Mitchell Hashimoto	2e11ca68df	config/module: go back to the original folder when doing parent ... references	11 years ago
Mitchell Hashimoto	bd4aaac71a	config/module: failing unit test for GH-1232	11 years ago
Mitchell Hashimoto	1e00b4386c	config/module: Child(nil) or empty will return self	12 years ago
Mitchell Hashimoto	267d45df86	config/module: Can look up Child with Tree.Child	12 years ago
Mitchell Hashimoto	7aa30fdf25	config: support subdirectories with the "//" syntax	12 years ago
Mitchell Hashimoto	1ef167602e	config/module: validate that required parameters are passed through	12 years ago
Mitchell Hashimoto	97da02c368	config/module: proper name for root	12 years ago
Mitchell Hashimoto	7bbf6a0d3a	config/module: NewTreeModule is easier to use	12 years ago
Mitchell Hashimoto	292f57ea0a	config/module: validate outputs line up with ModuleVariables	12 years ago
Mitchell Hashimoto	12e7c75211	config/module: validate that parameters into modules valid	12 years ago
Mitchell Hashimoto	2419bf79f2	config/module: error if duplicate module	12 years ago
Mitchell Hashimoto	c9fd910c41	config/module: Validate	12 years ago
Mitchell Hashimoto	30b76ef820	config/module: tree.String()	12 years ago
Mitchell Hashimoto	a35a9262d4	config/module: detectors, some more work on Tree	12 years ago
Mitchell Hashimoto	799ffbb3ac	config/module: tree.Modules()	12 years ago